Re: [libvirt] [RFC PATCH 0/5] Support online resizing of block devices.
On Mon, Nov 28, 2011 at 02:24:52PM -0700, Eric Blake wrote: > On 07/25/2011 11:51 PM, Osier Yang wrote: > > This patch series introduce new API "virDomainBlockResize" to expose > > qemu monitor command "block_size", which is for resizing the a block > > device while the domain is running. > > > > The prototype for the new API is: > > > > int > > virDomainBlockResize (virDomainPtr dom, > > const char *path, > > unsigned long long size, > > unsigned int flags) > > While looking through old mails, I noticed this had never been applied. > Is it something you could revive and rebase to the latest libvirt.git? IIRC, at the time the blocker was a question mark over the impl of the underlying QEMU command. We have since resolved the QEMU issue, so there's no reason not to apply this now. Daniel -- |: http://berrange.com -o-http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [RFC PATCH 0/5] Support online resizing of block devices.
On 07/25/2011 11:51 PM, Osier Yang wrote: > This patch series introduce new API "virDomainBlockResize" to expose > qemu monitor command "block_size", which is for resizing the a block > device while the domain is running. > > The prototype for the new API is: > > int > virDomainBlockResize (virDomainPtr dom, > const char *path, > unsigned long long size, > unsigned int flags) While looking through old mails, I noticed this had never been applied. Is it something you could revive and rebase to the latest libvirt.git? -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [RFC PATCH 0/5] Support online resizing of block devices.
On 07/25/2011 11:51 PM, Osier Yang wrote: This patch series introduce new API "virDomainBlockResize" to expose qemu monitor command "block_size", which is for resizing the a block device while the domain is running. The prototype for the new API is: int virDomainBlockResize (virDomainPtr dom, const char *path, unsigned long long size, unsigned int flags) Sounds nice, but it missed the rc1 freeze. This will have to wait for 0.9.5. -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt virtualization library http://libvirt.org -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
[libvirt] [RFC PATCH 0/5] Support online resizing of block devices.
This patch series introduce new API "virDomainBlockResize" to expose qemu monitor command "block_size", which is for resizing the a block device while the domain is running. The prototype for the new API is: int virDomainBlockResize (virDomainPtr dom, const char *path, unsigned long long size, unsigned int flags) * "@path" is the absolute path of the block device, which can be extraced from domain xml. * The units for "@size" is kilobytes, which might be not quite properly. (qemu HMP uses Megabytes as the default units, QMP uses Bytes as the default units, so it means we need to divice "@size" by 1024 for HMP, and multiply "@size" by 1024 for QMP. On the other hand, we need to check the overflowing). Any ideas on this is welcomed. * "@flags" is unused currently. [PATCH 1/5] block_resize: Define the new API [PATCH 2/5] block_resize: Wire up the remote protocol [PATCH 3/5] block_resize: Implement qemu monitor functions [PATCH 4/5] block_resize: Implement qemu driver method [PATCH 5/5] block_resize: Expose the new API to virsh -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
