Re: [libvirt] ESX [11/12]: Reorder some function calls to avoid potential virDomainPtr leaks

2009-09-14 Thread Daniel Veillard 
On Mon, Sep 14, 2009 at 02:45:34AM +0200, Matthias Bolte wrote:
> * src/esx/esx_driver.c: avoid potential virDomainPtr leaks

> diff --git a/src/esx/esx_driver.c b/src/esx/esx_driver.c
> index 5a93d1f..91de407 100644
> --- a/src/esx/esx_driver.c
> +++ b/src/esx/esx_driver.c

  Okay, that's clearly a bug fix applying to current code, so commited
  now,

thanks !

Daniel

-- 
Daniel Veillard  | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
dan...@veillard.com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/

--
Libvir-list mailing list
Libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] ESX [11/12]: Reorder some function calls to avoid potential virDomainPtr leaks

2009-09-13 Thread Matthias Bolte 
* src/esx/esx_driver.c: avoid potential virDomainPtr leaks
diff --git a/src/esx/esx_driver.c b/src/esx/esx_driver.c
index 5a93d1f..91de407 100644
--- a/src/esx/esx_driver.c
+++ b/src/esx/esx_driver.c
@@ -1200,14 +1200,14 @@ esxDomainLookupByUUID(virConnectPtr conn, const unsigned char *uuid)
 continue;
 }
 
-domain = virGetDomain(conn, name_candidate, uuid_candidate);
-
-if (domain == NULL) {
+if (esxVI_GetVirtualMachinePowerState(conn, virtualMachine,
+  &powerState) < 0) {
 goto failure;
 }
 
-if (esxVI_GetVirtualMachinePowerState(conn, virtualMachine,
-  &powerState) < 0) {
+domain = virGetDomain(conn, name_candidate, uuid_candidate);
+
+if (domain == NULL) {
 goto failure;
 }
 
@@ -1291,14 +1291,14 @@ esxDomainLookupByName(virConnectPtr conn, const char *name)
 continue;
 }
 
-domain = virGetDomain(conn, name_candidate, uuid_candidate);
-
-if (domain == NULL) {
+if (esxVI_GetVirtualMachinePowerState(conn, virtualMachine,
+  &powerState) < 0) {
 goto failure;
 }
 
-if (esxVI_GetVirtualMachinePowerState(conn, virtualMachine,
-  &powerState) < 0) {
+domain = virGetDomain(conn, name_candidate, uuid_candidate);
+
+if (domain == NULL) {
 goto failure;
 }
 
--
Libvir-list mailing list
Libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list