Re: [libvirt] Re: [PATCH 05/12] Domain Events - Driver API

2008-10-23 Thread Daniel P. Berrange
On Tue, Oct 21, 2008 at 03:15:19PM -0400, Ben Guthro wrote:
> [PATCH 05/12] Domain Events - Driver API
> Additions to the driver API

ACK


Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org   -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|

--
Libvir-list mailing list
Libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list


Re: [libvirt] Re: [PATCH 05/12] Domain Events - Driver API

2008-10-19 Thread Daniel P. Berrange
On Fri, Oct 17, 2008 at 12:00:16PM -0400, Ben Guthro wrote:
> Additions to the driver API
> 
>  driver.h |   19 +++
>  1 file changed, 19 insertions(+)



> diff --git a/src/driver.h b/src/driver.h
> index 0540f80..c88dea8 100644
> --- a/src/driver.h
> +++ b/src/driver.h
> @@ -280,6 +280,22 @@ typedef unsigned long long
>  (*virDrvNodeGetFreeMemory)
>  (virConnectPtr conn);
>  
> +typedef int
> +(*virDrvDomainEventRegister)
> +(virConnectPtr conn,
> + void *callback,
> + void *opaque);
> +
> +typedef int
> +(*virDrvDomainEventDeregister)
> +(virConnectPtr conn,
> + void *callback);
> +
> +typedef void
> +(*virDrvDomainEventDispatch)
> +(virDomainPtr dom,
> + virDomainEventType evt);

I don't believe this 3rd field is needed here - I'll explain against the
QEMU driver patch.

Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org   -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|

--
Libvir-list mailing list
Libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list