Re: [PATCH] ARM: Remove __ref on hotplug cpu die path
On 15/09/15 01:23, Stephen Boyd wrote: Now that __cpuinit has been removed, the __ref markings on these functions are useless. Remove them. This also reduces the size of the multi_v7_defconfig image: $ size before after textdata bss dec hex filename 126835781470996 348904 14503478 dd4e36 before 126832741470996 348904 14503174 dd4d06 after presumably because now we don't have to jump to code in the .ref.text section and/or the noinline marking is removed. Cc: Tony Lindgren Cc: Barry Song Cc: Andy Gross Cc: Viresh Kumar Cc: Shiraz Hashim Cc: Stephen Warren Cc: Thierry Reding Cc: Alexandre Courbot Cc: Linus Walleij Cc: Sudeep Holla Cc: Lorenzo Pieralisi Cc: Will Deacon Cc: Mark Rutland Cc: Cc: Cc: Cc: Signed-off-by: Stephen Boyd --- This patch can be broken up into per-SoC if desired. [...] arch/arm/mach-vexpress/hotplug.c | 2 +- Acked-by: Sudeep Holla Regards, -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v8 1/7] qcom: spm: Add Subsystem Power Manager driver
On 09/10/14 18:12, Lina Iyer wrote:
On Thu, Oct 09 2014 at 10:53 -0600, Sudeep Holla wrote:
On 07/10/14 22:41, Lina Iyer wrote:
SPM is a hardware block that controls the peripheral logic surrounding
the application cores (cpu/l$). When the core executes WFI instruction,
the SPM takes over the putting the core in low power state as
configured. The wake up for the SPM is an interrupt at the GIC, which
then completes the rest of low power mode sequence and brings the core
out of low power mode.
The SPM has a set of control registers that configure the SPMs
individually based on the type of the core and the runtime conditions.
SPM is a finite state machine block to which a sequence is provided and
it interprets the bytes and executes them in sequence. Each low power
mode that the core can enter into is provided to the SPM as a sequence.
Configure the SPM to set the core (cpu or L2) into its low power mode,
the index of the first command in the sequence is set in the SPM_CTL
register. When the core executes ARM wfi instruction, it triggers the
SPM state machine to start executing from that index. The SPM state
machine waits until the interrupt occurs and starts executing the rest
of the sequence until it hits the end of the sequence. The end of the
sequence jumps the core out of its low power mode.
Based on work by: Mahesh Sivasubramanian ,
Ai Li , Praveen Chidambaram
Original tree available at -
git://codeaurora.org/quic/la/kernel/msm-3.10.git
Signed-off-by: Lina Iyer
---
.../devicetree/bindings/arm/msm/qcom,saw2.txt | 31 ++-
drivers/soc/qcom/Kconfig | 8 +
drivers/soc/qcom/Makefile | 1 +
drivers/soc/qcom/spm.c | 223 +
4 files changed, 257 insertions(+), 6 deletions(-)
create mode 100644 drivers/soc/qcom/spm.c
[...]
+
+static struct spm_driver_data *spm_get_drv(struct platform_device *pdev)
+{
+ struct spm_driver_data *drv = NULL;
+ struct device_node *cpu_node, *saw_node;
+ u32 cpu;
+
+ for_each_possible_cpu(cpu) {
+ if (drv)
+ break;
+ cpu_node = of_get_cpu_node(cpu, NULL);
I have not looked at the patch in detail, just this caught my attention
as I removed most of these unnecessary parsing in ARM code. Unless you
need this before topology_init, you need not parse DT to get cpu_node.
You can use of_cpu_device_node_get instead.
Thanks. But in this usecase, I may need to iterate through all possible
cpus and do a get of the cpu and then get the SAW instance from that and
compare against the SPM instance that is being probed.
SPM does not have a reference to the CPU.
No that shouldn't matter. If spm_get_drv is called after topology_init
(which if IIRC is subsys_initcall), then what I meant is you need not
parse DT(via of_get_cpu_node) instead fetch the stashed cpu_node using
of_cpu_device_node_get(cpu_num)
Regards,
Sudeep
--
To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v8 1/7] qcom: spm: Add Subsystem Power Manager driver
On 07/10/14 22:41, Lina Iyer wrote:
SPM is a hardware block that controls the peripheral logic surrounding
the application cores (cpu/l$). When the core executes WFI instruction,
the SPM takes over the putting the core in low power state as
configured. The wake up for the SPM is an interrupt at the GIC, which
then completes the rest of low power mode sequence and brings the core
out of low power mode.
The SPM has a set of control registers that configure the SPMs
individually based on the type of the core and the runtime conditions.
SPM is a finite state machine block to which a sequence is provided and
it interprets the bytes and executes them in sequence. Each low power
mode that the core can enter into is provided to the SPM as a sequence.
Configure the SPM to set the core (cpu or L2) into its low power mode,
the index of the first command in the sequence is set in the SPM_CTL
register. When the core executes ARM wfi instruction, it triggers the
SPM state machine to start executing from that index. The SPM state
machine waits until the interrupt occurs and starts executing the rest
of the sequence until it hits the end of the sequence. The end of the
sequence jumps the core out of its low power mode.
Based on work by: Mahesh Sivasubramanian ,
Ai Li , Praveen Chidambaram
Original tree available at -
git://codeaurora.org/quic/la/kernel/msm-3.10.git
Signed-off-by: Lina Iyer
---
.../devicetree/bindings/arm/msm/qcom,saw2.txt | 31 ++-
drivers/soc/qcom/Kconfig | 8 +
drivers/soc/qcom/Makefile | 1 +
drivers/soc/qcom/spm.c | 223 +
4 files changed, 257 insertions(+), 6 deletions(-)
create mode 100644 drivers/soc/qcom/spm.c
[...]
+
+static struct spm_driver_data *spm_get_drv(struct platform_device *pdev)
+{
+ struct spm_driver_data *drv = NULL;
+ struct device_node *cpu_node, *saw_node;
+ u32 cpu;
+
+ for_each_possible_cpu(cpu) {
+ if (drv)
+ break;
+ cpu_node = of_get_cpu_node(cpu, NULL);
I have not looked at the patch in detail, just this caught my attention
as I removed most of these unnecessary parsing in ARM code. Unless you
need this before topology_init, you need not parse DT to get cpu_node.
You can use of_cpu_device_node_get instead.
Regards,
Sudeep
--
To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
