Re: [PATCH] imx: select SOC_BUS to fix firmware build

2021-01-17 Thread Shawn Guo
On Mon, Jan 18, 2021 at 04:36:55AM +, Aisheng Dong wrote:
> > From: Randy Dunlap 
> > Sent: Saturday, January 16, 2021 11:33 AM
> > Subject: [PATCH] imx: select SOC_BUS to fix firmware build
> 
> Patch title probably is better to be:
> firmware: imx: x

Fixed it up and applied.


RE: [PATCH] imx: select SOC_BUS to fix firmware build

2021-01-17 Thread Aisheng Dong
> From: Randy Dunlap 
> Sent: Saturday, January 16, 2021 11:33 AM
> Subject: [PATCH] imx: select SOC_BUS to fix firmware build

Patch title probably is better to be:
firmware: imx: x

Otherwise:
Reviewed-by: Dong Aisheng 

Regards
Aisheng

> 
> Fix build error in firmware/imx/ selecting SOC_BUS.
> 
> riscv32-linux-ld: drivers/firmware/imx/imx-scu-soc.o: in function `.L9':
> imx-scu-soc.c:(.text+0x1b0): undefined reference to `soc_device_register'
> 
> Fixes: edbee095fafb ("firmware: imx: add SCU firmware driver support")
> Signed-off-by: Randy Dunlap 
> Reported-by: kernel test robot 
> Cc: Atish Patra 
> Cc: Palmer Dabbelt 
> Cc: Ard Biesheuvel 
> Cc: Anson Huang 
> Cc: Daniel Baluta 
> Cc: Shawn Guo 
> Cc: Dong Aisheng 
> ---
>  drivers/firmware/imx/Kconfig |1 +
>  1 file changed, 1 insertion(+)
> 
> --- linux-next-20210115.orig/drivers/firmware/imx/Kconfig
> +++ linux-next-20210115/drivers/firmware/imx/Kconfig
> @@ -13,6 +13,7 @@ config IMX_DSP
>  config IMX_SCU
>   bool "IMX SCU Protocol driver"
>   depends on IMX_MBOX
> + select SOC_BUS
>   help
> The System Controller Firmware (SCFW) is a low-level system function
> which runs on a dedicated Cortex-M core to provide power, clock, and