Re: [PATCH] [media] Add RGB444_1X12 and RGB565_1X16 media bus formats
On Sat, 15 Nov 2014 16:49:33 +0200 Sakari Ailus wrote: > Hi Boris, > > Boris Brezillon wrote: > > Hi Sakari, > > > > On Fri, 14 Nov 2014 15:58:31 +0200 > > Sakari Ailus wrote: > > > >> Hi Boris, > >> > >> On Fri, Nov 14, 2014 at 11:36:00AM +0100, Boris Brezillon wrote: > ... > >>> diff --git a/include/uapi/linux/media-bus-format.h > >>> b/include/uapi/linux/media-bus-format.h > >>> index 23b4090..cc7b79e 100644 > >>> --- a/include/uapi/linux/media-bus-format.h > >>> +++ b/include/uapi/linux/media-bus-format.h > >>> @@ -33,7 +33,7 @@ > >>> > >>> #define MEDIA_BUS_FMT_FIXED 0x0001 > >>> > >>> -/* RGB - next is 0x100e */ > >>> +/* RGB - next is 0x1010 */ > >>> #define MEDIA_BUS_FMT_RGB444_2X8_PADHI_BE0x1001 > >>> #define MEDIA_BUS_FMT_RGB444_2X8_PADHI_LE0x1002 > >>> #define MEDIA_BUS_FMT_RGB555_2X8_PADHI_BE0x1003 > >>> @@ -47,6 +47,8 @@ > >>> #define MEDIA_BUS_FMT_RGB888_2X12_BE 0x100b > >>> #define MEDIA_BUS_FMT_RGB888_2X12_LE 0x100c > >>> #define MEDIA_BUS_FMT_ARGB_1X32 0x100d > >>> +#define MEDIA_BUS_FMT_RGB444_1X120x100e > >>> +#define MEDIA_BUS_FMT_RGB565_1X160x100f > >> > >> I'd arrange these according to BPP and bits per sample, both in the header > >> and documentation. > > > > I cannot keep both macro values and BPP/bits per sample in incrementing > > order. Are you sure you prefer to order macros in BPP/bits per sample > > order ? > > If you take a look elsewhere in the header, you'll notice that the > ordering has preferred the BPP value (and other values with semantic > significance) over the numeric value of the definition. I'd just prefer > to keep it that way. This is also why the "next is" comments are there. > My bad, I only had a look at RGB formats. I'll fix that. Regards, Boris -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] [media] Add RGB444_1X12 and RGB565_1X16 media bus formats
Hi Boris, Boris Brezillon wrote: > Hi Sakari, > > On Fri, 14 Nov 2014 15:58:31 +0200 > Sakari Ailus wrote: > >> Hi Boris, >> >> On Fri, Nov 14, 2014 at 11:36:00AM +0100, Boris Brezillon wrote: ... >>> diff --git a/include/uapi/linux/media-bus-format.h >>> b/include/uapi/linux/media-bus-format.h >>> index 23b4090..cc7b79e 100644 >>> --- a/include/uapi/linux/media-bus-format.h >>> +++ b/include/uapi/linux/media-bus-format.h >>> @@ -33,7 +33,7 @@ >>> >>> #define MEDIA_BUS_FMT_FIXED0x0001 >>> >>> -/* RGB - next is 0x100e */ >>> +/* RGB - next is 0x1010 */ >>> #define MEDIA_BUS_FMT_RGB444_2X8_PADHI_BE 0x1001 >>> #define MEDIA_BUS_FMT_RGB444_2X8_PADHI_LE 0x1002 >>> #define MEDIA_BUS_FMT_RGB555_2X8_PADHI_BE 0x1003 >>> @@ -47,6 +47,8 @@ >>> #define MEDIA_BUS_FMT_RGB888_2X12_BE 0x100b >>> #define MEDIA_BUS_FMT_RGB888_2X12_LE 0x100c >>> #define MEDIA_BUS_FMT_ARGB_1X320x100d >>> +#define MEDIA_BUS_FMT_RGB444_1X12 0x100e >>> +#define MEDIA_BUS_FMT_RGB565_1X16 0x100f >> >> I'd arrange these according to BPP and bits per sample, both in the header >> and documentation. > > I cannot keep both macro values and BPP/bits per sample in incrementing > order. Are you sure you prefer to order macros in BPP/bits per sample > order ? If you take a look elsewhere in the header, you'll notice that the ordering has preferred the BPP value (and other values with semantic significance) over the numeric value of the definition. I'd just prefer to keep it that way. This is also why the "next is" comments are there. -- Kind regards, Sakari Ailus sakari.ai...@iki.fi -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] [media] Add RGB444_1X12 and RGB565_1X16 media bus formats
Hi Sakari, On Fri, 14 Nov 2014 15:58:31 +0200 Sakari Ailus wrote: > Hi Boris, > > On Fri, Nov 14, 2014 at 11:36:00AM +0100, Boris Brezillon wrote: > > Add RGB444_1X12 and RGB565_1X16 format definitions and update the > > documentation. > > > > Signed-off-by: Boris Brezillon > > Acked-by: Mauro Carvalho Chehab > > --- > > Documentation/DocBook/media/v4l/subdev-formats.xml | 40 > > ++ > > include/uapi/linux/media-bus-format.h | 4 ++- > > 2 files changed, 43 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/DocBook/media/v4l/subdev-formats.xml > > b/Documentation/DocBook/media/v4l/subdev-formats.xml > > index 18730b9..8c396db 100644 > > --- a/Documentation/DocBook/media/v4l/subdev-formats.xml > > +++ b/Documentation/DocBook/media/v4l/subdev-formats.xml > > @@ -563,6 +563,46 @@ > > b1 > > b0 > > > > + > > + MEDIA_BUS_FMT_RGB444_1X12 > > + 0x100d > > + > > + &dash-ent-20; > > + r3 > > + r2 > > + r1 > > + r0 > > + g3 > > + g2 > > + g1 > > + g0 > > + b3 > > + b2 > > + b1 > > + b0 > > + > > + > > + MEDIA_BUS_FMT_RGB565_1X16 > > + 0x100d > > + > > + &dash-ent-16; > > + r4 > > + r3 > > + r2 > > + r1 > > + r0 > > + g5 > > + g4 > > + g3 > > + g2 > > + g1 > > + g0 > > + b4 > > + b3 > > + b2 > > + b1 > > + b0 > > + > > > > > > > > diff --git a/include/uapi/linux/media-bus-format.h > > b/include/uapi/linux/media-bus-format.h > > index 23b4090..cc7b79e 100644 > > --- a/include/uapi/linux/media-bus-format.h > > +++ b/include/uapi/linux/media-bus-format.h > > @@ -33,7 +33,7 @@ > > > > #define MEDIA_BUS_FMT_FIXED0x0001 > > > > -/* RGB - next is 0x100e */ > > +/* RGB - next is 0x1010 */ > > #define MEDIA_BUS_FMT_RGB444_2X8_PADHI_BE 0x1001 > > #define MEDIA_BUS_FMT_RGB444_2X8_PADHI_LE 0x1002 > > #define MEDIA_BUS_FMT_RGB555_2X8_PADHI_BE 0x1003 > > @@ -47,6 +47,8 @@ > > #define MEDIA_BUS_FMT_RGB888_2X12_BE 0x100b > > #define MEDIA_BUS_FMT_RGB888_2X12_LE 0x100c > > #define MEDIA_BUS_FMT_ARGB_1X320x100d > > +#define MEDIA_BUS_FMT_RGB444_1X12 0x100e > > +#define MEDIA_BUS_FMT_RGB565_1X16 0x100f > > I'd arrange these according to BPP and bits per sample, both in the header > and documentation. I cannot keep both macro values and BPP/bits per sample in incrementing order. Are you sure you prefer to order macros in BPP/bits per sample order ? -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] [media] Add RGB444_1X12 and RGB565_1X16 media bus formats
Hi Boris, On Fri, Nov 14, 2014 at 11:36:00AM +0100, Boris Brezillon wrote: > Add RGB444_1X12 and RGB565_1X16 format definitions and update the > documentation. > > Signed-off-by: Boris Brezillon > Acked-by: Mauro Carvalho Chehab > --- > Documentation/DocBook/media/v4l/subdev-formats.xml | 40 > ++ > include/uapi/linux/media-bus-format.h | 4 ++- > 2 files changed, 43 insertions(+), 1 deletion(-) > > diff --git a/Documentation/DocBook/media/v4l/subdev-formats.xml > b/Documentation/DocBook/media/v4l/subdev-formats.xml > index 18730b9..8c396db 100644 > --- a/Documentation/DocBook/media/v4l/subdev-formats.xml > +++ b/Documentation/DocBook/media/v4l/subdev-formats.xml > @@ -563,6 +563,46 @@ > b1 > b0 > > + > + MEDIA_BUS_FMT_RGB444_1X12 > + 0x100d > + > + &dash-ent-20; > + r3 > + r2 > + r1 > + r0 > + g3 > + g2 > + g1 > + g0 > + b3 > + b2 > + b1 > + b0 > + > + > + MEDIA_BUS_FMT_RGB565_1X16 > + 0x100d > + > + &dash-ent-16; > + r4 > + r3 > + r2 > + r1 > + r0 > + g5 > + g4 > + g3 > + g2 > + g1 > + g0 > + b4 > + b3 > + b2 > + b1 > + b0 > + > > > > diff --git a/include/uapi/linux/media-bus-format.h > b/include/uapi/linux/media-bus-format.h > index 23b4090..cc7b79e 100644 > --- a/include/uapi/linux/media-bus-format.h > +++ b/include/uapi/linux/media-bus-format.h > @@ -33,7 +33,7 @@ > > #define MEDIA_BUS_FMT_FIXED 0x0001 > > -/* RGB - next is 0x100e */ > +/* RGB - next is 0x1010 */ > #define MEDIA_BUS_FMT_RGB444_2X8_PADHI_BE0x1001 > #define MEDIA_BUS_FMT_RGB444_2X8_PADHI_LE0x1002 > #define MEDIA_BUS_FMT_RGB555_2X8_PADHI_BE0x1003 > @@ -47,6 +47,8 @@ > #define MEDIA_BUS_FMT_RGB888_2X12_BE 0x100b > #define MEDIA_BUS_FMT_RGB888_2X12_LE 0x100c > #define MEDIA_BUS_FMT_ARGB_1X32 0x100d > +#define MEDIA_BUS_FMT_RGB444_1X120x100e > +#define MEDIA_BUS_FMT_RGB565_1X160x100f I'd arrange these according to BPP and bits per sample, both in the header and documentation. > /* YUV (including grey) - next is0x2024 */ > #define MEDIA_BUS_FMT_Y8_1X8 0x2001 -- Regards, Sakari Ailus e-mail: sakari.ai...@iki.fi XMPP: sai...@retiisi.org.uk -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] [media] Add RGB444_1X12 and RGB565_1X16 media bus formats
Add RGB444_1X12 and RGB565_1X16 format definitions and update the documentation. Signed-off-by: Boris Brezillon Acked-by: Mauro Carvalho Chehab --- Documentation/DocBook/media/v4l/subdev-formats.xml | 40 ++ include/uapi/linux/media-bus-format.h | 4 ++- 2 files changed, 43 insertions(+), 1 deletion(-) diff --git a/Documentation/DocBook/media/v4l/subdev-formats.xml b/Documentation/DocBook/media/v4l/subdev-formats.xml index 18730b9..8c396db 100644 --- a/Documentation/DocBook/media/v4l/subdev-formats.xml +++ b/Documentation/DocBook/media/v4l/subdev-formats.xml @@ -563,6 +563,46 @@ b1 b0 + + MEDIA_BUS_FMT_RGB444_1X12 + 0x100d + + &dash-ent-20; + r3 + r2 + r1 + r0 + g3 + g2 + g1 + g0 + b3 + b2 + b1 + b0 + + + MEDIA_BUS_FMT_RGB565_1X16 + 0x100d + + &dash-ent-16; + r4 + r3 + r2 + r1 + r0 + g5 + g4 + g3 + g2 + g1 + g0 + b4 + b3 + b2 + b1 + b0 + diff --git a/include/uapi/linux/media-bus-format.h b/include/uapi/linux/media-bus-format.h index 23b4090..cc7b79e 100644 --- a/include/uapi/linux/media-bus-format.h +++ b/include/uapi/linux/media-bus-format.h @@ -33,7 +33,7 @@ #define MEDIA_BUS_FMT_FIXED0x0001 -/* RGB - next is 0x100e */ +/* RGB - next is 0x1010 */ #define MEDIA_BUS_FMT_RGB444_2X8_PADHI_BE 0x1001 #define MEDIA_BUS_FMT_RGB444_2X8_PADHI_LE 0x1002 #define MEDIA_BUS_FMT_RGB555_2X8_PADHI_BE 0x1003 @@ -47,6 +47,8 @@ #define MEDIA_BUS_FMT_RGB888_2X12_BE 0x100b #define MEDIA_BUS_FMT_RGB888_2X12_LE 0x100c #define MEDIA_BUS_FMT_ARGB_1X320x100d +#define MEDIA_BUS_FMT_RGB444_1X12 0x100e +#define MEDIA_BUS_FMT_RGB565_1X16 0x100f /* YUV (including grey) - next is 0x2024 */ #define MEDIA_BUS_FMT_Y8_1X8 0x2001 -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
