Re: [PATCH] mmc: block: add newline to sysfs display of force_ro

2014-10-27 Thread Ulf Hansson 
On 21 October 2014 11:20, Baruch Siach  wrote:
> Hi Chris, Ulf,
>
> Ping?
>
> Not a big deal, I guess, but still nice to have for consistency sake.
>
> When applying please make sure to change Andrei's email address.

Thanks! Applied for next!

Kind regards
Uffe

>
> Thanks,
> baruch
>
> On Mon, Sep 22, 2014 at 10:12:51AM +0300, Baruch Siach wrote:
>> Make force_ro consistent with other sysfs entries.
>>
>> Fixes: 371a689f64b0d ('mmc: MMC boot partitions support')
>> Cc: Andrei Warkentin 
>> Signed-off-by: Baruch Siach 
>> ---
>>  drivers/mmc/card/block.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/mmc/card/block.c b/drivers/mmc/card/block.c
>> index ede41f05c392..dad364b09952 100644
>> --- a/drivers/mmc/card/block.c
>> +++ b/drivers/mmc/card/block.c
>> @@ -260,7 +260,7 @@ static ssize_t force_ro_show(struct device *dev, struct 
>> device_attribute *attr,
>>   int ret;
>>   struct mmc_blk_data *md = mmc_blk_get(dev_to_disk(dev));
>>
>> - ret = snprintf(buf, PAGE_SIZE, "%d",
>> + ret = snprintf(buf, PAGE_SIZE, "%d\n",
>>  get_disk_ro(dev_to_disk(dev)) ^
>>  md->read_only);
>>   mmc_blk_put(md);
>> --
>> 2.1.0
>
> --
>  http://baruch.siach.name/blog/  ~. .~   Tk Open Systems
> =}ooO--U--Ooo{=
>- bar...@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] mmc: block: add newline to sysfs display of force_ro

2014-10-21 Thread Baruch Siach 
Hi Chris, Ulf,

Ping?

Not a big deal, I guess, but still nice to have for consistency sake.

When applying please make sure to change Andrei's email address.

Thanks,
baruch

On Mon, Sep 22, 2014 at 10:12:51AM +0300, Baruch Siach wrote:
> Make force_ro consistent with other sysfs entries.
> 
> Fixes: 371a689f64b0d ('mmc: MMC boot partitions support')
> Cc: Andrei Warkentin 
> Signed-off-by: Baruch Siach 
> ---
>  drivers/mmc/card/block.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mmc/card/block.c b/drivers/mmc/card/block.c
> index ede41f05c392..dad364b09952 100644
> --- a/drivers/mmc/card/block.c
> +++ b/drivers/mmc/card/block.c
> @@ -260,7 +260,7 @@ static ssize_t force_ro_show(struct device *dev, struct 
> device_attribute *attr,
>   int ret;
>   struct mmc_blk_data *md = mmc_blk_get(dev_to_disk(dev));
>  
> - ret = snprintf(buf, PAGE_SIZE, "%d",
> + ret = snprintf(buf, PAGE_SIZE, "%d\n",
>  get_disk_ro(dev_to_disk(dev)) ^
>  md->read_only);
>   mmc_blk_put(md);
> -- 
> 2.1.0

-- 
 http://baruch.siach.name/blog/  ~. .~   Tk Open Systems
=}ooO--U--Ooo{=
   - bar...@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] mmc: block: add newline to sysfs display of force_ro

2014-09-22 Thread Baruch Siach 
Make force_ro consistent with other sysfs entries.

Fixes: 371a689f64b0d ('mmc: MMC boot partitions support')
Cc: Andrei Warkentin 
Signed-off-by: Baruch Siach 
---
 drivers/mmc/card/block.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mmc/card/block.c b/drivers/mmc/card/block.c
index ede41f05c392..dad364b09952 100644
--- a/drivers/mmc/card/block.c
+++ b/drivers/mmc/card/block.c
@@ -260,7 +260,7 @@ static ssize_t force_ro_show(struct device *dev, struct 
device_attribute *attr,
int ret;
struct mmc_blk_data *md = mmc_blk_get(dev_to_disk(dev));
 
-   ret = snprintf(buf, PAGE_SIZE, "%d",
+   ret = snprintf(buf, PAGE_SIZE, "%d\n",
   get_disk_ro(dev_to_disk(dev)) ^
   md->read_only);
mmc_blk_put(md);
-- 
2.1.0

--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] mmc: block: add newline to sysfs display of force_ro

2014-09-22 Thread Baruch Siach 
Hi Cris, Ulf,

On Mon, Sep 22, 2014 at 10:12:51AM +0300, Baruch Siach wrote:
> Make force_ro consistent with other sysfs entries.
> 
> Fixes: 371a689f64b0d ('mmc: MMC boot partitions support')
> Cc: Andrei Warkentin 

Andrei's address is bouncing. Added his gmail address instead:

Cc: Andrei Warkentin 

baruch

> Signed-off-by: Baruch Siach 
> ---
>  drivers/mmc/card/block.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mmc/card/block.c b/drivers/mmc/card/block.c
> index ede41f05c392..dad364b09952 100644
> --- a/drivers/mmc/card/block.c
> +++ b/drivers/mmc/card/block.c
> @@ -260,7 +260,7 @@ static ssize_t force_ro_show(struct device *dev, struct 
> device_attribute *attr,
>   int ret;
>   struct mmc_blk_data *md = mmc_blk_get(dev_to_disk(dev));
>  
> - ret = snprintf(buf, PAGE_SIZE, "%d",
> + ret = snprintf(buf, PAGE_SIZE, "%d\n",
>  get_disk_ro(dev_to_disk(dev)) ^
>  md->read_only);
>   mmc_blk_put(md);
> -- 
> 2.1.0

-- 
 http://baruch.siach.name/blog/  ~. .~   Tk Open Systems
=}ooO--U--Ooo{=
   - bar...@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html