Re: [PATCH 0/3] Improve MMC error handling (3rd rev)

2011-06-21 Thread Chris Ball 
Hi Russell,

On Mon, Jun 20 2011, Russell King - ARM Linux wrote:
> This is the third revision of my improvements to the MMC block
> device error handling, which makes error handling more robust
> and permits MMC/SD to continue working in the presence of
> not-quite-perfect setups.
>
> Without this, my Versatile Express tends to fail to mount its rootfs
> on SD.  With this, it can successfully read and write data from the
> card in the presence of FIFO overruns and underruns, and also sensibly
> recover from command channel errors.
>
> There is more to come, but this is the "safer" bits of the improvements.
>
>  drivers/mmc/card/block.c |  279 ++---
>  include/linux/mmc/mmc.h  |   10 ++
>  2 files changed, 221 insertions(+), 68 deletions(-)

Thanks, pushed to mmc-next for 3.1.

(I'll do some more testing myself and let you know if I find anything
unexpected.)

- Chris.
-- 
Chris Ball  
One Laptop Per Child
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/3] Improve MMC error handling (3rd rev)

2011-06-21 Thread Pawel Moll 
On Mon, 2011-06-20 at 20:09 +0100, Russell King - ARM Linux wrote:
> This is the third revision of my improvements to the MMC block
> device error handling, which makes error handling more robust
> and permits MMC/SD to continue working in the presence of
> not-quite-perfect setups.

Tested-by: Pawel Moll 

Cheers!

Paweł


--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/3] Improve MMC error handling (3rd rev)

2011-06-20 Thread Linus Walleij 
On Mon, Jun 20, 2011 at 9:09 PM, Russell King - ARM Linux
 wrote:

> This is the third revision of my improvements to the MMC block
> device error handling, which makes error handling more robust
> and permits MMC/SD to continue working in the presence of
> not-quite-perfect setups.

All look like perfectly reasonable hardening of the MMC error
path, so FWIW:
Acked-by: Linus Walleij 

Thanks,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 0/3] Improve MMC error handling (3rd rev)

2011-06-20 Thread Russell King - ARM Linux 
This is the third revision of my improvements to the MMC block
device error handling, which makes error handling more robust
and permits MMC/SD to continue working in the presence of
not-quite-perfect setups.

Without this, my Versatile Express tends to fail to mount its rootfs
on SD.  With this, it can successfully read and write data from the
card in the presence of FIFO overruns and underruns, and also sensibly
recover from command channel errors.

There is more to come, but this is the "safer" bits of the improvements.

 drivers/mmc/card/block.c |  279 ++---
 include/linux/mmc/mmc.h  |   10 ++
 2 files changed, 221 insertions(+), 68 deletions(-)

--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html