Re: [PATCH] Add new device IDs for ConnectX VPI HCAs
On Thu, Feb 25, 2010 at 03:28:16PM -0800, Roland Dreier wrote: > > But yeah, patches to get the ID list into shape with at least the right > list of device IDs for kernel and userspace would be welcome. OK, we'll have them sent next week. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] Add new device IDs for ConnectX VPI HCAs
> > The kernel calls this device ID "MT26438 ConnectX EN 40GigE PCIe gen2 > > 5GT/s". Maybe we should just delete these comments, since we can't seem > > to get them right? > > I guess it would be best if we take the description from > http://pciids.sourceforge.net/v2.2/pci.ids I wonder whether it's really worth having the text at all. Maybe it's a bit useful, I'm not sure. But the pciids text could probably use some cleaning up, eg: 634a MT25418 [ConnectX VPI PCIe 2.0 2.5GT/s - IB DDR / 10GigE] 6368 MT25448 [ConnectX EN 10GigE, PCIe 2.0 2.5GT/s] it would be nice to decide on a standard order of whether the PCIe or the network info comes first. And then to make things even better we have: 103c 3313 HP NC542m Dual Port Flex-10 10GbE BLc Adapter so we can't even decide on 10GigE vs. 10GbE. But yeah, patches to get the ID list into shape with at least the right list of device IDs for kernel and userspace would be welcome. -- Roland Dreier For corporate legal information go to: http://www.cisco.com/web/about/doing_business/legal/cri/index.html -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] Add new device IDs for ConnectX VPI HCAs
On Wed, Feb 24, 2010 at 02:07:20PM -0800, Roland Dreier wrote: > > + HCA(MELLANOX, 0x6746), /* MT26438 ConnectX VPI PCIe 2.0 5GT/s - IB QDR > / 10GigE Virt+ */ > > The kernel calls this device ID "MT26438 ConnectX EN 40GigE PCIe gen2 > 5GT/s". Maybe we should just delete these comments, since we can't seem > to get them right? I guess it would be best if we take the description from http://pciids.sourceforge.net/v2.2/pci.ids > > > + HCA(MELLANOX, 0x6778), /* MT26488 ConnectX VPI PCIe 2.0 5GT/s - IB DDR > / 10GigE Virt+ */ > > Are we missing a kernel patch? I don't see this device ID in the kernel > driver. Looks like it is missing. If we agree on this, we'll send two patches - one for kernel and one for libmlx4 to sync all device IDs with descriptions from the mentioned url. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] Add new device IDs for ConnectX VPI HCAs
> +HCA(MELLANOX, 0x6746), /* MT26438 ConnectX VPI PCIe 2.0 5GT/s - IB QDR > / 10GigE Virt+ */ The kernel calls this device ID "MT26438 ConnectX EN 40GigE PCIe gen2 5GT/s". Maybe we should just delete these comments, since we can't seem to get them right? > +HCA(MELLANOX, 0x6778), /* MT26488 ConnectX VPI PCIe 2.0 5GT/s - IB DDR > / 10GigE Virt+ */ Are we missing a kernel patch? I don't see this device ID in the kernel driver. -- Roland Dreier For corporate legal information go to: http://www.cisco.com/web/about/doing_business/legal/cri/index.html -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] Add new device IDs for ConnectX VPI HCAs
Signed-off-by: Vladimir Sokolovsky
---
src/mlx4.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/src/mlx4.c b/src/mlx4.c
index 1295c53..973df68 100644
--- a/src/mlx4.c
+++ b/src/mlx4.c
@@ -66,6 +66,8 @@ struct {
HCA(MELLANOX, 0x6354), /* MT25408 "Hermon" QDR */
HCA(MELLANOX, 0x6732), /* MT25408 "Hermon" DDR PCIe gen2 */
HCA(MELLANOX, 0x673c), /* MT25408 "Hermon" QDR PCIe gen2 */
+ HCA(MELLANOX, 0x6746), /* MT26438 ConnectX VPI PCIe 2.0 5GT/s - IB QDR
/ 10GigE Virt+ */
+ HCA(MELLANOX, 0x6778), /* MT26488 ConnectX VPI PCIe 2.0 5GT/s - IB DDR
/ 10GigE Virt+ */
};
static struct ibv_context_ops mlx4_ctx_ops = {
--
1.5.4.3
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
