Re: [ewg] [PATCH] [for-2.6.33] rdma/cm: disallow loopback address for iwarp devices
Sean Hefty wrote: IMO 127.0.0.1 should be for SW loopback, not HW RDMA loopback. I disagree, but what does it matter? So, we add a 'software' loopback that uses 127.0.0.1. Openmpi still wouldn't work. I guess that's true. I will commit to get the fix in openmpi asap. If we don't care if the fix is in the kernel or user space, then we could add an a 'disable-loopback-support' build option to librdmacm, which can fail any attempt to bind to a loopback address. I'd rather see it removed from 2.6.33 kernel before it shipts, and then we fix openmpi, and then re-submit 127.0.0.1 support once openmpi publishes a release with its fix. See my other email that submits a potential commit to remove 127.0.0.1 support for 2.6.33. Steve. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [ewg] [PATCH] [for-2.6.33] rdma/cm: disallow loopback address for iwarp devices
>IMO 127.0.0.1 should be for SW loopback, not HW RDMA loopback. I disagree, but what does it matter? So, we add a 'software' loopback that uses 127.0.0.1. Openmpi still wouldn't work. >I will commit to get the fix in openmpi asap. If we don't care if the fix is in the kernel or user space, then we could add an a 'disable-loopback-support' build option to librdmacm, which can fail any attempt to bind to a loopback address. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [ewg] [PATCH] [for-2.6.33] rdma/cm: disallow loopback address for iwarp devices
Jason Gunthorpe wrote: On Mon, Feb 08, 2010 at 08:52:10AM -0800, Roland Dreier wrote: > This patch doesn't solve the openmpi/IB regression. So for OFED, > IMO, we need a different patch... If this doesn't solve the regression the we should have a different patch for upstream too. The goal for 2.6.33 should be to keep open mpi working, even if that requires us to go back to old breakage. Steve, I thought you said earlier in the thread that the rdmacm OMPI method is not used that often with IB - and the other IB connect methods work fine. Maybe Jeff can chime in here, but he mentioned to me that Sandia Labs were using IB/rdmacm. This really is a bug in OMPI, how long do you think this new feature should remain outside the upstream kernel? Is someone going to commit to fixing OMPI soon if the patch is removed? IMO 127.0.0.1 should be for SW loopback, not HW RDMA loopback. But I believe Jeff asked at least that we pull it from 2.6.33 and let OMPI get its next release out with the OMPI fix. Then you can push it into 2.6.34 if we really want this feature. I will commit to get the fix in openmpi asap. Steve. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [ewg] [PATCH] [for-2.6.33] rdma/cm: disallow loopback address for iwarp devices
On Mon, Feb 08, 2010 at 08:52:10AM -0800, Roland Dreier wrote: > > This patch doesn't solve the openmpi/IB regression. So for OFED, > > IMO, we need a different patch... > > If this doesn't solve the regression the we should have a different > patch for upstream too. The goal for 2.6.33 should be to keep open mpi > working, even if that requires us to go back to old breakage. Steve, I thought you said earlier in the thread that the rdmacm OMPI method is not used that often with IB - and the other IB connect methods work fine. This really is a bug in OMPI, how long do you think this new feature should remain outside the upstream kernel? Is someone going to commit to fixing OMPI soon if the patch is removed? Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [ewg] [PATCH] [for-2.6.33] rdma/cm: disallow loopback address for iwarp devices
> This patch doesn't solve the openmpi/IB regression. So for OFED, > IMO, we need a different patch... If this doesn't solve the regression the we should have a different patch for upstream too. The goal for 2.6.33 should be to keep open mpi working, even if that requires us to go back to old breakage. -- Roland Dreier For corporate legal information go to: http://www.cisco.com/web/about/doing_business/legal/cri/index.html -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [ewg] [PATCH] [for-2.6.33] rdma/cm: disallow loopback address for iwarp devices
This patch doesn't solve the openmpi/IB regression. So for OFED, IMO, we need a different patch... Tziporet Koren wrote: On 2/8/2010 8:02 AM, Sean Hefty wrote: Since iWarp devices are not guaranteed to support loopback connections, prevent rdma_bind_addr from associating the loopback address with an iWarp device. Signed-off-by: Sean Hefty Steve Have you tested this patch? When accepted to kernel can you prepare a patch for OFED 1.5.1 under fixes Thanks Tziporet -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [ewg] [PATCH] [for-2.6.33] rdma/cm: disallow loopback address for iwarp devices
On 2/8/2010 8:02 AM, Sean Hefty wrote: Since iWarp devices are not guaranteed to support loopback connections, prevent rdma_bind_addr from associating the loopback address with an iWarp device. Signed-off-by: Sean Hefty Steve Have you tested this patch? When accepted to kernel can you prepare a patch for OFED 1.5.1 under fixes Thanks Tziporet -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
