RE: [PATCH 0/8] i.MX6 PCIe binding change and MSI support
> -Original Message- > From: Bjorn Helgaas [mailto:bhelg...@google.com] > Sent: Friday, April 25, 2014 10:40 PM > To: Lucas Stach > Cc: Zhu Richard-R65037; Jingoo Han; Shawn Guo; linux-...@vger.kernel.org; > linux-arm; linux-samsung-soc@vger.kernel.org; devicet...@vger.kernel.org; Sean > Cross; Marek Vasut; Ian Campbell; Mark Rutland; Pawel Moll; Rob Herring; Arnd > Bergmann; Tim Harvey; ker...@pengutronix.de > Subject: Re: [PATCH 0/8] i.MX6 PCIe binding change and MSI support > > On Fri, Apr 25, 2014 at 4:21 AM, Lucas Stach wrote: > > Am Donnerstag, den 24.04.2014, 11:58 -0600 schrieb Bjorn Helgaas: > >> On Fri, Mar 28, 2014 at 05:52:51PM +0100, Lucas Stach wrote: > >> > While working on MSI support for the i.MX6 PCIe host driver it has > >> > been discovered that the binding for this host controller is broken > >> > in many ways (refer to the patch descriptions for more > >> > info) and was introduced without proper discussion about what > >> > should/should not be in the binding. > >> > > >> > This series fixes this and minimizes the difference of the > >> > i.MX6 binding to the common designware PCIe binding. I'm aware that > >> > this is a quite radical change, but I think it's justified to do > >> > this as long as there aren't many user of the old binding (most of > >> > the optional properties in the binding aren't even implemented). > >> > > >> > Looking forward to your feedback. > >> > > >> > Lucas Stach (8): > >> > ARM: imx6q-clk: parent lvds_gate from lvds_sel > > This one is already applied. > > > >> > PCI: designware: split Exynos and i.MX bindings > >> > ARM: dts: imx6: update pcie to bring in line with new binding > >> > PCI: imx6: use new clock names > >> > PCI: imx6: drop old irq mapping > >> > PCI: imx6: rip out optional (and unused) irqs > >> > PCI: designware: make MSI isr shared irq aware > >> > PCI: imx6: add support for MSI > >> > >> What's the status of all these? I would normally apply patches 4-8 > >> of this series through my tree, given the appropriate acks, but I > >> haven't seen those yet. And I'm not sure what dependencies there are > >> between the non-PCI patches and the PCI ones. > >> > > It's a complete binding change, so applying one part without the other > > is going to horribly break things. > > > > So I would at least want to see an ack for the binding change on the > > i.MX side from Shawn and Richard. This will need some follow on > > patches, as some boards adding PCIe using the old binding have cropped > > up in linux-next, but I can do the patches on short notice if everyone > > agrees to merge this patchset. > > > > The designware part is pretty simple and doesn't change anything for > > other users than i.MX. Though I would like to see an ack from Jingoo > > for those. > > > > I have some more stuff in the pipes regarding multiple MSI irqs, that > > depend on this series and also the Keystone people are waiting for > > this to be applied in order to consolidate the clock handling of the > > designware core driver, so it would be nice to get this moving again. [Richard] Hi Lucas, thanks. I'm ok for this patch-set. Acked-by: Richard Zhu > > OK, just poke me again when you're ready for me to do something with these. > > Bjorn > Best Regards Richard Zhu
RE: [PATCH 1/8] ARM: imx6q-clk: parent lvds_gate from lvds_sel
Hi Lucas:
Thanks for your re-structure the management of the output on CLK1/2 pads.
> -Original Message-
> From: linux-pci-ow...@vger.kernel.org [mailto:linux-pci-ow...@vger.kernel.org]
> On Behalf Of Lucas Stach
> Sent: Saturday, March 29, 2014 12:53 AM
> To: linux-...@vger.kernel.org
> Cc: linux-arm-ker...@lists.infradead.org; linux-samsung-soc@vger.kernel.org;
> devicet...@vger.kernel.org; Sean Cross; Marek Vasut; Zhu Richard-R65037; Bjorn
> Helgaas; Jingoo Han; Shawn Guo; Ian Campbell; Mark Rutland; Pawel Moll; Rob
> Herring; Arnd Bergmann; Tim Harvey; ker...@pengutronix.de
> Subject: [PATCH 1/8] ARM: imx6q-clk: parent lvds_gate from lvds_sel
>
> Allows fror proper refcounting of the parent clocks when enabling the clock
> output on CLK1/2 pads.
>
> Signed-off-by: Lucas Stach
Acked-by: Richard Zhu
> ---
> arch/arm/mach-imx/clk-imx6q.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-imx/clk-imx6q.c b/arch/arm/mach-imx/clk-imx6q.c
> index af2e582d2b74..f98a6bb98145 100644
> --- a/arch/arm/mach-imx/clk-imx6q.c
> +++ b/arch/arm/mach-imx/clk-imx6q.c
> @@ -208,8 +208,8 @@ static void __init imx6q_clocks_init(struct device_node
> *ccm_node)
>* the "output_enable" bit as a gate, even though it's really just
>* enabling clock output.
>*/
> - clk[lvds1_gate] = imx_clk_gate("lvds1_gate", "dummy", base + 0x160, 10);
> - clk[lvds2_gate] = imx_clk_gate("lvds2_gate", "dummy", base + 0x160, 11);
> + clk[lvds1_gate] = imx_clk_gate("lvds1_gate", "lvds1_sel", base + 0x160,
> 10);
> + clk[lvds2_gate] = imx_clk_gate("lvds2_gate", "lvds2_sel", base +
> +0x160, 11);
>
> /*name parent_name
> reg idx */
> clk[pll2_pfd0_352m] = imx_clk_pfd("pll2_pfd0_352m", "pll2_bus", base
> + 0x100, 0);
> --
> 1.9.0
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pci" in the
> body of a message to majord...@vger.kernel.org More majordomo info at
> http://vger.kernel.org/majordomo-info.html
>
Best Regards
Richard Zhu
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH] MAINTAINERS: Add DesignWare, i.MX6, Armada, R-Car PCI host maintainers
Hi Bjorn: > -Original Message- > From: Shawn Guo [mailto:shawn@linaro.org] > Sent: Friday, December 13, 2013 1:39 PM > To: Bjorn Helgaas > Cc: linux-...@vger.kernel.org; linux-ker...@vger.kernel.org; linux-arm; linux- > te...@vger.kernel.org; linux...@vger.kernel.org; linux-samsung- > s...@vger.kernel.org; Jingoo Han; Jason Cooper; Thierry Reding; Simon Horman; > Magnus Damm; Valentine Barshak; Wei Yongjun; Wei Yongjun; Kuninori Morimoto; > Zhu Richard-R65037 > Subject: Re: [PATCH] MAINTAINERS: Add DesignWare, i.MX6, Armada, R-Car PCI > host maintainers > > On Thu, Dec 12, 2013 at 01:29:00PM -0700, Bjorn Helgaas wrote: > > On Thu, Dec 12, 2013 at 12:00 AM, Shawn Guo wrote: > > > Hi Bjorn, > > > > > > On Wed, Dec 11, 2013 at 11:32:37AM -0700, Bjorn Helgaas wrote: > > >> +PCI DRIVER FOR IMX6 > > >> +M: Shawn Guo > > > > > > Thanks for the nomination. But I think a better person for this > > > position would be Richard Zhu (copied). He > > > knows the driver and controller much better than myself, and most > > > importantly he is the driver owner for Freescale kernel and he has > > > the contact to Freescale PCIe hardware people. > > > > Richard, are you OK with being listed here? > > Richard is on leave these two days. Hope he will be back to online soon. [Richard] I went to hospital in the past two days. Thanks, I'm ok with being listed here. > > > Shawn, do you want to be > > listed here in addition, if only to make sure you're copied on changes > > to pci-imx6.c? > > Okay, thanks, Bjorn. > > Shawn Best Regards Richard Zhu -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
