Re: [1/3] powerpc/mm: move mmap_sem unlock up from do_sigbus
On Tue, 2017-02-14 at 16:45:10 UTC, Laurent Dufour wrote: > Move mmap_sem releasing in the do_sigbus()'s unique caller : mm_fault_error() > > No functional changes. > > Signed-off-by: Laurent Dufour Series applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/c2294e0ffe741c8b34c630a71c7dc4 cheers
Re: [PATCH 1/3] powerpc/mm: move mmap_sem unlock up from do_sigbus
Laurent Dufour writes: > Move mmap_sem releasing in the do_sigbus()'s unique caller : mm_fault_error() > > No functional changes. > Reviewed-by: Aneesh Kumar K.V > Signed-off-by: Laurent Dufour > --- > arch/powerpc/mm/fault.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/powerpc/mm/fault.c b/arch/powerpc/mm/fault.c > index 62a50d6d1053..ee09604bbe12 100644 > --- a/arch/powerpc/mm/fault.c > +++ b/arch/powerpc/mm/fault.c > @@ -119,8 +119,6 @@ static int do_sigbus(struct pt_regs *regs, unsigned long > address, > siginfo_t info; > unsigned int lsb = 0; > > - up_read(¤t->mm->mmap_sem); > - > if (!user_mode(regs)) > return MM_FAULT_ERR(SIGBUS); > > @@ -184,8 +182,10 @@ static int mm_fault_error(struct pt_regs *regs, unsigned > long addr, int fault) > return MM_FAULT_RETURN; > } > > - if (fault & (VM_FAULT_SIGBUS|VM_FAULT_HWPOISON|VM_FAULT_HWPOISON_LARGE)) > + if (fault & > (VM_FAULT_SIGBUS|VM_FAULT_HWPOISON|VM_FAULT_HWPOISON_LARGE)) { > + up_read(¤t->mm->mmap_sem); > return do_sigbus(regs, addr, fault); > + } > > /* We don't understand the fault code, this is fatal */ > BUG(); > -- > 2.7.4
[PATCH 1/3] powerpc/mm: move mmap_sem unlock up from do_sigbus
Move mmap_sem releasing in the do_sigbus()'s unique caller : mm_fault_error() No functional changes. Signed-off-by: Laurent Dufour --- arch/powerpc/mm/fault.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/powerpc/mm/fault.c b/arch/powerpc/mm/fault.c index 62a50d6d1053..ee09604bbe12 100644 --- a/arch/powerpc/mm/fault.c +++ b/arch/powerpc/mm/fault.c @@ -119,8 +119,6 @@ static int do_sigbus(struct pt_regs *regs, unsigned long address, siginfo_t info; unsigned int lsb = 0; - up_read(¤t->mm->mmap_sem); - if (!user_mode(regs)) return MM_FAULT_ERR(SIGBUS); @@ -184,8 +182,10 @@ static int mm_fault_error(struct pt_regs *regs, unsigned long addr, int fault) return MM_FAULT_RETURN; } - if (fault & (VM_FAULT_SIGBUS|VM_FAULT_HWPOISON|VM_FAULT_HWPOISON_LARGE)) + if (fault & (VM_FAULT_SIGBUS|VM_FAULT_HWPOISON|VM_FAULT_HWPOISON_LARGE)) { + up_read(¤t->mm->mmap_sem); return do_sigbus(regs, addr, fault); + } /* We don't understand the fault code, this is fatal */ BUG(); -- 2.7.4