Re: [PATCH v2] watchdog: add SPDX identifiers for watchdog subsystem
On Tue, Feb 20, 2018 at 07:13:43AM -0800, Guenter Roeck wrote: > On 02/20/2018 05:21 AM, Marcus Folkesson wrote: > > Hello William, > > > > On Tue, Feb 20, 2018 at 07:49:55AM -0500, William Breathitt Gray wrote: > > > On Tue, Feb 20, 2018 at 11:45:31AM +0100, Marcus Folkesson wrote: > > > > - Add SPDX identifier > > > > - Remove boiler plate license text > > > > - If MODULE_LICENSE and boiler plate does not match, go for boiler plate > > > > license > > > > > > > > Signed-off-by: Marcus Folkesson > > > > Acked-by: Adam Thomson > > > > Acked-by: Charles Keepax > > > > Acked-by: Nicolas Ferre > > > > Acked-by: Michal Simek > > > > --- > > > > > > > > Notes: > > > > v2: > > > > - Put back removed copyright texts for meson_gxbb_wdt and > > > > coh901327_wdt > > > > - Change to BSD-3-Clause for meson_gxbb_wdt > > > > v1: Please have an extra look at meson_gxbb_wdt.c > > > > > > [...] > > > > > > > diff --git a/drivers/watchdog/ebc-c384_wdt.c > > > > b/drivers/watchdog/ebc-c384_wdt.c > > > > index 2170b275ea01..c173b6f5c866 100644 > > > > --- a/drivers/watchdog/ebc-c384_wdt.c > > > > +++ b/drivers/watchdog/ebc-c384_wdt.c > > > > @@ -1,15 +1,8 @@ > > > > +// SPDX-License-Identifier: GPL-2.0 > > > > /* > > > > * Watchdog timer driver for the WinSystems EBC-C384 > > > > * Copyright (C) 2016 William Breathitt Gray > > > > * The copyright is untouched? > > > > - * This program is free software; you can redistribute it and/or modify > > > > - * it under the terms of the GNU General Public License, version 2, as > > > > - * published by the Free Software Foundation. > > > > - * > > > > - * This program is distributed in the hope that it will be useful, but > > > > - * WITHOUT ANY WARRANTY; without even the implied warranty of > > > > - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > > > > - * General Public License for more details. > > > > */ > > > > #include > > > > #include > > > > Thank you for your feedback! > > > > > > I have no problem with adding a SPDX line to the top of this file, but > > > use "SPDX-License-Identifier: GPL-2.0-only" as I was very intentional > > > with the selection of GPL version 2 only when I published this code. > > > > SPDX-License-Identifier: GPL-2.0 > > Is GPL-2.0 only [1], so it respects your choice of license. > > > > > > > > Furthermore, please do not remove the existing copyright text; although > > > > It is not a matter if you CAN keep a copyright. You MUST NOT remove a > copyright. > As long as you do, the series is > > Nacked-by: Guenter Roeck > > Guenter I'm sorry, I do not see where the copyright is removed unless you count the license text as part of the copyright. Can you please point it out? > > > The copyright text: > > > > Copyright (C) 2016 William Breathitt Gray > > > > Is still in the file. ^^^ > > > > > > > it's just boilerplate for some, I was careful with the selection of > > > these words, and I worry the SPDX line only -- despite its useful > > > conciseness -- may lead to misunderstandings about my intentioned > > > license for this code. > > > > I'm not sure I understand your concerns here, the SPDX identifier is > > a shorthand for the GPL 2.0 only license. See [1] - Linux kernel licensing > > rules. > > > > One of the biggest benefits with SPDX identifier is that it is hard to > > verify > > boiler plate licenses due to formatting, types, different formulations and > > so on. > > > > If still worrying, I think we could keep the license text as > > well. > > > > > > > > For the time being, I can't Ack this patch with the changes it makes > > > currently: > > > > > > Nacked-by: William Breathitt Gray > > > > > > William Breathitt Gray > > > > Please let me know if I got you wrong at some point. > > > > [1] > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst > > > > Best regards > > Marcus Folkesson > > > Best regards Marcus Folkesson signature.asc Description: PGP signature
Re: [PATCH v2] watchdog: add SPDX identifiers for watchdog subsystem
On Tue, Feb 20, 2018 at 04:33:26PM +0100, Marcus Folkesson wrote: >On Tue, Feb 20, 2018 at 07:13:43AM -0800, Guenter Roeck wrote: >> On 02/20/2018 05:21 AM, Marcus Folkesson wrote: >> > Hello William, >> > >> > On Tue, Feb 20, 2018 at 07:49:55AM -0500, William Breathitt Gray wrote: >> > > On Tue, Feb 20, 2018 at 11:45:31AM +0100, Marcus Folkesson wrote: >> > > > - Add SPDX identifier >> > > > - Remove boiler plate license text >> > > > - If MODULE_LICENSE and boiler plate does not match, go for boiler >> > > > plate >> > > > license >> > > > >> > > > Signed-off-by: Marcus Folkesson >> > > > Acked-by: Adam Thomson >> > > > Acked-by: Charles Keepax >> > > > Acked-by: Nicolas Ferre >> > > > Acked-by: Michal Simek >> > > > --- >> > > > >> > > > Notes: >> > > > v2: >> > > >- Put back removed copyright texts for meson_gxbb_wdt and >> > > > coh901327_wdt >> > > >- Change to BSD-3-Clause for meson_gxbb_wdt >> > > > v1: Please have an extra look at meson_gxbb_wdt.c >> > > >> > > [...] >> > > >> > > > diff --git a/drivers/watchdog/ebc-c384_wdt.c >> > > > b/drivers/watchdog/ebc-c384_wdt.c >> > > > index 2170b275ea01..c173b6f5c866 100644 >> > > > --- a/drivers/watchdog/ebc-c384_wdt.c >> > > > +++ b/drivers/watchdog/ebc-c384_wdt.c >> > > > @@ -1,15 +1,8 @@ >> > > > +// SPDX-License-Identifier: GPL-2.0 >> > > > /* >> > > > * Watchdog timer driver for the WinSystems EBC-C384 >> > > > * Copyright (C) 2016 William Breathitt Gray >> > > > * > >The copyright is untouched? > >> > > > - * This program is free software; you can redistribute it and/or >> > > > modify >> > > > - * it under the terms of the GNU General Public License, version 2, as >> > > > - * published by the Free Software Foundation. >> > > > - * >> > > > - * This program is distributed in the hope that it will be useful, but >> > > > - * WITHOUT ANY WARRANTY; without even the implied warranty of >> > > > - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU >> > > > - * General Public License for more details. >> > > > */ >> > > > #include >> > > > #include >> > >> > Thank you for your feedback! >> > > >> > > I have no problem with adding a SPDX line to the top of this file, but >> > > use "SPDX-License-Identifier: GPL-2.0-only" as I was very intentional >> > > with the selection of GPL version 2 only when I published this code. >> > >> > SPDX-License-Identifier: GPL-2.0 >> > Is GPL-2.0 only [1], so it respects your choice of license. Ah, this should be fine then. :) >> > >> > > >> > > Furthermore, please do not remove the existing copyright text; although >> > >> >> It is not a matter if you CAN keep a copyright. You MUST NOT remove a >> copyright. >> As long as you do, the series is >> >> Nacked-by: Guenter Roeck >> >> Guenter > >I'm sorry, I do not see where the copyright is removed unless you count >the license text as part of the copyright. > >Can you please point it out? > >> >> > The copyright text: >> > >> > Copyright (C) 2016 William Breathitt Gray >> > >> > Is still in the file. > >^^^ > >> > >> > >> > > it's just boilerplate for some, I was careful with the selection of >> > > these words, and I worry the SPDX line only -- despite its useful >> > > conciseness -- may lead to misunderstandings about my intentioned >> > > license for this code. >> > >> > I'm not sure I understand your concerns here, the SPDX identifier is >> > a shorthand for the GPL 2.0 only license. See [1] - Linux kernel licensing >> > rules. >> > >> > One of the biggest benefits with SPDX identifier is that it is hard to >> > verify >> > boiler plate licenses due to formatting, types, different formulations and >> > so on. >> > >> > If still worrying, I think we could keep the license text as >> > well. I'm sorry for the confusion, I should have wrote "license text" rather than "copyright text" in my previous message. I agree with the benefits of utilizing the SPDX identifier, and I see the addition of the SPDX line as useful, but I would prefer the original license text remain as well. William Breathitt Gray >> > >> > > >> > > For the time being, I can't Ack this patch with the changes it makes >> > > currently: >> > > >> > > Nacked-by: William Breathitt Gray >> > > >> > > William Breathitt Gray >> > >> > Please let me know if I got you wrong at some point. >> > >> > [1] >> > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst >> > >> > Best regards >> > Marcus Folkesson >> > >> > >Best regards >Marcus Folkesson
Re: [PATCH v2] watchdog: add SPDX identifiers for watchdog subsystem
On 02/20/2018 05:21 AM, Marcus Folkesson wrote: Hello William, On Tue, Feb 20, 2018 at 07:49:55AM -0500, William Breathitt Gray wrote: On Tue, Feb 20, 2018 at 11:45:31AM +0100, Marcus Folkesson wrote: - Add SPDX identifier - Remove boiler plate license text - If MODULE_LICENSE and boiler plate does not match, go for boiler plate license Signed-off-by: Marcus Folkesson Acked-by: Adam Thomson Acked-by: Charles Keepax Acked-by: Nicolas Ferre Acked-by: Michal Simek --- Notes: v2: - Put back removed copyright texts for meson_gxbb_wdt and coh901327_wdt - Change to BSD-3-Clause for meson_gxbb_wdt v1: Please have an extra look at meson_gxbb_wdt.c [...] diff --git a/drivers/watchdog/ebc-c384_wdt.c b/drivers/watchdog/ebc-c384_wdt.c index 2170b275ea01..c173b6f5c866 100644 --- a/drivers/watchdog/ebc-c384_wdt.c +++ b/drivers/watchdog/ebc-c384_wdt.c @@ -1,15 +1,8 @@ +// SPDX-License-Identifier: GPL-2.0 /* * Watchdog timer driver for the WinSystems EBC-C384 * Copyright (C) 2016 William Breathitt Gray * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License, version 2, as - * published by the Free Software Foundation. - * - * This program is distributed in the hope that it will be useful, but - * WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU - * General Public License for more details. */ #include #include Thank you for your feedback! I have no problem with adding a SPDX line to the top of this file, but use "SPDX-License-Identifier: GPL-2.0-only" as I was very intentional with the selection of GPL version 2 only when I published this code. SPDX-License-Identifier: GPL-2.0 Is GPL-2.0 only [1], so it respects your choice of license. Furthermore, please do not remove the existing copyright text; although It is not a matter if you CAN keep a copyright. You MUST NOT remove a copyright. As long as you do, the series is Nacked-by: Guenter Roeck Guenter The copyright text: Copyright (C) 2016 William Breathitt Gray Is still in the file. it's just boilerplate for some, I was careful with the selection of these words, and I worry the SPDX line only -- despite its useful conciseness -- may lead to misunderstandings about my intentioned license for this code. I'm not sure I understand your concerns here, the SPDX identifier is a shorthand for the GPL 2.0 only license. See [1] - Linux kernel licensing rules. One of the biggest benefits with SPDX identifier is that it is hard to verify boiler plate licenses due to formatting, types, different formulations and so on. If still worrying, I think we could keep the license text as well. For the time being, I can't Ack this patch with the changes it makes currently: Nacked-by: William Breathitt Gray William Breathitt Gray Please let me know if I got you wrong at some point. [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst Best regards Marcus Folkesson
Re: [PATCH v2] watchdog: add SPDX identifiers for watchdog subsystem
On 02/20/2018 11:45 AM, Marcus Folkesson wrote: > - Add SPDX identifier > - Remove boiler plate license text > - If MODULE_LICENSE and boiler plate does not match, go for boiler plate > license > > Signed-off-by: Marcus Folkesson > Acked-by: Adam Thomson > Acked-by: Charles Keepax > Acked-by: Nicolas Ferre > Acked-by: Michal Simek > --- > > Notes: > v2: > - Put back removed copyright texts for meson_gxbb_wdt and coh901327_wdt > - Change to BSD-3-Clause for meson_gxbb_wdt > v1: Please have an extra look at meson_gxbb_wdt.c > > drivers/watchdog/acquirewdt.c | 6 +--- [...] > drivers/watchdog/mpc8xxx_wdt.c | 6 +--- > drivers/watchdog/mt7621_wdt.c | 5 +--- > drivers/watchdog/mtk_wdt.c | 11 +--- > drivers/watchdog/mtx-1_wdt.c | 11 +--- > drivers/watchdog/mv64x60_wdt.c | 6 ++-- [...] > diff --git a/drivers/watchdog/mtk_wdt.c b/drivers/watchdog/mtk_wdt.c > index 7ed417a765c7..498e7d4e1b66 100644 > --- a/drivers/watchdog/mtk_wdt.c > +++ b/drivers/watchdog/mtk_wdt.c > @@ -1,3 +1,4 @@ > +// SPDX-License-Identifier: GPL-2.0+ > /* > * Mediatek Watchdog Driver > * > @@ -5,16 +6,6 @@ > * > * Matthias Brugger > * > - * This program is free software; you can redistribute it and/or modify > - * it under the terms of the GNU General Public License as published by > - * the Free Software Foundation; either version 2 of the License, or > - * (at your option) any later version. > - * > - * This program is distributed in the hope that it will be useful, > - * but WITHOUT ANY WARRANTY; without even the implied warranty of > - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > - * GNU General Public License for more details. > - * > * Based on sunxi_wdt.c > */ > Acked-by: Matthias Brugger
Re: [PATCH v2] watchdog: add SPDX identifiers for watchdog subsystem
On Tue, Feb 20, 2018 at 01:14:27PM -0500, William Breathitt Gray wrote: > On Tue, Feb 20, 2018 at 04:33:26PM +0100, Marcus Folkesson wrote: > >On Tue, Feb 20, 2018 at 07:13:43AM -0800, Guenter Roeck wrote: > >> On 02/20/2018 05:21 AM, Marcus Folkesson wrote: > >> > Hello William, > >> > > >> > On Tue, Feb 20, 2018 at 07:49:55AM -0500, William Breathitt Gray wrote: > >> > > On Tue, Feb 20, 2018 at 11:45:31AM +0100, Marcus Folkesson wrote: > >> > > > - Add SPDX identifier > >> > > > - Remove boiler plate license text > >> > > > - If MODULE_LICENSE and boiler plate does not match, go for boiler > >> > > > plate > >> > > > license > >> > > > > >> > > > Signed-off-by: Marcus Folkesson > >> > > > Acked-by: Adam Thomson > >> > > > Acked-by: Charles Keepax > >> > > > Acked-by: Nicolas Ferre > >> > > > Acked-by: Michal Simek > >> > > > --- > >> > > > > >> > > > Notes: > >> > > > v2: > >> > > > - Put back removed copyright texts for meson_gxbb_wdt and > >> > > > coh901327_wdt > >> > > > - Change to BSD-3-Clause for meson_gxbb_wdt > >> > > > v1: Please have an extra look at meson_gxbb_wdt.c > >> > > > >> > > [...] > >> > > > >> > > > diff --git a/drivers/watchdog/ebc-c384_wdt.c > >> > > > b/drivers/watchdog/ebc-c384_wdt.c > >> > > > index 2170b275ea01..c173b6f5c866 100644 > >> > > > --- a/drivers/watchdog/ebc-c384_wdt.c > >> > > > +++ b/drivers/watchdog/ebc-c384_wdt.c > >> > > > @@ -1,15 +1,8 @@ > >> > > > +// SPDX-License-Identifier: GPL-2.0 > >> > > > /* > >> > > > * Watchdog timer driver for the WinSystems EBC-C384 > >> > > > * Copyright (C) 2016 William Breathitt Gray > >> > > > * > > > >The copyright is untouched? > > > >> > > > - * This program is free software; you can redistribute it and/or > >> > > > modify > >> > > > - * it under the terms of the GNU General Public License, version 2, > >> > > > as > >> > > > - * published by the Free Software Foundation. > >> > > > - * > >> > > > - * This program is distributed in the hope that it will be useful, > >> > > > but > >> > > > - * WITHOUT ANY WARRANTY; without even the implied warranty of > >> > > > - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > >> > > > - * General Public License for more details. > >> > > > */ > >> > > > #include > >> > > > #include > >> > > >> > Thank you for your feedback! > >> > > > >> > > I have no problem with adding a SPDX line to the top of this file, but > >> > > use "SPDX-License-Identifier: GPL-2.0-only" as I was very intentional > >> > > with the selection of GPL version 2 only when I published this code. > >> > > >> > SPDX-License-Identifier: GPL-2.0 > >> > Is GPL-2.0 only [1], so it respects your choice of license. > > Ah, this should be fine then. :) > Good! > >> > > >> > > > >> > > Furthermore, please do not remove the existing copyright text; although > >> > > >> > >> It is not a matter if you CAN keep a copyright. You MUST NOT remove a > >> copyright. > >> As long as you do, the series is > >> > >> Nacked-by: Guenter Roeck > >> > >> Guenter > > > >I'm sorry, I do not see where the copyright is removed unless you count > >the license text as part of the copyright. > > > >Can you please point it out? > > > >> > >> > The copyright text: > >> > > >> > Copyright (C) 2016 William Breathitt Gray > >> > > >> > Is still in the file. > > > >^^^ > > > >> > > >> > > >> > > it's just boilerplate for some, I was careful with the selection of > >> > > these words, and I worry the SPDX line only -- despite its useful > >> > > conciseness -- may lead to misunderstandings about my intentioned > >> > > license for this code. > >> > > >> > I'm not sure I understand your concerns here, the SPDX identifier is > >> > a shorthand for the GPL 2.0 only license. See [1] - Linux kernel > >> > licensing rules. > >> > > >> > One of the biggest benefits with SPDX identifier is that it is hard to > >> > verify > >> > boiler plate licenses due to formatting, types, different formulations > >> > and so on. > >> > > >> > If still worrying, I think we could keep the license text as > >> > well. > > I'm sorry for the confusion, I should have wrote "license text" rather > than "copyright text" in my previous message. I agree with the benefits No problem at all. > of utilizing the SPDX identifier, and I see the addition of the SPDX > line as useful, but I would prefer the original license text remain as > well. Of course, I will keep the the original license intact for v3. > > William Breathitt Gray > Best regards Marcus Folkesson signature.asc Description: PGP signature
Re: [PATCH v2] watchdog: add SPDX identifiers for watchdog subsystem
On Tue, Feb 20, 2018 at 11:45:31AM +0100, Marcus Folkesson wrote: >- Add SPDX identifier >- Remove boiler plate license text >- If MODULE_LICENSE and boiler plate does not match, go for boiler plate > license > >Signed-off-by: Marcus Folkesson >Acked-by: Adam Thomson >Acked-by: Charles Keepax >Acked-by: Nicolas Ferre >Acked-by: Michal Simek >--- > >Notes: >v2: > - Put back removed copyright texts for meson_gxbb_wdt and coh901327_wdt > - Change to BSD-3-Clause for meson_gxbb_wdt >v1: Please have an extra look at meson_gxbb_wdt.c [...] >diff --git a/drivers/watchdog/ebc-c384_wdt.c b/drivers/watchdog/ebc-c384_wdt.c >index 2170b275ea01..c173b6f5c866 100644 >--- a/drivers/watchdog/ebc-c384_wdt.c >+++ b/drivers/watchdog/ebc-c384_wdt.c >@@ -1,15 +1,8 @@ >+// SPDX-License-Identifier: GPL-2.0 > /* > * Watchdog timer driver for the WinSystems EBC-C384 > * Copyright (C) 2016 William Breathitt Gray > * >- * This program is free software; you can redistribute it and/or modify >- * it under the terms of the GNU General Public License, version 2, as >- * published by the Free Software Foundation. >- * >- * This program is distributed in the hope that it will be useful, but >- * WITHOUT ANY WARRANTY; without even the implied warranty of >- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU >- * General Public License for more details. > */ > #include > #include I have no problem with adding a SPDX line to the top of this file, but use "SPDX-License-Identifier: GPL-2.0-only" as I was very intentional with the selection of GPL version 2 only when I published this code. Furthermore, please do not remove the existing copyright text; although it's just boilerplate for some, I was careful with the selection of these words, and I worry the SPDX line only -- despite its useful conciseness -- may lead to misunderstandings about my intentioned license for this code. For the time being, I can't Ack this patch with the changes it makes currently: Nacked-by: William Breathitt Gray William Breathitt Gray
Re: [PATCH v2] watchdog: add SPDX identifiers for watchdog subsystem
Hello William, On Tue, Feb 20, 2018 at 07:49:55AM -0500, William Breathitt Gray wrote: > On Tue, Feb 20, 2018 at 11:45:31AM +0100, Marcus Folkesson wrote: > >- Add SPDX identifier > >- Remove boiler plate license text > >- If MODULE_LICENSE and boiler plate does not match, go for boiler plate > > license > > > >Signed-off-by: Marcus Folkesson > >Acked-by: Adam Thomson > >Acked-by: Charles Keepax > >Acked-by: Nicolas Ferre > >Acked-by: Michal Simek > >--- > > > >Notes: > >v2: > > - Put back removed copyright texts for meson_gxbb_wdt and coh901327_wdt > > - Change to BSD-3-Clause for meson_gxbb_wdt > >v1: Please have an extra look at meson_gxbb_wdt.c > > [...] > > >diff --git a/drivers/watchdog/ebc-c384_wdt.c > >b/drivers/watchdog/ebc-c384_wdt.c > >index 2170b275ea01..c173b6f5c866 100644 > >--- a/drivers/watchdog/ebc-c384_wdt.c > >+++ b/drivers/watchdog/ebc-c384_wdt.c > >@@ -1,15 +1,8 @@ > >+// SPDX-License-Identifier: GPL-2.0 > > /* > > * Watchdog timer driver for the WinSystems EBC-C384 > > * Copyright (C) 2016 William Breathitt Gray > > * > >- * This program is free software; you can redistribute it and/or modify > >- * it under the terms of the GNU General Public License, version 2, as > >- * published by the Free Software Foundation. > >- * > >- * This program is distributed in the hope that it will be useful, but > >- * WITHOUT ANY WARRANTY; without even the implied warranty of > >- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > >- * General Public License for more details. > > */ > > #include > > #include Thank you for your feedback! > > I have no problem with adding a SPDX line to the top of this file, but > use "SPDX-License-Identifier: GPL-2.0-only" as I was very intentional > with the selection of GPL version 2 only when I published this code. SPDX-License-Identifier: GPL-2.0 Is GPL-2.0 only [1], so it respects your choice of license. > > Furthermore, please do not remove the existing copyright text; although The copyright text: Copyright (C) 2016 William Breathitt Gray Is still in the file. > it's just boilerplate for some, I was careful with the selection of > these words, and I worry the SPDX line only -- despite its useful > conciseness -- may lead to misunderstandings about my intentioned > license for this code. I'm not sure I understand your concerns here, the SPDX identifier is a shorthand for the GPL 2.0 only license. See [1] - Linux kernel licensing rules. One of the biggest benefits with SPDX identifier is that it is hard to verify boiler plate licenses due to formatting, types, different formulations and so on. If still worrying, I think we could keep the license text as well. > > For the time being, I can't Ack this patch with the changes it makes > currently: > > Nacked-by: William Breathitt Gray > > William Breathitt Gray Please let me know if I got you wrong at some point. [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst Best regards Marcus Folkesson signature.asc Description: PGP signature
Re: [PATCH v2] watchdog: add SPDX identifiers for watchdog subsystem
On 20/02/2018 11:45, Marcus Folkesson wrote: > - Add SPDX identifier > - Remove boiler plate license text > - If MODULE_LICENSE and boiler plate does not match, go for boiler plate > license > > Signed-off-by: Marcus Folkesson > Acked-by: Adam Thomson > Acked-by: Charles Keepax > Acked-by: Nicolas Ferre > Acked-by: Michal Simek > --- > > Notes: > v2: > - Put back removed copyright texts for meson_gxbb_wdt and coh901327_wdt > - Change to BSD-3-Clause for meson_gxbb_wdt > v1: Please have an extra look at meson_gxbb_wdt.c > > drivers/watchdog/acquirewdt.c | 6 +--- > drivers/watchdog/advantechwdt.c| 6 +--- > drivers/watchdog/alim1535_wdt.c| 6 +--- > drivers/watchdog/alim7101_wdt.c| 1 + > drivers/watchdog/ar7_wdt.c | 14 +- > drivers/watchdog/asm9260_wdt.c | 2 +- > drivers/watchdog/aspeed_wdt.c | 5 +--- > drivers/watchdog/at91rm9200_wdt.c | 5 +--- > drivers/watchdog/at91sam9_wdt.c| 5 +--- > drivers/watchdog/at91sam9_wdt.h| 5 +--- > drivers/watchdog/ath79_wdt.c | 4 +-- > drivers/watchdog/atlas7_wdt.c | 2 +- > drivers/watchdog/bcm2835_wdt.c | 5 +--- > drivers/watchdog/bcm47xx_wdt.c | 5 +--- > drivers/watchdog/bcm63xx_wdt.c | 5 +--- > drivers/watchdog/bcm7038_wdt.c | 12 ++-- > drivers/watchdog/bcm_kona_wdt.c| 9 +- > drivers/watchdog/bfin_wdt.c| 2 +- > drivers/watchdog/booke_wdt.c | 5 +--- > drivers/watchdog/cadence_wdt.c | 5 +--- > drivers/watchdog/coh901327_wdt.c | 4 +-- > drivers/watchdog/cpu5wdt.c | 15 +- > drivers/watchdog/cpwd.c| 1 + > drivers/watchdog/da9052_wdt.c | 6 +--- > drivers/watchdog/da9055_wdt.c | 6 +--- > drivers/watchdog/da9062_wdt.c | 10 +-- > drivers/watchdog/da9063_wdt.c | 5 +--- > drivers/watchdog/davinci_wdt.c | 7 ++--- > drivers/watchdog/diag288_wdt.c | 1 + > drivers/watchdog/digicolor_wdt.c | 5 +--- > drivers/watchdog/dw_wdt.c | 6 +--- > drivers/watchdog/ebc-c384_wdt.c| 9 +- > drivers/watchdog/ep93xx_wdt.c | 7 ++--- > drivers/watchdog/eurotechwdt.c | 6 +--- > drivers/watchdog/f71808e_wdt.c | 16 +-- > drivers/watchdog/ftwdt010_wdt.c| 6 ++-- > drivers/watchdog/gef_wdt.c | 6 +--- > drivers/watchdog/geodewdt.c| 5 +--- > drivers/watchdog/gpio_wdt.c| 5 +--- > drivers/watchdog/hpwdt.c | 7 ++--- > drivers/watchdog/i6300esb.c| 6 +--- > drivers/watchdog/iTCO_vendor_support.c | 9 +- > drivers/watchdog/iTCO_wdt.c| 10 +-- > drivers/watchdog/ib700wdt.c| 6 +--- > drivers/watchdog/ibmasr.c | 3 +- > drivers/watchdog/ie6xx_wdt.c | 18 ++-- > drivers/watchdog/imgpdc_wdt.c | 5 +--- > drivers/watchdog/imx2_wdt.c| 5 +--- > drivers/watchdog/indydog.c | 6 +--- > drivers/watchdog/intel-mid_wdt.c | 6 ++-- > drivers/watchdog/intel_scu_watchdog.c | 18 ++-- > drivers/watchdog/intel_scu_watchdog.h | 16 +-- > drivers/watchdog/iop_wdt.c | 16 ++- > drivers/watchdog/it8712f_wdt.c | 10 +-- > drivers/watchdog/it87_wdt.c| 10 +-- > drivers/watchdog/ixp4xx_wdt.c | 6 ++-- > drivers/watchdog/jz4740_wdt.c | 10 +-- > drivers/watchdog/kempld_wdt.c | 12 ++-- > drivers/watchdog/ks8695_wdt.c | 6 ++-- > drivers/watchdog/lantiq_wdt.c | 7 ++--- > drivers/watchdog/loongson1_wdt.c | 5 +--- > drivers/watchdog/lpc18xx_wdt.c | 5 +--- > drivers/watchdog/m54xx_wdt.c | 6 ++-- > drivers/watchdog/machzwd.c | 11 +--- > drivers/watchdog/max63xx_wdt.c | 5 +--- > drivers/watchdog/max77620_wdt.c| 5 +--- > drivers/watchdog/mei_wdt.c | 12 ++-- > drivers/watchdog/mena21_wdt.c | 4 +-- > drivers/watchdog/menf21bmc_wdt.c | 8 ++ > drivers/watchdog/meson_gxbb_wdt.c | 50 > +- > drivers/watchdog/meson_wdt.c | 6 +--- > drivers/watchdog/mixcomwd.c| 6 +--- > drivers/watchdog/moxart_wdt.c | 7 ++--- > drivers/watchdog/mpc8xxx_wdt.c | 6 +--- > drivers/watchdog/mt7621_wdt.c | 5 +--- > drivers/watchdog/mtk_wdt.c | 11 +--- > drivers/watchdog/mtx-1_wdt.c | 11 +--- > drivers/watchdog/mv64x60_wdt.c | 6 ++-- > drivers/watchdog/ni903x_wdt.c | 11 +--- > drivers/watchdog/nic7018_wdt.c | 11 +--- > drivers/watchdog/nuc900_wdt.c | 7 ++--- > drivers/watchdog/nv_tco.c | 6 +--- > drivers/watchdog/nv_tco.h | 10 +--
Re: [PATCH v2] watchdog: add SPDX identifiers for watchdog subsystem
On Tue, Feb 20, 2018 at 11:45:31AM +0100, Marcus Folkesson wrote: [...] > drivers/watchdog/tegra_wdt.c | 10 +-- [...] Acked-by: Thierry Reding signature.asc Description: PGP signature
Re: [PATCH v2] watchdog: add SPDX identifiers for watchdog subsystem
Marcus Folkesson writes: > - Add SPDX identifier > - Remove boiler plate license text > - If MODULE_LICENSE and boiler plate does not match, go for boiler plate > license > > Signed-off-by: Marcus Folkesson > Acked-by: Adam Thomson > Acked-by: Charles Keepax > Acked-by: Nicolas Ferre > Acked-by: Michal Simek > --- > > Notes: > v2: > - Put back removed copyright texts for meson_gxbb_wdt and coh901327_wdt > - Change to BSD-3-Clause for meson_gxbb_wdt > v1: Please have an extra look at meson_gxbb_wdt.c [...] > drivers/watchdog/tangox_wdt.c | 6 +--- For tangox_wdt: Acked-by: Mans Rullgard -- Måns Rullgård
