Re: Need Volunteers to test patch for gnu make

2006-09-09 Thread Eli Zaretskii
> From: "Gary R. Van Sickle" <[EMAIL PROTECTED]>
> Date: Fri, 8 Sep 2006 22:17:26 -0500
> 
> > Since folks seem to be adverse to building from source, I have made 
> > the patched make.exe available here:
> > 
> > http://www.cmake.org/files/cygwin/make.exe
> 
> You might want to strip this; it's ~4xxkB unstripped, 147kB stripped.

Actually, I think it's a good idea to have a non-stripped binary
there: this way, users can make meaningful bug reports even though
they don't have sources readily available.  Stripping the binary is
easy and fast, if you want that (not that I can imagine why would
anyone care about 300KB of disk space).

> I just finished trying it on my standard test, building a cvs pull of
> wxWindows tip.  Worked like a charm.  It even shaved almost 18 seconds (!)
> (;-)) off my build time:

Thanks for testing.


___
Make-w32 mailing list
Make-w32@gnu.org
http://lists.gnu.org/mailman/listinfo/make-w32


Re: Problems with latest Cygwin make patch; builds OK but binary segfaults

2006-09-09 Thread Eli Zaretskii
> Date: Fri, 8 Sep 2006 18:14:38 -0400
> From: Christopher Faylor <[EMAIL PROTECTED]>
> 
> On Fri, Sep 08, 2006 at 11:47:22PM +0300, Eli Zaretskii wrote:
> >>Date: Fri, 8 Sep 2006 13:51:21 -0400
> >>From: Christopher Faylor
> >> 
> >>So, again, I'd like to go slowly and carefully with this change.
> >
> >I agree, and said I would wait, but I can't wait indefinitely.
> >Eventually, if no one else cares to try these changes, they will go in.
> 
> Personally, I think it sets a bad precedent to suggest that you'll apply
> a patch over the potential objections of the project lead for the
> affected system.

If you have objections that are based on actual use cases, i.e. if you
(or someone else) can come up with a situation where this patch does,
or could potentially do, some harm, then of course such objections
will never be overruled, not by me, anyway.  Any such objections in
the history of this patch development were always taken in
consideration and acted upon immediately.

Otherwise, it sounds unfair to me to encourage me and others to do
some non-trivial amount of work, only to hold the results back after
the job is done and approved by everyone involved, including yourself.

> However, you might as well go ahead and check in the patch.  If someone
> notes a problem then presumably it can be reported back to this mailing
> list.  But, at least, you won't have to suffer with an "indefinite" wait
> before the patch is checked in.
> 
> And in the meantime, since this is free software, if I don't agree that
> this change should be in the Cygwin release, I can always back it out in
> the next release.

True on both accounts.

However, I personally am in no hurry; when I said ``indefinitely'', I
really meant a VERY long time.  As no Make release is planned any time
soon (AFAIK), I don't see any reason to interpret ``indefinite'' as
meaning ``a few days''.  If you don't think the Cygwin user community
needs the patched version ASAP, I certainly won't push that against
your opinion.

In the meantime, I see we have another positive experience reported on
the Cygwin list.


___
Make-w32 mailing list
Make-w32@gnu.org
http://lists.gnu.org/mailman/listinfo/make-w32


Re: Need Volunteers to test patch for gnu make

2006-09-09 Thread Gary R. Van Sickle
(not cross-posting, but I did post this same email to cygwin-at)

Hi Bill,

> From: William A. Hoffman
> Sent: Friday, September 08, 2006 2:35 PM
> Subject: Re: Need Volunteers to test patch for gnu make
> 
> At 12:38 PM 9/8/2006, William A. Hoffman wrote:
> 
> >Thanks Bob.   OK, so that is three people that have tested 
> this patch.
> >Please try the patch if you use make.  DOS paths will be on
> by DEFAULT
> >and there will be no way to turn it off.   We want to make 
> sure this does
> >not break any POSIX based makefiles.   
> 
> Since folks seem to be adverse to building from source, I have made 
> the patched make.exe available here:
> 
> http://www.cmake.org/files/cygwin/make.exe

You might want to strip this; it's ~4xxkB unstripped, 147kB stripped.

> Please try it, and report any problems on this list.
> 
> Thanks.
> 
> -Bill
> 

I just finished trying it on my standard test, building a cvs pull of
wxWindows tip.  Worked like a charm.  It even shaved almost 18 seconds (!)
(;-)) off my build time:

Old make:

$ time make
[...]

real23m30.751s
user3m57.150s
sys 3m2.379s

New make (i.e. the one from your link, but stripped):

$ time make
[...]

real23m13.115s
   ^^ 18 seconds saved (approx. 1%)
user3m56.285s
sys 3m2.261s

So, I shall take that 18 seconds to also thank you for your great work. ;-)

-- 
Gary R. Van Sickle



___
Make-w32 mailing list
Make-w32@gnu.org
http://lists.gnu.org/mailman/listinfo/make-w32