Re: [matplotlib-devel] gtk backend silently ignores all exceptions
Sorry. That was a mistake to commit it -- I did this while I was trying to track down a segfault. I will revert it. Mike Jae-Joon Lee wrote: > Michael, > > It seems that the gtk backend in the current svn silently ignores ALL > exceptions raised during the drawing. > > http://matplotlib.svn.sourceforge.net/viewvc/matplotlib/trunk/matplotlib/lib/matplotlib/backends/backend_gtk.py?r1=6696&r2=6793 > > Is this necessary? I don't think we want to do this. > > Regards, > > -JJ > > -- > This SF.net email is sponsored by: > SourcForge Community > SourceForge wants to tell your story. > http://p.sf.net/sfu/sf-spreadtheword > ___ > Matplotlib-devel mailing list > Matplotlib-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/matplotlib-devel > -- This SF.net email is sponsored by: SourcForge Community SourceForge wants to tell your story. http://p.sf.net/sfu/sf-spreadtheword ___ Matplotlib-devel mailing list Matplotlib-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/matplotlib-devel
Re: [matplotlib-devel] gtk backend silently ignores all exceptions
On Mon, Jan 26, 2009 at 6:02 PM, Jae-Joon Lee wrote: > Michael, > > It seems that the gtk backend in the current svn silently ignores ALL > exceptions raised during the drawing. > > http://matplotlib.svn.sourceforge.net/viewvc/matplotlib/trunk/matplotlib/lib/matplotlib/backends/backend_gtk.py?r1=6696&r2=6793 > > Is this necessary? I don't think we want to do this. No, it is a bug. Catching blanket exceptions and ignoring them is never OK -- we need to add a section to the coding guide to this effect. If absolutely necessary, one can catch blanket exceptions and log them, eg using cbook.exception_to_str, but they must be reported. Michael has already fixed this (perhaps it was some detritus left in from a debugging session?) and I'll make a note in the developer docs coding guide. -- This SF.net email is sponsored by: SourcForge Community SourceForge wants to tell your story. http://p.sf.net/sfu/sf-spreadtheword ___ Matplotlib-devel mailing list Matplotlib-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/matplotlib-devel
Re: [matplotlib-devel] Line2D.set_pickradius missing in svn
On Tue, Jan 27, 2009 at 12:28 AM, Eric Firing wrote: > Martin Spacek wrote: >> >> Hi, >> >> I just updated my checkout to rev 6829, and it seems >> lines.Line2D.set_pickradius has been renamed to setpickradius. Is this a >> typo? get_pickradius still exists. This is on line 318 in lines.py. Renaming >> it back to set_pickradius seems make it work the way it used to. >> > > John, you made the change on Dec. 10: > > http://currents.soest.hawaii.edu/hg/hgwebdir.cgi/matplotlib_mirror/diff/0a8f5203a8fd/matplotlib/lib/matplotlib/lines.py > > Looks accidental to me. Yep, it must have been a bug because it doesn't follow the naming conventions for the set_property funcs. Fixed on branch and trunk. Thanks for tracking me down as the culprit :-) JDH -- This SF.net email is sponsored by: SourcForge Community SourceForge wants to tell your story. http://p.sf.net/sfu/sf-spreadtheword ___ Matplotlib-devel mailing list Matplotlib-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/matplotlib-devel
Re: [matplotlib-devel] gtk backend silently ignores all exceptions
John Hunter wrote: > On Mon, Jan 26, 2009 at 6:02 PM, Jae-Joon Lee wrote: >> Michael, >> >> It seems that the gtk backend in the current svn silently ignores ALL >> exceptions raised during the drawing. >> >> http://matplotlib.svn.sourceforge.net/viewvc/matplotlib/trunk/matplotlib/lib/matplotlib/backends/backend_gtk.py?r1=6696&r2=6793 >> >> Is this necessary? I don't think we want to do this. > > No, it is a bug. Catching blanket exceptions and ignoring them is > never OK -- we need to add a section to the coding guide to this > effect. If absolutely necessary, one can catch blanket exceptions and > log them, eg using cbook.exception_to_str, but they must be reported. > Michael has already fixed this (perhaps it was some detritus left in > from a debugging session?) and I'll make a note in the developer docs > coding guide. John, Not quite "always": I think that for something like cbook.is_string_like we actually *do* want to silently catch all exceptions. The problem is that if you know nothing about the type of object that you might have to deal with, you have no way of knowing what exception it might raise. We ran into an example of this recently. Eric > > -- > This SF.net email is sponsored by: > SourcForge Community > SourceForge wants to tell your story. > http://p.sf.net/sfu/sf-spreadtheword > ___ > Matplotlib-devel mailing list > Matplotlib-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/matplotlib-devel -- This SF.net email is sponsored by: SourcForge Community SourceForge wants to tell your story. http://p.sf.net/sfu/sf-spreadtheword ___ Matplotlib-devel mailing list Matplotlib-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/matplotlib-devel
[matplotlib-devel] online docs updating?
Hi, Do the online docs automatically update themselves from changes in SVN? I thought there was a nightly cron. I made some changes a few days ago (just a few typos) and they haven't shown up online yet. The changes were to doc/users/shell.rst. I'm assuming I should see the corresponding changes on http://matplotlib.sourceforge.net/users/shell.html. Ryan -- Ryan May Graduate Research Assistant School of Meteorology University of Oklahoma -- This SF.net email is sponsored by: SourcForge Community SourceForge wants to tell your story. http://p.sf.net/sfu/sf-spreadtheword ___ Matplotlib-devel mailing list Matplotlib-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/matplotlib-devel
Re: [matplotlib-devel] online docs updating?
On Tue, Jan 27, 2009 at 3:33 PM, Ryan May wrote: > Hi, > > Do the online docs automatically update themselves from changes in SVN? I > thought there was a nightly cron. I made some changes a few days ago (just a > few > typos) and they haven't shown up online yet. The changes were to > doc/users/shell.rst. I'm assuming I should see the corresponding changes on > http://matplotlib.sourceforge.net/users/shell.html. I had them in a cron and voluntarily disabled it. I'm amenable to re-enabling it. The problem is that as examples become available in svn, they automatically get pushed out to the gallery, but these may not run on the latest released version. I thought perhaps the site should more closely track the latest released version, so the last few times I've pushed the docs out, I did so from the branch. So if you want to see doc changes get pushed out sooner, you should patch the branch and merge to the trunk. I am in general a big fan of encouraging people to use the svn snapshots as much as possible, and updating the gallery and site docs nightly helps this because the new features in the gallery entice them, but in the absence of nightly builds and snapshots I don't think this is too helpful. JDH -- This SF.net email is sponsored by: SourcForge Community SourceForge wants to tell your story. http://p.sf.net/sfu/sf-spreadtheword ___ Matplotlib-devel mailing list Matplotlib-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/matplotlib-devel
