[jira] [Created] (OAK-8364) LastRevRecoveryAgent may log warn message for bundled node
Marcel Reutegger created OAK-8364:
-
Summary: LastRevRecoveryAgent may log warn message for bundled node
Key: OAK-8364
URL: https://issues.apache.org/jira/browse/OAK-8364
Project: Jackrabbit Oak
Issue Type: Bug
Components: documentmk
Affects Versions: 1.12.0, 1.10.0, 1.8.0, 1.6.0
Reporter: Marcel Reutegger
OAK-1312 introduced a new feature with Oak 1.6 that allowed the
DocumentNodeStore to store multiple nodes in the same document.
http://jackrabbit.apache.org/oak/docs/nodestore/document/node-bundling.html
The
[recovery|https://github.com/apache/jackrabbit-oak/tree/trunk/oak-run#recovery-mode]
command logs warn messages on on descendants of nodes that are bundled. The
LastRevRecoveryAgent complains about missing document. E.g. consider a
configuration that bundles the jcr:content child node into the parent nt:file
node. If the jcr:content node has descendant nodes, the LastRevRecoveryAgent
may log a warn message like this:
{noformat}
Unable to find document: 4:/content/folder/my-file.txt/jcr:content
{noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OAK-8207) Read-only DocumentNodeStore tries to create root document
[
https://issues.apache.org/jira/browse/OAK-8207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16849962#comment-16849962
]
Julian Reschke commented on OAK-8207:
-
trunk: [r1857238|http://svn.apache.org/r1857238]
[r1857212|http://svn.apache.org/r1857212]
1.10: [r1857299|http://svn.apache.org/r1857299]
1.8: [r1860291|http://svn.apache.org/r1860291]
> Read-only DocumentNodeStore tries to create root document
> -
>
> Key: OAK-8207
> URL: https://issues.apache.org/jira/browse/OAK-8207
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: documentmk
>Reporter: Marcel Reutegger
>Assignee: Marcel Reutegger
>Priority: Minor
> Fix For: 1.10.3, 1.14.0, 1.8.14
>
> Attachments: OAK-8207-1.8.diff
>
>
> When connecting a read-only DocumentNodeStore to a DocumentStore with an
> empty {{nodes}} collection, the DocumentNodeStore tries to create the root
> document. The operation then fails with something like:
> {noformat}
> Exception in thread "main"
> org.apache.jackrabbit.oak.plugins.document.DocumentStoreException: Method -
> createOrUpdate. Params: [nodes, [key: 0:/ new
> {_deleted.r16a020ebbbf-0-0=SET_MAP_ENTRY false,
> _commitRoot.r16a020ebbbf-0-0=SET_MAP_ENTRY 0, _modified=MAX 1554812680}]]
> at
> org.apache.jackrabbit.oak.plugins.document.DocumentStoreException.asDocumentStoreException(DocumentStoreException.java:179)
> at
> org.apache.jackrabbit.oak.plugins.document.DocumentStoreException.convert(DocumentStoreException.java:131)
> at
> org.apache.jackrabbit.oak.plugins.document.DocumentStoreException.convert(DocumentStoreException.java:114)
> at
> org.apache.jackrabbit.oak.plugins.document.Commit.applyToDocumentStore(Commit.java:425)
> at
> org.apache.jackrabbit.oak.plugins.document.Commit.applyToDocumentStoreWithTiming(Commit.java:280)
> at
> org.apache.jackrabbit.oak.plugins.document.Commit.applyToDocumentStore(Commit.java:264)
> at
> org.apache.jackrabbit.oak.plugins.document.DocumentNodeStore.(DocumentNodeStore.java:624)
> at
> org.apache.jackrabbit.oak.plugins.document.DocumentNodeStoreBuilder.build(DocumentNodeStoreBuilder.java:174)
> at
> org.apache.jackrabbit.oak.run.ClusterNodesCommand.execute(ClusterNodesCommand.java:65)
> at org.apache.jackrabbit.oak.run.Main.main(Main.java:49)
> Caused by: java.lang.UnsupportedOperationException: Method - createOrUpdate.
> Params: [nodes, [key: 0:/ new {_deleted.r16a020ebbbf-0-0=SET_MAP_ENTRY false,
> _commitRoot.r16a020ebbbf-0-0=SET_MAP_ENTRY 0, _modified=MAX 1554812680}]]
> at
> org.apache.jackrabbit.oak.plugins.document.util.ReadOnlyDocumentStoreWrapperFactory$1.invoke(ReadOnlyDocumentStoreWrapperFactory.java:38)
> at com.sun.proxy.$Proxy0.createOrUpdate(Unknown Source)
> at
> org.apache.jackrabbit.oak.plugins.document.Commit.applyToDocumentStore(Commit.java:365)
> ... 6 more
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Issue Comment Deleted] (OAK-8207) Read-only DocumentNodeStore tries to create root document
[
https://issues.apache.org/jira/browse/OAK-8207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Reschke updated OAK-8207:
Comment: was deleted
(was: trunk: [r1857238|http://svn.apache.org/r1857238]
[r1857212|http://svn.apache.org/r1857212]
1.10: [r1857299|http://svn.apache.org/r1857299])
> Read-only DocumentNodeStore tries to create root document
> -
>
> Key: OAK-8207
> URL: https://issues.apache.org/jira/browse/OAK-8207
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: documentmk
>Reporter: Marcel Reutegger
>Assignee: Marcel Reutegger
>Priority: Minor
> Fix For: 1.10.3, 1.14.0, 1.8.14
>
> Attachments: OAK-8207-1.8.diff
>
>
> When connecting a read-only DocumentNodeStore to a DocumentStore with an
> empty {{nodes}} collection, the DocumentNodeStore tries to create the root
> document. The operation then fails with something like:
> {noformat}
> Exception in thread "main"
> org.apache.jackrabbit.oak.plugins.document.DocumentStoreException: Method -
> createOrUpdate. Params: [nodes, [key: 0:/ new
> {_deleted.r16a020ebbbf-0-0=SET_MAP_ENTRY false,
> _commitRoot.r16a020ebbbf-0-0=SET_MAP_ENTRY 0, _modified=MAX 1554812680}]]
> at
> org.apache.jackrabbit.oak.plugins.document.DocumentStoreException.asDocumentStoreException(DocumentStoreException.java:179)
> at
> org.apache.jackrabbit.oak.plugins.document.DocumentStoreException.convert(DocumentStoreException.java:131)
> at
> org.apache.jackrabbit.oak.plugins.document.DocumentStoreException.convert(DocumentStoreException.java:114)
> at
> org.apache.jackrabbit.oak.plugins.document.Commit.applyToDocumentStore(Commit.java:425)
> at
> org.apache.jackrabbit.oak.plugins.document.Commit.applyToDocumentStoreWithTiming(Commit.java:280)
> at
> org.apache.jackrabbit.oak.plugins.document.Commit.applyToDocumentStore(Commit.java:264)
> at
> org.apache.jackrabbit.oak.plugins.document.DocumentNodeStore.(DocumentNodeStore.java:624)
> at
> org.apache.jackrabbit.oak.plugins.document.DocumentNodeStoreBuilder.build(DocumentNodeStoreBuilder.java:174)
> at
> org.apache.jackrabbit.oak.run.ClusterNodesCommand.execute(ClusterNodesCommand.java:65)
> at org.apache.jackrabbit.oak.run.Main.main(Main.java:49)
> Caused by: java.lang.UnsupportedOperationException: Method - createOrUpdate.
> Params: [nodes, [key: 0:/ new {_deleted.r16a020ebbbf-0-0=SET_MAP_ENTRY false,
> _commitRoot.r16a020ebbbf-0-0=SET_MAP_ENTRY 0, _modified=MAX 1554812680}]]
> at
> org.apache.jackrabbit.oak.plugins.document.util.ReadOnlyDocumentStoreWrapperFactory$1.invoke(ReadOnlyDocumentStoreWrapperFactory.java:38)
> at com.sun.proxy.$Proxy0.createOrUpdate(Unknown Source)
> at
> org.apache.jackrabbit.oak.plugins.document.Commit.applyToDocumentStore(Commit.java:365)
> ... 6 more
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OAK-8207) Read-only DocumentNodeStore tries to create root document
[
https://issues.apache.org/jira/browse/OAK-8207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Reschke updated OAK-8207:
Fix Version/s: 1.8.14
> Read-only DocumentNodeStore tries to create root document
> -
>
> Key: OAK-8207
> URL: https://issues.apache.org/jira/browse/OAK-8207
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: documentmk
>Reporter: Marcel Reutegger
>Assignee: Marcel Reutegger
>Priority: Minor
> Labels: candidate_oak_1_8
> Fix For: 1.10.3, 1.14.0, 1.8.14
>
> Attachments: OAK-8207-1.8.diff
>
>
> When connecting a read-only DocumentNodeStore to a DocumentStore with an
> empty {{nodes}} collection, the DocumentNodeStore tries to create the root
> document. The operation then fails with something like:
> {noformat}
> Exception in thread "main"
> org.apache.jackrabbit.oak.plugins.document.DocumentStoreException: Method -
> createOrUpdate. Params: [nodes, [key: 0:/ new
> {_deleted.r16a020ebbbf-0-0=SET_MAP_ENTRY false,
> _commitRoot.r16a020ebbbf-0-0=SET_MAP_ENTRY 0, _modified=MAX 1554812680}]]
> at
> org.apache.jackrabbit.oak.plugins.document.DocumentStoreException.asDocumentStoreException(DocumentStoreException.java:179)
> at
> org.apache.jackrabbit.oak.plugins.document.DocumentStoreException.convert(DocumentStoreException.java:131)
> at
> org.apache.jackrabbit.oak.plugins.document.DocumentStoreException.convert(DocumentStoreException.java:114)
> at
> org.apache.jackrabbit.oak.plugins.document.Commit.applyToDocumentStore(Commit.java:425)
> at
> org.apache.jackrabbit.oak.plugins.document.Commit.applyToDocumentStoreWithTiming(Commit.java:280)
> at
> org.apache.jackrabbit.oak.plugins.document.Commit.applyToDocumentStore(Commit.java:264)
> at
> org.apache.jackrabbit.oak.plugins.document.DocumentNodeStore.(DocumentNodeStore.java:624)
> at
> org.apache.jackrabbit.oak.plugins.document.DocumentNodeStoreBuilder.build(DocumentNodeStoreBuilder.java:174)
> at
> org.apache.jackrabbit.oak.run.ClusterNodesCommand.execute(ClusterNodesCommand.java:65)
> at org.apache.jackrabbit.oak.run.Main.main(Main.java:49)
> Caused by: java.lang.UnsupportedOperationException: Method - createOrUpdate.
> Params: [nodes, [key: 0:/ new {_deleted.r16a020ebbbf-0-0=SET_MAP_ENTRY false,
> _commitRoot.r16a020ebbbf-0-0=SET_MAP_ENTRY 0, _modified=MAX 1554812680}]]
> at
> org.apache.jackrabbit.oak.plugins.document.util.ReadOnlyDocumentStoreWrapperFactory$1.invoke(ReadOnlyDocumentStoreWrapperFactory.java:38)
> at com.sun.proxy.$Proxy0.createOrUpdate(Unknown Source)
> at
> org.apache.jackrabbit.oak.plugins.document.Commit.applyToDocumentStore(Commit.java:365)
> ... 6 more
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OAK-8207) Read-only DocumentNodeStore tries to create root document
[
https://issues.apache.org/jira/browse/OAK-8207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Reschke updated OAK-8207:
Labels: (was: candidate_oak_1_8)
> Read-only DocumentNodeStore tries to create root document
> -
>
> Key: OAK-8207
> URL: https://issues.apache.org/jira/browse/OAK-8207
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: documentmk
>Reporter: Marcel Reutegger
>Assignee: Marcel Reutegger
>Priority: Minor
> Fix For: 1.10.3, 1.14.0, 1.8.14
>
> Attachments: OAK-8207-1.8.diff
>
>
> When connecting a read-only DocumentNodeStore to a DocumentStore with an
> empty {{nodes}} collection, the DocumentNodeStore tries to create the root
> document. The operation then fails with something like:
> {noformat}
> Exception in thread "main"
> org.apache.jackrabbit.oak.plugins.document.DocumentStoreException: Method -
> createOrUpdate. Params: [nodes, [key: 0:/ new
> {_deleted.r16a020ebbbf-0-0=SET_MAP_ENTRY false,
> _commitRoot.r16a020ebbbf-0-0=SET_MAP_ENTRY 0, _modified=MAX 1554812680}]]
> at
> org.apache.jackrabbit.oak.plugins.document.DocumentStoreException.asDocumentStoreException(DocumentStoreException.java:179)
> at
> org.apache.jackrabbit.oak.plugins.document.DocumentStoreException.convert(DocumentStoreException.java:131)
> at
> org.apache.jackrabbit.oak.plugins.document.DocumentStoreException.convert(DocumentStoreException.java:114)
> at
> org.apache.jackrabbit.oak.plugins.document.Commit.applyToDocumentStore(Commit.java:425)
> at
> org.apache.jackrabbit.oak.plugins.document.Commit.applyToDocumentStoreWithTiming(Commit.java:280)
> at
> org.apache.jackrabbit.oak.plugins.document.Commit.applyToDocumentStore(Commit.java:264)
> at
> org.apache.jackrabbit.oak.plugins.document.DocumentNodeStore.(DocumentNodeStore.java:624)
> at
> org.apache.jackrabbit.oak.plugins.document.DocumentNodeStoreBuilder.build(DocumentNodeStoreBuilder.java:174)
> at
> org.apache.jackrabbit.oak.run.ClusterNodesCommand.execute(ClusterNodesCommand.java:65)
> at org.apache.jackrabbit.oak.run.Main.main(Main.java:49)
> Caused by: java.lang.UnsupportedOperationException: Method - createOrUpdate.
> Params: [nodes, [key: 0:/ new {_deleted.r16a020ebbbf-0-0=SET_MAP_ENTRY false,
> _commitRoot.r16a020ebbbf-0-0=SET_MAP_ENTRY 0, _modified=MAX 1554812680}]]
> at
> org.apache.jackrabbit.oak.plugins.document.util.ReadOnlyDocumentStoreWrapperFactory$1.invoke(ReadOnlyDocumentStoreWrapperFactory.java:38)
> at com.sun.proxy.$Proxy0.createOrUpdate(Unknown Source)
> at
> org.apache.jackrabbit.oak.plugins.document.Commit.applyToDocumentStore(Commit.java:365)
> ... 6 more
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Resolved] (OAK-8359) Test failure: AuthorizablePropertyTest.testGetPropertyByInvalidRelativePath()
[
https://issues.apache.org/jira/browse/OAK-8359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Marcel Reutegger resolved OAK-8359.
---
Resolution: Fixed
Build is stable again with fixes committed via OAK-8354.
> Test failure: AuthorizablePropertyTest.testGetPropertyByInvalidRelativePath()
> -
>
> Key: OAK-8359
> URL: https://issues.apache.org/jira/browse/OAK-8359
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: continuous integration, security
>Reporter: Hudson
>Priority: Major
>
> No description is provided
> The build Jackrabbit Oak #2177 has failed.
> First failed run: [Jackrabbit Oak
> #2177|https://builds.apache.org/job/Jackrabbit%20Oak/2177/] [console
> log|https://builds.apache.org/job/Jackrabbit%20Oak/2177/console]
> {noformat}
> [ERROR]
> testGetPropertyByInvalidRelativePath(org.apache.jackrabbit.oak.jcr.security.user.AuthorizablePropertyTest)
> Time elapsed: 0.016 s <<< ERROR!
> java.lang.NullPointerException
> at
> org.apache.jackrabbit.oak.security.user.AuthorizablePropertiesImpl.getOakPath(AuthorizablePropertiesImpl.java:297)
> at
> org.apache.jackrabbit.oak.security.user.AuthorizablePropertiesImpl.getProperty(AuthorizablePropertiesImpl.java:99)
> at
> org.apache.jackrabbit.oak.security.user.AuthorizableImpl.getProperty(AuthorizableImpl.java:118)
> at
> org.apache.jackrabbit.oak.jcr.delegate.AuthorizableDelegator$12.perform(AuthorizableDelegator.java:213)
> at
> org.apache.jackrabbit.oak.jcr.delegate.AuthorizableDelegator$12.perform(AuthorizableDelegator.java:209)
> at
> org.apache.jackrabbit.oak.jcr.delegate.SessionDelegate.perform(SessionDelegate.java:207)
> at
> org.apache.jackrabbit.oak.jcr.delegate.AuthorizableDelegator.getProperty(AuthorizableDelegator.java:209)
> at
> org.apache.jackrabbit.oak.jcr.security.user.AuthorizablePropertyTest.testGetPropertyByInvalidRelativePath(AuthorizablePropertyTest.java:216)
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Closed] (OAK-8359) Test failure: AuthorizablePropertyTest.testGetPropertyByInvalidRelativePath()
[
https://issues.apache.org/jira/browse/OAK-8359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Marcel Reutegger closed OAK-8359.
-
> Test failure: AuthorizablePropertyTest.testGetPropertyByInvalidRelativePath()
> -
>
> Key: OAK-8359
> URL: https://issues.apache.org/jira/browse/OAK-8359
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: continuous integration, security
>Reporter: Hudson
>Priority: Major
>
> No description is provided
> The build Jackrabbit Oak #2177 has failed.
> First failed run: [Jackrabbit Oak
> #2177|https://builds.apache.org/job/Jackrabbit%20Oak/2177/] [console
> log|https://builds.apache.org/job/Jackrabbit%20Oak/2177/console]
> {noformat}
> [ERROR]
> testGetPropertyByInvalidRelativePath(org.apache.jackrabbit.oak.jcr.security.user.AuthorizablePropertyTest)
> Time elapsed: 0.016 s <<< ERROR!
> java.lang.NullPointerException
> at
> org.apache.jackrabbit.oak.security.user.AuthorizablePropertiesImpl.getOakPath(AuthorizablePropertiesImpl.java:297)
> at
> org.apache.jackrabbit.oak.security.user.AuthorizablePropertiesImpl.getProperty(AuthorizablePropertiesImpl.java:99)
> at
> org.apache.jackrabbit.oak.security.user.AuthorizableImpl.getProperty(AuthorizableImpl.java:118)
> at
> org.apache.jackrabbit.oak.jcr.delegate.AuthorizableDelegator$12.perform(AuthorizableDelegator.java:213)
> at
> org.apache.jackrabbit.oak.jcr.delegate.AuthorizableDelegator$12.perform(AuthorizableDelegator.java:209)
> at
> org.apache.jackrabbit.oak.jcr.delegate.SessionDelegate.perform(SessionDelegate.java:207)
> at
> org.apache.jackrabbit.oak.jcr.delegate.AuthorizableDelegator.getProperty(AuthorizableDelegator.java:209)
> at
> org.apache.jackrabbit.oak.jcr.security.user.AuthorizablePropertyTest.testGetPropertyByInvalidRelativePath(AuthorizablePropertyTest.java:216)
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (OAK-8349) RDBDocumentStore*: "reset clusterId tool" in oak-run
[ https://issues.apache.org/jira/browse/OAK-8349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16849756#comment-16849756 ] Julian Reschke edited comment on OAK-8349 at 5/28/19 3:06 PM: -- [^OAK-8349.diff] - proposed change; it refactors the code to use the generic bootstrap code for node stores. (doc update still todo) [~egli], [~mreutegg] - do you want to review? was (Author: reschke): [^OAK-8349.diff] - proposed change; it refactors the code to use the generic bootstrap code for node stores. > RDBDocumentStore*: "reset clusterId tool" in oak-run > > > Key: OAK-8349 > URL: https://issues.apache.org/jira/browse/OAK-8349 > Project: Jackrabbit Oak > Issue Type: Technical task > Components: run >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > Attachments: OAK-8349.diff > > > Make the run command added for OAK-4007 support RDB as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OAK-8349) RDBDocumentStore*: "reset clusterId tool" in oak-run
[ https://issues.apache.org/jira/browse/OAK-8349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16849756#comment-16849756 ] Julian Reschke edited comment on OAK-8349 at 5/28/19 3:05 PM: -- [^OAK-8349.diff] - proposed change; it refactors the code to use the generic bootstrap code for node stores. was (Author: reschke): [^OAK-8349.diff] - proposed change; it refactors the code to use the generic parser/builder for the documentnodestore, and falls back to filestorage if that fails - this seems to work, but will not generate the right usage message in every case - this is due to the fact that the options for mongo/rdb are indeed different fromt those for file storage. > RDBDocumentStore*: "reset clusterId tool" in oak-run > > > Key: OAK-8349 > URL: https://issues.apache.org/jira/browse/OAK-8349 > Project: Jackrabbit Oak > Issue Type: Technical task > Components: run >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > Attachments: OAK-8349.diff > > > Make the run command added for OAK-4007 support RDB as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OAK-8359) Test failure: AuthorizablePropertyTest.testGetPropertyByInvalidRelativePath()
[
https://issues.apache.org/jira/browse/OAK-8359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16849825#comment-16849825
]
Hudson commented on OAK-8359:
-
Previously failing build now is OK.
Passed run: [Jackrabbit Oak
#2180|https://builds.apache.org/job/Jackrabbit%20Oak/2180/] [console
log|https://builds.apache.org/job/Jackrabbit%20Oak/2180/console]
> Test failure: AuthorizablePropertyTest.testGetPropertyByInvalidRelativePath()
> -
>
> Key: OAK-8359
> URL: https://issues.apache.org/jira/browse/OAK-8359
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: continuous integration, security
>Reporter: Hudson
>Priority: Major
>
> No description is provided
> The build Jackrabbit Oak #2177 has failed.
> First failed run: [Jackrabbit Oak
> #2177|https://builds.apache.org/job/Jackrabbit%20Oak/2177/] [console
> log|https://builds.apache.org/job/Jackrabbit%20Oak/2177/console]
> {noformat}
> [ERROR]
> testGetPropertyByInvalidRelativePath(org.apache.jackrabbit.oak.jcr.security.user.AuthorizablePropertyTest)
> Time elapsed: 0.016 s <<< ERROR!
> java.lang.NullPointerException
> at
> org.apache.jackrabbit.oak.security.user.AuthorizablePropertiesImpl.getOakPath(AuthorizablePropertiesImpl.java:297)
> at
> org.apache.jackrabbit.oak.security.user.AuthorizablePropertiesImpl.getProperty(AuthorizablePropertiesImpl.java:99)
> at
> org.apache.jackrabbit.oak.security.user.AuthorizableImpl.getProperty(AuthorizableImpl.java:118)
> at
> org.apache.jackrabbit.oak.jcr.delegate.AuthorizableDelegator$12.perform(AuthorizableDelegator.java:213)
> at
> org.apache.jackrabbit.oak.jcr.delegate.AuthorizableDelegator$12.perform(AuthorizableDelegator.java:209)
> at
> org.apache.jackrabbit.oak.jcr.delegate.SessionDelegate.perform(SessionDelegate.java:207)
> at
> org.apache.jackrabbit.oak.jcr.delegate.AuthorizableDelegator.getProperty(AuthorizableDelegator.java:209)
> at
> org.apache.jackrabbit.oak.jcr.security.user.AuthorizablePropertyTest.testGetPropertyByInvalidRelativePath(AuthorizablePropertyTest.java:216)
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OAK-8349) RDBDocumentStore*: "reset clusterId tool" in oak-run
[ https://issues.apache.org/jira/browse/OAK-8349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-8349: Attachment: OAK-8349.diff > RDBDocumentStore*: "reset clusterId tool" in oak-run > > > Key: OAK-8349 > URL: https://issues.apache.org/jira/browse/OAK-8349 > Project: Jackrabbit Oak > Issue Type: Technical task > Components: run >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > Attachments: OAK-8349.diff > > > Make the run command added for OAK-4007 support RDB as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OAK-8349) RDBDocumentStore*: "reset clusterId tool" in oak-run
[ https://issues.apache.org/jira/browse/OAK-8349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-8349: Attachment: (was: OAK-8349.diff) > RDBDocumentStore*: "reset clusterId tool" in oak-run > > > Key: OAK-8349 > URL: https://issues.apache.org/jira/browse/OAK-8349 > Project: Jackrabbit Oak > Issue Type: Technical task > Components: run >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > Attachments: OAK-8349.diff > > > Make the run command added for OAK-4007 support RDB as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OAK-8207) Read-only DocumentNodeStore tries to create root document
[
https://issues.apache.org/jira/browse/OAK-8207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16849821#comment-16849821
]
Marcel Reutegger commented on OAK-8207:
---
The patch looks good to me.
> Read-only DocumentNodeStore tries to create root document
> -
>
> Key: OAK-8207
> URL: https://issues.apache.org/jira/browse/OAK-8207
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: documentmk
>Reporter: Marcel Reutegger
>Assignee: Marcel Reutegger
>Priority: Minor
> Labels: candidate_oak_1_8
> Fix For: 1.10.3, 1.14.0
>
> Attachments: OAK-8207-1.8.diff
>
>
> When connecting a read-only DocumentNodeStore to a DocumentStore with an
> empty {{nodes}} collection, the DocumentNodeStore tries to create the root
> document. The operation then fails with something like:
> {noformat}
> Exception in thread "main"
> org.apache.jackrabbit.oak.plugins.document.DocumentStoreException: Method -
> createOrUpdate. Params: [nodes, [key: 0:/ new
> {_deleted.r16a020ebbbf-0-0=SET_MAP_ENTRY false,
> _commitRoot.r16a020ebbbf-0-0=SET_MAP_ENTRY 0, _modified=MAX 1554812680}]]
> at
> org.apache.jackrabbit.oak.plugins.document.DocumentStoreException.asDocumentStoreException(DocumentStoreException.java:179)
> at
> org.apache.jackrabbit.oak.plugins.document.DocumentStoreException.convert(DocumentStoreException.java:131)
> at
> org.apache.jackrabbit.oak.plugins.document.DocumentStoreException.convert(DocumentStoreException.java:114)
> at
> org.apache.jackrabbit.oak.plugins.document.Commit.applyToDocumentStore(Commit.java:425)
> at
> org.apache.jackrabbit.oak.plugins.document.Commit.applyToDocumentStoreWithTiming(Commit.java:280)
> at
> org.apache.jackrabbit.oak.plugins.document.Commit.applyToDocumentStore(Commit.java:264)
> at
> org.apache.jackrabbit.oak.plugins.document.DocumentNodeStore.(DocumentNodeStore.java:624)
> at
> org.apache.jackrabbit.oak.plugins.document.DocumentNodeStoreBuilder.build(DocumentNodeStoreBuilder.java:174)
> at
> org.apache.jackrabbit.oak.run.ClusterNodesCommand.execute(ClusterNodesCommand.java:65)
> at org.apache.jackrabbit.oak.run.Main.main(Main.java:49)
> Caused by: java.lang.UnsupportedOperationException: Method - createOrUpdate.
> Params: [nodes, [key: 0:/ new {_deleted.r16a020ebbbf-0-0=SET_MAP_ENTRY false,
> _commitRoot.r16a020ebbbf-0-0=SET_MAP_ENTRY 0, _modified=MAX 1554812680}]]
> at
> org.apache.jackrabbit.oak.plugins.document.util.ReadOnlyDocumentStoreWrapperFactory$1.invoke(ReadOnlyDocumentStoreWrapperFactory.java:38)
> at com.sun.proxy.$Proxy0.createOrUpdate(Unknown Source)
> at
> org.apache.jackrabbit.oak.plugins.document.Commit.applyToDocumentStore(Commit.java:365)
> ... 6 more
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OAK-8343) Allow queries to be delayed until an index is available
[
https://issues.apache.org/jira/browse/OAK-8343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16849788#comment-16849788
]
Thomas Mueller commented on OAK-8343:
-
One of the first queries is actually run when initializing the repository, when
there are few (almost no) indexes available:
{noformat}
select [rep:Authorizable].[rep:authorizableId] as
[rep:Authorizable.rep:authorizableId], [rep:Authorizable].[rep:principalName]
as [rep:Authorizable.rep:principalName], [rep:Authorizable].[jcr:uuid] as
[rep:Authorizable.jcr:uuid], [rep:Authorizable].[jcr:primaryType] as
[rep:Authorizable.jcr:primaryType], [rep:Authorizable].[jcr:createdBy] as
[rep:Authorizable.jcr:createdBy], [rep:Authorizable].[jcr:created] as
[rep:Authorizable.jcr:created] from [rep:Authorizable] as [rep:Authorizable]
where [rep:Authorizable].[rep:principalName] = $principalName
Daemon Thread [Apache Sling Repository Startup Thread] (Suspended (breakpoint
at line 319 in IndexTracker))
IndexTracker.waitForIndex(NodeState, String) line: 319
IndexTracker.getIndexDefinition(String, boolean) line: 287
LucenePropertyIndex$LazyLuceneIndexNode.getDefinition() line: 1615
LucenePropertyIndex$LazyLuceneIndexNode.getDefinition() line: 1580
FulltextIndexPlanner.(IndexNode, String, Filter,
List) line: 102
LucenePropertyIndex(FulltextIndex).getPlans(Filter, List,
NodeState) line: 102
QueryImpl.getBestSelectorExecutionPlan(NodeState, FilterImpl,
QueryIndexProvider, boolean) line: 1015
QueryImpl.getBestSelectorExecutionPlan(FilterImpl) line: 968
SelectorImpl.prepare() line: 308
QueryImpl.prepare() line: 629
MutableRoot$2(QueryEngineImpl).prepareAndSelect(List) line: 304
MutableRoot$2(QueryEngineImpl).executeQuery(String, String, long, long,
Map, Map) line: 278
UserProvider.getAuthorizableByPrincipal(Principal) line: 231
UserManagerImpl.getAuthorizable(Principal) line: 126
UserManagerImpl.checkValidPrincipal(Principal, boolean) line: 457
UserManagerImpl.createUser(String, String, Principal, String) line: 163
UserManagerImpl.createUser(String, String) line: 156
UserInitializer.initialize(NodeBuilder, String) line: 144
OakInitializer.initialize(Iterable, NodeStore,
String, CommitHook) line: 60
Oak.initialContent(IndexEditorProvider, QueryIndexProvider) line: 697
Oak.createNewContentRepository() line: 725
Oak.createContentRepository() line: 670
Jcr.createContentRepository() line: 376
SlingRepositoryManager.createRepository() line: 443
SlingRepositoryManager.acquireRepository() line: 284
SlingRepositoryManager(AbstractSlingRepositoryManager).initializeAndRegisterRepositoryService()
line: 471
AbstractSlingRepositoryManager.access$300(AbstractSlingRepositoryManager) line:
85
AbstractSlingRepositoryManager$4.run() line: 455
{noformat}
> Allow queries to be delayed until an index is available
> ---
>
> Key: OAK-8343
> URL: https://issues.apache.org/jira/browse/OAK-8343
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: lucene, query
>Reporter: Thomas Mueller
>Assignee: Thomas Mueller
>Priority: Major
> Fix For: 1.14.0
>
> Attachments: OAK-8343-b.patch, OAK-8343.patch
>
>
> Currently, indexes are built asynchronously. That is, if an index definition
> is added, the index is eventually built, but it's quite hard to say when it
> is ready for queries. This can be specially a problem right after the initial
> repository initialization, or after an upgrade.
> In theory, system startup could be delayed until all indexes are ready (e.g.
> set the "reindex" flag for important indexes, and at startup, wait until the
> "reindex" flag is set to "false"). However, doing that would block threads
> that _don't_ need an index. It would be better to only block threads that
> actually do run queries. That would make startup deterministic, without
> delaying other threads unnecessarily.
> To solve the problem, we can add a property "waitForIndex" in the index
> definition (just Lucene indexes is fine for now, as those are the important
> asynchronous ones). If set, then queries that potentially use those indexes
> are delayed, until the indexes are ready for sure. Reindex would need to
> remove that property (the same as it removes e.g. refresh or sets reindex to
> false). For added security, queries are only blocked as long as "reindex" is
> also set to true (this ensures that waitForIndex is removed eventually), and
> waiting
[jira] [Commented] (OAK-8344) Expose local index directory size as a metric
[ https://issues.apache.org/jira/browse/OAK-8344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16849783#comment-16849783 ] Nitin Gupta commented on OAK-8344: -- [~tmueller] - added the line breaks here - [^OAK-8344_1.patch] > Expose local index directory size as a metric > - > > Key: OAK-8344 > URL: https://issues.apache.org/jira/browse/OAK-8344 > Project: Jackrabbit Oak > Issue Type: Task > Components: indexing, lucene >Reporter: Nitin Gupta >Priority: Major > Attachments: OAK-8344.patch, OAK-8344_1.patch > > > We need to expose the local index directory size a metric that can later be > consumed for monitor and alerting purposes . > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OAK-8344) Expose local index directory size as a metric
[ https://issues.apache.org/jira/browse/OAK-8344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nitin Gupta updated OAK-8344: - Attachment: OAK-8344_1.patch > Expose local index directory size as a metric > - > > Key: OAK-8344 > URL: https://issues.apache.org/jira/browse/OAK-8344 > Project: Jackrabbit Oak > Issue Type: Task > Components: indexing, lucene >Reporter: Nitin Gupta >Priority: Major > Attachments: OAK-8344.patch, OAK-8344_1.patch > > > We need to expose the local index directory size a metric that can later be > consumed for monitor and alerting purposes . > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (OAK-8362) UserImporter: redundant check for null principals
[
https://issues.apache.org/jira/browse/OAK-8362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
angela resolved OAK-8362.
-
Resolution: Fixed
Committed revision 1860280.
> UserImporter: redundant check for null principals
> -
>
> Key: OAK-8362
> URL: https://issues.apache.org/jira/browse/OAK-8362
> Project: Jackrabbit Oak
> Issue Type: Improvement
>Reporter: angela
>Assignee: angela
>Priority: Minor
> Fix For: 1.14.0
>
>
> {{UserImporter.handlePropInfo}} contains an extra check for the 'principals'
> field being null, which is never the case. the extra if can be removed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OAK-8363) Remove obsolete comment
[ https://issues.apache.org/jira/browse/OAK-8363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcel Reutegger updated OAK-8363: -- Fix Version/s: 1.10.3 Merged into 1.10 branch: http://svn.apache.org/r1860279 > Remove obsolete comment > --- > > Key: OAK-8363 > URL: https://issues.apache.org/jira/browse/OAK-8363 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: documentmk >Reporter: Marcel Reutegger >Assignee: Marcel Reutegger >Priority: Trivial > Fix For: 1.10.3, 1.14.0 > > > There's an obsolete comment, which is a left over from OAK-7316. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (OAK-8363) Remove obsolete comment
[ https://issues.apache.org/jira/browse/OAK-8363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcel Reutegger resolved OAK-8363. --- Resolution: Fixed Fix Version/s: 1.14.0 Done in trunk: http://svn.apache.org/r1860278 > Remove obsolete comment > --- > > Key: OAK-8363 > URL: https://issues.apache.org/jira/browse/OAK-8363 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: documentmk >Reporter: Marcel Reutegger >Assignee: Marcel Reutegger >Priority: Trivial > Fix For: 1.14.0 > > > There's an obsolete comment, which is a left over from OAK-7316. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OAK-8363) Remove obsolete comment
Marcel Reutegger created OAK-8363: - Summary: Remove obsolete comment Key: OAK-8363 URL: https://issues.apache.org/jira/browse/OAK-8363 Project: Jackrabbit Oak Issue Type: Improvement Components: documentmk Reporter: Marcel Reutegger Assignee: Marcel Reutegger There's an obsolete comment, which is a left over from OAK-7316. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OAK-8349) RDBDocumentStore*: "reset clusterId tool" in oak-run
[ https://issues.apache.org/jira/browse/OAK-8349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16849756#comment-16849756 ] Julian Reschke commented on OAK-8349: - [^OAK-8349.diff] - proposed change; it refactors the code to use the generic parser/builder for the documentnodestore, and falls back to filestorage if that fails - this seems to work, but will not generate the right usage message in every case - this is due to the fact that the options for mongo/rdb are indeed different fromt those for file storage. > RDBDocumentStore*: "reset clusterId tool" in oak-run > > > Key: OAK-8349 > URL: https://issues.apache.org/jira/browse/OAK-8349 > Project: Jackrabbit Oak > Issue Type: Technical task > Components: run >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > Attachments: OAK-8349.diff > > > Make the run command added for OAK-4007 support RDB as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OAK-8349) RDBDocumentStore*: "reset clusterId tool" in oak-run
[ https://issues.apache.org/jira/browse/OAK-8349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-8349: Attachment: OAK-8349.diff > RDBDocumentStore*: "reset clusterId tool" in oak-run > > > Key: OAK-8349 > URL: https://issues.apache.org/jira/browse/OAK-8349 > Project: Jackrabbit Oak > Issue Type: Technical task > Components: run >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > Attachments: OAK-8349.diff > > > Make the run command added for OAK-4007 support RDB as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OAK-8353) Additional test for OAK-8012
[
https://issues.apache.org/jira/browse/OAK-8353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16849538#comment-16849538
]
Marcel Reutegger edited comment on OAK-8353 at 5/28/19 2:00 PM:
Merged into branches:
- 1.10: http://svn.apache.org/r1860212
- 1.8: http://svn.apache.org/r1860222
- 1.6: http://svn.apache.org/r1860242
- 1.4: http://svn.apache.org/r1860251 (test enabled with
http://svn.apache.org/r1860261)
- 1.2: http://svn.apache.org/r1860252 (test enabled with
http://svn.apache.org/r1860269)
- 1.0: http://svn.apache.org/r1860256 (test enabled with
http://svn.apache.org/r1860273)
was (Author: mreutegg):
Merged into branches:
- 1.10: http://svn.apache.org/r1860212
- 1.8: http://svn.apache.org/r1860222
- 1.6: http://svn.apache.org/r1860242
- 1.4: http://svn.apache.org/r1860251 (test ignored)
- 1.2: http://svn.apache.org/r1860252 (test ignored)
- 1.0: http://svn.apache.org/r1860256 (test ignored)
> Additional test for OAK-8012
>
>
> Key: OAK-8353
> URL: https://issues.apache.org/jira/browse/OAK-8353
> Project: Jackrabbit Oak
> Issue Type: Test
> Components: documentmk
>Reporter: Marcel Reutegger
>Assignee: Marcel Reutegger
>Priority: Minor
> Fix For: 1.0.43, 1.4.25, 1.2.32, 1.10.3, 1.14.0, 1.6.18, 1.8.14
>
>
> It turns out the issue described in OAK-8012 may also happen without a
> restart. An incorrect read may happen when the orphaned branch clean up kicks
> in. There is a race condition in the code before OAK-8012 changes. The read
> may check the state of an orphaned branch and doesn't see it in the
> {{UnmergedBranches}} map while it is still visible in the DocumentStore.
> This issue is about an additional test to verify OAK-8012 also fixes this
> situation.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OAK-8012) Unmerged branch changes visible after restart
[ https://issues.apache.org/jira/browse/OAK-8012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcel Reutegger updated OAK-8012: -- Fix Version/s: 1.0.43 > Unmerged branch changes visible after restart > - > > Key: OAK-8012 > URL: https://issues.apache.org/jira/browse/OAK-8012 > Project: Jackrabbit Oak > Issue Type: Bug > Components: documentmk >Affects Versions: 1.4, 1.6.0, 1.8.0, 1.10.0 >Reporter: Marcel Reutegger >Assignee: Marcel Reutegger >Priority: Critical > Fix For: 1.0.43, 1.12.0, 1.4.25, 1.10.1, 1.8.13, 1.2.32, 1.6.18 > > > Changes persisted to a branch are visible after a restart even when the > branch has not been merged. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OAK-8012) Unmerged branch changes visible after restart
[ https://issues.apache.org/jira/browse/OAK-8012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16814490#comment-16814490 ] Marcel Reutegger edited comment on OAK-8012 at 5/28/19 1:59 PM: Merged fix into branches: - 1.8: http://svn.apache.org/r1857251 - 1.6: http://svn.apache.org/r1857301 - 1.4: http://svn.apache.org/r1860261 - 1.2: http://svn.apache.org/r1860267 - 1.0: http://svn.apache.org/r1860272 was (Author: mreutegg): Merged fix into branches: - 1.8: http://svn.apache.org/r1857251 - 1.6: http://svn.apache.org/r1857301 - 1.4: http://svn.apache.org/r1860261 - 1.2: http://svn.apache.org/r1860267 > Unmerged branch changes visible after restart > - > > Key: OAK-8012 > URL: https://issues.apache.org/jira/browse/OAK-8012 > Project: Jackrabbit Oak > Issue Type: Bug > Components: documentmk >Affects Versions: 1.4, 1.6.0, 1.8.0, 1.10.0 >Reporter: Marcel Reutegger >Assignee: Marcel Reutegger >Priority: Critical > Fix For: 1.12.0, 1.4.25, 1.10.1, 1.8.13, 1.2.32, 1.6.18 > > > Changes persisted to a branch are visible after a restart even when the > branch has not been merged. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OAK-8362) UserImporter: redundant check for null principals
angela created OAK-8362:
---
Summary: UserImporter: redundant check for null principals
Key: OAK-8362
URL: https://issues.apache.org/jira/browse/OAK-8362
Project: Jackrabbit Oak
Issue Type: Improvement
Reporter: angela
Assignee: angela
Fix For: 1.14.0
{{UserImporter.handlePropInfo}} contains an extra check for the 'principals'
field being null, which is never the case. the extra if can be removed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Resolved] (OAK-8360) UserAuthentication.authenticate: improve readability
[ https://issues.apache.org/jira/browse/OAK-8360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] angela resolved OAK-8360. - Resolution: Fixed Committed revision 1860270. > UserAuthentication.authenticate: improve readability > > > Key: OAK-8360 > URL: https://issues.apache.org/jira/browse/OAK-8360 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: core, security >Reporter: angela >Assignee: angela >Priority: Minor > Fix For: 1.14.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OAK-8361) Improve tests for o.a.j.oak.security.user package
angela created OAK-8361: --- Summary: Improve tests for o.a.j.oak.security.user package Key: OAK-8361 URL: https://issues.apache.org/jira/browse/OAK-8361 Project: Jackrabbit Oak Issue Type: Improvement Components: core, security Reporter: angela Assignee: angela Fix For: 1.14.0 same as OAK-8320 for o.a.j.oak.security.user -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (OAK-8077) how to support node type template modification and removal
[ https://issues.apache.org/jira/browse/OAK-8077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] angela resolved OAK-8077. - Resolution: Invalid hi [~zhouxu245], please send your questions to the mailing lists. for this particular question you will find answers at https://docs.adobe.com/docs/en/spec/jcr/2.0/19_Node_Type_Management.html and the corresponding javadoc. hope that helps. > how to support node type template modification and removal > -- > > Key: OAK-8077 > URL: https://issues.apache.org/jira/browse/OAK-8077 > Project: Jackrabbit Oak > Issue Type: Bug > Components: api >Reporter: zhouxu >Priority: Blocker > > hello everyone! > we can use NodeTypeManager to create a custom type,but we donot known > how to modify and remove exist propery from exist node type? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OAK-8012) Unmerged branch changes visible after restart
[ https://issues.apache.org/jira/browse/OAK-8012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16814490#comment-16814490 ] Marcel Reutegger edited comment on OAK-8012 at 5/28/19 1:27 PM: Merged fix into branches: - 1.8: http://svn.apache.org/r1857251 - 1.6: http://svn.apache.org/r1857301 - 1.4: http://svn.apache.org/r1860261 - 1.2: http://svn.apache.org/r1860267 was (Author: mreutegg): Merged fix into branches: - 1.8: http://svn.apache.org/r1857251 - 1.6: http://svn.apache.org/r1857301 - 1.4: http://svn.apache.org/r1860261 > Unmerged branch changes visible after restart > - > > Key: OAK-8012 > URL: https://issues.apache.org/jira/browse/OAK-8012 > Project: Jackrabbit Oak > Issue Type: Bug > Components: documentmk >Affects Versions: 1.4, 1.6.0, 1.8.0, 1.10.0 >Reporter: Marcel Reutegger >Assignee: Marcel Reutegger >Priority: Critical > Fix For: 1.12.0, 1.4.25, 1.10.1, 1.8.13, 1.6.18 > > > Changes persisted to a branch are visible after a restart even when the > branch has not been merged. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OAK-8012) Unmerged branch changes visible after restart
[ https://issues.apache.org/jira/browse/OAK-8012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcel Reutegger updated OAK-8012: -- Fix Version/s: 1.2.32 > Unmerged branch changes visible after restart > - > > Key: OAK-8012 > URL: https://issues.apache.org/jira/browse/OAK-8012 > Project: Jackrabbit Oak > Issue Type: Bug > Components: documentmk >Affects Versions: 1.4, 1.6.0, 1.8.0, 1.10.0 >Reporter: Marcel Reutegger >Assignee: Marcel Reutegger >Priority: Critical > Fix For: 1.12.0, 1.4.25, 1.10.1, 1.8.13, 1.2.32, 1.6.18 > > > Changes persisted to a branch are visible after a restart even when the > branch has not been merged. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OAK-8359) Test failure: AuthorizablePropertyTest.testGetPropertyByInvalidRelativePath()
[
https://issues.apache.org/jira/browse/OAK-8359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16849701#comment-16849701
]
Hudson commented on OAK-8359:
-
Build is still failing.
Failed run: [Jackrabbit Oak
#2179|https://builds.apache.org/job/Jackrabbit%20Oak/2179/] [console
log|https://builds.apache.org/job/Jackrabbit%20Oak/2179/console]
> Test failure: AuthorizablePropertyTest.testGetPropertyByInvalidRelativePath()
> -
>
> Key: OAK-8359
> URL: https://issues.apache.org/jira/browse/OAK-8359
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: continuous integration, security
>Reporter: Hudson
>Priority: Major
>
> No description is provided
> The build Jackrabbit Oak #2177 has failed.
> First failed run: [Jackrabbit Oak
> #2177|https://builds.apache.org/job/Jackrabbit%20Oak/2177/] [console
> log|https://builds.apache.org/job/Jackrabbit%20Oak/2177/console]
> {noformat}
> [ERROR]
> testGetPropertyByInvalidRelativePath(org.apache.jackrabbit.oak.jcr.security.user.AuthorizablePropertyTest)
> Time elapsed: 0.016 s <<< ERROR!
> java.lang.NullPointerException
> at
> org.apache.jackrabbit.oak.security.user.AuthorizablePropertiesImpl.getOakPath(AuthorizablePropertiesImpl.java:297)
> at
> org.apache.jackrabbit.oak.security.user.AuthorizablePropertiesImpl.getProperty(AuthorizablePropertiesImpl.java:99)
> at
> org.apache.jackrabbit.oak.security.user.AuthorizableImpl.getProperty(AuthorizableImpl.java:118)
> at
> org.apache.jackrabbit.oak.jcr.delegate.AuthorizableDelegator$12.perform(AuthorizableDelegator.java:213)
> at
> org.apache.jackrabbit.oak.jcr.delegate.AuthorizableDelegator$12.perform(AuthorizableDelegator.java:209)
> at
> org.apache.jackrabbit.oak.jcr.delegate.SessionDelegate.perform(SessionDelegate.java:207)
> at
> org.apache.jackrabbit.oak.jcr.delegate.AuthorizableDelegator.getProperty(AuthorizableDelegator.java:209)
> at
> org.apache.jackrabbit.oak.jcr.security.user.AuthorizablePropertyTest.testGetPropertyByInvalidRelativePath(AuthorizablePropertyTest.java:216)
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OAK-8012) Unmerged branch changes visible after restart
[ https://issues.apache.org/jira/browse/OAK-8012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcel Reutegger updated OAK-8012: -- Labels: (was: candidate_oak_1_4) > Unmerged branch changes visible after restart > - > > Key: OAK-8012 > URL: https://issues.apache.org/jira/browse/OAK-8012 > Project: Jackrabbit Oak > Issue Type: Bug > Components: documentmk >Affects Versions: 1.4, 1.6.0, 1.8.0, 1.10.0 >Reporter: Marcel Reutegger >Assignee: Marcel Reutegger >Priority: Critical > Fix For: 1.12.0, 1.4.25, 1.10.1, 1.8.13, 1.6.18 > > > Changes persisted to a branch are visible after a restart even when the > branch has not been merged. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OAK-8012) Unmerged branch changes visible after restart
[ https://issues.apache.org/jira/browse/OAK-8012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16814490#comment-16814490 ] Marcel Reutegger edited comment on OAK-8012 at 5/28/19 12:58 PM: - Merged fix into branches: - 1.8: http://svn.apache.org/r1857251 - 1.6: http://svn.apache.org/r1857301 - 1.4: http://svn.apache.org/r1860261 was (Author: mreutegg): Merged fix into branches: - 1.8: http://svn.apache.org/r1857251 - 1.6: http://svn.apache.org/r1857301 > Unmerged branch changes visible after restart > - > > Key: OAK-8012 > URL: https://issues.apache.org/jira/browse/OAK-8012 > Project: Jackrabbit Oak > Issue Type: Bug > Components: documentmk >Affects Versions: 1.4, 1.6.0, 1.8.0, 1.10.0 >Reporter: Marcel Reutegger >Assignee: Marcel Reutegger >Priority: Critical > Labels: candidate_oak_1_4 > Fix For: 1.12.0, 1.10.1, 1.8.13, 1.6.18 > > > Changes persisted to a branch are visible after a restart even when the > branch has not been merged. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OAK-8012) Unmerged branch changes visible after restart
[ https://issues.apache.org/jira/browse/OAK-8012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcel Reutegger updated OAK-8012: -- Fix Version/s: 1.4.25 > Unmerged branch changes visible after restart > - > > Key: OAK-8012 > URL: https://issues.apache.org/jira/browse/OAK-8012 > Project: Jackrabbit Oak > Issue Type: Bug > Components: documentmk >Affects Versions: 1.4, 1.6.0, 1.8.0, 1.10.0 >Reporter: Marcel Reutegger >Assignee: Marcel Reutegger >Priority: Critical > Labels: candidate_oak_1_4 > Fix For: 1.12.0, 1.4.25, 1.10.1, 1.8.13, 1.6.18 > > > Changes persisted to a branch are visible after a restart even when the > branch has not been merged. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OAK-8343) Allow queries to be delayed until an index is available
[
https://issues.apache.org/jira/browse/OAK-8343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16849694#comment-16849694
]
Thomas Mueller commented on OAK-8343:
-
Looks like the query
{noformat}
SELECT * FROM [rep:Authorizable] WHERE [rep:principalName] = $principalName /*
oak-internal */
{noformat}
is run quite early, and uses the node type index then (cost: 4). I don't know
yet why the /oak:index/principalName index isn't used at that time, looks like
it's not available yet.
> Allow queries to be delayed until an index is available
> ---
>
> Key: OAK-8343
> URL: https://issues.apache.org/jira/browse/OAK-8343
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: lucene, query
>Reporter: Thomas Mueller
>Assignee: Thomas Mueller
>Priority: Major
> Fix For: 1.14.0
>
> Attachments: OAK-8343-b.patch, OAK-8343.patch
>
>
> Currently, indexes are built asynchronously. That is, if an index definition
> is added, the index is eventually built, but it's quite hard to say when it
> is ready for queries. This can be specially a problem right after the initial
> repository initialization, or after an upgrade.
> In theory, system startup could be delayed until all indexes are ready (e.g.
> set the "reindex" flag for important indexes, and at startup, wait until the
> "reindex" flag is set to "false"). However, doing that would block threads
> that _don't_ need an index. It would be better to only block threads that
> actually do run queries. That would make startup deterministic, without
> delaying other threads unnecessarily.
> To solve the problem, we can add a property "waitForIndex" in the index
> definition (just Lucene indexes is fine for now, as those are the important
> asynchronous ones). If set, then queries that potentially use those indexes
> are delayed, until the indexes are ready for sure. Reindex would need to
> remove that property (the same as it removes e.g. refresh or sets reindex to
> false). For added security, queries are only blocked as long as "reindex" is
> also set to true (this ensures that waitForIndex is removed eventually), and
> waiting should time out after 2 minutes, to ensure the feature doesn't block
> startup forever if indexing fails for some reason.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (OAK-8360) UserAuthentication.authenticate: improve readability
angela created OAK-8360: --- Summary: UserAuthentication.authenticate: improve readability Key: OAK-8360 URL: https://issues.apache.org/jira/browse/OAK-8360 Project: Jackrabbit Oak Issue Type: Improvement Components: core, security Reporter: angela Assignee: angela Fix For: 1.14.0 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OAK-8232) Node#setPrimaryType(String) does not create child nodes defined as autoCreated
[ https://issues.apache.org/jira/browse/OAK-8232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16849608#comment-16849608 ] Julian Reschke edited comment on OAK-8232 at 5/28/19 12:39 PM: --- trunk: [r1857592|http://svn.apache.org/r1857592] [r1857589|http://svn.apache.org/r1857589] 1.10: [r1860255|http://svn.apache.org/r1860255] was (Author: reschke): trunk: [r1857592|http://svn.apache.org/r1857592] [r1857589|http://svn.apache.org/r1857589] > Node#setPrimaryType(String) does not create child nodes defined as autoCreated > -- > > Key: OAK-8232 > URL: https://issues.apache.org/jira/browse/OAK-8232 > Project: Jackrabbit Oak > Issue Type: Bug > Components: jcr >Affects Versions: 1.12.0 >Reporter: Manfred Baedke >Assignee: Manfred Baedke >Priority: Minor > Labels: candidate_oak_1_8 > Fix For: 1.10.3, 1.14.0 > > Attachments: oak-8232-testcase.patch, oak-8232.patch > > > In contrast to Node#addNode(String, String), Node#setPrimaryType(String) does > not create child nodes that are defined as autoCreated. See attached failing > test case. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OAK-8353) Additional test for OAK-8012
[
https://issues.apache.org/jira/browse/OAK-8353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Marcel Reutegger updated OAK-8353:
--
Fix Version/s: 1.2.32
1.4.25
1.0.43
> Additional test for OAK-8012
>
>
> Key: OAK-8353
> URL: https://issues.apache.org/jira/browse/OAK-8353
> Project: Jackrabbit Oak
> Issue Type: Test
> Components: documentmk
>Reporter: Marcel Reutegger
>Assignee: Marcel Reutegger
>Priority: Minor
> Fix For: 1.0.43, 1.4.25, 1.2.32, 1.10.3, 1.14.0, 1.6.18, 1.8.14
>
>
> It turns out the issue described in OAK-8012 may also happen without a
> restart. An incorrect read may happen when the orphaned branch clean up kicks
> in. There is a race condition in the code before OAK-8012 changes. The read
> may check the state of an orphaned branch and doesn't see it in the
> {{UnmergedBranches}} map while it is still visible in the DocumentStore.
> This issue is about an additional test to verify OAK-8012 also fixes this
> situation.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (OAK-8353) Additional test for OAK-8012
[
https://issues.apache.org/jira/browse/OAK-8353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16849538#comment-16849538
]
Marcel Reutegger edited comment on OAK-8353 at 5/28/19 12:39 PM:
-
Merged into branches:
- 1.10: http://svn.apache.org/r1860212
- 1.8: http://svn.apache.org/r1860222
- 1.6: http://svn.apache.org/r1860242
- 1.4: http://svn.apache.org/r1860251 (test ignored)
- 1.2: http://svn.apache.org/r1860252 (test ignored)
- 1.0: http://svn.apache.org/r1860256 (test ignored)
was (Author: mreutegg):
Merged into branches:
- 1.10: http://svn.apache.org/r1860212
- 1.8: http://svn.apache.org/r1860222
- 1.6: http://svn.apache.org/r1860242
> Additional test for OAK-8012
>
>
> Key: OAK-8353
> URL: https://issues.apache.org/jira/browse/OAK-8353
> Project: Jackrabbit Oak
> Issue Type: Test
> Components: documentmk
>Reporter: Marcel Reutegger
>Assignee: Marcel Reutegger
>Priority: Minor
> Fix For: 1.10.3, 1.14.0, 1.6.18, 1.8.14
>
>
> It turns out the issue described in OAK-8012 may also happen without a
> restart. An incorrect read may happen when the orphaned branch clean up kicks
> in. There is a race condition in the code before OAK-8012 changes. The read
> may check the state of an orphaned branch and doesn't see it in the
> {{UnmergedBranches}} map while it is still visible in the DocumentStore.
> This issue is about an additional test to verify OAK-8012 also fixes this
> situation.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OAK-8232) Node#setPrimaryType(String) does not create child nodes defined as autoCreated
[ https://issues.apache.org/jira/browse/OAK-8232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-8232: Labels: candidate_oak_1_8 (was: candidate_oak_1_10) > Node#setPrimaryType(String) does not create child nodes defined as autoCreated > -- > > Key: OAK-8232 > URL: https://issues.apache.org/jira/browse/OAK-8232 > Project: Jackrabbit Oak > Issue Type: Bug > Components: jcr >Affects Versions: 1.12.0 >Reporter: Manfred Baedke >Assignee: Manfred Baedke >Priority: Minor > Labels: candidate_oak_1_8 > Fix For: 1.10.3, 1.14.0 > > Attachments: oak-8232-testcase.patch, oak-8232.patch > > > In contrast to Node#addNode(String, String), Node#setPrimaryType(String) does > not create child nodes that are defined as autoCreated. See attached failing > test case. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OAK-8232) Node#setPrimaryType(String) does not create child nodes defined as autoCreated
[ https://issues.apache.org/jira/browse/OAK-8232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-8232: Fix Version/s: 1.10.3 > Node#setPrimaryType(String) does not create child nodes defined as autoCreated > -- > > Key: OAK-8232 > URL: https://issues.apache.org/jira/browse/OAK-8232 > Project: Jackrabbit Oak > Issue Type: Bug > Components: jcr >Affects Versions: 1.12.0 >Reporter: Manfred Baedke >Assignee: Manfred Baedke >Priority: Minor > Labels: candidate_oak_1_10 > Fix For: 1.10.3, 1.14.0 > > Attachments: oak-8232-testcase.patch, oak-8232.patch > > > In contrast to Node#addNode(String, String), Node#setPrimaryType(String) does > not create child nodes that are defined as autoCreated. See attached failing > test case. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (OAK-8355) AuthorizableImpl.isEveryone should not throw RepositoryException
[
https://issues.apache.org/jira/browse/OAK-8355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
angela resolved OAK-8355.
-
Resolution: Fixed
Fix Version/s: 1.14.0
Committed revision 1860254.
> AuthorizableImpl.isEveryone should not throw RepositoryException
>
>
> Key: OAK-8355
> URL: https://issues.apache.org/jira/browse/OAK-8355
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: 1.14
>Reporter: angela
>Assignee: angela
>Priority: Minor
> Fix For: 1.14.0
>
>
> {{AuthorizableImpl.isEveryone}} should be refactored such that it doesn't
> throw {{RepositoryException}}, which doesn't add any value for this internal
> method.
> [~stillalex], fyi
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Resolved] (OAK-8354) Fix/Add nullability annotations with o.a.j.oak.security.user package
[ https://issues.apache.org/jira/browse/OAK-8354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] angela resolved OAK-8354. - Resolution: Fixed revision 1860253. > Fix/Add nullability annotations with o.a.j.oak.security.user package > > > Key: OAK-8354 > URL: https://issues.apache.org/jira/browse/OAK-8354 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: core, security >Reporter: angela >Assignee: angela >Priority: Trivial > Fix For: 1.14.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OAK-8355) AuthorizableImpl.isEveryone should not throw RepositoryException
[
https://issues.apache.org/jira/browse/OAK-8355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
angela updated OAK-8355:
Description:
{{AuthorizableImpl.isEveryone}} should be refactored such that it doesn't throw
{{RepositoryException}}, which doesn't add any value for this internal method.
[~stillalex], fyi
was:
{{AuthorizableImpl.isEveryone}} should be refactored such that it doesn't throw
{{RepositoryException}}, which is not needed for this internal method.
[~stillalex], fyi
> AuthorizableImpl.isEveryone should not throw RepositoryException
>
>
> Key: OAK-8355
> URL: https://issues.apache.org/jira/browse/OAK-8355
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: 1.14
>Reporter: angela
>Assignee: angela
>Priority: Minor
>
> {{AuthorizableImpl.isEveryone}} should be refactored such that it doesn't
> throw {{RepositoryException}}, which doesn't add any value for this internal
> method.
> [~stillalex], fyi
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OAK-8359) Test failure: AuthorizablePropertyTest.testGetPropertyByInvalidRelativePath()
[
https://issues.apache.org/jira/browse/OAK-8359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16849649#comment-16849649
]
Hudson commented on OAK-8359:
-
Build is still failing.
Failed run: [Jackrabbit Oak
#2178|https://builds.apache.org/job/Jackrabbit%20Oak/2178/] [console
log|https://builds.apache.org/job/Jackrabbit%20Oak/2178/console]
> Test failure: AuthorizablePropertyTest.testGetPropertyByInvalidRelativePath()
> -
>
> Key: OAK-8359
> URL: https://issues.apache.org/jira/browse/OAK-8359
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: continuous integration, security
>Reporter: Hudson
>Priority: Major
>
> No description is provided
> The build Jackrabbit Oak #2177 has failed.
> First failed run: [Jackrabbit Oak
> #2177|https://builds.apache.org/job/Jackrabbit%20Oak/2177/] [console
> log|https://builds.apache.org/job/Jackrabbit%20Oak/2177/console]
> {noformat}
> [ERROR]
> testGetPropertyByInvalidRelativePath(org.apache.jackrabbit.oak.jcr.security.user.AuthorizablePropertyTest)
> Time elapsed: 0.016 s <<< ERROR!
> java.lang.NullPointerException
> at
> org.apache.jackrabbit.oak.security.user.AuthorizablePropertiesImpl.getOakPath(AuthorizablePropertiesImpl.java:297)
> at
> org.apache.jackrabbit.oak.security.user.AuthorizablePropertiesImpl.getProperty(AuthorizablePropertiesImpl.java:99)
> at
> org.apache.jackrabbit.oak.security.user.AuthorizableImpl.getProperty(AuthorizableImpl.java:118)
> at
> org.apache.jackrabbit.oak.jcr.delegate.AuthorizableDelegator$12.perform(AuthorizableDelegator.java:213)
> at
> org.apache.jackrabbit.oak.jcr.delegate.AuthorizableDelegator$12.perform(AuthorizableDelegator.java:209)
> at
> org.apache.jackrabbit.oak.jcr.delegate.SessionDelegate.perform(SessionDelegate.java:207)
> at
> org.apache.jackrabbit.oak.jcr.delegate.AuthorizableDelegator.getProperty(AuthorizableDelegator.java:209)
> at
> org.apache.jackrabbit.oak.jcr.security.user.AuthorizablePropertyTest.testGetPropertyByInvalidRelativePath(AuthorizablePropertyTest.java:216)
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OAK-5027) Test utils for commonly used functionality
[ https://issues.apache.org/jira/browse/OAK-5027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcel Reutegger updated OAK-5027: -- Fix Version/s: 1.2.32 1.4.25 1.0.43 Merged into branches: - 1.4: http://svn.apache.org/r1860244 - 1.2: http://svn.apache.org/r1860245 - 1.0: http://svn.apache.org/r1860248 > Test utils for commonly used functionality > -- > > Key: OAK-5027 > URL: https://issues.apache.org/jira/browse/OAK-5027 > Project: Jackrabbit Oak > Issue Type: Test > Components: core >Reporter: Marcel Reutegger >Assignee: Marcel Reutegger >Priority: Minor > Fix For: 1.5.13, 1.6.0, 1.0.43, 1.4.25, 1.2.32 > > > Introduce a utility class with functionality commonly used in tests. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OAK-8354) Fix/Add nullability annotations with o.a.j.oak.security.user package
[
https://issues.apache.org/jira/browse/OAK-8354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16849634#comment-16849634
]
angela commented on OAK-8354:
-
[~mreutegg], yep... there are tests passing {{null}}, where the internal oak
class specifies the relPath parameter to be non-null... will fix it right away.
> Fix/Add nullability annotations with o.a.j.oak.security.user package
>
>
> Key: OAK-8354
> URL: https://issues.apache.org/jira/browse/OAK-8354
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: core, security
>Reporter: angela
>Assignee: angela
>Priority: Trivial
> Fix For: 1.14.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Resolved] (OAK-8358) oak-run check should have an option for specifying memory mapping
[
https://issues.apache.org/jira/browse/OAK-8358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrei Dulceanu resolved OAK-8358.
--
Resolution: Fixed
Fix Version/s: 1.14.0
Fixed at r1860247.
> oak-run check should have an option for specifying memory mapping
> -
>
> Key: OAK-8358
> URL: https://issues.apache.org/jira/browse/OAK-8358
> Project: Jackrabbit Oak
> Issue Type: New Feature
> Components: run, segment-tar
>Reporter: Andrei Dulceanu
>Assignee: Andrei Dulceanu
>Priority: Minor
> Labels: tooling
> Fix For: 1.14.0
>
>
> {{oak-run check}} currently uses memory mapping by default when building the
> {{FileStore}}. This setting should be configurable, to allow switching memory
> mapping off.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Reopened] (OAK-8354) Fix/Add nullability annotations with o.a.j.oak.security.user package
[ https://issues.apache.org/jira/browse/OAK-8354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcel Reutegger reopened OAK-8354: --- I think this breaks some tests. See OAK-8359 and also failures on travis: https://travis-ci.org/apache/jackrabbit-oak/jobs/538168370 > Fix/Add nullability annotations with o.a.j.oak.security.user package > > > Key: OAK-8354 > URL: https://issues.apache.org/jira/browse/OAK-8354 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: core, security >Reporter: angela >Assignee: angela >Priority: Trivial > Fix For: 1.14.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OAK-8359) Test failure: AuthorizablePropertyTest.testGetPropertyByInvalidRelativePath()
[
https://issues.apache.org/jira/browse/OAK-8359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Marcel Reutegger updated OAK-8359:
--
Description:
No description is provided
The build Jackrabbit Oak #2177 has failed.
First failed run: [Jackrabbit Oak
#2177|https://builds.apache.org/job/Jackrabbit%20Oak/2177/] [console
log|https://builds.apache.org/job/Jackrabbit%20Oak/2177/console]
{noformat}
[ERROR]
testGetPropertyByInvalidRelativePath(org.apache.jackrabbit.oak.jcr.security.user.AuthorizablePropertyTest)
Time elapsed: 0.016 s <<< ERROR!
java.lang.NullPointerException
at
org.apache.jackrabbit.oak.security.user.AuthorizablePropertiesImpl.getOakPath(AuthorizablePropertiesImpl.java:297)
at
org.apache.jackrabbit.oak.security.user.AuthorizablePropertiesImpl.getProperty(AuthorizablePropertiesImpl.java:99)
at
org.apache.jackrabbit.oak.security.user.AuthorizableImpl.getProperty(AuthorizableImpl.java:118)
at
org.apache.jackrabbit.oak.jcr.delegate.AuthorizableDelegator$12.perform(AuthorizableDelegator.java:213)
at
org.apache.jackrabbit.oak.jcr.delegate.AuthorizableDelegator$12.perform(AuthorizableDelegator.java:209)
at
org.apache.jackrabbit.oak.jcr.delegate.SessionDelegate.perform(SessionDelegate.java:207)
at
org.apache.jackrabbit.oak.jcr.delegate.AuthorizableDelegator.getProperty(AuthorizableDelegator.java:209)
at
org.apache.jackrabbit.oak.jcr.security.user.AuthorizablePropertyTest.testGetPropertyByInvalidRelativePath(AuthorizablePropertyTest.java:216)
{noformat}
was:
No description is provided
The build Jackrabbit Oak #2177 has failed.
First failed run: [Jackrabbit Oak
#2177|https://builds.apache.org/job/Jackrabbit%20Oak/2177/] [console
log|https://builds.apache.org/job/Jackrabbit%20Oak/2177/console]
Component/s: security
Summary: Test failure:
AuthorizablePropertyTest.testGetPropertyByInvalidRelativePath() (was: Build
Jackrabbit Oak #2177 failed)
Looks like this is caused by OAK-8354 and commit http://svn.apache.org/r1860234
> Test failure: AuthorizablePropertyTest.testGetPropertyByInvalidRelativePath()
> -
>
> Key: OAK-8359
> URL: https://issues.apache.org/jira/browse/OAK-8359
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: continuous integration, security
>Reporter: Hudson
>Priority: Major
>
> No description is provided
> The build Jackrabbit Oak #2177 has failed.
> First failed run: [Jackrabbit Oak
> #2177|https://builds.apache.org/job/Jackrabbit%20Oak/2177/] [console
> log|https://builds.apache.org/job/Jackrabbit%20Oak/2177/console]
> {noformat}
> [ERROR]
> testGetPropertyByInvalidRelativePath(org.apache.jackrabbit.oak.jcr.security.user.AuthorizablePropertyTest)
> Time elapsed: 0.016 s <<< ERROR!
> java.lang.NullPointerException
> at
> org.apache.jackrabbit.oak.security.user.AuthorizablePropertiesImpl.getOakPath(AuthorizablePropertiesImpl.java:297)
> at
> org.apache.jackrabbit.oak.security.user.AuthorizablePropertiesImpl.getProperty(AuthorizablePropertiesImpl.java:99)
> at
> org.apache.jackrabbit.oak.security.user.AuthorizableImpl.getProperty(AuthorizableImpl.java:118)
> at
> org.apache.jackrabbit.oak.jcr.delegate.AuthorizableDelegator$12.perform(AuthorizableDelegator.java:213)
> at
> org.apache.jackrabbit.oak.jcr.delegate.AuthorizableDelegator$12.perform(AuthorizableDelegator.java:209)
> at
> org.apache.jackrabbit.oak.jcr.delegate.SessionDelegate.perform(SessionDelegate.java:207)
> at
> org.apache.jackrabbit.oak.jcr.delegate.AuthorizableDelegator.getProperty(AuthorizableDelegator.java:209)
> at
> org.apache.jackrabbit.oak.jcr.security.user.AuthorizablePropertyTest.testGetPropertyByInvalidRelativePath(AuthorizablePropertyTest.java:216)
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Closed] (OAK-8342) Build Jackrabbit Oak #2166 failed
[ https://issues.apache.org/jira/browse/OAK-8342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcel Reutegger closed OAK-8342. - > Build Jackrabbit Oak #2166 failed > - > > Key: OAK-8342 > URL: https://issues.apache.org/jira/browse/OAK-8342 > Project: Jackrabbit Oak > Issue Type: Bug > Components: continuous integration >Reporter: Hudson >Priority: Major > > No description is provided > The build Jackrabbit Oak #2166 has failed. > First failed run: [Jackrabbit Oak > #2166|https://builds.apache.org/job/Jackrabbit%20Oak/2166/] [console > log|https://builds.apache.org/job/Jackrabbit%20Oak/2166/console] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (OAK-8342) Build Jackrabbit Oak #2166 failed
[ https://issues.apache.org/jira/browse/OAK-8342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcel Reutegger resolved OAK-8342. --- Resolution: Duplicate > Build Jackrabbit Oak #2166 failed > - > > Key: OAK-8342 > URL: https://issues.apache.org/jira/browse/OAK-8342 > Project: Jackrabbit Oak > Issue Type: Bug > Components: continuous integration >Reporter: Hudson >Priority: Major > > No description is provided > The build Jackrabbit Oak #2166 has failed. > First failed run: [Jackrabbit Oak > #2166|https://builds.apache.org/job/Jackrabbit%20Oak/2166/] [console > log|https://builds.apache.org/job/Jackrabbit%20Oak/2166/console] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OAK-8232) Node#setPrimaryType(String) does not create child nodes defined as autoCreated
[ https://issues.apache.org/jira/browse/OAK-8232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16849608#comment-16849608 ] Julian Reschke commented on OAK-8232: - trunk: [r1857592|http://svn.apache.org/r1857592] [r1857589|http://svn.apache.org/r1857589] > Node#setPrimaryType(String) does not create child nodes defined as autoCreated > -- > > Key: OAK-8232 > URL: https://issues.apache.org/jira/browse/OAK-8232 > Project: Jackrabbit Oak > Issue Type: Bug > Components: jcr >Affects Versions: 1.12.0 >Reporter: Manfred Baedke >Assignee: Manfred Baedke >Priority: Minor > Labels: candidate_oak_1_10 > Fix For: 1.14.0 > > Attachments: oak-8232-testcase.patch, oak-8232.patch > > > In contrast to Node#addNode(String, String), Node#setPrimaryType(String) does > not create child nodes that are defined as autoCreated. See attached failing > test case. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OAK-8248) Update Oak trunk and 1.10 to Jackrabbit 2.18.2
[ https://issues.apache.org/jira/browse/OAK-8248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16849605#comment-16849605 ] Julian Reschke commented on OAK-8248: - trunk: [r1860235|http://svn.apache.org/r1860235] 1.10: [r1860243|http://svn.apache.org/r1860243] > Update Oak trunk and 1.10 to Jackrabbit 2.18.2 > -- > > Key: OAK-8248 > URL: https://issues.apache.org/jira/browse/OAK-8248 > Project: Jackrabbit Oak > Issue Type: Task > Components: parent >Reporter: Julian Reschke >Priority: Trivial > Fix For: 1.10.3, 1.14.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (OAK-8248) Update Oak trunk and 1.10 to Jackrabbit 2.18.2
[ https://issues.apache.org/jira/browse/OAK-8248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke resolved OAK-8248. - Resolution: Fixed Fix Version/s: 1.14.0 1.10.3 > Update Oak trunk and 1.10 to Jackrabbit 2.18.2 > -- > > Key: OAK-8248 > URL: https://issues.apache.org/jira/browse/OAK-8248 > Project: Jackrabbit Oak > Issue Type: Task > Components: parent >Reporter: Julian Reschke >Priority: Trivial > Fix For: 1.10.3, 1.14.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OAK-8352) Update Oak trunk and 1.10 to Jackrabbit 2.18.2
[ https://issues.apache.org/jira/browse/OAK-8352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-8352: Fix Version/s: 1.14.0 1.10.3 > Update Oak trunk and 1.10 to Jackrabbit 2.18.2 > -- > > Key: OAK-8352 > URL: https://issues.apache.org/jira/browse/OAK-8352 > Project: Jackrabbit Oak > Issue Type: Task > Components: parent >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > Fix For: 1.10.3, 1.14.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OAK-8352) Update Oak trunk and 1.10 to Jackrabbit 2.18.2
[ https://issues.apache.org/jira/browse/OAK-8352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-8352: Fix Version/s: (was: 1.14.0) (was: 1.10.3) > Update Oak trunk and 1.10 to Jackrabbit 2.18.2 > -- > > Key: OAK-8352 > URL: https://issues.apache.org/jira/browse/OAK-8352 > Project: Jackrabbit Oak > Issue Type: Task > Components: parent >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OAK-8359) Build Jackrabbit Oak #2177 failed
Hudson created OAK-8359: --- Summary: Build Jackrabbit Oak #2177 failed Key: OAK-8359 URL: https://issues.apache.org/jira/browse/OAK-8359 Project: Jackrabbit Oak Issue Type: Bug Components: continuous integration Reporter: Hudson No description is provided The build Jackrabbit Oak #2177 has failed. First failed run: [Jackrabbit Oak #2177|https://builds.apache.org/job/Jackrabbit%20Oak/2177/] [console log|https://builds.apache.org/job/Jackrabbit%20Oak/2177/console] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OAK-8353) Additional test for OAK-8012
[
https://issues.apache.org/jira/browse/OAK-8353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Marcel Reutegger updated OAK-8353:
--
Fix Version/s: 1.6.18
> Additional test for OAK-8012
>
>
> Key: OAK-8353
> URL: https://issues.apache.org/jira/browse/OAK-8353
> Project: Jackrabbit Oak
> Issue Type: Test
> Components: documentmk
>Reporter: Marcel Reutegger
>Assignee: Marcel Reutegger
>Priority: Minor
> Fix For: 1.10.3, 1.14.0, 1.6.18, 1.8.14
>
>
> It turns out the issue described in OAK-8012 may also happen without a
> restart. An incorrect read may happen when the orphaned branch clean up kicks
> in. There is a race condition in the code before OAK-8012 changes. The read
> may check the state of an orphaned branch and doesn't see it in the
> {{UnmergedBranches}} map while it is still visible in the DocumentStore.
> This issue is about an additional test to verify OAK-8012 also fixes this
> situation.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (OAK-8353) Additional test for OAK-8012
[
https://issues.apache.org/jira/browse/OAK-8353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16849538#comment-16849538
]
Marcel Reutegger edited comment on OAK-8353 at 5/28/19 10:56 AM:
-
Merged into branches:
- 1.10: http://svn.apache.org/r1860212
- 1.8: http://svn.apache.org/r1860222
- 1.6: http://svn.apache.org/r1860242
was (Author: mreutegg):
Merged into branches:
- 1.10: http://svn.apache.org/r1860212
- 1.8: http://svn.apache.org/r1860222
> Additional test for OAK-8012
>
>
> Key: OAK-8353
> URL: https://issues.apache.org/jira/browse/OAK-8353
> Project: Jackrabbit Oak
> Issue Type: Test
> Components: documentmk
>Reporter: Marcel Reutegger
>Assignee: Marcel Reutegger
>Priority: Minor
> Fix For: 1.10.3, 1.14.0, 1.8.14
>
>
> It turns out the issue described in OAK-8012 may also happen without a
> restart. An incorrect read may happen when the orphaned branch clean up kicks
> in. There is a race condition in the code before OAK-8012 changes. The read
> may check the state of an orphaned branch and doesn't see it in the
> {{UnmergedBranches}} map while it is still visible in the DocumentStore.
> This issue is about an additional test to verify OAK-8012 also fixes this
> situation.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OAK-8344) Expose local index directory size as a metric
[ https://issues.apache.org/jira/browse/OAK-8344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16849588#comment-16849588 ] Thomas Mueller commented on OAK-8344: - [~nitigup] could you do the following change: use line breaks in "public long getLocalIndexDirSize()". Other than that, the patch looks fine. > Expose local index directory size as a metric > - > > Key: OAK-8344 > URL: https://issues.apache.org/jira/browse/OAK-8344 > Project: Jackrabbit Oak > Issue Type: Task > Components: indexing, lucene >Reporter: Nitin Gupta >Priority: Major > Attachments: OAK-8344.patch > > > We need to expose the local index directory size a metric that can later be > consumed for monitor and alerting purposes . > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OAK-8357) Support the truncate operation for the GCJournalFile
[
https://issues.apache.org/jira/browse/OAK-8357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tomek Rękawek reassigned OAK-8357:
--
Assignee: Tomek Rękawek
> Support the truncate operation for the GCJournalFile
>
>
> Key: OAK-8357
> URL: https://issues.apache.org/jira/browse/OAK-8357
> Project: Jackrabbit Oak
> Issue Type: Task
> Components: segment-azure, segment-tar
>Reporter: Tomek Rękawek
>Assignee: Tomek Rękawek
>Priority: Major
> Fix For: 1.14.0, 1.12.1
>
>
> The new {{truncate}} method, similar to the one in the JournalFile, would
> remove the content of the gc.log.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OAK-8357) Support the truncate operation for the GCJournalFile
[
https://issues.apache.org/jira/browse/OAK-8357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16849569#comment-16849569
]
Tomek Rękawek commented on OAK-8357:
Fixed for trunk in [r1860236|https://svn.apache.org/r1860236].
> Support the truncate operation for the GCJournalFile
>
>
> Key: OAK-8357
> URL: https://issues.apache.org/jira/browse/OAK-8357
> Project: Jackrabbit Oak
> Issue Type: Task
> Components: segment-azure, segment-tar
>Reporter: Tomek Rękawek
>Priority: Major
> Fix For: 1.14.0, 1.12.1
>
>
> The new {{truncate}} method, similar to the one in the JournalFile, would
> remove the content of the gc.log.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Resolved] (OAK-8357) Support the truncate operation for the GCJournalFile
[
https://issues.apache.org/jira/browse/OAK-8357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tomek Rękawek resolved OAK-8357.
Resolution: Fixed
> Support the truncate operation for the GCJournalFile
>
>
> Key: OAK-8357
> URL: https://issues.apache.org/jira/browse/OAK-8357
> Project: Jackrabbit Oak
> Issue Type: Task
> Components: segment-azure, segment-tar
>Reporter: Tomek Rękawek
>Assignee: Tomek Rękawek
>Priority: Major
> Fix For: 1.14.0, 1.12.1
>
>
> The new {{truncate}} method, similar to the one in the JournalFile, would
> remove the content of the gc.log.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Resolved] (OAK-8356) Support append mode in the SegmentStoreMigrator
[ https://issues.apache.org/jira/browse/OAK-8356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomek Rękawek resolved OAK-8356. Resolution: Fixed Assignee: Tomek Rękawek Fixed for trunk in [r1860237|https://svn.apache.org/r1860237]. > Support append mode in the SegmentStoreMigrator > --- > > Key: OAK-8356 > URL: https://issues.apache.org/jira/browse/OAK-8356 > Project: Jackrabbit Oak > Issue Type: Task > Components: segment-azure >Reporter: Tomek Rękawek >Assignee: Tomek Rękawek >Priority: Major > Fix For: 1.14.0, 1.12.1 > > > In case the target segment store already exists, it should be possible to > only append the missing segments from the source and update the metadata, > skipping the existing archives. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OAK-8358) oak-run check should have an option for specifying memory mapping
Andrei Dulceanu created OAK-8358:
Summary: oak-run check should have an option for specifying memory
mapping
Key: OAK-8358
URL: https://issues.apache.org/jira/browse/OAK-8358
Project: Jackrabbit Oak
Issue Type: New Feature
Components: run, segment-tar
Reporter: Andrei Dulceanu
Assignee: Andrei Dulceanu
{{oak-run check}} currently uses memory mapping by default when building the
{{FileStore}}. This setting should be configurable, to allow switching memory
mapping off.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (OAK-8357) Support the truncate operation for the GCJournalFile
Tomek Rękawek created OAK-8357:
--
Summary: Support the truncate operation for the GCJournalFile
Key: OAK-8357
URL: https://issues.apache.org/jira/browse/OAK-8357
Project: Jackrabbit Oak
Issue Type: Task
Components: segment-azure, segment-tar
Reporter: Tomek Rękawek
Fix For: 1.14.0, 1.12.1
The new {{truncate}} method, similar to the one in the JournalFile, would
remove the content of the gc.log.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (OAK-8356) Support append mode in the SegmentStoreMigrator
Tomek Rękawek created OAK-8356: -- Summary: Support append mode in the SegmentStoreMigrator Key: OAK-8356 URL: https://issues.apache.org/jira/browse/OAK-8356 Project: Jackrabbit Oak Issue Type: Task Components: segment-azure Reporter: Tomek Rękawek Fix For: 1.14.0, 1.12.1 In case the target segment store already exists, it should be possible to only append the missing segments from the source and update the metadata, skipping the existing archives. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OAK-8355) AuthorizableImpl.isEveryone should not throw RepositoryException
angela created OAK-8355:
---
Summary: AuthorizableImpl.isEveryone should not throw
RepositoryException
Key: OAK-8355
URL: https://issues.apache.org/jira/browse/OAK-8355
Project: Jackrabbit Oak
Issue Type: Improvement
Components: 1.14
Reporter: angela
Assignee: angela
{{AuthorizableImpl.isEveryone}} should be refactored such that it doesn't throw
{{RepositoryException}}, which is not needed for this internal method.
[~stillalex], fyi
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OAK-8342) Build Jackrabbit Oak #2166 failed
[ https://issues.apache.org/jira/browse/OAK-8342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16849550#comment-16849550 ] Hudson commented on OAK-8342: - Previously failing build now is OK. Passed run: [Jackrabbit Oak #2176|https://builds.apache.org/job/Jackrabbit%20Oak/2176/] [console log|https://builds.apache.org/job/Jackrabbit%20Oak/2176/console] > Build Jackrabbit Oak #2166 failed > - > > Key: OAK-8342 > URL: https://issues.apache.org/jira/browse/OAK-8342 > Project: Jackrabbit Oak > Issue Type: Bug > Components: continuous integration >Reporter: Hudson >Priority: Major > > No description is provided > The build Jackrabbit Oak #2166 has failed. > First failed run: [Jackrabbit Oak > #2166|https://builds.apache.org/job/Jackrabbit%20Oak/2166/] [console > log|https://builds.apache.org/job/Jackrabbit%20Oak/2166/console] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (OAK-8354) Fix/Add nullability annotations with o.a.j.oak.security.user package
[ https://issues.apache.org/jira/browse/OAK-8354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] angela resolved OAK-8354. - Resolution: Fixed revision 1860234 > Fix/Add nullability annotations with o.a.j.oak.security.user package > > > Key: OAK-8354 > URL: https://issues.apache.org/jira/browse/OAK-8354 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: core, security >Reporter: angela >Assignee: angela >Priority: Trivial > Fix For: 1.14.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OAK-8354) Fix/Add nullability annotations with o.a.j.oak.security.user package
angela created OAK-8354: --- Summary: Fix/Add nullability annotations with o.a.j.oak.security.user package Key: OAK-8354 URL: https://issues.apache.org/jira/browse/OAK-8354 Project: Jackrabbit Oak Issue Type: Improvement Components: core, security Reporter: angela Assignee: angela Fix For: 1.14.0 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OAK-8353) Additional test for OAK-8012
[
https://issues.apache.org/jira/browse/OAK-8353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Marcel Reutegger updated OAK-8353:
--
Fix Version/s: 1.8.14
1.10.3
Merged into branches:
- 1.10: http://svn.apache.org/r1860212
- 1.8: http://svn.apache.org/r1860222
> Additional test for OAK-8012
>
>
> Key: OAK-8353
> URL: https://issues.apache.org/jira/browse/OAK-8353
> Project: Jackrabbit Oak
> Issue Type: Test
> Components: documentmk
>Reporter: Marcel Reutegger
>Assignee: Marcel Reutegger
>Priority: Minor
> Fix For: 1.10.3, 1.14.0, 1.8.14
>
>
> It turns out the issue described in OAK-8012 may also happen without a
> restart. An incorrect read may happen when the orphaned branch clean up kicks
> in. There is a race condition in the code before OAK-8012 changes. The read
> may check the state of an orphaned branch and doesn't see it in the
> {{UnmergedBranches}} map while it is still visible in the DocumentStore.
> This issue is about an additional test to verify OAK-8012 also fixes this
> situation.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OAK-8238) MongoDocumentStore support for AWS DocumentDB
[ https://issues.apache.org/jira/browse/OAK-8238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcel Reutegger updated OAK-8238: -- Affects Version/s: (was: 1.9.8) > MongoDocumentStore support for AWS DocumentDB > - > > Key: OAK-8238 > URL: https://issues.apache.org/jira/browse/OAK-8238 > Project: Jackrabbit Oak > Issue Type: New Feature > Components: mongomk >Reporter: Vishnu Aggarwal >Priority: Major > Labels: aws, aws-documentdb, documentdb, mongo > > Hi, > I was trying to run a Grails 3.3.5 application with Apache OAK 1.9.8 and AWS > Document DB(which replicates MongoDB 3.6). However, upon running the > application it was found that, > org.apache.jackrabbit.oak.plugins.document.mongo.MongoUtils#createPartialIndex > fails to execute since, DocumentDB does not supports Partial Indexes > ([https://docs.aws.amazon.com/documentdb/latest/developerguide/mongo-apis-index.html]). > It would be good if there is full working compatibility made for OAK to run > with AWS DocumentDB too. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OAK-8321) Use format specifier for log output
[
https://issues.apache.org/jira/browse/OAK-8321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16841049#comment-16841049
]
angela edited comment on OAK-8321 at 5/28/19 9:31 AM:
--
- revision 1859353: {{TokenProviderImpl}}
- revision 1860216: package o.a.j.oak.security.user
was (Author: anchela):
- revision 1859353: {{TokenProviderImpl}}
> Use format specifier for log output
> ---
>
> Key: OAK-8321
> URL: https://issues.apache.org/jira/browse/OAK-8321
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: core, security
>Reporter: angela
>Assignee: angela
>Priority: Trivial
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (OAK-8227) Performance benchmarks
[
https://issues.apache.org/jira/browse/OAK-8227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16849475#comment-16849475
]
angela edited comment on OAK-8227 at 5/28/19 9:30 AM:
--
initial commit revision 1860199 with an open TODO related to OAK-8155
the benchmarks include:
- {{PrinicipalBasedReadTest}}:
> base test that is responsible for the setup (see below)
> test-run as in ReadDeepTreeTest
- {{HasItemGetItemIsModifiedTest}}
> test-run not only reads random items ({{Session.hasItem}},
{{Session.getItem}}) but additionally calls {{Item.isModified}}.
- {{PermissionEvaluationTest}}
> test-run will call {{Session.hasPermission}} for randomly selected paths
and randomly selected permissions
The following test options can be specified:
- number of items to read (or number of hasPermission calls, respectively)
- number of initial ACEs to be created
- number of principals in the test-subject (the test will create system users)
- weather or not the initial # of ACEs are created for each principal or
whether ACEs will be created for rotating principals
- doReport: if selected will print an report on how many nodes/properties have
been read
In order to compare principal-based with the default authorization the
following additional options are present:
- testDefault: if {{true}} the authorization setup will only include the
default model otherwise principal-basd and default
- compositionType: AND or OR composition for multiple authorization models
- useAggregationFilter: TODO once OAK-8155 is available
was (Author: anchela):
initial commit revision 1860199 with an open TODO related to OAK-8155
> Performance benchmarks
> --
>
> Key: OAK-8227
> URL: https://issues.apache.org/jira/browse/OAK-8227
> Project: Jackrabbit Oak
> Issue Type: Technical task
> Components: benchmarks
>Reporter: angela
>Assignee: angela
>Priority: Major
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Resolved] (OAK-8353) Additional test for OAK-8012
[
https://issues.apache.org/jira/browse/OAK-8353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Marcel Reutegger resolved OAK-8353.
---
Resolution: Fixed
Fix Version/s: 1.14.0
Added test to trunk: http://svn.apache.org/r1860202
> Additional test for OAK-8012
>
>
> Key: OAK-8353
> URL: https://issues.apache.org/jira/browse/OAK-8353
> Project: Jackrabbit Oak
> Issue Type: Test
> Components: documentmk
>Reporter: Marcel Reutegger
>Assignee: Marcel Reutegger
>Priority: Minor
> Fix For: 1.14.0
>
>
> It turns out the issue described in OAK-8012 may also happen without a
> restart. An incorrect read may happen when the orphaned branch clean up kicks
> in. There is a race condition in the code before OAK-8012 changes. The read
> may check the state of an orphaned branch and doesn't see it in the
> {{UnmergedBranches}} map while it is still visible in the DocumentStore.
> This issue is about an additional test to verify OAK-8012 also fixes this
> situation.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OAK-8261) Indexing lane failing but the index is not marked corrupt
[ https://issues.apache.org/jira/browse/OAK-8261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16849481#comment-16849481 ] Thomas Mueller commented on OAK-8261: - http://svn.apache.org/r1860192 (formatting changes) http://svn.apache.org/r1860200 (fix and test case) > Indexing lane failing but the index is not marked corrupt > - > > Key: OAK-8261 > URL: https://issues.apache.org/jira/browse/OAK-8261 > Project: Jackrabbit Oak > Issue Type: Bug > Components: indexing >Reporter: Mohit Kataria >Assignee: Thomas Mueller >Priority: Minor > Attachments: > 0001-OAK-8261-Indexing-lane-failing-but-the-index-is-not-.patch, > 0002-OAK-8261-Formatting-changes-Indexing-lane-failing-bu.patch, > 0003-OAK-8261-Indexing-lane-failing-but-the-index-is-not-.patch, trace.log > > > Steps to reproduce issue: > Delete blob filesystem(in case of tarmk) from repository/datastore and empty > repository/index folder. > Now asyncIndexUpdate will run periodically and fail but index won't get > marked as corrupt. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (OAK-8261) Indexing lane failing but the index is not marked corrupt
[ https://issues.apache.org/jira/browse/OAK-8261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Mueller resolved OAK-8261. - Resolution: Fixed Fix Version/s: 1.14.0 > Indexing lane failing but the index is not marked corrupt > - > > Key: OAK-8261 > URL: https://issues.apache.org/jira/browse/OAK-8261 > Project: Jackrabbit Oak > Issue Type: Bug > Components: indexing >Reporter: Mohit Kataria >Assignee: Thomas Mueller >Priority: Minor > Fix For: 1.14.0 > > Attachments: > 0001-OAK-8261-Indexing-lane-failing-but-the-index-is-not-.patch, > 0002-OAK-8261-Formatting-changes-Indexing-lane-failing-bu.patch, > 0003-OAK-8261-Indexing-lane-failing-but-the-index-is-not-.patch, trace.log > > > Steps to reproduce issue: > Delete blob filesystem(in case of tarmk) from repository/datastore and empty > repository/index folder. > Now asyncIndexUpdate will run periodically and fail but index won't get > marked as corrupt. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OAK-8227) Performance benchmarks
[ https://issues.apache.org/jira/browse/OAK-8227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16849475#comment-16849475 ] angela edited comment on OAK-8227 at 5/28/19 8:36 AM: -- initial commit revision 1860199 with an open TODO related to OAK-8155 was (Author: anchela): initial commit revision 1860199. > Performance benchmarks > -- > > Key: OAK-8227 > URL: https://issues.apache.org/jira/browse/OAK-8227 > Project: Jackrabbit Oak > Issue Type: Technical task > Components: benchmarks >Reporter: angela >Assignee: angela >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OAK-8227) Performance benchmarks
[ https://issues.apache.org/jira/browse/OAK-8227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16849475#comment-16849475 ] angela commented on OAK-8227: - initial commit revision 1860199. > Performance benchmarks > -- > > Key: OAK-8227 > URL: https://issues.apache.org/jira/browse/OAK-8227 > Project: Jackrabbit Oak > Issue Type: Technical task > Components: benchmarks >Reporter: angela >Assignee: angela >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OAK-8353) Additional test for OAK-8012
Marcel Reutegger created OAK-8353:
-
Summary: Additional test for OAK-8012
Key: OAK-8353
URL: https://issues.apache.org/jira/browse/OAK-8353
Project: Jackrabbit Oak
Issue Type: Test
Components: documentmk
Reporter: Marcel Reutegger
Assignee: Marcel Reutegger
It turns out the issue described in OAK-8012 may also happen without a restart.
An incorrect read may happen when the orphaned branch clean up kicks in. There
is a race condition in the code before OAK-8012 changes. The read may check the
state of an orphaned branch and doesn't see it in the {{UnmergedBranches}} map
while it is still visible in the DocumentStore.
This issue is about an additional test to verify OAK-8012 also fixes this
situation.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (OAK-8261) Indexing lane failing but the index is not marked corrupt
[ https://issues.apache.org/jira/browse/OAK-8261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Mueller reassigned OAK-8261: --- Assignee: Thomas Mueller > Indexing lane failing but the index is not marked corrupt > - > > Key: OAK-8261 > URL: https://issues.apache.org/jira/browse/OAK-8261 > Project: Jackrabbit Oak > Issue Type: Bug > Components: indexing >Reporter: Mohit Kataria >Assignee: Thomas Mueller >Priority: Minor > Attachments: > 0001-OAK-8261-Indexing-lane-failing-but-the-index-is-not-.patch, > 0002-OAK-8261-Formatting-changes-Indexing-lane-failing-bu.patch, > 0003-OAK-8261-Indexing-lane-failing-but-the-index-is-not-.patch, trace.log > > > Steps to reproduce issue: > Delete blob filesystem(in case of tarmk) from repository/datastore and empty > repository/index folder. > Now asyncIndexUpdate will run periodically and fail but index won't get > marked as corrupt. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OAK-8343) Allow queries to be delayed until an index is available
[ https://issues.apache.org/jira/browse/OAK-8343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16849434#comment-16849434 ] Thomas Mueller commented on OAK-8343: - I should probably replace ":async" with the constant (make it public). But maybe there is an alternative. Starting the async indexing earlier might be problematic in a clustered environment (I guess that async indexing requires that cluster topology is known / this service started). > Allow queries to be delayed until an index is available > --- > > Key: OAK-8343 > URL: https://issues.apache.org/jira/browse/OAK-8343 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: lucene, query >Reporter: Thomas Mueller >Assignee: Thomas Mueller >Priority: Major > Fix For: 1.14.0 > > Attachments: OAK-8343-b.patch, OAK-8343.patch > > > Currently, indexes are built asynchronously. That is, if an index definition > is added, the index is eventually built, but it's quite hard to say when it > is ready for queries. This can be specially a problem right after the initial > repository initialization, or after an upgrade. > In theory, system startup could be delayed until all indexes are ready (e.g. > set the "reindex" flag for important indexes, and at startup, wait until the > "reindex" flag is set to "false"). However, doing that would block threads > that _don't_ need an index. It would be better to only block threads that > actually do run queries. That would make startup deterministic, without > delaying other threads unnecessarily. > To solve the problem, we can add a property "waitForIndex" in the index > definition (just Lucene indexes is fine for now, as those are the important > asynchronous ones). If set, then queries that potentially use those indexes > are delayed, until the indexes are ready for sure. Reindex would need to > remove that property (the same as it removes e.g. refresh or sets reindex to > false). For added security, queries are only blocked as long as "reindex" is > also set to true (this ensures that waitForIndex is removed eventually), and > waiting should time out after 2 minutes, to ensure the feature doesn't block > startup forever if indexing fails for some reason. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OAK-8248) Update Oak trunk and 1.10 to Jackrabbit 2.18.2
[ https://issues.apache.org/jira/browse/OAK-8248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-8248: Summary: Update Oak trunk and 1.10 to Jackrabbit 2.18.2 (was: Update Oak trunk to Jackrabbit 2.18.2) > Update Oak trunk and 1.10 to Jackrabbit 2.18.2 > -- > > Key: OAK-8248 > URL: https://issues.apache.org/jira/browse/OAK-8248 > Project: Jackrabbit Oak > Issue Type: Task > Components: parent >Reporter: Julian Reschke >Priority: Trivial > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (OAK-8352) Update Oak trunk and 1.10 to Jackrabbit 2.18.2
[ https://issues.apache.org/jira/browse/OAK-8352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke resolved OAK-8352. - Resolution: Duplicate > Update Oak trunk and 1.10 to Jackrabbit 2.18.2 > -- > > Key: OAK-8352 > URL: https://issues.apache.org/jira/browse/OAK-8352 > Project: Jackrabbit Oak > Issue Type: Task > Components: parent >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OAK-8352) Update Oak trunk and 1.10 to Jackrabbit 2.18.2
Julian Reschke created OAK-8352: --- Summary: Update Oak trunk and 1.10 to Jackrabbit 2.18.2 Key: OAK-8352 URL: https://issues.apache.org/jira/browse/OAK-8352 Project: Jackrabbit Oak Issue Type: Task Components: parent Reporter: Julian Reschke Assignee: Julian Reschke -- This message was sent by Atlassian JIRA (v7.6.3#76005)
