Re: [jfx15] RFR: 8250799: NumberStringConverter and its subclasses are missing documentation for all their constructors [v3]

2020-07-30 Thread Nir Lisker 
> This was missed the in Javadoc fixes for 15.
> 
> Added documentation for all the constructors, did a bit of formatting, and 
> removed redundant comments.

Nir Lisker has updated the pull request incrementally with one additional 
commit since the last revision:

  Corrected NumberFormat constructor text

-

Changes:
  - all: https://git.openjdk.java.net/jfx/pull/277/files
  - new: https://git.openjdk.java.net/jfx/pull/277/files/72c0b00d..8f19315b

Webrevs:
 - full: https://webrevs.openjdk.java.net/jfx/277/webrev.02
 - incr: https://webrevs.openjdk.java.net/jfx/277/webrev.01-02

  Stats: 5 lines in 3 files changed: 0 ins; 2 del; 3 mod
  Patch: https://git.openjdk.java.net/jfx/pull/277.diff
  Fetch: git fetch https://git.openjdk.java.net/jfx pull/277/head:pull/277

PR: https://git.openjdk.java.net/jfx/pull/277

JavaFX 15 is in Rampdown Phase Two (RDP2)

2020-07-30 Thread Kevin Rushforth 

To: OpenJFX Developers

As a reminder, JavaFX 15 is now in Rampdown Phase Two (RDP2). [1]

P1-P2 bugs, and test or doc bugs of any priority, can be fixed during 
RDP2. Explicit approval is needed for bug fixes (except for doc and test 
fixes), and all enhancements to go in to the jfx15 branch. The bar for 
approving bug fixes is appropriately high at this point. We do not 
anticipate approving any more enhancements.


We will use the same rules for RDP2 that the JDK uses [2], with two 
modifications:


1. Approval is needed from one of the OpenJFX project leads (not the 
OpenJDK project lead)


2. Since we are not part of the JDK, we need to use labels that do not 
collide with the JDK 15 release. As an obvious choice, derived from the 
JBS fix version, we will use "openjfx15-fix-request", 
"openjfx15-fix-yes", "openjfx15-fix-no" and "openjfx15-fix-nmi", 
"openjfx15-enhancement-request", "openjfx15-enhancement-yes", 
"openjfx15-enhancement-no" and "openjfx15-enhancement-nmi" as 
corresponding labels.


Note that if a fix is approved to integrate into jfx15 (with the 
appropriate approval label added by a lead), then the PR should be 
targeted to the jfx15 branch. There is no need to also create a separate 
PR to integrate it into master -- we will continue to periodically sync 
jfx15 --> master for the duration of the openjfx15 release.


Now that we are in RDP2, the goal is to stabilize what is there, fixing 
bugs that are new in openjfx15. We need to be extremely careful about 
including anything that introduces risk.


IMPORTANT: Reviewers and Committers now have an extra responsibility to 
double-check the target branch of each PR that they review, integrate, 
or sponsor. By default a PR will be targeted to `master` which is the 
main development line (OpenJFX 16 as of today). This is usually what we 
want. A PR should be targeted to `jfx15` if, and only if, it is intended 
for OpenJFX 15 and meets the criteria for the current rampdown phase 
(we're in RDP2 as of today). Reviewers are advised to be extra cautious 
in approving potentially risky fixes targeted to `jfx15`. If there is a 
concern, then a reviewer can as part of the review indicate that the PR 
should be retargeted to `master` for 16. Reviewers also need to be extra 
careful when reviewing PRs targeted to jfx15 that it doesn't mistakenly 
contain any commits from the master branch. You'll be able to tell 
because the diffs will contain changes that are not part of the fix 
being reviewed. Such a PR will either need to be closed and redone, or 
it will need to be rebased and force-pushed.


Let me know if there are any questions.

-- Kevin

[1] 
https://mail.openjdk.java.net/pipermail/openjfx-dev/2020-March/025410.html

[2] http://openjdk.java.net/jeps/3

Re: Deadlock: JFXPanel, ContextMenu, macOS

2020-07-30 Thread Kevin Rushforth 

Thanks, I'll take a look at it and let you know if we need anything else.

-- Kevin


On 7/30/2020 8:45 AM, Steven Yi wrote:

Hi Kevin,

I pasted in the minimal reproducible example with the issue I filed as 
well as a link to the github repo; I hope the everything is in order.


Thanks,
Steven


On Thu, Jul 30, 2020 at 10:57 AM Kevin Rushforth 
mailto:kevin.rushfo...@oracle.com>> wrote:


If you can provide a small, standalone test case as part of the bug
report, that would be ideal.

Thanks.

-- Kevin


On 7/30/2020 6:46 AM, Steven Yi wrote:
> Hi Michael,
>
> Thanks for the link, I missed that when I went to explore JBS.
I'll report
> the issue there.
>
> All best,
> Steven
>
>
> On Thu, Jul 30, 2020 at 3:25 AM Michael Paus mailto:m...@jugs.org>> wrote:
>
>> Hi Steven,
>> the right place for bug reports like this is here:
>> 
>> Michael
>>
>> Am 30.07.20 um 01:28 schrieb Steven Yi:
>>> Hi All,
>>>
>>> I'm not sure if this is the place to report this, but
hopefully so. (I
>> did
>>> not see a way to create an account or report issues on JBS.)
>>>
>>> I am using JavaFX embedded within a Swing application and had
found
>>> intermittent deadlocks on macOS that I wasn't sure why it was
happening.
>> I
>>> was finally able to create a minimal working example and have
published
>> it
>>> here:
>>>
>>> https://github.com/kunstmusik/ContextMenuHangingTest
>>>
>>> The switching applications seems to be a key to getting the
deadlock to
>>> happen. Testing with debugger in Netbeans, when the app
freezes, I paused
>>> the app and saw this in the Java FX Application Thread stack:
>>>
>>> "JavaFX Application Thread"
>>> at sun.lwawt.macosx.LWCToolkit.doAWTRunLoopImpl(LWCToolkit.java)
>>> at sun.lwawt.macosx.LWCToolkit.doAWTRunLoop(LWCToolkit.java:913)
>>> at sun.lwawt.macosx.LWCToolkit.invokeAndWait(LWCToolkit.java:694)
>>> at sun.lwawt.macosx.LWCToolkit.invokeAndWait(LWCToolkit.java:639)
>>> at
sun.lwawt.macosx.CAccessibility.invokeAndWait(CAccessibility.java:94)
>>> at
sun.lwawt.macosx.CAccessibility.getFocusOwner(CAccessibility.java:548)
>>> at com.sun.glass.ui.mac.MacWindow._setView(MacWindow.java)
>>> at com.sun.glass.ui.Window.setView(Window.java:416)
>>> at
>>>
>>

com.sun.javafx.tk.quantum.WindowStage.lambda$setScene$0(WindowStage.java:287)
>>> at com.sun.javafx.tk.quantum.WindowStage$$Lambda$359.792704517.get
>>> at
>>>
>>

com.sun.javafx.tk.quantum.QuantumToolkit.runWithRenderLock(QuantumToolkit.java:430)
>>> at
com.sun.javafx.tk.quantum.WindowStage.setScene(WindowStage.java:286)
>>> at javafx.stage.Window$12.invalidated(Window.java:1085)
>>> at
>>>
>>

javafx.beans.property.BooleanPropertyBase.markInvalid(BooleanPropertyBase.java:110)
>>> at
>>>
>>
javafx.beans.property.BooleanPropertyBase.set(BooleanPropertyBase.java:145)
>>> at javafx.stage.Window.setShowing(Window.java:1174)
>>> at javafx.stage.Window.show(Window.java:1189)
>>> at javafx.stage.PopupWindow.showImpl(PopupWindow.java:472)
>>> at javafx.stage.PopupWindow.show(PopupWindow.java:417)
>>> at javafx.scene.control.ContextMenu.doShow(ContextMenu.java:323)
>>> at javafx.scene.control.ContextMenu.show(ContextMenu.java:265)
>>> at
>>>
>>

com.kunstmusik.contextmenuhangingtest.HangingTest.lambda$main$0(HangingTest.java:29)
>>> at
>>>
>>

com.kunstmusik.contextmenuhangingtest.HangingTest$$Lambda$191.1699780362.handle
>>> at
>>>
>>

com.sun.javafx.event.CompositeEventHandler.dispatchBubblingEvent(CompositeEventHandler.java:86)
>>> at
>>>
>>

com.sun.javafx.event.EventHandlerManager.dispatchBubblingEvent(EventHandlerManager.java:234)
>>> at
>>>
>>

com.sun.javafx.event.EventHandlerManager.dispatchBubblingEvent(EventHandlerManager.java:191)
>>> at
>>>
>>

com.sun.javafx.event.CompositeEventDispatcher.dispatchBubblingEvent(CompositeEventDispatcher.java:59)
>>> at
>>>
>>

com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:58)
>>> at
>>>
>>

com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114)
>>> at
>>>
>>

com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:56)
>>> at
>>>
>>

com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114)
>>> at
>>>
>>

com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:56)
>>> at
>>>
>>

com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114)
>>> at com.sun.javafx.event.Eve

Re: Deadlock: JFXPanel, ContextMenu, macOS

2020-07-30 Thread Steven Yi 
Hi Kevin,

I pasted in the minimal reproducible example with the issue I filed as well
as a link to the github repo; I hope the everything is in order.

Thanks,
Steven


On Thu, Jul 30, 2020 at 10:57 AM Kevin Rushforth 
wrote:

> If you can provide a small, standalone test case as part of the bug
> report, that would be ideal.
>
> Thanks.
>
> -- Kevin
>
>
> On 7/30/2020 6:46 AM, Steven Yi wrote:
> > Hi Michael,
> >
> > Thanks for the link, I missed that when I went to explore JBS. I'll
> report
> > the issue there.
> >
> > All best,
> > Steven
> >
> >
> > On Thu, Jul 30, 2020 at 3:25 AM Michael Paus  wrote:
> >
> >> Hi Steven,
> >> the right place for bug reports like this is here:
> >> 
> >> Michael
> >>
> >> Am 30.07.20 um 01:28 schrieb Steven Yi:
> >>> Hi All,
> >>>
> >>> I'm not sure if this is the place to report this, but hopefully so. (I
> >> did
> >>> not see a way to create an account or report issues on JBS.)
> >>>
> >>> I am using JavaFX embedded within a Swing application and had found
> >>> intermittent deadlocks on macOS that I wasn't sure why it was
> happening.
> >> I
> >>> was finally able to create a minimal working example and have published
> >> it
> >>> here:
> >>>
> >>> https://github.com/kunstmusik/ContextMenuHangingTest
> >>>
> >>> The switching applications seems to be a key to getting the deadlock to
> >>> happen. Testing with debugger in Netbeans, when the app freezes, I
> paused
> >>> the app and saw this in the Java FX Application Thread stack:
> >>>
> >>> "JavaFX Application Thread"
> >>> at sun.lwawt.macosx.LWCToolkit.doAWTRunLoopImpl(LWCToolkit.java)
> >>> at sun.lwawt.macosx.LWCToolkit.doAWTRunLoop(LWCToolkit.java:913)
> >>> at sun.lwawt.macosx.LWCToolkit.invokeAndWait(LWCToolkit.java:694)
> >>> at sun.lwawt.macosx.LWCToolkit.invokeAndWait(LWCToolkit.java:639)
> >>> at
> sun.lwawt.macosx.CAccessibility.invokeAndWait(CAccessibility.java:94)
> >>> at
> sun.lwawt.macosx.CAccessibility.getFocusOwner(CAccessibility.java:548)
> >>> at com.sun.glass.ui.mac.MacWindow._setView(MacWindow.java)
> >>> at com.sun.glass.ui.Window.setView(Window.java:416)
> >>> at
> >>>
> >>
> com.sun.javafx.tk.quantum.WindowStage.lambda$setScene$0(WindowStage.java:287)
> >>> at com.sun.javafx.tk.quantum.WindowStage$$Lambda$359.792704517.get
> >>> at
> >>>
> >>
> com.sun.javafx.tk.quantum.QuantumToolkit.runWithRenderLock(QuantumToolkit.java:430)
> >>> at com.sun.javafx.tk.quantum.WindowStage.setScene(WindowStage.java:286)
> >>> at javafx.stage.Window$12.invalidated(Window.java:1085)
> >>> at
> >>>
> >>
> javafx.beans.property.BooleanPropertyBase.markInvalid(BooleanPropertyBase.java:110)
> >>> at
> >>>
> >>
> javafx.beans.property.BooleanPropertyBase.set(BooleanPropertyBase.java:145)
> >>> at javafx.stage.Window.setShowing(Window.java:1174)
> >>> at javafx.stage.Window.show(Window.java:1189)
> >>> at javafx.stage.PopupWindow.showImpl(PopupWindow.java:472)
> >>> at javafx.stage.PopupWindow.show(PopupWindow.java:417)
> >>> at javafx.scene.control.ContextMenu.doShow(ContextMenu.java:323)
> >>> at javafx.scene.control.ContextMenu.show(ContextMenu.java:265)
> >>> at
> >>>
> >>
> com.kunstmusik.contextmenuhangingtest.HangingTest.lambda$main$0(HangingTest.java:29)
> >>> at
> >>>
> >>
> com.kunstmusik.contextmenuhangingtest.HangingTest$$Lambda$191.1699780362.handle
> >>> at
> >>>
> >>
> com.sun.javafx.event.CompositeEventHandler.dispatchBubblingEvent(CompositeEventHandler.java:86)
> >>> at
> >>>
> >>
> com.sun.javafx.event.EventHandlerManager.dispatchBubblingEvent(EventHandlerManager.java:234)
> >>> at
> >>>
> >>
> com.sun.javafx.event.EventHandlerManager.dispatchBubblingEvent(EventHandlerManager.java:191)
> >>> at
> >>>
> >>
> com.sun.javafx.event.CompositeEventDispatcher.dispatchBubblingEvent(CompositeEventDispatcher.java:59)
> >>> at
> >>>
> >>
> com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:58)
> >>> at
> >>>
> >>
> com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114)
> >>> at
> >>>
> >>
> com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:56)
> >>> at
> >>>
> >>
> com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114)
> >>> at
> >>>
> >>
> com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:56)
> >>> at
> >>>
> >>
> com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114)
> >>> at com.sun.javafx.event.EventUtil.fireEventImpl(EventUtil.java:74)
> >>> at com.sun.javafx.event.EventUtil.fireEvent(EventUtil.java:49)
> >>> at javafx.event.Event.fireEvent(Event.java:198)
> >>> at javafx.scene.Node.fireEvent(Node.java:8885)
> >>> at javafx.scene.control.Button.fire(Button.java:203)
> >>> at
> >>>
> >>
> com.sun.javafx.scene.control.behavior.ButtonBehavior.mouseReleased(ButtonBehavior.java:206)
> >>> at
> >>>
> >>
> com.sun.javafx.scene.control.behavior.ButtonBehavior$$Lambda$247.6

Re: Deadlock: JFXPanel, ContextMenu, macOS

2020-07-30 Thread Kevin Rushforth 
If you can provide a small, standalone test case as part of the bug 
report, that would be ideal.


Thanks.

-- Kevin


On 7/30/2020 6:46 AM, Steven Yi wrote:

Hi Michael,

Thanks for the link, I missed that when I went to explore JBS. I'll report
the issue there.

All best,
Steven


On Thu, Jul 30, 2020 at 3:25 AM Michael Paus  wrote:


Hi Steven,
the right place for bug reports like this is here:

Michael

Am 30.07.20 um 01:28 schrieb Steven Yi:

Hi All,

I'm not sure if this is the place to report this, but hopefully so. (I

did

not see a way to create an account or report issues on JBS.)

I am using JavaFX embedded within a Swing application and had found
intermittent deadlocks on macOS that I wasn't sure why it was happening.

I

was finally able to create a minimal working example and have published

it

here:

https://github.com/kunstmusik/ContextMenuHangingTest

The switching applications seems to be a key to getting the deadlock to
happen. Testing with debugger in Netbeans, when the app freezes, I paused
the app and saw this in the Java FX Application Thread stack:

"JavaFX Application Thread"
at sun.lwawt.macosx.LWCToolkit.doAWTRunLoopImpl(LWCToolkit.java)
at sun.lwawt.macosx.LWCToolkit.doAWTRunLoop(LWCToolkit.java:913)
at sun.lwawt.macosx.LWCToolkit.invokeAndWait(LWCToolkit.java:694)
at sun.lwawt.macosx.LWCToolkit.invokeAndWait(LWCToolkit.java:639)
at sun.lwawt.macosx.CAccessibility.invokeAndWait(CAccessibility.java:94)
at sun.lwawt.macosx.CAccessibility.getFocusOwner(CAccessibility.java:548)
at com.sun.glass.ui.mac.MacWindow._setView(MacWindow.java)
at com.sun.glass.ui.Window.setView(Window.java:416)
at


com.sun.javafx.tk.quantum.WindowStage.lambda$setScene$0(WindowStage.java:287)

at com.sun.javafx.tk.quantum.WindowStage$$Lambda$359.792704517.get
at


com.sun.javafx.tk.quantum.QuantumToolkit.runWithRenderLock(QuantumToolkit.java:430)

at com.sun.javafx.tk.quantum.WindowStage.setScene(WindowStage.java:286)
at javafx.stage.Window$12.invalidated(Window.java:1085)
at


javafx.beans.property.BooleanPropertyBase.markInvalid(BooleanPropertyBase.java:110)

at


javafx.beans.property.BooleanPropertyBase.set(BooleanPropertyBase.java:145)

at javafx.stage.Window.setShowing(Window.java:1174)
at javafx.stage.Window.show(Window.java:1189)
at javafx.stage.PopupWindow.showImpl(PopupWindow.java:472)
at javafx.stage.PopupWindow.show(PopupWindow.java:417)
at javafx.scene.control.ContextMenu.doShow(ContextMenu.java:323)
at javafx.scene.control.ContextMenu.show(ContextMenu.java:265)
at


com.kunstmusik.contextmenuhangingtest.HangingTest.lambda$main$0(HangingTest.java:29)

at


com.kunstmusik.contextmenuhangingtest.HangingTest$$Lambda$191.1699780362.handle

at


com.sun.javafx.event.CompositeEventHandler.dispatchBubblingEvent(CompositeEventHandler.java:86)

at


com.sun.javafx.event.EventHandlerManager.dispatchBubblingEvent(EventHandlerManager.java:234)

at


com.sun.javafx.event.EventHandlerManager.dispatchBubblingEvent(EventHandlerManager.java:191)

at


com.sun.javafx.event.CompositeEventDispatcher.dispatchBubblingEvent(CompositeEventDispatcher.java:59)

at


com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:58)

at


com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114)

at


com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:56)

at


com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114)

at


com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:56)

at


com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114)

at com.sun.javafx.event.EventUtil.fireEventImpl(EventUtil.java:74)
at com.sun.javafx.event.EventUtil.fireEvent(EventUtil.java:49)
at javafx.event.Event.fireEvent(Event.java:198)
at javafx.scene.Node.fireEvent(Node.java:8885)
at javafx.scene.control.Button.fire(Button.java:203)
at


com.sun.javafx.scene.control.behavior.ButtonBehavior.mouseReleased(ButtonBehavior.java:206)

at


com.sun.javafx.scene.control.behavior.ButtonBehavior$$Lambda$247.642849157.handle

at

com.sun.javafx.scene.control.inputmap.InputMap.handle(InputMap.java:274)

at


com.sun.javafx.scene.control.inputmap.InputMap$$Lambda$242.1652994145.handle

at


com.sun.javafx.event.CompositeEventHandler$NormalEventHandlerRecord.handleBubblingEvent(CompositeEventHandler.java:247)

at


com.sun.javafx.event.CompositeEventHandler.dispatchBubblingEvent(CompositeEventHandler.java:80)

at


com.sun.javafx.event.EventHandlerManager.dispatchBubblingEvent(EventHandlerManager.java:234)

at


com.sun.javafx.event.EventHandlerManager.dispatchBubblingEvent(EventHandlerManager.java:191)

at


com.sun.javafx.event.CompositeEventDispatcher.dispatchBubblingEvent(CompositeEventDispatcher.java:59)

at


com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:58)

at


com.sun.javafx.event.EventDispatc

Re: Deadlock: JFXPanel, ContextMenu, macOS

2020-07-30 Thread Steven Yi 
Hi Michael,

Thanks for the link, I missed that when I went to explore JBS. I'll report
the issue there.

All best,
Steven


On Thu, Jul 30, 2020 at 3:25 AM Michael Paus  wrote:

> Hi Steven,
> the right place for bug reports like this is here:
> 
> Michael
>
> Am 30.07.20 um 01:28 schrieb Steven Yi:
> > Hi All,
> >
> > I'm not sure if this is the place to report this, but hopefully so. (I
> did
> > not see a way to create an account or report issues on JBS.)
> >
> > I am using JavaFX embedded within a Swing application and had found
> > intermittent deadlocks on macOS that I wasn't sure why it was happening.
> I
> > was finally able to create a minimal working example and have published
> it
> > here:
> >
> > https://github.com/kunstmusik/ContextMenuHangingTest
> >
> > The switching applications seems to be a key to getting the deadlock to
> > happen. Testing with debugger in Netbeans, when the app freezes, I paused
> > the app and saw this in the Java FX Application Thread stack:
> >
> > "JavaFX Application Thread"
> > at sun.lwawt.macosx.LWCToolkit.doAWTRunLoopImpl(LWCToolkit.java)
> > at sun.lwawt.macosx.LWCToolkit.doAWTRunLoop(LWCToolkit.java:913)
> > at sun.lwawt.macosx.LWCToolkit.invokeAndWait(LWCToolkit.java:694)
> > at sun.lwawt.macosx.LWCToolkit.invokeAndWait(LWCToolkit.java:639)
> > at sun.lwawt.macosx.CAccessibility.invokeAndWait(CAccessibility.java:94)
> > at sun.lwawt.macosx.CAccessibility.getFocusOwner(CAccessibility.java:548)
> > at com.sun.glass.ui.mac.MacWindow._setView(MacWindow.java)
> > at com.sun.glass.ui.Window.setView(Window.java:416)
> > at
> >
> com.sun.javafx.tk.quantum.WindowStage.lambda$setScene$0(WindowStage.java:287)
> > at com.sun.javafx.tk.quantum.WindowStage$$Lambda$359.792704517.get
> > at
> >
> com.sun.javafx.tk.quantum.QuantumToolkit.runWithRenderLock(QuantumToolkit.java:430)
> > at com.sun.javafx.tk.quantum.WindowStage.setScene(WindowStage.java:286)
> > at javafx.stage.Window$12.invalidated(Window.java:1085)
> > at
> >
> javafx.beans.property.BooleanPropertyBase.markInvalid(BooleanPropertyBase.java:110)
> > at
> >
> javafx.beans.property.BooleanPropertyBase.set(BooleanPropertyBase.java:145)
> > at javafx.stage.Window.setShowing(Window.java:1174)
> > at javafx.stage.Window.show(Window.java:1189)
> > at javafx.stage.PopupWindow.showImpl(PopupWindow.java:472)
> > at javafx.stage.PopupWindow.show(PopupWindow.java:417)
> > at javafx.scene.control.ContextMenu.doShow(ContextMenu.java:323)
> > at javafx.scene.control.ContextMenu.show(ContextMenu.java:265)
> > at
> >
> com.kunstmusik.contextmenuhangingtest.HangingTest.lambda$main$0(HangingTest.java:29)
> > at
> >
> com.kunstmusik.contextmenuhangingtest.HangingTest$$Lambda$191.1699780362.handle
> > at
> >
> com.sun.javafx.event.CompositeEventHandler.dispatchBubblingEvent(CompositeEventHandler.java:86)
> > at
> >
> com.sun.javafx.event.EventHandlerManager.dispatchBubblingEvent(EventHandlerManager.java:234)
> > at
> >
> com.sun.javafx.event.EventHandlerManager.dispatchBubblingEvent(EventHandlerManager.java:191)
> > at
> >
> com.sun.javafx.event.CompositeEventDispatcher.dispatchBubblingEvent(CompositeEventDispatcher.java:59)
> > at
> >
> com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:58)
> > at
> >
> com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114)
> > at
> >
> com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:56)
> > at
> >
> com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114)
> > at
> >
> com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:56)
> > at
> >
> com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114)
> > at com.sun.javafx.event.EventUtil.fireEventImpl(EventUtil.java:74)
> > at com.sun.javafx.event.EventUtil.fireEvent(EventUtil.java:49)
> > at javafx.event.Event.fireEvent(Event.java:198)
> > at javafx.scene.Node.fireEvent(Node.java:8885)
> > at javafx.scene.control.Button.fire(Button.java:203)
> > at
> >
> com.sun.javafx.scene.control.behavior.ButtonBehavior.mouseReleased(ButtonBehavior.java:206)
> > at
> >
> com.sun.javafx.scene.control.behavior.ButtonBehavior$$Lambda$247.642849157.handle
> > at
> com.sun.javafx.scene.control.inputmap.InputMap.handle(InputMap.java:274)
> > at
> >
> com.sun.javafx.scene.control.inputmap.InputMap$$Lambda$242.1652994145.handle
> > at
> >
> com.sun.javafx.event.CompositeEventHandler$NormalEventHandlerRecord.handleBubblingEvent(CompositeEventHandler.java:247)
> > at
> >
> com.sun.javafx.event.CompositeEventHandler.dispatchBubblingEvent(CompositeEventHandler.java:80)
> > at
> >
> com.sun.javafx.event.EventHandlerManager.dispatchBubblingEvent(EventHandlerManager.java:234)
> > at
> >
> com.sun.javafx.event.EventHandlerManager.dispatchBubblingEvent(EventHandlerManager.java:191)
> > at
> >
> com.sun.javafx.event.CompositeEventDispatcher.dispatchBubbli

Re: [jfx15] RFR: 8250799: NumberStringConverter and its subclasses are missing documentation for all their constructors [v2]

2020-07-30 Thread Nir Lisker 
> This was missed the in Javadoc fixes for 15.
> 
> Added documentation for all the constructors, did a bit of formatting, and 
> removed redundant comments.

Nir Lisker has updated the pull request incrementally with one additional 
commit since the last revision:

  Added note on immutability

-

Changes:
  - all: https://git.openjdk.java.net/jfx/pull/277/files
  - new: https://git.openjdk.java.net/jfx/pull/277/files/5e7274ab..72c0b00d

Webrevs:
 - full: https://webrevs.openjdk.java.net/jfx/277/webrev.01
 - incr: https://webrevs.openjdk.java.net/jfx/277/webrev.00-01

  Stats: 4 lines in 3 files changed: 1 ins; 0 del; 3 mod
  Patch: https://git.openjdk.java.net/jfx/pull/277.diff
  Fetch: git fetch https://git.openjdk.java.net/jfx pull/277/head:pull/277

PR: https://git.openjdk.java.net/jfx/pull/277

Integrated: 8245053: Keyboard doesn't show when TextInputControl has focus

2020-07-30 Thread Abhinay Agarwal 
On Thu, 14 May 2020 19:22:54 GMT, Abhinay Agarwal 
 wrote:

> In Android, TextInputControls (TextField and TextArea) are responsible for 
> showing and hiding software keyboard.
> Currently, a focus listener is attached to these controls and is used to 
> toggle the visibility of keyboard. This
> condition fails in cases where the control already has focus but the keyboard 
> is not visible.  Ideally, the keyboard
> should be shown again when the user taps on the TextInputControl.
> This PR adds an event handler for `MouseEvent.MOUSE_CLICKED` event and shows 
> the keyboard  if the TextInput control is
> both editable and focused.

This pull request has now been integrated.

Changeset: 5d34d724
Author:Abhinay Agarwal 
Committer: Johan Vos 
URL:   https://git.openjdk.java.net/jfx/commit/5d34d724
Stats: 93 lines in 2 files changed: 6 ins; 63 del; 24 mod

8245053: Keyboard doesn't show when TextInputControl has focus

Reviewed-by: jvos

-

PR: https://git.openjdk.java.net/jfx/pull/219

Re: Deadlock: JFXPanel, ContextMenu, macOS

2020-07-30 Thread Michael Paus 

Hi Steven,
the right place for bug reports like this is here: 


Michael

Am 30.07.20 um 01:28 schrieb Steven Yi:

Hi All,

I'm not sure if this is the place to report this, but hopefully so. (I did
not see a way to create an account or report issues on JBS.)

I am using JavaFX embedded within a Swing application and had found
intermittent deadlocks on macOS that I wasn't sure why it was happening. I
was finally able to create a minimal working example and have published it
here:

https://github.com/kunstmusik/ContextMenuHangingTest

The switching applications seems to be a key to getting the deadlock to
happen. Testing with debugger in Netbeans, when the app freezes, I paused
the app and saw this in the Java FX Application Thread stack:

"JavaFX Application Thread"
at sun.lwawt.macosx.LWCToolkit.doAWTRunLoopImpl(LWCToolkit.java)
at sun.lwawt.macosx.LWCToolkit.doAWTRunLoop(LWCToolkit.java:913)
at sun.lwawt.macosx.LWCToolkit.invokeAndWait(LWCToolkit.java:694)
at sun.lwawt.macosx.LWCToolkit.invokeAndWait(LWCToolkit.java:639)
at sun.lwawt.macosx.CAccessibility.invokeAndWait(CAccessibility.java:94)
at sun.lwawt.macosx.CAccessibility.getFocusOwner(CAccessibility.java:548)
at com.sun.glass.ui.mac.MacWindow._setView(MacWindow.java)
at com.sun.glass.ui.Window.setView(Window.java:416)
at
com.sun.javafx.tk.quantum.WindowStage.lambda$setScene$0(WindowStage.java:287)
at com.sun.javafx.tk.quantum.WindowStage$$Lambda$359.792704517.get
at
com.sun.javafx.tk.quantum.QuantumToolkit.runWithRenderLock(QuantumToolkit.java:430)
at com.sun.javafx.tk.quantum.WindowStage.setScene(WindowStage.java:286)
at javafx.stage.Window$12.invalidated(Window.java:1085)
at
javafx.beans.property.BooleanPropertyBase.markInvalid(BooleanPropertyBase.java:110)
at
javafx.beans.property.BooleanPropertyBase.set(BooleanPropertyBase.java:145)
at javafx.stage.Window.setShowing(Window.java:1174)
at javafx.stage.Window.show(Window.java:1189)
at javafx.stage.PopupWindow.showImpl(PopupWindow.java:472)
at javafx.stage.PopupWindow.show(PopupWindow.java:417)
at javafx.scene.control.ContextMenu.doShow(ContextMenu.java:323)
at javafx.scene.control.ContextMenu.show(ContextMenu.java:265)
at
com.kunstmusik.contextmenuhangingtest.HangingTest.lambda$main$0(HangingTest.java:29)
at
com.kunstmusik.contextmenuhangingtest.HangingTest$$Lambda$191.1699780362.handle
at
com.sun.javafx.event.CompositeEventHandler.dispatchBubblingEvent(CompositeEventHandler.java:86)
at
com.sun.javafx.event.EventHandlerManager.dispatchBubblingEvent(EventHandlerManager.java:234)
at
com.sun.javafx.event.EventHandlerManager.dispatchBubblingEvent(EventHandlerManager.java:191)
at
com.sun.javafx.event.CompositeEventDispatcher.dispatchBubblingEvent(CompositeEventDispatcher.java:59)
at
com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:58)
at
com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114)
at
com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:56)
at
com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114)
at
com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:56)
at
com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114)
at com.sun.javafx.event.EventUtil.fireEventImpl(EventUtil.java:74)
at com.sun.javafx.event.EventUtil.fireEvent(EventUtil.java:49)
at javafx.event.Event.fireEvent(Event.java:198)
at javafx.scene.Node.fireEvent(Node.java:8885)
at javafx.scene.control.Button.fire(Button.java:203)
at
com.sun.javafx.scene.control.behavior.ButtonBehavior.mouseReleased(ButtonBehavior.java:206)
at
com.sun.javafx.scene.control.behavior.ButtonBehavior$$Lambda$247.642849157.handle
at com.sun.javafx.scene.control.inputmap.InputMap.handle(InputMap.java:274)
at
com.sun.javafx.scene.control.inputmap.InputMap$$Lambda$242.1652994145.handle
at
com.sun.javafx.event.CompositeEventHandler$NormalEventHandlerRecord.handleBubblingEvent(CompositeEventHandler.java:247)
at
com.sun.javafx.event.CompositeEventHandler.dispatchBubblingEvent(CompositeEventHandler.java:80)
at
com.sun.javafx.event.EventHandlerManager.dispatchBubblingEvent(EventHandlerManager.java:234)
at
com.sun.javafx.event.EventHandlerManager.dispatchBubblingEvent(EventHandlerManager.java:191)
at
com.sun.javafx.event.CompositeEventDispatcher.dispatchBubblingEvent(CompositeEventDispatcher.java:59)
at
com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:58)
at
com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114)
at
com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:56)
at
com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114)
at
com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:56)
at
com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114

Re: RFR: 8209788: Left/Right/Ctrl+A keys not working in editor of ComboBox if popup showing [v3]

2020-07-30 Thread Ambarish Rapte 
On Thu, 23 Jul 2020 17:57:34 GMT, Kevin Rushforth  wrote:

>> Ambarish Rapte has updated the pull request incrementally with two 
>> additional commits since the last revision:
>> 
>>  - revert unintended line deletion
>>  - changes to address to review
>
> Once the merge conflicts and review comments are addressed, I'll put this 
> back on my review queue.

Please review the updated change:

1. Changed the approach to add a property named 
`removeKeyMappingsForComboBoxEditor` to ListView when creating it from
ComboBox. Please do suggest if this name sounds Ok. 2. When this property is 
present some KeyMappings that are needed
for ComboBox Editor get removed from `ListViewBehavior`. 3. I have considered 
to remove some more KeyMappings which
seem like they should be passed on to ComboBox's Editor.(method 
`removeKeyMappingsForComboBoxEditor()`) 4. There is an
existing issue with `BehaviorBase`: 
[JDK-8250807](https://bugs.openjdk.java.net/browse/JDK-8250807). Due to this 
issue,
KeyMappings from child `InputMap` do not get removed. So the keys 
CTRL+SHIFT+HOME and CTRL+SHIFT+END will still not
work with ComboBox editor. 5. Updated ComboBoxTest for additional keys. 6. 
Keeping the tests added for ListView, as
they seem reasonable and not present already.

Change is very specific to ComboBox editor, so it should not affect any other 
tests.

-

PR: https://git.openjdk.java.net/jfx/pull/172

Re: RFR: 8209788: Left/Right/Ctrl+A keys not working in editor of ComboBox if popup showing [v3]

2020-07-30 Thread Ambarish Rapte 
> The issue occurs because the key events are consumed by the `ListView` in 
> `Popup`, which displays the items.
> This is a regression of 
> [JDK-8077916](https://bugs.openjdk.java.net/browse/JDK-8077916). This change 
> aadded several
> `KeyMapping`s for focus traversals to `ListView`, which consume the `Left`, 
> `Right` and `Ctrl+A` key events.
> Fix:
> 1. Remove the four focus traversal arrow `KeyMapping`s from 
> `ListViewBehavior`.
> 2. Add the `Ctrl + A` `KeyMapping` to `ListViewBehavior` only if the 
> `ListView`'s selection mode is set to
> `SelectionMode.MULTIPLE`.  `ComboBox` uses the `ListView` with 
> `SelectionMode.SINGLE` mode.
> Change unrelated to fix:
> `ComboBoxListViewBehavior` adds `KeyMapping` for `Up` and `Down` keys, which 
> are not invoked when the `ComboBox` popup
> is showing. When the popup is shown, the Up and Down key events are handled 
> by the `ListView` and the `KeyMapping` code
> from `ComboBoxListViewBehavior` does not get executed. These KeyMapping are 
> removed. However this change is not needed
> for the fix. But this seems to be dead code.   Verification:
> Added new unit tests to verify the change.
> Also verified that the behavior ListView behaves same before and after this 
> change.

Ambarish Rapte has updated the pull request incrementally with two additional 
commits since the last revision:

 - revert unintended line deletion
 - changes to address to review

-

Changes:
  - all: https://git.openjdk.java.net/jfx/pull/172/files
  - new: https://git.openjdk.java.net/jfx/pull/172/files/f0c94d60..7f528241

Webrevs:
 - full: https://webrevs.openjdk.java.net/jfx/172/webrev.02
 - incr: https://webrevs.openjdk.java.net/jfx/172/webrev.01-02

  Stats: 177 lines in 6 files changed: 103 ins; 44 del; 30 mod
  Patch: https://git.openjdk.java.net/jfx/pull/172.diff
  Fetch: git fetch https://git.openjdk.java.net/jfx pull/172/head:pull/172

PR: https://git.openjdk.java.net/jfx/pull/172