Re: [openstack-dev] How to add feature to diskimage-builder
Excerpts from George Shuklin's message of 2015-12-29 09:16:52 -0800: > Hello. > > I'm trying add a small feature to one of the elements in > diskimage-builder (https://github.com/openstack/diskimage-builder/pull/10/) > > I have experience with gerrit and openstack bugfix workflow, but I have > no idea how to add small enhancements. > > Dev guide says I need to add blueprint (how?) and follow the guides for > the project. But I can't find any dev guides specific for diskimage-builder. > > What should I do? (Or may be I can just submit changes for review > without noting blueprint/spec?). > If a feature can be completed with a small amount of patches, we don't need a spec IMO. Specs are more about building community consensus around _big_ changes that may affect many users or have large cross-cutting ripple effects in the code. Looking at your patch, I'd expect that with some adjustments via the normal review process it would be accepted as-is. __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] How to add feature to diskimage-builder
hi here's some links may helps [1] is the general development guide for OpenStack contributors. It may provide some useful guide. [2] is the the place you register blueprint. Hope you play well. Thanks Eli [1]https://wiki.openstack.org/wiki/How_To_Contribute#Feature_development [2]https://blueprints.launchpad.net/diskimage-builder On 2015年12月30日 01:16, George Shuklin wrote: Hello. I'm trying add a small feature to one of the elements in diskimage-builder (https://github.com/openstack/diskimage-builder/pull/10/) I have experience with gerrit and openstack bugfix workflow, but I have no idea how to add small enhancements. Dev guide says I need to add blueprint (how?) and follow the guides for the project. But I can't find any dev guides specific for diskimage-builder. What should I do? (Or may be I can just submit changes for review without noting blueprint/spec?). __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev -- BR, Eli(Li Yong)Qiao <>__ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] How to add feature to diskimage-builder
On 2015-12-29 19:16:52 +0200 (+0200), George Shuklin wrote: > I'm trying add a small feature to one of the elements in diskimage-builder > (https://github.com/openstack/diskimage-builder/pull/10/) > > I have experience with gerrit and openstack bugfix workflow, but I have no > idea how to add small enhancements. > > Dev guide says I need to add blueprint (how?) and follow the guides for the > project. But I can't find any dev guides specific for diskimage-builder. > > What should I do? (Or may be I can just submit changes for review without > noting blueprint/spec?). I'm not a core reviewer for DIB, but for a small modification I doubt they expect you to create a Launchpad blueprint or an associated specification. I would just start by pushing the proposed addition into Gerrit and see what else they request after that. -- Jeremy Stanley __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
[openstack-dev] How to add feature to diskimage-builder
Hello. I'm trying add a small feature to one of the elements in diskimage-builder (https://github.com/openstack/diskimage-builder/pull/10/) I have experience with gerrit and openstack bugfix workflow, but I have no idea how to add small enhancements. Dev guide says I need to add blueprint (how?) and follow the guides for the project. But I can't find any dev guides specific for diskimage-builder. What should I do? (Or may be I can just submit changes for review without noting blueprint/spec?). __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
