[Bug 1785495] Review Request: python-pwntools - A CTF framework and exploit development library
https://bugzilla.redhat.com/show_bug.cgi?id=1785495 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2020-03-16 20:38:07 --- Comment #16 from Fedora Update System --- python-pwntools-4.0.0-0.1.b0.fc32 has been pushed to the Fedora 32 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1785495] Review Request: python-pwntools - A CTF framework and exploit development library
https://bugzilla.redhat.com/show_bug.cgi?id=1785495 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #15 from Fedora Update System --- python-pwntools-4.0.0-0.1.b0.fc32 has been pushed to the Fedora 32 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-70231bc5e4 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1785495] Review Request: python-pwntools - A CTF framework and exploit development library
https://bugzilla.redhat.com/show_bug.cgi?id=1785495 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #14 from Fedora Update System --- FEDORA-2020-70231bc5e4 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-70231bc5e4 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1785495] Review Request: python-pwntools - A CTF framework and exploit development library
https://bugzilla.redhat.com/show_bug.cgi?id=1785495 Robert-André Mauchin changed: What|Removed |Added Status|NEW |POST Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review+ --- Comment #13 from Robert-André Mauchin --- Package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1785495] Review Request: python-pwntools - A CTF framework and exploit development library
https://bugzilla.redhat.com/show_bug.cgi?id=1785495 --- Comment #12 from W. Michael Petullo --- Upstream bug: https://github.com/Gallopsled/pwntools/issues/1404 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1785495] Review Request: python-pwntools - A CTF framework and exploit development library
https://bugzilla.redhat.com/show_bug.cgi?id=1785495 --- Comment #11 from W. Michael Petullo --- Spec URL: https://www.flyn.org/SRPMS/python-pwntools.spec SRPM URL: https://www.flyn.org/SRPMS/python-pwntools-4.0.0-0.1.b0.fc31.src.rpm Description: - Fix typos in URL and Source0 I separately updated the python-intervaltree in Rawhide. See https://koji.fedoraproject.org/koji/taskinfo?taskID=40254996. I will bring up the Python 2 shebang issues with the upstream developers. The package has a name that exists because I am revitalizing an orphaned package. I will bring up the issues highlighted by rpmlint with the upstream developers. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1785495] Review Request: python-pwntools - A CTF framework and exploit development library
https://bugzilla.redhat.com/show_bug.cgi?id=1785495
Robert-André Mauchin changed:
What|Removed |Added
CC||zebo...@gmail.com
--- Comment #10 from Robert-André Mauchin ---
- Typo in URL and Source0: use % not $ for RPM variables:
URL:https://github.com/Gallopsled/%{srcname}/
Source0:
https://github.com/Gallopsled/%{srcname}/archive/%{version}beta0.tar.gz
- Package is not installable:
DEBUG util.py:582: Error:
DEBUG util.py:582: Problem: conflicting requests
DEBUG util.py:582:- nothing provides python3.8dist(intervaltree) >= 3
needed by python3-pwntools-4.0.0-0.1.b0.fc32.noarch
Seems you're the maintainer of intervaltree, update it to 3?
- there's a weird list of files with a Py2 shebang
python3-pwntools.noarch: E: non-executable-script
/usr/lib/python3.8/site-packages/pwnlib/commandline/__init__.py 644
/usr/bin/env python2
python3-pwntools.noarch: E: non-executable-script
/usr/lib/python3.8/site-packages/pwnlib/commandline/asm.py 644 /usr/bin/env
python2
python3-pwntools.noarch: E: non-executable-script
/usr/lib/python3.8/site-packages/pwnlib/commandline/checksec.py 644
/usr/bin/env python2
python3-pwntools.noarch: E: non-executable-script
/usr/lib/python3.8/site-packages/pwnlib/commandline/constgrep.py 644
/usr/bin/env python2
python3-pwntools.noarch: E: non-executable-script
/usr/lib/python3.8/site-packages/pwnlib/commandline/cyclic.py 644 /usr/bin/env
python2
python3-pwntools.noarch: E: non-executable-script
/usr/lib/python3.8/site-packages/pwnlib/commandline/debug.py 644 /usr/bin/env
python2
python3-pwntools.noarch: E: non-executable-script
/usr/lib/python3.8/site-packages/pwnlib/commandline/disablenx.py 644
/usr/bin/env python2
python3-pwntools.noarch: E: non-executable-script
/usr/lib/python3.8/site-packages/pwnlib/commandline/disasm.py 644 /usr/bin/env
python2
python3-pwntools.noarch: E: non-executable-script
/usr/lib/python3.8/site-packages/pwnlib/commandline/elfdiff.py 644 /usr/bin/env
python2
python3-pwntools.noarch: E: non-executable-script
/usr/lib/python3.8/site-packages/pwnlib/commandline/elfpatch.py 644
/usr/bin/env python2
python3-pwntools.noarch: E: non-executable-script
/usr/lib/python3.8/site-packages/pwnlib/commandline/hex.py 644 /usr/bin/env
python2
python3-pwntools.noarch: E: non-executable-script
/usr/lib/python3.8/site-packages/pwnlib/commandline/phd.py 644 /usr/bin/env
python2
python3-pwntools.noarch: E: non-executable-script
/usr/lib/python3.8/site-packages/pwnlib/commandline/shellcraft.py 644
/usr/bin/env python2
python3-pwntools.noarch: E: non-executable-script
/usr/lib/python3.8/site-packages/pwnlib/commandline/template.py 644
/usr/bin/env python2
python3-pwntools.noarch: E: non-executable-script
/usr/lib/python3.8/site-packages/pwnlib/commandline/unhex.py 644 /usr/bin/env
python2
python3-pwntools.noarch: E: non-executable-script
/usr/lib/python3.8/site-packages/pwnlib/commandline/update.py 644 /usr/bin/env
python
python3-pwntools.noarch: E: non-executable-script
/usr/lib/python3.8/site-packages/pwnlib/context/__init__.py 644 /usr/bin/env
python2
python3-pwntools.noarch: E: non-executable-script
/usr/lib/python3.8/site-packages/pwnlib/term/readline.py 644 /usr/bin/env
python2
python3-pwntools.noarch: E: non-executable-script
/usr/lib/python3.8/site-packages/pwnlib/timeout.py 644 /usr/bin/env python2
python3-pwntools.noarch: E: non-executable-script
/usr/lib/python3.8/site-packages/pwnlib/tubes/buffer.py 644 /usr/bin/env
python2
python3-pwntools.noarch: E: non-executable-script
/usr/lib/python3.8/site-packages/pwnlib/util/sh_string.py 644 /usr/bin/env
python2
python3-pwntools.noarch: E: non-executable-script
/usr/lib/python3.8/site-packages/pwnlib/elf/datatypes.py 644 /usr/bin/env
python
python3-pwntools.noarch: E: non-executable-script
/usr/lib/python3.8/site-packages/pwnlib/encoders/i386/xor.py 644 /usr/bin/env
python2
python3-pwntools.noarch: E: non-executable-script
/usr/lib/python3.8/site-packages/pwnlib/encoders/mips/xor.py 644 /usr/bin/env
python2
See with upstream if the python2 is what is intended.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Package installs properly.
Note: Installation errors (see attachment)
See: https://docs.fedoraproject.org/en-US/packaging-guidelines/
- Package does not use a name that already exists.
Note: A package with this name already exists. Please check
https://src.fedoraproject.org/rpms/python-pwntools
See: https://docs.fedoraproject.org/en-US/packaging-
guidelines/Naming/#_conflicting_package_names
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in th
[Bug 1785495] Review Request: python-pwntools - A CTF framework and exploit development library
https://bugzilla.redhat.com/show_bug.cgi?id=1785495 --- Comment #9 from W. Michael Petullo --- Updated URL. I had updated the Source0 before. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1785495] Review Request: python-pwntools - A CTF framework and exploit development library
https://bugzilla.redhat.com/show_bug.cgi?id=1785495 --- Comment #8 from Fabian Affolter --- It's hard to keep track if the release is not bumped. I saw the same release tag and that the URL still points to PyPI but the description says otherwise. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1785495] Review Request: python-pwntools - A CTF framework and exploit development library
https://bugzilla.redhat.com/show_bug.cgi?id=1785495 --- Comment #7 from W. Michael Petullo --- The spec file and the SRPM have indeed changed at the upload location. I did not increment the release tag, since there has not yet been an approved release of this version. Should I have? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1785495] Review Request: python-pwntools - A CTF framework and exploit development library
https://bugzilla.redhat.com/show_bug.cgi?id=1785495 --- Comment #6 from Fabian Affolter --- The spec file and the SRPM were not updated at the upload location. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1785495] Review Request: python-pwntools - A CTF framework and exploit development library
https://bugzilla.redhat.com/show_bug.cgi?id=1785495 --- Comment #5 from W. Michael Petullo --- Spec URL: https://www.flyn.org/SRPMS/python-pwntools.spec SRPM URL: https://www.flyn.org/SRPMS/python-pwntools-4.0.0-0.1.b0.fc31.src.rpm Description: - Use upstream URL - Allow dependency generator to pick Python dependencies - Require binutils -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1785495] Review Request: python-pwntools - A CTF framework and exploit development library
https://bugzilla.redhat.com/show_bug.cgi?id=1785495
Fabian Affolter changed:
What|Removed |Added
CC||m...@fabian-affolter.ch
--- Comment #4 from Fabian Affolter ---
Just some comments:
- URL:https://pypi.python.org/pypi/%{srcname}
I suggest to use the location of the upstream
(https://github.com/Gallopsled/pwntools) instead of PyPI.
- Isn't the dependency generator picking-up the Requires:?
- According the pwntools documentation is binutils
(https://docs.pwntools.com/en/stable/install/binutils.html) also a requirement.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1785495] Review Request: python-pwntools - A CTF framework and exploit development library
https://bugzilla.redhat.com/show_bug.cgi?id=1785495 W. Michael Petullo changed: What|Removed |Added CC||upstream-release-monitoring ||@fedoraproject.org --- Comment #3 from W. Michael Petullo --- *** Bug 1697445 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1785495] Review Request: python-pwntools - A CTF framework and exploit development library
https://bugzilla.redhat.com/show_bug.cgi?id=1785495
--- Comment #2 from W. Michael Petullo ---
Spec URL: https://www.flyn.org/SRPMS/python-pwntools.spec
SRPM URL: https://www.flyn.org/SRPMS/python-pwntools-4.0.0-0.1.b0.fc31.src.rpm
Description:
- Adjust package name to use beta0 rather than b0
- BuildRequires python3-setuptools
- Update sphinx comment
- Escape macros in comments
- Use %{python3_version}
- Add trailing slashes to directory paths
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1785495] Review Request: python-pwntools - A CTF framework and exploit development library
https://bugzilla.redhat.com/show_bug.cgi?id=1785495
Miro Hrončok changed:
What|Removed |Added
CC||mhron...@redhat.com
Doc Type|--- |If docs needed, set a value
--- Comment #1 from Miro Hrončok ---
Spec sanity:
> Release:0.1beta%{?dist}
This doesn't correspond with
https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/#_more_complex_versioning
What about: 0.1.b0? Or even 4.0.0~b0 in version?
> https://files.pythonhosted.org/packages/source/p/%{srcname}/%{srcname}-%{version}beta0.tar.gz
Upstream calls this b0. The URL with beta0 seems not to work. Maybe us the
%{pypi_source} macro?
> BuildRequires: python3-devel
Add BR for python3-setuptools as that's what the upstream is using to build the
package, but you only get it transitively. See the note in python3.spec if you
want to know more (starts with '# This is not "API"').
> # Waiting on pwntools to support sphinx 1.7.
We no longer have 1.7, but 2.2. This comment is outdated.
> # %package doc
> # ...
Macros in comment.
> %{python3_sitelib}/%{srcname}-%{version}b0-py?.?.egg-info
This will break with Python 3.10. Use %{python3_version} instead of ?.?.
> %{python3_sitelib}/%{srcname}-%{version}b0-py?.?.egg-info
> %{python3_sitelib}/pwn
> %{python3_sitelib}/pwnlib
Add trailing slashes to directories to ensure there are always directories.
egg-info has a bad habbit of changing from a directory to a file and breaking
the package.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
