Re: More Makefile.PL patches

2005-03-27 Thread Luke Palmer
Rafael Garcia-Suarez writes:
> This one fixes "make test", by forcing the fix of "test" target of the
> generated Makefile. I'd rather have Ingy reviewing it or something,
> because AFAICT it's his territory -- dark makemaker places where black
> magic hides behind obscure curtains. ("make install" still works and
> still installs everything in its right place)

Thanks, applied.

Luke

> 
> Index: inc/Module/Install/Pugs.pm
> ===
> --- inc/Module/Install/Pugs.pm(revision 1236)
> +++ inc/Module/Install/Pugs.pm(working copy)
> @@ -22,8 +22,7 @@
>  
>  $self->WriteAll(@_);
>  
> -$self->pugs_fix_makefile
> -  if $install_version eq '6';
> +$self->pugs_fix_makefile;
>  }
>  
>  sub set_makefile_macros {
> 
> 
> This one is just a nit : it silences "make test", that complains
> about t/*.t not existing.
> 
> Index: Makefile.PL
> ===
> --- Makefile.PL   (revision 1236)
> +++ Makefile.PL   (working copy)
> @@ -27,7 +27,7 @@
>   } glob("ext/*")
>  );
>  makemaker_args  (
> -test => { TESTS => join ' ', "t/*.t", "t/*/*.t", "t/*/*/*.t" },
> +test => { TESTS => join ' ', "t/*/*.t", "t/*/*/*.t" },
>  MAN1PODS => {},
>  );
>  clean_files (map fixpaths($_),
> 


More Makefile.PL patches

2005-03-27 Thread Rafael Garcia-Suarez
This one fixes "make test", by forcing the fix of "test" target of the
generated Makefile. I'd rather have Ingy reviewing it or something,
because AFAICT it's his territory -- dark makemaker places where black
magic hides behind obscure curtains. ("make install" still works and
still installs everything in its right place)

Index: inc/Module/Install/Pugs.pm
===
--- inc/Module/Install/Pugs.pm  (revision 1236)
+++ inc/Module/Install/Pugs.pm  (working copy)
@@ -22,8 +22,7 @@
 
 $self->WriteAll(@_);
 
-$self->pugs_fix_makefile
-  if $install_version eq '6';
+$self->pugs_fix_makefile;
 }
 
 sub set_makefile_macros {


This one is just a nit : it silences "make test", that complains
about t/*.t not existing.

Index: Makefile.PL
===
--- Makefile.PL (revision 1236)
+++ Makefile.PL (working copy)
@@ -27,7 +27,7 @@
  } glob("ext/*")
 );
 makemaker_args  (
-test => { TESTS => join ' ', "t/*.t", "t/*/*.t", "t/*/*/*.t" },
+test => { TESTS => join ' ', "t/*/*.t", "t/*/*/*.t" },
 MAN1PODS => {},
 );
 clean_files (map fixpaths($_),