[COMMITTERS] pgsql: Improve discussion of setting server parameters.
Improve discussion of setting server parameters. Rewrite description of "include_if_exists" for clarity. Add subsection headings to make the structure of the page a little clearer. A couple other minor improvements too. Josh Kupershmidt and Tom Lane Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/817ec1bc8227eb0d7f3bbb5725ea1de0ec73c1ea Modified Files -- doc/src/sgml/config.sgml | 328 - 1 files changed, 175 insertions(+), 153 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Revert catalog bump; was post-beta1, and unnecessary.
Revert catalog bump; was post-beta1, and unnecessary. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/ee24de40018fe5b6f8dc015e56e41c7889622c33 Modified Files -- src/include/catalog/catversion.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Update comment for 'name' data type to say 63 "bytes".
Update comment for 'name' data type to say 63 "bytes". Catalog version bump so everyone has the same comment for beta1. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/d2fe836cd28dbaff86f63b77da8d7ea0efa9a9c3 Modified Files -- src/include/catalog/catversion.h |2 +- src/include/catalog/pg_type.h|2 +- 2 files changed, 2 insertions(+), 2 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Stamp 9.2beta1.
Stamp 9.2beta1. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/f70fa835e08eee4cb2dc0f72d66cf633089c37e8 Modified Files -- configure | 18 +- configure.in |2 +- doc/bug.template |2 +- src/include/pg_config.h.win32 |6 +++--- 4 files changed, 14 insertions(+), 14 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Tweak documentation wording to avoid "pdfendlink" failure.
Tweak documentation wording to avoid "pdfendlink" failure. HEAD documentation was failing to build as US PDF for me, because a link to "CREATE CAST" was getting split across pages. Adjust wording to remove this rather gratuitous cross-reference. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/e3cdc1532caaec4652b41d1114c71aa3872a8f6f Modified Files -- doc/src/sgml/catalogs.sgml |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
Re: [COMMITTERS] pgsql: Make WaitLatch's WL_POSTMASTER_DEATH result trustworthy; simplif
Peter Geoghegan writes: > On 10 May 2012 19:35, Tom Lane wrote: >> Remove weasel wording about falsely-set result bits from >> WaitLatch's API contract. > Aren't those weasel words still applicable to the case where sock != > PGINVALID_SOCKET ? I don't think so. WaitLatch is honestly reporting the result of select or poll; code that doesn't work with it wouldn't work with the native OS facilities either. The only case that is really a problem here is where we make the logical leap from "socket possibly readable" to "postmaster is dead". I think what that Linux man page is advising is that you not assume that a blocking-mode read() won't block, which AFAIK is something we don't do; we always use non-block mode on sockets we don't wish to block on. regards, tom lane -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Temporarily revert stats collector latch changes so we can ship
Temporarily revert stats collector latch changes so we can ship beta1. This patch reverts commit 49340037ee3ab46cb24144a86705e35f272c24d5 and some follow-on tweaking in pgstat.c. While the basic scheme of latch-ifying the stats collector seems sound enough, it's failing on most Windows buildfarm members for unknown reasons, and there's no time left to debug that before 9.2beta1. Better to ship a beta version without this improvement. I hope to re-revert this once beta1 is out, though. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/cb2f2873d6b81ad7f0a9733ba738bfac0746fb7b Modified Files -- src/backend/postmaster/pgstat.c | 185 -- 1 files changed, 117 insertions(+), 68 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
Re: [COMMITTERS] pgsql: Make WaitLatch's WL_POSTMASTER_DEATH result trustworthy; simplif
On 10 May 2012 19:35, Tom Lane wrote: > Remove weasel wording about falsely-set result bits from > WaitLatch's API contract. Aren't those weasel words still applicable to the case where sock != PGINVALID_SOCKET ? -- Peter Geoghegan http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Merge visibility map crash-safety into index-only scan release n
Merge visibility map crash-safety into index-only scan release note item, per Robert Haas. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/5428ff4af84e488c7f0629108cd12ff51125e09f Modified Files -- doc/src/sgml/release-9.2.sgml | 16 +++- 1 files changed, 3 insertions(+), 13 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Make WaitLatch's WL_POSTMASTER_DEATH result trustworthy; simplif
Make WaitLatch's WL_POSTMASTER_DEATH result trustworthy; simplify callers. Per a suggestion from Peter Geoghegan, make WaitLatch responsible for verifying that the WL_POSTMASTER_DEATH bit it returns is truthful (by testing PostmasterIsAlive). Then simplify its callers, who no longer need to do that for themselves. Remove weasel wording about falsely-set result bits from WaitLatch's API contract. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/f40022f1adaeff85b01d98fea38cf5aa16814aa7 Modified Files -- src/backend/port/unix_latch.c | 35 ++-- src/backend/port/win32_latch.c| 12 +- src/backend/postmaster/autovacuum.c |9 --- src/backend/postmaster/bgwriter.c |7 + src/backend/postmaster/checkpointer.c |7 + src/backend/postmaster/pgstat.c |7 + src/backend/postmaster/walwriter.c|7 + 7 files changed, 47 insertions(+), 37 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
Re: [COMMITTERS] pgsql: Remove unportable use of SGML character-code entity.
Excerpts from Bruce Momjian's message of jue may 10 13:52:22 -0400 2012: > On Thu, May 10, 2012 at 04:22:40PM +, Tom Lane wrote: > > Remove unportable use of SGML character-code entity. > > > > It'd be nice to be able to spell Jan Urbanski's name with the correct > > accent marks, but we haven't yet found a way that works in everybody's > > docs toolchain. This way definitely doesn't. > > Accent-N is not available in Latin1, so we are stuck. We could do > tilde-N, but that seems wrong. The good news is that this is the only > name I couldn't do. Actually Pavel Stehule's last name has some funny accent too (it's Stěhule). I don't think you can do that in Latin1. -- Álvaro Herrera The PostgreSQL Company - Command Prompt, Inc. PostgreSQL Replication, Consulting, Custom Development, 24x7 support -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Properly capitalize the TimeZone parameter
Properly capitalize the TimeZone parameter For better or worse, it is implemented in mixed case, so document it as such, at least in the main listing, like DateStyle. Josh Kupershmidt Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/586d356bc5af1aa61f965f6ba1cbeb1533ec8c99 Modified Files -- doc/src/sgml/config.sgml |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
Re: [COMMITTERS] pgsql: Remove unportable use of SGML character-code entity.
On Thu, May 10, 2012 at 04:22:40PM +, Tom Lane wrote: > Remove unportable use of SGML character-code entity. > > It'd be nice to be able to spell Jan Urbanski's name with the correct > accent marks, but we haven't yet found a way that works in everybody's > docs toolchain. This way definitely doesn't. Accent-N is not available in Latin1, so we are stuck. We could do tilde-N, but that seems wrong. The good news is that this is the only name I couldn't do. We might try Asian characters someday if we had a UTF toolchain. -- Bruce Momjian http://momjian.us EnterpriseDB http://enterprisedb.com + It's impossible for everything to be true. + -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Add comma after "Previously" as suggested by Josh Kupershmidt
Add comma after "Previously" as suggested by Josh Kupershmidt Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/45f6fb2713feb21bc24fa907bad575008fd680ef Modified Files -- doc/src/sgml/release-9.2.sgml | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: PL/Python: Update incorrect comment
PL/Python: Update incorrect comment Jan Urbański Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/1540d3bf4d405278533377ba81dbbf1c857eaec0 Modified Files -- src/pl/plpython/plpy_resultobject.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: PL/Python: Fix slicing support for result objects for Python 3
PL/Python: Fix slicing support for result objects for Python 3 The old way of implementing slicing support by implementing PySequenceMethods.sq_slice no longer works in Python 3. You now have to implement PyMappingMethods.mp_subscript. Do this by simply proxying the call to the wrapped list of result dictionaries. Consolidate some of the subscripting regression tests. Jan Urbański Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/a97207b6908f1d4a7d19b37b818367bb0171039f Modified Files -- src/pl/plpython/expected/plpython_spi.out | 75 + src/pl/plpython/plpy_resultobject.c | 26 ++- src/pl/plpython/sql/plpython_spi.sql | 51 ++-- 3 files changed, 116 insertions(+), 36 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix Windows implementation of PGSemaphoreLock.
Fix Windows implementation of PGSemaphoreLock. The original coding failed to reset ImmediateInterruptOK before returning, which would potentially allow a subsequent query-cancel interrupt to be accepted at an unsafe point. This is a really nasty bug since it's so hard to predict the consequences, but they could be unpleasant. Also, ensure that signal handlers are serviced before this function returns, even if the semaphore is already set. This should make the behavior more like Unix. Back-patch to all supported versions. Branch -- REL8_4_STABLE Details --- http://git.postgresql.org/pg/commitdiff/de48dbade3930522dd33446b84dcc5407bec7f72 Modified Files -- src/backend/port/win32_sema.c | 20 1 files changed, 12 insertions(+), 8 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix Windows implementation of PGSemaphoreLock.
Fix Windows implementation of PGSemaphoreLock. The original coding failed to reset ImmediateInterruptOK before returning, which would potentially allow a subsequent query-cancel interrupt to be accepted at an unsafe point. This is a really nasty bug since it's so hard to predict the consequences, but they could be unpleasant. Also, ensure that signal handlers are serviced before this function returns, even if the semaphore is already set. This should make the behavior more like Unix. Back-patch to all supported versions. Branch -- REL8_3_STABLE Details --- http://git.postgresql.org/pg/commitdiff/fcc0ba313b41437b9efc01438f133feb484b2e93 Modified Files -- src/backend/port/win32_sema.c | 20 1 files changed, 12 insertions(+), 8 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix Windows implementation of PGSemaphoreLock.
Fix Windows implementation of PGSemaphoreLock. The original coding failed to reset ImmediateInterruptOK before returning, which would potentially allow a subsequent query-cancel interrupt to be accepted at an unsafe point. This is a really nasty bug since it's so hard to predict the consequences, but they could be unpleasant. Also, ensure that signal handlers are serviced before this function returns, even if the semaphore is already set. This should make the behavior more like Unix. Back-patch to all supported versions. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/ada8fa08fc6cf5f199b6df935b4d0a730aaa4fec Modified Files -- src/backend/port/win32_sema.c | 20 1 files changed, 12 insertions(+), 8 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix Windows implementation of PGSemaphoreLock.
Fix Windows implementation of PGSemaphoreLock. The original coding failed to reset ImmediateInterruptOK before returning, which would potentially allow a subsequent query-cancel interrupt to be accepted at an unsafe point. This is a really nasty bug since it's so hard to predict the consequences, but they could be unpleasant. Also, ensure that signal handlers are serviced before this function returns, even if the semaphore is already set. This should make the behavior more like Unix. Back-patch to all supported versions. Branch -- REL9_0_STABLE Details --- http://git.postgresql.org/pg/commitdiff/b149d1f90e7d42f719babc0c26addaeffa18df8c Modified Files -- src/backend/port/win32_sema.c | 20 1 files changed, 12 insertions(+), 8 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix Windows implementation of PGSemaphoreLock.
Fix Windows implementation of PGSemaphoreLock. The original coding failed to reset ImmediateInterruptOK before returning, which would potentially allow a subsequent query-cancel interrupt to be accepted at an unsafe point. This is a really nasty bug since it's so hard to predict the consequences, but they could be unpleasant. Also, ensure that signal handlers are serviced before this function returns, even if the semaphore is already set. This should make the behavior more like Unix. Back-patch to all supported versions. Branch -- REL9_1_STABLE Details --- http://git.postgresql.org/pg/commitdiff/1b48f6af315e9db89aaf43e8c8c9de903294fbdf Modified Files -- src/backend/port/win32_sema.c | 20 1 files changed, 12 insertions(+), 8 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: 9.2 release note updates from Peter Geoghegan
9.2 release note updates from Peter Geoghegan Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/ffda90f3afe3f4db10127d2b853dfe4230720873 Modified Files -- doc/src/sgml/release-9.2.sgml | 47 + 1 files changed, 24 insertions(+), 23 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Improve Windows implementation of WaitLatch/WaitLatchOrSocket.
Improve Windows implementation of WaitLatch/WaitLatchOrSocket. Ensure that signal handlers are serviced before this function returns. This should make the behavior more like Unix. Also, add some more error checking, and make some other cosmetic improvements. No back-patch since it's not clear whether this is fixing any live bug that would affect 9.1. I'm more concerned about 9.2 anyway given our considerable recent expansions in the usage of WaitLatch. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/8ebc908c575b3378c9d4096412d16d91d107311c Modified Files -- src/backend/port/win32_latch.c | 60 ++-- 1 files changed, 39 insertions(+), 21 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: New 9.2 SSL parameters are GUC, not libpq, per Magnus's observat
New 9.2 SSL parameters are GUC, not libpq, per Magnus's observation. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/53216e3992665eda1570650f4047efa4202e7173 Modified Files -- doc/src/sgml/release-9.2.sgml |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Add 9.2 release note suggestions from Heikki,
Add 9.2 release note suggestions from Heikki, Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/deb2c6e381e26b4e3c042b16990dd3821f6757b3 Modified Files -- doc/src/sgml/release-9.2.sgml | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Whitespace cleanup
Whitespace cleanup Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/d9bb75dd37ae1642392b8638c99bfeb9f9890c0a Modified Files -- doc/src/sgml/pgtesttiming.sgml | 190 +++- 1 files changed, 92 insertions(+), 98 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Python 2.2 is no longer supported
Python 2.2 is no longer supported It was already on its last legs, and it turns out that it was accidentally broken in commit 89e850e6fda9e4e441712012abe971fe938d595a and no one cared. So remove the rest the support for it and update the documentation to indicate that Python 2.3 is now required. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/1d158d7f9841d7993f7b5990f311e3595db7960b Modified Files -- doc/src/sgml/installation.sgml |2 +- src/pl/plpython/expected/README |3 --- src/pl/plpython/plpython.h |7 --- 3 files changed, 1 insertions(+), 11 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: 9.2 release note adjustments from Robert Haas.
9.2 release note adjustments from Robert Haas. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/1908a6796a2e61e78c9a31807076746c34ea6a15 Modified Files -- doc/src/sgml/release-9.2.sgml | 33 + 1 files changed, 5 insertions(+), 28 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Update entitiy escapes docs; must be Latin1.
Update entitiy escapes docs; must be Latin1. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/77bfdb11d09a3adef1f9310201e1b2fe38ee47bd Modified Files -- doc/src/sgml/release.sgml |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Another doc fix for HTML entities.
Another doc fix for HTML entities. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/d413efe9e14357577a3b7537784eb856ab6525ba Modified Files -- doc/src/sgml/release.sgml |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Remove URL that suggested numeric HTML entities.
Remove URL that suggested numeric HTML entities. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/38cd7cc0bcd6fcbfa8942e28f6aee84ab9fbb651 Modified Files -- doc/src/sgml/release.sgml |1 - 1 files changed, 0 insertions(+), 1 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Remove unportable use of SGML character-code entity.
Remove unportable use of SGML character-code entity. It'd be nice to be able to spell Jan Urbanski's name with the correct accent marks, but we haven't yet found a way that works in everybody's docs toolchain. This way definitely doesn't. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/47ce4c36a721b621b6b0ddcba9d02ccd0af5b3aa Modified Files -- doc/src/sgml/release-9.2.sgml |2 +- doc/src/sgml/release.sgml |6 -- 2 files changed, 5 insertions(+), 3 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Release notes adjustments from Erik Rijkers
Release notes adjustments from Erik Rijkers Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/1ee90397f498141abf0c77b4d3c9ea26babc072d Modified Files -- doc/src/sgml/release-9.2.sgml | 13 ++--- 1 files changed, 10 insertions(+), 3 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
Re: [COMMITTERS] pgsql: Improve tests for postmaster death in auxiliary processes.
Peter Geoghegan writes: > On 10 May 2012 05:55, Tom Lane wrote: >> I had already removed the unconditional >> PostmasterIsAlive calls in bgwriter and pgstat in previous patches, but >> forgot that WL_POSTMASTER_DEATH is supposed to be treated as untrustworthy >> (per comment in unix_latch.c); so adjust those two cases to match. > I'm not sure why we're pushing the responsibility to call > PostmasterIsAlive() onto latch clients. Why not just do it within > WaitLatchOrSocket just as the WL_POSTMASTER_DEATH bit is set? It's not > as if someone could conceivably care that the Postmaster might have > died, but not enough to want to be sure. Hmm ... yeah, that would simplify the API if we didn't have to have the caveat about the bits being untrustworthy. The only objection I can see is that this might represent a useless PostmasterIsAlive call for those callers that aren't inspecting the result bit. However, at this point we've more or less decided that those callers aren't performance-critical anyway; anyone who thinks they are should be rearranging their code to remove the separate PostmasterIsAlive calls. So, yeah, seems like a good idea. Any objections out there? regards, tom lane -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
Re: [COMMITTERS] pgsql: Improve tests for postmaster death in auxiliary processes.
On 10 May 2012 05:55, Tom Lane wrote: > In checkpointer and walwriter, avoid calling PostmasterIsAlive unless > WaitLatch has reported WL_POSTMASTER_DEATH. This saves a kernel call per > iteration of the process's outer loop, which is not all that much, but a > cycle shaved is a cycle earned. I had already removed the unconditional > PostmasterIsAlive calls in bgwriter and pgstat in previous patches, but > forgot that WL_POSTMASTER_DEATH is supposed to be treated as untrustworthy > (per comment in unix_latch.c); so adjust those two cases to match. I'm not sure why we're pushing the responsibility to call PostmasterIsAlive() onto latch clients. Why not just do it within WaitLatchOrSocket just as the WL_POSTMASTER_DEATH bit is set? It's not as if someone could conceivably care that the Postmaster might have died, but not enough to want to be sure. -- Peter Geoghegan http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Improve two 9.2 release note items.
Improve two 9.2 release note items. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/5d258fe90cbd6a0efd68e057697f85a1f961c42d Modified Files -- doc/src/sgml/release-9.2.sgml |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix a couple of typos in 9.2 release notes.
Fix a couple of typos in 9.2 release notes. Thom Brown Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/386bb92f6348bf8a6f5ebd39122161e190e464c2 Modified Files -- doc/src/sgml/release-9.2.sgml |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Copy-editing 9.2 release notes.
Copy-editing 9.2 release notes. Fix a couple of typos, add missing filename tags, and add a link to the doc section on timezone guc. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/3e8e692bbc829f48c8c1accbeed9284735f9a88c Modified Files -- doc/src/sgml/release-9.2.sgml | 15 --- 1 files changed, 8 insertions(+), 7 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Only attempt to show collations on servers >= 9.1.
Only attempt to show collations on servers >= 9.1. Show a proper error message instead of a SQL error. Josh Kupershmidt Branch -- REL9_1_STABLE Details --- http://git.postgresql.org/pg/commitdiff/71ca53608de1763c0d82bf463580a30f634eba56 Modified Files -- src/bin/psql/describe.c |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Only attempt to show collations on servers >= 9.1.
Only attempt to show collations on servers >= 9.1. Show a proper error message instead of a SQL error. Josh Kupershmidt Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/f33c5d471ccdf33ac413d49b32a898eeab13538b Modified Files -- src/bin/psql/describe.c |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
