replication slots only need user with replication for creation
Hi, Looking at privileges that a user would need now a days to create a cluster clone with repmgr we noticed that there's inaccurate information in the docs regarding the use of replication functions. I was able to test on 9.6 and 10 that a user with replication privileges can create and drop a replication slot. But in the system administration functions, section replication functions it states: The functions shown in Table 9.83 are for controlling and interacting with replication features. See Section 26.2.5, Section 26.2.6, and Chapter 49 for information about the underlying features. Use of these functions is restricted to superusers. Source: https://www.postgresql.org/docs/10/static/functions-admin.html#FUNCTIONS-REPLICATION I suggest amending this with a text like the following: The functions shown in Table 9.83 are for controlling and interacting with replication features. See Section 26.2.5, Section 26.2.6, and Chapter 49 for information about the underlying features. Use of these functions is restricted to superusers and users with replication privileges. I think this doc patch should be back-patched Regards, -- Martín Marquéshttp://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services
Re: "System roles" mentioned in psql documentation
On Thu, Aug 23, 2018 at 10:53:35AM +0200, Jürgen Purtz wrote: > This inconsistency is part of the more general problem that we miss a > chapter, where our basic terms like 'database', 'cluster', 'segment', > 'catalog', 'schema', ... are explicitly defined. You may have a point here, not in the way of reworking entirely the documentation, but in the fact that we may want to use "system objects" instead of "system roles". I am not personally sure that it is a better improvement than using "default roles", but that's a point to raise. -- Michael signature.asc Description: PGP signature
Re: "System roles" mentioned in psql documentation
> On Aug 23, 2018, at 3:58 AM, Michael Paquier wrote: > > Hi all, > > I have noticed that psql documentation mentions "system roles", however > in all other parts of the docs, we use the term "default roles". > Shouldn't we make this term more consistent and also add a link to the > table describing those roles? Please see the attached. I did a quick search for other cases of “system roles” with nothing coming up, so it looks like you caught the only reference. LGTM. Thanks! Jonathan signature.asc Description: Message signed with OpenPGP
Re: 25.3. Continuous Archiving : Unix examples with Windows-style variables %-$
Hi, > On Aug 23, 2018, at 5:54 AM, PG Doc comments form > wrote: > > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/9.4/static/continuous-archiving.html > Description: > > Most examples in "25.3. Continuous Archiving and Point-in-Time Recovery > (PITR)" use Unix commands and paths, but all variables are written as > Windows batch file variables (Windows "%var" / Unix "$var”). These are special variables that PostgreSQL replaces regardless of operating system. Per the paragraph above the examples: "In archive_command, %p is replaced by the path name of the file to archive, while %f is replaced by only the file name.” Thanks, Jonathan signature.asc Description: Message signed with OpenPGP
fix word
The following documentation comment has been logged on the website: Page: https://www.postgresql.org/docs/10/static/app-pg-ctl.html Description: ref/pg_ctl-ref.sgml 337,338c337,339 < The options should usually be surrounded by single or < double quotes to ensure that they are passed through as a group. --- > The initdb-options should usually be surrounded > by single or double quotes to ensure that they are passed through > as a group.
25.3. Continuous Archiving : Unix examples with Windows-style variables %-$
The following documentation comment has been logged on the website: Page: https://www.postgresql.org/docs/9.4/static/continuous-archiving.html Description: Most examples in "25.3. Continuous Archiving and Point-in-Time Recovery (PITR)" use Unix commands and paths, but all variables are written as Windows batch file variables (Windows "%var" / Unix "$var"). For example, the first one on the page has archive_command = 'test ! -f /mnt/server/archivedir/%f && cp %p /mnt/server/archivedir/%f' # Unix Instead of archive_command = 'test ! -f /mnt/server/archivedir/$f && cp $p /mnt/server/archivedir/$f' # Unix or possibly archive_command = '[ -f /mnt/server/archivedir/$f ] || cp $p /mnt/server/archivedir/$f' # Unix https://www.postgresql.org/docs/current/static/continuous-archiving.html
Re: "System roles" mentioned in psql documentation
This inconsistency is part of the more general problem that we miss a chapter, where our basic terms like 'database', 'cluster', 'segment', 'catalog', 'schema', ... are explicitly defined. Kind regards Jürgen Purtz
"System roles" mentioned in psql documentation
Hi all, I have noticed that psql documentation mentions "system roles", however in all other parts of the docs, we use the term "default roles". Shouldn't we make this term more consistent and also add a link to the table describing those roles? Please see the attached. Thanks, -- Michael diff --git a/doc/src/sgml/ref/psql-ref.sgml b/doc/src/sgml/ref/psql-ref.sgml index eb9d93a168..df762b811c 100644 --- a/doc/src/sgml/ref/psql-ref.sgml +++ b/doc/src/sgml/ref/psql-ref.sgml @@ -1521,7 +1521,8 @@ testdb=> unified into roles, this command is now equivalent to \du.) By default, only user-created roles are shown; supply the -S modifier to include system roles. +S modifier to include default roles described in +. If pattern is specified, only those roles whose names match the pattern are listed. If the form \dg+ is used, additional information @@ -1711,7 +1712,8 @@ testdb=> unified into roles, this command is now equivalent to \dg.) By default, only user-created roles are shown; supply the -S modifier to include system roles. +S modifier to include default roles described +in . If pattern is specified, only those roles whose names match the pattern are listed. If the form \du+ is used, additional information signature.asc Description: PGP signature
