Re: Use uppercase keywords in foreign key tutorial

2025-11-05 Thread Erik Wienhold
On 2025-11-04 03:09 +0100, David Rowley wrote:
> On Tue, 4 Nov 2025 at 13:04, Erik Wienhold  wrote:
> >
> > On 2025-11-03 23:37 +0100, David Rowley wrote:
> > > I'm starting to wonder if adjusting the spacing here is a worthwhile
> > > change.
> >
> > I think it's worth to have that consistency.  If the patch is too broad
> > I can of course limit it to the listings with inconsistent keyword
> > casing which is more less patch v2 plus some changes from v3 and later.
> >
> > Or just fix the keywords for now to get that out of the way and deal
> > with the spacing in a separate patch/thread.
> 
> I think just the keyword upper casing is a good idea for now. I'm
> starting to lose hope that there's enough merit and consistency to the
> proposed whitespace changes. Maybe there's a subset of it that does
> make sense to do.

Done in the attached v6.  But I kept the few whitespace changes on lines
where I change keywords to uppercase.  It's mostly a single space after
commas in column and parameter lists which I think also enhances
readability.

-- 
Erik Wienhold
>From 24061d3202452592bceab9e751de314a89af7146 Mon Sep 17 00:00:00 2001
From: Erik Wienhold 
Date: Thu, 16 Oct 2025 10:30:21 +0200
Subject: [PATCH v6] doc: Use uppercase keywords

Use uppercase SQL keywords consistently throughout the documentation to
ease reading.  Also add whitespace in a couple of places where it
improves readability.
---
 doc/src/sgml/advanced.sgml   |  4 +-
 doc/src/sgml/arch-dev.sgml   |  2 +-
 doc/src/sgml/bloom.sgml  | 12 ++--
 doc/src/sgml/charset.sgml|  4 +-
 doc/src/sgml/config.sgml |  4 +-
 doc/src/sgml/cube.sgml   |  8 +--
 doc/src/sgml/datatype.sgml   |  4 +-
 doc/src/sgml/datetime.sgml   |  6 +-
 doc/src/sgml/dblink.sgml | 28 -
 doc/src/sgml/ddl.sgml| 28 -
 doc/src/sgml/dict-int.sgml   |  2 +-
 doc/src/sgml/dml.sgml|  2 +-
 doc/src/sgml/ecpg.sgml   |  4 +-
 doc/src/sgml/event-trigger.sgml  |  2 +-
 doc/src/sgml/func/func-array.sgml|  2 +-
 doc/src/sgml/func/func-binarystring.sgml | 10 +--
 doc/src/sgml/func/func-bitstring.sgml|  8 +--
 doc/src/sgml/func/func-datetime.sgml | 14 ++---
 doc/src/sgml/func/func-formatting.sgml   |  4 +-
 doc/src/sgml/func/func-info.sgml |  4 +-
 doc/src/sgml/func/func-json.sgml | 80 
 doc/src/sgml/func/func-matching.sgml |  8 +--
 doc/src/sgml/func/func-srf.sgml  |  4 +-
 doc/src/sgml/func/func-string.sgml   | 14 ++---
 doc/src/sgml/func/func-textsearch.sgml   |  2 +-
 doc/src/sgml/func/func-xml.sgml  | 20 +++---
 doc/src/sgml/hstore.sgml |  4 +-
 doc/src/sgml/indices.sgml|  6 +-
 doc/src/sgml/isn.sgml|  2 +-
 doc/src/sgml/libpq.sgml  |  4 +-
 doc/src/sgml/logical-replication.sgml|  2 +-
 doc/src/sgml/logicaldecoding.sgml|  8 +--
 doc/src/sgml/ltree.sgml  |  2 +-
 doc/src/sgml/maintenance.sgml|  4 +-
 doc/src/sgml/monitoring.sgml |  4 +-
 doc/src/sgml/pageinspect.sgml|  4 +-
 doc/src/sgml/pgcrypto.sgml   |  2 +-
 doc/src/sgml/pgstattuple.sgml|  2 +-
 doc/src/sgml/pgsurgery.sgml  | 12 ++--
 doc/src/sgml/planstats.sgml  |  2 +-
 doc/src/sgml/plperl.sgml |  8 +--
 doc/src/sgml/plpgsql.sgml| 20 +++---
 doc/src/sgml/plpython.sgml   |  6 +-
 doc/src/sgml/pltcl.sgml  |  2 +-
 doc/src/sgml/queries.sgml|  4 +-
 doc/src/sgml/ref/alter_table.sgml|  2 +-
 doc/src/sgml/ref/create_function.sgml|  6 +-
 doc/src/sgml/ref/create_table.sgml   | 12 ++--
 doc/src/sgml/ref/pg_rewind.sgml  |  8 +--
 doc/src/sgml/ref/psql-ref.sgml   | 16 ++---
 doc/src/sgml/ref/select.sgml |  2 +-
 doc/src/sgml/rules.sgml  |  2 +-
 doc/src/sgml/seg.sgml|  6 +-
 doc/src/sgml/sepgsql.sgml|  2 +-
 doc/src/sgml/tablefunc.sgml  | 44 ++---
 doc/src/sgml/tcn.sgml| 22 +++
 doc/src/sgml/textsearch.sgml |  6 +-
 doc/src/sgml/typeconv.sgml   |  2 +-
 doc/src/sgml/unaccent.sgml   |  8 +--
 doc/src/sgml/xfunc.sgml  |  2 +-
 60 files changed, 259 insertions(+), 259 deletions(-)

diff --git a/doc/src/sgml/advanced.sgml b/doc/src/sgml/advanced.sgml
index e15a3323dfb..82e82c13457 100644
--- a/doc/src/sgml/advanced.sgml
+++ b/doc/src/sgml/advanced.sgml
@@ -101,12 +101,12 @@ SELECT * FROM myview;
 
 
 CREATE TABLE cities (
-name varchar(80) primary key,
+name varchar(80) PRIMARY KEY,
 location point
 );
 
 CREATE TABLE weather (
-city  varchar(80) references cities(name),
+ 

Re: Use uppercase keywords in foreign key tutorial

2025-11-05 Thread David Rowley
On Thu, 6 Nov 2025 at 07:09, Erik Wienhold  wrote:
>
> On 2025-11-04 03:09 +0100, David Rowley wrote:
> > I think just the keyword upper casing is a good idea for now. I'm
> > starting to lose hope that there's enough merit and consistency to the
> > proposed whitespace changes. Maybe there's a subset of it that does
> > make sense to do.
>
> Done in the attached v6.  But I kept the few whitespace changes on lines
> where I change keywords to uppercase.  It's mostly a single space after
> commas in column and parameter lists which I think also enhances
> readability.

I reviewed this and double checked you left "uPDaTE" in [1]. Found no
issues, so pushed.

Thank you.

David

[1] https://www.postgresql.org/docs/current/sql-syntax-lexical.html