Re: [HACKERS] v7.2.4 bundled ...
7.2.x isn't bison 1.75 compatible ... and most likely never will be ... On Wed, 29 Jan 2003, Rod Taylor wrote: > > I jsut bundled up v7.2.4 with all the recent security fixes ... can a > > few ppl do some regression tests and report back before I announce in the > > morning? I did a configure and build here and all looks fine, but some > > confirmations is always nice ;) > > Updated to tag REL7_2_4 on FreeBSD 4.7 and cannot compile it. gram.y > errors complaining: invalid character: ','. > > bash-2.05b$ bison --version > bison (GNU Bison) 1.75 > Written by Robert Corbett and Richard Stallman. > > > > -- > Rod Taylor <[EMAIL PROTECTED]> > > PGP Key: http://www.rbt.ca/rbtpub.asc > ---(end of broadcast)--- TIP 6: Have you searched our list archives? http://archives.postgresql.org
Re: [HACKERS] v7.2.4 bundled ...
Kevin Brown <[EMAIL PROTECTED]> writes: > I'm attaching a patch for 7.2.4's parser/gram.y that fixes all of > bison 1.75's complaints. But parser/gram.y is not the only .y file in the distribution. To call ourselves 1.75-safe, we'd have to go through this same exercise for all of 'em: $ find REL7_2 -name '*.y' REL7_2/pgsql/contrib/cube/cubeparse.y REL7_2/pgsql/contrib/seg/segparse.y REL7_2/pgsql/src/backend/bootstrap/bootparse.y REL7_2/pgsql/src/backend/parser/gram.y REL7_2/pgsql/src/interfaces/ecpg/preproc/preproc.y REL7_2/pgsql/src/pl/plpgsql/src/gram.y $ And on top of that, 1.75 isn't the current bison release anymore; the one that is current has changed the spelling of syntax error messages, which means that the regression tests will fail (and perhaps clients that are looking for syntax errors, too). We have agreed how to fix this in HEAD, but not actually done it yet --- shall we put that not-even-written-let-alone-tested code into 7.2.4 as well? I think it's best to leave well enough alone. The tarball ships with working bison output files anyway, so all of this really only matters to people trying to build 7.2.* from a CVS pull. regards, tom lane ---(end of broadcast)--- TIP 1: subscribe and unsubscribe commands go to [EMAIL PROTECTED]
Re: [HACKERS] v7.2.4 bundled ...
> > bash-2.05b$ bison --version > > bison (GNU Bison) 1.75 > ISTM that the eve of what'll probably be our last dot-release for 7.2 > is not the time to drop a new bison into its toolchain. Agreed -- but it's worth mentioning in the 7.2.4 release notes that an earlier Bison version is required. -- Rod Taylor <[EMAIL PROTECTED]> PGP Key: http://www.rbt.ca/rbtpub.asc signature.asc Description: This is a digitally signed message part
Re: [HACKERS] v7.2.4 bundled ...
All tests pass on FreeBSD/Alpha. Chris > -Original Message- > From: [EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED]]On Behalf Of Magnus > Naeslund(f) > Sent: Thursday, 30 January 2003 2:13 PM > To: Marc G. Fournier; [EMAIL PROTECTED] > Subject: Re: [HACKERS] v7.2.4 bundled ... > > > Redhat 6.2 > Linux gserver1 2.4.19-pre6 #4 Thu Apr 11 07:17:39 CEST 2002 alpha > unknown > All 79 tests passed. > > Magnus > > > ---(end of broadcast)--- > TIP 6: Have you searched our list archives? > > http://archives.postgresql.org > ---(end of broadcast)--- TIP 3: if posting/reading through Usenet, please send an appropriate subscribe-nomail command to [EMAIL PROTECTED] so that your message can get through to the mailing list cleanly
Re: [HACKERS] v7.2.4 bundled ...
Tom Lane wrote: > Rod Taylor <[EMAIL PROTECTED]> writes: > > Updated to tag REL7_2_4 on FreeBSD 4.7 and cannot compile it. gram.y > > errors complaining: invalid character: ','. > > > bash-2.05b$ bison --version > > bison (GNU Bison) 1.75 > > We just had that discussion on pgcore. The 7.2 grammar was developed > against bison 1.28; it works with warnings against bison 1.35, but bison > 1.75 just flat rejects it (not for any significant reason, but just > because they decided to get anal-retentive about whether they'd allow > commas in keyword lists). > > We could update the 7.2 grammar and compile it with the latest bison, > but we were worried about whether we might introduce any subtle problems > if we did. The 7.2 branch has received zero testing with bison 1.75. > > ISTM that the eve of what'll probably be our last dot-release for 7.2 > is not the time to drop a new bison into its toolchain. Ooops. Last patch wasn't done using CVS diff. This one is, in case it matters... -- Kevin Brown [EMAIL PROTECTED] Index: gram.y === RCS file: /projects/cvsroot/pgsql-server/src/backend/parser/gram.y,v retrieving revision 2.276.2.1 diff -u -d -r2.276.2.1 gram.y --- gram.y 2002/03/09 17:41:04 2.276.2.1 +++ gram.y 2003/01/30 06:55:25 @@ -129,33 +129,33 @@ InsertStmt *istmt; } -%typestmt, - AlterGroupStmt, AlterSchemaStmt, AlterTableStmt, AlterUserStmt, - AnalyzeStmt, - ClosePortalStmt, ClusterStmt, CommentStmt, ConstraintsSetStmt, - CopyStmt, CreateAsStmt, CreateGroupStmt, CreatePLangStmt, - CreateSchemaStmt, CreateSeqStmt, CreateStmt, CreateTrigStmt, - CreateUserStmt, CreatedbStmt, CursorStmt, DefineStmt, DeleteStmt, - DropGroupStmt, DropPLangStmt, DropSchemaStmt, DropStmt, DropTrigStmt, - DropUserStmt, DropdbStmt, ExplainStmt, FetchStmt, - GrantStmt, IndexStmt, InsertStmt, ListenStmt, LoadStmt, LockStmt, - NotifyStmt, OptimizableStmt, ProcedureStmt, ReindexStmt, - RemoveAggrStmt, RemoveFuncStmt, RemoveOperStmt, - RenameStmt, RevokeStmt, RuleActionStmt, RuleActionStmtOrEmpty, - RuleStmt, SelectStmt, TransactionStmt, TruncateStmt, - UnlistenStmt, UpdateStmt, VacuumStmt, VariableResetStmt, - VariableSetStmt, VariableShowStmt, ViewStmt, CheckPointStmt +%typestmt + AlterGroupStmt AlterSchemaStmt AlterTableStmt AlterUserStmt + AnalyzeStmt + ClosePortalStmt ClusterStmt CommentStmt ConstraintsSetStmt + CopyStmt CreateAsStmt CreateGroupStmt CreatePLangStmt + CreateSchemaStmt CreateSeqStmt CreateStmt CreateTrigStmt + CreateUserStmt CreatedbStmt CursorStmt DefineStmt DeleteStmt + DropGroupStmt DropPLangStmt DropSchemaStmt DropStmt DropTrigStmt + DropUserStmt DropdbStmt ExplainStmt FetchStmt + GrantStmt IndexStmt InsertStmt ListenStmt LoadStmt LockStmt + NotifyStmt OptimizableStmt ProcedureStmt ReindexStmt + RemoveAggrStmt RemoveFuncStmt RemoveOperStmt + RenameStmt RevokeStmt RuleActionStmt RuleActionStmtOrEmpty + RuleStmt SelectStmt TransactionStmt TruncateStmt + UnlistenStmt UpdateStmt VacuumStmt VariableResetStmt + VariableSetStmt VariableShowStmt ViewStmt CheckPointStmt -%typeselect_no_parens, select_with_parens, select_clause, +%typeselect_no_parens select_with_parens select_clause simple_select %type alter_column_default %type drop_behavior -%typecreatedb_opt_list, createdb_opt_item +%typecreatedb_opt_list createdb_opt_item -%typeopt_lock, lock_type -%type opt_force, opt_or_replace +%typeopt_lock lock_type +%type opt_force opt_or_replace %typeuser_list @@ -165,7 +165,7 @@ %typeOptUserList %type OptUserElem -%type TriggerActionTime, TriggerForSpec, opt_trusted, opt_procedural +%type TriggerActionTime TriggerForSpec opt_trusted opt_procedural %type opt_lancompiler %type OptConstrFromTable @@ -173,111 +173,111 @@ %type TriggerEvents %type TriggerFuncArg -%type relation_name, copy_file_name, copy_delimiter, copy_null, - database_name, access_method_clause, access_method, attr_name, - class, index_name, name, func_name, file_name +%type relation_name copy_file_name copy_delimiter copy_null + database_name access_method_clause access_method attr_name + class index_name name func_name file_name -%type opt_id, - all_Op, MathOp, opt_name, - OptUseOp, opt_class,
Re: [HACKERS] v7.2.4 bundled ...
Tom Lane wrote: > Rod Taylor <[EMAIL PROTECTED]> writes: > > Updated to tag REL7_2_4 on FreeBSD 4.7 and cannot compile it. gram.y > > errors complaining: invalid character: ','. > > > bash-2.05b$ bison --version > > bison (GNU Bison) 1.75 > > We just had that discussion on pgcore. The 7.2 grammar was developed > against bison 1.28; it works with warnings against bison 1.35, but bison > 1.75 just flat rejects it (not for any significant reason, but just > because they decided to get anal-retentive about whether they'd allow > commas in keyword lists). > > We could update the 7.2 grammar and compile it with the latest bison, > but we were worried about whether we might introduce any subtle problems > if we did. The 7.2 branch has received zero testing with bison 1.75. > > ISTM that the eve of what'll probably be our last dot-release for 7.2 > is not the time to drop a new bison into its toolchain. For what it's worth, I've fixed all the errors in the 7.2.4 gram.y file that bison 1.75 complained and then re-ran bison 1.35 against it, then compared that with the output that the same version of bison generated from the original grammar file. The only differences were references to line numbers -- everything else is identical. So if any problems occur from using bison 1.75, they will be either due to bugs in that version of bison or due to our dependence on a bug in earlier versions, or something like that. I'm attaching a patch for 7.2.4's parser/gram.y that fixes all of bison 1.75's complaints. Since the output of bison 1.35 is essentially identical between the original and this, I don't see any reason we shouldn't include the fix in the 7.2.4 release, as long as we include a warning in the release notes that we haven't done any real testing with a build against bison 1.75 (or later). -- Kevin Brown [EMAIL PROTECTED] --- gram.y.orig Wed Jan 29 22:39:31 2003 +++ gram.y Wed Jan 29 22:43:33 2003 @@ -129,33 +129,33 @@ InsertStmt *istmt; } -%typestmt, - AlterGroupStmt, AlterSchemaStmt, AlterTableStmt, AlterUserStmt, - AnalyzeStmt, - ClosePortalStmt, ClusterStmt, CommentStmt, ConstraintsSetStmt, - CopyStmt, CreateAsStmt, CreateGroupStmt, CreatePLangStmt, - CreateSchemaStmt, CreateSeqStmt, CreateStmt, CreateTrigStmt, - CreateUserStmt, CreatedbStmt, CursorStmt, DefineStmt, DeleteStmt, - DropGroupStmt, DropPLangStmt, DropSchemaStmt, DropStmt, DropTrigStmt, - DropUserStmt, DropdbStmt, ExplainStmt, FetchStmt, - GrantStmt, IndexStmt, InsertStmt, ListenStmt, LoadStmt, LockStmt, - NotifyStmt, OptimizableStmt, ProcedureStmt, ReindexStmt, - RemoveAggrStmt, RemoveFuncStmt, RemoveOperStmt, - RenameStmt, RevokeStmt, RuleActionStmt, RuleActionStmtOrEmpty, - RuleStmt, SelectStmt, TransactionStmt, TruncateStmt, - UnlistenStmt, UpdateStmt, VacuumStmt, VariableResetStmt, - VariableSetStmt, VariableShowStmt, ViewStmt, CheckPointStmt +%typestmt + AlterGroupStmt AlterSchemaStmt AlterTableStmt AlterUserStmt + AnalyzeStmt + ClosePortalStmt ClusterStmt CommentStmt ConstraintsSetStmt + CopyStmt CreateAsStmt CreateGroupStmt CreatePLangStmt + CreateSchemaStmt CreateSeqStmt CreateStmt CreateTrigStmt + CreateUserStmt CreatedbStmt CursorStmt DefineStmt DeleteStmt + DropGroupStmt DropPLangStmt DropSchemaStmt DropStmt DropTrigStmt + DropUserStmt DropdbStmt ExplainStmt FetchStmt + GrantStmt IndexStmt InsertStmt ListenStmt LoadStmt LockStmt + NotifyStmt OptimizableStmt ProcedureStmt ReindexStmt + RemoveAggrStmt RemoveFuncStmt RemoveOperStmt + RenameStmt RevokeStmt RuleActionStmt RuleActionStmtOrEmpty + RuleStmt SelectStmt TransactionStmt TruncateStmt + UnlistenStmt UpdateStmt VacuumStmt VariableResetStmt + VariableSetStmt VariableShowStmt ViewStmt CheckPointStmt -%typeselect_no_parens, select_with_parens, select_clause, +%typeselect_no_parens select_with_parens select_clause simple_select %type alter_column_default %type drop_behavior -%typecreatedb_opt_list, createdb_opt_item +%typecreatedb_opt_list createdb_opt_item -%typeopt_lock, lock_type -%type opt_force, opt_or_replace +%typeopt_lock lock_type +%type opt_force opt_or_replace %typeuser_list @@ -165,7 +165,7 @@ %typeOptUserList %type OptUserElem -%type TriggerActionTime, TriggerForSpec, opt_trusted, opt_procedural +%type TriggerActionTime TriggerForSpec opt_trusted opt_procedural %type opt_lancompiler %type OptConstrFromTable @@ -17
Re: [HACKERS] v7.2.4 bundled ...
"Christopher Kings-Lynne" <[EMAIL PROTECTED]> writes: > Where do I get it from? > I can't see it on any of the FTP sites... Not all the mirrors have updated yet, but I see it at ftp://ftp9.us.postgresql.org/pub/mirrors/postgresql/source/v7.2.4/ for one ... regards, tom lane ---(end of broadcast)--- TIP 3: if posting/reading through Usenet, please send an appropriate subscribe-nomail command to [EMAIL PROTECTED] so that your message can get through to the mailing list cleanly
Re: [HACKERS] v7.2.4 bundled ...
Redhat 6.2 Linux gserver1 2.4.19-pre6 #4 Thu Apr 11 07:17:39 CEST 2002 alpha unknown All 79 tests passed. Magnus ---(end of broadcast)--- TIP 6: Have you searched our list archives? http://archives.postgresql.org
Re: [HACKERS] v7.2.4 bundled ...
Where do I get it from? I can't see it on any of the FTP sites... Chris > -Original Message- > From: [EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED]]On Behalf Of Marc G. Fournier > Sent: Thursday, 30 January 2003 10:00 AM > To: [EMAIL PROTECTED] > Subject: [HACKERS] v7.2.4 bundled ... > > > > Morning all ... > > I jsut bundled up v7.2.4 with all the recent security fixes ... can a > few ppl do some regression tests and report back before I announce in the > morning? I did a configure and build here and all looks fine, but some > confirmations is always nice ;) > > > > ---(end of broadcast)--- > TIP 4: Don't 'kill -9' the postmaster > ---(end of broadcast)--- TIP 4: Don't 'kill -9' the postmaster
Re: [HACKERS] v7.2.4 bundled ...
"Marc G. Fournier" <[EMAIL PROTECTED]> writes: > I jsut bundled up v7.2.4 with all the recent security fixes ... can a > few ppl do some regression tests and report back before I announce in the > morning? I did a configure and build here and all looks fine, but some > confirmations is always nice ;) Passes regression tests here (HPUX 10.20)... regards, tom lane ---(end of broadcast)--- TIP 3: if posting/reading through Usenet, please send an appropriate subscribe-nomail command to [EMAIL PROTECTED] so that your message can get through to the mailing list cleanly
Re: [HACKERS] v7.2.4 bundled ...
Rod Taylor <[EMAIL PROTECTED]> writes: > Updated to tag REL7_2_4 on FreeBSD 4.7 and cannot compile it. gram.y > errors complaining: invalid character: ','. > bash-2.05b$ bison --version > bison (GNU Bison) 1.75 We just had that discussion on pgcore. The 7.2 grammar was developed against bison 1.28; it works with warnings against bison 1.35, but bison 1.75 just flat rejects it (not for any significant reason, but just because they decided to get anal-retentive about whether they'd allow commas in keyword lists). We could update the 7.2 grammar and compile it with the latest bison, but we were worried about whether we might introduce any subtle problems if we did. The 7.2 branch has received zero testing with bison 1.75. ISTM that the eve of what'll probably be our last dot-release for 7.2 is not the time to drop a new bison into its toolchain. regards, tom lane ---(end of broadcast)--- TIP 1: subscribe and unsubscribe commands go to [EMAIL PROTECTED]
Re: [HACKERS] v7.2.4 bundled ...
> I jsut bundled up v7.2.4 with all the recent security fixes ... can a > few ppl do some regression tests and report back before I announce in the > morning? I did a configure and build here and all looks fine, but some > confirmations is always nice ;) Updated to tag REL7_2_4 on FreeBSD 4.7 and cannot compile it. gram.y errors complaining: invalid character: ','. bash-2.05b$ bison --version bison (GNU Bison) 1.75 Written by Robert Corbett and Richard Stallman. -- Rod Taylor <[EMAIL PROTECTED]> PGP Key: http://www.rbt.ca/rbtpub.asc signature.asc Description: This is a digitally signed message part
