D19577: [sddm-theme/lock screen] Fix "unable to assign [undefined] error

[Krešimir Čohar]

rooty created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
rooty requested review of this revision.

REVISION SUMMARY
  This patch fixes the "Unable to assign [undefined] to QColor" and "Unable to 
assign [undefined] to int" errors that occur in UserDelegate.qml (188:9, 187:9) 
and Clock.qml (53:13, 52:13, 60:13, 59:13), visible in sddm-greeter's output.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  no-more-unabletoassign (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19577

AFFECTED FILES
  lookandfeel/contents/components/Clock.qml
  lookandfeel/contents/components/UserDelegate.qml

To: rooty
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19479: [Lock, Login, and Logout screen] Adjust visual feedback of action buttons

[Krešimir Čohar]

rooty requested changes to this revision.
rooty added a comment.
This revision now requires changes to proceed.


  I really hate to be a bore but without the switch to PropertyAnimation that 
annoying bug (that you might not be able to notice but I am) keeps rearing its 
ugly head.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19479

To: filipf, rooty, ngraham, #vdg, #plasma
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19566: [OSD] Fix animation stutter

[Krešimir Čohar]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:9a7de4e02399: [OSD] Fix animation stutter (authored by 
rooty).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19566?vs=53286&id=53329

REVISION DETAIL
  https://phabricator.kde.org/D19566

AFFECTED FILES
  lookandfeel/contents/osd/Osd.qml

To: rooty, #plasma, #vdg, davidedmundson, ngraham
Cc: abetts, broulik, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19434: Change entry of Endpoint UI

[Bruce Anderson]

andersonbruce updated this revision to Diff 53328.
andersonbruce added a comment.


  - Add validator for Endpoint Port field

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19434?vs=52875&id=53328

BRANCH
  EndPointUIChange

REVISION DETAIL
  https://phabricator.kde.org/D19434

AFFECTED FILES
  vpn/wireguard/wireguard.ui
  vpn/wireguard/wireguardwidget.cpp

To: andersonbruce, jgrulich
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19479: [Lock, Login, and Logout screen] Adjust visual feedback of action buttons

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  This looks and feels great to me! A huge improvement IMO. And the code looks 
good.
  
  I'd also like a pressed state for these buttons too, but since the lack of 
them is a pre-existing issue, we can do that in another patch. :)

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19479

To: filipf, rooty, ngraham, #vdg, #plasma
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19479: [Lock, Login, and Logout screen] Adjust visual feedback of action buttons

[Filip Fila]

filipf updated this revision to Diff 53325.
filipf added a comment.


  fix comment

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19479?vs=53322&id=53325

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19479

AFFECTED FILES
  lookandfeel/contents/components/ActionButton.qml
  lookandfeel/contents/logout/LogoutButton.qml

To: filipf, rooty, ngraham, #vdg, #plasma
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17249: Preserve screen colour doesn't work as expected

[John Salatas]

This revision was automatically updated to reflect the committed changes.
Closed by commit R885:1e2a920633d7: Preserve screen colour doesn't work as 
expected (authored by jsalatas).

REPOSITORY
  R885 Redshift Control for Plasma

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17249?vs=46524&id=53324

REVISION DETAIL
  https://phabricator.kde.org/D17249

AFFECTED FILES
  package/contents/ui/main.qml

To: jsalatas, #plasma, martinkostolny, broulik
Cc: broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19479: [Lock, Login, and Logout screen] Adjust visual feedback of action buttons

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> LogoutButton.qml:34
> +circleVisiblity: activeFocus || containsMouse
> +circleOpacity: 0.15 // circles are always visible
>  opacity: activeFocus || containsMouse ? 1 : 0.5

This comment doesn't seem accurate anymore.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19479

To: filipf, rooty, ngraham, #vdg, #plasma
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19011: Thunderbolt KCM and KDED module

[Nathaniel Graham]

ngraham accepted this revision as: VDG.
ngraham added a comment.


  UI looks good to me now! Nice job.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19011

To: dvratil, #vdg, #plasma
Cc: knambiar, bernieinnocenti, andreask, ndavis, trickyricky26, abetts, 
fabianr, ngraham, broulik, ognarb, yurchor, asturmlechner, plasma-devel, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D19011: Thunderbolt KCM and KDED module

[Daniel Vrátil]

dvratil updated this revision to Diff 53323.
dvratil added a comment.


  - Wording: Trust this Device/Revoke Trust button labels

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19011?vs=52775&id=53323

BRANCH
  arcpatch-D19011

REVISION DETAIL
  https://phabricator.kde.org/D19011

AFFECTED FILES
  CMakeLists.txt
  autotests/CMakeLists.txt
  autotests/bolt/CMakeLists.txt
  autotests/bolt/data/default.json
  autotests/bolt/fakeserver/CMakeLists.txt
  autotests/bolt/fakeserver/fakedevice.cpp
  autotests/bolt/fakeserver/fakedevice.h
  autotests/bolt/fakeserver/fakemanager.cpp
  autotests/bolt/fakeserver/fakemanager.h
  autotests/bolt/fakeserver/fakeserver.cpp
  autotests/bolt/fakeserver/fakeserver.h
  autotests/bolt/fakeserver/main.cpp
  autotests/bolt/kded/CMakeLists.txt
  autotests/bolt/kded/kdedtest.cpp
  autotests/bolt/lib/CMakeLists.txt
  autotests/bolt/lib/devicetest.cpp
  autotests/bolt/lib/managertest.cpp
  cmake/modules/FindBolt.cmake
  kcms/CMakeLists.txt
  kcms/bolt/CMakeLists.txt
  kcms/bolt/Messages.sh
  kcms/bolt/kcm_bolt.cpp
  kcms/bolt/kcm_bolt.desktop
  kcms/bolt/kcm_bolt.h
  kcms/bolt/package/contents/ui/DeviceList.qml
  kcms/bolt/package/contents/ui/DeviceView.qml
  kcms/bolt/package/contents/ui/main.qml
  kcms/bolt/package/contents/ui/utils.js
  kcms/bolt/package/metadata.desktop
  kded/CMakeLists.txt
  kded/bolt/CMakeLists.txt
  kded/bolt/kded_bolt.cpp
  kded/bolt/kded_bolt.desktop
  kded/bolt/kded_bolt.h
  kded/bolt/kded_bolt.notifyrc
  kded/bolt/main.cpp
  libs/CMakeLists.txt
  libs/bolt/CMakeLists.txt
  libs/bolt/dbushelper.cpp
  libs/bolt/dbushelper.h
  libs/bolt/device.cpp
  libs/bolt/device.h
  libs/bolt/devicemodel.cpp
  libs/bolt/devicemodel.h
  libs/bolt/enum.cpp
  libs/bolt/enum.h
  libs/bolt/interfaces/org.freedesktop.bolt1.device.xml
  libs/bolt/interfaces/org.freedesktop.bolt1.manager.xml
  libs/bolt/manager.cpp
  libs/bolt/manager.h

To: dvratil, #vdg, #plasma
Cc: knambiar, bernieinnocenti, andreask, ndavis, trickyricky26, abetts, 
fabianr, ngraham, broulik, ognarb, yurchor, asturmlechner, plasma-devel, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D19479: [Lock, Login, and Logout screen] Adjust visual feedback of action buttons

[Filip Fila]

filipf updated this revision to Diff 53322.
filipf added a comment.


  go back to using opacityanimator

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19479?vs=53321&id=53322

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19479

AFFECTED FILES
  lookandfeel/contents/components/ActionButton.qml
  lookandfeel/contents/logout/LogoutButton.qml

To: filipf, rooty, ngraham, #vdg, #plasma
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19479: [Lock, Login, and Logout screen] Adjust visual feedback of action buttons

[Filip Fila]

filipf updated this revision to Diff 53321.
filipf added a comment.


  Circles in the logout screen are only visible if the option is selected or 
hovered over

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19479?vs=53089&id=53321

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19479

AFFECTED FILES
  lookandfeel/contents/components/ActionButton.qml
  lookandfeel/contents/logout/LogoutButton.qml

To: filipf, rooty, ngraham, #vdg, #plasma
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19510: [Logout screen] Fix label opacity failing

[Filip Fila]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:076671638f1d: [Logout screen] Fix label opacity failing 
(authored by filipf).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19510?vs=53317&id=53320

REVISION DETAIL
  https://phabricator.kde.org/D19510

AFFECTED FILES
  lookandfeel/contents/components/ActionButton.qml
  lookandfeel/contents/logout/LogoutButton.qml

To: filipf, #plasma, ngraham, rooty
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19510: [Logout screen] Fix label opacity failing

[Filip Fila]

filipf updated this revision to Diff 53317.
filipf added a comment.


  Add space between = and 1

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19510?vs=53316&id=53317

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19510

AFFECTED FILES
  lookandfeel/contents/components/ActionButton.qml
  lookandfeel/contents/logout/LogoutButton.qml

To: filipf, #plasma, ngraham, rooty
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19510: [Logout screen] Fix label opacity failing

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> LogoutButton.qml:34
>  opacity: activeFocus || containsMouse ? 1 : 0.5
> +labelRendering: opacity !=1 ? Text.QtRendering : Text.NativeRendering // 
> Remove once we've solved Qt bug: https://bugreports.qt.io/browse/QTBUG-70138 
> (KDE bug: https://bugs.kde.org/show_bug.cgi?id=401644)
>  font.underline: false

Add a space between `=` and `1`

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19510

To: filipf, #plasma, ngraham, rooty
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19510: [Logout screen] Fix label opacity failing

[Filip Fila]

filipf added a comment.


  @ngraham to further minimize the use of QtRendering I've added code so that 
it's used only when opacity is not 1. Is that okay?

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19510

To: filipf, #plasma, ngraham, rooty
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19510: [Logout screen] Fix label opacity failing

[Filip Fila]

filipf updated this revision to Diff 53316.
filipf added a comment.


  Use QtRendering only when opacity is not 1

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19510?vs=53122&id=53316

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19510

AFFECTED FILES
  lookandfeel/contents/components/ActionButton.qml
  lookandfeel/contents/logout/LogoutButton.qml

To: filipf, #plasma, ngraham, rooty
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19417: [Web Browser] Use more appropriate panel icon and increase default size

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R114:47a8dd784daf: [Web Browser] Use more appropriate panel 
icon and increase default size (authored by iostapenko, committed by ngraham).

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19417?vs=52812&id=53313

REVISION DETAIL
  https://phabricator.kde.org/D19417

AFFECTED FILES
  applets/webbrowser/package/contents/ui/main.qml
  applets/webbrowser/package/metadata.desktop

To: iostapenko, ematirov, #plasma, broulik
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19550: [Media Frame] Set sourceSize for higher quality and lower memory consumption

[Nathaniel Graham]

ngraham updated this revision to Diff 53310.
ngraham marked an inline comment as done.
ngraham added a comment.


  Restart the timer when resizing is still ongoing so we can reduce the timer 
interval and update faster once resizing is done

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19550?vs=53302&id=53310

BRANCH
  use-mipmapping-for-higher-quality (branched from Plasma/5.15)

REVISION DETAIL
  https://phabricator.kde.org/D19550

AFFECTED FILES
  applets/mediaframe/package/contents/ui/main.qml

To: ngraham, #plasma, broulik
Cc: anthonyfieroni, broulik, davidedmundson, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D19569: ActionTextField: Properly place actions

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:90693762ce26: ActionTextField: Properly place actions 
(authored by apol).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19569?vs=53287&id=53309

REVISION DETAIL
  https://phabricator.kde.org/D19569

AFFECTED FILES
  src/controls/ActionTextField.qml

To: apol, #kirigami, ngraham
Cc: plasma-devel, domson, dkardarakos, apol, davidedmundson, mart, hein

D19572: [kcolorschemeditor] Don't re-add existing tab

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  This keeps it from unexpectedly changing tabs as you change any values.
  
  BUG: 393282
  FIXED-IN: 5.15.3

TEST PLAN
  I tried to look into why Qt does it but I couldn't figure out why it happens.
  
tabWidget->currentIndex(); // is 3
tabWidget->addTab(m_inactiveTab, i18n("Inactive")); // returns 3
tabWidget->currentIndex(); // is suddenly 2?!

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19572

AFFECTED FILES
  kcms/colors/editor/scmeditordialog.cpp

To: broulik, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19550: [Media Frame] Set sourceSize for higher quality and lower memory consumption

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> main.qml:224-225
>  
> +onWidthChanged: imageReloadTimer.start()
> +onHeightChanged: imageReloadTimer.start()
> +

Maybe restart is better, you can resize more than a second, so it'll wait a 
timer interval with no resize activity. After that you can make timer.interval 
say 100 ms.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D19550

To: ngraham, #plasma, broulik
Cc: anthonyfieroni, broulik, davidedmundson, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D18646: [Colors KCM] Add search and filter

[Kai Uwe Broulik]

broulik updated this revision to Diff 53304.
broulik added a comment.
This revision is now accepted and ready to land.


  - Refactor to use proper `QAbstractListModel` for colors
  - Fix current scheme index following as you filter

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18646?vs=50838&id=53304

REVISION DETAIL
  https://phabricator.kde.org/D18646

AFFECTED FILES
  kcms/colors/CMakeLists.txt
  kcms/colors/colors.cpp
  kcms/colors/colors.h
  kcms/colors/colorsmodel.cpp
  kcms/colors/colorsmodel.h
  kcms/colors/filterproxymodel.cpp
  kcms/colors/filterproxymodel.h
  kcms/colors/package/contents/ui/main.qml

To: broulik, #plasma, #vdg, hein
Cc: hein, davidedmundson, ngraham, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D19417: Panel icon & layout change of webbrowser applet

[Ilya Ostapenko]

iostapenko added a comment.


  Ilya Ostapenko ostapenko.public at gmail.com

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D19417

To: iostapenko, ematirov, #plasma, broulik
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19550: [Media Frame] Set sourceSize for higher quality and lower memory consumption

[Nathaniel Graham]

ngraham updated this revision to Diff 53302.
ngraham added a comment.


  Set `sourceSize` in a timer so we don't continuously reload the image while 
the widget is being resized

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19550?vs=53249&id=53302

BRANCH
  use-mipmapping-for-higher-quality (branched from Plasma/5.15)

REVISION DETAIL
  https://phabricator.kde.org/D19550

AFFECTED FILES
  applets/mediaframe/package/contents/ui/main.qml

To: ngraham, #plasma
Cc: broulik, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19560: [Desktop Sessions KCM] Add Restart to BIOS/UEFI checkbox

[Kai Uwe Broulik]

broulik updated this revision to Diff 53290.
broulik added a comment.


  - Add efi, uefi, bios as keywords so the KCM can be found this way through 
KRunner

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19560?vs=53279&id=53290

REVISION DETAIL
  https://phabricator.kde.org/D19560

AFFECTED FILES
  kcms/ksmserver/kcmsmserver.cpp
  kcms/ksmserver/kcmsmserver.desktop
  kcms/ksmserver/kcmsmserver.h
  kcms/ksmserver/smserverconfigdlg.ui
  kcms/ksmserver/smserverconfigimpl.cpp
  kcms/ksmserver/smserverconfigimpl.h

To: broulik, #plasma, #vdg
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19560: [Desktop Sessions KCM] Add Restart to BIOS/UEFI checkbox

[Nathaniel Graham]

ngraham accepted this revision as: VDG.
ngraham added a comment.


  Never mind, it's already gone. UI looks good to me!

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19560

To: broulik, #plasma, #vdg
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19560: [Desktop Sessions KCM] Add Restart to BIOS/UEFI checkbox

[Nathaniel Graham]

ngraham added a comment.


  Not sure we need the restart icon in the checkbox label.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19560

To: broulik, #plasma, #vdg
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19569: ActionTextField: Properly place actions

[Aleix Pol Gonzalez]

apol added a comment.


  New: F6663212: action-button-good.png 
  
  Old: F6663211: action-button-bad.png 

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D19569

To: apol, #kirigami
Cc: plasma-devel, domson, dkardarakos, apol, davidedmundson, mart, hein

D19569: ActionTextField: Properly place actions

[Aleix Pol Gonzalez]

apol created this revision.
apol added a reviewer: Kirigami.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  Since it was adopted I got a tiny button for the action, make better anchors 
use to fix this.

TEST PLAN
  Visual inspection

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19569

AFFECTED FILES
  src/controls/ActionTextField.qml

To: apol, #kirigami
Cc: plasma-devel, domson, dkardarakos, apol, davidedmundson, mart, hein

D19417: Panel icon & layout change of webbrowser applet

[Nathaniel Graham]

ngraham added a comment.


  Thanks for this patch! Can you provide your full name and email address so we 
can land it with correct authorship information?

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D19417

To: iostapenko, ematirov, #plasma, broulik
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19566: [OSD] Fix animation stutter

[Krešimir Čohar]

rooty added a comment.


  How's that? It actually reminds me of the notification widget with these 
changes in place

REPOSITORY
  R120 Plasma Workspace

BRANCH
  osd-effect-fix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19566

To: rooty, #plasma, #vdg, davidedmundson, ngraham
Cc: abetts, broulik, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19566: [OSD] Fix animation stutter

[Krešimir Čohar]

rooty updated this revision to Diff 53286.
rooty added a comment.


  Remove unused animation code

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19566?vs=53277&id=53286

BRANCH
  osd-effect-fix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19566

AFFECTED FILES
  lookandfeel/contents/osd/Osd.qml

To: rooty, #plasma, #vdg, davidedmundson, ngraham
Cc: abetts, broulik, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19566: [OSD] Fix animation stutter

[Krešimir Čohar]

rooty added a comment.


  > plasma-workspace/shell/osd.cpp
  > 
  > It also seems kscreen has a copy of thhis OSD which also needs fixing, and 
please also make sure the lockscreen doesn't break as it also embeds an OSD 
item.
  
  It won't affect the lock screen. (The lock screen was never affected by the 
bug either, actually)
  
  > The aforementioned code checks if an `animateOpacity` property is present, 
if so, it changes the window `opacity` which will then be animated. If that 
property is gone, the code just sets the window `visible` which will be 
animated by KWin. As such, the animation in the osd.qml is entirely unused now.
  
  Oh God I'm so sorry I completely forgot about Kwin. I could just remove the 
animation entirely then?

REPOSITORY
  R120 Plasma Workspace

BRANCH
  osd-effect-fix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19566

To: rooty, #plasma, #vdg, davidedmundson, ngraham
Cc: abetts, broulik, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D17249: Preserve screen colour doesn't work as expected

[Kai Uwe Broulik]

broulik accepted this revision.
broulik added a comment.
This revision is now accepted and ready to land.


  Seems sensible, thanks.

REPOSITORY
  R885 Redshift Control for Plasma

REVISION DETAIL
  https://phabricator.kde.org/D17249

To: jsalatas, #plasma, martinkostolny, broulik
Cc: broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19566: [OSD] Fix animation stutter

[Kai Uwe Broulik]

broulik added a comment.


  > There don't seem to be any other instances of it being used?
  
  plasma-workspace/shell/osd.cpp
  
  It also seems kscreen has a copy of thhis OSD which also needs fixing, and 
please also make sure the lockscreen doesn't break as it also embeds an OSD 
item.
  
  > I don't understand, could you elaborate please?
  
  The aforementioned code checks if an `animateOpacity` property is present, if 
so, it changes the window `opacity` which will then be animated. If that 
property is gone, the code just sets the window `visible` which will be 
animated by KWin. As such, the animation in the osd.qml is entirely unused now.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  osd-effect-fix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19566

To: rooty, #plasma, #vdg, davidedmundson, ngraham
Cc: abetts, broulik, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19566: [OSD] Fix animation stutter

[Krešimir Čohar]

rooty added a comment.


  In D19566#425896 , @broulik wrote:
  
  > That removes the "slowly fade out feature of the OSD", please then also 
remove all uses of that property
  
  
  There don't seem to be any other instances of it being used?
  
  > Also, the Animation is now also entirely unused as the opacity of the 
window is no longer changed? Please clean this up.
  
  I don't understand, could you elaborate please?

REPOSITORY
  R120 Plasma Workspace

BRANCH
  osd-effect-fix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19566

To: rooty, #plasma, #vdg, davidedmundson, ngraham
Cc: abetts, broulik, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19550: [Media Frame] Set sourceSize for higher quality and lower memory consumption

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> main.qml:189
>  fillMode: plasmoid.configuration.fillMode
> +sourceSize.width: main.width
> +sourceSize.height: main.height

Note that this will cause the image to be reloaded everytime the size changes, 
so make sure the image isn't loaded repeatedly on start (as the applet is laid 
out) and/or while resizing the widget

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D19550

To: ngraham, #plasma
Cc: broulik, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19566: [OSD] Fix animation stutter

[Andres Betts]

abetts added a comment.


  +1 on visuals

REPOSITORY
  R120 Plasma Workspace

BRANCH
  osd-effect-fix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19566

To: rooty, #plasma, #vdg, davidedmundson, ngraham
Cc: abetts, broulik, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19566: [OSD] Fix animation stutter

[Kai Uwe Broulik]

broulik added a comment.


  Also, the Animation is now also entirely unused as the opacity of the window 
is no longer changed? Please clean this up.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  osd-effect-fix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19566

To: rooty, #plasma, #vdg, davidedmundson, ngraham
Cc: broulik, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19566: [OSD] Fix animation stutter

[Kai Uwe Broulik]

broulik added a comment.


  That removes the "slowly fade out feature of the OSD", please then also 
remove all uses of that property

REPOSITORY
  R120 Plasma Workspace

BRANCH
  osd-effect-fix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19566

To: rooty, #plasma, #vdg, davidedmundson, ngraham
Cc: broulik, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19562: [Logout Screen] Show info that rebooting will enter firmware setup

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  The wording looks good to me!

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19562

To: broulik, #plasma, #vdg, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19566: [OSD] Fix animation stutter

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  Land in 5.15 and merge to master, please!

REPOSITORY
  R120 Plasma Workspace

BRANCH
  osd-effect-fix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19566

To: rooty, #plasma, #vdg, davidedmundson, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19561: Don't crash if the fwupd error is null

[Dan Leinir Turthra Jensen]

leinir added a comment.


  In D19561#425879 , @apol wrote:
  
  > Cool, thanks! remember to land in 5.15.
  
  
  Will do! :)

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D19561

To: leinir, #discover_software_store, apol, ngraham
Cc: plasma-devel, #discover_software_store, jraleigh, bam, GB_2, ragreen, 
ixoos, Pitel, ZrenBot, James, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D19561: Don't crash if the fwupd error is null

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.


  Cool, thanks! remember to land in 5.15.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D19561

To: leinir, #discover_software_store, apol, ngraham
Cc: plasma-devel, #discover_software_store, jraleigh, bam, GB_2, ragreen, 
ixoos, Pitel, ZrenBot, James, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11352: [RFC] Auto ordered systray

[Nathaniel Graham]

ngraham added a comment.


  @pitel, I'm sorry this has been sitting for so long! We'd like to land this 
but it no longer merges cleanly on master. Can you rebase it please?

REPOSITORY
  R120 Plasma Workspace

BRANCH
  stableSystray2

REVISION DETAIL
  https://phabricator.kde.org/D11352

To: Pitel, #vdg, #plasma, mart
Cc: ognarb, ngraham, wsdfhjxc, mart, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D19560: [Desktop Sessions KCM] Add Restart to BIOS/UEFI checkbox

[Kai Uwe Broulik]

broulik updated this revision to Diff 53279.
broulik edited the test plan for this revision.
broulik added a comment.


  - Simplify, totally didn't realize the "impl" was just a UI subclass, just 
access its controls directly from the kcm class
  - Add "Restart Now" button to message widget
  - Drop icon on checkbox

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19560?vs=53267&id=53279

REVISION DETAIL
  https://phabricator.kde.org/D19560

AFFECTED FILES
  kcms/ksmserver/kcmsmserver.cpp
  kcms/ksmserver/kcmsmserver.h
  kcms/ksmserver/smserverconfigdlg.ui
  kcms/ksmserver/smserverconfigimpl.cpp
  kcms/ksmserver/smserverconfigimpl.h

To: broulik, #plasma, #vdg
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19566: [OSD] Fix animation stutter

[Krešimir Čohar]

rooty created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
rooty requested review of this revision.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  osd-effect-fix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19566

AFFECTED FILES
  lookandfeel/contents/osd/Osd.qml

To: rooty
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19560: [Desktop Sessions KCM] Add Restart to BIOS/UEFI checkbox

[Kai Uwe Broulik]

broulik updated this revision to Diff 53267.
broulik retitled this revision from "[Desktop Sessions KCM] Add Reboot to 
BIOS/UEFI checkbox" to "[Desktop Sessions KCM] Add Restart to BIOS/UEFI 
checkbox".
broulik added a comment.


  - Change wording to "restarted" instead of rebooted and talk about computers, 
not systems

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19560?vs=53261&id=53267

REVISION DETAIL
  https://phabricator.kde.org/D19560

AFFECTED FILES
  kcms/ksmserver/kcmsmserver.cpp
  kcms/ksmserver/kcmsmserver.h
  kcms/ksmserver/smserverconfigdlg.ui
  kcms/ksmserver/smserverconfigimpl.cpp
  kcms/ksmserver/smserverconfigimpl.h

To: broulik, #plasma, #vdg
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19562: [Logout Screen] Show info that rebooting will enter firmware setup

[Kai Uwe Broulik]

broulik updated this revision to Diff 53265.
broulik added a comment.


  Use "restarted" instead of rebooted, just saw that we use the former now :)

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19562?vs=53262&id=53265

REVISION DETAIL
  https://phabricator.kde.org/D19562

AFFECTED FILES
  logout-greeter/shutdowndlg.cpp
  lookandfeel/contents/logout/Logout.qml

To: broulik, #plasma, #vdg
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19562: [Logout Screen] Show info that rebooting will enter firmware setup

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  When the flag to reboot into BIOS/UEFI setup is set, show a hint on the 
logout screen.
  For simplicity and to avoid the layout from shifting, and since the user had 
to explicitly enable the flag and probably know what they're doing, it is shown 
regardless of what action is highlighted.

TEST PLAN
  See D19560 
  
  Suggestions on wording welcome
  
  F6662377: Screenshot_20190306_115112.png 


REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19562

AFFECTED FILES
  logout-greeter/shutdowndlg.cpp
  lookandfeel/contents/logout/Logout.qml

To: broulik, #plasma, #vdg
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19561: Don't crash if the fwupd error is null

[Dan Leinir Turthra Jensen]

leinir created this revision.
leinir added reviewers: Discover Software Store, apol, ngraham.
leinir added a project: Discover Software Store.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
leinir requested review of this revision.

REVISION SUMMARY
  I got a difficult-to-reproduce crash, which pointed at the fact that this 
error can, at times, be null. Without the validity check this patch introduces, 
we then attempted to deref that null pointer, and crashed.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D19561

AFFECTED FILES
  libdiscover/backends/FwupdBackend/FwupdBackend.cpp

To: leinir, #discover_software_store, apol, ngraham
Cc: plasma-devel, #discover_software_store, jraleigh, bam, GB_2, ragreen, 
ixoos, Pitel, ZrenBot, James, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D19560: [Desktop Sessions KCM] Add Reboot to BIOS/UEFI checkbox

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  This sets a logind flag that tells the system to boot into the BIOS/UEFI 
setup screen on next boot.
  It can be quite a challenge to enter the setup screen on boot these days as 
with quick boot and what not the timeframe for the keypress is often quite 
narrow.

TEST PLAN
  - Checked checkbox, entered my password, rebooted, ended up in UEFI screen
  - When opening the checkbox reflects the state of the flag (e.g. checking, 
closing, opening will keep the checkbox checked so you can unset the flag again)
  - Unchecked checkbox, entered my password, flag was unset
  - Checkbox is only shown if supported
  - Checks for UEFI and shows "UEFI" instead of generic "Firmware" labels, not 
sure if that stuff actually works when you didn't set up your machine as UEFI 
boot
  
  I originally considered adding a dropdown to logout screen or some context 
menu action in the app launcher but since this is quite a niche task to do it's 
fine to have it in systemsettings somewhere imho.
  
  Checkbox with tooltip
  F6662353: Screenshot_20190306_114421.png 

  After typing the password when having checked it
  F6662355: Screenshot_20190306_114434.png 

  
  Suggestions on wording welcome

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19560

AFFECTED FILES
  kcms/ksmserver/kcmsmserver.cpp
  kcms/ksmserver/kcmsmserver.h
  kcms/ksmserver/smserverconfigdlg.ui
  kcms/ksmserver/smserverconfigimpl.cpp
  kcms/ksmserver/smserverconfigimpl.h

To: broulik, #plasma, #vdg
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart