D23112: Add a event Spy for GtkFileChooser recent files

[Méven Car]

meven updated this revision to Diff 63890.
meven added a comment.


  Ensure the log category is exported, compare only chars, variable naming fix

REPOSITORY
  R161 KActivity Manager Service

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23112?vs=63830&id=63890

BRANCH
  arcpatch-D23112

REVISION DETAIL
  https://phabricator.kde.org/D23112

AFFECTED FILES
  kactivitymanagerd.categories
  src/service/plugins/CMakeLists.txt
  src/service/plugins/gtk-eventspy/CMakeLists.txt
  src/service/plugins/gtk-eventspy/GtkEventSpy.cpp
  src/service/plugins/gtk-eventspy/GtkEventSpy.h
  src/service/plugins/gtk-eventspy/kactivitymanagerd-plugin-gtk-eventspy.json

To: meven, #frameworks, ivan
Cc: bruns, ngraham, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12827: Added process details in the process list context menu

[Chris Xiong]

chrisx added a comment.


  In D12827#513118 , @meven wrote:
  
  > I quite like this feature @chrisx
  >  I hope you can still push it forward after all this time.
  
  
  I'll definitely update the patch if the maintainers show more interest in 
merging. After all I don't really like the idea of having WebKit (back when the 
patch was authored) or Chromium in my system monitor in order to view memory 
details.
  ... and I have to admit that my code style is a complete mess. I'll fix it in 
the next patch (if there is one).

REPOSITORY
  R111 KSysguard Library

REVISION DETAIL
  https://phabricator.kde.org/D12827

To: chrisx, broulik, davidedmundson
Cc: meven, garywang, broulik, davidedmundson, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23112: Add a event Spy for GtkFileChooser recent files

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> ivan wrote in GtkEventSpy.cpp:126
> No need to compare chars with strings:
> 
>   if (!exec.isEmpty() && exec[0] == '\'' && exec.back() == '\'')

missing `QChar('\'')`, otherwise it breaks with QT_NO_CAST_FROM_ASCII

-> `if (exec.startsWith(QChar('\'') && exec.endsWith(QChar('\'')) {...`

> GtkEventSpy.cpp:144
> +// remove space and any caracter after
> +const int spaceIdex = exec.indexOf(" ");
> +if (spaceIdex != -1) {

`spaceI_n_dex`

REPOSITORY
  R161 KActivity Manager Service

REVISION DETAIL
  https://phabricator.kde.org/D23112

To: meven, #frameworks, ivan
Cc: bruns, ngraham, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23081: remove references from the icon qrc to missing icons.

[Camilo Higuita]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:b3ffca1363b1: remove references from the icon qrc to 
missing icons. (authored by camiloh).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23081?vs=63518&id=63889

REVISION DETAIL
  https://phabricator.kde.org/D23081

AFFECTED FILES
  kirigami-icons.qrc

To: camiloh, #kirigami, mart
Cc: plasma-devel, fbampaloukas, domson, dkardarakos, apol, davidedmundson, 
mart, hein

Fwd: KDE CI: Administration » Dependency Build Plasma stable-kf5-qt5 SUSEQt5.12 - Build # 50 - Still Failing!

[Ben Cooksley]

Hi all,

Please see below - can someone take a look at the below build failure?

Thanks,
Ben

-- Forwarded message -
From: CI System 
Date: Sat, Aug 17, 2019 at 10:05 AM
Subject: KDE CI: Administration » Dependency Build Plasma stable-kf5-qt5
SUSEQt5.12 - Build # 50 - Still Failing!
To: 


*BUILD FAILURE*
Build URL
https://build.kde.org/job/Administration/job/Dependency%20Build%20Plasma%20stable-kf5-qt5%20SUSEQt5.12/50/
Project: Dependency Build Plasma stable-kf5-qt5 SUSEQt5.12
Date of build: Fri, 16 Aug 2019 21:10:18 +
Build duration: 54 min and counting
* CONSOLE OUTPUT *
[...truncated 95758 lines...]
[2019-08-16T22:04:46.984Z] [ 95%] Building CXX object
dataengines/statusnotifieritem/CMakeFiles/plasma_engine_statusnotifieritem.dir/statusnotifierwatcher_interface.cpp.o
[2019-08-16T22:04:46.984Z] [ 95%] Building CXX object
dataengines/statusnotifieritem/CMakeFiles/plasma_engine_statusnotifieritem.dir/dbusproperties.cpp.o
[2019-08-16T22:04:46.984Z] [ 95%] Built target klipper
[2019-08-16T22:04:46.984Z] Scanning dependencies of target kcminit_autogen
[2019-08-16T22:04:46.984Z] [ 96%] Automatic MOC for target kcminit
[2019-08-16T22:04:47.240Z] [ 96%] Built target kcminit_autogen
[2019-08-16T22:04:47.240Z] [ 96%] Building CXX object
dataengines/statusnotifieritem/CMakeFiles/plasma_engine_statusnotifieritem.dir/statusnotifieritem_interface.cpp.o
[2019-08-16T22:04:47.240Z] [ 96%] Built target notification_test
[2019-08-16T22:04:47.240Z] [ 96%] Building CXX object
dataengines/statusnotifieritem/CMakeFiles/plasma_engine_statusnotifieritem.dir/debug.cpp.o
[2019-08-16T22:04:47.494Z] [ 96%] Linking CXX shared module
../bin/appmenu.so
[2019-08-16T22:04:47.494Z] [ 96%] Building CXX object
components/sessionsprivate/CMakeFiles/sessionsprivateplugin.dir/sessionsmodel.cpp.o
[2019-08-16T22:04:47.751Z] [ 97%] Building CXX object
components/sessionsprivate/CMakeFiles/sessionsprivateplugin.dir/sessionsprivateplugin.cpp.o
[2019-08-16T22:04:47.751Z] [ 97%] Building CXX object
components/sessionsprivate/CMakeFiles/sessionsprivateplugin.dir/screensaver_interface.cpp.o
[2019-08-16T22:04:48.009Z] [ 97%] Built target appmenu
[2019-08-16T22:04:48.009Z] [ 97%] Building CXX object
components/sessionsprivate/CMakeFiles/sessionsprivateplugin.dir/kscreensaversettings.cpp.o
[2019-08-16T22:04:48.266Z] Scanning dependencies of target
kcminit_startup_autogen
[2019-08-16T22:04:48.266Z] [ 97%] Automatic MOC for target kcminit_startup
[2019-08-16T22:04:48.266Z] [ 97%] Built target kcminit_startup_autogen
[2019-08-16T22:04:48.266Z] Scanning dependencies of target
testChromeBookmarks
[2019-08-16T22:04:48.266Z] [ 97%] Building CXX object
runners/bookmarks/tests/CMakeFiles/testChromeBookmarks.dir/testChromeBookmarks_autogen/mocs_compilation.cpp.o
[2019-08-16T22:04:48.522Z] Scanning dependencies of target servicerunnertest
[2019-08-16T22:04:48.522Z] [ 97%] Building CXX object
runners/services/autotests/CMakeFiles/servicerunnertest.dir/servicerunnertest_autogen/mocs_compilation.cpp.o
[2019-08-16T22:04:48.522Z] [ 97%] Building CXX object
runners/services/autotests/CMakeFiles/servicerunnertest.dir/servicerunnertest.cpp.o
[2019-08-16T22:04:48.777Z] Scanning dependencies of target krunner_kill
[2019-08-16T22:04:48.777Z] [ 97%] Building CXX object
runners/kill/CMakeFiles/krunner_kill.dir/krunner_kill_autogen/mocs_compilation.cpp.o
[2019-08-16T22:04:48.777Z] [ 97%] Linking CXX executable
../../bin/nightcolortest
[2019-08-16T22:04:48.777Z] [ 97%] Building CXX object
runners/bookmarks/tests/CMakeFiles/testChromeBookmarks.dir/testchromebookmarks.cpp.o
[2019-08-16T22:04:49.034Z] [ 97%] Linking CXX shared module
../../bin/plasma_engine_statusnotifieritem.so
[2019-08-16T22:04:49.034Z] [ 97%] Building CXX object
runners/kill/CMakeFiles/krunner_kill.dir/killrunner.cpp.o
[2019-08-16T22:04:49.292Z] Scanning dependencies of target
plasma_engine_geolocation
[2019-08-16T22:04:49.292Z] [ 97%] Building CXX object
dataengines/geolocation/CMakeFiles/plasma_engine_geolocation.dir/plasma_engine_geolocation_autogen/mocs_compilation.cpp.o
[2019-08-16T22:04:49.292Z] [ 97%] Built target nightcolortest
[2019-08-16T22:04:49.549Z] [ 97%] Building CXX object
dataengines/geolocation/CMakeFiles/plasma_engine_geolocation.dir/geolocation.cpp.o
[2019-08-16T22:04:49.549Z] [ 97%] Built target
plasma_engine_statusnotifieritem
[2019-08-16T22:04:49.805Z] Scanning dependencies of target
plasma-geolocation-ip
[2019-08-16T22:04:49.805Z] [ 97%] Building CXX object
dataengines/geolocation/CMakeFiles/plasma-geolocation-ip.dir/plasma-geolocation-ip_autogen/mocs_compilation.cpp.o
[2019-08-16T22:04:49.805Z] Scanning dependencies of target
plasma_engine_weather
[2019-08-16T22:04:49.805Z] [ 97%] Building CXX object
dataengines/weather/CMakeFiles/plasma_engine_weather.dir/plasma_engine_weather_autogen/mocs_compilation.cpp.o
[2019-08-16T22:04:49.805Z] [ 97%] Linking CXX shared library
../../bin/libsessionsprivateplugin.so
[2019-08-16T22:04:50.061Z] Scanning dependencies of target ion_b

D23112: Add a event Spy for GtkFileChooser recent files

[Ivan Čukić]

ivan requested changes to this revision.
ivan added a comment.
This revision now requires changes to proceed.


  Another tiny change, and I think it is ready to land. Unless someone else 
sees other issues.

INLINE COMMENTS

> GtkEventSpy.cpp:126
> +
> +if (exec.at(0) == QStringLiteral("'") && exec.at(exec.size() - 1) == 
> QStringLiteral("'")) {
> +// remove "'" caracters wrapping the command

No need to compare chars with strings:

  if (!exec.isEmpty() && exec[0] == '\'' && exec.back() == '\'')

REPOSITORY
  R161 KActivity Manager Service

REVISION DETAIL
  https://phabricator.kde.org/D23112

To: meven, #frameworks, ivan
Cc: ngraham, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23170: Fix colors from KStatefulBrushes not using application colorschemes

[Nathaniel Graham]

ngraham added a subscriber: hpereiradacosta.
ngraham added a comment.


  Looking back at the quality of my last Breeze review, maybe @hpereiradacosta 
could have a go. :)

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D23170

To: ndavis, #vdg, #breeze
Cc: hpereiradacosta, mglb, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23170: Fix colors from KStatefulBrushes not using application colorschemes

[Noah Davis]

ndavis added a comment.


  Anyone want to accept this?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D23170

To: ndavis, #vdg, #breeze
Cc: mglb, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23169: Fix width and separator of ToolButtonComplexControl outline w/ dropdown menu

[Hugo Pereira Da Costa]

hpereiradacosta added a comment.


  Thanks !

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D23169

To: ndavis, #vdg, #breeze, ngraham, hpereiradacosta
Cc: hpereiradacosta, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23169: Fix width and separator of ToolButtonComplexControl outline w/ dropdown menu

[Noah Davis]

ndavis abandoned this revision.
ndavis added a comment.


  Alright, problem fixed.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D23169

To: ndavis, #vdg, #breeze, ngraham, hpereiradacosta
Cc: hpereiradacosta, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23169: Fix width and separator of ToolButtonComplexControl outline w/ dropdown menu

[Noah Davis]

ndavis added a comment.


  In D23169#513046 , 
@hpereiradacosta wrote:
  
  > Hi Noah
  >  Thanks for the patch, however, it is not the right fix to the issue. If 
you use a light color scheme (like the default breeze), you will see that the 
shadow below the part of the button that corresponds to the arrow is darker 
than below the rest of the button. This is because the frame is actually 
rendered twice.
  >
  > Now, the bug you try to fix is real, and as I was 100% sure that it was not 
there in the past, I used git bisect to track it down to this commit:
  >
  > 32d8b02880a237e6de415861500a018a5cd09781 

  >
  > The corresponding diff contains 
  >  @@ -5988,7 +5988,6 @@ namespace Breeze
  >
  >   // frame
  >   if( toolButtonOption->subControls & SC_ToolButton )
  >   {
  >
  > - copy.rect = buttonRect; if( inTabBar ) 
drawTabBarPanelButtonToolPrimitive( ©, painter, widget ); else 
drawPrimitive( PE_PanelButtonTool, ©, painter, widget); }
  >
  >   Which is what causes the issue. Could you revert this commit, and push 
instead the proper fix that I will post in another comment ?
  >
  >   Alternatively, I can do it myself. Note that your changes on the 
separator position is legit, but should be a different patch
  
  
  Sure, thanks for the help.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D23169

To: ndavis, #vdg, #breeze, ngraham, hpereiradacosta
Cc: hpereiradacosta, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23152: [energy kcm] Display Vendor and model

[Nathaniel Graham]

ngraham added a comment.


  "Manufacturer" is fine IMO. If it needs to be changed, maybe "Vendor" or 
"Hardware"

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D23152

To: meven, broulik, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23169: Fix width and separator of ToolButtonComplexControl outline w/ dropdown menu

[Noah Davis]

ndavis added a comment.


  In D23169#513071 , 
@hpereiradacosta wrote:
  
  > Zoom showing the issue mentionned above with the "current" patch (or master 
branch of breeze)
  >
  > F7250494: Screenshot_20190816_175237.png 

  >
  > How it should look: 
  >  F7250505: Screenshot_20190816_175628.png 

  
  
  Whoops. Is that a double shadow?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D23169

To: ndavis, #vdg, #breeze, ngraham, hpereiradacosta
Cc: hpereiradacosta, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23152: [energy kcm] Display Vendor and model

[Méven Car]

meven added a comment.


  For reference in GNOME, the equivalent feature looks like :
  https://i.stack.imgur.com/V7Fpk.png
  
  I would be in favor of rename the "Manufacturer" section to "Manufacturing" 
or "Part" or "Component".

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D23152

To: meven, broulik, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23198: Skip mime type check only for files on network mounts

[Méven Car]

meven added a comment.


  For reference in GNOME, the equivalent feature looks like :
  https://i.stack.imgur.com/V7Fpk.png

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23198

To: meven, #plasma, dfaure
Cc: ngraham, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12827: Added process details in the process list context menu

[Méven Car]

meven added a comment.


  I quite like this feature @chrisx
  I hope you can still push it forward after all this time.

INLINE COMMENTS

> DetailsDlg.cpp:1
> +/*
> + KSysGuard, the KDE System Guard

Personally I would favor a class name with no abbreviation, here DetailsDialog, 
and here perhaps make it more explicit like ProcessDetailsDialog.

> ksysguardprocesslist.cpp:205
>  renice->setShortcut(Qt::Key_F8);
> + details = new QAction(i18n("Process Details..."), q);
>  selectParent = new QAction(i18n("Jump to Parent Process"), q);

Indentation seems off.

> ksysguardprocesslist.cpp:1225
> + QList processes = selectedProcesses();
> + if(processes.size()!=1)return;
> + QPointer detailsdlg=new 
> DetailsDlg(processes.first()->pid(),processModel(),d->mUi->treeView);

if (processes.size() != 1) {

  return;

}
You can try to use uncrustify-kf5 to 
(https://github.com/KDE/kde-dev-scripts/blob/master/uncrustify-kf5) to solve 
code style and indentation issues.
It works on whole directories only, so you might want to use `uncrustify-kf5; 
git commit --amend --no-edit [files part you are adding/touching] ; git 
checkout .`

REPOSITORY
  R111 KSysguard Library

REVISION DETAIL
  https://phabricator.kde.org/D12827

To: chrisx, broulik, davidedmundson
Cc: meven, garywang, broulik, davidedmundson, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23198: Skip mime type check only for files on network mounts

[Méven Car]

meven added a comment.


  In D23198#512999 , @ngraham wrote:
  
  > In D23198#512942 , @broulik 
wrote:
  >
  > > `fileSystemType` calls `statvfs` which might also block, so I don't think 
this helps.
  >
  >
  > True, but then that implies that `KFileItem::isSlow()` which has the same 
code is flawed in the same way.
  
  
  Well I had the same reflection in https://phabricator.kde.org/D19784#503088 
but after reflection it is ok :
  
  A file whose filesystem is not mounted, is a non-existing file which statvfs 
report as its error ENOENT http://man7.org/linux/man-pages/man3/statvfs.3.html
  I still have to test it at home where I have a nfs setup.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23198

To: meven, #plasma, dfaure
Cc: ngraham, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22896: Port System Settings sidebar to QQC2

[Björn Feber]

GB_2 updated this revision to Diff 63872.
GB_2 added a comment.


  Address comments

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22896?vs=63827&id=63872

BRANCH
  arcpatch-D22896

REVISION DETAIL
  https://phabricator.kde.org/D22896

AFFECTED FILES
  app/SettingsBase.cpp
  sidebar/SidebarMode.cpp
  sidebar/SidebarMode.h
  sidebar/package/contents/ui/ActionMenu.qml
  sidebar/package/contents/ui/CategoriesPage.qml
  sidebar/package/contents/ui/IntroIcon.qml
  sidebar/package/contents/ui/SubCategoryPage.qml
  sidebar/package/contents/ui/introPage.qml
  sidebar/package/contents/ui/main.qml

To: GB_2, #plasma, #vdg, ngraham, mart
Cc: mart, filipf, ngraham, broulik, #vdg, plasma-devel, #plasma, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D23169: Fix width and separator of ToolButtonComplexControl outline w/ dropdown menu

[Hugo Pereira Da Costa]

hpereiradacosta added a comment.


  Zoom showing the issue mentionned above with the "current" patch (or master 
branch of breeze)
  
  F7250494: Screenshot_20190816_175237.png 

  
  How it should look: 
  F7250505: Screenshot_20190816_175628.png 


REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D23169

To: ndavis, #vdg, #breeze, ngraham, hpereiradacosta
Cc: hpereiradacosta, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23169: Fix width and separator of ToolButtonComplexControl outline w/ dropdown menu

[Hugo Pereira Da Costa]

hpereiradacosta reopened this revision.
hpereiradacosta added a comment.
This revision is now accepted and ready to land.


  F7250479: patch.diff 

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D23169

To: ndavis, #vdg, #breeze, ngraham
Cc: hpereiradacosta, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23169: Fix width and separator of ToolButtonComplexControl outline w/ dropdown menu

[Hugo Pereira Da Costa]

hpereiradacosta added a comment.


  Hi Noah
  Thanks for the patch, however, it is not the right fix to the issue. If you 
use a light color scheme (like the default breeze), you will see that the 
shadow below the part of the button that corresponds to the arrow is darker 
than below the rest of the button. This is because the frame is actually 
rendered twice.
  
  Now, the bug you try to fix is real, and as I was 100% sure that it was not 
there in the past, I used git bisect to track it down to this commit:
  
  32d8b02880a237e6de415861500a018a5cd09781 

  
  The corresponding diff contains 
  @@ -5988,7 +5988,6 @@ namespace Breeze
  
// frame
if( toolButtonOption->subControls & SC_ToolButton )
{
  
  - copy.rect = buttonRect; if( inTabBar ) drawTabBarPanelButtonToolPrimitive( 
©, painter, widget ); else drawPrimitive( PE_PanelButtonTool, ©, 
painter, widget); }
  
  Which is what causes the issue. 
  Could you revert this commit, and push instead the proper fix that I will 
post in another comment ? 
  Thanks !

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D23169

To: ndavis, #vdg, #breeze, ngraham
Cc: hpereiradacosta, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23198: Skip mime type check only for files on network mounts

[Nathaniel Graham]

ngraham added a comment.


  In D23198#512942 , @broulik wrote:
  
  > `fileSystemType` calls `statvfs` which might also block, so I don't think 
this helps.
  
  
  True, but then that implies that `KFileItem::isSlow()` which has the same 
code is flawed in the same way.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23198

To: meven, #plasma, dfaure
Cc: ngraham, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23198: Skip mime type check only for files on network mounts

[Méven Car]

meven updated this revision to Diff 63859.
meven added a comment.


  Use toLocalFile() instead of path()

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23198?vs=63855&id=63859

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23198

AFFECTED FILES
  applets/kicker/plugin/recentusagemodel.cpp

To: meven, #plasma, dfaure
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22896: Port System Settings sidebar to QQC2

[Kai Uwe Broulik]

broulik added a comment.


  Working very nice now! Just some minor nitpicks then this can go in

INLINE COMMENTS

> SidebarMode.h:54
>  Q_PROPERTY(int width READ width NOTIFY widthChanged)
> +Q_PROPERTY(bool actionMenuVisible READ actionMenuVisible WRITE 
> setActionMenuVisible NOTIFY actionMenuVisibleChanged)
>  

Doesn't need a `WRITE` as it is internal

> SidebarMode.h:77
> +bool actionMenuVisible() const;
> +void setActionMenuVisible(const bool &actionMenuVisible);
> +

Make the setter `private`

> SidebarMode.h:107
>  Private *const d;
> +bool m_actionMenuVisible = false;
>  };

Move this to the `Private` class

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D22896

To: GB_2, #plasma, #vdg, ngraham, mart
Cc: mart, filipf, ngraham, broulik, #vdg, plasma-devel, #plasma, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D17464: [Timer applet] Minor fixes for the applet

[Alexander Kernozhitsky]

gepardo added a comment.


  ping @davidedmundson

REPOSITORY
  R114 Plasma Addons

BRANCH
  arcpatch-D17464

REVISION DETAIL
  https://phabricator.kde.org/D17464

To: gepardo, muhlenpfordt, mmazur, friedreich, #plasma, ngraham
Cc: ngraham, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23198: Skip mime type check only for files on network mounts

[Kai Uwe Broulik]

broulik added a comment.


  `fileSystemType` calls `statvfs` which might also block, so I don't think 
this helps.

INLINE COMMENTS

> recentusagemodel.cpp:252
> +// taken from kfileitem::isSlow
> +const KFileSystemType::Type fsType = 
> KFileSystemType::fileSystemType(url.path());
> +if ((fsType == KFileSystemType::Nfs || fsType == 
> KFileSystemType::Smb)) {

`toLocalFile()` instead of `path()`

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23198

To: meven, #plasma, dfaure
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23198: Skip mime type check only for files on network mounts

[Méven Car]

meven created this revision.
meven added reviewers: Plasma, dfaure.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
meven requested review of this revision.

REVISION SUMMARY
  Related diff D19784 
  
  BUG: 401579

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23198

AFFECTED FILES
  applets/kicker/plugin/recentusagemodel.cpp

To: meven, #plasma, dfaure
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

KDE CI: Plasma » breeze » kf5-qt5 FreeBSDQt5.13 - Build # 10 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/breeze/job/kf5-qt5%20FreeBSDQt5.13/10/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Fri, 16 Aug 2019 10:23:40 +
 Build duration:
2 min 16 sec and counting

D23125: fix bridge master:slave mapping by-name

[Jan Grulich]

jgrulich added a comment.


  The parent knows the connection id, if you look into 
ConnectionEditorBase::initialize(), then you can get the id using
  
"m_connection->id()"
  
  You can add additional **masterId** parameter so you don't need to go through 
the whole connection list to get the id.  Also, this same improvement can be 
done in BondWidget and TeamWidget, where very same code is used (if would be so 
kind to do so :) )

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D23125

To: sitter, jgrulich
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22774: In the note applet, always paste without formatting by default. Add an action to paste preserving formatting in the contextual menu.

[Luca Carlon]

luc4 added a comment.


  Ping.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D22774

To: luc4, davidedmundson, #plasma
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22458: [sddm-theme] Add slot to configure a logo to be shown on the SDDM login screen

[Björn Feber]

GB_2 added a comment.


  Ping.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  distro-logo-slot (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22458

To: cblack, #vdg, #plasma, filipf, ngraham
Cc: GB_2, Codezela, filipf, davidedmundson, broulik, ngraham, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23158: [Kickoff] Improve appearance of draggable button grid in settings window

[Björn Feber]

GB_2 accepted this revision as: VDG, GB_2.
GB_2 added a comment.


  Visually +1

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23158

To: ngraham, #vdg, #plasma, davidedmundson, GB_2
Cc: GB_2, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart