D24127: Fix toggle button colours

[Nathaniel Graham]

ngraham added a comment.


  I think this patch needs some changes (outlined above).

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D24127

To: cblack, #breeze, ndavis, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24127: Fix toggle button colours

[Noah Davis]

ndavis added a comment.


  Friendly ping. It would be nice to have this in 5.17.1

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D24127

To: cblack, #breeze, ndavis, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24127: Fix toggle button colours

[Noah Davis]

ndavis added a comment.


  In D24127#536672 , @ngraham wrote:
  
  > @cblack if we're going to use this patch to do that, then the same 
treatment needs to be done for other buttonlike controls like comboboxes (with 
and without text entry), font buttons, file picker buttons, etc. Also I feel 
like maybe the border thickness of the highlight could stand to be increased so 
it's more visible.
  >
  > @ndavis, if we're going to do this, can you make the same change in Breeze 
itself so the themes are consistent?
  
  
  Yes

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D24127

To: cblack, #breeze, ndavis, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24127: Fix toggle button colours

[Nathaniel Graham]

ngraham added a comment.


  @cblack if we're going to use this patch to do that, then the same treatment 
needs to be done for other buttonlike controls like comboboxes (with and 
without text entry), font buttons, file picker buttons, etc. Also I feel like 
maybe the border thickness of the highlight could stand to be increased so it's 
more visible.
  
  @noahdvs, if we're going to do this, can you make the same change in Breeze 
itself so the themes are consistent?

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D24127

To: cblack, #breeze, ndavis, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24127: Fix toggle button colours

[Carson Black]

cblack updated this revision to Diff 66712.
cblack added a comment.


  Substitute border decoration for fill decoration

REPOSITORY
  R98 Breeze for Gtk

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24127?vs=66574&id=66712

BRANCH
  fix-toggle-state (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24127

AFFECTED FILES
  src/gtk3/widgets/_button.scss

To: cblack, #breeze, ndavis, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24127: Fix toggle button colours

[Noah Davis]

ndavis added a comment.


  In D24127#535826 , @cblack wrote:
  
  > In D24127#53 , @ndavis wrote:
  >
  > > @cblack Can you change the focus state to only have a blue outline? This 
behavior is really confusing, even though it seems consistent with Breeze: 
-snip-
  >
  >
  > I'd rather not diverge from the Breeze here for a few reasons:
  >
  > - I don't have a guarantee that Breeze is going to have the exact same 
change
  > - Breeze GTK is supposed to look like the current state of Breeze, with 
adaptations where necessary due to differences between GTK and Qt
  >
  >   If Breeze gets the change, I'll add it.
  
  
  If I can
  
  In D24127#535826 , @cblack wrote:
  
  > In D24127#53 , @ndavis wrote:
  >
  > > @cblack Can you change the focus state to only have a blue outline? This 
behavior is really confusing, even though it seems consistent with Breeze: 
-snip-
  >
  >
  > I'd rather not diverge from the Breeze here for a few reasons:
  >
  > - I don't have a guarantee that Breeze is going to have the exact same 
change
  > - Breeze GTK is supposed to look like the current state of Breeze, with 
adaptations where necessary due to differences between GTK and Qt
  >
  >   If Breeze gets the change, I'll add it.
  
  
  I will do the same thing to Breeze if I ever find an example of a situation 
where a focusable and toggleable button exists with the same usability issue. 
We do have a real example where this usability issue happens with GTK, so I 
think it's best to do this now instead of later.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D24127

To: cblack, #breeze, ndavis, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24127: Fix toggle button colours

[Nathaniel Graham]

ngraham added a comment.


  Weird, this happens with the regular old breeze color scheme for me.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D24127

To: cblack, #breeze, ndavis, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24127: Fix toggle button colours

[Carson Black]

cblack added a comment.


  In D24127#535551 , @ngraham shared 
an image:
  
  > F7398590: Screenshot_20190920_194959.png 

  
  
  That doesn't match the color of what I have on my machine.
  F7405543: image.png 

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D24127

To: cblack, #breeze, ndavis, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24127: Fix toggle button colours

[Carson Black]

cblack added a comment.


  In D24127#53 , @ndavis wrote:
  
  > @cblack Can you change the focus state to only have a blue outline? This 
behavior is really confusing, even though it seems consistent with Breeze: 
F7398663: gtk_togglebuttons-2019-09-20_21.55.35.webm 

  
  
  I'd rather not diverge from the Breeze here for a few reasons:
  
  - I don't have a guarantee that Breeze is going to have the exact same change
  - Breeze GTK is supposed to look like the current state of Breeze, with 
adaptations where necessary due to differences between GTK and Qt
  
  If Breeze gets the change, I'll add it.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D24127

To: cblack, #breeze, ndavis, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24127: Fix toggle button colours

[Nathaniel Graham]

ngraham added a comment.


  Yeah, it's definitely more obvious in Breeze dark, but I've always felt that 
a more colorful color was appropriate for the default button. Maybe it's just 
my history in macOS, where it's been like that for 20 years, but I've always 
appreciated being able to visually pick out in an instant what button the 
programmers wanted to highlight as the obvious or safe choice. GNOME does this 
too in some apps, using a bright blue button color to help guide you through a 
UI. See SimpleScan for example.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D24127

To: cblack, #breeze, ndavis, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24127: Fix toggle button colours

[Noah Davis]

ndavis added a comment.


  In D24127#535558 , @ngraham wrote:
  
  > In D24127#53 , @ndavis wrote:
  >
  > > This behavior is really confusing, even though it seems consistent with 
Breeze
  >
  >
  > I really dislike this about Breeze itself and would welcome a fix there 
too. Then maybe we can make the default button actually be blue, rather than an 
almost-indistinguishable shade of gray (See 
https://bugs.kde.org/show_bug.cgi?id=386158).
  
  
  This is because the default button uses the View Background color. On Breeze 
Dark, the default button is much more obvious: F7398712: 
Screenshot_20190920_220117.png 

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D24127

To: cblack, #breeze, ndavis, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24127: Fix toggle button colours

[Nathaniel Graham]

ngraham added a comment.


  In D24127#53 , @ndavis wrote:
  
  > This behavior is really confusing, even though it seems consistent with 
Breeze
  
  
  I really dislike this about Breeze itself and would welcome a fix there too. 
Then maybe we can make the default button actually be blue, rather than an 
almost-indistinguishable shade of gray (See 
https://bugs.kde.org/show_bug.cgi?id=386158).

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D24127

To: cblack, #breeze, ndavis, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24127: Fix toggle button colours

[Noah Davis]

ndavis added a comment.


  In the beginning of the video where it looks like I'm just hovering, I'm 
actually clicking once a second.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D24127

To: cblack, #breeze, ndavis, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24127: Fix toggle button colours

[Noah Davis]

ndavis added a comment.


  @cblack Can you change the focus state to only have a blue outline? This 
behavior is really confusing, even though it seems consistent with Breeze: 
F7398663: gtk_togglebuttons-2019-09-20_21.55.35.webm 


REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D24127

To: cblack, #breeze, ndavis, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24127: Fix toggle button colours

[Noah Davis]

ndavis added a comment.


  Ah, I only tested Breeze Dark, which uses the same white text color for 
everything.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D24127

To: cblack, #breeze, ndavis, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24127: Fix toggle button colours

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  I was actually just about to report this, hah. The text color for the checked 
state looks too light for Breeze and Breeze light though: F7398590: 
Screenshot_20190920_194959.png 
  
  The Breeze Widget theme has this using a dark text color instead of a light 
one. The color appears to be correct for Breeze Dark though.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D24127

To: cblack, #breeze, ndavis, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24127: Fix toggle button colours

[Carson Black]

cblack created this revision.
cblack added a reviewer: Breeze.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
cblack requested review of this revision.

REVISION SUMMARY
  Toggle button colors are now correct.

REPOSITORY
  R98 Breeze for Gtk

BRANCH
  fix-toggle-state (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24127

AFFECTED FILES
  src/gtk3/widgets/_button.scss

To: cblack, #breeze
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart