Re: [pulseaudio-discuss] [PATCH] fix two warnings in utils/padsp.c

[Maarten Bosmans]

2011/10/20 Arun Raghavan :
> On Tue, 2011-10-18 at 14:48 +0800, Lu Guanqun wrote:
>> CC     libpulsedsp_la-padsp.lo
>> utils/padsp.c:1524:5: warning: no previous prototype for '__open_2' 
>> [-Wmissing-prototypes]
>> utils/padsp.c:2560:5: warning: no previous prototype for '__open64_2' 
>> [-Wmissing-prototypes]
>> ---
>>  src/utils/padsp.c |    3 +++
>>  1 files changed, 3 insertions(+), 0 deletions(-)
>>
>> diff --git a/src/utils/padsp.c b/src/utils/padsp.c
>> index a8bc8d2..414ebe4 100644
>> --- a/src/utils/padsp.c
>> +++ b/src/utils/padsp.c
>> @@ -64,6 +64,9 @@
>>  #undef open
>>  #undef open64
>>
>> +int __open_2(const char *filename, int flags);
>> +int __open64_2(const char *filename, int flags);
>> +
>
> These two are defined a little later from where you've added them. Is
> this really present in master?

I also see these warnings from time to time, but not always. IIRC also
in master. But I haven't really been able to pinpoint exactly where
the problem lies. Until that time, I don't think just adding these is
a solution.

Maarten
___
pulseaudio-discuss mailing list
pulseaudio-discuss@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss

Re: [pulseaudio-discuss] [PATCH] fix two warnings in utils/padsp.c

[Arun Raghavan]

On Tue, 2011-10-18 at 14:48 +0800, Lu Guanqun wrote:
> CC libpulsedsp_la-padsp.lo
> utils/padsp.c:1524:5: warning: no previous prototype for '__open_2' 
> [-Wmissing-prototypes]
> utils/padsp.c:2560:5: warning: no previous prototype for '__open64_2' 
> [-Wmissing-prototypes]
> ---
>  src/utils/padsp.c |3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/src/utils/padsp.c b/src/utils/padsp.c
> index a8bc8d2..414ebe4 100644
> --- a/src/utils/padsp.c
> +++ b/src/utils/padsp.c
> @@ -64,6 +64,9 @@
>  #undef open
>  #undef open64
>  
> +int __open_2(const char *filename, int flags);
> +int __open64_2(const char *filename, int flags);
> +

These two are defined a little later from where you've added them. Is
this really present in master?

Cheers,
Arun

___
pulseaudio-discuss mailing list
pulseaudio-discuss@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss

[pulseaudio-discuss] [PATCH] fix two warnings in utils/padsp.c

[Lu Guanqun]

  CC libpulsedsp_la-padsp.lo
utils/padsp.c:1524:5: warning: no previous prototype for '__open_2' 
[-Wmissing-prototypes]
utils/padsp.c:2560:5: warning: no previous prototype for '__open64_2' 
[-Wmissing-prototypes]
---
 src/utils/padsp.c |3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/src/utils/padsp.c b/src/utils/padsp.c
index a8bc8d2..414ebe4 100644
--- a/src/utils/padsp.c
+++ b/src/utils/padsp.c
@@ -64,6 +64,9 @@
 #undef open
 #undef open64
 
+int __open_2(const char *filename, int flags);
+int __open64_2(const char *filename, int flags);
+
 typedef enum {
 FD_INFO_MIXER,
 FD_INFO_STREAM,

___
pulseaudio-discuss mailing list
pulseaudio-discuss@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss