Jira (PUP-5968) Deprecate Symbol#<=> monkey patch
Title: Message Title Eric Thompson updated an issue Puppet / PUP-5968 Deprecate Symbol#<=> monkey patch Change By: Eric Thompson QA Risk Assessment: Low Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5968) Deprecate Symbol#<=> monkey patch
Title: Message Title Eric Thompson updated an issue Puppet / PUP-5968 Deprecate Symbol#<=> monkey patch Change By: Eric Thompson QA Status: Reviewed Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5968) Deprecate Symbol#<=> monkey patch
Title: Message Title Michael Smith assigned an issue to qa Puppet / PUP-5968 Deprecate Symbol#<=> monkey patch Change By: Michael Smith Status: Ready for CI Test Assignee: qa Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5968) Deprecate Symbol#<=> monkey patch
Title: Message Title Branan Riley commented on PUP-5968 Re: Deprecate Symbol#<=> monkey patch I just saw the mention of --strict here. I agree that's worth doing in this case, and I can play with some (admittedly microbenchmarky) tests to see how bad it ends up being. I wonder if longer-term the right thing for us to do would be rewriting issue_deprecation_warning to use --strict to determine whether to warn, raise, or skip logging entirely. It already keeps track of where it's been called from to avoid duplicate log entries, so changing it to check Puppet[:strict] once we're past that duplicate check isn't going to be as horrifically expensive as checking at all the places we might have deprecated functionality Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5968) Deprecate Symbol#<=> monkey patch
Title: Message Title Branan Riley updated an issue Puppet / PUP-5968 Deprecate Symbol#<=> monkey patch Change By: Branan Riley Release Notes: Bug Fix Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5968) Deprecate Symbol#<=> monkey patch
Title: Message Title Henrik Lindberg commented on PUP-5968 Re: Deprecate Symbol#<=> monkey patch Branan Riley The way it is implemented now, --strict is above the deprecation warnings. There is a new "warn_once" that is better as the original deprecation warnings were designed for deprecation of ruby code. You can see how I implemented it for --strict_variables where it is also possible to turn of the specific issue in disabled_warnings. I find that I often want to use strict to control different logic depending on if it is warning, off or error. If off, do it the old way, if error, do it the sane way, and error for the specific deprecated condition, if warning, you may use the old logic with a warn_once etc. Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5968) Deprecate Symbol#<=> monkey patch
Title: Message Title Branan Riley updated an issue Puppet / PUP-5968 Deprecate Symbol#<=> monkey patch Change By: Branan Riley Release Notes Summary: Comparing symbols to strings (or other types) in Ruby code is deprecated. This functionality was provided by a monkey patch in a ruby dependency that Puppet no longer requires. Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5968) Deprecate Symbol#<=> monkey patch
Title: Message Title Josh Cooper commented on PUP-5968 Re: Deprecate Symbol#<=> monkey patch Thanks Henrik Lindberg for the reminder. I added the removal ticket in PUP-5973. My only concern about using --strict is whether that will have performance impact, e.g. is Symbol#<=> called during pson serialization? Is there a way to determine the value of the strict flag without calling into settings? Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5968) Deprecate Symbol#<=> monkey patch
Title: Message Title
Branan Riley updated an issue
Puppet / PUP-5968
Deprecate Symbol#<=> monkey patch
Change By:
Branan Riley
Comment:
I just saw the mention of {{--strict}} here. I agree that's worth doing in this case, and I can play with some (admittedly microbenchmarky) tests to see how bad it ends up being.I wonder if longer-term the right thing for us to do would be rewriting {{issue_deprecation_warning}} to use --strict to determine whether to warn, raise, or skip logging entirely. It already keeps track of where it's been called from to avoid duplicate log entries, so changing it to check {{Puppet[:strict]}} once we're past that duplicate check isn't going to be as horrifically expensive as checking at all the places we might have deprecated functionality
Add Comment
This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5968) Deprecate Symbol#<=> monkey patch
Title: Message Title Branan Riley assigned an issue to Branan Riley Puppet / PUP-5968 Deprecate Symbol#<=> monkey patch Change By: Branan Riley Assignee: Branan Riley Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5968) Deprecate Symbol#<=> monkey patch
Title: Message Title Branan Riley commented on PUP-5968 Re: Deprecate Symbol#<=> monkey patch I just saw the mention of --strict here. I agree that's worth doing in this case, and I can play with some (admittedly microbenchmarky) tests to see how bad it ends up being. I wonder if longer-term the right thing for us to do would be rewriting issue_deprecation_warning to use --strict to determine whether to warn, raise, or skip logging entirely. It already keeps track of where it's been called from to avoid duplicate log entries, so changing it to check Puppet[:strict] once we're past that duplicate check isn't going to be as horrifically expensive as checking at all the places we might have deprecated functionality Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5968) Deprecate Symbol#<=> monkey patch
Title: Message Title Branan Riley commented on PUP-5968 Re: Deprecate Symbol#<=> monkey patch Details on my quick benchmarking exercise are on teh hubz https://github.com/puppetlabs/puppet/pull/4796#issuecomment-198114762 Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5968) Deprecate Symbol#<=> monkey patch
Title: Message Title Branan Riley updated an issue Puppet / PUP-5968 Deprecate Symbol#<=> monkey patch Change By: Branan Riley Fix Version/s: PUP 4.x Fix Version/s: PUP 4.5.0 Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5968) Deprecate Symbol#<=> monkey patch
Title: Message Title Henrik Lindberg commented on PUP-5968 Re: Deprecate Symbol#<=> monkey patch I don't really know how costly it is to evaluate Puppet[:strict]. What we do in the parser is to look that up once when configuring validation. There is no other cheaper way that I know of, so if a setting lookup is expensive it needs to somehow be cached. (Then that has a cost naturally). Maybe do something special for cases like this; say you have to reboot the server to make the --strict setting take effect for this deprecation - then it is just the matter of doing a conditional monkeypatch. Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5968) Deprecate Symbol#<=> monkey patch
Title: Message Title Hailee Kenney assigned an issue to Unassigned Puppet / PUP-5968 Deprecate Symbol#<=> monkey patch Change By: Hailee Kenney Assignee: Hailee Kenney Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5968) Deprecate Symbol#<=> monkey patch
Title: Message Title Hailee Kenney assigned an issue to Hailee Kenney Puppet / PUP-5968 Deprecate Symbol#<=> monkey patch Change By: Hailee Kenney Assignee: Hailee Kenney Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5968) Deprecate Symbol#<=> monkey patch
Title: Message Title Kylo Ginsberg updated an issue Puppet / PUP-5968 Deprecate Symbol#<=> monkey patch Change By: Kylo Ginsberg Sprint: Client Triage 2016-03-23 (Bug Fixes) Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5968) Deprecate Symbol#<=> monkey patch
Title: Message Title Josh Cooper updated an issue Puppet / PUP-5968 Deprecate Symbol#<=> monkey patch Change By: Josh Cooper Fix Version/s: PUP 5.0.0 Fix Version/s: PUP 4.x Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5968) Deprecate Symbol#<=> monkey patch
Title: Message Title Josh Cooper updated an issue Puppet / PUP-5968 Deprecate Symbol#<=> monkey patch Change By: Josh Cooper Fix Version/s: PUP 5.0.0 Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5968) Deprecate Symbol#<=> monkey patch
Title: Message Title Henrik Lindberg commented on PUP-5968 Re: Deprecate Symbol#<=> monkey patch Suggest using the --strict flag (it has values :off, :warning, :error) added in PUP-5889 to do nothing, issue a warning or fail with error. (And we need a removal ticket, unless there already is one open - it should be linked to the epic '5.0 Removals'). Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5968) Deprecate Symbol#<=> monkey patch
Title: Message Title Josh Cooper created an issue Puppet / PUP-5968 Deprecate Symbol#<=> monkey patch Issue Type: Bug Assignee: Unassigned Created: 2016/02/24 9:14 AM Priority: Normal Reporter: Josh Cooper We restored the Symbol#<=> monkey patch in PUP-5962 because our version behaves differently from ruby 1.9.3 and up: Puppet: irb(main):005:0> :a <=> 'a' => 0 Ruby: irb(main):003:0> :a <=> 'a'
Jira (PUP-5968) Deprecate Symbol#<=> monkey patch
Title: Message Title
Josh Cooper commented on PUP-5968
Re: Deprecate Symbol#<=> monkey patch
FWIW, if I add a raise to the monkey patch: raise "Not a Symbol" unless other.is_a?(Symbol), then puppet specs still pass. Also executing the following also works (so the monkey patch is no longer necessary for the original use case that caused it to be added):
$ bundle exec puppet resource user root
user { 'root':
ensure => 'present',
comment => 'System Administrator',
gid => '0',
groups => ['admin', 'certusers', 'daemon', 'foobar', 'kmem', 'operator', 'procmod', 'procview', 'staff', 'sys', 'tty', 'wheel'],
home => '/var/root',
password => '*',
shell=> '/bin/sh',
uid => '0',
