[issue12449] Add accelerator "F" to button "Finish" in all MSI installers made by bdist_msi

[Éric Araujo]

Éric Araujo added the comment:

distutils2 is no more and the feature freeze for distutils was lifted.  
However, this does not strike me as an important feature to add.

--
resolution:  -> rejected
stage: needs patch -> committed/rejected
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12449] Add accelerator "F" to button "Finish" in all MSI installers made by bdist_msi

[Éric Araujo]

Éric Araujo  added the comment:

> My concern for MSI is that this issue is referencing a change to MSI
> generation. I never had any expectation for wininst to generate an MSI.
I’m sorry, it was me that first talked about wininst by mistake, the bug report 
always was about msi.

> If I remember correctly from trying the other day --formats=msi fails
> because bdist_msi is set as a valid format.
Also bdist_msi is only enabled on Windows.

> I have begun work on fixing these problems, as I've encountered them,
> and will be writing up issues for them soon.
Great!  Can you open bugs as soon as encountered?  Just say that you’re working 
on a patch to avoid work duplication.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12449] Add accelerator "F" to button "Finish" in all MSI installers made by bdist_msi

[Thomas Holmes]

Thomas Holmes  added the comment:

I mean that msi is _not_ set as a valid format. I will verify this evening.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12449] Add accelerator "F" to button "Finish" in all MSI installers made by bdist_msi

[Thomas Holmes]

Thomas Holmes  added the comment:

> > It also creates an exe installer, not an MSI.
> Why would you think it creates an MSI?  bdist_wininst is not bdist_msi.

My concern for MSI is that this issue is referencing a change to MSI 
generation. I never had any expectation for wininst to generate an MSI.

If I remember correctly from trying the other day --formats=msi fails because 
bdist_msi is set as a valid format.

I have begun work on fixing these problems, as I've encountered them, and will 
be writing up issues for them soon.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12449] Add accelerator "F" to button "Finish" in all MSI installers made by bdist_msi

[Éric Araujo]

Éric Araujo  added the comment:

> Apparently -m packaging.run and pysetup3 run don't perform
> identically, but that isn't relevant for this bug.
That’s very surprising, given that they have the same one-line code.  Please 
file that bug.

> Regarding bdist, I got bdist_wininst to work but I had to modify the
> code in place, it did not work by default.
Can you report that too, if there is no existing bug?  (Maybe it’s #10945 or 
another one.)

> It also creates an exe installer, not an MSI.
Why would you think it creates an MSI?  bdist_wininst is not bdist_msi.

> bdist_msi is not set as a valid command to run inside the commands
> package __init__.py.
Is it a problem?  In distutils too, bdist_msi is not registered in 
command.__init__, as it can’t run on non-Windows, but the bdist command knows 
that it exists and can run it.  IOW, there are two registries of bdist 
commands: in command.__init__, which is used by --help-commands and others, and 
in bdist.  In distutils, calling bdist --formats=msi or directly bdist_msi 
works (on Windows); if it doesn’t work with packaging, this is another bug to 
report.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12449] Add accelerator "F" to button "Finish" in all MSI installers made by bdist_msi

[Thomas Holmes]

Thomas Holmes  added the comment:

I was having a separate difficulty with bdist. Apparently -m packaging.run and 
pysetup3 run don't perform identically, but that isn't relevant for this bug.

Regarding bdist, I got bdist_wininst to work but I had to modify the code in 
place, it did not work by default. It also creates an exe installer, not an MSI.

bdist_msi is not set as a valid command to run inside the commands package 
__init__.py.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12449] Add accelerator "F" to button "Finish" in all MSI installers made by bdist_msi

[Éric Araujo]

Éric Araujo  added the comment:

What do you mean with disabled?  There is a bdist_wininst command in packaging. 
 Use “pysetup run bdist_wininst” to call it.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12449] Add accelerator "F" to button "Finish" in all MSI installers made by bdist_msi

[Thomas Holmes]

Thomas Holmes  added the comment:

bdist does not appear to be enabled in 3.3 development branch, is this correct?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12449] Add accelerator "F" to button "Finish" in all MSI installers made by bdist_msi

[Éric Araujo]

Éric Araujo  added the comment:

Distutils is frozen.  New features go into distutils2.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12449] Add accelerator "F" to button "Finish" in all MSI installers made by bdist_msi

[Ram Rachum]

Ram Rachum  added the comment:

I can only do wxPython, I have no idea how Python's MSI installers work. I did 
a quick search for "Finish" in the codebase but could find any obvious place to 
add the accelerator.

"As a new feature, this cannot go into distutils."

Seriously? Why?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12449] Add accelerator "F" to button "Finish" in all MSI installers made by bdist_msi

[Thomas Holmes]

Changes by Thomas Holmes :


--
nosy: +thomas.holmes

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12449] Add accelerator "F" to button "Finish" in all MSI installers made by bdist_msi

[Éric Araujo]

Éric Araujo  added the comment:

As a new feature, this cannot go into distutils.

Would you like to contribute a patch?  I have currently no idea about the 
workings of the MSI code.

--
components: +Distutils2 -Distutils
nosy: +alexis
stage:  -> needs patch
type: behavior -> feature request
versions:  -Python 3.4

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12449] Add accelerator "F" to button "Finish" in all MSI installers made by bdist_msi

[Ram Rachum]

New submission from Ram Rachum :

I noticed that in MSI installers downloaded from PyPI don't have an accelerator 
on the Finish button. Please add an accelerator on it. (I think that "F" is the 
accepted one.)

--
assignee: tarek
components: Distutils
messages: 139463
nosy: cool-RR, eric.araujo, tarek
priority: normal
severity: normal
status: open
title: Add accelerator "F" to button "Finish" in all MSI installers made by 
bdist_msi
type: behavior
versions: Python 3.3, Python 3.4

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com