Re: [PULL 00/45] ppc-for-5.0 queue 20200317
On Tue, 17 Mar 2020 at 10:04, David Gibson wrote: > > The following changes since commit a98135f727595382e200d04c2996e868b7925a01: > > Merge remote-tracking branch > 'remotes/kraxel/tags/vga-20200316-pull-request' into staging (2020-03-16 > 14:55:59 +) > > are available in the Git repository at: > > git://github.com/dgibson/qemu.git tags/ppc-for-5.0-20200317 > > for you to fetch changes up to 6961eae79f58385482775dc0a6c3d553f633662d: > > pseries: Update SLOF firmware image (2020-03-17 17:00:22 +1100) > > > ppc patch queue 2020-03-17 > > Here's my final pull request for the qemu-5.0 soft freeze. Sorry this > is just under the wire - I hit some last minute problems that took a > while to fix up and retest. > > Highlights are: > * Numerous fixes for the FWNMI feature > * A handful of cleanups to the device tree construction code > * Numerous fixes for the spapr-vscsi device > * A number of fixes and cleanups for real mode (MMU off) softmmu >handling > * Fixes for handling of the PAPR RMA > * Better handling of hotplug/unplug events during boot > * Assorted other fixes > Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/5.0 for any user-visible changes. -- PMM
Re: [PULL 00/45] ppc-for-5.0 queue 20200317
On Wed, Mar 18, 2020 at 10:58:46AM +1100, Alexey Kardashevskiy wrote: > > > On 18/03/2020 09:33, David Gibson wrote: > > On Tue, Mar 17, 2020 at 11:30:31AM +0100, Paolo Bonzini wrote: > >> On 17/03/20 11:03, David Gibson wrote: > >>> pseries: Update SLOF firmware image > >>> ppc/spapr: Move GPRs setup to one place > >>> pseries: Update SLOF firmware image > >>> spapr/rtas: Reserve space for RTAS blob and log > >>> pseries: Update SLOF firmware image > >> > >> Oh, no fake-OF patches? > > > > Apart from some prelims that make sense on their own, no. > > > > Not quite ready to go ahead with that, I'm afraid. > > You reviewed and found problems or you did not have time for that? > Either is fine, just curious. Mostly the second. It's not just the time to actually review the patches, either. Paolo made some good points about what it's safe to move into qemu proper. That means I need to thoroughly rethink where I really want to go with these SLOF removal ideas, and I haven't had time to do that. -- David Gibson| I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson signature.asc Description: PGP signature
Re: [PULL 00/45] ppc-for-5.0 queue 20200317
On 18/03/2020 09:33, David Gibson wrote: > On Tue, Mar 17, 2020 at 11:30:31AM +0100, Paolo Bonzini wrote: >> On 17/03/20 11:03, David Gibson wrote: >>> pseries: Update SLOF firmware image >>> ppc/spapr: Move GPRs setup to one place >>> pseries: Update SLOF firmware image >>> spapr/rtas: Reserve space for RTAS blob and log >>> pseries: Update SLOF firmware image >> >> Oh, no fake-OF patches? > > Apart from some prelims that make sense on their own, no. > > Not quite ready to go ahead with that, I'm afraid. You reviewed and found problems or you did not have time for that? Either is fine, just curious. -- Alexey
Re: [PULL 00/45] ppc-for-5.0 queue 20200317
On Tue, Mar 17, 2020 at 11:30:31AM +0100, Paolo Bonzini wrote: > On 17/03/20 11:03, David Gibson wrote: > > pseries: Update SLOF firmware image > > ppc/spapr: Move GPRs setup to one place > > pseries: Update SLOF firmware image > > spapr/rtas: Reserve space for RTAS blob and log > > pseries: Update SLOF firmware image > > Oh, no fake-OF patches? Apart from some prelims that make sense on their own, no. Not quite ready to go ahead with that, I'm afraid. > > Paolo > > > Cédric Le Goater (1): > > spapr/xive: use SPAPR_IRQ_IPI to define IPI ranges exposed to the > > guest > > > > David Gibson (19): > > ppc: Remove stub support for 32-bit hypervisor mode > > ppc: Remove stub of PPC970 HID4 implementation > > target/ppc: Correct handling of real mode accesses with vhyp on hash > > MMU > > target/ppc: Introduce ppc_hash64_use_vrma() helper > > spapr, ppc: Remove VPM0/RMLS hacks for POWER9 > > target/ppc: Remove RMOR register from POWER9 & POWER10 > > target/ppc: Use class fields to simplify LPCR masking > > target/ppc: Streamline calculation of RMA limit from LPCR[RMLS] > > target/ppc: Correct RMLS table > > target/ppc: Only calculate RMLS derived RMA limit on demand > > target/ppc: Don't store VRMA SLBE persistently > > spapr: Don't use weird units for MIN_RMA_SLOF > > spapr,ppc: Simplify signature of kvmppc_rma_size() > > spapr: Don't attempt to clamp RMA to VRMA constraint > > spapr: Don't clamp RMA to 16GiB on new machine types > > spapr: Clean up RMA size calculation > > spapr: Move creation of ibm,dynamic-reconfiguration-memory dt node > > spapr: Move creation of ibm,architecture-vec-5 property > > spapr: Rename DT functions to newer naming convention > > > > Greg Kurz (2): > > spapr: Handle pending hot plug/unplug requests at CAS > > ppc: Officially deprecate the CPU "compat" property > > > > Nicholas Piggin (8): > > ppc/spapr: Fix FWNMI machine check failure handling > > ppc/spapr: Change FWNMI names > > ppc/spapr: Add FWNMI System Reset state > > ppc/spapr: Fix FWNMI machine check interrupt delivery > > ppc/spapr: Allow FWNMI on TCG > > target/ppc: allow ppc_cpu_do_system_reset to take an alternate vector > > ppc/spapr: Implement FWNMI System Reset delivery > > ppc/spapr: Ignore common "ibm,nmi-interlock" Linux bug > > > > Philippe Mathieu-Daudé (8): > > hw/ppc/pnv: Fix typo in comment > > hw/scsi/viosrp: Add missing 'hw/scsi/srp.h' include > > hw/scsi/spapr_vscsi: Use SRP_MAX_IU_LEN instead of sizeof flexible > > array > > hw/scsi/spapr_vscsi: Simplify a bit > > hw/scsi/spapr_vscsi: Introduce req_iu() helper > > hw/scsi/spapr_vscsi: Do not mix SRP IU size with DMA buffer size > > hw/scsi/spapr_vscsi: Prevent buffer overflow > > hw/scsi/spapr_vscsi: Convert debug fprintf() to trace event > > > > Shivaprasad G Bhat (1): > > spapr: Fix Coverity warning while validating nvdimm options > > > > Vitaly Chikunov (1): > > target/ppc: Fix rlwinm on ppc64 > > > > docs/system/deprecated.rst| 7 + > > hw/intc/spapr_xive.c | 4 +- > > hw/ppc/pnv_lpc.c | 2 +- > > hw/ppc/spapr.c| 980 > > -- > > hw/ppc/spapr_caps.c | 19 +- > > hw/ppc/spapr_cpu_core.c | 16 +- > > hw/ppc/spapr_events.c | 51 +- > > hw/ppc/spapr_hcall.c | 15 +- > > hw/ppc/spapr_nvdimm.c | 7 +- > > hw/ppc/spapr_ovec.c | 4 +- > > hw/ppc/spapr_rtas.c | 45 +- > > hw/scsi/spapr_vscsi.c | 72 +-- > > hw/scsi/trace-events | 1 + > > hw/scsi/viosrp.h | 3 +- > > include/hw/ppc/spapr.h| 34 +- > > include/hw/ppc/spapr_cpu_core.h | 4 +- > > include/hw/ppc/spapr_ovec.h | 4 +- > > pc-bios/README| 2 +- > > pc-bios/slof.bin | Bin 931032 -> 965008 bytes > > roms/SLOF | 2 +- > > target/ppc/cpu-qom.h | 1 + > > target/ppc/cpu.h | 28 +- > > target/ppc/excp_helper.c | 79 ++- > > target/ppc/kvm.c | 5 +- > > target/ppc/kvm_ppc.h | 7 +- > > target/ppc/mmu-hash64.c | 319 + > > target/ppc/translate.c| 20 +- > > target/ppc/translate_init.inc.c | 116 ++--- > > tests/qtest/libqos/libqos-spapr.h | 3 +- > > 29 files changed, 930 insertions(+), 920 deletions(-) > > > -- David Gibson| I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson signature.asc Description: PGP signatu
Re: [PULL 00/45] ppc-for-5.0 queue 20200317
Patchew URL: https://patchew.org/QEMU/20200317100423.622643-1-da...@gibson.dropbear.id.au/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PULL 00/45] ppc-for-5.0 queue 20200317 Message-id: 20200317100423.622643-1-da...@gibson.dropbear.id.au Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Switched to a new branch 'test' 1689eda pseries: Update SLOF firmware image 72735a9 ppc/spapr: Ignore common "ibm,nmi-interlock" Linux bug 47df6f1 ppc/spapr: Implement FWNMI System Reset delivery f1fef1f target/ppc: allow ppc_cpu_do_system_reset to take an alternate vector 3bd2159 ppc/spapr: Allow FWNMI on TCG 91debae ppc/spapr: Fix FWNMI machine check interrupt delivery c9df752 ppc/spapr: Add FWNMI System Reset state bed131f ppc/spapr: Change FWNMI names b4a37dd ppc/spapr: Fix FWNMI machine check failure handling 6a32b19 spapr: Rename DT functions to newer naming convention 4e79406 spapr: Move creation of ibm,architecture-vec-5 property 21a3ae2 spapr: Move creation of ibm, dynamic-reconfiguration-memory dt node bf5265e spapr/rtas: Reserve space for RTAS blob and log 446dace pseries: Update SLOF firmware image f5bb445 ppc/spapr: Move GPRs setup to one place b824828 target/ppc: Fix rlwinm on ppc64 0e75479 spapr/xive: use SPAPR_IRQ_IPI to define IPI ranges exposed to the guest 397ec17 hw/scsi/spapr_vscsi: Convert debug fprintf() to trace event e8ff332 hw/scsi/spapr_vscsi: Prevent buffer overflow 7bde608 hw/scsi/spapr_vscsi: Do not mix SRP IU size with DMA buffer size 10ef238 hw/scsi/spapr_vscsi: Introduce req_iu() helper 06d1d9a hw/scsi/spapr_vscsi: Simplify a bit 89514b4 hw/scsi/spapr_vscsi: Use SRP_MAX_IU_LEN instead of sizeof flexible array 8cad997 hw/scsi/viosrp: Add missing 'hw/scsi/srp.h' include 684e72f spapr: Clean up RMA size calculation 4015194 spapr: Don't clamp RMA to 16GiB on new machine types 6ba055d spapr: Don't attempt to clamp RMA to VRMA constraint 37120d6 spapr,ppc: Simplify signature of kvmppc_rma_size() ac722f8 spapr: Don't use weird units for MIN_RMA_SLOF 2c86473 target/ppc: Don't store VRMA SLBE persistently 2a4565f target/ppc: Only calculate RMLS derived RMA limit on demand e6944cb target/ppc: Correct RMLS table 27bd1f5 target/ppc: Streamline calculation of RMA limit from LPCR[RMLS] 1d5b686 target/ppc: Use class fields to simplify LPCR masking 41f0aef target/ppc: Remove RMOR register from POWER9 & POWER10 f0bb56d spapr, ppc: Remove VPM0/RMLS hacks for POWER9 49d09fc target/ppc: Introduce ppc_hash64_use_vrma() helper a604105 target/ppc: Correct handling of real mode accesses with vhyp on hash MMU 6fbdf8f ppc: Remove stub of PPC970 HID4 implementation 689d28f ppc: Remove stub support for 32-bit hypervisor mode 405c024 hw/ppc/pnv: Fix typo in comment 7532fbf spapr: Fix Coverity warning while validating nvdimm options 645463a ppc: Officially deprecate the CPU "compat" property 63c40f1 spapr: Handle pending hot plug/unplug requests at CAS 7d74e4f pseries: Update SLOF firmware image === OUTPUT BEGIN === 1/45 Checking commit 7d74e4fe6d74 (pseries: Update SLOF firmware image) 2/45 Checking commit 63c40f1e53c0 (spapr: Handle pending hot plug/unplug requests at CAS) 3/45 Checking commit 645463ab9a98 (ppc: Officially deprecate the CPU "compat" property) 4/45 Checking commit 7532fbf9018e (spapr: Fix Coverity warning while validating nvdimm options) 5/45 Checking commit 405c024f407a (hw/ppc/pnv: Fix typo in comment) 6/45 Checking commit 689d28f975cf (ppc: Remove stub support for 32-bit hypervisor mode) 7/45 Checking commit 6fbdf8f49b17 (ppc: Remove stub of PPC970 HID4 implementation) 8/45 Checking commit a604105404be (target/ppc: Correct handling of real mode accesses with vhyp on hash MMU) 9/45 Checking commit 49d09fc795a5 (target/ppc: Introduce ppc_hash64_use_vrma() helper) 10/45 Checking commit f0bb56d30022 (spapr, ppc: Remove VPM0/RMLS hacks for POWER9) 11/45 Checking commit 41f0aefbf75e (target/ppc: Remove RMOR register from POWER9 & POWER10) 12/45 Checking commit 1d5b6860959d (target/ppc: Use class fields to simplify LPCR masking) 13/45 Checking commit 27bd1f5741a5 (target/ppc: Streamline calculation of RMA limit from LPCR[RMLS]) 14/45 Checking commit e6944cbf3ed9 (target/ppc: Correct RMLS table) 15/45 Checking commit 2a4565fd1852 (target/ppc: Only calculate RMLS derived RMA limit on demand) 16/45 Checking commit 2c864739b507 (target/ppc: Don't store VRMA SLBE persistently) 17/45 Checking commit ac722f832dad (spapr: Don't use weird units for MIN_RMA_SLOF) 18/45 Checking commit 37120d691e31 (spapr,ppc: Simplify signature of kvmppc_rma_size()) 19/45 Checking commit 6ba055dea62c (spapr: Don't attempt to clamp
Re: [PULL 00/45] ppc-for-5.0 queue 20200317
On 17/03/20 11:03, David Gibson wrote: > pseries: Update SLOF firmware image > ppc/spapr: Move GPRs setup to one place > pseries: Update SLOF firmware image > spapr/rtas: Reserve space for RTAS blob and log > pseries: Update SLOF firmware image Oh, no fake-OF patches? Paolo > Cédric Le Goater (1): > spapr/xive: use SPAPR_IRQ_IPI to define IPI ranges exposed to the guest > > David Gibson (19): > ppc: Remove stub support for 32-bit hypervisor mode > ppc: Remove stub of PPC970 HID4 implementation > target/ppc: Correct handling of real mode accesses with vhyp on hash MMU > target/ppc: Introduce ppc_hash64_use_vrma() helper > spapr, ppc: Remove VPM0/RMLS hacks for POWER9 > target/ppc: Remove RMOR register from POWER9 & POWER10 > target/ppc: Use class fields to simplify LPCR masking > target/ppc: Streamline calculation of RMA limit from LPCR[RMLS] > target/ppc: Correct RMLS table > target/ppc: Only calculate RMLS derived RMA limit on demand > target/ppc: Don't store VRMA SLBE persistently > spapr: Don't use weird units for MIN_RMA_SLOF > spapr,ppc: Simplify signature of kvmppc_rma_size() > spapr: Don't attempt to clamp RMA to VRMA constraint > spapr: Don't clamp RMA to 16GiB on new machine types > spapr: Clean up RMA size calculation > spapr: Move creation of ibm,dynamic-reconfiguration-memory dt node > spapr: Move creation of ibm,architecture-vec-5 property > spapr: Rename DT functions to newer naming convention > > Greg Kurz (2): > spapr: Handle pending hot plug/unplug requests at CAS > ppc: Officially deprecate the CPU "compat" property > > Nicholas Piggin (8): > ppc/spapr: Fix FWNMI machine check failure handling > ppc/spapr: Change FWNMI names > ppc/spapr: Add FWNMI System Reset state > ppc/spapr: Fix FWNMI machine check interrupt delivery > ppc/spapr: Allow FWNMI on TCG > target/ppc: allow ppc_cpu_do_system_reset to take an alternate vector > ppc/spapr: Implement FWNMI System Reset delivery > ppc/spapr: Ignore common "ibm,nmi-interlock" Linux bug > > Philippe Mathieu-Daudé (8): > hw/ppc/pnv: Fix typo in comment > hw/scsi/viosrp: Add missing 'hw/scsi/srp.h' include > hw/scsi/spapr_vscsi: Use SRP_MAX_IU_LEN instead of sizeof flexible array > hw/scsi/spapr_vscsi: Simplify a bit > hw/scsi/spapr_vscsi: Introduce req_iu() helper > hw/scsi/spapr_vscsi: Do not mix SRP IU size with DMA buffer size > hw/scsi/spapr_vscsi: Prevent buffer overflow > hw/scsi/spapr_vscsi: Convert debug fprintf() to trace event > > Shivaprasad G Bhat (1): > spapr: Fix Coverity warning while validating nvdimm options > > Vitaly Chikunov (1): > target/ppc: Fix rlwinm on ppc64 > > docs/system/deprecated.rst| 7 + > hw/intc/spapr_xive.c | 4 +- > hw/ppc/pnv_lpc.c | 2 +- > hw/ppc/spapr.c| 980 > -- > hw/ppc/spapr_caps.c | 19 +- > hw/ppc/spapr_cpu_core.c | 16 +- > hw/ppc/spapr_events.c | 51 +- > hw/ppc/spapr_hcall.c | 15 +- > hw/ppc/spapr_nvdimm.c | 7 +- > hw/ppc/spapr_ovec.c | 4 +- > hw/ppc/spapr_rtas.c | 45 +- > hw/scsi/spapr_vscsi.c | 72 +-- > hw/scsi/trace-events | 1 + > hw/scsi/viosrp.h | 3 +- > include/hw/ppc/spapr.h| 34 +- > include/hw/ppc/spapr_cpu_core.h | 4 +- > include/hw/ppc/spapr_ovec.h | 4 +- > pc-bios/README| 2 +- > pc-bios/slof.bin | Bin 931032 -> 965008 bytes > roms/SLOF | 2 +- > target/ppc/cpu-qom.h | 1 + > target/ppc/cpu.h | 28 +- > target/ppc/excp_helper.c | 79 ++- > target/ppc/kvm.c | 5 +- > target/ppc/kvm_ppc.h | 7 +- > target/ppc/mmu-hash64.c | 319 + > target/ppc/translate.c| 20 +- > target/ppc/translate_init.inc.c | 116 ++--- > tests/qtest/libqos/libqos-spapr.h | 3 +- > 29 files changed, 930 insertions(+), 920 deletions(-) >
[PULL 00/45] ppc-for-5.0 queue 20200317
The following changes since commit a98135f727595382e200d04c2996e868b7925a01: Merge remote-tracking branch 'remotes/kraxel/tags/vga-20200316-pull-request' into staging (2020-03-16 14:55:59 +) are available in the Git repository at: git://github.com/dgibson/qemu.git tags/ppc-for-5.0-20200317 for you to fetch changes up to 6961eae79f58385482775dc0a6c3d553f633662d: pseries: Update SLOF firmware image (2020-03-17 17:00:22 +1100) ppc patch queue 2020-03-17 Here's my final pull request for the qemu-5.0 soft freeze. Sorry this is just under the wire - I hit some last minute problems that took a while to fix up and retest. Highlights are: * Numerous fixes for the FWNMI feature * A handful of cleanups to the device tree construction code * Numerous fixes for the spapr-vscsi device * A number of fixes and cleanups for real mode (MMU off) softmmu handling * Fixes for handling of the PAPR RMA * Better handling of hotplug/unplug events during boot * Assorted other fixes Alexey Kardashevskiy (5): pseries: Update SLOF firmware image ppc/spapr: Move GPRs setup to one place pseries: Update SLOF firmware image spapr/rtas: Reserve space for RTAS blob and log pseries: Update SLOF firmware image Cédric Le Goater (1): spapr/xive: use SPAPR_IRQ_IPI to define IPI ranges exposed to the guest David Gibson (19): ppc: Remove stub support for 32-bit hypervisor mode ppc: Remove stub of PPC970 HID4 implementation target/ppc: Correct handling of real mode accesses with vhyp on hash MMU target/ppc: Introduce ppc_hash64_use_vrma() helper spapr, ppc: Remove VPM0/RMLS hacks for POWER9 target/ppc: Remove RMOR register from POWER9 & POWER10 target/ppc: Use class fields to simplify LPCR masking target/ppc: Streamline calculation of RMA limit from LPCR[RMLS] target/ppc: Correct RMLS table target/ppc: Only calculate RMLS derived RMA limit on demand target/ppc: Don't store VRMA SLBE persistently spapr: Don't use weird units for MIN_RMA_SLOF spapr,ppc: Simplify signature of kvmppc_rma_size() spapr: Don't attempt to clamp RMA to VRMA constraint spapr: Don't clamp RMA to 16GiB on new machine types spapr: Clean up RMA size calculation spapr: Move creation of ibm,dynamic-reconfiguration-memory dt node spapr: Move creation of ibm,architecture-vec-5 property spapr: Rename DT functions to newer naming convention Greg Kurz (2): spapr: Handle pending hot plug/unplug requests at CAS ppc: Officially deprecate the CPU "compat" property Nicholas Piggin (8): ppc/spapr: Fix FWNMI machine check failure handling ppc/spapr: Change FWNMI names ppc/spapr: Add FWNMI System Reset state ppc/spapr: Fix FWNMI machine check interrupt delivery ppc/spapr: Allow FWNMI on TCG target/ppc: allow ppc_cpu_do_system_reset to take an alternate vector ppc/spapr: Implement FWNMI System Reset delivery ppc/spapr: Ignore common "ibm,nmi-interlock" Linux bug Philippe Mathieu-Daudé (8): hw/ppc/pnv: Fix typo in comment hw/scsi/viosrp: Add missing 'hw/scsi/srp.h' include hw/scsi/spapr_vscsi: Use SRP_MAX_IU_LEN instead of sizeof flexible array hw/scsi/spapr_vscsi: Simplify a bit hw/scsi/spapr_vscsi: Introduce req_iu() helper hw/scsi/spapr_vscsi: Do not mix SRP IU size with DMA buffer size hw/scsi/spapr_vscsi: Prevent buffer overflow hw/scsi/spapr_vscsi: Convert debug fprintf() to trace event Shivaprasad G Bhat (1): spapr: Fix Coverity warning while validating nvdimm options Vitaly Chikunov (1): target/ppc: Fix rlwinm on ppc64 docs/system/deprecated.rst| 7 + hw/intc/spapr_xive.c | 4 +- hw/ppc/pnv_lpc.c | 2 +- hw/ppc/spapr.c| 980 -- hw/ppc/spapr_caps.c | 19 +- hw/ppc/spapr_cpu_core.c | 16 +- hw/ppc/spapr_events.c | 51 +- hw/ppc/spapr_hcall.c | 15 +- hw/ppc/spapr_nvdimm.c | 7 +- hw/ppc/spapr_ovec.c | 4 +- hw/ppc/spapr_rtas.c | 45 +- hw/scsi/spapr_vscsi.c | 72 +-- hw/scsi/trace-events | 1 + hw/scsi/viosrp.h | 3 +- include/hw/ppc/spapr.h| 34 +- include/hw/ppc/spapr_cpu_core.h | 4 +- include/hw/ppc/spapr_ovec.h | 4 +- pc-bios/README| 2 +- pc-bios/slof.bin | Bin 931032 -> 965008 bytes roms/SLOF | 2 +- target/ppc/cpu-qom.h | 1 + target/ppc/cpu.h | 28 +- target/ppc/excp_helper.c | 79 ++- target/ppc/kvm.c | 5 +- target/ppc/kvm_ppc.h | 7 +- targ
