Re: [Qemu-devel] [PATCH 07/52] target-m68k: add bkpt instruction

2016-05-07 Thread Laurent Vivier


Le 06/05/2016 à 18:42, Richard Henderson a écrit :
> On 05/04/2016 10:11 AM, Laurent Vivier wrote:
>> +INSN(bkpt,  4848, fff8, M68000);
> 
> Do we care that this comes in with 68010 not 68000?

Yes, you're right: I'm adding M68K_FEATURE_BKPT to enable it only on 68010+

> Otherwise,
> 
> Reviewed-by: Richard Henderson 
> 
> 
> r~
> 
Thanks,
Laurent



Re: [Qemu-devel] [PATCH 07/52] target-m68k: add bkpt instruction

2016-05-06 Thread Richard Henderson

On 05/04/2016 10:11 AM, Laurent Vivier wrote:

+INSN(bkpt,  4848, fff8, M68000);


Do we care that this comes in with 68010 not 68000?

Otherwise,

Reviewed-by: Richard Henderson 


r~




[Qemu-devel] [PATCH 07/52] target-m68k: add bkpt instruction

2016-05-04 Thread Laurent Vivier
Signed-off-by: Laurent Vivier 
---
 target-m68k/translate.c | 6 ++
 1 file changed, 6 insertions(+)

diff --git a/target-m68k/translate.c b/target-m68k/translate.c
index bad07a5..e2555f6 100644
--- a/target-m68k/translate.c
+++ b/target-m68k/translate.c
@@ -1441,6 +1441,11 @@ DISAS_INSN(swap)
 gen_logic_cc(s, reg);
 }
 
+DISAS_INSN(bkpt)
+{
+gen_exception(s, s->pc - 2, EXCP_DEBUG);
+}
+
 DISAS_INSN(pea)
 {
 TCGv tmp;
@@ -2894,6 +2899,7 @@ void register_m68k_insns (CPUM68KState *env)
 INSN(move_to_sr, 46c0, ffc0, CF_ISA_A);
 BASE(pea,   4840, ffc0);
 BASE(swap,  4840, fff8);
+INSN(bkpt,  4848, fff8, M68000);
 BASE(movem, 48c0, fbc0);
 BASE(ext,   4880, fff8);
 BASE(ext,   48c0, fff8);
-- 
2.5.5