[QGIS-Developer] QGIS repository management

2023-10-13 Thread Sandro Santilli via QGIS-Developer 
Hello all,
today I was finally able to more clearly see the problem that frustrates
me everytime a take part to a new QGIS bugfixing drive, and I would like
to share it hoping to find a solution togheter.

The main problem:

  - Despite having been granted write access to the QGIS repository in 2012
[1], I cannot effectively use that power today

It's not just me, I think, but I cannot tell for sure because the configuration
of the infrastructure currently in use (github) is not available for me to see
and the governance page on the official QGIS website does not contain this
information [2]. This being blind of course adds up to my frustration.

>From experience, I know that the reason why I cannot write to the QGIS
repository is because "branch protection" is active (for the master branch
at least) and a set of conditions are required to merge a PR, namely:

  - All CI tests need to pass.

  - Someone else (I don't know from which group of people) needs to
approve the proposed change.

While I do the above condition being a useful indication for "QGIS
core developers" to decide whether to accept or not a change request,
I find them representing an obstacle way more often than a service,
and in particular:

1. CI is often broken for reasons that are independent from the proposed
   change.

2. An aberration of the "review" condition is that a change proposed by a
   contributor and approved by me can be merged but a change proposed by
   me and approved by the same contributor can not be merged, effectively
   giving me ("core QGIS committer") less power than the power of a random
   contributor.

The rules described above are not found from the governance page [2]
so it isn't easy for me to propose changes because I don't have a clear
picture of current rules (like, I believe some people in QGIS can
self-approve PRs but dunno how to tell who and why).

I would personally welcome (and be able to help taking) the following actions:

  1. Clearly document the roles and rules on the website

  2. Allow those with "write access" to self-approve PRs

  3. Define rules by which "write access" privileges to the repository
 are revoked

Thanks for having read this in full, and I hope to hear your position
on the matter.  Happy hacking !


[1] https://lists.osgeo.org/pipermail/qgis-developer/2012-October/022715.html
[2] https://qgis.org/en/site/getinvolved/governance/governance.html

--strk;

  Libre GIS consultant/developer
  https://strk.kbt.io/services.html
___
QGIS-Developer mailing list
QGIS-Developer@lists.osgeo.org
List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer

Re: [QGIS-Developer] QGIS Documentation Writer Report

2023-10-13 Thread Selma Vidimlic via QGIS-Developer 
Hello everyone,

PRs open or fixed this week:

   - Calculate expressions algorithm
   
   - Recent project update
    ( including this
   issue https://github.com/qgis/QGIS-Documentation/issues/2833 )

PRs merged this week:

   - https://github.com/qgis/QGIS-Documentation/pull/8531
   - https://github.com/qgis/QGIS-Documentation/pull/8530
   - https://github.com/qgis/QGIS-Documentation/pull/8483

Still working on:

   - https://github.com/qgis/QGIS-Documentation/issues/7802 (
   https://github.com/qgis/QGIS-Documentation/issues/8547 )


Have a nice weekend,
Selma.

On Fri, 6 Oct 2023 at 18:00, Selma Vidimlic  wrote:

> Hi all,
>
> This week, I dedicated my efforts to gaining a deeper understanding of the
> QGIS project and community, as well as exploring ways to enhance our
> documentation workflow.
> I recognized the need for faster communication among active contributors
> within the context of QGIS documentation. To address this, I created a
> chatroom on Fluffy Chat (Matrix). If you'd like to join the chatroom,
> please add me (@selmaaa:matrix.org), and I will manually invite you.
> Fluffy Chat does not allow sending a single invite to all, so this step is
> necessary...
>
> Although I did not create new PRs this week, I was actively involved in
> the following issue:
>
>- https://github.com/qgis/QGIS-Documentation/issues/7802
>
> This issue focuses on expression functions, a topic that I had not
> explored extensively in QGIS before. I dedicated a significant amount of
> time to understand and create visual examples for expression functions.
>
> I was also fixing screenshots for this PR:
>
>- https://github.com/qgis/QGIS-Documentation/pull/8483
>
> Have a nice weekend,
> Selma.
>
>
> On Fri, 29 Sept 2023 at 19:35, Selma Vidimlic  wrote:
>
>>   Hi all,
>>
>> Open pull requests:
>>
>>- https://github.com/qgis/QGIS-Documentation/pull/8541
>>- https://github.com/qgis/QGIS-Documentation/pull/8537 (I will
>>continue to work on this one together with Harrissou so it is not ready to
>>be merged yet)
>>- https://github.com/qgis/QGIS-Documentation/pull/8531 (this one
>>also, Harrissou started to update Elevation profile, so we will continue
>>together)
>>- https://github.com/qgis/QGIS-Documentation/pull/8522 (same as
>>previous)
>>- https://github.com/qgis/QGIS-Documentation/pull/8530 (same as
>>previous)
>>- https://github.com/qgis/QGIS-Documentation/pull/8491 ( this one
>>needs feedback from Nyall Dawson or anybody else who is familiar with "Add
>>GIS File" action)
>>- https://github.com/qgis/QGIS-Documentation/pull/8483 (will be done
>>by the end of the weekend)
>>
>> Merged PRs:
>>
>>- https://github.com/qgis/QGIS-Documentation/pull/8507
>>
>> From this week I will send this report in a single thread so we can all
>> follow the progress easier.
>>
>> Have a nice weekend,
>> Selma.
>>
>>
>> --
>> Selma Vidimlic Husic
>> QGIS Documentation Writer
>> Visit http://kartoza.com to find out about open source:
>> * Desktop GIS programming services
>> * Geospatial web development
>> * GIS Training
>> * Consulting Services
>> Phone: +387 61 933 651
>>
>
>
> --
> Selma Vidimlic Husic
> QGIS Documentation Writer
> Visit http://kartoza.com to find out about open source:
> * Desktop GIS programming services
> * Geospatial web development
> * GIS Training
> * Consulting Services
> Phone: +387 61 933 651
>


-- 
Selma Vidimlic Husic
QGIS Documentation Writer
Visit http://kartoza.com to find out about open source:
* Desktop GIS programming services
* Geospatial web development
* GIS Training
* Consulting Services
Phone: +387 61 933 651
___
QGIS-Developer mailing list
QGIS-Developer@lists.osgeo.org
List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer

[QGIS-Developer] Merging MinGW CI workflows ?

2023-10-13 Thread Sandro Santilli via QGIS-Developer 
As I got failure in a MingW workflow [1] and could not figure out what
the problem was due to the huge size of CI step logs, I'm trying to find
a way to reduce that log size and stumbled upon the fact that two
different windows-related workflows are using two different approaches:

  - .github/workflows/mingw64.yml (the problematic one)

Uses a single "Build QGIS Application" step doing build
configuration (ccache, cmake), build (verbose) and install.
Additional steps create a portable .zip and upload the artifacts.

  - .github/workflows/mingw-w64-msys2.yml

Uses separate steps for build configuration and build
(non-verbose). Does not install. Does not create or upload
artifacts.

I think the multi-step approach would be easier to use because each
step runs in its own container and produces its own logs, thus letting
you (the developer) only download the log of interest, so I'm thinking
to adapt the problematic one to a multi-step approach too.

But then I wondered: do we really need two separate workflows ?
Would it make sense to merge them into a single one ?


[1] 
https://github.com/qgis/QGIS/actions/runs/6493640195/job/17634987561?pr=54923
[2] https://github.com/qgis/QGIS/pull/54924

--strk; 

  Libre GIS consultant/developer
  https://strk.kbt.io/services.html
___
QGIS-Developer mailing list
QGIS-Developer@lists.osgeo.org
List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer