[GitHub] [spark] AmplabJenkins removed a comment on issue #25960: [SPARK-29283][SQL] Error message is hidden when query from JDBC, especially enabled adaptive execution

2019-10-12 Thread GitBox
AmplabJenkins removed a comment on issue #25960: [SPARK-29283][SQL] Error 
message is hidden when query from JDBC, especially enabled adaptive execution
URL: https://github.com/apache/spark/pull/25960#issuecomment-541388544
 
 
   Merged build finished. Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on issue #25960: [SPARK-29283][SQL] Error message is hidden when query from JDBC, especially enabled adaptive execution

2019-10-12 Thread GitBox
AmplabJenkins removed a comment on issue #25960: [SPARK-29283][SQL] Error 
message is hidden when query from JDBC, especially enabled adaptive execution
URL: https://github.com/apache/spark/pull/25960#issuecomment-541388545
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/111991/
   Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA removed a comment on issue #25960: [SPARK-29283][SQL] Error message is hidden when query from JDBC, especially enabled adaptive execution

2019-10-12 Thread GitBox
SparkQA removed a comment on issue #25960: [SPARK-29283][SQL] Error message is 
hidden when query from JDBC, especially enabled adaptive execution
URL: https://github.com/apache/spark/pull/25960#issuecomment-541387557
 
 
   **[Test build #111991 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/111991/testReport)**
 for PR 25960 at commit 
[`4aa2dd2`](https://github.com/apache/spark/commit/4aa2dd2b7441b35fe80c1656dc8487bf4afef1c7).


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on issue #25960: [SPARK-29283][SQL] Error message is hidden when query from JDBC, especially enabled adaptive execution

2019-10-12 Thread GitBox
SparkQA commented on issue #25960: [SPARK-29283][SQL] Error message is hidden 
when query from JDBC, especially enabled adaptive execution
URL: https://github.com/apache/spark/pull/25960#issuecomment-541388525
 
 
   **[Test build #111991 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/111991/testReport)**
 for PR 25960 at commit 
[`4aa2dd2`](https://github.com/apache/spark/commit/4aa2dd2b7441b35fe80c1656dc8487bf4afef1c7).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on issue #25960: [SPARK-29283][SQL] Error message is hidden when query from JDBC, especially enabled adaptive execution

2019-10-12 Thread GitBox
AmplabJenkins commented on issue #25960: [SPARK-29283][SQL] Error message is 
hidden when query from JDBC, especially enabled adaptive execution
URL: https://github.com/apache/spark/pull/25960#issuecomment-541388545
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/111991/
   Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on issue #25960: [SPARK-29283][SQL] Error message is hidden when query from JDBC, especially enabled adaptive execution

2019-10-12 Thread GitBox
AmplabJenkins commented on issue #25960: [SPARK-29283][SQL] Error message is 
hidden when query from JDBC, especially enabled adaptive execution
URL: https://github.com/apache/spark/pull/25960#issuecomment-541388544
 
 
   Merged build finished. Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] wangyum commented on issue #25018: [SPARK-26321][SQL] Port HIVE-15297: Hive should not split semicolon within quoted string literals

2019-10-12 Thread GitBox
wangyum commented on issue #25018: [SPARK-26321][SQL] Port HIVE-15297: Hive 
should not split semicolon within quoted string literals
URL: https://github.com/apache/spark/pull/25018#issuecomment-541387635
 
 
   Merged to master.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on issue #25960: [SPARK-29283][SQL] Error message is hidden when query from JDBC, especially enabled adaptive execution

2019-10-12 Thread GitBox
AmplabJenkins removed a comment on issue #25960: [SPARK-29283][SQL] Error 
message is hidden when query from JDBC, especially enabled adaptive execution
URL: https://github.com/apache/spark/pull/25960#issuecomment-541387620
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/17006/
   Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on issue #25960: [SPARK-29283][SQL] Error message is hidden when query from JDBC, especially enabled adaptive execution

2019-10-12 Thread GitBox
AmplabJenkins removed a comment on issue #25960: [SPARK-29283][SQL] Error 
message is hidden when query from JDBC, especially enabled adaptive execution
URL: https://github.com/apache/spark/pull/25960#issuecomment-541387618
 
 
   Merged build finished. Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on issue #25960: [SPARK-29283][SQL] Error message is hidden when query from JDBC, especially enabled adaptive execution

2019-10-12 Thread GitBox
AmplabJenkins commented on issue #25960: [SPARK-29283][SQL] Error message is 
hidden when query from JDBC, especially enabled adaptive execution
URL: https://github.com/apache/spark/pull/25960#issuecomment-541387620
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/17006/
   Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on issue #25960: [SPARK-29283][SQL] Error message is hidden when query from JDBC, especially enabled adaptive execution

2019-10-12 Thread GitBox
AmplabJenkins commented on issue #25960: [SPARK-29283][SQL] Error message is 
hidden when query from JDBC, especially enabled adaptive execution
URL: https://github.com/apache/spark/pull/25960#issuecomment-541387618
 
 
   Merged build finished. Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] wangyum closed pull request #25018: [SPARK-26321][SQL] Port HIVE-15297: Hive should not split semicolon within quoted string literals

2019-10-12 Thread GitBox
wangyum closed pull request #25018: [SPARK-26321][SQL] Port HIVE-15297: Hive 
should not split semicolon within quoted string literals
URL: https://github.com/apache/spark/pull/25018
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on issue #25960: [SPARK-29283][SQL] Error message is hidden when query from JDBC, especially enabled adaptive execution

2019-10-12 Thread GitBox
SparkQA commented on issue #25960: [SPARK-29283][SQL] Error message is hidden 
when query from JDBC, especially enabled adaptive execution
URL: https://github.com/apache/spark/pull/25960#issuecomment-541387557
 
 
   **[Test build #111991 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/111991/testReport)**
 for PR 25960 at commit 
[`4aa2dd2`](https://github.com/apache/spark/commit/4aa2dd2b7441b35fe80c1656dc8487bf4afef1c7).


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on issue #25018: [SPARK-26321][SQL] Port HIVE-15297: Hive should not split semicolon within quoted string literals

2019-10-12 Thread GitBox
AmplabJenkins commented on issue #25018: [SPARK-26321][SQL] Port HIVE-15297: 
Hive should not split semicolon within quoted string literals
URL: https://github.com/apache/spark/pull/25018#issuecomment-541387463
 
 
   Merged build finished. Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA removed a comment on issue #25018: [SPARK-26321][SQL] Port HIVE-15297: Hive should not split semicolon within quoted string literals

2019-10-12 Thread GitBox
SparkQA removed a comment on issue #25018: [SPARK-26321][SQL] Port HIVE-15297: 
Hive should not split semicolon within quoted string literals
URL: https://github.com/apache/spark/pull/25018#issuecomment-541386478
 
 
   **[Test build #111990 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/111990/testReport)**
 for PR 25018 at commit 
[`48364a7`](https://github.com/apache/spark/commit/48364a7c5cb6b4398a57cd3abcfe624adffa056a).


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on issue #25018: [SPARK-26321][SQL] Port HIVE-15297: Hive should not split semicolon within quoted string literals

2019-10-12 Thread GitBox
AmplabJenkins removed a comment on issue #25018: [SPARK-26321][SQL] Port 
HIVE-15297: Hive should not split semicolon within quoted string literals
URL: https://github.com/apache/spark/pull/25018#issuecomment-541387463
 
 
   Merged build finished. Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] wangyum commented on issue #25960: [SPARK-29283][SQL] Error message is hidden when query from JDBC, especially enabled adaptive execution

2019-10-12 Thread GitBox
wangyum commented on issue #25960: [SPARK-29283][SQL] Error message is hidden 
when query from JDBC, especially enabled adaptive execution
URL: https://github.com/apache/spark/pull/25960#issuecomment-541387470
 
 
   retest this please


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on issue #25018: [SPARK-26321][SQL] Port HIVE-15297: Hive should not split semicolon within quoted string literals

2019-10-12 Thread GitBox
AmplabJenkins removed a comment on issue #25018: [SPARK-26321][SQL] Port 
HIVE-15297: Hive should not split semicolon within quoted string literals
URL: https://github.com/apache/spark/pull/25018#issuecomment-541387466
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/111990/
   Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on issue #25018: [SPARK-26321][SQL] Port HIVE-15297: Hive should not split semicolon within quoted string literals

2019-10-12 Thread GitBox
AmplabJenkins commented on issue #25018: [SPARK-26321][SQL] Port HIVE-15297: 
Hive should not split semicolon within quoted string literals
URL: https://github.com/apache/spark/pull/25018#issuecomment-541387466
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/111990/
   Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] wangyum commented on issue #26028: [SPARK-29359][SQL][TESTS] Better exception handling in (SQL|ThriftServer)QueryTestSuite

2019-10-12 Thread GitBox
wangyum commented on issue #26028: [SPARK-29359][SQL][TESTS] Better exception 
handling in (SQL|ThriftServer)QueryTestSuite
URL: https://github.com/apache/spark/pull/26028#issuecomment-541387445
 
 
   Merged to master.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] wangyum commented on issue #26028: [SPARK-29359][SQL][TESTS] Better exception handling in (SQL|ThriftServer)QueryTestSuite

2019-10-12 Thread GitBox
wangyum commented on issue #26028: [SPARK-29359][SQL][TESTS] Better exception 
handling in (SQL|ThriftServer)QueryTestSuite
URL: https://github.com/apache/spark/pull/26028#issuecomment-541387440
 
 
   Thank you @peter-toth @dongjoon-hyun 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on issue #25018: [SPARK-26321][SQL] Port HIVE-15297: Hive should not split semicolon within quoted string literals

2019-10-12 Thread GitBox
SparkQA commented on issue #25018: [SPARK-26321][SQL] Port HIVE-15297: Hive 
should not split semicolon within quoted string literals
URL: https://github.com/apache/spark/pull/25018#issuecomment-541387439
 
 
   **[Test build #111990 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/111990/testReport)**
 for PR 25018 at commit 
[`48364a7`](https://github.com/apache/spark/commit/48364a7c5cb6b4398a57cd3abcfe624adffa056a).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] wangyum closed pull request #26028: [SPARK-29359][SQL][TESTS] Better exception handling in (SQL|ThriftServer)QueryTestSuite

2019-10-12 Thread GitBox
wangyum closed pull request #26028: [SPARK-29359][SQL][TESTS] Better exception 
handling in (SQL|ThriftServer)QueryTestSuite
URL: https://github.com/apache/spark/pull/26028
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on issue #25018: [SPARK-26321][SQL] Port HIVE-15297: Hive should not split semicolon within quoted string literals

2019-10-12 Thread GitBox
AmplabJenkins removed a comment on issue #25018: [SPARK-26321][SQL] Port 
HIVE-15297: Hive should not split semicolon within quoted string literals
URL: https://github.com/apache/spark/pull/25018#issuecomment-541386542
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/17005/
   Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on issue #25018: [SPARK-26321][SQL] Port HIVE-15297: Hive should not split semicolon within quoted string literals

2019-10-12 Thread GitBox
AmplabJenkins removed a comment on issue #25018: [SPARK-26321][SQL] Port 
HIVE-15297: Hive should not split semicolon within quoted string literals
URL: https://github.com/apache/spark/pull/25018#issuecomment-541386539
 
 
   Merged build finished. Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on issue #25018: [SPARK-26321][SQL] Port HIVE-15297: Hive should not split semicolon within quoted string literals

2019-10-12 Thread GitBox
AmplabJenkins commented on issue #25018: [SPARK-26321][SQL] Port HIVE-15297: 
Hive should not split semicolon within quoted string literals
URL: https://github.com/apache/spark/pull/25018#issuecomment-541386542
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/17005/
   Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on issue #25018: [SPARK-26321][SQL] Port HIVE-15297: Hive should not split semicolon within quoted string literals

2019-10-12 Thread GitBox
AmplabJenkins commented on issue #25018: [SPARK-26321][SQL] Port HIVE-15297: 
Hive should not split semicolon within quoted string literals
URL: https://github.com/apache/spark/pull/25018#issuecomment-541386539
 
 
   Merged build finished. Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on issue #25018: [SPARK-26321][SQL] Port HIVE-15297: Hive should not split semicolon within quoted string literals

2019-10-12 Thread GitBox
SparkQA commented on issue #25018: [SPARK-26321][SQL] Port HIVE-15297: Hive 
should not split semicolon within quoted string literals
URL: https://github.com/apache/spark/pull/25018#issuecomment-541386478
 
 
   **[Test build #111990 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/111990/testReport)**
 for PR 25018 at commit 
[`48364a7`](https://github.com/apache/spark/commit/48364a7c5cb6b4398a57cd3abcfe624adffa056a).


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on issue #25816: [SPARK-29107][SQL][TESTS] Port window.sql (Part 1)

2019-10-12 Thread GitBox
AmplabJenkins removed a comment on issue #25816: [SPARK-29107][SQL][TESTS] Port 
window.sql (Part 1)
URL: https://github.com/apache/spark/pull/25816#issuecomment-541385080
 
 
   Merged build finished. Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on issue #25816: [SPARK-29107][SQL][TESTS] Port window.sql (Part 1)

2019-10-12 Thread GitBox
AmplabJenkins removed a comment on issue #25816: [SPARK-29107][SQL][TESTS] Port 
window.sql (Part 1)
URL: https://github.com/apache/spark/pull/25816#issuecomment-541385081
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/111988/
   Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on issue #25816: [SPARK-29107][SQL][TESTS] Port window.sql (Part 1)

2019-10-12 Thread GitBox
AmplabJenkins commented on issue #25816: [SPARK-29107][SQL][TESTS] Port 
window.sql (Part 1)
URL: https://github.com/apache/spark/pull/25816#issuecomment-541385081
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/111988/
   Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on issue #25816: [SPARK-29107][SQL][TESTS] Port window.sql (Part 1)

2019-10-12 Thread GitBox
AmplabJenkins commented on issue #25816: [SPARK-29107][SQL][TESTS] Port 
window.sql (Part 1)
URL: https://github.com/apache/spark/pull/25816#issuecomment-541385080
 
 
   Merged build finished. Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on issue #25816: [SPARK-29107][SQL][TESTS] Port window.sql (Part 1)

2019-10-12 Thread GitBox
SparkQA commented on issue #25816: [SPARK-29107][SQL][TESTS] Port window.sql 
(Part 1)
URL: https://github.com/apache/spark/pull/25816#issuecomment-541385009
 
 
   **[Test build #111988 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/111988/testReport)**
 for PR 25816 at commit 
[`3a5825c`](https://github.com/apache/spark/commit/3a5825c277ecfdf7e504e4542e4b2c39cc0bd892).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA removed a comment on issue #25816: [SPARK-29107][SQL][TESTS] Port window.sql (Part 1)

2019-10-12 Thread GitBox
SparkQA removed a comment on issue #25816: [SPARK-29107][SQL][TESTS] Port 
window.sql (Part 1)
URL: https://github.com/apache/spark/pull/25816#issuecomment-541374790
 
 
   **[Test build #111988 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/111988/testReport)**
 for PR 25816 at commit 
[`3a5825c`](https://github.com/apache/spark/commit/3a5825c277ecfdf7e504e4542e4b2c39cc0bd892).


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] viirya commented on a change in pull request #26094: [SPARK-29442][SQL][PYSPARK] Set `default` mode should override the existing mode

2019-10-12 Thread GitBox
viirya commented on a change in pull request #26094: 
[SPARK-29442][SQL][PYSPARK] Set `default` mode should override the existing mode
URL: https://github.com/apache/spark/pull/26094#discussion_r334262049
 
 

 ##
 File path: sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala
 ##
 @@ -87,10 +87,9 @@ final class DataFrameWriter[T] private[sql](ds: Dataset[T]) 
{
   case "overwrite" => mode(SaveMode.Overwrite)
   case "append" => mode(SaveMode.Append)
   case "ignore" => mode(SaveMode.Ignore)
-  case "error" | "errorifexists" => mode(SaveMode.ErrorIfExists)
-  case "default" => this
 
 Review comment:
   this looks suspicious. looks like we never document "default" option.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] viirya commented on a change in pull request #26094: [SPARK-29442][SQL][PYSPARK] Set `default` mode should override the existing mode

2019-10-12 Thread GitBox
viirya commented on a change in pull request #26094: 
[SPARK-29442][SQL][PYSPARK] Set `default` mode should override the existing mode
URL: https://github.com/apache/spark/pull/26094#discussion_r334262074
 
 

 ##
 File path: sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala
 ##
 @@ -77,7 +77,7 @@ final class DataFrameWriter[T] private[sql](ds: Dataset[T]) {
* `overwrite`: overwrite the existing data.
* `append`: append the data.
* `ignore`: ignore the operation (i.e. no-op).
-   * `error` or `errorifexists`: default option, throw an exception at 
runtime.
+   * `error`, `errorifexists`, or `default`: default option, throw an 
exception at runtime.
 
 Review comment:
   actually, I think it is a bit weird to give a "default" option explicitly. 
I'd tend to remove "default" option, if possible.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on issue #25984: [SPARK-29308][BUILD] Update deps in dev/deps/spark-deps-hadoop-3.2 for hadoop-3.2

2019-10-12 Thread GitBox
AmplabJenkins commented on issue #25984: [SPARK-29308][BUILD] Update deps in 
dev/deps/spark-deps-hadoop-3.2 for hadoop-3.2
URL: https://github.com/apache/spark/pull/25984#issuecomment-541384046
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/111989/
   Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on issue #25984: [SPARK-29308][BUILD] Update deps in dev/deps/spark-deps-hadoop-3.2 for hadoop-3.2

2019-10-12 Thread GitBox
AmplabJenkins removed a comment on issue #25984: [SPARK-29308][BUILD] Update 
deps in dev/deps/spark-deps-hadoop-3.2 for hadoop-3.2
URL: https://github.com/apache/spark/pull/25984#issuecomment-541384046
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/111989/
   Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on issue #25984: [SPARK-29308][BUILD] Update deps in dev/deps/spark-deps-hadoop-3.2 for hadoop-3.2

2019-10-12 Thread GitBox
AmplabJenkins commented on issue #25984: [SPARK-29308][BUILD] Update deps in 
dev/deps/spark-deps-hadoop-3.2 for hadoop-3.2
URL: https://github.com/apache/spark/pull/25984#issuecomment-541384045
 
 
   Merged build finished. Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on issue #25984: [SPARK-29308][BUILD] Update deps in dev/deps/spark-deps-hadoop-3.2 for hadoop-3.2

2019-10-12 Thread GitBox
AmplabJenkins removed a comment on issue #25984: [SPARK-29308][BUILD] Update 
deps in dev/deps/spark-deps-hadoop-3.2 for hadoop-3.2
URL: https://github.com/apache/spark/pull/25984#issuecomment-541384045
 
 
   Merged build finished. Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA removed a comment on issue #25984: [SPARK-29308][BUILD] Update deps in dev/deps/spark-deps-hadoop-3.2 for hadoop-3.2

2019-10-12 Thread GitBox
SparkQA removed a comment on issue #25984: [SPARK-29308][BUILD] Update deps in 
dev/deps/spark-deps-hadoop-3.2 for hadoop-3.2
URL: https://github.com/apache/spark/pull/25984#issuecomment-541376512
 
 
   **[Test build #111989 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/111989/testReport)**
 for PR 25984 at commit 
[`e56a8c6`](https://github.com/apache/spark/commit/e56a8c617a1d11cf41b0b074bfb5c62f8d991000).


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on issue #25984: [SPARK-29308][BUILD] Update deps in dev/deps/spark-deps-hadoop-3.2 for hadoop-3.2

2019-10-12 Thread GitBox
SparkQA commented on issue #25984: [SPARK-29308][BUILD] Update deps in 
dev/deps/spark-deps-hadoop-3.2 for hadoop-3.2
URL: https://github.com/apache/spark/pull/25984#issuecomment-541383944
 
 
   **[Test build #111989 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/111989/testReport)**
 for PR 25984 at commit 
[`e56a8c6`](https://github.com/apache/spark/commit/e56a8c617a1d11cf41b0b074bfb5c62f8d991000).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] dongjoon-hyun commented on issue #26096: [SPARK-27831][FOLLOWUP][SQL][TEST] ADDITIONAL_REMOTE_REPOSITORIES is a comma-delimited string

2019-10-12 Thread GitBox
dongjoon-hyun commented on issue #26096: [SPARK-27831][FOLLOWUP][SQL][TEST] 
ADDITIONAL_REMOTE_REPOSITORIES is a comma-delimited string
URL: https://github.com/apache/spark/pull/26096#issuecomment-541382474
 
 
   Thank you for review and merging, @wangyum ! 😄 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on issue #26042: [SPARK-29092][SQL] Report additional information about DataSourceScanExec in EXPLAIN FORMATTED

2019-10-12 Thread GitBox
AmplabJenkins removed a comment on issue #26042: [SPARK-29092][SQL] Report 
additional information about DataSourceScanExec in EXPLAIN FORMATTED
URL: https://github.com/apache/spark/pull/26042#issuecomment-541381802
 
 
   Merged build finished. Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on issue #26042: [SPARK-29092][SQL] Report additional information about DataSourceScanExec in EXPLAIN FORMATTED

2019-10-12 Thread GitBox
AmplabJenkins commented on issue #26042: [SPARK-29092][SQL] Report additional 
information about DataSourceScanExec in EXPLAIN FORMATTED
URL: https://github.com/apache/spark/pull/26042#issuecomment-541381802
 
 
   Merged build finished. Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on issue #26042: [SPARK-29092][SQL] Report additional information about DataSourceScanExec in EXPLAIN FORMATTED

2019-10-12 Thread GitBox
AmplabJenkins removed a comment on issue #26042: [SPARK-29092][SQL] Report 
additional information about DataSourceScanExec in EXPLAIN FORMATTED
URL: https://github.com/apache/spark/pull/26042#issuecomment-541381804
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/111986/
   Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on issue #26042: [SPARK-29092][SQL] Report additional information about DataSourceScanExec in EXPLAIN FORMATTED

2019-10-12 Thread GitBox
AmplabJenkins commented on issue #26042: [SPARK-29092][SQL] Report additional 
information about DataSourceScanExec in EXPLAIN FORMATTED
URL: https://github.com/apache/spark/pull/26042#issuecomment-541381804
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/111986/
   Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA removed a comment on issue #26042: [SPARK-29092][SQL] Report additional information about DataSourceScanExec in EXPLAIN FORMATTED

2019-10-12 Thread GitBox
SparkQA removed a comment on issue #26042: [SPARK-29092][SQL] Report additional 
information about DataSourceScanExec in EXPLAIN FORMATTED
URL: https://github.com/apache/spark/pull/26042#issuecomment-541371218
 
 
   **[Test build #111986 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/111986/testReport)**
 for PR 26042 at commit 
[`d07e2b0`](https://github.com/apache/spark/commit/d07e2b0e8cde8d4f3712f0c05957d5d0477a11a1).


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on issue #26042: [SPARK-29092][SQL] Report additional information about DataSourceScanExec in EXPLAIN FORMATTED

2019-10-12 Thread GitBox
SparkQA commented on issue #26042: [SPARK-29092][SQL] Report additional 
information about DataSourceScanExec in EXPLAIN FORMATTED
URL: https://github.com/apache/spark/pull/26042#issuecomment-541381730
 
 
   **[Test build #111986 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/111986/testReport)**
 for PR 26042 at commit 
[`d07e2b0`](https://github.com/apache/spark/commit/d07e2b0e8cde8d4f3712f0c05957d5d0477a11a1).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] stczwd commented on issue #26098: Add configuration to support JacksonGenrator to keep fields with null values

2019-10-12 Thread GitBox
stczwd commented on issue #26098: Add configuration to support JacksonGenrator 
to keep fields with null values
URL: https://github.com/apache/spark/pull/26098#issuecomment-541380230
 
 
   > Hi, @stczwd . Thank you for making a PR.
   > Does this PR resolve SPARK-23773 ? Otherwise, you need to file an 
independent JIRA issue for this.
   
   Yes, this PR can resolve this problem


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] stczwd commented on a change in pull request #26098: Add configuration to support JacksonGenrator to keep fields with null values

2019-10-12 Thread GitBox
stczwd commented on a change in pull request #26098: Add configuration to 
support JacksonGenrator to keep fields with null values
URL: https://github.com/apache/spark/pull/26098#discussion_r334260536
 
 

 ##
 File path: 
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/json/JacksonGeneratorSuite.scala
 ##
 @@ -39,6 +39,18 @@ class JacksonGeneratorSuite extends SparkFunSuite {
 assert(writer.toString === """{"a":1}""")
   }
 
+  test("initial with StructType and write out an empty row with 
allowStructIncludeNull=true") {
 
 Review comment:
   ok


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on issue #26094: [SPARK-29442][SQL][PYSPARK] Set `default` mode should override the existing mode

2019-10-12 Thread GitBox
AmplabJenkins removed a comment on issue #26094: [SPARK-29442][SQL][PYSPARK] 
Set `default` mode should override the existing mode
URL: https://github.com/apache/spark/pull/26094#issuecomment-541379684
 
 
   Merged build finished. Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on issue #26094: [SPARK-29442][SQL][PYSPARK] Set `default` mode should override the existing mode

2019-10-12 Thread GitBox
AmplabJenkins commented on issue #26094: [SPARK-29442][SQL][PYSPARK] Set 
`default` mode should override the existing mode
URL: https://github.com/apache/spark/pull/26094#issuecomment-541379686
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/111980/
   Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on issue #26094: [SPARK-29442][SQL][PYSPARK] Set `default` mode should override the existing mode

2019-10-12 Thread GitBox
AmplabJenkins removed a comment on issue #26094: [SPARK-29442][SQL][PYSPARK] 
Set `default` mode should override the existing mode
URL: https://github.com/apache/spark/pull/26094#issuecomment-541379686
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/111980/
   Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on issue #26094: [SPARK-29442][SQL][PYSPARK] Set `default` mode should override the existing mode

2019-10-12 Thread GitBox
AmplabJenkins commented on issue #26094: [SPARK-29442][SQL][PYSPARK] Set 
`default` mode should override the existing mode
URL: https://github.com/apache/spark/pull/26094#issuecomment-541379684
 
 
   Merged build finished. Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA removed a comment on issue #26094: [SPARK-29442][SQL][PYSPARK] Set `default` mode should override the existing mode

2019-10-12 Thread GitBox
SparkQA removed a comment on issue #26094: [SPARK-29442][SQL][PYSPARK] Set 
`default` mode should override the existing mode
URL: https://github.com/apache/spark/pull/26094#issuecomment-541368166
 
 
   **[Test build #111980 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/111980/testReport)**
 for PR 26094 at commit 
[`a4751f6`](https://github.com/apache/spark/commit/a4751f6334fc9977be51e5eb4e36727c9de2a874).


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on issue #26094: [SPARK-29442][SQL][PYSPARK] Set `default` mode should override the existing mode

2019-10-12 Thread GitBox
SparkQA commented on issue #26094: [SPARK-29442][SQL][PYSPARK] Set `default` 
mode should override the existing mode
URL: https://github.com/apache/spark/pull/26094#issuecomment-541379629
 
 
   **[Test build #111980 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/111980/testReport)**
 for PR 26094 at commit 
[`a4751f6`](https://github.com/apache/spark/commit/a4751f6334fc9977be51e5eb4e36727c9de2a874).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] turboFei commented on issue #26086: [SPARK-29302] Make the file name of a task for dynamic partition overwrite be unique

2019-10-12 Thread GitBox
turboFei commented on issue #26086: [SPARK-29302] Make the file name of a task 
for dynamic partition overwrite be unique
URL: https://github.com/apache/spark/pull/26086#issuecomment-541378398
 
 
   > > How about using this method to name a task file for dynamic partition 
overwrite only?
   > 
   > Which method do you mean here ?
   
   Name a task file with taskId and attemptId.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on issue #26058: [SPARK-10614][core] Add monotonic time to Clock interface.

2019-10-12 Thread GitBox
AmplabJenkins removed a comment on issue #26058: [SPARK-10614][core] Add 
monotonic time to Clock interface.
URL: https://github.com/apache/spark/pull/26058#issuecomment-541378177
 
 
   Merged build finished. Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on issue #26058: [SPARK-10614][core] Add monotonic time to Clock interface.

2019-10-12 Thread GitBox
AmplabJenkins commented on issue #26058: [SPARK-10614][core] Add monotonic time 
to Clock interface.
URL: https://github.com/apache/spark/pull/26058#issuecomment-541378182
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/111985/
   Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on issue #26058: [SPARK-10614][core] Add monotonic time to Clock interface.

2019-10-12 Thread GitBox
AmplabJenkins removed a comment on issue #26058: [SPARK-10614][core] Add 
monotonic time to Clock interface.
URL: https://github.com/apache/spark/pull/26058#issuecomment-541378182
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/111985/
   Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on issue #26058: [SPARK-10614][core] Add monotonic time to Clock interface.

2019-10-12 Thread GitBox
AmplabJenkins commented on issue #26058: [SPARK-10614][core] Add monotonic time 
to Clock interface.
URL: https://github.com/apache/spark/pull/26058#issuecomment-541378177
 
 
   Merged build finished. Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA removed a comment on issue #26058: [SPARK-10614][core] Add monotonic time to Clock interface.

2019-10-12 Thread GitBox
SparkQA removed a comment on issue #26058: [SPARK-10614][core] Add monotonic 
time to Clock interface.
URL: https://github.com/apache/spark/pull/26058#issuecomment-541369689
 
 
   **[Test build #111985 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/111985/testReport)**
 for PR 26058 at commit 
[`fc1cb0d`](https://github.com/apache/spark/commit/fc1cb0dc60816e10254a113fdb371a35c0202c2b).


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on issue #26058: [SPARK-10614][core] Add monotonic time to Clock interface.

2019-10-12 Thread GitBox
SparkQA commented on issue #26058: [SPARK-10614][core] Add monotonic time to 
Clock interface.
URL: https://github.com/apache/spark/pull/26058#issuecomment-541378050
 
 
   **[Test build #111985 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/111985/testReport)**
 for PR 26058 at commit 
[`fc1cb0d`](https://github.com/apache/spark/commit/fc1cb0dc60816e10254a113fdb371a35c0202c2b).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] manuzhang commented on issue #26086: [SPARK-29302] Make the file name of a task for dynamic partition overwrite be unique

2019-10-12 Thread GitBox
manuzhang commented on issue #26086: [SPARK-29302] Make the file name of a task 
for dynamic partition overwrite be unique
URL: https://github.com/apache/spark/pull/26086#issuecomment-541377635
 
 
   > How about using this method to name a task file for dynamic partition 
overwrite only?
   
   Which method do you mean here ?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on issue #26071: [SPARK-29412][SQL] refine the document of v2 session catalog config

2019-10-12 Thread GitBox
AmplabJenkins removed a comment on issue #26071: [SPARK-29412][SQL] refine the 
document of v2 session catalog config
URL: https://github.com/apache/spark/pull/26071#issuecomment-541377537
 
 
   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/111983/
   Test FAILed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on issue #26071: [SPARK-29412][SQL] refine the document of v2 session catalog config

2019-10-12 Thread GitBox
AmplabJenkins removed a comment on issue #26071: [SPARK-29412][SQL] refine the 
document of v2 session catalog config
URL: https://github.com/apache/spark/pull/26071#issuecomment-541377535
 
 
   Merged build finished. Test FAILed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on issue #26071: [SPARK-29412][SQL] refine the document of v2 session catalog config

2019-10-12 Thread GitBox
AmplabJenkins commented on issue #26071: [SPARK-29412][SQL] refine the document 
of v2 session catalog config
URL: https://github.com/apache/spark/pull/26071#issuecomment-541377535
 
 
   Merged build finished. Test FAILed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on issue #26071: [SPARK-29412][SQL] refine the document of v2 session catalog config

2019-10-12 Thread GitBox
AmplabJenkins commented on issue #26071: [SPARK-29412][SQL] refine the document 
of v2 session catalog config
URL: https://github.com/apache/spark/pull/26071#issuecomment-541377537
 
 
   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/111983/
   Test FAILed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA removed a comment on issue #26071: [SPARK-29412][SQL] refine the document of v2 session catalog config

2019-10-12 Thread GitBox
SparkQA removed a comment on issue #26071: [SPARK-29412][SQL] refine the 
document of v2 session catalog config
URL: https://github.com/apache/spark/pull/26071#issuecomment-541368569
 
 
   **[Test build #111983 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/111983/testReport)**
 for PR 26071 at commit 
[`c54b156`](https://github.com/apache/spark/commit/c54b1563aa8a5c758a47f7aabc1808a305ad21c2).


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on issue #26071: [SPARK-29412][SQL] refine the document of v2 session catalog config

2019-10-12 Thread GitBox
SparkQA commented on issue #26071: [SPARK-29412][SQL] refine the document of v2 
session catalog config
URL: https://github.com/apache/spark/pull/26071#issuecomment-541377487
 
 
   **[Test build #111983 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/111983/testReport)**
 for PR 26071 at commit 
[`c54b156`](https://github.com/apache/spark/commit/c54b1563aa8a5c758a47f7aabc1808a305ad21c2).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
 * `class CatalogManager(`


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] wangyum commented on issue #26096: [SPARK-27831][FOLLOWUP][SQL][TEST] ADDITIONAL_REMOTE_REPOSITORIES is a comma-delimited string

2019-10-12 Thread GitBox
wangyum commented on issue #26096: [SPARK-27831][FOLLOWUP][SQL][TEST] 
ADDITIONAL_REMOTE_REPOSITORIES is a comma-delimited string
URL: https://github.com/apache/spark/pull/26096#issuecomment-541377407
 
 
   Merged to master.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] wangyum closed pull request #26096: [SPARK-27831][FOLLOWUP][SQL][TEST] ADDITIONAL_REMOTE_REPOSITORIES is a comma-delimited string

2019-10-12 Thread GitBox
wangyum closed pull request #26096: [SPARK-27831][FOLLOWUP][SQL][TEST] 
ADDITIONAL_REMOTE_REPOSITORIES is a comma-delimited string
URL: https://github.com/apache/spark/pull/26096
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on issue #26078: [SPARK-29151][CORE] Support fractional resources for task resource scheduling

2019-10-12 Thread GitBox
AmplabJenkins removed a comment on issue #26078: [SPARK-29151][CORE] Support 
fractional resources for task resource scheduling
URL: https://github.com/apache/spark/pull/26078#issuecomment-541236575
 
 
   Can one of the admins verify this patch?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] tgravescs commented on issue #26078: [SPARK-29151][CORE] Support fractional resources for task resource scheduling

2019-10-12 Thread GitBox
tgravescs commented on issue #26078: [SPARK-29151][CORE] Support fractional 
resources for task resource scheduling
URL: https://github.com/apache/spark/pull/26078#issuecomment-541377123
 
 
   Ok to test


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on issue #26093: [SPARK-27812][K8s] Bump client version

2019-10-12 Thread GitBox
AmplabJenkins removed a comment on issue #26093: [SPARK-27812][K8s] Bump client 
version 
URL: https://github.com/apache/spark/pull/26093#issuecomment-541376980
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/111979/
   Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on issue #26093: [SPARK-27812][K8s] Bump client version

2019-10-12 Thread GitBox
AmplabJenkins removed a comment on issue #26093: [SPARK-27812][K8s] Bump client 
version 
URL: https://github.com/apache/spark/pull/26093#issuecomment-541376979
 
 
   Merged build finished. Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] dongjoon-hyun edited a comment on issue #26093: [SPARK-27812][K8s] Bump client version

2019-10-12 Thread GitBox
dongjoon-hyun edited a comment on issue #26093: [SPARK-27812][K8s] Bump client 
version 
URL: https://github.com/apache/spark/pull/26093#issuecomment-541367912
 
 
   @igorcalabria . The following claims is not matched with your PR description.
   > Standard kubernetes tests should validate this patch.
   
   Please describe how to test this for the following for the reviewer. 
(Technically, this PR need a test case for that. Or, at least, manual testing 
process should be described in the PR description and should be the commit log.)
   > https://issues.apache.org/jira/browse/SPARK-27812
   > https://issues.apache.org/jira/browse/SPARK-27927


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on issue #26093: [SPARK-27812][K8s] Bump client version

2019-10-12 Thread GitBox
AmplabJenkins commented on issue #26093: [SPARK-27812][K8s] Bump client version 
URL: https://github.com/apache/spark/pull/26093#issuecomment-541376980
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/111979/
   Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on issue #26093: [SPARK-27812][K8s] Bump client version

2019-10-12 Thread GitBox
AmplabJenkins commented on issue #26093: [SPARK-27812][K8s] Bump client version 
URL: https://github.com/apache/spark/pull/26093#issuecomment-541376979
 
 
   Merged build finished. Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on issue #26093: [SPARK-27812][K8s] Bump client version

2019-10-12 Thread GitBox
AmplabJenkins removed a comment on issue #26093: [SPARK-27812][K8s] Bump client 
version 
URL: https://github.com/apache/spark/pull/26093#issuecomment-541368189
 
 
   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/16994/
   Test FAILed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on issue #26093: [SPARK-27812][K8s] Bump client version

2019-10-12 Thread GitBox
SparkQA commented on issue #26093: [SPARK-27812][K8s] Bump client version 
URL: https://github.com/apache/spark/pull/26093#issuecomment-541376894
 
 
   **[Test build #111979 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/111979/testReport)**
 for PR 26093 at commit 
[`7f15bac`](https://github.com/apache/spark/commit/7f15bacbb9b8ac4a448e3f0fca8213632c07c52d).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on issue #25984: [SPARK-29308][BUILD] Update deps in dev/deps/spark-deps-hadoop-3.2 for hadoop-3.2

2019-10-12 Thread GitBox
AmplabJenkins removed a comment on issue #25984: [SPARK-29308][BUILD] Update 
deps in dev/deps/spark-deps-hadoop-3.2 for hadoop-3.2
URL: https://github.com/apache/spark/pull/25984#issuecomment-541376573
 
 
   Merged build finished. Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on issue #25984: [SPARK-29308][BUILD] Update deps in dev/deps/spark-deps-hadoop-3.2 for hadoop-3.2

2019-10-12 Thread GitBox
AmplabJenkins removed a comment on issue #25984: [SPARK-29308][BUILD] Update 
deps in dev/deps/spark-deps-hadoop-3.2 for hadoop-3.2
URL: https://github.com/apache/spark/pull/25984#issuecomment-541376574
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/17004/
   Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on issue #25984: [SPARK-29308][BUILD] Update deps in dev/deps/spark-deps-hadoop-3.2 for hadoop-3.2

2019-10-12 Thread GitBox
AmplabJenkins commented on issue #25984: [SPARK-29308][BUILD] Update deps in 
dev/deps/spark-deps-hadoop-3.2 for hadoop-3.2
URL: https://github.com/apache/spark/pull/25984#issuecomment-541376574
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/17004/
   Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on issue #25984: [SPARK-29308][BUILD] Update deps in dev/deps/spark-deps-hadoop-3.2 for hadoop-3.2

2019-10-12 Thread GitBox
AmplabJenkins commented on issue #25984: [SPARK-29308][BUILD] Update deps in 
dev/deps/spark-deps-hadoop-3.2 for hadoop-3.2
URL: https://github.com/apache/spark/pull/25984#issuecomment-541376573
 
 
   Merged build finished. Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on issue #25984: [SPARK-29308][BUILD] Update deps in dev/deps/spark-deps-hadoop-3.2 for hadoop-3.2

2019-10-12 Thread GitBox
SparkQA commented on issue #25984: [SPARK-29308][BUILD] Update deps in 
dev/deps/spark-deps-hadoop-3.2 for hadoop-3.2
URL: https://github.com/apache/spark/pull/25984#issuecomment-541376512
 
 
   **[Test build #111989 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/111989/testReport)**
 for PR 25984 at commit 
[`e56a8c6`](https://github.com/apache/spark/commit/e56a8c617a1d11cf41b0b074bfb5c62f8d991000).


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] dongjoon-hyun commented on issue #26096: [SPARK-27831][FOLLOWUP][SQL][TEST] ADDITIONAL_REMOTE_REPOSITORIES is a comma-delimited string

2019-10-12 Thread GitBox
dongjoon-hyun commented on issue #26096: [SPARK-27831][FOLLOWUP][SQL][TEST] 
ADDITIONAL_REMOTE_REPOSITORIES is a comma-delimited string
URL: https://github.com/apache/spark/pull/26096#issuecomment-541376533
 
 
   Could you review this once more, @wangyum ?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] dongjoon-hyun edited a comment on issue #25816: [SPARK-29107][SQL][TESTS] Port window.sql (Part 1)

2019-10-12 Thread GitBox
dongjoon-hyun edited a comment on issue #25816: [SPARK-29107][SQL][TESTS] Port 
window.sql (Part 1)
URL: https://github.com/apache/spark/pull/25816#issuecomment-541376447
 
 
   I checked the diff. There is additional addition from line 1257, but that is 
irrelevant to this PR because this PR is only for line 1 to line 319.
   ```
   ~/A/postgres:REL_12_STABLE$ git diff REL_12_BETA4 
src/test/regress/sql/window.sql
   diff --git a/src/test/regress/sql/window.sql 
b/src/test/regress/sql/window.sql
   index fc6d4cc903..fe273aa31e 100644
   --- a/src/test/regress/sql/window.sql
   +++ b/src/test/regress/sql/window.sql
   @@ -1257,3 +1257,22 @@ SELECT to_char(SUM(n::float8) OVER (ORDER BY i ROWS 
BETWEEN CURRENT ROW AND 1 FO
SELECT i, b, bool_and(b) OVER w, bool_or(b) OVER w
  FROM (VALUES (1,true), (2,true), (3,false), (4,false), (5,true)) v(i,b)
  WINDOW w AS (ORDER BY i ROWS BETWEEN CURRENT ROW AND 1 FOLLOWING);
   +
   +-- Tests for problems with failure to walk or mutate expressions
   +-- within window frame clauses.
   +
   +-- test walker (fails with collation error if expressions are not walked)
   +SELECT array_agg(i) OVER w
   +  FROM generate_series(1,5) i
   +WINDOW w AS (ORDER BY i ROWS BETWEEN (('foo' < 'foobar')::integer) 
PRECEDING AND CURRENT ROW);
   +
   +-- test mutator (fails when inlined if expressions are not mutated)
   +CREATE FUNCTION pg_temp.f(group_size BIGINT) RETURNS SETOF integer[]
   +AS $$
   +SELECT array_agg(s) OVER w
   +  FROM generate_series(1,5) s
   +WINDOW w AS (ORDER BY s ROWS BETWEEN CURRENT ROW AND GROUP_SIZE 
FOLLOWING)
   +$$ LANGUAGE SQL STABLE;
   +
   +EXPLAIN (costs off) SELECT * FROM pg_temp.f(2);
   +SELECT * FROM pg_temp.f(2);
   ```
   
   Please simply update the link with `REL_12_STABLE` in the PR description and 
code.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] dongjoon-hyun commented on issue #25816: [SPARK-29107][SQL][TESTS] Port window.sql (Part 1)

2019-10-12 Thread GitBox
dongjoon-hyun commented on issue #25816: [SPARK-29107][SQL][TESTS] Port 
window.sql (Part 1)
URL: https://github.com/apache/spark/pull/25816#issuecomment-541376447
 
 
   I checked the diff. There is additional addition from line 1257, but that is 
irrelevant to this PR because this PR is only for line 1 to line 319.
   ```
   ~/A/postgres:REL_12_STABLE$ git diff REL_12_BETA4 
src/test/regress/sql/window.sql
   diff --git a/src/test/regress/sql/window.sql 
b/src/test/regress/sql/window.sql
   index fc6d4cc903..fe273aa31e 100644
   --- a/src/test/regress/sql/window.sql
   +++ b/src/test/regress/sql/window.sql
   @@ -1257,3 +1257,22 @@ SELECT to_char(SUM(n::float8) OVER (ORDER BY i ROWS 
BETWEEN CURRENT ROW AND 1 FO
SELECT i, b, bool_and(b) OVER w, bool_or(b) OVER w
  FROM (VALUES (1,true), (2,true), (3,false), (4,false), (5,true)) v(i,b)
  WINDOW w AS (ORDER BY i ROWS BETWEEN CURRENT ROW AND 1 FOLLOWING);
   +
   +-- Tests for problems with failure to walk or mutate expressions
   +-- within window frame clauses.
   +
   +-- test walker (fails with collation error if expressions are not walked)
   +SELECT array_agg(i) OVER w
   +  FROM generate_series(1,5) i
   +WINDOW w AS (ORDER BY i ROWS BETWEEN (('foo' < 'foobar')::integer) 
PRECEDING AND CURRENT ROW);
   +
   +-- test mutator (fails when inlined if expressions are not mutated)
   +CREATE FUNCTION pg_temp.f(group_size BIGINT) RETURNS SETOF integer[]
   +AS $$
   +SELECT array_agg(s) OVER w
   +  FROM generate_series(1,5) s
   +WINDOW w AS (ORDER BY s ROWS BETWEEN CURRENT ROW AND GROUP_SIZE 
FOLLOWING)
   +$$ LANGUAGE SQL STABLE;
   +
   +EXPLAIN (costs off) SELECT * FROM pg_temp.f(2);
   +SELECT * FROM pg_temp.f(2);
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AngersZhuuuu commented on a change in pull request #25984: [SPARK-29308][BUILD] Update deps in dev/deps/spark-deps-hadoop-3.2 for hadoop-3.2

2019-10-12 Thread GitBox
AngersZh commented on a change in pull request #25984: [SPARK-29308][BUILD] 
Update deps in dev/deps/spark-deps-hadoop-3.2 for hadoop-3.2
URL: https://github.com/apache/spark/pull/25984#discussion_r334258873
 
 

 ##
 File path: licenses-binary/LICENSE-javax-transaction-transaction-api.txt
 ##
 @@ -0,0 +1,119 @@
+COMMON DEVELOPMENT AND DISTRIBUTION LICENSE (CDDL) Version 1.0
+
+1. Definitions.
+
+1.1. Contributor means each individual or entity that creates or contributes 
to the creation of Modifications.
+
+1.2. Contributor Version means the combination of the Original Software, prior 
Modifications used by a Contributor (if any), and the Modifications made by 
that particular Contributor.
+
+1.3. Covered Software means (a) the Original Software, or (b) Modifications, 
or (c) the combination of files containing Original Software with files 
containing Modifications, in each case including portions thereof.
+
+1.4. Executable means the Covered Software in any form other than Source Code.
+
+1.5. Initial Developer means the individual or entity that first makes 
Original Software available under this License.
+
+1.6. Larger Work means a work which combines Covered Software or portions 
thereof with code not governed by the terms of this License.
+
+1.7. License means this document.
+
+1.8. Licensable means having the right to grant, to the maximum extent 
possible, whether at the time of the initial grant or subsequently acquired, 
any and all of the rights conveyed herein.
+
+1.9. Modifications means the Source Code and Executable form of any of the 
following:
+
+A. Any file that results from an addition to, deletion from or modification of 
the contents of a file containing Original Software or previous Modifications;
+
+B. Any new file that contains any part of the Original Software or previous 
Modification; or
+
+C. Any new file that is contributed or otherwise made available under the 
terms of this License.
+
+1.10. Original Software means the Source Code and Executable form of computer 
software code that is originally released under this License.
+
+1.11. Patent Claims means any patent claim(s), now owned or hereafter 
acquired, including without limitation, method, process, and apparatus claims, 
in any patent Licensable by grantor.
+
+1.12. Source Code means (a) the common form of computer software code in which 
modifications are made and (b) associated documentation included in or with 
such code.
+
+1.13. You (or Your) means an individual or a legal entity exercising rights 
under, and complying with all of the terms of, this License. For legal 
entities, You includes any entity which controls, is controlled by, or is under 
common control with You. For purposes of this definition, control means (a)�the 
power, direct or indirect, to cause the direction or management of such entity, 
whether by contract or otherwise, or (b)�ownership of more than fifty percent 
(50%) of the outstanding shares or beneficial ownership of such entity.
 
 Review comment:
   > The original license has a non-ascii char?
   
   Remove non-ascii char by hand. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AngersZhuuuu commented on a change in pull request #25984: [SPARK-29308][BUILD] Update deps in dev/deps/spark-deps-hadoop-3.2 for hadoop-3.2

2019-10-12 Thread GitBox
AngersZh commented on a change in pull request #25984: [SPARK-29308][BUILD] 
Update deps in dev/deps/spark-deps-hadoop-3.2 for hadoop-3.2
URL: https://github.com/apache/spark/pull/25984#discussion_r334258814
 
 

 ##
 File path: licenses-binary/LICENSE-javax-transaction-transaction-api.txt
 ##
 @@ -0,0 +1,119 @@
+COMMON DEVELOPMENT AND DISTRIBUTION LICENSE (CDDL) Version 1.0
+
+1. Definitions.
+
+1.1. Contributor means each individual or entity that creates or contributes 
to the creation of Modifications.
+
+1.2. Contributor Version means the combination of the Original Software, prior 
Modifications used by a Contributor (if any), and the Modifications made by 
that particular Contributor.
+
+1.3. Covered Software means (a) the Original Software, or (b) Modifications, 
or (c) the combination of files containing Original Software with files 
containing Modifications, in each case including portions thereof.
+
+1.4. Executable means the Covered Software in any form other than Source Code.
+
+1.5. Initial Developer means the individual or entity that first makes 
Original Software available under this License.
+
+1.6. Larger Work means a work which combines Covered Software or portions 
thereof with code not governed by the terms of this License.
+
+1.7. License means this document.
+
+1.8. Licensable means having the right to grant, to the maximum extent 
possible, whether at the time of the initial grant or subsequently acquired, 
any and all of the rights conveyed herein.
+
+1.9. Modifications means the Source Code and Executable form of any of the 
following:
+
+A. Any file that results from an addition to, deletion from or modification of 
the contents of a file containing Original Software or previous Modifications;
+
+B. Any new file that contains any part of the Original Software or previous 
Modification; or
+
+C. Any new file that is contributed or otherwise made available under the 
terms of this License.
+
+1.10. Original Software means the Source Code and Executable form of computer 
software code that is originally released under this License.
+
+1.11. Patent Claims means any patent claim(s), now owned or hereafter 
acquired, including without limitation, method, process, and apparatus claims, 
in any patent Licensable by grantor.
+
+1.12. Source Code means (a) the common form of computer software code in which 
modifications are made and (b) associated documentation included in or with 
such code.
+
+1.13. You (or Your) means an individual or a legal entity exercising rights 
under, and complying with all of the terms of, this License. For legal 
entities, You includes any entity which controls, is controlled by, or is under 
common control with You. For purposes of this definition, control means (a)�the 
power, direct or indirect, to cause the direction or management of such entity, 
whether by contract or otherwise, or (b)�ownership of more than fifty percent 
(50%) of the outstanding shares or beneficial ownership of such entity.
 
 Review comment:
   > The original license has a non-ascii char?
   
   In my local file I didn't see � . Strange things..


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AngersZhuuuu commented on a change in pull request #25984: [SPARK-29308][BUILD] Update deps in dev/deps/spark-deps-hadoop-3.2 for hadoop-3.2

2019-10-12 Thread GitBox
AngersZh commented on a change in pull request #25984: [SPARK-29308][BUILD] 
Update deps in dev/deps/spark-deps-hadoop-3.2 for hadoop-3.2
URL: https://github.com/apache/spark/pull/25984#discussion_r334258814
 
 

 ##
 File path: licenses-binary/LICENSE-javax-transaction-transaction-api.txt
 ##
 @@ -0,0 +1,119 @@
+COMMON DEVELOPMENT AND DISTRIBUTION LICENSE (CDDL) Version 1.0
+
+1. Definitions.
+
+1.1. Contributor means each individual or entity that creates or contributes 
to the creation of Modifications.
+
+1.2. Contributor Version means the combination of the Original Software, prior 
Modifications used by a Contributor (if any), and the Modifications made by 
that particular Contributor.
+
+1.3. Covered Software means (a) the Original Software, or (b) Modifications, 
or (c) the combination of files containing Original Software with files 
containing Modifications, in each case including portions thereof.
+
+1.4. Executable means the Covered Software in any form other than Source Code.
+
+1.5. Initial Developer means the individual or entity that first makes 
Original Software available under this License.
+
+1.6. Larger Work means a work which combines Covered Software or portions 
thereof with code not governed by the terms of this License.
+
+1.7. License means this document.
+
+1.8. Licensable means having the right to grant, to the maximum extent 
possible, whether at the time of the initial grant or subsequently acquired, 
any and all of the rights conveyed herein.
+
+1.9. Modifications means the Source Code and Executable form of any of the 
following:
+
+A. Any file that results from an addition to, deletion from or modification of 
the contents of a file containing Original Software or previous Modifications;
+
+B. Any new file that contains any part of the Original Software or previous 
Modification; or
+
+C. Any new file that is contributed or otherwise made available under the 
terms of this License.
+
+1.10. Original Software means the Source Code and Executable form of computer 
software code that is originally released under this License.
+
+1.11. Patent Claims means any patent claim(s), now owned or hereafter 
acquired, including without limitation, method, process, and apparatus claims, 
in any patent Licensable by grantor.
+
+1.12. Source Code means (a) the common form of computer software code in which 
modifications are made and (b) associated documentation included in or with 
such code.
+
+1.13. You (or Your) means an individual or a legal entity exercising rights 
under, and complying with all of the terms of, this License. For legal 
entities, You includes any entity which controls, is controlled by, or is under 
common control with You. For purposes of this definition, control means (a)�the 
power, direct or indirect, to cause the direction or management of such entity, 
whether by contract or otherwise, or (b)�ownership of more than fifty percent 
(50%) of the outstanding shares or beneficial ownership of such entity.
 
 Review comment:
   > The original license has a non-ascii char?
   
   In my local file I didn't see � . Strange things..


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] turboFei edited a comment on issue #24142: [SPARK-27194][core] Job failures when task attempts do not clean up spark-staging parquet files

2019-10-12 Thread GitBox
turboFei edited a comment on issue #24142: [SPARK-27194][core] Job failures 
when task attempts do not clean up spark-staging parquet files
URL: https://github.com/apache/spark/pull/24142#issuecomment-541376155
 
 
   Hi, @vanzin  @ajithme  and @cloud-fan 
   We face this problem too.
   Sorry for that I did not notice this PR before and I create a new PR 
https://github.com/apache/spark/pull/26086.
   How about using this method to name a task file for dynamic partition 
overwrite only?
   
   Now, for a dynamic partition overwrite operation, the filename of a task 
output is determined by splitId(taskId) and jobId.
   So, if speculation is enabled, a task would conflict with its relative 
speculation task.
   We can make the file name of a task for dynamic partition overwrite be 
unique.
   And the outputCommitCoordinator would decide which task can commit.
   
   And for dynamic partition overwrite, it keeps a filesToMove set, which would 
not cause duplicate result.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] turboFei commented on issue #24142: [SPARK-27194][core] Job failures when task attempts do not clean up spark-staging parquet files

2019-10-12 Thread GitBox
turboFei commented on issue #24142: [SPARK-27194][core] Job failures when task 
attempts do not clean up spark-staging parquet files
URL: https://github.com/apache/spark/pull/24142#issuecomment-541376155
 
 
   Hi, @vanzin  @ajithme  and @cloud-fan 
   We face this problem too.
   Sorry for that I don't notice this PR before and I create a new PR 
https://github.com/apache/spark/pull/26086.
   How about using this method to name a task file for dynamic partition 
overwrite only?
   
   Now, for a dynamic partition overwrite operation, the filename of a task 
output is determined by splitId(taskId) and jobId.
   So, if speculation is enabled, a task would conflict with its relative 
speculation task.
   We can make the file name of a task for dynamic partition overwrite be 
unique.
   And the outputCommitCoordinator would decide which task can commit.
   
   And for dynamic partition overwrite, it keeps a filesToMove set, which would 
not cause duplicate result.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on issue #25816: [SPARK-29107][SQL][TESTS] Port window.sql (Part 1)

2019-10-12 Thread GitBox
AmplabJenkins removed a comment on issue #25816: [SPARK-29107][SQL][TESTS] Port 
window.sql (Part 1)
URL: https://github.com/apache/spark/pull/25816#issuecomment-541374882
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/17003/
   Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins removed a comment on issue #25816: [SPARK-29107][SQL][TESTS] Port window.sql (Part 1)

2019-10-12 Thread GitBox
AmplabJenkins removed a comment on issue #25816: [SPARK-29107][SQL][TESTS] Port 
window.sql (Part 1)
URL: https://github.com/apache/spark/pull/25816#issuecomment-541374880
 
 
   Merged build finished. Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on issue #25816: [SPARK-29107][SQL][TESTS] Port window.sql (Part 1)

2019-10-12 Thread GitBox
AmplabJenkins commented on issue #25816: [SPARK-29107][SQL][TESTS] Port 
window.sql (Part 1)
URL: https://github.com/apache/spark/pull/25816#issuecomment-541374880
 
 
   Merged build finished. Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] AmplabJenkins commented on issue #25816: [SPARK-29107][SQL][TESTS] Port window.sql (Part 1)

2019-10-12 Thread GitBox
AmplabJenkins commented on issue #25816: [SPARK-29107][SQL][TESTS] Port 
window.sql (Part 1)
URL: https://github.com/apache/spark/pull/25816#issuecomment-541374882
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/17003/
   Test PASSed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] [spark] SparkQA commented on issue #25816: [SPARK-29107][SQL][TESTS] Port window.sql (Part 1)

2019-10-12 Thread GitBox
SparkQA commented on issue #25816: [SPARK-29107][SQL][TESTS] Port window.sql 
(Part 1)
URL: https://github.com/apache/spark/pull/25816#issuecomment-541374790
 
 
   **[Test build #111988 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/111988/testReport)**
 for PR 25816 at commit 
[`3a5825c`](https://github.com/apache/spark/commit/3a5825c277ecfdf7e504e4542e4b2c39cc0bd892).


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



  1   2   3   4   5   6   >