Re: clang: warning fix for vmt.c

[Jeremie Courreges-Anglas]

Mark Kettenis  writes:

> Using a variable for the format string isn't a godd idea.
>
> ok?

ok jca@

>
> Index: dev/pv/vmt.c
> ===
> RCS file: /cvs/src/sys/dev/pv/vmt.c,v
> retrieving revision 1.9
> diff -u -p -r1.9 vmt.c
> --- dev/pv/vmt.c  3 Feb 2016 14:24:05 -   1.9
> +++ dev/pv/vmt.c  24 Sep 2016 17:08:35 -
> @@ -419,7 +419,7 @@ vmt_kvop(void *arg, int op, char *key, c
>   goto done;
>   }
>  
> - if (vm_rpc_send_rpci_tx(sc, buf) != 0) {
> + if (vm_rpc_send_rpci_tx(sc, "%s", buf) != 0) {
>   DPRINTF("%s: error sending command: %s\n", DEVNAME(sc), buf);
>   sc->sc_rpc_error = 1;
>   error = EIO;
>

-- 
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF  DDCC 0DFA 74AE 1524 E7EE

clang: warning fix for vmt.c

[Mark Kettenis]

Using a variable for the format string isn't a godd idea.

ok?


Index: dev/pv/vmt.c
===
RCS file: /cvs/src/sys/dev/pv/vmt.c,v
retrieving revision 1.9
diff -u -p -r1.9 vmt.c
--- dev/pv/vmt.c3 Feb 2016 14:24:05 -   1.9
+++ dev/pv/vmt.c24 Sep 2016 17:08:35 -
@@ -419,7 +419,7 @@ vmt_kvop(void *arg, int op, char *key, c
goto done;
}
 
-   if (vm_rpc_send_rpci_tx(sc, buf) != 0) {
+   if (vm_rpc_send_rpci_tx(sc, "%s", buf) != 0) {
DPRINTF("%s: error sending command: %s\n", DEVNAME(sc), buf);
sc->sc_rpc_error = 1;
error = EIO;