Re: pstat -d fix

2016-10-22 Thread Jeremie Courreges-Anglas
Mark Kettenis  writes:

> If there is no modifier, we should not go down the "longformat" path.
> The amount of breakage is somewhat ABI-dependent, but on armv7
>
>pstat -d x ticks
>
> would print stack garbage.
>
> ok?

ok

>
> Index: pstat.c
> ===
> RCS file: /cvs/src/usr.sbin/pstat/pstat.c,v
> retrieving revision 1.110
> diff -u -p -r1.110 pstat.c
> --- pstat.c   19 Sep 2016 20:10:54 -  1.110
> +++ pstat.c   22 Oct 2016 20:38:15 -
> @@ -270,7 +270,7 @@ main(int argc, char *argv[])
>   mask = 0x;
>   else if (strcmp(mod, "hh") == 0)
>   mask = 0xff;
> - else
> + else if (strcmp(mod, "") != 0)
>   longformat = 1;
>  
>   } else
>


-- 
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF  DDCC 0DFA 74AE 1524 E7EE



pstat -d fix

2016-10-22 Thread Mark Kettenis
If there is no modifier, we should not go down the "longformat" path.
The amount of breakage is somewhat ABI-dependent, but on armv7

   pstat -d x ticks

would print stack garbage.

ok?


Index: pstat.c
===
RCS file: /cvs/src/usr.sbin/pstat/pstat.c,v
retrieving revision 1.110
diff -u -p -r1.110 pstat.c
--- pstat.c 19 Sep 2016 20:10:54 -  1.110
+++ pstat.c 22 Oct 2016 20:38:15 -
@@ -270,7 +270,7 @@ main(int argc, char *argv[])
mask = 0x;
else if (strcmp(mod, "hh") == 0)
mask = 0xff;
-   else
+   else if (strcmp(mod, "") != 0)
longformat = 1;
 
} else