Re: [U-Boot-Users] Support for the ML507

[Michal Simek]

Hi Ricardo,

> Hello again:
> 
>   This is my third submission of the same thing, please be indulgent:

Please don't send next submission of the same thing if you know that minimally
half of these patches are wrong.

Michal

>   This month I have been working on the ml507 board, trying to give it
> support. This boards has a lot of components and I have developed
> drivers for some of them. On my first submission, the board and the
> drivers were on a single diff file. The mail list didn't like a
> message so big so I cutted it in 4 parts, bziped it and resend it.
> Later on I have realized that, it do not support the guidelines on the
> web And it will be huge work for the mantainers to check all that
> code
> 
>   So, I have spent the evening dividing the big patch in 8 independent
> patches. I have used the git tools to prepare the patches and resend
> them... Unfortunatelly some of this files are bigged than the 40kb
> limit If the mail list administrator don't accept this parts you
> can download the full set of patches from my website:
> http://www.ii.uam.es/~rribalda/ml507.tgz
> 
>   Why my patches are so big... They give support to IPs by Xilinx,
> which have some kind of generic drivers to adapt them to multiple
> OS... When the driver was very complex I have used this generic
> drivers and added an adaptor. Because it does not follows the coding
> guidelines, all this drivers have been located under the board
> directory to respect all your "clean" work.
> 
>Sorry for the mess I have created in just a matter of minutes.
> 
> 
>  Best Regards and I hope to see my code on the main line someday.
> 
> 

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Re: [U-Boot-Users] [PATCH] -Support fot the ADT7640 Monitor chip

[Michal Simek]

Clean coding style especially long lines, free lines and please choose only one
email address.

Michal

> Signed-off-by: Ricardo Ribalda Delgado <[EMAIL PROTECTED]>
> ---
>  drivers/hwmon/Makefile  |1 +
>  drivers/hwmon/adt7460.c |   89 
> +++
>  drivers/hwmon/adt7460.h |   49 ++
>  include/dtt.h   |2 +-
>  4 files changed, 140 insertions(+), 1 deletions(-)
>  create mode 100644 drivers/hwmon/adt7460.c
>  create mode 100644 drivers/hwmon/adt7460.h
> 
> diff --git a/drivers/hwmon/Makefile b/drivers/hwmon/Makefile
> index 065433a..83aa297 100644
> --- a/drivers/hwmon/Makefile
> +++ b/drivers/hwmon/Makefile
> @@ -34,6 +34,7 @@ COBJS-y += adm1021.o
>  COBJS-y += ds1621.o
>  COBJS-y += ds1722.o
>  COBJS-y += ds1775.o
> +COBJS-y += adt7460.o

look at line below to proper style.

>  COBJS-$(CONFIG_DTT_LM73) += lm73.o


>  COBJS-y += lm75.o
>  COBJS-y += lm81.o
> diff --git a/drivers/hwmon/adt7460.c b/drivers/hwmon/adt7460.c
> new file mode 100644
> index 000..255d6ed
> --- /dev/null
> +++ b/drivers/hwmon/adt7460.c
> @@ -0,0 +1,89 @@
> +/*   
> +(C) Copyright 2008
> +Ricado Ribalda, Universidad Autonoma de Madrid, 
> ricardo.ribaldauam.es , ricardo.ribaldagmail.com
long line

> +This work has been supported by: Q-Technology  http://qtec.com/
> +
> +This program is free software: you can redistribute it and/or modify
> +it under the terms of the GNU General Public License as published by
> +the Free Software Foundation, either version 3 of the License, or
> +(at your option) any later version.
> +
> +This program is distributed in the hope that it will be useful,
> +but WITHOUT ANY WARRANTY; without even the implied warranty of
> +MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> +GNU General Public License for more details.
> +
> +You should have received a copy of the GNU General Public License
> +along with this program.  If not, see .
> +*/
> +
> +#include 
> +
> +#ifdef CONFIG_DTT_ADT7460

why is this ifdef here?

> +
> +#include 
> +#include 
> +#include "adt7460.h"
> +
> +#define ADT7460_ADDRESS 0x2c
> +
> +
> +int dtt_read(int sensor, int reg)
> +{
> + u8 dir=reg;
> + u8 data;
> +
> + if (-1==i2c_read(ADT7460_ADDRESS,dir,1,&data,1))
> + return -1;
> + 
> + if (data==ADT7460_INVALID)
> + return -1;
> +
> + return data;
> +
> +} 
> +
> +
> +int dtt_write(int sensor, int reg, int val)
> +{
> + u8 dir=reg;
> + u8 data=val;
> + 
> + if (-1==i2c_write(ADT7460_ADDRESS,dir,1,&data,1))
> + return -1;
> +
> + return 0;
> +} 
> +
> +
> +
> +int dtt_init (void)
> +{
> + printf("ADT7460 at I2C address 0x%2x\n",ADT7460_ADDRESS);
> + if (-1==dtt_write(0,ADT7460_CONFIG,1)){
> + printf("Error initialiting ADT7460\n");
> + return -1;
> + }
> + return 0;
> +} 
> +
> +
> +int dtt_get_temp(int sensor)
> +{
> + int aux;
> + u8 table[]={ADT7460_REM1_TEMP,ADT7460_LOCAL_TEMP,ADT7460_REM2_TEMP};
> + if (sensor>2){
> + printf("DTT sensor does not exist\n");
> + return -1;
> + }
> + 
> + aux=dtt_read(0,table[sensor]);
> +
> + if (-1==aux){
> + printf("DTT temperature read failed\n");
> + return -1;
> +
> + }
> + return aux;
> +}
> +#endif 
> diff --git a/drivers/hwmon/adt7460.h b/drivers/hwmon/adt7460.h
> new file mode 100644
> index 000..48666f7
> --- /dev/null
> +++ b/drivers/hwmon/adt7460.h
> @@ -0,0 +1,49 @@
> +/*   
> +(C) Copyright 2008
> +Ricado Ribalda, Universidad Autonoma de Madrid, 
> ricardo.ribaldauam.es , ricardo.ribaldagmail.com
> +This work has been supported by: Q-Technology  http://qtec.com/
> +
> +This program is free software: you can redistribute it and/or modify
> +it under the terms of the GNU General Public License as published by
> +the Free Software Foundation, either version 3 of the License, or
> +(at your option) any later version.
> +
> +This program is distributed in the hope that it will be useful,
> +but WITHOUT ANY WARRANTY; without even the implied warranty of
> +MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> +GNU General Public License for more details.
> +
> +You should have received a copy of the GNU General Public License
> +along with this program.  If not, see .
> +*/
> +#ifndef ADT7460
> +#define ADT7460
> +
> +
> +#define ADT7460_INVALID 128
> +
> +#define ADT7460_2_5V 0x20
> +#define ADT7460_VCCP 0x21
> +#define ADT7460_VCC  0x22
> +#define ADT7460_V5   0x23
> +#define ADT7460_V12  0x24
> +#define ADT7460_REM1_TEMP0x25
> +#define ADT7460_LOCAL_TEMP   0x26
> +#define ADT7460_REM2_TEMP0x27
> +#define ADT7460_TACH1L   0x28
> +#define ADT7460_TACH1H 

Re: [U-Boot-Users] [PATCH] Support fot the ML507 Board 1/4

[Michal Simek]

Hi Ricardo,

> Hi Michael
> 
>   Sorry to hear that. I have tried to give all my best and follow the
> style of the ml300 board, which was the closest board to mine.
> On FPGAs board I think that it is not  a horrible idea to follow this
> style. Maybe you should consider to create an FPGA branch, where the
> generic drivers could be accepted. As I said, the FPGA hardware
> changes a lot and support a so changing hardware will be very
> difficult... Or just should not support FPGAs and its IP devices...

Any FPGA branch is not acceptable in U-BOOT mainline. Mainline U-BOOT is only
one. If you want to add your changes to U-BOOT mainline you have to change your
design style.

> By the way:
> 
>   patches 1 2  and 6 follow the guidelines and don't add any generic driver
>   patches 8 (except xparameters.h) follow the guidelines
>   patch 6 could be redesined. You should be aware that
> driver/serial/serial_xuartlite.c does not compile for ppc440 without
> that patch

This should be truth but without compatible board doesn't make sense to me. You
use any numbers but I haven't seen these numbers anywhere. Please use git for
your work and use more generic subject of your email. In set of patches you use
conventional style which generate git. Add there at the begging ml507 or xilinx
or whatever what will be specify xilinx relate topic.

Michal

>   Best regards
> 
> On Thu, Jul 10, 2008 at 9:04 PM, Michal Simek <[EMAIL PROTECTED]> wrote:
>> Hi Ricardo,
>>
>> I read your patches in your weird style.
>> These style of patches never go to mainline. You use xilinx generated files 
>> which is currently use only with ml300.
>> For example look at your xparameters.h there are a lot of values which are 
>> not used.
>> If you want to add ml507 to mainline U-BOOT you have to change completely 
>> handling style of xilinx board for ppc.
>> In next U-BOOT release I will clean ancient ml300. I want to remove a lot of 
>> xilinx generic files.
>>
>> 100% NACK for these patches.
>>
>> The size of patches is due to your incorrect design strategy.
>>
>> Michal Simek
>>
>>
>> Hi List:
>>
>>  This is my first contribution to u-boot. I have ported u-boot to the
>> ML507 Board by Xilinx.
>> http://www.xilinx.com/products/devkits/HW-V5-ML507-UNI-G.htm
>>
>> This boards includes an FPGA Virtex 5 FX with an embedded PowerPC 440.
>>
>> The port supports:
>>-Virtex 5 ppc440x5
>>-XIlinx Interrupt Controller
>>-Xilinx I2C Controller (Interrupted mode)
>>-Xilinx Uart Lite (simple port)
>>-Xilinx LL_TEMA (Interrupted and SGDMA)
>>-Save environment on board eeprom
>>-DTT support for the ADT sensor on board (new hwmon driver)
>>-Dummy I2C driver (for testing purposes)
>>
>> This patch works against the last commit to the p4xx branch.
>>
>> I am a researcher of the Universidad Autonoma de Madrid, and this work
>> has been supported by Q-Technology ( http://qtec.com ) under a
>> Research Agreement.
>>
>> Any comment will be very welcomed.
>>
>> PS: I have divided the patch in four parts for the mailing list
>> --
>> Ricardo Ribalda
>> http://www.eps.uam.es/~rribalda/
>>
>>
>>
> 
> 
> 

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Re: [U-Boot-Users] [PATCH] I2C Dummy Driver

[Michal Simek]

Clean coding style. http://www.denx.de/wiki/UBoot/CodingStyle


> Signed-off-by: Ricardo Ribalda Delgado <[EMAIL PROTECTED]>
> ---
>  drivers/i2c/Makefile|1 +
>  drivers/i2c/dummy_i2c.c |   84 
> +++
>  2 files changed, 85 insertions(+), 0 deletions(-)
>  create mode 100644 drivers/i2c/dummy_i2c.c
> 
> diff --git a/drivers/i2c/Makefile b/drivers/i2c/Makefile
> index 534c015..322c822 100644
> --- a/drivers/i2c/Makefile
> +++ b/drivers/i2c/Makefile
> @@ -30,6 +30,7 @@ COBJS-y += omap1510_i2c.o
>  COBJS-y += omap24xx_i2c.o
>  COBJS-y += tsi108_i2c.o
>  COBJS-y += mxc_i2c.o
> +COBJS-y += dummy_i2c.o
>  
>  COBJS:= $(COBJS-y)
>  SRCS := $(COBJS:.o=.c)
> diff --git a/drivers/i2c/dummy_i2c.c b/drivers/i2c/dummy_i2c.c
> new file mode 100644
> index 000..04f6edb
> --- /dev/null
> +++ b/drivers/i2c/dummy_i2c.c
> @@ -0,0 +1,84 @@
> +/*   
> +(C) Copyright 2008
> +Ricado Ribalda, Universidad Autonoma de Madrid, 
> ricardo.ribaldauam.es , ricardo.ribaldagmail.com
> +This work has been supported by: Q-Technology  http://qtec.com/
> +
> +This program is free software: you can redistribute it and/or modify
> +it under the terms of the GNU General Public License as published by
> +the Free Software Foundation, either version 3 of the License, or
> +(at your option) any later version.
> +
> +This program is distributed in the hope that it will be useful,
> +but WITHOUT ANY WARRANTY; without even the implied warranty of
> +MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> +GNU General Public License for more details.
> +
> +You should have received a copy of the GNU General Public License
> +along with this program.  If not, see .
> +*/
> +
> +#include 
> +
> +#if defined(CONFIG_DUMMY_I2C)
> +
> +
> +#include 
> +u8 
> i2c_dummy_buffer[256]={0x80,0x8,0x8,0x0D,0x0A,0x60,0x40,0x0,0x5,0x3D,0x50,0x0,0x82,0x10,0x0,0x0,0x0C,0x4,0x18,0x1,0x4,0x0,0x1,0x50,0x50,0x0,0x0,0x3C,0x28,0x3C,0x2D,0x40,0x25,0x37,0x10,0x22,0x3C,0x1E,0x1E,0x0,0x0,0x3C,0x69,0x80,0x1E,0x28,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x12,0xC9,0x2C,'0','0','0','0','0','0','0',0x0,'4','H','T','F','3','2','6','4','H','Y','-','5','3','E','D','3',0x3,0x0,0x0,0x0,0x0};
> + 
> +
> +
> +void i2c_init(int speed, int slaveaddr){
> + return ;
> +}
> +
> +
> +
> +int
> +i2c_read(uchar chip, uint addr, int alen, uchar * buffer, int len)
> +{
> + int i;
> + if (alen!=1)
> + return -1;
> +
> + if (addr+len>0xff)
> + return -1;
> +
> + for(i=0;i + buffer[i]=i2c_dummy_buffer[i+addr];
> + }
> +
> + return 0;
> +
> +
> +}
> +
> +
> +int
> +i2c_write(uchar chip, uint addr, int alen, uchar * buffer, int len)
> +{
> + int i;
> + if (alen!=1)
> + return -1;
> + if (addr+len>0xff)
> + return -1;
> +
> + for(i=0;i + i2c_dummy_buffer[i+addr]=buffer[i];
> + }
> +
> + return 0;
> +}
> +
> +
> +int
> +i2c_probe(uchar chip)
> +{
> + return 0;
> +}
> +
> +
> +
> +
> +
> +#endif
> +

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Re: [U-Boot-Users] [PATCH] Adds support for Xilinx Uart Lite on ppc4xx

[Michal Simek]

100% NACK.


> Signed-off-by: Ricardo Ribalda Delgado <[EMAIL PROTECTED]>
> ---
>  include/asm-ppc/arch-ppc4xx/xbasic_types.h |  301 
> 
>  include/asm-ppc/arch-ppc4xx/xio.h  |   63 ++
>  include/asm-ppc/arch-ppc4xx/xuartlite_l.h  |  256 +++
>  include/asm-ppc/serial_xuartlite.h |   25 +++
>  4 files changed, 645 insertions(+), 0 deletions(-)
>  create mode 100644 include/asm-ppc/arch-ppc4xx/xbasic_types.h
>  create mode 100644 include/asm-ppc/arch-ppc4xx/xio.h
>  create mode 100644 include/asm-ppc/arch-ppc4xx/xuartlite_l.h
>  create mode 100644 include/asm-ppc/serial_xuartlite.h
> 
> diff --git a/include/asm-ppc/arch-ppc4xx/xbasic_types.h 
> b/include/asm-ppc/arch-ppc4xx/xbasic_types.h
> new file mode 100644
> index 000..25012e6
> --- /dev/null
> +++ b/include/asm-ppc/arch-ppc4xx/xbasic_types.h
> @@ -0,0 +1,301 @@
> +/**
> +*
> +* Author: Xilinx, Inc.
> +*
> +*
> +* This program is free software; you can redistribute it and/or modify it
> +* under the terms of the GNU General Public License as published by the
> +* Free Software Foundation; either version 2 of the License, or (at your
> +* option) any later version.
> +*
> +*
> +* XILINX IS PROVIDING THIS DESIGN, CODE, OR INFORMATION "AS IS" AS A
> +* COURTESY TO YOU. BY PROVIDING THIS DESIGN, CODE, OR INFORMATION AS
> +* ONE POSSIBLE IMPLEMENTATION OF THIS FEATURE, APPLICATION OR STANDARD,
> +* XILINX IS MAKING NO REPRESENTATION THAT THIS IMPLEMENTATION IS FREE
> +* FROM ANY CLAIMS OF INFRINGEMENT, AND YOU ARE RESPONSIBLE FOR OBTAINING
> +* ANY THIRD PARTY RIGHTS YOU MAY REQUIRE FOR YOUR IMPLEMENTATION.
> +* XILINX EXPRESSLY DISCLAIMS ANY WARRANTY WHATSOEVER WITH RESPECT TO
> +* THE ADEQUACY OF THE IMPLEMENTATION, INCLUDING BUT NOT LIMITED TO ANY
> +* WARRANTIES OR REPRESENTATIONS THAT THIS IMPLEMENTATION IS FREE FROM
> +* CLAIMS OF INFRINGEMENT, IMPLIED WARRANTIES OF MERCHANTABILITY AND
> +* FITNESS FOR A PARTICULAR PURPOSE.
> +*
> +*
> +* Xilinx hardware products are not intended for use in life support
> +* appliances, devices, or systems. Use in such applications is
> +* expressly prohibited.
> +*
> +*
> +* (c) Copyright 2002-2003 Xilinx Inc.
> +* All rights reserved.
> +*
> +*
> +* You should have received a copy of the GNU General Public License along
> +* with this program; if not, write to the Free Software Foundation, Inc.,
> +* 675 Mass Ave, Cambridge, MA 02139, USA.
> +*
> +**/
> +/*/
> +/**
> +*
> +* @file xbasic_types.h
> +*
> +* This file contains basic types for Xilinx software IP.  These types do not
> +* follow the standard naming convention with respect to using the component
> +* name in front of each name because they are considered to be primitives.
> +*
> +* @note
> +*
> +* This file contains items which are architecture dependent.
> +*
> +* 
> +* MODIFICATION HISTORY:
> +*
> +* Ver WhoDateChanges
> +* -   ---
> +* 1.00a rmm  12/14/01 First release
> +*rmm  05/09/03 Added "xassert always" macros to rid ourselves of diab
> +*  compiler warnings
> +* 
> +*
> +**/
> +
> +#ifndef XBASIC_TYPES_H   /* prevent circular inclusions */
> +#define XBASIC_TYPES_H   /* by using protection macros */
> +
> +/* Include Files 
> */
> +
> +/** Constant Definitions 
> */
> +
> +#ifndef TRUE
> +#define TRUE 1
> +#endif
> +#ifndef FALSE
> +#define FALSE 0
> +#endif
> +
> +#ifndef NULL
> +#define NULL 0
> +#endif
> +/** Null */
> +
> +#define XCOMPONENT_IS_READY  0x  /* component has been 
> initialized */
> +#define XCOMPONENT_IS_STARTED0x  /* component has been 
> started */
> +
> +/* the following constants and declarations are for unit test purposes and 
> are
> + * designed to be used in test applications.
> + */
> +#define XTEST_PASSED 0
> +#define XTEST_FAILED 1
> +
> +#define XASSERT_NONE  0
> +#define XASSERT_OCCURRED 1
> +
> +extern unsigned int XAssertStatus;
> +extern void XAssert(char *, int);
> +
> +/ Type Definitions 
> ***/
> +
> +/** @name Primitive types
> + * These primitive types are created for transportability.
> + * They are dependent upon the target architecture.
> + * @{
> + */
> +#include 
> +
> +typedef struct {
> + u32 Upper;
> + u32 Lower;
> +} Xuint64;
> +
> +/* Xilinx's unsigned integer types */
> +typedef u32 Xuint32;
> +typedef u16 Xuint

[U-Boot-Users] [PATCH] fix DIU for small screens

[Kenneth Johansson]

The DIU_DIV register is 8 bit not 5 bit. This prevented large DIV values
so it was not possible to set a slow pixel clock and thus prevented
display on small screens. 

Signed-off-by: Kenneth Johansson <[EMAIL PROTECTED]>

--- a/board/ads5121/ads5121_diu.c
+++ b/board/ads5121/ads5121_diu.c
@@ -57,7 +57,7 @@ void diu_set_pixel_clock(unsigned int pixclock)
/* Modify PXCLK in GUTS CLKDVDR */
debug("DIU: Current value of CLKDVDR = 0x%08x\n", *clkdvdr);
temp = *clkdvdr & 0xFF00;
-   *clkdvdr = temp | (pixval & 0x1F);
+   *clkdvdr = temp | (pixval & 0xFF);
debug("DIU: Modified value of CLKDVDR = 0x%08x\n", *clkdvdr);
 }



-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

[U-Boot-Users] Undelivered Mail Returned to Sender

[Mail Delivery System]

This is the mail system at host efw-budpar.budpar.go.id.

I'm sorry to have to inform you that your message could not
be delivered to one or more recipients. It's attached below.

For further assistance, please send mail to 

If you do so, please include this problem report. You can
delete your own text from the attached returned message.

   The mail system

<[EMAIL PROTECTED]>: host c.mx.mail.yahoo.com[216.39.53.2] said: 554 delivery
error: dd This user doesn't have a yahoo.com account ([EMAIL PROTECTED]) 
[-5]
- mta215.mail.re4.yahoo.com (in reply to end of DATA command)
Reporting-MTA: dns; efw-budpar.budpar.go.id
X-Postfix-Queue-ID: 5AC192A6D8A
X-Postfix-Sender: rfc822; u-boot-users@lists.sourceforge.net
Arrival-Date: Fri, 11 Jul 2008 09:13:19 +0700 (WIT)

Final-Recipient: rfc822; brent@yahoo.com
Original-Recipient: rfc822;brent@yahoo.com
Action: failed
Status: 5.0.0
Remote-MTA: dns; c.mx.mail.yahoo.com
Diagnostic-Code: smtp; 554 delivery error: dd This user doesn't have a
	yahoo.com account (brent@yahoo.com) [-5] - mta215.mail.re4.yahoo.com
Received: from localhost (localhost [127.0.0.1])
	by efw-budpar.budpar.go.id (Postfix) with ESMTP id 5AC192A6D8A
	for <[EMAIL PROTECTED]>; Fri, 11 Jul 2008 09:13:19 +0700 (WIT)
X-Virus-Scanned: by Endian Firewall
Received: from lists.sourceforge.net (unknown [172.17.100.133])
	by efw-budpar.budpar.go.id (Postfix) with ESMTP id 95C842A6D7D
	for <[EMAIL PROTECTED]>; Fri, 11 Jul 2008 09:13:18 +0700 (WIT)
From: u-boot-users@lists.sourceforge.net
To: [EMAIL PROTECTED]
Subject: Mail Transaction Failed
Date: Fri, 11 Jul 2008 09:13:17 +0700
MIME-Version: 1.0
Content-Type: multipart/mixed;
	boundary="=_NextPart_000_0008_E16CE525.6078328C"
X-Priority: 3
X-MSMail-Priority: Normal
Message-Id: <[EMAIL PROTECTED]>
-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Re: [U-Boot-Users] [PATCH] usb: add support for R8A66597 usb controller

[Nobuhiro Iwamatsu]

Hi, Wolfgang.

2008/7/11 Wolfgang Denk <[EMAIL PROTECTED]>:
> In message <[EMAIL PROTECTED]> you wrote:
>>
>> > Can you not find some simpler name that "r8a66597"? That's a mess to
>> > type and to read.
>>
>> Thank you for your comment.
>>
>> I can change that "struct r8a66597" for a simple name. For example,
>> its name is "struct r597". However, I do not want to change a source
>> file name and CONFIG_ name, because "R8A66597" is product name.
>
> Doesn't the board have an easy to spell and easy to remember nickname
> or so?

Unfortunately this tip does not have nicname and other.
We want to acquire a name same as Linux kernel USB driver..

Best regards,
 Nobuhiro

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

[U-Boot-Users] [PATCH] Round the serial port clock divisor value returned by calc_divisor()

[Jerry Van Baren]

This formula is better at avoiding integer overflow.

Signed-off-by: Gerald Van Baren <[EMAIL PROTECTED]>
---

(try 2)

The formula I proposed previously in this thread compiles OK.  I cannot
verify it is correct on real hardware, however.


Best regards,
gvb 

 drivers/serial/serial.c |4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/drivers/serial/serial.c b/drivers/serial/serial.c
index 182ca2d..48579ae 100644
--- a/drivers/serial/serial.c
+++ b/drivers/serial/serial.c
@@ -150,7 +150,9 @@ static int calc_divisor (NS16550_t port)
 * but we need to round that value by adding 0.5 or 8/16.
 * Rounding is especially important at high baud rates.
 */
-   return (((16 * CFG_NS16550_CLK) / MODE_X_DIV / gd->baudrate) + 8) / 16;
+   return (CFG_NS16550_CLK + (gd->baudrate / 2)) /
+   (MODE_X_DIV * gd->baudrate);
+
 }
 
 #if !defined(CONFIG_SERIAL_MULTI)
-- 
1.5.6


-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

[U-Boot-Users] [PATCH] Enable passing of ATAGs required by latest Linux kernel.

[Marcel Ziswiler]

---
 include/configs/pxa255_idp.h |4 
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/include/configs/pxa255_idp.h b/include/configs/pxa255_idp.h
index 4a9cadb..b7ea1a9 100644
--- a/include/configs/pxa255_idp.h
+++ b/include/configs/pxa255_idp.h
@@ -208,6 +208,10 @@
 /* "protect off"   */
 
 
+#define CONFIG_CMDLINE_TAG 1   /* enable passing of ATAGs */
+#define CONFIG_SETUP_MEMORY_TAGS   1
+/* #define CONFIG_INITRD_TAG   1 */
+
 #if defined(CONFIG_CMD_KGDB)
 #define CONFIG_KGDB_BAUDRATE   115200  /* speed to run kgdb serial 
port */
 #define CONFIG_KGDB_SER_INDEX  2   /* which serial port to use */
-- 
1.5.4.1


-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Re: [U-Boot-Users] [PATCH V2] Round the serial port clock divisor value returned by calc_divisor()

[Jerry Van Baren]

Wolfgang Denk wrote:

In message <[EMAIL PROTECTED]> you wrote:

Round the serial port clock divisor value returned by
calc_divisor().

Signed-off-by: Hugo Villeneuve <[EMAIL PROTECTED]>
Signed-off-by: John Roberts <[EMAIL PROTECTED]>

---

Rounding is important, especially when using high baud rates
values like 115200bps. When using the non-rounded value, some
boards will work and some won't.

 drivers/serial/serial.c |6 +-
 1 files changed, 5 insertions(+), 1 deletions(-)

diff --git a/drivers/serial/serial.c b/drivers/serial/serial.c
index 76425d8..1192f07 100644
--- a/drivers/serial/serial.c
+++ b/drivers/serial/serial.c
@@ -144,8 +144,12 @@ static int calc_divisor (NS16550_t port)
 #else
 #define MODE_X_DIV 16
 #endif
-   return (CFG_NS16550_CLK / MODE_X_DIV / gd->baudrate);
 
+	/* Compute divisor value. Normally, we should simply return:

+*   CFG_NS16550_CLK) / MODE_X_DIV / gd->baudrate
+* but we need to round that value by adding 0.5 or 8/16.
+* Rounding is especially important at high baud rates. */
+   return (((16 * CFG_NS16550_CLK) / MODE_X_DIV / gd->baudrate) + 8) / 16;
 }


Your patch causes problems with some boards:

Configuring for SBC8540 board...
serial.c: In function 'calc_divisor':
serial.c:153: warning: integer overflow in expression
serial.c:153: warning: integer overflow in expression

Configuring for sbc8548 board...
serial.c: In function 'calc_divisor':
serial.c:153: warning: integer overflow in expression
serial.c:153: warning: integer overflow in expression


Do you have a quick fix, or shall I back out the patch?

Best regards,

Wolfgang Denk


The formula I proposed previously in this thread compiles OK.  I cannot 
verify it is correct on real hardware, however.



My apologies for providing the patch as an attachment.  I need to add 
the external editor plugin so I can use tbird for proper inline patches.


Best regards,
gvb

>From 97b1ea8273eec4e45df71e074e0790d39fd6536d Mon Sep 17 00:00:00 2001
From: Gerald Van Baren <[EMAIL PROTECTED]>
Date: Thu, 10 Jul 2008 19:44:28 -0400
Subject: [PATCH] Round the serial port clock divisor value returned by calc_divisor()

This algorithm is better at avoiding integer overflow.

Signed-off-by: Gerald Van Baren <[EMAIL PROTECTED]>
---
 drivers/serial/serial.c |4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/drivers/serial/serial.c b/drivers/serial/serial.c
index 182ca2d..48579ae 100644
--- a/drivers/serial/serial.c
+++ b/drivers/serial/serial.c
@@ -150,7 +150,9 @@ static int calc_divisor (NS16550_t port)
 	 * but we need to round that value by adding 0.5 or 8/16.
 	 * Rounding is especially important at high baud rates.
 	 */
-	return (((16 * CFG_NS16550_CLK) / MODE_X_DIV / gd->baudrate) + 8) / 16;
+	return (CFG_NS16550_CLK + (gd->baudrate / 2)) /
+		(MODE_X_DIV * gd->baudrate);
+
 }
 
 #if !defined(CONFIG_SERIAL_MULTI)
-- 
1.5.6

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

[U-Boot-Users] [PATCH] Fix build time warnings in function mmc_decode_csd.

[Marcel Ziswiler]

---
 cpu/pxa/mmc.c |5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/cpu/pxa/mmc.c b/cpu/pxa/mmc.c
index 4495a80..97ac4a5 100644
--- a/cpu/pxa/mmc.c
+++ b/cpu/pxa/mmc.c
@@ -535,8 +535,9 @@ static void mmc_decode_csd(uint32_t * resp)
mmc_dev.removable = 0;
mmc_dev.block_read = mmc_bread;
 
-   printf("Detected: %u blocks of %u bytes (%uMB) ", mmc_dev.lba,
-  mmc_dev.blksz, mmc_dev.lba * mmc_dev.blksz / (1024 * 1024));
+   printf("Detected: %lu blocks of %lu bytes (%luMB) ",
+  (unsigned long)mmc_dev.lba, mmc_dev.blksz,
+  mmc_dev.lba * mmc_dev.blksz / (1024 * 1024));
 }
 
 int
-- 
1.5.4.1


-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Re: [U-Boot-Users] [PATCH] =?utf-8?q?Fix=20build= 20time=20warnings=20in=20function=20=E2=80 =98mmc=5Fdecode=5Fcsd=E2=80=99:

[Marcel Ziswiler]

Sorry, don't know exactly why it did that utf-8 crap. Will repost ASAP.


-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

[U-Boot-Users] [PATCH] Fix some more print() format errors.

[Wolfgang Denk]

Signed-off-by: Wolfgang Denk <[EMAIL PROTECTED]>
---
 board/ads5121/ads5121.c   |6 --
 board/atum8548/atum8548.c |2 +-
 board/bc3450/cmd_bc3450.c |2 +-
 board/cm5200/cmd_cm5200.c |8 
 board/cm5200/fwupdate.c   |2 +-
 board/fads/flash.c|2 +-
 board/freescale/mpc8544ds/mpc8544ds.c |2 +-
 board/freescale/mpc8610hpcd/mpc8610hpcd.c |4 ++--
 board/freescale/mpc8641hpcn/mpc8641hpcn.c |4 ++--
 board/mcc200/auto_update.c|2 +-
 board/mpc8540eval/flash.c |8 +---
 board/netstal/common/nm_bsp.c |   10 ++
 board/o2dnt/flash.c   |2 +-
 board/sandburst/metrobox/metrobox.c   |2 +-
 board/spc1920/hpi.c   |3 ++-
 board/total5200/total5200.c   |   14 +++---
 board/tqc/tqm5200/cmd_stk52xx.c   |2 +-
 board/tqc/tqm8272/tqm8272.c   |4 ++--
 common/cmd_nand.c |4 ++--
 common/cmd_reginfo.c  |   22 +++---
 cpu/mpc512x/speed.c   |2 +-
 cpu/mpc86xx/traps.c   |2 +-
 drivers/net/uli526x.c |2 +-
 examples/test_burst.c |2 +-
 lib_generic/lmb.c |   20 +++-
 net/net.c |3 ++-
 26 files changed, 73 insertions(+), 63 deletions(-)

diff --git a/board/ads5121/ads5121.c b/board/ads5121/ads5121.c
index de59991..d5cee64 100644
--- a/board/ads5121/ads5121.c
+++ b/board/ads5121/ads5121.c
@@ -29,6 +29,8 @@
 #ifdef CONFIG_MISC_INIT_R
 #include 
 #endif
+#include "iopin.h" /* for iopin_initialize() prototype */
+
 /* Clocks in use */
 #define SCCR1_CLOCKS_EN(CLOCK_SCCR1_CFG_EN |   
\
 CLOCK_SCCR1_LPC_EN |   \
@@ -52,8 +54,7 @@ long int fixed_sdram(void);
 int board_early_init_f (void)
 {
volatile immap_t *im = (immap_t *) CFG_IMMR;
-   u32 lpcaw, tmp32;
-   int i;
+   u32 lpcaw;
 
/*
 * Initialize Local Window for the CPLD registers access (CS2 selects
@@ -206,6 +207,7 @@ long int fixed_sdram (void)
 int misc_init_r(void)
 {
u8 tmp_val;
+   extern int ads5121_diu_init(void);
 
/* Using this for DIU init before the driver in linux takes over
 *  Enable the TFP410 Encoder (I2C address 0x38)
diff --git a/board/atum8548/atum8548.c b/board/atum8548/atum8548.c
index 4d8c6fb..34f4599 100644
--- a/board/atum8548/atum8548.c
+++ b/board/atum8548/atum8548.c
@@ -53,7 +53,7 @@ int checkboard (void)
volatile ccsr_local_ecm_t *ecm = (void *)(CFG_MPC85xx_ECM_ADDR);
 
if ((uint)&gur->porpllsr != 0xe00e) {
-   printf("immap size error %x\n",&gur->porpllsr);
+   printf("immap size error %lx\n",(ulong)&gur->porpllsr);
}
printf ("Board: ATUM8548\n");
 
diff --git a/board/bc3450/cmd_bc3450.c b/board/bc3450/cmd_bc3450.c
index f7f0013..48bc65d 100644
--- a/board/bc3450/cmd_bc3450.c
+++ b/board/bc3450/cmd_bc3450.c
@@ -189,7 +189,7 @@ int cmd_dip (cmd_tbl_t * cmdtp, int flag, int argc, char 
*argv[])
if (rc > 0x0F)
return -1;
 
-   printf ("0x%x\n", rc);
+   printf ("0x%lx\n", rc);
return 0;
 }
 
diff --git a/board/cm5200/cmd_cm5200.c b/board/cm5200/cmd_cm5200.c
index 354f2bf..2201bdd 100644
--- a/board/cm5200/cmd_cm5200.c
+++ b/board/cm5200/cmd_cm5200.c
@@ -335,7 +335,7 @@ int do_rs232(char *argv[])
if (((*(vu_long *)MPC5XXX_WU_GPIO_DATA_I) & 0x1000) !=
0x1000) {
error_status = 2;
-   printf("%s: failure at rs232_4, rxd status is %d "
+   printf("%s: failure at rs232_4, rxd status is %lu "
"(should be 1)\n", __FUNCTION__,
((*(vu_long *)MPC5XXX_WU_GPIO_DATA_I) &
0x1000) >> 28);
@@ -350,7 +350,7 @@ int do_rs232(char *argv[])
if (((*(vu_long *)MPC5XXX_WU_GPIO_DATA_I) & 0x1000) !=
0x) {
error_status = 2;
-   printf("%s: failure at rs232_4, rxd status is %d "
+   printf("%s: failure at rs232_4, rxd status is %lu "
"(should be 0)\n", __FUNCTION__,
((*(vu_long *)MPC5XXX_WU_GPIO_DATA_I) &
0x1000) >> 28);
@@ -366,7 +366,7 @@ int do_rs232(char *argv[])
if (((*(vu_long *)MPC5XXX_WU_GPIO_DATA_I) & 0x2000) !=
0x2000) {
error_status = 3;
-   printf("

[U-Boot-Users] [PATCH] =?utf-8?q?Fix=20build=20time=20warnings=20in=20function=20=E2=80=98mmc=5Fdecode=5Fcsd=E2=80=99:

[Marcel Ziswiler]

Signed-off-by: Marcel Ziswiler <[EMAIL PROTECTED]>
---
 cpu/pxa/mmc.c |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/cpu/pxa/mmc.c b/cpu/pxa/mmc.c
index 4495a80..8c529a3 100644
--- a/cpu/pxa/mmc.c
+++ b/cpu/pxa/mmc.c
@@ -535,7 +535,7 @@ static void mmc_decode_csd(uint32_t * resp)
mmc_dev.removable = 0;
mmc_dev.block_read = mmc_bread;
 
-   printf("Detected: %u blocks of %u bytes (%uMB) ", mmc_dev.lba,
+   printf("Detected: %lu blocks of %lu bytes (%luMB) ", (unsigned 
long)mmc_dev.lba,
   mmc_dev.blksz, mmc_dev.lba * mmc_dev.blksz / (1024 * 1024));
 }
 
-- 
1.5.4.1


-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Re: [U-Boot-Users] [PATCH, resend] FDT memory and pci node fixes for MPC8260ADS

[Wolfgang Denk]

In message <[EMAIL PROTECTED]> you wrote:
> Signed-off-by: Matvejchikov Ilya <[EMAIL PROTECTED]>
> ---
>  board/freescale/mpc8260ads/mpc8260ads.c |   27 +++
>  cpu/mpc8260/pci.c   |   12 
>  include/configs/MPC8260ADS.h|7 +++
>  3 files changed, 46 insertions(+), 0 deletions(-)
...
> --- a/cpu/mpc8260/pci.c
> +++ b/cpu/mpc8260/pci.c
> @@ -33,6 +33,10 @@
>  #include 
>  #include 
>  #include 
> +#ifdef CONFIG_OF_LIBFDT
> +#include 
> +#include 
> +#endif
> 
>  #if defined CONFIG_MPC8266ADS || defined CONFIG_MPC8272 || defined 
> CONFIG_PM826
>  DECLARE_GLOBAL_DATA_PTR;
> @@ -449,4 +453,12 @@ void pci_mpc8250_init (struct pci_controller *hose)
>   immap->im_pci.pci_emr |= cpu_to_le32 (PCI_ERROR_PCI_NO_RSP);
>  }
> 
> +#if defined(CONFIG_OF_LIBFDT)
> +void ft_pci_setup(void *blob, bd_t *bd)
> +{
> + do_fixup_by_prop_u32(blob, "device_type", "pci", 4,
> + "clock-frequency", bd->pci_clk, 1);
> +}
> +#endif

Your patch causes problems:

Configuring for MPC8260ADS board...
pci.c: In function 'ft_pci_setup':
pci.c:460: error: 'bd_t' has no member named 'pci_clk'
make[1]: *** [pci.o] Error 1


Do you have a quick fix or shall I back out the patch?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED]
Drun'? 'm not drun'! You woudn' dare call m' drun' if I was sober!
 - Terry Pratchett, _Men at Arms_

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Re: [U-Boot-Users] [PATCH V2] Round the serial port clock divisor value returned by calc_divisor()

[Wolfgang Denk]

In message <[EMAIL PROTECTED]> you wrote:
> Round the serial port clock divisor value returned by
> calc_divisor().
> 
> Signed-off-by: Hugo Villeneuve <[EMAIL PROTECTED]>
> Signed-off-by: John Roberts <[EMAIL PROTECTED]>
> 
> ---
> 
> Rounding is important, especially when using high baud rates
> values like 115200bps. When using the non-rounded value, some
> boards will work and some won't.
> 
>  drivers/serial/serial.c |6 +-
>  1 files changed, 5 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/serial/serial.c b/drivers/serial/serial.c
> index 76425d8..1192f07 100644
> --- a/drivers/serial/serial.c
> +++ b/drivers/serial/serial.c
> @@ -144,8 +144,12 @@ static int calc_divisor (NS16550_t port)
>  #else
>  #define MODE_X_DIV 16
>  #endif
> - return (CFG_NS16550_CLK / MODE_X_DIV / gd->baudrate);
>  
> + /* Compute divisor value. Normally, we should simply return:
> +  *   CFG_NS16550_CLK) / MODE_X_DIV / gd->baudrate
> +  * but we need to round that value by adding 0.5 or 8/16.
> +  * Rounding is especially important at high baud rates. */
> + return (((16 * CFG_NS16550_CLK) / MODE_X_DIV / gd->baudrate) + 8) / 16;
>  }

Your patch causes problems with some boards:

Configuring for SBC8540 board...
serial.c: In function 'calc_divisor':
serial.c:153: warning: integer overflow in expression
serial.c:153: warning: integer overflow in expression

Configuring for sbc8548 board...
serial.c: In function 'calc_divisor':
serial.c:153: warning: integer overflow in expression
serial.c:153: warning: integer overflow in expression


Do you have a quick fix, or shall I back out the patch?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED]
To understand a program you must become  both  the  machine  and  the
program.

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Re: [U-Boot-Users] [PATCH][AT91][Re-submit] DataFlash AT45DB021 support

[Jean-Christophe PLAGNIOL-VILLARD]

On 11:06 Thu 05 Jun , Sergey Lapin wrote:
> Some boards based on AT91SAM926X-EK use smaller DF chips to keep
> bootstrap, u-boot and its environment, using NAND or other external
> storage for kernel and rootfs. This patch adds support for
> small 1024x263 chip.
> 
> Signed-off-by: Sergey Lapin <[EMAIL PROTECTED]>
> ---
>  drivers/mtd/dataflash.c |   14 ++-
>  include/dataflash.h |1 +
>  2 files changed, 16 insertions(+), 2 deletions(-)
> 
Applied in u-boot-at91

Best Regards,
J.

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

[U-Boot-Users] AT91 pull request

[Jean-Christophe PLAGNIOL-VILLARD]

Hi,
please pull
The following changes since commit 4109df6f75fc00ab7da56d286ba50149a0d16a69:
  Kim Phillips (1):
silence misc printf formatting compiler warnings

are available in the git repository at:

  git://git.denx.de/u-boot-at91.git master

Jean-Christophe PLAGNIOL-VILLARD (1):
  MAKEALL: remove duplicated at91 from ARM9 list and add LIST_at91 to arm

Sergey Lapin (1):
  DataFlash AT45DB021 support

 MAKEALL |   12 +---
 drivers/mtd/dataflash.c |   14 ++
 include/dataflash.h |1 +
 3 files changed, 16 insertions(+), 11 deletions(-)

Best Regards,
J.

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Re: [U-Boot-Users] [PATCH] -Support fot the ADT7640 Monitor chip

[Ricardo Ribalda Delgado]

Hello


  All the comments are right, I will resend it tomorrow.


   Best regards and thanks

>
> --
> DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED]
> Earth -- mother of the most beautiful women in the universe.
>-- Apollo, "Who Mourns for Adonais?" stardate 3468.1
>



-- 
Ricardo Ribalda
http://www.eps.uam.es/~rribalda/

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Re: [U-Boot-Users] [PATCH] I2C Dummy Driver

[Ricardo Ribalda Delgado]

Hi Wolfgang

> What is the intention or practical use of this dummy driver?


  I developed this driver for two reasons,

 I wanted a dummy driver to test the i2c subsystem
 I wanted a way of use the ddr2 autoconfiguration for ppc440 without i2c.


>
>> +#if defined(CONFIG_DUMMY_I2C)
>> +u8 
>> i2c_dummy_buffer[256]={0x80,0x8,0x8,0x0D,0x0A,0x60,0x40,0x0,0x5,0x3D,0x50,0x0,0x82,0x10,0x0,0x0,0x0C,0x4,0x18,0x1,0x4,0x0,0x1,0x50,0x50,0x0,0x0,0x3C,0x28,0x3C,0x2D,0x40,0x25,0x37,0x10,0x22,0x3C,0x1E,0x1E,0x0,0x0,0x3C,0x69,0x80,0x1E,0x28,0x0,0x0,0x0,
>> 0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x12,0xC9,0x2C,'0','0','0','0','0','0','0',0x0,'4','H','T','F','3','2','6','4','H','Y','-','5','3','E','D','3',0x3,0x0,0x0,0x0,0x0};
>
> Line way too long.
>
> Maybe you also want to explain where these magic data is coming from
> or what it means?

It is the identification data of my ddr2 memory.



I will redo this patch and sent it again if you consider it useful for
the mainline.


 Best Regards and thanks for your comments


> --
> DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED]
> "Plan to throw one away.  You will anyway."
>  - Fred Brooks, "The Mythical Man Month"
>



-- 
Ricardo Ribalda
http://www.eps.uam.es/~rribalda/

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

[U-Boot-Users] [PATCH] MAKEALL: remove duplicated at91 from ARM9 list and add LIST_at91 to arm

[Jean-Christophe PLAGNIOL-VILLARD]

Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <[EMAIL PROTECTED]>

diff --git a/MAKEALL b/MAKEALL
index e00bb9c..2ec2c22 100755
--- a/MAKEALL
+++ b/MAKEALL
@@ -461,13 +461,6 @@ LIST_ARM7="\
 #
 
 LIST_ARM9="\
-   at91cap9adk \
-   at91rm9200dk\
-   at91sam9260ek   \
-   at91sam9261ek   \
-   at91sam9263ek   \
-   at91sam9rlek\
-   cmc_pu2 \
ap920t  \
ap922_XA10  \
ap926ejs\
@@ -478,11 +471,7 @@ LIST_ARM9="\
cp926ejs\
cp946es \
cp966   \
-   csb637  \
-   kb9202  \
lpd7a400\
-   m501sk  \
-   mp2usb  \
mx1ads  \
mx1fs2  \
netstar \
@@ -587,6 +576,7 @@ LIST_arm="  \
${LIST_ARM9}\
${LIST_ARM10}   \
${LIST_ARM11}   \
+   ${LIST_at91}\
${LIST_pxa} \
${LIST_ixp} \
 "
-- 
1.5.6.2


-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Re: [U-Boot-Users] [PATCH 04/10 v2] [ARM] TQMA31: add new board with i.MX31 processor

[Guennadi Liakhovetski]

On Thu, 10 Jul 2008, Jens Gehrlein wrote:

> Wolfgang Denk schrieb:
> > In message <[EMAIL PROTECTED]> you wrote:
> >> The TQMA31, as well as the mx32ads use the General Purpose Timer 1, 
> >> which is feeded by a 32768 clock (possibly imx31_litekit and 
> >> imx31_phycore with 32000 Hz? I don't know.). The prescale divider can 
> >> only be an integer. 32768/1000 = non-integer.
> > 
> > I think other architectures hav / had similar issues. See for example
> > the MIPS fixes that were added some time ago.
> 
> I'll take a look.
> 
> 
> >> Currently, I see only one way to solve this:
> >> 1. Patch the common file cpu/arm1136/mx31/interrupts.c, function 
> >> interrupt_init(), so that the prescaler divides by 33.
> >> Alternatively, also make the divider a board specific define.
> >> 2. Patch all mx31 board config header files with CFG_HZ 1000.
> >> 3. All mx31 boards have to be tested.
> > 
> > Sounds like a plan.
> 
> What do you mean?
> It's just a proposal and I like to read comments from others, especially 
> those, who wrote this code.

Ok, let's fix it then. Unfortunately, I don't think I will have time for 
this _soon_, but I definitely will try to convret all i.MX31 platforms to 
CFG_HZ == 1000 ASAP. Jean-Christophe, what would you prefer, first accept 
patches as they are (i.e., with CFG_HZ ~= 1000) and then fix all i.MX31 
platforms or first fix the existing boards and then commit an updated 
patch with CFG_HZ == 1000?

Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.

DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: [EMAIL PROTECTED]

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Re: [U-Boot-Users] [PATCH 0/1] Moved initialization of AVR32 Ethernet controllers to board_eth_init()

[Ben Warren]

Hans-Christian Egtvedt wrote:
> On Thu, 2008-07-10 at 14:47 +0200, Hans-Christian Egtvedt wrote:
>   
>> On Thu, 2008-07-10 at 14:45 +0200, Hans-Christian Egtvedt wrote:
>> 
>>> On Thu, 2008-07-10 at 13:24 +0200, Haavard Skinnemoen wrote:
>>>   
>
> 
>
>   
 Looks good to me, but I don't have the chance to test it.

 
>>> I tried looking into it, but I do not see who is going to call
>>> board_eth_init() ? Is this supposed to be done in net/eth.c or
>>> lib_avr32/board.c ?
>>>
>>>   
>> Cheese, I am blind, just found it almost on top in the eth_initialize()
>> function.
>>
>> I will pull the master and see if it works.
>>
>> 
>
> And it works, proof below (-: (Net: did not work before pulling master)
>
> U-Boot 1.3.3-00248-gae9bc0c-dirty (Jul 10 2008 - 14:50:32) 
>
> U-Boot code:  -> f6b8  data: 000155c0 -> 0004bd18
> malloc: Using memory from 0x10f74000 to 0x10fb4000
> DMA: Using memory from 0x10f7 to 0x10f74000
> Flash:  8 MB at address 0x
> DRAM Configuration:
> Bank #0: 1000 16 MB
> In:serial
> Out:   serial
> Err:   serial
> Net:   macb0
> Press SPACE to abort autoboot in 1 seconds
> macb0: link up, 100Mbps full-duplex (lpa: 0x45e1)
> BOOTP broadcast 1
> DHCP client bound to address 10.191.252.36
> Using macb0 device
> TFTP from server 10.191.252.83; our IP address is 10.191.252.36
> Filename 'uimage_br_stk'.
> Load address: 0x1040
> Loading: T #
>  ###
> done
> Bytes transferred = 788 (10f6ec hex)
> ## Booting kernel from Legacy Image at 1040 ...
>Image Name:   Linux-2.6.25.10.atmel.2
>Image Type:   AVR32 Linux Kernel Image (gzip compressed)
>Data Size:724 Bytes =  1.1 MB
>Load Address: 1000
>Entry Point:  9000
>Verifying Checksum ... OK
>Uncompressing Kernel Image ... OK
>
> Starting kernel at 9000 (params at 10f74008)...
>
> Linux version 2.6.25.10.atmel.2 ([EMAIL PROTECTED]) (gcc version 
> 4.2.2-atmel.1.0.8) #68 Thu Jul 10 13:16:42 CEST 2008
>
>   
Good news!

Thanks,
Ben


-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Re: [U-Boot-Users] [GIT PULL] Please pull mpc512x tree

[Wolfgang Denk]

In message <[EMAIL PROTECTED]> you wrote:
> 
> The following changes since commit d4692b0ba83b7b454bbd92bad1f4befe6e1657b7:
>Christian Eggers (1):
>  Fix "usb part" command
> 
> are available in the git repository at:
> 
>git://git.denx.de/u-boot-mpc512x.git master
> 
> Martha Marx (2):
>Consolidate ADS5121 IO Pin configuration
>Configuration changes for ADS5121 Rev 3
> 
>   Makefile  |9 +-
>   board/ads5121/Makefile|2 +-
>   board/ads5121/README  |9 ++
>   board/ads5121/ads5121.c   |   54 ---
>   board/ads5121/iopin.c |   96 +++
>   board/ads5121/iopin.h |  222 ++
>   cpu/mpc512x/cpu.c |8 +-
>   cpu/mpc512x/fec.c |   15 ---
>   include/configs/ads5121.h |   39 +++--
>   9 files changed, 389 insertions(+), 65 deletions(-)
>   create mode 100644 board/ads5121/README
>   create mode 100644 board/ads5121/iopin.c
>   create mode 100644 board/ads5121/iopin.h

Done, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED]
Wenn das dann in die Hose geht, nehme ich es auf meine Kappe.
 -- Rudi Völler, 15. Nov 2003

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Re: [U-Boot-Users] [PATCH] I2C Dummy Driver

[Wolfgang Denk]

In message <[EMAIL PROTECTED]> you wrote:
> 
> Signed-off-by: Ricardo Ribalda Delgado <[EMAIL PROTECTED]>

What is the intention or practical use of this dummy driver?


> --- a/drivers/i2c/Makefile
> +++ b/drivers/i2c/Makefile
> @@ -30,6 +30,7 @@ COBJS-y += omap1510_i2c.o
...
> +COBJS-y += dummy_i2c.o

Please make "COBJS-$(CONFIG_DUMMY_I2C) += dummy_i2c.o" and ...

> diff --git a/drivers/i2c/dummy_i2c.c b/drivers/i2c/dummy_i2c.c
> new file mode 100644
> index 000..04f6edb
> --- /dev/null
> +++ b/drivers/i2c/dummy_i2c.c
> @@ -0,0 +1,84 @@
...

> +(C) Copyright 2008
> +Ricado Ribalda, Universidad Autonoma de Madrid, 
> ricardo.ribaldauam.es , ricardo.ribaldagmail.com

[Line too long]

> +This program is free software: you can redistribute it and/or modify
> +it under the terms of the GNU General Public License as published by
> +the Free Software Foundation, either version 3 of the License, or
> +(at your option) any later version.

[ GPLv2 needed]

> +#if defined(CONFIG_DUMMY_I2C)

... drop this #ifdef / #endif

> +
> +#include 
> +u8 
> i2c_dummy_buffer[256]={0x80,0x8,0x8,0x0D,0x0A,0x60,0x40,0x0,0x5,0x3D,0x50,0x0,0x82,0x10,0x0,0x0,0x0C,0x4,0x18,0x1,0x4,0x0,0x1,0x50,0x50,0x0,0x0,0x3C,0x28,0x3C,0x2D,0x40,0x25,0x37,0x10,0x22,0x3C,0x1E,0x1E,0x0,0x0,0x3C,0x69,0x80,0x1E,0x28,0x0,0x0,0x0,
> 0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x12,0xC9,0x2C,'0','0','0','0','0','0','0',0x0,'4','H','T','F','3','2','6','4','H','Y','-','5','3','E','D','3',0x3,0x0,0x0,0x0,0x0};

Line way too long.

Maybe you also want to explain where these magic data is coming from
or what it means?

> + if (alen!=1)

if (alen != 1)

> + return -1;
> +
> + if (addr+len>0xff)

if (addr+len > 0xff)

> + return -1;
> +
> + for(i=0;i + buffer[i]=i2c_dummy_buffer[i+addr];

buffer[i] = i2c_dummy_buffer[i+addr];

etc., please.


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED]
"Plan to throw one away.  You will anyway."
  - Fred Brooks, "The Mythical Man Month"

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Re: [U-Boot-Users] [PATCH] -Support fot the ADT7640 Monitor chip

[Wolfgang Denk]

In message <[EMAIL PROTECTED]> you wrote:
> 
> Signed-off-by: Ricardo Ribalda Delgado <[EMAIL PROTECTED]>
> ---
>  drivers/hwmon/Makefile  |1 +
>  drivers/hwmon/adt7460.c |   89 
> +++
>  drivers/hwmon/adt7460.h |   49 ++
>  include/dtt.h   |2 +-
>  4 files changed, 140 insertions(+), 1 deletions(-)
>  create mode 100644 drivers/hwmon/adt7460.c
>  create mode 100644 drivers/hwmon/adt7460.h
> 
> diff --git a/drivers/hwmon/Makefile b/drivers/hwmon/Makefile
> index 065433a..83aa297 100644
> --- a/drivers/hwmon/Makefile
> +++ b/drivers/hwmon/Makefile
> @@ -34,6 +34,7 @@ COBJS-y += adm1021.o
>  COBJS-y += ds1621.o
>  COBJS-y += ds1722.o
>  COBJS-y += ds1775.o
> +COBJS-y += adt7460.o

Please make this 

   COBJS-$(CONFIG_DTT_ADT7460) += adt7460.o

instead,

>  COBJS-$(CONFIG_DTT_LM73) += lm73.o
>  COBJS-y += lm75.o
>  COBJS-y += lm81.o
> diff --git a/drivers/hwmon/adt7460.c b/drivers/hwmon/adt7460.c
> new file mode 100644
> index 000..255d6ed
> --- /dev/null
> +++ b/drivers/hwmon/adt7460.c
> @@ -0,0 +1,89 @@
...
> +#ifdef CONFIG_DTT_ADT7460

...and then drop this #ifdef / #endif 

> +#include 
> +#include 
> +#include "adt7460.h"
> +
> +#define ADT7460_ADDRESS 0x2c
> +
> +
> +int dtt_read(int sensor, int reg)
> +{
> + u8 dir=reg;
> + u8 data;
> +
> + if (-1==i2c_read(ADT7460_ADDRESS,dir,1,&data,1))

Please write

if (i2c_read(ADT7460_ADDRESS,dir,1,&data,1) == -1)

here and everywhere else.

> +int dtt_write(int sensor, int reg, int val)
> +{
> + u8 dir=reg;
> + u8 data=val;
> + 
> + if (-1==i2c_write(ADT7460_ADDRESS,dir,1,&data,1))
> + return -1;
> +
> + return 0;

Maybe this could be simplyfied as

return i2c_write(ADT7460_ADDRESS,dir,1,&data,1);

?

> +This program is free software: you can redistribute it and/or modify
> +it under the terms of the GNU General Public License as published by
> +the Free Software Foundation, either version 3 of the License, or
> +(at your option) any later version.

Please make GPLv2 (or later).

...
> --- a/include/dtt.h
> +++ b/include/dtt.h
> @@ -32,7 +32,7 @@
>  defined(CONFIG_DTT_DS1775) || \
>  defined(CONFIG_DTT_LM81) || \
>  defined(CONFIG_DTT_ADM1021) || \
> -defined(CONFIG_DTT_LM73)
> +defined(CONFIG_DTT_LM73)||defined(CONFIG_DTT_ADT7460)

Please split on separate line.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED]
Earth -- mother of the most beautiful women in the universe.
-- Apollo, "Who Mourns for Adonais?" stardate 3468.1

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Re: [U-Boot-Users] Pull Request: Please pull u-boot-mpc86xx.git

[Wolfgang Denk]

In message <[EMAIL PROTECTED]> you wrote:
> Wolfgang,
> 
> The following changes are available in the git repository at:
> 
>   git://www.denx.de/git/u-boot-mpc86xx.git master
> 
> 
> Jason Jin (1):
>   Feed the watchdog in u-boot for 8610 board.
> 
> Kumar Gala (2):
>   MPC8641HPCN: Report board id, board version and fpga version.
>   MPC8610HPCD: Report board id, board version and fpga version.

Done. Thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED]
There is a multi-legged creature crawling on your shoulder.
-- Spock, "A Taste of Armageddon", stardate 3193.9

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Re: [U-Boot-Users] [PATCH] USB: shutdown USB before booting

[Wolfgang Denk]

In message <[EMAIL PROTECTED]> you wrote:
> 
> Yes, I remember hearing of this problem. I thought it was already fixed. 
> Seems 
> not to be the case. Please find a comment below.

I thought so, too. But Martin Krause's patch somehow got stuck in the
gearbox.

> By implementing this usb_stop() in do_bootm() you prevent this problem in 
> many 
> cases (e.g. Linux booting). But unfortunately not in all cases. For 
> example "bootelf" or "bootvx" are not fixed.

You are right.

> Can't this be solved in a different way. By calling usb_stop each time after 
> an USB command completes. IIRC, this is how it is done in the U-Boot network 
> implementation too.
> 
> What do you think?

I pulled in the current patch so we reduce  the  problem  as  far  as
possible; any better implementation is welcome.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED]
In the beginning there was nothing.
And the Lord said "Let There Be Light!"
And still there was nothing, but at least now you could see it.

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Re: [U-Boot-Users] [PATCH] USB: shutdown USB before booting

[Wolfgang Denk]

In message <[EMAIL PROTECTED]> you wrote:
> 
> This patch fixes a potentially serious issue related to USB which was
> discouvered by Martin Krause <[EMAIL PROTECTED]> and fixed for
> ARM920T. Martin wrote:
> 
>   Turn off USB to prevent the host controller from writing to the
>   SDRAM while Linux is booting. This could happen, because the HCCA
>   (Host Controller Communication Area) lies within the SDRAM and the
>   host controller writes continously to this area (as busmaster!), for
>   example to increase the HccaFrameNumber variable, which happens
>   every 1 ms.
> 
> This is a slightly modified version of the patch in order to shutdown
> USB when booting on all architectures.
> 
> Signed-off-by: Markus Klotzbuecher <[EMAIL PROTECTED]>
> ---
>  common/cmd_bootm.c |   18 ++
>  1 files changed, 18 insertions(+), 0 deletions(-)

Thanks, Markus. This is so urgent that I pull this directly.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED]
How does a project get to be a year late?  ... One day at a time.

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Re: [U-Boot-Users] [PATCH] usb: add support for R8A66597 usb controller

[Wolfgang Denk]

In message <[EMAIL PROTECTED]> you wrote:
>
> > Can you not find some simpler name that "r8a66597"? That's a mess to
> > type and to read.
> 
> Thank you for your comment.
> 
> I can change that "struct r8a66597" for a simple name. For example,
> its name is "struct r597". However, I do not want to change a source
> file name and CONFIG_ name, because "R8A66597" is product name.

Doesn't the board have an easy to spell and easy to remember nickname
or so?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED]
To the systems programmer,  users  and  applications  serve  only  to
provide a test load.

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Re: [U-Boot-Users] [PATCH] Support fot the ML507 Board 1/4

[Ricardo]

Hello Wolfgang

  Lets find a solution to support ML507 on u-boot (and make my work
availiable to more people). I am completly with you about the low
quality of the xilinx-adapted code. I am using it for two things: i2c
and ethernet, but the board can perfetly work without them.  The i2c
code can be very simply adapted to the "good way".

  Tomorrow I will work on a patch for the CPU, ADT7640, Uart Lite and
the board without i2c and in the near future I will provide a "clean"
driver for the xilinx i2c.

  How does it sounds for you?


   Best regards


-- 
Ricardo Ribalda
http://www.eps.uam.es/~rribalda/

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

[U-Boot-Users] [PATCH] silence misc printf formatting compiler warnings

[Kim Phillips]

Signed-off-by: Kim Phillips <[EMAIL PROTECTED]>
---
WD, please apply directly.

 common/cmd_flash.c   |4 ++--
 common/cmd_jffs2.c   |   12 ++--
 cpu/mpc83xx/ecc.c|6 +++---
 cpu/mpc83xx/speed.c  |2 +-
 drivers/block/fsl_sata.c |2 +-
 drivers/block/libata.c   |2 +-
 drivers/rtc/ds1374.c |4 ++--
 7 files changed, 16 insertions(+), 16 deletions(-)

diff --git a/common/cmd_flash.c b/common/cmd_flash.c
index db5dec9..9bd8074 100644
--- a/common/cmd_flash.c
+++ b/common/cmd_flash.c
@@ -360,7 +360,7 @@ int do_flerase (cmd_tbl_t *cmdtp, int flag, int argc, char 
*argv[])
addr_last = addr_first + part->size - 1;
 
printf ("Erase Flash Parition %s, "
-   "bank %d, 0x%08lx - 0x%08lx ",
+   "bank %ld, 0x%08lx - 0x%08lx ",
argv[1], bank, addr_first,
addr_last);
 
@@ -566,7 +566,7 @@ int do_protect (cmd_tbl_t *cmdtp, int flag, int argc, char 
*argv[])
addr_last = addr_first + part->size - 1;
 
printf ("%sProtect Flash Parition %s, "
-   "bank %d, 0x%08lx - 0x%08lx\n",
+   "bank %ld, 0x%08lx - 0x%08lx\n",
p ? "" : "Un", argv[1],
bank, addr_first, addr_last);
 
diff --git a/common/cmd_jffs2.c b/common/cmd_jffs2.c
index 1b67e73..b4698be 100644
--- a/common/cmd_jffs2.c
+++ b/common/cmd_jffs2.c
@@ -241,13 +241,13 @@ static void memsize_format(char *buf, u32 size)
 #define SIZE_KB ((u32)1024)
 
if ((size % SIZE_GB) == 0)
-   sprintf(buf, "%lug", size/SIZE_GB);
+   sprintf(buf, "%ug", size/SIZE_GB);
else if ((size % SIZE_MB) == 0)
-   sprintf(buf, "%lum", size/SIZE_MB);
+   sprintf(buf, "%um", size/SIZE_MB);
else if (size % SIZE_KB == 0)
-   sprintf(buf, "%luk", size/SIZE_KB);
+   sprintf(buf, "%uk", size/SIZE_KB);
else
-   sprintf(buf, "%lu", size);
+   sprintf(buf, "%u", size);
 }
 
 /**
@@ -416,7 +416,7 @@ static int part_validate(struct mtdids *id, struct 
part_info *part)
part->size = id->size - part->offset;
 
if (part->offset > id->size) {
-   printf("%s: offset %08lx beyond flash size %08lx\n",
+   printf("%s: offset %08x beyond flash size %08x\n",
id->mtd_id, part->offset, id->size);
return 1;
}
@@ -1288,7 +1288,7 @@ static void list_partitions(void)
if (current_dev) {
part = jffs2_part_info(current_dev, current_partnum);
if (part) {
-   printf("\nactive partition: %s%d,%d - (%s) 0x%08lx @ 
0x%08lx\n",
+   printf("\nactive partition: %s%d,%d - (%s) 0x%08x @ 
0x%08x\n",
MTD_DEV_TYPE(current_dev->id->type),
current_dev->id->num, current_partnum,
part->name, part->size, part->offset);
diff --git a/cpu/mpc83xx/ecc.c b/cpu/mpc83xx/ecc.c
index 6f13094..5137ab6 100644
--- a/cpu/mpc83xx/ecc.c
+++ b/cpu/mpc83xx/ecc.c
@@ -45,7 +45,7 @@ void ecc_print_status(void)
   (ddr->err_disable & ECC_ERROR_DISABLE_MSED) ? 1 : 0);
 
/* Error injection */
-   printf("Memory Data Path Error Injection Mask High/Low: %08lx %08lx\n",
+   printf("Memory Data Path Error Injection Mask High/Low: %08x %08x\n",
   ddr->data_err_inject_hi, ddr->data_err_inject_lo);
 
printf("Memory Data Path Error Injection Mask ECC:\n");
@@ -75,8 +75,8 @@ void ecc_print_status(void)
   (ddr->err_detect & ECC_ERROR_DETECT_MSE) ? 1 : 0);
 
/* Capture data */
-   printf("Memory Error Address Capture: 0x%08lx\n", ddr->capture_address);
-   printf("Memory Data Path Read Capture High/Low: %08lx %08lx\n",
+   printf("Memory Error Address Capture: 0x%08x\n", ddr->capture_address);
+   printf("Memory Data Path Read Capture High/Low: %08x %08x\n",
   ddr->capture_data_hi, ddr->capture_data_lo);
printf("Memory Data Path Read Capture ECC: 0x%02x\n\n",
   ddr->capture_ecc & CAPTURE_ECC_ECE);
diff --git a/cpu/mpc83xx/speed.c b/cpu/mpc83xx/speed.c
index 16145dd..76c569d 100644
--- a/cpu/mpc83xx/speed.c
+++ b/cpu/mpc83xx/speed.c
@@ -508,7 +508,7 @@ int do_clocks (cmd_tbl_t * cmdtp, int flag, int argc, char 
*argv[])
 #endif
printf("  Local Bus Controller:%4d MHz\n", gd->lbiu_clk / 100);
printf("  Local Bus:   %4d MHz\n", gd->lclk_clk / 100);
-   printf("  DDR: 

Re: [U-Boot-Users] [PATCH] Support fot the ML507 Board 1/4

[Wolfgang Denk]

Dear Ricardo,

in message <[EMAIL PROTECTED]> you wrote:
> 
>   Sorry to hear that. I have tried to give all my best and follow the
> style of the ml300 board, which was the closest board to mine.
> On FPGAs board I think that it is not  a horrible idea to follow this
> style. Maybe you should consider to create an FPGA branch, where the
> generic drivers could be accepted. As I said, the FPGA hardware

Believe me, this makes no sense. Copying the same files around quickly
results in an unmaintainable mess. Adding lots of code which are not
actually needed just prevent anybody from actually understanding which
code is essential and which not.

We've been there before, and we learned this lesson.

> changes a lot and support a so changing hardware will be very
> difficult... Or just should not support FPGAs and its IP devices...

I do not think that FPGA have any inherent  problems.  The  issue  is
with  the  base  code  which  was  not written with a boot loader (or
portability and efficiency) in mind.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED]
A weak mind is like a microscope, which magnifies trifling things,
but cannot receive great ones.  -- Philip Earl of Chesterfield

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Re: [U-Boot-Users] [PATCH] Support fot the ML507 Board 1/4

[Ricardo]

Hi Michael

  Sorry to hear that. I have tried to give all my best and follow the
style of the ml300 board, which was the closest board to mine.
On FPGAs board I think that it is not  a horrible idea to follow this
style. Maybe you should consider to create an FPGA branch, where the
generic drivers could be accepted. As I said, the FPGA hardware
changes a lot and support a so changing hardware will be very
difficult... Or just should not support FPGAs and its IP devices...


By the way:

  patches 1 2  and 6 follow the guidelines and don't add any generic driver
  patches 8 (except xparameters.h) follow the guidelines
  patch 6 could be redesined. You should be aware that
driver/serial/serial_xuartlite.c does not compile for ppc440 without
that patch


  Best regards

On Thu, Jul 10, 2008 at 9:04 PM, Michal Simek <[EMAIL PROTECTED]> wrote:
> Hi Ricardo,
>
> I read your patches in your weird style.
> These style of patches never go to mainline. You use xilinx generated files 
> which is currently use only with ml300.
> For example look at your xparameters.h there are a lot of values which are 
> not used.
> If you want to add ml507 to mainline U-BOOT you have to change completely 
> handling style of xilinx board for ppc.
> In next U-BOOT release I will clean ancient ml300. I want to remove a lot of 
> xilinx generic files.
>
> 100% NACK for these patches.
>
> The size of patches is due to your incorrect design strategy.
>
> Michal Simek
>
>
> Hi List:
>
>  This is my first contribution to u-boot. I have ported u-boot to the
> ML507 Board by Xilinx.
> http://www.xilinx.com/products/devkits/HW-V5-ML507-UNI-G.htm
>
> This boards includes an FPGA Virtex 5 FX with an embedded PowerPC 440.
>
> The port supports:
>-Virtex 5 ppc440x5
>-XIlinx Interrupt Controller
>-Xilinx I2C Controller (Interrupted mode)
>-Xilinx Uart Lite (simple port)
>-Xilinx LL_TEMA (Interrupted and SGDMA)
>-Save environment on board eeprom
>-DTT support for the ADT sensor on board (new hwmon driver)
>-Dummy I2C driver (for testing purposes)
>
> This patch works against the last commit to the p4xx branch.
>
> I am a researcher of the Universidad Autonoma de Madrid, and this work
> has been supported by Q-Technology ( http://qtec.com ) under a
> Research Agreement.
>
> Any comment will be very welcomed.
>
> PS: I have divided the patch in four parts for the mailing list
> --
> Ricardo Ribalda
> http://www.eps.uam.es/~rribalda/
>
>
>



-- 
Ricardo Ribalda
http://www.eps.uam.es/~rribalda/

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Re: [U-Boot-Users] Support for the ML507

[Michal Simek]

Hi,
>Hello again:

>  I have adapted the Xilinx drivers just because there were other
>examples of that behaviour on the u-boot code
>(board/xilinx/xilinx_enet, board/xilinx/xilinx_iic and
>board/xilinx/common) for the xilinx drivers.

This style is deprecated. xilinx_enet is emaclite(drivers/net/xilinx_emac.c) 
driver which I rewrite some month ago.
IIC driver is easy to rewrite. You used bad example.

>  About redesigning the drivers from scratch Maybe is not a good
>idea on FPGA soft cores. This devices made of hardware/software change
>very frequently (even twice per year) and if we develop a driver from
>scratch, it will be very hard to mantain. On the other hand, if we use
>the "generic drivers" we just need to change them when the devices are
>upgraded.

Almost all IP cores are backward compatible. I developed for Microblaze cpu 
MLD(TCL) which
helps you with changes in your design. You can do the same thing. Bsp is 
available at git.monstr.eu. Patches are welcomed.

>  Maybe an option will be just not give support to FPGAs boards...,
>but they are used by a lot of people (students and companies). We can
>have the risk that if we do not give support to that boards, the FPGAs
>manufacturers will create a fork and take full control of the u-boot
>roadmap (more money and resources).

Of course you can add support for generic board or for small amount of board in 
generic style.
Look at ml401 and xupv2p for microblaze. It is not to hard to add support for 
xilinx fpga board but
you have to do it correctly. I see a space for adding one generic board with 
ppc440 which will be sufficient 
for others.

>  I have tried to follow the coding guidelines for all the files I
>have created from scratch, but not for the drivers by xilinx.

If you want to help with handling of xilinx board, you can contact me.

Michal Simek

>  Best Regards

On Thu, Jul 10, 2008 at 8:48 PM, Wolfgang Denk <[EMAIL PROTECTED]> wrote:
> In message <[EMAIL PROTECTED]> you
wrote:
>>
>>   So, I have spent the evening dividing the big patch in 8 independent
>> patches. I have used the git tools to prepare the patches and resend
>> them... Unfortunatelly some of this files are bigged than the 40kb
>> limit If the mail list administrator don't accept this parts you
>> can download the full set of patches from my website:
>> http://www.ii.uam.es/~rribalda/ml507.tgz
>
> 40 kB is the soft limit; the hard limit is 100 kB.
>
>>   Why my patches are so big... They give support to IPs by Xilinx,
>> which have some kind of generic drivers to adapt them to multiple
>
> You are aware that some similar code laready exists  in  U-Boot?  and
> that  your  patches  contain  lots  of code that will most definitely
> never be used in U-Boot?
>
>> OS... When the driver was very complex I have used this generic
>> drivers and added an adaptor. Because it does not follows the coding
>
> I have extremely little emthusiasm to add big and complex drivers that
> are intended to support many operating systems plus an adaption layer
> to a small boot loader like U-Boot.
>
> I think such drivers should be reimplemented from scratch, with
> efficiency and style in mind.
>
>> guidelines, all this drivers have been located under the board
>> directory to respect all your "clean" work.
>
> The Coding Style reqyierements apply to code in the board/ directories
> as well.
>
> And adding thsi stuff there makes it only worse, as the next similar
> board that gets added will copy the whole crap.
>
> This is bound to be unmaintainable.
>
> I *strongly* recommend to redesign and reimplement.
>
>
> Best regards,
>
> Wolfgang Denk
>
> --
> DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED]
> How much net work could a network work, if a network could net work?
>



-- 
Ricardo Ribalda
http://www.eps.uam.es/~rribalda/

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users



-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/li

Re: [U-Boot-Users] HELP, trying to remove complier warnings

[Scott Wood]

Wolfgang Denk wrote:
> In message <[EMAIL PROTECTED]> you wrote:
>> Wolfgang Denk wrote:
>>> In message <[EMAIL PROTECTED]> you wrote:
 Try adding -fno-strict-aliasing
>>> No, we don't want to hush up compiler warnings, we want to fix the
>>> problems instead.
>> It's not silencing a warning (if it were, it'd be a -W flag); it's 
>> disabling an incompatible optimization.
> 
> OK.
> 
> Then let me rephrase: We do not want to disable optimizations, ...

If you want to figure out what that code is doing and rewrite it to be 
compliant with strict aliasing, go ahead (I tried, and it made my brain 
hurt).  In the meantime, we shouldn't be enabling the optimization on 
code that was written for an older version of the C language where such 
an optimization was prohibited, and where the compiler is letting us 
know that it thinks the code depends on the older semantics.

-Scott

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Re: [U-Boot-Users] [PATCH] Support fot the ML507 Board 1/4

[Michal Simek]

Hi Ricardo,

I read your patches in your weird style. 
These style of patches never go to mainline. You use xilinx generated files 
which is currently use only with ml300.
For example look at your xparameters.h there are a lot of values which are not 
used.
If you want to add ml507 to mainline U-BOOT you have to change completely 
handling style of xilinx board for ppc.
In next U-BOOT release I will clean ancient ml300. I want to remove a lot of 
xilinx generic files.

100% NACK for these patches.

The size of patches is due to your incorrect design strategy.

Michal Simek


Hi List:

 This is my first contribution to u-boot. I have ported u-boot to the
ML507 Board by Xilinx.
http://www.xilinx.com/products/devkits/HW-V5-ML507-UNI-G.htm

This boards includes an FPGA Virtex 5 FX with an embedded PowerPC 440.

The port supports:
-Virtex 5 ppc440x5
-XIlinx Interrupt Controller
-Xilinx I2C Controller (Interrupted mode)
-Xilinx Uart Lite (simple port)
-Xilinx LL_TEMA (Interrupted and SGDMA)
-Save environment on board eeprom
-DTT support for the ADT sensor on board (new hwmon driver)
-Dummy I2C driver (for testing purposes)

This patch works against the last commit to the p4xx branch.

I am a researcher of the Universidad Autonoma de Madrid, and this work
has been supported by Q-Technology ( http://qtec.com ) under a
Research Agreement.

Any comment will be very welcomed.

PS: I have divided the patch in four parts for the mailing list
-- 
Ricardo Ribalda
http://www.eps.uam.es/~rribalda/



-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Re: [U-Boot-Users] Support for the ML507

[Ricardo Ribalda Delgado]

Hello again:

  I have adapted the Xilinx drivers just because there were other
examples of that behaviour on the u-boot code
(board/xilinx/xilinx_enet, board/xilinx/xilinx_iic and
board/xilinx/common) for the xilinx drivers.

  About redesigning the drivers from scratch Maybe is not a good
idea on FPGA soft cores. This devices made of hardware/software change
very frequently (even twice per year) and if we develop a driver from
scratch, it will be very hard to mantain. On the other hand, if we use
the "generic drivers" we just need to change them when the devices are
upgraded.

  Maybe an option will be just not give support to FPGAs boards...,
but they are used by a lot of people (students and companies). We can
have the risk that if we do not give support to that boards, the FPGAs
manufacturers will create a fork and take full control of the u-boot
roadmap (more money and resources).

  I have tried to follow the coding guidelines for all the files I
have created from scratch, but not for the drivers by xilinx.

  Best Regards

On Thu, Jul 10, 2008 at 8:48 PM, Wolfgang Denk <[EMAIL PROTECTED]> wrote:
> In message <[EMAIL PROTECTED]> you wrote:
>>
>>   So, I have spent the evening dividing the big patch in 8 independent
>> patches. I have used the git tools to prepare the patches and resend
>> them... Unfortunatelly some of this files are bigged than the 40kb
>> limit If the mail list administrator don't accept this parts you
>> can download the full set of patches from my website:
>> http://www.ii.uam.es/~rribalda/ml507.tgz
>
> 40 kB is the soft limit; the hard limit is 100 kB.
>
>>   Why my patches are so big... They give support to IPs by Xilinx,
>> which have some kind of generic drivers to adapt them to multiple
>
> You are aware that some similar code laready exists  in  U-Boot?  and
> that  your  patches  contain  lots  of code that will most definitely
> never be used in U-Boot?
>
>> OS... When the driver was very complex I have used this generic
>> drivers and added an adaptor. Because it does not follows the coding
>
> I have extremely little emthusiasm to add big and complex drivers that
> are intended to support many operating systems plus an adaption layer
> to a small boot loader like U-Boot.
>
> I think such drivers should be reimplemented from scratch, with
> efficiency and style in mind.
>
>> guidelines, all this drivers have been located under the board
>> directory to respect all your "clean" work.
>
> The Coding Style reqyierements apply to code in the board/ directories
> as well.
>
> And adding thsi stuff there makes it only worse, as the next similar
> board that gets added will copy the whole crap.
>
> This is bound to be unmaintainable.
>
> I *strongly* recommend to redesign and reimplement.
>
>
> Best regards,
>
> Wolfgang Denk
>
> --
> DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED]
> How much net work could a network work, if a network could net work?
>



-- 
Ricardo Ribalda
http://www.eps.uam.es/~rribalda/

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Re: [U-Boot-Users] [PATCH] Adds support for Xilinx Uart Lite on ppc4xx

[Wolfgang Denk]

In message <[EMAIL PROTECTED]> you wrote:
> 
> This files already exist on the u-boot tree. They are located in
> include/asm-microblaze and include/asm-microblaze/arch-microblaze .
> They give support to a simple uart which can also be used on the
> powerpc, I have just copied them from one directory to another.

That's even worse. Don't do that. NEVER duplicate code.

Software engineering is an art of NOT duplicating previous work or
code.

> This files have been provided by Xilinx, and they are the same in
> all the OS and boot loaders, I don't  think they break any GPL
> license,

IANAL. Are you a laywer?

> >> +* This program is free software; you can redistribute it and/or 
> >> modify it
> >> +* under the terms of the GNU General Public License as published by 
> >> the
> >> +* Free Software Foundation; either version 2 of the License, or (at 
> >> your
> >> +* option) any later version.
> > ..
> >> +* XILINX IS PROVIDING THIS DESIGN, CODE, OR INFORMATION "AS IS" AS A
> >> +* COURTESY TO YOU. BY PROVIDING THIS DESIGN, CODE, OR INFORMATION AS
> >> +* ONE POSSIBLE IMPLEMENTATION OF THIS FEATURE, APPLICATION OR 
> >> STANDARD,
> >> +* XILINX IS MAKING NO REPRESENTATION THAT THIS IMPLEMENTATION IS FREE
> >> +* FROM ANY CLAIMS OF INFRINGEMENT, AND YOU ARE RESPONSIBLE FOR 
> >> OBTAINING
> >> +* ANY THIRD PARTY RIGHTS YOU MAY REQUIRE FOR YOUR IMPLEMENTATION.
> >
> > This is IMHO in contradiction to the GPL clause above.

If the code is under GPL there should not be any undefined (probably
dangerous?) third party rights. If this should be the case, the file
cannot be released under GPL.

> >> +* Xilinx hardware products are not intended for use in life support
> >> +* appliances, devices, or systems. Use in such applications is
> >> +* expressly prohibited.
> >
> > This restriction is IMHO in contradiction to the GPL clause above.


[BTW: please do not top-post / full-quote.]


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED]
If you hear an onion ring, answer it.

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Re: [U-Boot-Users] HELP, trying to remove complier warnings

[Wolfgang Denk]

In message <[EMAIL PROTECTED]> you wrote:
> Wolfgang Denk wrote:
> > In message <[EMAIL PROTECTED]> you wrote:
> >> Try adding -fno-strict-aliasing
> > 
> > No, we don't want to hush up compiler warnings, we want to fix the
> > problems instead.
> 
> It's not silencing a warning (if it were, it'd be a -W flag); it's 
> disabling an incompatible optimization.

OK.

Then let me rephrase: We do not want to disable optimizations, ...

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED]
The more sins you confess, the more books you will sell.

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Re: [U-Boot-Users] [PATCH] -Support fot the ADT7640 Monitor chip

[Wolfgang Denk]

In message <[EMAIL PROTECTED]> you wrote:
> 
>   I have modified the license of all the patches, and they are now located at:
>  http://www.ii.uam.es/~rribalda/ml507.tgz
>   Waiting for more comments

There will not be any comments from me  this  way.  Please  post  the
pathces on the list.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED]
"Now here's something you're really going to like!"
- Rocket J. Squirrel

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Re: [U-Boot-Users] [PATCH] Support fot the ML507 Board 1/4

[Wolfgang Denk]

In message <[EMAIL PROTECTED]> you wrote:
> 
>   I wanted the four parts to have the same subject, to easy the

But this makes no sense, especiall when you add "1/4" to the subject.

> handling of the files. The first submition was 4 .bz2 dependent
> files... But later on the evening I have prepared 8 different
> INdependent patches following the guidelines on the u-boot site. Sorry

The guidelines say:

...
Separate _logical changes_ into a single patch file.

...
No MIME, no links, no compression, no attachments.  Just plain
text.

...
The canonical patch subject line is: 

Subject: [PATCH 001/123] subsystem: summary phrase
...


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED]
A princess should not be afraid -- not with a brave knight to protect
her.
-- McCoy, "Shore Leave", stardate 3025.3

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Re: [U-Boot-Users] [PATCH] Adds support for Xilinx Uart Lite on ppc4xx

[Ricardo Ribalda Delgado]

Hello again

This files already exist on the u-boot tree. They are located in
include/asm-microblaze and include/asm-microblaze/arch-microblaze .
They give support to a simple uart which can also be used on the
powerpc, I have just copied them from one directory to another.

This files have been provided by Xilinx, and they are the same in
all the OS and boot loaders, I don't  think they break any GPL
license,


   Best regards and sorry for the coding style I am correcting it.

On Thu, Jul 10, 2008 at 8:41 PM, Wolfgang Denk <[EMAIL PROTECTED]> wrote:
> In message <[EMAIL PROTECTED]> you wrote:
>>
>> +* This program is free software; you can redistribute it and/or modify 
>> it
>> +* under the terms of the GNU General Public License as published by the
>> +* Free Software Foundation; either version 2 of the License, or (at your
>> +* option) any later version.
> ..
>> +* XILINX IS PROVIDING THIS DESIGN, CODE, OR INFORMATION "AS IS" AS A
>> +* COURTESY TO YOU. BY PROVIDING THIS DESIGN, CODE, OR INFORMATION AS
>> +* ONE POSSIBLE IMPLEMENTATION OF THIS FEATURE, APPLICATION OR STANDARD,
>> +* XILINX IS MAKING NO REPRESENTATION THAT THIS IMPLEMENTATION IS FREE
>> +* FROM ANY CLAIMS OF INFRINGEMENT, AND YOU ARE RESPONSIBLE FOR OBTAINING
>> +* ANY THIRD PARTY RIGHTS YOU MAY REQUIRE FOR YOUR IMPLEMENTATION.
>
> This is IMHO in contradiction to the GPL clause above.
>
>> +* Xilinx hardware products are not intended for use in life support
>> +* appliances, devices, or systems. Use in such applications is
>> +* expressly prohibited.
>
> This restriction is IMHO in contradiction to the GPL clause above.
>
> ..
>> +#define XCOMPONENT_IS_READY  0x  /* component has been 
>> initialized */
>> +#define XCOMPONENT_IS_STARTED0x  /* component has been 
>> started */
>
> Lines too long.
>
>> +/* the following constants and declarations are for unit test purposes and 
>> are
>> + * designed to be used in test applications.
>> + */
>> +#define XTEST_PASSED 0
>> +#define XTEST_FAILED 1
>> +
>> +#define XASSERT_NONE  0
>> +#define XASSERT_OCCURRED 1
>> +
>> +extern unsigned int XAssertStatus;
>> +extern void XAssert(char *, int);
>> +
>> +/ Type Definitions 
>> ***/
>> +
>> +/** @name Primitive types
>> + * These primitive types are created for transportability.
>> + * They are dependent upon the target architecture.
>> + * @{
>> + */
>> +#include 
>> +
>> +typedef struct {
>> + u32 Upper;
>> + u32 Lower;
>> +} Xuint64;
>> +
>> +/* Xilinx's unsigned integer types */
>> +typedef u32 Xuint32;
>> +typedef u16 Xuint16;
>> +typedef u8 Xuint8;
>> +
>> +/* and signed integer types */
>> +typedef s32 Xint32;
>> +typedef s16 Xint16;
>> +typedef s8 Xint8;
>> +
>> +#ifndef NULL
>> +#define NULL 0
>> +#endif
>> +
>> +typedef unsigned long Xboolean;
>> +#define XNULLNULL
>> +
>> +#define XTRUE1
>> +#define XFALSE   0
>> +
>> +/[EMAIL PROTECTED]/
>> +
>> +/**
>> + * This data type defines an interrupt handler for a device.
>> + * The argument points to the instance of the component
>> + */
>> +typedef void (*XInterruptHandler) (void *InstancePtr);
>> +
>> +/**
>> + * This data type defines a callback to be invoked when an
>> + * assert occurs. The callback is invoked only when asserts are enabled
>> + */
>> +typedef void (*XAssertCallback) (char *FilenamePtr, int LineNumber);
>> +
>> +/* Macros (Inline Functions) Definitions 
>> */
>> +
>> +/*/
>> +/**
>> +* Return the most significant half of the 64 bit data type.
>> +*
>> +* @param x is the 64 bit word.
>> +*
>> +* @return
>> +*
>> +* The upper 32 bits of the 64 bit word.
>> +*
>> +* @note
>> +*
>> +* None.
>> +*
>> +**/
>> +#define XUINT64_MSW(x) ((x).Upper)
>> +
>> +/*/
>> +/**
>> +* Return the least significant half of the 64 bit data type.
>> +*
>> +* @param x is the 64 bit word.
>> +*
>> +* @return
>> +*
>> +* The lower 32 bits of the 64 bit word.
>> +*
>> +* @note
>> +*
>> +* None.
>> +*
>> +**/
>> +#define XUINT64_LSW(x) ((x).Lower)
>> +
>> +#ifndef NDEBUG
>> +
>> +/*/
>> +/**
>> +* This assert macro is to be used for functions that do not return anything
>> +* (void). This in conjunction with the XWaitInAssert boolean can be used to
>> +* accomodate tests so that asserts which fail allow execution to continue.
>> +*
>> +* @param expression is the expression to evaluate. If it evaluates to false,
>> +* the assert occurs.
>> +*
>> +* @return
>> +*
>> +* Returns void unless the XWaitInAssert varia

Re: [U-Boot-Users] HELP, trying to remove complier warnings

[Scott Wood]

Wolfgang Denk wrote:
> In message <[EMAIL PROTECTED]> you wrote:
>> Try adding -fno-strict-aliasing
> 
> No, we don't want to hush up compiler warnings, we want to fix the
> problems instead.

It's not silencing a warning (if it were, it'd be a -W flag); it's 
disabling an incompatible optimization.

-Scott

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Re: [U-Boot-Users] Support for the ML507

[Wolfgang Denk]

In message <[EMAIL PROTECTED]> you wrote:
> 
>   So, I have spent the evening dividing the big patch in 8 independent
> patches. I have used the git tools to prepare the patches and resend
> them... Unfortunatelly some of this files are bigged than the 40kb
> limit If the mail list administrator don't accept this parts you
> can download the full set of patches from my website:
> http://www.ii.uam.es/~rribalda/ml507.tgz

40 kB is the soft limit; the hard limit is 100 kB.

>   Why my patches are so big... They give support to IPs by Xilinx,
> which have some kind of generic drivers to adapt them to multiple

You are aware that some similar code laready exists  in  U-Boot?  and
that  your  patches  contain  lots  of code that will most definitely
never be used in U-Boot?

> OS... When the driver was very complex I have used this generic
> drivers and added an adaptor. Because it does not follows the coding

I have extremely little emthusiasm to add big and complex drivers that
are intended to support many operating systems plus an adaption layer
to a small boot loader like U-Boot.

I think such drivers should be reimplemented from scratch, with
efficiency and style in mind.

> guidelines, all this drivers have been located under the board
> directory to respect all your "clean" work.

The Coding Style reqyierements apply to code in the board/ directories
as well.

And adding thsi stuff there makes it only worse, as the next similar
board that gets added will copy the whole crap.

This is bound to be unmaintainable.

I *strongly* recommend to redesign and reimplement.


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED]
How much net work could a network work, if a network could net work?

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Re: [U-Boot-Users] [PATCH] Adds support for the PPC440x5 Processor on Virtex5 FX

[Ricardo Ribalda Delgado]

Hi again

You are right on all your comments, I am correcting them on my
local copy. Once I receive more comments I will resubmit.

 Thanks and best regards

On Thu, Jul 10, 2008 at 8:36 PM, Wolfgang Denk <[EMAIL PROTECTED]> wrote:
> In message <[EMAIL PROTECTED]> you wrote:
>>
>> diff --git a/cpu/ppc4xx/4xx_enet.c b/cpu/ppc4xx/4xx_enet.c
>> index 4e863dc..d55ce56 100644
>> --- a/cpu/ppc4xx/4xx_enet.c
>> +++ b/cpu/ppc4xx/4xx_enet.c
>> @@ -97,7 +97,7 @@
>>   * network support enabled.
>>   * Remark: CONFIG_405 describes Xilinx PPC405 FPGA without EMAC controller!
>>   */
>> -#if defined(CONFIG_CMD_NET) && !defined(CONFIG_405) && 
>> !defined(CONFIG_IOP480)
>> +#if defined(CONFIG_CMD_NET) && !defined(CONFIG_405) && 
>> !defined(CONFIG_IOP480) && !defined(CONFIG_440_VIRTEX5)
>
> Line too long.
>
>>  #if !(defined(CONFIG_MII) || defined(CONFIG_CMD_MII))
>>  #error "CONFIG_MII has to be defined!"
>> diff --git a/cpu/ppc4xx/4xx_uart.c b/cpu/ppc4xx/4xx_uart.c
>> index a7587d4..e79c48c 100644
>> --- a/cpu/ppc4xx/4xx_uart.c
>> +++ b/cpu/ppc4xx/4xx_uart.c
>> @@ -48,6 +48,7 @@
>>  #include 
>>  #include 
>>
>> +#if !defined(CONFIG_440_VIRTEX5)
>>  #ifdef CONFIG_SERIAL_MULTI
>>  #include 
>>  #endif
>> @@ -58,6 +59,7 @@
>>
>>  DECLARE_GLOBAL_DATA_PTR;
>>
>> +
>
> Too many empty lines.
>
>>  #if defined(CONFIG_405GP) || defined(CONFIG_405CR) || \
>>  defined(CONFIG_405EP) || defined(CONFIG_405EZ) || \
>>  defined(CONFIG_405EX) || defined(CONFIG_440)
>> @@ -873,3 +875,5 @@ int serial_tstc(void)
>>  #endif /* CONFIG_SERIAL_MULTI */
>>
>>  #endif   /* CONFIG_405GP || CONFIG_405CR */
>> +
>
> Unnecessary empty line.
>
>> +#endif
>> diff --git a/cpu/ppc4xx/cpu.c b/cpu/ppc4xx/cpu.c
>> index 39f439d..defbbba 100644
>> --- a/cpu/ppc4xx/cpu.c
>> +++ b/cpu/ppc4xx/cpu.c
>> @@ -508,6 +508,11 @@ int checkcpu (void)
>>   puts("GT Rev. A");
>>   strcpy(addstr, "Security/Kasumi support");
>>   break;
>> +
>> + case PVR_VIRTEX5:
>> + printf(" VIRTEX5");
>> + break;
>> +
>>
>
> Too many empty lines.
>
>> --- a/cpu/ppc4xx/speed.c
>> +++ b/cpu/ppc4xx/speed.c
>> @@ -415,7 +415,7 @@ ulong get_PCI_freq (void)
>>   return sys_info.freqPCI;
>>  }
>>
>> -#elif !defined(CONFIG_440GX) && !defined(CONFIG_440SP) && 
>> !defined(CONFIG_440SPE)
>> +#elif !defined(CONFIG_440GX) && !defined(CONFIG_440SP) && 
>> !defined(CONFIG_440SPE) &&!defined(CONFIG_440_VIRTEX5)
>
> Line too long.
>
>> --- a/cpu/ppc4xx/start.S
>> +++ b/cpu/ppc4xx/start.S
>> @@ -367,6 +367,7 @@ skip_debug_init:
>>   /**/
>>   /* Setup interrupt vectors */
>>   /**/
>> + li  r0,0
>
> Why do you think this was necessary?
>
>> --- a/net/eth.c
>> +++ b/net/eth.c
>> @@ -291,6 +291,7 @@ int eth_initialize(bd_t *bis)
>>   at91sam9_eth_initialize(bis);
>>  #endif
>>
>> +
>
> Too many empoty lines.
>
>>   if (!eth_devices) {
>>   puts ("No ethernet found.\n");
>>   show_boot_progress (-64);
>> @@ -621,7 +622,7 @@ int eth_initialize(bd_t *bis)
>>   at91rm9200_miiphy_initialize(bis);
>>  #endif
>>  #if defined(CONFIG_4xx) && !defined(CONFIG_IOP480) \
>> - && !defined(CONFIG_AP1000) && !defined(CONFIG_405)
>> + && !defined(CONFIG_AP1000) && !defined(CONFIG_405) && 
>> !defined(CONFIG_440_VIRTEX5)
>
> Line too long.
>
>
> Best regards,
>
> Wolfgang Denk
>
> --
> DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED]
> Some people march to the beat of a different drummer. And some people
> tango!
>



-- 
Ricardo Ribalda
http://www.eps.uam.es/~rribalda/

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Re: [U-Boot-Users] HELP, trying to remove complier warnings

[Wolfgang Denk]

In message <[EMAIL PROTECTED]> you wrote:
> 
> Try adding -fno-strict-aliasing

No, we don't want to hush up compiler warnings, we want to fix the
problems instead.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED]
The first thing we do is kill all the lawyers.
(Shakespeare. II Henry VI, Act IV, scene ii)

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Re: [U-Boot-Users] [PATCH] Adds support for Xilinx Uart Lite on ppc4xx

[Wolfgang Denk]

In message <[EMAIL PROTECTED]> you wrote:
> 
> +* This program is free software; you can redistribute it and/or modify it
> +* under the terms of the GNU General Public License as published by the
> +* Free Software Foundation; either version 2 of the License, or (at your
> +* option) any later version.
...
> +* XILINX IS PROVIDING THIS DESIGN, CODE, OR INFORMATION "AS IS" AS A
> +* COURTESY TO YOU. BY PROVIDING THIS DESIGN, CODE, OR INFORMATION AS
> +* ONE POSSIBLE IMPLEMENTATION OF THIS FEATURE, APPLICATION OR STANDARD,
> +* XILINX IS MAKING NO REPRESENTATION THAT THIS IMPLEMENTATION IS FREE
> +* FROM ANY CLAIMS OF INFRINGEMENT, AND YOU ARE RESPONSIBLE FOR OBTAINING
> +* ANY THIRD PARTY RIGHTS YOU MAY REQUIRE FOR YOUR IMPLEMENTATION.

This is IMHO in contradiction to the GPL clause above.

> +* Xilinx hardware products are not intended for use in life support
> +* appliances, devices, or systems. Use in such applications is
> +* expressly prohibited.

This restriction is IMHO in contradiction to the GPL clause above.

...
> +#define XCOMPONENT_IS_READY  0x  /* component has been 
> initialized */
> +#define XCOMPONENT_IS_STARTED0x  /* component has been 
> started */

Lines too long.

> +/* the following constants and declarations are for unit test purposes and 
> are
> + * designed to be used in test applications.
> + */
> +#define XTEST_PASSED 0
> +#define XTEST_FAILED 1
> +
> +#define XASSERT_NONE  0
> +#define XASSERT_OCCURRED 1
> +
> +extern unsigned int XAssertStatus;
> +extern void XAssert(char *, int);
> +
> +/ Type Definitions 
> ***/
> +
> +/** @name Primitive types
> + * These primitive types are created for transportability.
> + * They are dependent upon the target architecture.
> + * @{
> + */
> +#include 
> +
> +typedef struct {
> + u32 Upper;
> + u32 Lower;
> +} Xuint64;
> +
> +/* Xilinx's unsigned integer types */
> +typedef u32 Xuint32;
> +typedef u16 Xuint16;
> +typedef u8 Xuint8;
> +
> +/* and signed integer types */
> +typedef s32 Xint32;
> +typedef s16 Xint16;
> +typedef s8 Xint8;
> +
> +#ifndef NULL
> +#define NULL 0
> +#endif
> +
> +typedef unsigned long Xboolean;
> +#define XNULLNULL
> +
> +#define XTRUE1
> +#define XFALSE   0
> +
> +/[EMAIL PROTECTED]/
> +
> +/**
> + * This data type defines an interrupt handler for a device.
> + * The argument points to the instance of the component
> + */
> +typedef void (*XInterruptHandler) (void *InstancePtr);
> +
> +/**
> + * This data type defines a callback to be invoked when an
> + * assert occurs. The callback is invoked only when asserts are enabled
> + */
> +typedef void (*XAssertCallback) (char *FilenamePtr, int LineNumber);
> +
> +/* Macros (Inline Functions) Definitions 
> */
> +
> +/*/
> +/**
> +* Return the most significant half of the 64 bit data type.
> +*
> +* @param x is the 64 bit word.
> +*
> +* @return
> +*
> +* The upper 32 bits of the 64 bit word.
> +*
> +* @note
> +*
> +* None.
> +*
> +**/
> +#define XUINT64_MSW(x) ((x).Upper)
> +
> +/*/
> +/**
> +* Return the least significant half of the 64 bit data type.
> +*
> +* @param x is the 64 bit word.
> +*
> +* @return
> +*
> +* The lower 32 bits of the 64 bit word.
> +*
> +* @note
> +*
> +* None.
> +*
> +**/
> +#define XUINT64_LSW(x) ((x).Lower)
> +
> +#ifndef NDEBUG
> +
> +/*/
> +/**
> +* This assert macro is to be used for functions that do not return anything
> +* (void). This in conjunction with the XWaitInAssert boolean can be used to
> +* accomodate tests so that asserts which fail allow execution to continue.
> +*
> +* @param expression is the expression to evaluate. If it evaluates to false,
> +* the assert occurs.
> +*
> +* @return
> +*
> +* Returns void unless the XWaitInAssert variable is true, in which case
> +* no return is made and an infinite loop is entered.
> +*
> +* @note
> +*
> +* None.
> +*
> +**/
> +#define XASSERT_VOID(expression) \
> +{\
> + if (expression) {   \
> + XAssertStatus = XASSERT_NONE;   \
> + } else {\
> + XAssert(__FILE__, __LINE__);\
> + XAssertStatus = XASSERT_OCCURRED;   \
> + return; \
> + }

Re: [U-Boot-Users] [PATCH] Adds support for the PPC440x5 Processor on Virtex5 FX

[Wolfgang Denk]

In message <[EMAIL PROTECTED]> you wrote:
> 
> diff --git a/cpu/ppc4xx/4xx_enet.c b/cpu/ppc4xx/4xx_enet.c
> index 4e863dc..d55ce56 100644
> --- a/cpu/ppc4xx/4xx_enet.c
> +++ b/cpu/ppc4xx/4xx_enet.c
> @@ -97,7 +97,7 @@
>   * network support enabled.
>   * Remark: CONFIG_405 describes Xilinx PPC405 FPGA without EMAC controller!
>   */
> -#if defined(CONFIG_CMD_NET) && !defined(CONFIG_405) && 
> !defined(CONFIG_IOP480)
> +#if defined(CONFIG_CMD_NET) && !defined(CONFIG_405) && 
> !defined(CONFIG_IOP480) && !defined(CONFIG_440_VIRTEX5)

Line too long.

>  #if !(defined(CONFIG_MII) || defined(CONFIG_CMD_MII))
>  #error "CONFIG_MII has to be defined!"
> diff --git a/cpu/ppc4xx/4xx_uart.c b/cpu/ppc4xx/4xx_uart.c
> index a7587d4..e79c48c 100644
> --- a/cpu/ppc4xx/4xx_uart.c
> +++ b/cpu/ppc4xx/4xx_uart.c
> @@ -48,6 +48,7 @@
>  #include 
>  #include 
>  
> +#if !defined(CONFIG_440_VIRTEX5)
>  #ifdef CONFIG_SERIAL_MULTI
>  #include 
>  #endif
> @@ -58,6 +59,7 @@
>  
>  DECLARE_GLOBAL_DATA_PTR;
>  
> +

Too many empty lines.

>  #if defined(CONFIG_405GP) || defined(CONFIG_405CR) || \
>  defined(CONFIG_405EP) || defined(CONFIG_405EZ) || \
>  defined(CONFIG_405EX) || defined(CONFIG_440)
> @@ -873,3 +875,5 @@ int serial_tstc(void)
>  #endif /* CONFIG_SERIAL_MULTI */
>  
>  #endif   /* CONFIG_405GP || CONFIG_405CR */
> +

Unnecessary empty line.

> +#endif
> diff --git a/cpu/ppc4xx/cpu.c b/cpu/ppc4xx/cpu.c
> index 39f439d..defbbba 100644
> --- a/cpu/ppc4xx/cpu.c
> +++ b/cpu/ppc4xx/cpu.c
> @@ -508,6 +508,11 @@ int checkcpu (void)
>   puts("GT Rev. A");
>   strcpy(addstr, "Security/Kasumi support");
>   break;
> + 
> + case PVR_VIRTEX5:
> + printf(" VIRTEX5");
> + break;
> +
>  

Too many empty lines.

> --- a/cpu/ppc4xx/speed.c
> +++ b/cpu/ppc4xx/speed.c
> @@ -415,7 +415,7 @@ ulong get_PCI_freq (void)
>   return sys_info.freqPCI;
>  }
>  
> -#elif !defined(CONFIG_440GX) && !defined(CONFIG_440SP) && 
> !defined(CONFIG_440SPE)
> +#elif !defined(CONFIG_440GX) && !defined(CONFIG_440SP) && 
> !defined(CONFIG_440SPE) &&!defined(CONFIG_440_VIRTEX5)

Line too long.

> --- a/cpu/ppc4xx/start.S
> +++ b/cpu/ppc4xx/start.S
> @@ -367,6 +367,7 @@ skip_debug_init:
>   /**/
>   /* Setup interrupt vectors */
>   /**/
> + li  r0,0

Why do you think this was necessary?

> --- a/net/eth.c
> +++ b/net/eth.c
> @@ -291,6 +291,7 @@ int eth_initialize(bd_t *bis)
>   at91sam9_eth_initialize(bis);
>  #endif
>  
> +

Too many empoty lines.

>   if (!eth_devices) {
>   puts ("No ethernet found.\n");
>   show_boot_progress (-64);
> @@ -621,7 +622,7 @@ int eth_initialize(bd_t *bis)
>   at91rm9200_miiphy_initialize(bis);
>  #endif
>  #if defined(CONFIG_4xx) && !defined(CONFIG_IOP480) \
> - && !defined(CONFIG_AP1000) && !defined(CONFIG_405)
> + && !defined(CONFIG_AP1000) && !defined(CONFIG_405) && 
> !defined(CONFIG_440_VIRTEX5)

Line too long.


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED]
Some people march to the beat of a different drummer. And some people
tango!

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Re: [U-Boot-Users] [PATCH] -Support fot the ADT7640 Monitor chip

[Ricardo Ribalda Delgado]

Hello again

  I have modified the license of all the patches, and they are now located at:
 http://www.ii.uam.es/~rribalda/ml507.tgz
  Waiting for more comments

  Thanks for your time and comments




On Thu, Jul 10, 2008 at 8:16 PM, Ricardo Ribalda Delgado
<[EMAIL PROTECTED]> wrote:
> Hello Jerry
>
> I didn't know that I will change the license and resend the
> patches as soon as I get more feedback to keep the mailing list as
> silent as possible.
>
>  Again: Thanks
>
> On Thu, Jul 10, 2008 at 8:10 PM, Jerry Van Baren <[EMAIL PROTECTED]> wrote:
>> Ricardo Ribalda Delgado wrote:
>>>
>>> Signed-off-by: Ricardo Ribalda Delgado <[EMAIL PROTECTED]>
>>> ---
>>>  drivers/hwmon/Makefile  |1 +
>>>  drivers/hwmon/adt7460.c |   89
>>> +++
>>>  drivers/hwmon/adt7460.h |   49 ++
>>>  include/dtt.h   |2 +-
>>>  4 files changed, 140 insertions(+), 1 deletions(-)
>>>  create mode 100644 drivers/hwmon/adt7460.c
>>>  create mode 100644 drivers/hwmon/adt7460.h
>>
>> [snip]
>>
>>> +++ b/drivers/hwmon/adt7460.c
>>> @@ -0,0 +1,89 @@
>>> +/*   +(C) Copyright 2008
>>> +Ricado Ribalda, Universidad Autonoma de Madrid,
>>> ricardo.ribaldauam.es , ricardo.ribaldagmail.com
>>> +This work has been supported by: Q-Technology  http://qtec.com/
>>> +
>>> +This program is free software: you can redistribute it and/or modify
>>> +it under the terms of the GNU General Public License as published by
>>> +the Free Software Foundation, either version 3 of the License, or
>>
>> Hi Ricardo,
>>
>> GPLv3 is a problem because most of u-boot is licensed at GPLv2 (possibly
>> with an upgrade clause).  The problem is, GPLv3 is not backward compatible
>> with GPLv2 because it adds restrictions.
>>  
>>
>> If you wish to have this added to u-boot, you will need to change the
>> licensing to GPLv2 (note that you can still keep the "any later" upgrade
>> clause).
>>
>> [snip]
>>
>>> diff --git a/drivers/hwmon/adt7460.h b/drivers/hwmon/adt7460.h
>>> new file mode 100644
>>> index 000..48666f7
>>> --- /dev/null
>>> +++ b/drivers/hwmon/adt7460.h
>>> @@ -0,0 +1,49 @@
>>> +/*   +(C) Copyright 2008
>>> +Ricado Ribalda, Universidad Autonoma de Madrid,
>>> ricardo.ribaldauam.es , ricardo.ribaldagmail.com
>>> +This work has been supported by: Q-Technology  http://qtec.com/+
>>> +This program is free software: you can redistribute it and/or modify
>>> +it under the terms of the GNU General Public License as published by
>>> +the Free Software Foundation, either version 3 of the License, or
>>
>> Ditto.
>>
>> Best regards,
>> gvb
>>
>
>
>
> --
> Ricardo Ribalda
> http://www.eps.uam.es/~rribalda/
>



-- 
Ricardo Ribalda
http://www.eps.uam.es/~rribalda/

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Re: [U-Boot-Users] [PATCH] Support fot the ML507 Board 1/4

[Ricardo]

Hello Wolfgang

  I wanted the four parts to have the same subject, to easy the
handling of the files. The first submition was 4 .bz2 dependent
files... But later on the evening I have prepared 8 different
INdependent patches following the guidelines on the u-boot site. Sorry
for the mess. I have sent some minutes ago an apologize and a
explanation. Please check it if you have enough time. It is my first
time with git, and I am a bit confused (even after a day of reading)


 Best regards and thanks

On Thu, Jul 10, 2008 at 8:18 PM, Wolfgang Denk <[EMAIL PROTECTED]> wrote:
> In message <[EMAIL PROTECTED]> you wrote:
>>
>> And Part  4
>
> Could you please explain why the subject says part 1, and the
> message body says part 4 ?
>
> Best regards,
>
> Wolfgang Denk
>
> --
> DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED]
> Computers make excellent and efficient servants, but I have  no  wish
> to  serve under them. Captain, a starship also runs on loyalty to one
> man. And nothing can replace it or him.
>-- Spock, "The Ultimate Computer", stardate 4729.4
>
> -
> Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
> Studies have shown that voting for your favorite open source project,
> along with a healthy diet, reduces your potential for chronic lameness
> and boredom. Vote Now at http://www.sourceforge.net/community/cca08
> ___
> U-Boot-Users mailing list
> U-Boot-Users@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/u-boot-users
>



-- 
Ricardo Ribalda
http://www.eps.uam.es/~rribalda/

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Re: [U-Boot-Users] [PATCH] Support fot the ML507 Board 1/4

[Wolfgang Denk]

In message <[EMAIL PROTECTED]> you wrote:
> 
> And Part  4

Could you please explain why the subject says part 1, and the
message body says part 4 ?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED]
Computers make excellent and efficient servants, but I have  no  wish
to  serve under them. Captain, a starship also runs on loyalty to one
man. And nothing can replace it or him.
-- Spock, "The Ultimate Computer", stardate 4729.4

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Re: [U-Boot-Users] [PATCH] Support fot the ML507 Board 1/4

[Wolfgang Denk]

In message <[EMAIL PROTECTED]> you wrote:
>
> Any comment will be very welcomed.
> 
> PS: I have divided the patch in four parts for the mailing list

Soerry, I can neither read nor apply this conveniently:

> Content-Type: application/x-bzip2; name=ml507_1_of_4.diff.bz2
> Content-Transfer-Encoding: base64
> X-Attachment-Id: f_fihjyhy70
> Content-Disposition: attachment; filename=ml507_1_of_4.diff.bz2
> 
> QlpoOTFBWSZTWSR6xsAAgHH/gH/6/r9gkx749nwE919zr26feb708npH3fPa
> Pab6z7Ye+2gXd9t2He+c3uzjhUa33venYaAvm+vPfd6vu856FHWmNq+nTqjVsqlW2WtUaapE
> egaKoXWjbQAoBQpa1De7y5295t3nPR6CB3tPvoBvWoXEj5L593r7fPglW+19xvu+c+++fd73b2fK
> D199c0D6+AczIa31pTs1PRtgegHQuwBkK9GgAUsTAUgJ9BlXQUA3hAJnfe+cd73Xe6r25vHWVNsp
> dn3NF751a4W2te3OqXbrtp10uO3Ve995xV7BoqiIAfb573fZod6XVLa7pNVjPrc73qoESpOjlKk7
> LtkO3ffFvvRfC5OMotZS0a99j15arBRaxb6xHZQa0c7VtqcmVW1jaM7VdGDRUOZRKnR4eqSqlCns
> cezurEPvtPT0CrODK202x9Wzs9x6F5ltl6oy6fe+T4eEoICBohoRpoQwo00aaKep+iekaNCm9U0/
...

Please make sure to post plain text patches only, and keep in mind
that the mailing list has a soft limit of 40 kB message size , and a
hard limit of 100 kB.

See http://www.denx.de/wiki/UBoot/Patches

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED]
"There are three principal ways to lose money: wine, women,  and  en-
gineers.  While  the first two are more pleasant, the third is by far
the more certain."  -- Baron Rothschild, ca. 1800

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Re: [U-Boot-Users] [PATCH] -Support fot the ADT7640 Monitor chip

[Ricardo Ribalda Delgado]

Hello Jerry

I didn't know that I will change the license and resend the
patches as soon as I get more feedback to keep the mailing list as
silent as possible.

  Again: Thanks

On Thu, Jul 10, 2008 at 8:10 PM, Jerry Van Baren <[EMAIL PROTECTED]> wrote:
> Ricardo Ribalda Delgado wrote:
>>
>> Signed-off-by: Ricardo Ribalda Delgado <[EMAIL PROTECTED]>
>> ---
>>  drivers/hwmon/Makefile  |1 +
>>  drivers/hwmon/adt7460.c |   89
>> +++
>>  drivers/hwmon/adt7460.h |   49 ++
>>  include/dtt.h   |2 +-
>>  4 files changed, 140 insertions(+), 1 deletions(-)
>>  create mode 100644 drivers/hwmon/adt7460.c
>>  create mode 100644 drivers/hwmon/adt7460.h
>
> [snip]
>
>> +++ b/drivers/hwmon/adt7460.c
>> @@ -0,0 +1,89 @@
>> +/*   +(C) Copyright 2008
>> +Ricado Ribalda, Universidad Autonoma de Madrid,
>> ricardo.ribaldauam.es , ricardo.ribaldagmail.com
>> +This work has been supported by: Q-Technology  http://qtec.com/
>> +
>> +This program is free software: you can redistribute it and/or modify
>> +it under the terms of the GNU General Public License as published by
>> +the Free Software Foundation, either version 3 of the License, or
>
> Hi Ricardo,
>
> GPLv3 is a problem because most of u-boot is licensed at GPLv2 (possibly
> with an upgrade clause).  The problem is, GPLv3 is not backward compatible
> with GPLv2 because it adds restrictions.
>  
>
> If you wish to have this added to u-boot, you will need to change the
> licensing to GPLv2 (note that you can still keep the "any later" upgrade
> clause).
>
> [snip]
>
>> diff --git a/drivers/hwmon/adt7460.h b/drivers/hwmon/adt7460.h
>> new file mode 100644
>> index 000..48666f7
>> --- /dev/null
>> +++ b/drivers/hwmon/adt7460.h
>> @@ -0,0 +1,49 @@
>> +/*   +(C) Copyright 2008
>> +Ricado Ribalda, Universidad Autonoma de Madrid,
>> ricardo.ribaldauam.es , ricardo.ribaldagmail.com
>> +This work has been supported by: Q-Technology  http://qtec.com/+
>> +This program is free software: you can redistribute it and/or modify
>> +it under the terms of the GNU General Public License as published by
>> +the Free Software Foundation, either version 3 of the License, or
>
> Ditto.
>
> Best regards,
> gvb
>



-- 
Ricardo Ribalda
http://www.eps.uam.es/~rribalda/

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

[U-Boot-Users] Support for the ML507

[Ricardo Ribalda Delgado]

Hello again:

  This is my third submission of the same thing, please be indulgent:

  This month I have been working on the ml507 board, trying to give it
support. This boards has a lot of components and I have developed
drivers for some of them. On my first submission, the board and the
drivers were on a single diff file. The mail list didn't like a
message so big so I cutted it in 4 parts, bziped it and resend it.
Later on I have realized that, it do not support the guidelines on the
web And it will be huge work for the mantainers to check all that
code

  So, I have spent the evening dividing the big patch in 8 independent
patches. I have used the git tools to prepare the patches and resend
them... Unfortunatelly some of this files are bigged than the 40kb
limit If the mail list administrator don't accept this parts you
can download the full set of patches from my website:
http://www.ii.uam.es/~rribalda/ml507.tgz

  Why my patches are so big... They give support to IPs by Xilinx,
which have some kind of generic drivers to adapt them to multiple
OS... When the driver was very complex I have used this generic
drivers and added an adaptor. Because it does not follows the coding
guidelines, all this drivers have been located under the board
directory to respect all your "clean" work.

   Sorry for the mess I have created in just a matter of minutes.


 Best Regards and I hope to see my code on the main line someday.


-- 
Ricardo Ribalda
http://www.eps.uam.es/~rribalda/

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Re: [U-Boot-Users] [PATCH] I2C Dummy Driver

[Jerry Van Baren]

Ricardo Ribalda Delgado wrote:
> Signed-off-by: Ricardo Ribalda Delgado <[EMAIL PROTECTED]>
> ---
>  drivers/i2c/Makefile|1 +
>  drivers/i2c/dummy_i2c.c |   84 
> +++
>  2 files changed, 85 insertions(+), 0 deletions(-)
>  create mode 100644 drivers/i2c/dummy_i2c.c
> 
> diff --git a/drivers/i2c/Makefile b/drivers/i2c/Makefile
> index 534c015..322c822 100644
> --- a/drivers/i2c/Makefile
> +++ b/drivers/i2c/Makefile
> @@ -30,6 +30,7 @@ COBJS-y += omap1510_i2c.o
>  COBJS-y += omap24xx_i2c.o
>  COBJS-y += tsi108_i2c.o
>  COBJS-y += mxc_i2c.o
> +COBJS-y += dummy_i2c.o
>  
>  COBJS:= $(COBJS-y)
>  SRCS := $(COBJS:.o=.c)
> diff --git a/drivers/i2c/dummy_i2c.c b/drivers/i2c/dummy_i2c.c
> new file mode 100644
> index 000..04f6edb
> --- /dev/null
> +++ b/drivers/i2c/dummy_i2c.c
> @@ -0,0 +1,84 @@
> +/*   
> +(C) Copyright 2008
> +Ricado Ribalda, Universidad Autonoma de Madrid, 
> ricardo.ribaldauam.es , ricardo.ribaldagmail.com
> +This work has been supported by: Q-Technology  http://qtec.com/
> +
> +This program is free software: you can redistribute it and/or modify
> +it under the terms of the GNU General Public License as published by
> +the Free Software Foundation, either version 3 of the License, or

Ditto: GPLv3 is a problem because most of u-boot is licensed at GPLv2 
(possibly with an upgrade clause).  The problem is, GPLv3 is not 
backward compatible with GPLv2 because it adds restrictions.
   

If you wish to have this added to u-boot, you will need to change the 
licensing to GPLv2 (note that you can still keep the "any later" upgrade 
clause).

Best regards,
gvb

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Re: [U-Boot-Users] [PATCH] -Support fot the ADT7640 Monitor chip

[Jerry Van Baren]

Ricardo Ribalda Delgado wrote:
> Signed-off-by: Ricardo Ribalda Delgado <[EMAIL PROTECTED]>
> ---
>  drivers/hwmon/Makefile  |1 +
>  drivers/hwmon/adt7460.c |   89 
> +++
>  drivers/hwmon/adt7460.h |   49 ++
>  include/dtt.h   |2 +-
>  4 files changed, 140 insertions(+), 1 deletions(-)
>  create mode 100644 drivers/hwmon/adt7460.c
>  create mode 100644 drivers/hwmon/adt7460.h

[snip]

> +++ b/drivers/hwmon/adt7460.c
> @@ -0,0 +1,89 @@
> +/*   
> +(C) Copyright 2008
> +Ricado Ribalda, Universidad Autonoma de Madrid, 
> ricardo.ribaldauam.es , ricardo.ribaldagmail.com
> +This work has been supported by: Q-Technology  http://qtec.com/
> +
> +This program is free software: you can redistribute it and/or modify
> +it under the terms of the GNU General Public License as published by
> +the Free Software Foundation, either version 3 of the License, or

Hi Ricardo,

GPLv3 is a problem because most of u-boot is licensed at GPLv2 (possibly 
with an upgrade clause).  The problem is, GPLv3 is not backward 
compatible with GPLv2 because it adds restrictions.
   

If you wish to have this added to u-boot, you will need to change the 
licensing to GPLv2 (note that you can still keep the "any later" upgrade 
clause).

[snip]

> diff --git a/drivers/hwmon/adt7460.h b/drivers/hwmon/adt7460.h
> new file mode 100644
> index 000..48666f7
> --- /dev/null
> +++ b/drivers/hwmon/adt7460.h
> @@ -0,0 +1,49 @@
> +/*   
> +(C) Copyright 2008
> +Ricado Ribalda, Universidad Autonoma de Madrid, 
> ricardo.ribaldauam.es , ricardo.ribaldagmail.com
> +This work has been supported by: Q-Technology  http://qtec.com/
> +
> +This program is free software: you can redistribute it and/or modify
> +it under the terms of the GNU General Public License as published by
> +the Free Software Foundation, either version 3 of the License, or

Ditto.

Best regards,
gvb

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

[U-Boot-Users] [GIT PULL] Please pull mpc512x tree

[John Rigby]

Wolfgang,

The following changes since commit d4692b0ba83b7b454bbd92bad1f4befe6e1657b7:
   Christian Eggers (1):
 Fix "usb part" command

are available in the git repository at:

   git://git.denx.de/u-boot-mpc512x.git master

Martha Marx (2):
   Consolidate ADS5121 IO Pin configuration
   Configuration changes for ADS5121 Rev 3

  Makefile  |9 +-
  board/ads5121/Makefile|2 +-
  board/ads5121/README  |9 ++
  board/ads5121/ads5121.c   |   54 ---
  board/ads5121/iopin.c |   96 +++
  board/ads5121/iopin.h |  222 ++
  cpu/mpc512x/cpu.c |8 +-
  cpu/mpc512x/fec.c |   15 ---
  include/configs/ads5121.h |   39 +++--
  9 files changed, 389 insertions(+), 65 deletions(-)
  create mode 100644 board/ads5121/README
  create mode 100644 board/ads5121/iopin.c
  create mode 100644 board/ads5121/iopin.h

Thanks
John



-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Re: [U-Boot-Users] HELP, trying to remove complier warnings

[Howard, Marc]

Kumar,

Try adding -fno-strict-aliasing

Marc Howard 

> -Original Message-
> From: [EMAIL PROTECTED] 
> [mailto:[EMAIL PROTECTED] On Behalf 
> Of Kumar Gala
> Sent: Thursday, July 10, 2008 9:59 AM
> To: u-boot-users@lists.sourceforge.net Users
> Subject: [U-Boot-Users] HELP, trying to remove complier warnings
> 
> I'm running with gcc-4.3 from fedora 9.  I get the following warnings:
> 
> dlmalloc.c: In function 'malloc_extend_top':
> dlmalloc.c:1971: error: dereferencing type-punned pointer will break  
> strict-aliasing rules
> dlmalloc.c:1999: error: dereferencing type-punned pointer will break  
> strict-aliasing rules
> dlmalloc.c:2029: error: dereferencing type-punned pointer will break  
> strict-aliasing rules
> dlmalloc.c:2031: error: dereferencing type-punned pointer will break  
> strict-aliasing rules
> dlmalloc.c:2042: error: dereferencing type-punned pointer will break  
> strict-aliasing rules
> dlmalloc.c: In function 'malloc':
> dlmalloc.c:2245: error: dereferencing type-punned pointer will break  
> strict-aliasing rules
> dlmalloc.c:2245: error: dereferencing type-punned pointer will break  
> strict-aliasing rules
> dlmalloc.c:2253: error: dereferencing type-punned pointer will break  
> strict-aliasing rules
> dlmalloc.c:2258: error: dereferencing type-punned pointer will break  
> strict-aliasing rules
> dlmalloc.c:2263: error: dereferencing type-punned pointer will break  
> strict-aliasing rules
> dlmalloc.c:2318: error: dereferencing type-punned pointer will break  
> strict-aliasing rules
> dlmalloc.c:2327: error: dereferencing type-punned pointer will break  
> strict-aliasing rules
> dlmalloc.c:2329: error: dereferencing type-punned pointer will break  
> strict-aliasing rules
> dlmalloc.c:2344: error: dereferencing type-punned pointer will break  
> strict-aliasing rules
> dlmalloc.c:2356: error: dereferencing type-punned pointer will break  
> strict-aliasing rules
> dlmalloc.c:2360: error: dereferencing type-punned pointer will break  
> strict-aliasing rules
> dlmalloc.c:2362: error: dereferencing type-punned pointer will break  
> strict-aliasing rules
> dlmalloc.c:2363: error: dereferencing type-punned pointer will break  
> strict-aliasing rules
> dlmalloc.c: In function 'free':
> dlmalloc.c:2431: error: dereferencing type-punned pointer will break  
> strict-aliasing rules
> dlmalloc.c:2444: error: dereferencing type-punned pointer will break  
> strict-aliasing rules
> dlmalloc.c:2483: error: dereferencing type-punned pointer will break  
> strict-aliasing rules
> dlmalloc.c:2483: error: dereferencing type-punned pointer will break  
> strict-aliasing rules
> dlmalloc.c: In function 'realloc':
> dlmalloc.c:2594: error: dereferencing type-punned pointer will break  
> strict-aliasing rules
> dlmalloc.c:2599: error: dereferencing type-punned pointer will break  
> strict-aliasing rules
> dlmalloc.c:2604: error: dereferencing type-punned pointer will break  
> strict-aliasing rules
> dlmalloc.c:2605: error: dereferencing type-punned pointer will break  
> strict-aliasing rules
> dlmalloc.c:2637: error: dereferencing type-punned pointer will break  
> strict-aliasing rules
> dlmalloc.c:2646: error: dereferencing type-punned pointer will break  
> strict-aliasing rules
> dlmalloc.c:2647: error: dereferencing type-punned pointer will break  
> strict-aliasing rules
> dlmalloc.c: In function 'calloc':
> dlmalloc.c:2896: error: dereferencing type-punned pointer will break  
> strict-aliasing rules
> dlmalloc.c:2897: error: dereferencing type-punned pointer will break  
> strict-aliasing rules
> dlmalloc.c: In function 'malloc_trim':
> dlmalloc.c:2987: error: dereferencing type-punned pointer will break  
> strict-aliasing rules
> dlmalloc.c:2997: error: dereferencing type-punned pointer will break  
> strict-aliasing rules
> dlmalloc.c:3008: error: dereferencing type-punned pointer will break  
> strict-aliasing rules
> dlmalloc.c:3012: error: dereferencing type-punned pointer will break  
> strict-aliasing rules
> dlmalloc.c:3021: error: dereferencing type-punned pointer will break  
> strict-aliasing rules
> 
> They all result from the bin_at macro in the file.  I can't 
> seem to do  
> anything to the code to get rid of them.
> 
> I see these both on x86 or ppc host builds:
> 
> x86:
> 
> gcc -g  -Os -m32-D__KERNEL__ -DTEXT_BASE=0x387c 
> -I/local/home/ 
> galak/u-boot/include -fno-builtin -ffreestanding -nostdinc -isystem / 
> usr/lib/gcc/x86_64-redhat-linux/4.3.0/include -pipe  -DCONFIG_I386 - 
> D__I386__ -march=i386 -Werror -Wall -Wstrict-prototypes -fno-stack- 
> protector -c -o dlmalloc.o dlmalloc.c
> 
> ppc:
> 
> gcc -g  -Os   -fPIC -ffixed-r14 -meabi -D__KERNEL__ - 
> DTEXT_BASE=0xeff8 
> -I/local/home/galak/git/u-boot-85xx/include -fno- 
> builtin -ffreestanding -nostdinc -isystem /usr/lib/gcc/ppc64-redhat- 
> linux/4.3.0/include -pipe  -DCONFIG_PPC -D__powerpc__ 
> -DCONFIG_MPC85xx  
> -DCONFIG_E500 -ffixed-r2 -Wa,-me500 -msoft-float -mno-stri

[U-Boot-Users] [PATCH] Adds support for Xilinx Uart Lite on ppc4xx

[Ricardo Ribalda Delgado]

Signed-off-by: Ricardo Ribalda Delgado <[EMAIL PROTECTED]>
---
 include/asm-ppc/arch-ppc4xx/xbasic_types.h |  301 
 include/asm-ppc/arch-ppc4xx/xio.h  |   63 ++
 include/asm-ppc/arch-ppc4xx/xuartlite_l.h  |  256 +++
 include/asm-ppc/serial_xuartlite.h |   25 +++
 4 files changed, 645 insertions(+), 0 deletions(-)
 create mode 100644 include/asm-ppc/arch-ppc4xx/xbasic_types.h
 create mode 100644 include/asm-ppc/arch-ppc4xx/xio.h
 create mode 100644 include/asm-ppc/arch-ppc4xx/xuartlite_l.h
 create mode 100644 include/asm-ppc/serial_xuartlite.h

diff --git a/include/asm-ppc/arch-ppc4xx/xbasic_types.h 
b/include/asm-ppc/arch-ppc4xx/xbasic_types.h
new file mode 100644
index 000..25012e6
--- /dev/null
+++ b/include/asm-ppc/arch-ppc4xx/xbasic_types.h
@@ -0,0 +1,301 @@
+/**
+*
+* Author: Xilinx, Inc.
+*
+*
+* This program is free software; you can redistribute it and/or modify it
+* under the terms of the GNU General Public License as published by the
+* Free Software Foundation; either version 2 of the License, or (at your
+* option) any later version.
+*
+*
+* XILINX IS PROVIDING THIS DESIGN, CODE, OR INFORMATION "AS IS" AS A
+* COURTESY TO YOU. BY PROVIDING THIS DESIGN, CODE, OR INFORMATION AS
+* ONE POSSIBLE IMPLEMENTATION OF THIS FEATURE, APPLICATION OR STANDARD,
+* XILINX IS MAKING NO REPRESENTATION THAT THIS IMPLEMENTATION IS FREE
+* FROM ANY CLAIMS OF INFRINGEMENT, AND YOU ARE RESPONSIBLE FOR OBTAINING
+* ANY THIRD PARTY RIGHTS YOU MAY REQUIRE FOR YOUR IMPLEMENTATION.
+* XILINX EXPRESSLY DISCLAIMS ANY WARRANTY WHATSOEVER WITH RESPECT TO
+* THE ADEQUACY OF THE IMPLEMENTATION, INCLUDING BUT NOT LIMITED TO ANY
+* WARRANTIES OR REPRESENTATIONS THAT THIS IMPLEMENTATION IS FREE FROM
+* CLAIMS OF INFRINGEMENT, IMPLIED WARRANTIES OF MERCHANTABILITY AND
+* FITNESS FOR A PARTICULAR PURPOSE.
+*
+*
+* Xilinx hardware products are not intended for use in life support
+* appliances, devices, or systems. Use in such applications is
+* expressly prohibited.
+*
+*
+* (c) Copyright 2002-2003 Xilinx Inc.
+* All rights reserved.
+*
+*
+* You should have received a copy of the GNU General Public License along
+* with this program; if not, write to the Free Software Foundation, Inc.,
+* 675 Mass Ave, Cambridge, MA 02139, USA.
+*
+**/
+/*/
+/**
+*
+* @file xbasic_types.h
+*
+* This file contains basic types for Xilinx software IP.  These types do not
+* follow the standard naming convention with respect to using the component
+* name in front of each name because they are considered to be primitives.
+*
+* @note
+*
+* This file contains items which are architecture dependent.
+*
+* 
+* MODIFICATION HISTORY:
+*
+* Ver   WhoDateChanges
+* -   ---
+* 1.00a rmm  12/14/01 First release
+*  rmm  05/09/03 Added "xassert always" macros to rid ourselves of diab
+*compiler warnings
+* 
+*
+**/
+
+#ifndef XBASIC_TYPES_H /* prevent circular inclusions */
+#define XBASIC_TYPES_H /* by using protection macros */
+
+/* Include Files */
+
+/** Constant Definitions */
+
+#ifndef TRUE
+#define TRUE 1
+#endif
+#ifndef FALSE
+#define FALSE 0
+#endif
+
+#ifndef NULL
+#define NULL 0
+#endif
+/** Null */
+
+#define XCOMPONENT_IS_READY0x  /* component has been 
initialized */
+#define XCOMPONENT_IS_STARTED  0x  /* component has been started */
+
+/* the following constants and declarations are for unit test purposes and are
+ * designed to be used in test applications.
+ */
+#define XTEST_PASSED   0
+#define XTEST_FAILED   1
+
+#define XASSERT_NONE0
+#define XASSERT_OCCURRED 1
+
+extern unsigned int XAssertStatus;
+extern void XAssert(char *, int);
+
+/ Type Definitions ***/
+
+/** @name Primitive types
+ * These primitive types are created for transportability.
+ * They are dependent upon the target architecture.
+ * @{
+ */
+#include 
+
+typedef struct {
+   u32 Upper;
+   u32 Lower;
+} Xuint64;
+
+/* Xilinx's unsigned integer types */
+typedef u32 Xuint32;
+typedef u16 Xuint16;
+typedef u8 Xuint8;
+
+/* and signed integer types */
+typedef s32 Xint32;
+typedef s16 Xint16;
+typedef s8 Xint8;
+
+#ifndef NULL
+#define NULL 0
+#endif
+
+typedef unsigned long Xboolean;
+#define XNULL  NULL
+
+#define XTRUE  1
+#define XFALSE 0
+
+/[EMAIL PROTECTED]/
+
+/**
+ * This data type defi

[U-Boot-Users] [PATCH] Adds support for the PPC440x5 Processor on Virtex5 FX

[Ricardo Ribalda Delgado]

Signed-off-by: Ricardo Ribalda Delgado <[EMAIL PROTECTED]>
---
 cpu/ppc4xx/4xx_enet.c   |2 +-
 cpu/ppc4xx/4xx_uart.c   |4 
 cpu/ppc4xx/cpu.c|5 +
 cpu/ppc4xx/gpio.c   |5 +
 cpu/ppc4xx/interrupts.c |6 ++
 cpu/ppc4xx/miiphy.c |5 +
 cpu/ppc4xx/speed.c  |5 -
 cpu/ppc4xx/start.S  |1 +
 include/asm-ppc/processor.h |2 ++
 net/eth.c   |3 ++-
 10 files changed, 35 insertions(+), 3 deletions(-)

diff --git a/cpu/ppc4xx/4xx_enet.c b/cpu/ppc4xx/4xx_enet.c
index 4e863dc..d55ce56 100644
--- a/cpu/ppc4xx/4xx_enet.c
+++ b/cpu/ppc4xx/4xx_enet.c
@@ -97,7 +97,7 @@
  * network support enabled.
  * Remark: CONFIG_405 describes Xilinx PPC405 FPGA without EMAC controller!
  */
-#if defined(CONFIG_CMD_NET) && !defined(CONFIG_405) && !defined(CONFIG_IOP480)
+#if defined(CONFIG_CMD_NET) && !defined(CONFIG_405) && !defined(CONFIG_IOP480) 
&& !defined(CONFIG_440_VIRTEX5)
 
 #if !(defined(CONFIG_MII) || defined(CONFIG_CMD_MII))
 #error "CONFIG_MII has to be defined!"
diff --git a/cpu/ppc4xx/4xx_uart.c b/cpu/ppc4xx/4xx_uart.c
index a7587d4..e79c48c 100644
--- a/cpu/ppc4xx/4xx_uart.c
+++ b/cpu/ppc4xx/4xx_uart.c
@@ -48,6 +48,7 @@
 #include 
 #include 
 
+#if !defined(CONFIG_440_VIRTEX5)
 #ifdef CONFIG_SERIAL_MULTI
 #include 
 #endif
@@ -58,6 +59,7 @@
 
 DECLARE_GLOBAL_DATA_PTR;
 
+
 #if defined(CONFIG_405GP) || defined(CONFIG_405CR) || \
 defined(CONFIG_405EP) || defined(CONFIG_405EZ) || \
 defined(CONFIG_405EX) || defined(CONFIG_440)
@@ -873,3 +875,5 @@ int serial_tstc(void)
 #endif /* CONFIG_SERIAL_MULTI */
 
 #endif /* CONFIG_405GP || CONFIG_405CR */
+
+#endif
diff --git a/cpu/ppc4xx/cpu.c b/cpu/ppc4xx/cpu.c
index 39f439d..defbbba 100644
--- a/cpu/ppc4xx/cpu.c
+++ b/cpu/ppc4xx/cpu.c
@@ -508,6 +508,11 @@ int checkcpu (void)
puts("GT Rev. A");
strcpy(addstr, "Security/Kasumi support");
break;
+   
+   case PVR_VIRTEX5:
+   printf(" VIRTEX5");
+   break;
+
 
default:
printf (" UNKNOWN (PVR=%08x)", pvr);
diff --git a/cpu/ppc4xx/gpio.c b/cpu/ppc4xx/gpio.c
index df99f53..59159ee 100644
--- a/cpu/ppc4xx/gpio.c
+++ b/cpu/ppc4xx/gpio.c
@@ -26,6 +26,9 @@
 #include 
 #include 
 
+
+#if !defined(CONFIG_440_VIRTEX5)
+
 #if defined(CFG_4xx_GPIO_TABLE)
 gpio_param_s const gpio_tab[GPIO_GROUP_MAX][GPIO_MAX] = CFG_4xx_GPIO_TABLE;
 #endif
@@ -253,3 +256,5 @@ void gpio_set_chip_configuration(void)
}
 }
 #endif /* CFG_4xx_GPIO_TABLE */
+
+#endif
diff --git a/cpu/ppc4xx/interrupts.c b/cpu/ppc4xx/interrupts.c
index 8620e2b..7c7b073 100644
--- a/cpu/ppc4xx/interrupts.c
+++ b/cpu/ppc4xx/interrupts.c
@@ -28,6 +28,9 @@
  */
 
 #include 
+
+#if !defined(CONFIG_440_VIRTEX5)
+
 #include 
 #include 
 #include 
@@ -393,3 +396,6 @@ int do_irqinfo(cmd_tbl_t *cmdtp, int flag, int argc, char 
*argv[])
return 0;
 }
 #endif
+
+
+#endif
diff --git a/cpu/ppc4xx/miiphy.c b/cpu/ppc4xx/miiphy.c
index c882720..172fbcd 100644
--- a/cpu/ppc4xx/miiphy.c
+++ b/cpu/ppc4xx/miiphy.c
@@ -43,6 +43,9 @@
 #include <405_mal.h>
 #include 
 
+
+#if !defined(CONFIG_440_VIRTEX5)
+
 #if !defined(CONFIG_PHY_CLK_FREQ)
 #define CONFIG_PHY_CLK_FREQ0
 #endif
@@ -331,3 +334,5 @@ int emac4xx_miiphy_write (char *devname, unsigned char 
addr, unsigned char reg,
 {
return emac_miiphy_command(addr, reg, EMAC_STACR_WRITE, value);
 }
+
+#endif
diff --git a/cpu/ppc4xx/speed.c b/cpu/ppc4xx/speed.c
index 34bd721..5aa3655 100644
--- a/cpu/ppc4xx/speed.c
+++ b/cpu/ppc4xx/speed.c
@@ -415,7 +415,7 @@ ulong get_PCI_freq (void)
return sys_info.freqPCI;
 }
 
-#elif !defined(CONFIG_440GX) && !defined(CONFIG_440SP) && 
!defined(CONFIG_440SPE)
+#elif !defined(CONFIG_440GX) && !defined(CONFIG_440SP) && 
!defined(CONFIG_440SPE) &&!defined(CONFIG_440_VIRTEX5)
 void get_sys_info (sys_info_t * sysInfo)
 {
unsigned long strp0;
@@ -448,6 +448,8 @@ void get_sys_info (sys_info_t * sysInfo)
sysInfo->freqUART = sysInfo->freqPLB;
 }
 #else
+
+#if !defined(CONFIG_440_VIRTEX5)
 void get_sys_info (sys_info_t * sysInfo)
 {
unsigned long strp0;
@@ -534,6 +536,7 @@ void get_sys_info (sys_info_t * sysInfo)
 }
 
 #endif
+#endif
 
 #if defined(CONFIG_YUCCA)
 unsigned long determine_sysper(void)
diff --git a/cpu/ppc4xx/start.S b/cpu/ppc4xx/start.S
index 426bf3c..acb536d 100644
--- a/cpu/ppc4xx/start.S
+++ b/cpu/ppc4xx/start.S
@@ -367,6 +367,7 @@ skip_debug_init:
/**/
/* Setup interrupt vectors */
/**/
+   li  r0,0
mtspr   ivpr,r0 /* Vectors start at 0x_ */
li  r1,0x0100
mtspr   ivor0,r1/* Critical input */
diff --git a/include/asm-ppc/processor.h b/include/asm-ppc/processor.h
index 10fd478..04fa431 100644
--- a/include/asm-ppc/pro

[U-Boot-Users] [PATCH] I2C Dummy Driver

[Ricardo Ribalda Delgado]

Signed-off-by: Ricardo Ribalda Delgado <[EMAIL PROTECTED]>
---
 drivers/i2c/Makefile|1 +
 drivers/i2c/dummy_i2c.c |   84 +++
 2 files changed, 85 insertions(+), 0 deletions(-)
 create mode 100644 drivers/i2c/dummy_i2c.c

diff --git a/drivers/i2c/Makefile b/drivers/i2c/Makefile
index 534c015..322c822 100644
--- a/drivers/i2c/Makefile
+++ b/drivers/i2c/Makefile
@@ -30,6 +30,7 @@ COBJS-y += omap1510_i2c.o
 COBJS-y += omap24xx_i2c.o
 COBJS-y += tsi108_i2c.o
 COBJS-y += mxc_i2c.o
+COBJS-y += dummy_i2c.o
 
 COBJS  := $(COBJS-y)
 SRCS   := $(COBJS:.o=.c)
diff --git a/drivers/i2c/dummy_i2c.c b/drivers/i2c/dummy_i2c.c
new file mode 100644
index 000..04f6edb
--- /dev/null
+++ b/drivers/i2c/dummy_i2c.c
@@ -0,0 +1,84 @@
+/*   
+(C) Copyright 2008
+Ricado Ribalda, Universidad Autonoma de Madrid, ricardo.ribaldauam.es 
, ricardo.ribaldagmail.com
+This work has been supported by: Q-Technology  http://qtec.com/
+
+This program is free software: you can redistribute it and/or modify
+it under the terms of the GNU General Public License as published by
+the Free Software Foundation, either version 3 of the License, or
+(at your option) any later version.
+
+This program is distributed in the hope that it will be useful,
+but WITHOUT ANY WARRANTY; without even the implied warranty of
+MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+GNU General Public License for more details.
+
+You should have received a copy of the GNU General Public License
+along with this program.  If not, see .
+*/
+
+#include 
+
+#if defined(CONFIG_DUMMY_I2C)
+
+
+#include 
+u8 
i2c_dummy_buffer[256]={0x80,0x8,0x8,0x0D,0x0A,0x60,0x40,0x0,0x5,0x3D,0x50,0x0,0x82,0x10,0x0,0x0,0x0C,0x4,0x18,0x1,0x4,0x0,0x1,0x50,0x50,0x0,0x0,0x3C,0x28,0x3C,0x2D,0x40,0x25,0x37,0x10,0x22,0x3C,0x1E,0x1E,0x0,0x0,0x3C,0x69,0x80,0x1E,0x28,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x12,0xC9,0x2C,'0','0','0','0','0','0','0',0x0,'4','H','T','F','3','2','6','4','H','Y','-','5','3','E','D','3',0x3,0x0,0x0,0x0,0x0};
+   
+
+
+void i2c_init(int speed, int slaveaddr){
+   return ;
+}
+
+
+
+int
+i2c_read(uchar chip, uint addr, int alen, uchar * buffer, int len)
+{
+   int i;
+   if (alen!=1)
+   return -1;
+
+   if (addr+len>0xff)
+   return -1;
+
+   for(i=0;i0xff)
+   return -1;
+
+   for(i=0;ihttp://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

[U-Boot-Users] [PATCH] -Support fot the ADT7640 Monitor chip

[Ricardo Ribalda Delgado]

Signed-off-by: Ricardo Ribalda Delgado <[EMAIL PROTECTED]>
---
 drivers/hwmon/Makefile  |1 +
 drivers/hwmon/adt7460.c |   89 +++
 drivers/hwmon/adt7460.h |   49 ++
 include/dtt.h   |2 +-
 4 files changed, 140 insertions(+), 1 deletions(-)
 create mode 100644 drivers/hwmon/adt7460.c
 create mode 100644 drivers/hwmon/adt7460.h

diff --git a/drivers/hwmon/Makefile b/drivers/hwmon/Makefile
index 065433a..83aa297 100644
--- a/drivers/hwmon/Makefile
+++ b/drivers/hwmon/Makefile
@@ -34,6 +34,7 @@ COBJS-y += adm1021.o
 COBJS-y += ds1621.o
 COBJS-y += ds1722.o
 COBJS-y += ds1775.o
+COBJS-y += adt7460.o
 COBJS-$(CONFIG_DTT_LM73) += lm73.o
 COBJS-y += lm75.o
 COBJS-y += lm81.o
diff --git a/drivers/hwmon/adt7460.c b/drivers/hwmon/adt7460.c
new file mode 100644
index 000..255d6ed
--- /dev/null
+++ b/drivers/hwmon/adt7460.c
@@ -0,0 +1,89 @@
+/*   
+(C) Copyright 2008
+Ricado Ribalda, Universidad Autonoma de Madrid, ricardo.ribaldauam.es 
, ricardo.ribaldagmail.com
+This work has been supported by: Q-Technology  http://qtec.com/
+
+This program is free software: you can redistribute it and/or modify
+it under the terms of the GNU General Public License as published by
+the Free Software Foundation, either version 3 of the License, or
+(at your option) any later version.
+
+This program is distributed in the hope that it will be useful,
+but WITHOUT ANY WARRANTY; without even the implied warranty of
+MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+GNU General Public License for more details.
+
+You should have received a copy of the GNU General Public License
+along with this program.  If not, see .
+*/
+
+#include 
+
+#ifdef CONFIG_DTT_ADT7460
+
+#include 
+#include 
+#include "adt7460.h"
+
+#define ADT7460_ADDRESS 0x2c
+
+
+int dtt_read(int sensor, int reg)
+{
+   u8 dir=reg;
+   u8 data;
+
+   if (-1==i2c_read(ADT7460_ADDRESS,dir,1,&data,1))
+   return -1;
+   
+   if (data==ADT7460_INVALID)
+   return -1;
+
+   return data;
+
+} 
+
+
+int dtt_write(int sensor, int reg, int val)
+{
+   u8 dir=reg;
+   u8 data=val;
+   
+   if (-1==i2c_write(ADT7460_ADDRESS,dir,1,&data,1))
+   return -1;
+
+   return 0;
+} 
+
+
+
+int dtt_init (void)
+{
+   printf("ADT7460 at I2C address 0x%2x\n",ADT7460_ADDRESS);
+   if (-1==dtt_write(0,ADT7460_CONFIG,1)){
+   printf("Error initialiting ADT7460\n");
+   return -1;
+   }
+   return 0;
+} 
+
+
+int dtt_get_temp(int sensor)
+{
+   int aux;
+   u8 table[]={ADT7460_REM1_TEMP,ADT7460_LOCAL_TEMP,ADT7460_REM2_TEMP};
+   if (sensor>2){
+   printf("DTT sensor does not exist\n");
+   return -1;
+   }
+   
+   aux=dtt_read(0,table[sensor]);
+
+   if (-1==aux){
+   printf("DTT temperature read failed\n");
+   return -1;
+
+   }
+   return aux;
+}
+#endif 
diff --git a/drivers/hwmon/adt7460.h b/drivers/hwmon/adt7460.h
new file mode 100644
index 000..48666f7
--- /dev/null
+++ b/drivers/hwmon/adt7460.h
@@ -0,0 +1,49 @@
+/*   
+(C) Copyright 2008
+Ricado Ribalda, Universidad Autonoma de Madrid, ricardo.ribaldauam.es 
, ricardo.ribaldagmail.com
+This work has been supported by: Q-Technology  http://qtec.com/
+
+This program is free software: you can redistribute it and/or modify
+it under the terms of the GNU General Public License as published by
+the Free Software Foundation, either version 3 of the License, or
+(at your option) any later version.
+
+This program is distributed in the hope that it will be useful,
+but WITHOUT ANY WARRANTY; without even the implied warranty of
+MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+GNU General Public License for more details.
+
+You should have received a copy of the GNU General Public License
+along with this program.  If not, see .
+*/
+#ifndef ADT7460
+#define ADT7460
+
+
+#define ADT7460_INVALID 128
+
+#define ADT7460_2_5V   0x20
+#define ADT7460_VCCP   0x21
+#define ADT7460_VCC0x22
+#define ADT7460_V5 0x23
+#define ADT7460_V120x24
+#define ADT7460_REM1_TEMP  0x25
+#define ADT7460_LOCAL_TEMP 0x26
+#define ADT7460_REM2_TEMP  0x27
+#define ADT7460_TACH1L 0x28
+#define ADT7460_TACH1H 0x29
+#define ADT7460_TACH2L 0x2a
+#define ADT7460_TACH2H 0x2b
+#define ADT7460_TACH3L 0x2c
+#define ADT7460_TACH3H 0x2d
+#define ADT7460_TACH4L 0x2e
+#define ADT7460_TACH4H 0x2f
+#define ADT7460_TACH5L 0xa9
+#define ADT7460_TACH5H 0xaa
+#define ADT7460_TACH6L 0xab
+#define ADT7460_TACH6H 0xac
+#define ADT7460_REVISION   0x3f
+#defi

[U-Boot-Users] Support for the ML507 Xilinx Board

[Ricardo Ribalda Delgado]

Hi List:



This is my first contribution to u-boot. I have ported u-boot to the
ML507 Board by Xilinx.
http://www.xilinx.com/products/devkits/HW-V5-ML507-UNI-G.htm

This boards includes an FPGA Virtex 5 FX with an embedded PowerPC 440.

The port supports:
   -Virtex 5 ppc440x5
   -XIlinx Interrupt Controller
   -Xilinx I2C Controller (Interrupted mode)
   -Xilinx Uart Lite (simple port)
   -Xilinx LL_TEMA (Interrupted and SGDMA)
   -Save environment on board eeprom
   -DTT support for the ADT sensor on board (new hwmon driver)
   -Dummy I2C driver (for testing purposes)

This patch works against the last commit to the p4xx branch.

I am a researcher of the Universidad Autonoma de Madrid, and this work
has been supported by Q-Technology ( http://qtec.com ) under a
Research Agreement.

Any comment will be very welcomed.

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

[U-Boot-Users] Pull Request: Please pull u-boot-mpc86xx.git

[Jon Loeliger]

Wolfgang,

The following changes are available in the git repository at:

  git://www.denx.de/git/u-boot-mpc86xx.git master


Jason Jin (1):
  Feed the watchdog in u-boot for 8610 board.

Kumar Gala (2):
  MPC8641HPCN: Report board id, board version and fpga version.
  MPC8610HPCD: Report board id, board version and fpga version.

Thanks,
jdl

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Re: [U-Boot-Users] [PATCH] add 'license' command to u-boot?commandline

[Jean-Christophe PLAGNIOL-VILLARD]

On 13:08 Thu 10 Jul , Stefan Roese wrote:
> On Thursday 10 July 2008, Detlev Zundel wrote:
> > > IMHO, vim and xxd are essential programs so I'm OK with using
> > > xxd. OTOH, I understand some people actually prefer emacs and may have
> > > a problem with requiring vim to be installed.  ;-/
> >
> > Even though I'm an enthusiastic Emacs user, I have different reasons for
> > my vote.  As far as build dependencies go, I'd like to restrict this to
> > the LSB standard[1].  Xdd is not in there, so thats why I vote for the
> > small C program (unless we can adapt the script and use 'od').
> 
> I would prefer this C program solution too.

I would prefer this C program solution too.

Best Regards,
J.

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

[U-Boot-Users] HELP, trying to remove complier warnings

[Kumar Gala]

I'm running with gcc-4.3 from fedora 9.  I get the following warnings:

dlmalloc.c: In function ‘malloc_extend_top’:
dlmalloc.c:1971: error: dereferencing type-punned pointer will break  
strict-aliasing rules
dlmalloc.c:1999: error: dereferencing type-punned pointer will break  
strict-aliasing rules
dlmalloc.c:2029: error: dereferencing type-punned pointer will break  
strict-aliasing rules
dlmalloc.c:2031: error: dereferencing type-punned pointer will break  
strict-aliasing rules
dlmalloc.c:2042: error: dereferencing type-punned pointer will break  
strict-aliasing rules
dlmalloc.c: In function ‘malloc’:
dlmalloc.c:2245: error: dereferencing type-punned pointer will break  
strict-aliasing rules
dlmalloc.c:2245: error: dereferencing type-punned pointer will break  
strict-aliasing rules
dlmalloc.c:2253: error: dereferencing type-punned pointer will break  
strict-aliasing rules
dlmalloc.c:2258: error: dereferencing type-punned pointer will break  
strict-aliasing rules
dlmalloc.c:2263: error: dereferencing type-punned pointer will break  
strict-aliasing rules
dlmalloc.c:2318: error: dereferencing type-punned pointer will break  
strict-aliasing rules
dlmalloc.c:2327: error: dereferencing type-punned pointer will break  
strict-aliasing rules
dlmalloc.c:2329: error: dereferencing type-punned pointer will break  
strict-aliasing rules
dlmalloc.c:2344: error: dereferencing type-punned pointer will break  
strict-aliasing rules
dlmalloc.c:2356: error: dereferencing type-punned pointer will break  
strict-aliasing rules
dlmalloc.c:2360: error: dereferencing type-punned pointer will break  
strict-aliasing rules
dlmalloc.c:2362: error: dereferencing type-punned pointer will break  
strict-aliasing rules
dlmalloc.c:2363: error: dereferencing type-punned pointer will break  
strict-aliasing rules
dlmalloc.c: In function ‘free’:
dlmalloc.c:2431: error: dereferencing type-punned pointer will break  
strict-aliasing rules
dlmalloc.c:2444: error: dereferencing type-punned pointer will break  
strict-aliasing rules
dlmalloc.c:2483: error: dereferencing type-punned pointer will break  
strict-aliasing rules
dlmalloc.c:2483: error: dereferencing type-punned pointer will break  
strict-aliasing rules
dlmalloc.c: In function ‘realloc’:
dlmalloc.c:2594: error: dereferencing type-punned pointer will break  
strict-aliasing rules
dlmalloc.c:2599: error: dereferencing type-punned pointer will break  
strict-aliasing rules
dlmalloc.c:2604: error: dereferencing type-punned pointer will break  
strict-aliasing rules
dlmalloc.c:2605: error: dereferencing type-punned pointer will break  
strict-aliasing rules
dlmalloc.c:2637: error: dereferencing type-punned pointer will break  
strict-aliasing rules
dlmalloc.c:2646: error: dereferencing type-punned pointer will break  
strict-aliasing rules
dlmalloc.c:2647: error: dereferencing type-punned pointer will break  
strict-aliasing rules
dlmalloc.c: In function ‘calloc’:
dlmalloc.c:2896: error: dereferencing type-punned pointer will break  
strict-aliasing rules
dlmalloc.c:2897: error: dereferencing type-punned pointer will break  
strict-aliasing rules
dlmalloc.c: In function ‘malloc_trim’:
dlmalloc.c:2987: error: dereferencing type-punned pointer will break  
strict-aliasing rules
dlmalloc.c:2997: error: dereferencing type-punned pointer will break  
strict-aliasing rules
dlmalloc.c:3008: error: dereferencing type-punned pointer will break  
strict-aliasing rules
dlmalloc.c:3012: error: dereferencing type-punned pointer will break  
strict-aliasing rules
dlmalloc.c:3021: error: dereferencing type-punned pointer will break  
strict-aliasing rules

They all result from the bin_at macro in the file.  I can't seem to do  
anything to the code to get rid of them.

I see these both on x86 or ppc host builds:

x86:

gcc -g  -Os -m32-D__KERNEL__ -DTEXT_BASE=0x387c -I/local/home/ 
galak/u-boot/include -fno-builtin -ffreestanding -nostdinc -isystem / 
usr/lib/gcc/x86_64-redhat-linux/4.3.0/include -pipe  -DCONFIG_I386 - 
D__I386__ -march=i386 -Werror -Wall -Wstrict-prototypes -fno-stack- 
protector -c -o dlmalloc.o dlmalloc.c

ppc:

gcc -g  -Os   -fPIC -ffixed-r14 -meabi -D__KERNEL__ - 
DTEXT_BASE=0xeff8 -I/local/home/galak/git/u-boot-85xx/include -fno- 
builtin -ffreestanding -nostdinc -isystem /usr/lib/gcc/ppc64-redhat- 
linux/4.3.0/include -pipe  -DCONFIG_PPC -D__powerpc__ -DCONFIG_MPC85xx  
-DCONFIG_E500 -ffixed-r2 -Wa,-me500 -msoft-float -mno-string -mno-spe - 
DCONFIG_E500=1 -DCONFIG_MPC85xx=1 -DCONFIG_PPC_P4080=1 -Wall -Wstrict- 
prototypes -fno-stack-protector  -c -o dlmalloc.o dlmalloc.c

- k 

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
__

Re: [U-Boot-Users] u-boot, powerpc with device tree, initrd problem

[John Linn]

> -Original Message-
> From: Jerry Van Baren [mailto:[EMAIL PROTECTED]
> Sent: Wednesday, July 09, 2008 2:27 PM
> To: John Linn
> Cc: u-boot-users@lists.sourceforge.net
> Subject: Re: [U-Boot-Users] u-boot, powerpc with device tree, initrd
problem

[snip]

> 
> You might try loading your dtb and then use the "fdt chosen" command
to
> create the /chosen node and the "fdt bd" command to run the
> board-specific fixups.  Do these as two separate steps and run "fdt
> print" in between to see what changes occur.

I don't have any board specific fixups. We have the chosen already in
the dts before I compile it to a blob.  We do this because with the FPGA
many people don't use a boot loader.

> 
> > => bootm 0x1c0 0x180 0x100
> > ## Booting image at 01c0 ...
> >Image Name:   Linux-2.6.26-rc8
> >Image Type:   PowerPC Linux Kernel Image (gzip compressed)
> >Data Size:1536962 Bytes =  1.5 MB
> >Load Address: 
> >Entry Point:  
> >Verifying Checksum ... OK
> >Uncompressing Kernel Image ... OK
> > ## Current stack ends at 0x0FEA5990 => set upper limit to 0x0080
> > ## cmdline at 0x007FFF00 ... 0x007FFF3A
> > bd address  = 0x0FEA5E80
> > memstart= 0x
> > memsize = 0x1000
> > flashstart  = 0x
> > flashsize   = 0x
> > flashoffset = 0x
> > sramstart   = 0x
> > sramsize= 0x
> > bootflags   = 0x0FEA4C88
> > procfreq=400 MHz
> > plb_busfreq = 20 MHz
> > ethaddr = 00:0A:35:01:02:03
> > IP addr = 172.16.40.227
> > baudrate=   9600 bps
> > Not skipping initrd
> > ## Loading RAMDisk Image at 0180 ...
> >Image Name:
> >Image Type:   PowerPC Linux RAMDisk Image (gzip compressed)
> >Data Size:1507104 Bytes =  1.4 MB
> >Load Address: 
> >Entry Point:  
> >Verifying Checksum ... OK
> >Booting using the fdt at 0x100
> > ## initrd at 0x01800040 ... 0x0196FF5F (len=1507104=0x16FF20)
> >Loading Ramdisk to 0fd35000, end 0fea4f20 ... OK
> > ## device tree at 0x0100 ... 0x01002FFF (len=12288=0x3000)
> >Loading Device Tree to 007fc000, end 007fefff ... OK
> > ## Transferring control to Linux (at address ) ...
> > Using Xilinx Virtex machine description
> > Linux version 2.6.26-rc8 ([EMAIL PROTECTED]) (gcc version 4.0.0
(DENX
> > ELDK 4.1 4.0.0)) #6 PREEMPT Wed Jul 9 12
> > :36:41 PDT 2008
> 
> [snip]
> 

[snip]

> > Sending DHCP requests ., OK
> > IP-Config: Got DHCP answer from 149.199.109.235, my address is
> > 172.16.40.12
> > IP-Config: Complete:
> >  device=eth0, addr=172.16.40.12, mask=255.255.255.0,
> > gw=172.16.40.254,
> >  host=172.16.40.12, domain=xilinx.com public.xilinx.com
> > xlnx.xilinx.com public.xsj.xilinx., nis-domain=xil
> > inx.com,
> >  bootserver=149.199.109.235, rootserver=149.199.109.235,
> > rootpath=/tmp
> 
> I don't *think* this causes problems, but your DHCP server is
providing
> NFS configuration information.  Does that override the ramdisk
> configuration?

I removed ip from the command line and it didn't help any.

> 
> > List of all partitions:
> > No filesystem could mount root, tried:  ext2 cramfs msdos vfat romfs
> > Kernel panic - not syncing: VFS: Unable to mount root fs on
> > unknown-block(1,0)
> > Rebooting in 180 seconds..
> 
> [snip]
> 
> HTH,
> gvb

I added linux,initrd-start= and linux,initrd-end= to my dts
file and the kernel now finds the initrd. 

I found these properties in the code, but it doesn't seem right to need
it, I must be still missing something.

Thanks,
John

This email and any attachments are intended for the sole use of the named 
recipient(s) and contain(s) confidential information that may be proprietary, 
privileged or copyrighted under applicable law. If you are not the intended 
recipient, do not read, copy, or forward this email message or any attachments. 
Delete this email message and any attachments immediately.



-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Re: [U-Boot-Users] [PATCH] Support fot the ML507 Board 1/4

[Ricardo]

And Part  4

On Thu, Jul 10, 2008 at 6:07 PM, Ricardo <[EMAIL PROTECTED]> wrote:
> Part 3
>
> On Thu, Jul 10, 2008 at 6:07 PM, Ricardo <[EMAIL PROTECTED]> wrote:
>> Part 2
>>
>> On Thu, Jul 10, 2008 at 6:06 PM, Ricardo <[EMAIL PROTECTED]> wrote:
>>> Hi List:
>>>
>>>  This is my first contribution to u-boot. I have ported u-boot to the
>>> ML507 Board by Xilinx.
>>> http://www.xilinx.com/products/devkits/HW-V5-ML507-UNI-G.htm
>>>
>>> This boards includes an FPGA Virtex 5 FX with an embedded PowerPC 440.
>>>
>>> The port supports:
>>>-Virtex 5 ppc440x5
>>>-XIlinx Interrupt Controller
>>>-Xilinx I2C Controller (Interrupted mode)
>>>-Xilinx Uart Lite (simple port)
>>>-Xilinx LL_TEMA (Interrupted and SGDMA)
>>>-Save environment on board eeprom
>>>-DTT support for the ADT sensor on board (new hwmon driver)
>>>-Dummy I2C driver (for testing purposes)
>>>
>>> This patch works against the last commit to the p4xx branch.
>>>
>>> I am a researcher of the Universidad Autonoma de Madrid, and this work
>>> has been supported by Q-Technology ( http://qtec.com ) under a
>>> Research Agreement.
>>>
>>> Any comment will be very welcomed.
>>>
>>> PS: I have divided the patch in four parts for the mailing list
>>> --
>>> Ricardo Ribalda
>>> http://www.eps.uam.es/~rribalda/
>>>
>>
>>
>>
>> --
>> Ricardo Ribalda
>> http://www.eps.uam.es/~rribalda/
>>
>
>
>
> --
> Ricardo Ribalda
> http://www.eps.uam.es/~rribalda/
>



-- 
Ricardo Ribalda
http://www.eps.uam.es/~rribalda/


ml507_4_of_4.diff.bz2
Description: BZip2 compressed data
-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Re: [U-Boot-Users] [PATCH] Support fot the ML507 Board 1/4

[Ricardo]

Part 3

On Thu, Jul 10, 2008 at 6:07 PM, Ricardo <[EMAIL PROTECTED]> wrote:
> Part 2
>
> On Thu, Jul 10, 2008 at 6:06 PM, Ricardo <[EMAIL PROTECTED]> wrote:
>> Hi List:
>>
>>  This is my first contribution to u-boot. I have ported u-boot to the
>> ML507 Board by Xilinx.
>> http://www.xilinx.com/products/devkits/HW-V5-ML507-UNI-G.htm
>>
>> This boards includes an FPGA Virtex 5 FX with an embedded PowerPC 440.
>>
>> The port supports:
>>-Virtex 5 ppc440x5
>>-XIlinx Interrupt Controller
>>-Xilinx I2C Controller (Interrupted mode)
>>-Xilinx Uart Lite (simple port)
>>-Xilinx LL_TEMA (Interrupted and SGDMA)
>>-Save environment on board eeprom
>>-DTT support for the ADT sensor on board (new hwmon driver)
>>-Dummy I2C driver (for testing purposes)
>>
>> This patch works against the last commit to the p4xx branch.
>>
>> I am a researcher of the Universidad Autonoma de Madrid, and this work
>> has been supported by Q-Technology ( http://qtec.com ) under a
>> Research Agreement.
>>
>> Any comment will be very welcomed.
>>
>> PS: I have divided the patch in four parts for the mailing list
>> --
>> Ricardo Ribalda
>> http://www.eps.uam.es/~rribalda/
>>
>
>
>
> --
> Ricardo Ribalda
> http://www.eps.uam.es/~rribalda/
>



-- 
Ricardo Ribalda
http://www.eps.uam.es/~rribalda/


ml507_3_of_4.diff.bz2
Description: BZip2 compressed data
-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Re: [U-Boot-Users] [PATCH] Support fot the ML507 Board 1/4

[Ricardo]

Part 2

On Thu, Jul 10, 2008 at 6:06 PM, Ricardo <[EMAIL PROTECTED]> wrote:
> Hi List:
>
>  This is my first contribution to u-boot. I have ported u-boot to the
> ML507 Board by Xilinx.
> http://www.xilinx.com/products/devkits/HW-V5-ML507-UNI-G.htm
>
> This boards includes an FPGA Virtex 5 FX with an embedded PowerPC 440.
>
> The port supports:
>-Virtex 5 ppc440x5
>-XIlinx Interrupt Controller
>-Xilinx I2C Controller (Interrupted mode)
>-Xilinx Uart Lite (simple port)
>-Xilinx LL_TEMA (Interrupted and SGDMA)
>-Save environment on board eeprom
>-DTT support for the ADT sensor on board (new hwmon driver)
>-Dummy I2C driver (for testing purposes)
>
> This patch works against the last commit to the p4xx branch.
>
> I am a researcher of the Universidad Autonoma de Madrid, and this work
> has been supported by Q-Technology ( http://qtec.com ) under a
> Research Agreement.
>
> Any comment will be very welcomed.
>
> PS: I have divided the patch in four parts for the mailing list
> --
> Ricardo Ribalda
> http://www.eps.uam.es/~rribalda/
>



-- 
Ricardo Ribalda
http://www.eps.uam.es/~rribalda/


ml507_2_of_4.diff.bz2
Description: BZip2 compressed data
-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

[U-Boot-Users] [PATCH] Support fot the ML507 Board 1/4

[Ricardo]

Hi List:

 This is my first contribution to u-boot. I have ported u-boot to the
ML507 Board by Xilinx.
http://www.xilinx.com/products/devkits/HW-V5-ML507-UNI-G.htm

This boards includes an FPGA Virtex 5 FX with an embedded PowerPC 440.

The port supports:
-Virtex 5 ppc440x5
-XIlinx Interrupt Controller
-Xilinx I2C Controller (Interrupted mode)
-Xilinx Uart Lite (simple port)
-Xilinx LL_TEMA (Interrupted and SGDMA)
-Save environment on board eeprom
-DTT support for the ADT sensor on board (new hwmon driver)
-Dummy I2C driver (for testing purposes)

This patch works against the last commit to the p4xx branch.

I am a researcher of the Universidad Autonoma de Madrid, and this work
has been supported by Q-Technology ( http://qtec.com ) under a
Research Agreement.

Any comment will be very welcomed.

PS: I have divided the patch in four parts for the mailing list
-- 
Ricardo Ribalda
http://www.eps.uam.es/~rribalda/


ml507_1_of_4.diff.bz2
Description: BZip2 compressed data
-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Re: [U-Boot-Users] [PATCH 1/4][RFC] Add initial high speed support to USB code.

[Tor Krill]

On 7/10/2008, "Markus Klotzbücher" <[EMAIL PROTECTED]> wrote:

>Hi Tor,

Hi Markus,

>Tor Krill <[EMAIL PROTECTED]> writes:
>
>> Add high speed support to USB code. Extracted from Juniper Networks patch.
>>
>> I know that the mergewindow is closed but wanted to get feedback on these
>> patches if possible.
>
>Thanks again for fixing this up. AFAIK patches look fine, only two
> things:
>
>- please address the issues pointed out by Michael, especially removal
>  of the "C" macro.
>
>- Secondly it would be nice if we could have a short README.ehci or
>  similar which explains what works and what not, and what needs to be
>  done to add further board/HC support.
>
>Thank you in advance.

Thank you for reviewing. I will try fix things up and resubmit later.

Best Regards,

/Tor

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Re: [U-Boot-Users] [PATCH 1/4][RFC] Add initial high speed support to USB code.

[Markus Klotzbücher]

Hi Tor,

Tor Krill <[EMAIL PROTECTED]> writes:

> Add high speed support to USB code. Extracted from Juniper Networks patch.
>
> I know that the mergewindow is closed but wanted to get feedback on these
> patches if possible.

Thanks again for fixing this up. AFAIK patches look fine, only two
 things:

- please address the issues pointed out by Michael, especially removal
  of the "C" macro.

- Secondly it would be nice if we could have a short README.ehci or
  similar which explains what works and what not, and what needs to be
  done to add further board/HC support.

Thank you in advance.

Best regards

Markus Klotzbücher

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: [EMAIL PROTECTED]

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

[U-Boot-Users] [PATCH] ARM: Fix for broken compilation when defining CONFIG_CMD_ELF

[Hugo Villeneuve]

ARM: Fix for broken compilation when defining
CONFIG_CMD_ELF caused by missing dcache
status/enable/disable functions.

Signed-off-by: Hugo Villeneuve <[EMAIL PROTECTED]>

---

 cpu/arm926ejs/cpu.c  |   51 +-
 include/configs/davinci_sffsdr.h |1 +
 2 files changed, 40 insertions(+), 12 deletions(-)

diff --git a/cpu/arm926ejs/cpu.c b/cpu/arm926ejs/cpu.c
index 722732e..56c6289 100644
--- a/cpu/arm926ejs/cpu.c
+++ b/cpu/arm926ejs/cpu.c
@@ -134,25 +134,52 @@ int do_reset (cmd_tbl_t *cmdtp, int flag, int argc, char 
*argv[])
return (0);
 }
 
-void icache_enable (void)
+/* cache_bit must be either C1_IC or C1_DC */
+static void cache_enable(uint32_t cache_bit)
 {
-   ulong reg;
+   uint32_t reg;
 
-   reg = read_p15_c1 ();   /* get control reg. */
-   cp_delay ();
-   write_p15_c1 (reg | C1_IC);
+   reg = read_p15_c1();/* get control reg. */
+   cp_delay();
+   write_p15_c1(reg | cache_bit);
 }
 
-void icache_disable (void)
+/* cache_bit must be either C1_IC or C1_DC */
+static void cache_disable(uint32_t cache_bit)
 {
-   ulong reg;
+   uint32_t reg;
 
-   reg = read_p15_c1 ();
-   cp_delay ();
-   write_p15_c1 (reg & ~C1_IC);
+   reg = read_p15_c1();
+   cp_delay();
+   write_p15_c1(reg & ~cache_bit);
 }
 
-int icache_status (void)
+void icache_enable(void)
 {
-   return (read_p15_c1 () & C1_IC) != 0;
+   cache_enable(C1_IC);
+}
+
+void icache_disable(void)
+{
+   cache_disable(C1_IC);
+}
+
+int icache_status(void)
+{
+   return (read_p15_c1() & C1_IC) != 0;
+}
+
+void dcache_enable(void)
+{
+   cache_enable(C1_DC);
+}
+
+void dcache_disable(void)
+{
+   cache_disable(C1_DC);
+}
+
+int dcache_status(void)
+{
+   return (read_p15_c1() & C1_DC) != 0;
 }
diff --git a/include/configs/davinci_sffsdr.h b/include/configs/davinci_sffsdr.h
index 0e49e6c..7c860e5 100644
--- a/include/configs/davinci_sffsdr.h
+++ b/include/configs/davinci_sffsdr.h
@@ -137,6 +137,7 @@
 #define CONFIG_CMD_SAVES
 #define CONFIG_CMD_NAND
 #define CONFIG_CMD_EEPROM
+#define CONFIG_CMD_ELF /* Needed to load Integrity kernel. */
 #undef CONFIG_CMD_BDI
 #undef CONFIG_CMD_FPGA
 #undef CONFIG_CMD_SETGETDCR

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

[U-Boot-Users] Undelivered Mail Returned to Sender

[Mail Delivery System]

This is the mail system at host efw-budpar.budpar.go.id.

I'm sorry to have to inform you that your message could not
be delivered to one or more recipients. It's attached below.

For further assistance, please send mail to 

If you do so, please include this problem report. You can
delete your own text from the attached returned message.

   The mail system

<[EMAIL PROTECTED]>: host mx1.mail.sg1.yahoo.com[124.108.116.72] said: 554
delivery error: dd This user doesn't have a yahoo.co.id account
([EMAIL PROTECTED]) [-5] - mta131.mail.sg1.yahoo.com (in reply to end of 
DATA
command)
Reporting-MTA: dns; efw-budpar.budpar.go.id
X-Postfix-Queue-ID: E8FA4359B8C
X-Postfix-Sender: rfc822; u-boot-users@lists.sourceforge.net
Arrival-Date: Thu, 10 Jul 2008 15:56:31 +0700 (WIT)

Final-Recipient: rfc822; leo@yahoo.co.id
Original-Recipient: rfc822;leo@yahoo.co.id
Action: failed
Status: 5.0.0
Remote-MTA: dns; mx1.mail.sg1.yahoo.com
Diagnostic-Code: smtp; 554 delivery error: dd This user doesn't have a
	yahoo.co.id account (leo@yahoo.co.id) [-5] - mta131.mail.sg1.yahoo.com
Received: from localhost (localhost [127.0.0.1])
	by efw-budpar.budpar.go.id (Postfix) with ESMTP id E8FA4359B8C
	for <[EMAIL PROTECTED]>; Thu, 10 Jul 2008 15:56:31 +0700 (WIT)
X-Virus-Scanned: by Endian Firewall
Received: from lists.sourceforge.net (unknown [172.17.100.133])
	by efw-budpar.budpar.go.id (Postfix) with ESMTP id 3D77144EA49
	for <[EMAIL PROTECTED]>; Thu, 10 Jul 2008 13:11:40 +0700 (WIT)
From: u-boot-users@lists.sourceforge.net
To: [EMAIL PROTECTED]
Subject: Error
Date: Thu, 10 Jul 2008 13:11:39 +0700
MIME-Version: 1.0
Content-Type: multipart/mixed;
	boundary="=_NextPart_000_0003_AC4EC6B6.B4DEDD6E"
X-Priority: 3
X-MSMail-Priority: Normal
Message-Id: <[EMAIL PROTECTED]>
-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Re: [U-Boot-Users] Tftp command !!

[Jerry Van Baren]

Dear Amit,

Preliminary comment: Wolfgang is lashing out at stupid disclaimers, 
don't take it personally.  We all realize you didn't write the stupid 
disclaimer and cannot remove it.

Amit Kumar wrote:
> Dear Wolfgang,
> 
> Kindly read disclaimer properly or show to your lawyer.
> 
> "This e-mail contains PRIVILEGED AND CONFIDENTIAL INFORMATION
> intended solely for the use of the addressee(s)."

No it doesn't.  Your email was neither PRIVILEGED nor CONFIDENTIAL.

In the USofA, the term "privileged" as used in this context is a 
specific type of communications with a lawyer who is in a formal, legal 
way your (or your company's) representative.  This email clearly falls 
outside of that category.

Email is *never* CONFIDENTIAL if it is sent unencrypted on an 
unprotected network.  If it is encrypted and/or on a network internal to 
your company or over a secured VPN, you may have a reasonable 
expectation that the email is confidential within the bounds of your 
company and/or the limitations of the encryption.  This email clearly 
falls outside of that category.

Further, this email list is known to be archived by several servers 
(e.g. sourceforge, gmane, nabble) which are then indexed and cached by 
several search engines (e.g. google, yahoo, microsoft), not to mention 
snapshotted by archivers (e.g. the wayback engine).  Anyone now and in 
the future that has internet access can read it.  Obviously the list of 
addressees does not include everyone in the present and definitely not 
everyone in the future.

> You are not understanding the disclaimer at all. I am highly
> surprised. If your lawyer says that you are correct then as mentioned
> by you earlier you can report to management of my company.

If your company's legal disclaimer was actually written by a lawyer, and 
I strongly suspect it was not, that lawyer is either totally ignorant of 
the inherent characteristics of email or totally incompetent.  If the 
former, he should be educated on the inherent characteristics of email 
(see the analogy below).  If the latter, your company should replace him.

Rather than putting stupid useless disclaimers on non-PRIVILEGED, 
non-CONFIDENTIAL emails, a competent lawyer would/should give competent 
legal advice like DON'T EVER SEND PRIVILEGED OR CONFIDENTIAL INFORMATION 
over a service that has no expectations of privacy or confidentiality 
and "go medieval" on anybody that disregarded that advice.

As an analogy, sending PRIVILEGED AND CONFIDENTIAL information over 
email is *worse* than sending PRIVILEGED AND CONFIDENTIAL information 
written on a postcard and mailed out.  For a postcard, anybody between 
your outbox and the recipient's inbox can read the postcard, *most* of 
them *legally.*  This includes all of the mail handlers in your company, 
all of the mail handlers in the route from your company to the 
destination company (including any government security services, 
especially if it crosses a border) and potentially industrial spies (OK, 
*they* might be reading the postcard illegally, but legalities never 
stop a good spy).

> You are preventing people like us from sharing information on this
> esteemed mailing list for which I think you are the moderator.

Relax.  The information is still being shared.

> Regards,
> Amit

HTH,
gvb

> -Original Message-
> From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]
> Sent: Thursday, July 10, 2008 4:37 PM
> To: Amit Kumar
> Cc: u-boot-users@lists.sourceforge.net
> Subject: Re: [U-Boot-Users] Tftp command !!
> 
> In message <[EMAIL PROTECTED]> you wrote:
>>> If you had to make changes, this means that you are not running on the
>> very same hardware as trhe board configuration was made for.
> 
> I don't really believe that.
> 
>> [Amit]: If you look at my so called "changes" they don't make any 
>> difference. For example #defining one FLAG does not mean that there is 
>> change. README clearly mentions that if one wants particular piece of code 
>> to be enabled then #define it. Secondly,
>> there is increase in number of sectors.
> 
> But on the " hardware as trhe board configuration was made for", the
> number ofd sectors is OK. Which means you must have somewhat different
> hardware.
> 
> But if you don't believe me I can't help it. Feel free to find your
> own way.
> 
>> [Amit]: As per the disclaimer "If you are not the intended recipient and you 
>> copy, disclose, or distribute this e-mail or its contents to any other 
>> person" then such actions are unlawful. In this case, intended recipient is 
>> [EMAIL PROTECTED]
> 
>> e.net ... so I think there should not be any problem.
> 
> A mailing-list is not a person in the legal sense. Ask you lawyer. You
> are in trouble.
> 
> 
> Best regards,
> 
> Wolfgang Denk
> 
> --
> DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED]
> 

[U-Boot-Users] [PATCH] 83xx: mpc8315erdb: fix silly thinko in fdt_tsec1_fixup

[Anton Vorontsov]

The thinko was quite silly indeed, I messed with !ptr. Normally this
would trigger some fault, but in U-Boot NULL pointer is equal to phys
0, so the code was working still, just didn't actually test mpc8315erdb
environment variable value. Heh.

Signed-off-by: Anton Vorontsov <[EMAIL PROTECTED]>
---

Kim, sorry for this inconvenience.

 board/freescale/mpc8315erdb/mpc8315erdb.c |   19 ++-
 1 files changed, 10 insertions(+), 9 deletions(-)

diff --git a/board/freescale/mpc8315erdb/mpc8315erdb.c 
b/board/freescale/mpc8315erdb/mpc8315erdb.c
index 7555ffb..3eecee2 100644
--- a/board/freescale/mpc8315erdb/mpc8315erdb.c
+++ b/board/freescale/mpc8315erdb/mpc8315erdb.c
@@ -128,15 +128,16 @@ void fdt_tsec1_fixup(void *fdt, bd_t *bd)
const char *path;
int ret;
 
-   if (!mpc8315erdb) {
-   if (!strcmp(mpc8315erdb, "tsec1")) {
-   return;
-   } else if (strcmp(mpc8315erdb, "ulpi")) {
-   printf("WARNING: wrong `mpc8315erdb' environment "
-  "variable specified: `%s'. Should be `ulpi' "
-  "or `tsec1'.\n", mpc8315erdb);
-   return;
-   }
+   if (!mpc8315erdb)
+   return;
+
+   if (!strcmp(mpc8315erdb, "tsec1")) {
+   return;
+   } else if (strcmp(mpc8315erdb, "ulpi")) {
+   printf("WARNING: wrong `mpc8315erdb' environment "
+  "variable specified: `%s'. Should be `ulpi' "
+  "or `tsec1'.\n", mpc8315erdb);
+   return;
}
 
ret = fdt_path_offset(fdt, "/aliases");
-- 
1.5.5.4

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Re: [U-Boot-Users] [PATCH] USB: shutdown USB before booting

[Stefan Roese]

Hi Markus,

On Thursday 10 July 2008, Markus Klotzbücher wrote:
> This patch fixes a potentially serious issue related to USB which was
> discouvered by Martin Krause <[EMAIL PROTECTED]> and fixed for
> ARM920T. Martin wrote:
>
>   Turn off USB to prevent the host controller from writing to the
>   SDRAM while Linux is booting. This could happen, because the HCCA
>   (Host Controller Communication Area) lies within the SDRAM and the
>   host controller writes continously to this area (as busmaster!), for
>   example to increase the HccaFrameNumber variable, which happens
>   every 1 ms.
>
> This is a slightly modified version of the patch in order to shutdown
> USB when booting on all architectures.

Yes, I remember hearing of this problem. I thought it was already fixed. Seems 
not to be the case. Please find a comment below.

> Signed-off-by: Markus Klotzbuecher <[EMAIL PROTECTED]>
> ---
>  common/cmd_bootm.c |   18 ++
>  1 files changed, 18 insertions(+), 0 deletions(-)
>
> diff --git a/common/cmd_bootm.c b/common/cmd_bootm.c

By implementing this usb_stop() in do_bootm() you prevent this problem in many 
cases (e.g. Linux booting). But unfortunately not in all cases. For 
example "bootelf" or "bootvx" are not fixed.

Can't this be solved in a different way. By calling usb_stop each time after 
an USB command completes. IIRC, this is how it is done in the U-Boot network 
implementation too.

What do you think?

Best regards,
Stefan

=
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: [EMAIL PROTECTED]
=

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Re: [U-Boot-Users] [PATCH 0/1] Moved initialization of AVR32 Ethernet controllers to board_eth_init()

[Hans-Christian Egtvedt]

On Thu, 2008-07-10 at 14:47 +0200, Hans-Christian Egtvedt wrote:
> On Thu, 2008-07-10 at 14:45 +0200, Hans-Christian Egtvedt wrote:
> > On Thu, 2008-07-10 at 13:24 +0200, Haavard Skinnemoen wrote:



> > > Looks good to me, but I don't have the chance to test it.
> > > 
> > 
> > I tried looking into it, but I do not see who is going to call
> > board_eth_init() ? Is this supposed to be done in net/eth.c or
> > lib_avr32/board.c ?
> > 
> 
> Cheese, I am blind, just found it almost on top in the eth_initialize()
> function.
> 
> I will pull the master and see if it works.
> 

And it works, proof below (-: (Net: did not work before pulling master)

U-Boot 1.3.3-00248-gae9bc0c-dirty (Jul 10 2008 - 14:50:32) 

U-Boot code:  -> f6b8  data: 000155c0 -> 0004bd18
malloc: Using memory from 0x10f74000 to 0x10fb4000
DMA: Using memory from 0x10f7 to 0x10f74000
Flash:  8 MB at address 0x
DRAM Configuration:
Bank #0: 1000 16 MB
In:serial
Out:   serial
Err:   serial
Net:   macb0
Press SPACE to abort autoboot in 1 seconds
macb0: link up, 100Mbps full-duplex (lpa: 0x45e1)
BOOTP broadcast 1
DHCP client bound to address 10.191.252.36
Using macb0 device
TFTP from server 10.191.252.83; our IP address is 10.191.252.36
Filename 'uimage_br_stk'.
Load address: 0x1040
Loading: T #
 ###
done
Bytes transferred = 788 (10f6ec hex)
## Booting kernel from Legacy Image at 1040 ...
   Image Name:   Linux-2.6.25.10.atmel.2
   Image Type:   AVR32 Linux Kernel Image (gzip compressed)
   Data Size:724 Bytes =  1.1 MB
   Load Address: 1000
   Entry Point:  9000
   Verifying Checksum ... OK
   Uncompressing Kernel Image ... OK

Starting kernel at 9000 (params at 10f74008)...

Linux version 2.6.25.10.atmel.2 ([EMAIL PROTECTED]) (gcc version 
4.2.2-atmel.1.0.8) #68 Thu Jul 10 13:16:42 CEST 2008

-- 
With kind regards,
Hans-Christian Egtvedt, Applications Engineer


-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Re: [U-Boot-Users] [PATCH 0/1] Moved initialization of AVR32 Ethernet controllers to board_eth_init()

[Hans-Christian Egtvedt]

On Thu, 2008-07-10 at 14:45 +0200, Hans-Christian Egtvedt wrote:
> On Thu, 2008-07-10 at 13:24 +0200, Haavard Skinnemoen wrote:
> > On Sat,  5 Jul 2008 00:08:47 -0700
> > Ben Warren <[EMAIL PROTECTED]> wrote:
> > 
> > > More cleanup of net/eth.c, this time taking care of AVR32 boards.  I got 
> > > rid
> > > of the board/eth.c files because board_eth_init() needs to be in a file 
> > > where
> > > there are other strong symbols in order to override the weak 
> > > board_eth_init() in
> > > net/eth.c.  I've compiled this code  and verified that the strong
> > > board_eth_init() symbols are linked in, but don't have hardware to test 
> > > on.
> > > If somebody can, please try out and let me know.
> > 
> > Looks good to me, but I don't have the chance to test it.
> > 
> 
> I tried looking into it, but I do not see who is going to call
> board_eth_init() ? Is this supposed to be done in net/eth.c or
> lib_avr32/board.c ?
> 

Cheese, I am blind, just found it almost on top in the eth_initialize()
function.

I will pull the master and see if it works.



-- 
With kind regards,
Hans-Christian Egtvedt, Applications Engineer


-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Re: [U-Boot-Users] [PATCH 0/1] Moved initialization of AVR32 Ethernet controllers to board_eth_init()

[Hans-Christian Egtvedt]

On Thu, 2008-07-10 at 13:24 +0200, Haavard Skinnemoen wrote:
> On Sat,  5 Jul 2008 00:08:47 -0700
> Ben Warren <[EMAIL PROTECTED]> wrote:
> 
> > More cleanup of net/eth.c, this time taking care of AVR32 boards.  I got rid
> > of the board/eth.c files because board_eth_init() needs to be in a file 
> > where
> > there are other strong symbols in order to override the weak 
> > board_eth_init() in
> > net/eth.c.  I've compiled this code  and verified that the strong
> > board_eth_init() symbols are linked in, but don't have hardware to test on.
> > If somebody can, please try out and let me know.
> 
> Looks good to me, but I don't have the chance to test it.
> 

I tried looking into it, but I do not see who is going to call
board_eth_init() ? Is this supposed to be done in net/eth.c or
lib_avr32/board.c ?

> > These patches are being staged in the 'testing' branch of the net repo.
> 
> Maybe someone else could give it a try?
> 

I tried it (just reworked a bit to my board from EarthLCD) and it does
not detect the PHY. I am working on master from the AVR32 branch in GIT.

PS! I am not on u-boot-users, and is there a archive which is faster to
scroll than the one on sf.net?

-- 
With kind regards,
Hans-Christian Egtvedt, Applications Engineer


-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

[U-Boot-Users] [PATCH] USB: shutdown USB before booting

[Markus Klotzbücher]

This patch fixes a potentially serious issue related to USB which was
discouvered by Martin Krause <[EMAIL PROTECTED]> and fixed for
ARM920T. Martin wrote:

  Turn off USB to prevent the host controller from writing to the
  SDRAM while Linux is booting. This could happen, because the HCCA
  (Host Controller Communication Area) lies within the SDRAM and the
  host controller writes continously to this area (as busmaster!), for
  example to increase the HccaFrameNumber variable, which happens
  every 1 ms.

This is a slightly modified version of the patch in order to shutdown
USB when booting on all architectures.

Signed-off-by: Markus Klotzbuecher <[EMAIL PROTECTED]>
---
 common/cmd_bootm.c |   18 ++
 1 files changed, 18 insertions(+), 0 deletions(-)

diff --git a/common/cmd_bootm.c b/common/cmd_bootm.c
index 959689e..f914815 100644
--- a/common/cmd_bootm.c
+++ b/common/cmd_bootm.c
@@ -36,6 +36,10 @@
 #include 
 #include 
 
+#if (CONFIG_COMMANDS & CFG_CMD_USB)
+#include 
+#endif
+
 #ifdef CFG_HUSH_PARSER
 #include 
 #endif
@@ -213,6 +217,20 @@ int do_bootm (cmd_tbl_t *cmdtp, int flag, int argc, char 
*argv[])
 */
iflag = disable_interrupts();
 
+#if (CONFIG_COMMANDS & CFG_CMD_USB)
+   /*
+* turn off USB to prevent the host controller from writing to the
+* SDRAM while Linux is booting. This could happen (at least for OHCI
+* controller), because the HCCA (Host Controller Communication Area)
+* lies within the SDRAM and the host controller writes continously to
+* this area (as busmaster!). The HccaFrameNumber is for example
+* updated every 1 ms within the HCCA structure in SDRAM! For more
+* details see the OpenHCI specification.
+*/
+   usb_stop();
+#endif
+
+
 #ifdef CONFIG_AMIGAONEG3SE
/*
 * We've possible left the caches enabled during
-- 
1.5.5.1


Best regards

Markus Klotzbuecher

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: [EMAIL PROTECTED]

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Re: [U-Boot-Users] [PATCH] usb: add support for R8A66597 usb controller

[Yoshihiro Shimoda]

2008/07/10 20:01, Wolfgang Denk wrote:
> In message <[EMAIL PROTECTED]> you wrote:
>>> is it not possible to have a better name for the struct and the var
>>> and btw for the function naming?
>> Because XTAL, LDRV, DEVADD are a register name or register bit name,
>> I think that it is a good name...
>> But I will change a name of the "struct r8a66957 gr8a66597" to
>> "struct r8a66597 r8a66597_dev".
> 
> Can you not find some simpler name that "r8a66597"? That's a mess to
> type and to read.

Thank you for your comment.

I can change that "struct r8a66597" for a simple name. For example,
its name is "struct r597". However, I do not want to change a source
file name and CONFIG_ name, because "R8A66597" is product name.

Best Regards,
Yoshihiro Shimoda


-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

[U-Boot-Users] [PATCH] mpc85xx: fix upmconfig

[Sebastian Siewior]

This actually shouldn't work. Imagina 0xf000 base address that
gets translated into 0x1e000 and causes my box to hang. Writing
to 0xf000 seems the better way.
Also don't compare against the UPM mask but agaist the MSEL mask.

Cc: Sergei Poselenov <[EMAIL PROTECTED]>
Cc: Andy Fleming <[EMAIL PROTECTED]>
Signed-off-by: Sebastian Siewior <[EMAIL PROTECTED]>
---
 cpu/mpc85xx/cpu.c |7 +++
 1 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/cpu/mpc85xx/cpu.c b/cpu/mpc85xx/cpu.c
index 0497422..2373b4a 100644
--- a/cpu/mpc85xx/cpu.c
+++ b/cpu/mpc85xx/cpu.c
@@ -71,8 +71,7 @@ struct cpu_type *identify_cpu(u32 ver)
 
 static void set_lcb_clock(uint clkdiv)
 {
-   volatile immap_t *immap = (immap_t *)CFG_IMMR;
-   volatile ccsr_lbc_t *lbc= &immap->im_lbc;
+   volatile ccsr_lbc_t *lbc = (void *)(CFG_MPC85xx_LBC_ADDR);
uint lcrr;
 
lcrr = lbc->lcrr;
@@ -352,8 +351,8 @@ void upmconfig (uint upm, uint * table, uint size)
 i++, brp += 2, orp += 2) {
 
/* Look for a valid BR with selected UPM */
-   if ((in_be32(brp) & (BR_V | upmmask)) == (BR_V | upmmask)) {
-   dummy = (volatile u8*)(in_be32(brp) >> BR_BA_SHIFT);
+   if ((in_be32(brp) & (BR_V | BR_MSEL)) == (BR_V | upmmask)) {
+   dummy = (volatile u8*)(in_be32(brp) & BR_BA);
break;
}
}
-- 
1.5.5.2


-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

[U-Boot-Users] [PATCH] cfi_flash: fix flash on Big Endian machines.

[Sebastian Siewior]

This got broken by commits 93c56f212c
 [cfi_flash: support of long cmd in U-boot.]

That command seems to be access in a little endian way so
wrappers are required.
Long is the wrong type because it will behave differently on
64bit machnines in a way that is probably not expected.
int should be enough.

Cc: Alexey Korolev <[EMAIL PROTECTED]>
Cc: Vasiliy Leonenko <[EMAIL PROTECTED]>
Signed-off-by: Sebastian Siewior <[EMAIL PROTECTED]>
---
 drivers/mtd/cfi_flash.c |   14 --
 1 files changed, 8 insertions(+), 6 deletions(-)

diff --git a/drivers/mtd/cfi_flash.c b/drivers/mtd/cfi_flash.c
index c0ea97b..6770496 100644
--- a/drivers/mtd/cfi_flash.c
+++ b/drivers/mtd/cfi_flash.c
@@ -301,24 +301,26 @@ static inline void flash_unmap(flash_info_t *info, 
flash_sect_t sect,
 /*---
  * make a proper sized command based on the port and chip widths
  */
-static void flash_make_cmd (flash_info_t * info, ulong cmd, void *cmdbuf)
+static void flash_make_cmd (flash_info_t * info, uint cmd, void *cmdbuf)
 {
int i;
int cword_offset;
int cp_offset;
+   int cmd_le;
uchar val;
uchar *cp = (uchar *) cmdbuf;
 
+   cmd_le = cpu_to_le32(cmd);
for (i = info->portwidth; i > 0; i--){
cword_offset = (info->portwidth-i)%info->chipwidth;
 #if defined(__LITTLE_ENDIAN) || defined(CFG_WRITE_SWAPPED_DATA)
cp_offset = info->portwidth - i;
-   val = *((uchar*)&cmd + cword_offset);
+   val = *((uchar*)&cmd_le + cword_offset);
 #else
cp_offset = i - 1;
-   val = *((uchar*)&cmd + sizeof(ulong) - cword_offset - 1);
+   val = *((uchar*)&cmd_le + sizeof(uint) - cword_offset - 1);
 #endif
-   cp[cp_offset] = (cword_offset >= sizeof(ulong)) ? 0x00 : val;
+   cp[cp_offset] = (cword_offset >= sizeof(uint)) ? 0x00 : val;
}
 }
 
@@ -329,7 +331,7 @@ static void flash_make_cmd (flash_info_t * info, ulong cmd, 
void *cmdbuf)
 static void print_longlong (char *str, unsigned long long data)
 {
int i;
-   char *cp;
+   unsigned char *cp;
 
cp = (unsigned char *) &data;
for (i = 0; i < 8; i++)
@@ -433,7 +435,7 @@ static ulong flash_read_long (flash_info_t * info, 
flash_sect_t sect,
  * Write a proper sized command to the correct address
  */
 static void flash_write_cmd (flash_info_t * info, flash_sect_t sect,
-uint offset, ulong cmd)
+uint offset, uint cmd)
 {
 
void *addr;
-- 
1.5.5.2


-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Re: [U-Boot-Users] Tftp command !!

[Amit Kumar]

Dear Wolfgang,

Kindly read disclaimer properly or show to your lawyer.

"This e-mail contains PRIVILEGED AND CONFIDENTIAL INFORMATION intended solely 
for the use of the addressee(s)."

You are not understanding the disclaimer at all. I am highly surprised. If your 
lawyer says that you are correct then as mentioned by you earlier you can 
report to management of my company.

You are preventing people like us from sharing information on this esteemed 
mailing list for which I think you are the moderator.

Regards,
Amit

-Original Message-
From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]
Sent: Thursday, July 10, 2008 4:37 PM
To: Amit Kumar
Cc: u-boot-users@lists.sourceforge.net
Subject: Re: [U-Boot-Users] Tftp command !!

In message <[EMAIL PROTECTED]> you wrote:
>
> > If you had to make changes, this means that you are not running on the
> very same hardware as trhe board configuration was made for.

I don't really believe that.

> [Amit]: If you look at my so called "changes" they don't make any difference. 
> For example #defining one FLAG does not mean that there is change. README 
> clearly mentions that if one wants particular piece of code to be enabled 
> then #define it. Secondly,
> there is increase in number of sectors.

But on the " hardware as trhe board configuration was made for", the
number ofd sectors is OK. Which means you must have somewhat different
hardware.

But if you don't believe me I can't help it. Feel free to find your
own way.

> [Amit]: As per the disclaimer "If you are not the intended recipient and you 
> copy, disclose, or distribute this e-mail or its contents to any other 
> person" then such actions are unlawful. In this case, intended recipient is 
> [EMAIL PROTECTED]

> e.net ... so I think there should not be any problem.

A mailing-list is not a person in the legal sense. Ask you lawyer. You
are in trouble.


Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED]
When a man sits with a pretty girl for  an  hour,  it  seems  like  a
minute.  But let him sit on a hot stove for a minute -- and it's lon-
ger than any hour. That's relativity.  -- Albert Einstein

 CAUTION - Disclaimer *
This e-mail contains PRIVILEGED AND CONFIDENTIAL INFORMATION intended solely 
for the use of the addressee(s). If you are not the intended recipient, please 
notify the sender by e-mail and delete the original message. Further, you are 
not 
to copy, disclose, or distribute this e-mail or its contents to any other 
person and 
any such actions are unlawful. This e-mail may contain viruses. Infosys has 
taken 
every reasonable precaution to minimize this risk, but is not liable for any 
damage 
you may sustain as a result of any virus in this e-mail. You should carry out 
your 
own virus checks before opening the e-mail or attachment. Infosys reserves the 
right to monitor and review the content of all messages sent to or from this 
e-mail 
address. Messages sent to or from this e-mail address may be stored on the 
Infosys e-mail system.
***INFOSYS End of Disclaimer INFOSYS***

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Re: [U-Boot-Users] [PATCH v2] Remove [EMAIL PROTECTED] from MAINTAINERS

[Jerry Van Baren]

Wolfgang Denk wrote:
> In message <[EMAIL PROTECTED]> you wrote:
>> Would it be reasonable to add an optional tag "last known maintainer" 
>> for orphaned boards so someone can chase it without pawing through git 
>> history?  E.g.:
> 
> Excellent idea. I like it.
> 
>> +-
>> +
>> +Unknown / orphaned boards:
>> +
>> +Last known maintainer: Kyle Harris <[EMAIL PROTECTED]>
>> +cradle  xscale  
>> +ixdp425 xscale  
>> +lubbock xscale  
> 
> Let's rather have a third column:
> 
>   board   archLKM (if any)
>   cradle  xscale  Kyle Harris <[EMAIL PROTECTED]>
>   ...
> 
> etc.
> 
> 
> Best regards,
> 
> Wolfgang Denk

I'm OK with that too.  I actually did that first, but it linewrapped on 
me so I put the LKM on a separate line.  Ahh, I see you deleted a tab.

+1
gvb


-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Re: [U-Boot-Users] [PATCH v2] Remove [EMAIL PROTECTED] from MAINTAINERS

[Wolfgang Denk]

In message <[EMAIL PROTECTED]> you wrote:
>
> Would it be reasonable to add an optional tag "last known maintainer" 
> for orphaned boards so someone can chase it without pawing through git 
> history?  E.g.:

Excellent idea. I like it.

> +-
> +
> +Unknown / orphaned boards:
> +
> +Last known maintainer: Kyle Harris <[EMAIL PROTECTED]>
> + cradle  xscale  
> + ixdp425 xscale  
> + lubbock xscale  

Let's rather have a third column:

board   archLKM (if any)
cradle  xscale  Kyle Harris <[EMAIL PROTECTED]>
...

etc.


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED]
... The prejudices people feel about each other disappear  when  then
get to know each other.
-- Kirk, "Elaan of Troyius", stardate 4372.5

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Re: [U-Boot-Users] [PATCH v2] Remove [EMAIL PROTECTED] from MAINTAINERS

[Jean-Christophe PLAGNIOL-VILLARD]

On 07:35 Thu 10 Jul , Jerry Van Baren wrote:
> > +
> > +Unknown / orphaned boards:
> > +
> > +   cradle  xscale
> > +   ixdp425 xscale
> > +   lubbock xscale
> > +
> >  #
> >  # x86 Systems: 
> > #
> >  #  #
> 
> Would it be reasonable to add an optional tag "last known maintainer" 
> for orphaned boards so someone can chase it without pawing through git 
> history?  E.g.:
> 
> +-
> +
> +Unknown / orphaned boards:
> +
> +Last known maintainer: Kyle Harris <[EMAIL PROTECTED]>
> + cradle  xscale  
> + ixdp425 xscale  
> + lubbock xscale  
> +
> 
Good idea

Best Regards,
J.

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

[U-Boot-Users] [PATCH] ppc4xx: Remove redundant ft_board_setup() functions from some 4xx boards

[Stefan Roese]

This patch removes some ft_board_setup() functions from some 4xx boards.
This can be done since we now have a default weak implementation for this
in cpu/ppc4xx/fdt.c. Only board in need for a different/custom
implementation like canyonlands need their own version.

Signed-off-by: Stefan Roese <[EMAIL PROTECTED]>
---
 board/amcc/katmai/katmai.c |   21 -
 board/amcc/kilauea/kilauea.c   |   21 -
 board/amcc/makalu/makalu.c |   21 -
 board/amcc/sequoia/sequoia.c   |   21 -
 board/amcc/yosemite/yosemite.c |   21 -
 board/esd/pmc440/pmc440.c  |   21 -
 board/prodrive/alpr/alpr.c |   21 -
 cpu/ppc4xx/fdt.c   |   12 ++--
 8 files changed, 10 insertions(+), 149 deletions(-)

diff --git a/board/amcc/katmai/katmai.c b/board/amcc/katmai/katmai.c
index 3a0b18f..f2bed5c 100644
--- a/board/amcc/katmai/katmai.c
+++ b/board/amcc/katmai/katmai.c
@@ -517,24 +517,3 @@ int post_hotkeys_pressed(void)
return (ctrlc());
 }
 #endif
-
-#if defined(CONFIG_OF_LIBFDT) && defined(CONFIG_OF_BOARD_SETUP)
-void ft_board_setup(void *blob, bd_t *bd)
-{
-   u32 val[4];
-   int rc;
-
-   ft_cpu_setup(blob, bd);
-
-   /* Fixup NOR mapping */
-   val[0] = 0; /* chip select number */
-   val[1] = 0; /* always 0 */
-   val[2] = gd->bd->bi_flashstart;
-   val[3] = gd->bd->bi_flashsize;
-   rc = fdt_find_and_setprop(blob, "/plb/opb/ebc", "ranges",
- val, sizeof(val), 1);
-   if (rc)
-   printf("Unable to update property NOR mapping, err=%s\n",
-  fdt_strerror(rc));
-}
-#endif /* defined(CONFIG_OF_LIBFDT) && defined(CONFIG_OF_BOARD_SETUP) */
diff --git a/board/amcc/kilauea/kilauea.c b/board/amcc/kilauea/kilauea.c
index f30dc8f..7b10255 100644
--- a/board/amcc/kilauea/kilauea.c
+++ b/board/amcc/kilauea/kilauea.c
@@ -374,24 +374,3 @@ int post_hotkeys_pressed(void)
return 0;   /* No hotkeys supported */
 }
 #endif /* CONFIG_POST */
-
-#if defined(CONFIG_OF_LIBFDT) && defined(CONFIG_OF_BOARD_SETUP)
-void ft_board_setup(void *blob, bd_t *bd)
-{
-   u32 val[4];
-   int rc;
-
-   ft_cpu_setup(blob, bd);
-
-   /* Fixup NOR mapping */
-   val[0] = 0; /* chip select number */
-   val[1] = 0; /* always 0 */
-   val[2] = gd->bd->bi_flashstart;
-   val[3] = gd->bd->bi_flashsize;
-   rc = fdt_find_and_setprop(blob, "/plb/opb/ebc", "ranges",
- val, sizeof(val), 1);
-   if (rc)
-   printf("Unable to update property NOR mapping, err=%s\n",
-  fdt_strerror(rc));
-}
-#endif /* defined(CONFIG_OF_LIBFDT) && defined(CONFIG_OF_BOARD_SETUP) */
diff --git a/board/amcc/makalu/makalu.c b/board/amcc/makalu/makalu.c
index 9baec9a..2b4d3d4 100644
--- a/board/amcc/makalu/makalu.c
+++ b/board/amcc/makalu/makalu.c
@@ -330,24 +330,3 @@ int post_hotkeys_pressed(void)
return 0;   /* No hotkeys supported */
 }
 #endif /* CONFIG_POST */
-
-#if defined(CONFIG_OF_LIBFDT) && defined(CONFIG_OF_BOARD_SETUP)
-void ft_board_setup(void *blob, bd_t *bd)
-{
-   u32 val[4];
-   int rc;
-
-   ft_cpu_setup(blob, bd);
-
-   /* Fixup NOR mapping */
-   val[0] = 0; /* chip select number */
-   val[1] = 0; /* always 0 */
-   val[2] = gd->bd->bi_flashstart;
-   val[3] = gd->bd->bi_flashsize;
-   rc = fdt_find_and_setprop(blob, "/plb/opb/ebc", "ranges",
- val, sizeof(val), 1);
-   if (rc)
-   printf("Unable to update property NOR mapping, err=%s\n",
-  fdt_strerror(rc));
-}
-#endif /* defined(CONFIG_OF_LIBFDT) && defined(CONFIG_OF_BOARD_SETUP) */
diff --git a/board/amcc/sequoia/sequoia.c b/board/amcc/sequoia/sequoia.c
index 5ff9787..b833092 100644
--- a/board/amcc/sequoia/sequoia.c
+++ b/board/amcc/sequoia/sequoia.c
@@ -509,24 +509,3 @@ int post_hotkeys_pressed(void)
return 0;   /* No hotkeys supported */
 }
 #endif /* CONFIG_POST */
-
-#if defined(CONFIG_OF_LIBFDT) && defined(CONFIG_OF_BOARD_SETUP)
-void ft_board_setup(void *blob, bd_t *bd)
-{
-   u32 val[4];
-   int rc;
-
-   ft_cpu_setup(blob, bd);
-
-   /* Fixup NOR mapping */
-   val[0] = 0; /* chip select number */
-   val[1] = 0; /* always 0 */
-   val[2] = gd->bd->bi_flashstart;
-   val[3] = gd->bd->bi_flashsize;
-   rc = fdt_find_and_setprop(blob, "/plb/opb/ebc", "ranges",
- val, sizeof(val), 1);
-   if (rc)
-   printf("Unable to update property NOR mapping, err=%s\n",
-  fdt_strerror(rc));
-}
-#endif 

Re: [U-Boot-Users] [PATCH v2] Remove [EMAIL PROTECTED] from MAINTAINERS

[Jerry Van Baren]

Haavard Skinnemoen wrote:
> Mail to [EMAIL PROTECTED] bounces because the user doesn't exist
> anymore. You can't be a maintainer without a valid e-mail address, so
> move all boards that used to be maintained by Kyle Harris to the
> "orphaned" list.
> 
> Currently, only PowerPC has a list of orphaned boards, so this patch
> creates one for ARM as well.
> 
> Signed-off-by: Haavard Skinnemoen <[EMAIL PROTECTED]>
> ---
> On Sun, 06 Jul 2008 00:32:01 +0200 Wolfgang Denk <[EMAIL PROTECTED]> wrote:
>> ... don't jusst delete the orphaned boards, but add them to the
>> "Unknown / orphaned" list.
> 
> I created a new Unknown/orphaned list for ARM since the existing one
> was located in the PowerPC section and only had PowerPC boards on it.
> Is that ok?
> 
>  MAINTAINERS |   14 --
>  1 files changed, 8 insertions(+), 6 deletions(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index a3d70b1..6065e42 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -492,12 +492,6 @@ Kshitij Gupta <[EMAIL PROTECTED]>
>   omap1510inn ARM925T
>   omap1610inn ARM926EJS
>  
> -Kyle Harris <[EMAIL PROTECTED]>
> -
> - lubbock xscale
> - cradle  xscale
> - ixdp425 xscale
> -
>  Gary Jennejohn <[EMAIL PROTECTED]>
>  
>   smdk2400ARM920T
> @@ -591,6 +585,14 @@ Michael Schwingen <[EMAIL PROTECTED]>
>   actux3  xscale
>   actux4  xscale
>  
> +-
> +
> +Unknown / orphaned boards:
> +
> + cradle  xscale
> + ixdp425 xscale
> + lubbock xscale
> +
>  #
>  # x86 Systems:   
> #
>  ##

Would it be reasonable to add an optional tag "last known maintainer" 
for orphaned boards so someone can chase it without pawing through git 
history?  E.g.:

+-
+
+Unknown / orphaned boards:
+
+Last known maintainer: Kyle Harris <[EMAIL PROTECTED]>
+   cradle  xscale  
+   ixdp425 xscale  
+   lubbock xscale  
+

Best regards,
gvb

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Re: [U-Boot-Users] [PATCH] add 'license' command to u-boot?commandline

[Wolfgang Denk]

In message <[EMAIL PROTECTED]> you wrote:
> On Thu, Jul 10, 2008 at 12:51:03PM +0200, Detlev Zundel wrote:
> 
> > Even though I'm an enthusiastic Emacs user, I have different reasons for
> > my vote.  As far as build dependencies go, I'd like to restrict this to
> > the LSB standard[1].  Xdd is not in there, so thats why I vote for the
> > small C program (unless we can adapt the script and use 'od').
> 
> I think sticking to LSB for build dependencies is a very reasonable choice.
> 
> I still don't think the small C program is that much of a problem:
> 
> 1) dependency tracking should ensure it is only built when the license
>feature is enabled by the board-level config.  I think this will be
>a minority case.
> 
> 2) compilation of native programs has already to be possible since there
>are other native tools such as mkimage built during the compilation

I think we have an agreement. We will use the C program.

Now let's go on and do some real work.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED]
Repeat after me:
Usenet is not a word processor; it's a medium where aesthetics count.
Mozilla is not a newsreader; it's a web browser.
Windows is not an operating system; it's a GUI on a program loader.
 -- Tom Christiansen in <[EMAIL PROTECTED]>

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Re: [U-Boot-Users] [PATCH 0/1] Moved initialization of AVR32 Ethernet controllers to board_eth_init()

[Haavard Skinnemoen]

On Sat,  5 Jul 2008 00:08:47 -0700
Ben Warren <[EMAIL PROTECTED]> wrote:

> More cleanup of net/eth.c, this time taking care of AVR32 boards.  I got rid
> of the board/eth.c files because board_eth_init() needs to be in a file where
> there are other strong symbols in order to override the weak board_eth_init() 
> in
> net/eth.c.  I've compiled this code  and verified that the strong
> board_eth_init() symbols are linked in, but don't have hardware to test on.
> If somebody can, please try out and let me know.

Looks good to me, but I don't have the chance to test it.

> These patches are being staged in the 'testing' branch of the net repo.

Maybe someone else could give it a try?

Haavard

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Re: [U-Boot-Users] Release status - things to be done

[Haavard Skinnemoen]

[removing my private e-mail address from Cc]

On Sun, 06 Jul 2008 01:05:40 +0200
Wolfgang Denk <[EMAIL PROTECTED]> wrote:

> 2582  05/21 Haavard Skinnemoe  [PATCH] MMC: Consolidate MMC/SD command 
> definitions
>   -> Rejected, needs to be rebased  

I see you applied v2 instead -- good. Please ignore v1 as it was posted
before the big whitespace cleanup.

>  2584  05/21 Haavard Skinnemoe  [PATCH] Remove [EMAIL PROTECTED] from 
> MAINTAINERS
>   -> asked submitter for fixes / cleanup  

I'll send you a new patch later today...if I can find the original
commit.

> 3648  06/11 "Antonio R. Costa  [U-Boot-Users] [PATCH 1/6] AT572D940HF-EB 
> Support
>  3649  06/11 "Antonio R. Costa  [U-Boot-Users] [PATCH 2/6] AT572D940HF-EB 
> Support
>  3650  06/11 "Antonio R. Costa  [U-Boot-Users] [PATCH 3/6] AT572D940HF-EB 
> Support
>  3651  06/11 "Antonio R. Costa  [U-Boot-Users] [PATCH 4/6] AT572D940HF-EB 
> Support
>  3652  06/11 "Antonio R. Costa  [U-Boot-Users] [PATCH 5/6] AT572D940HF-EB 
> Support
>  3653  06/11 "Antonio R. Costa  [U-Boot-Users] [PATCH 6/6] AT572D940HF-EB 
> Support
>  3654  06/11 "Antonio R. Costa  [U-Boot-Users] [PATCH 1/3] SDHC Support for 
> AT572d940HF-EB
>  3733  06/12 "Ulf Samuelsson"   Re: [U-Boot-Users] [PATCH 1/3] SDHC Support 
> for AT572d940HF-EB
>  3735  06/12 "COSTA, Antonio"   Re: [U-Boot-Users] [PATCH 1/3] SDHC Support 
> for AT572d940HF-EB
>  3737  06/12 "Ulf Samuelsson"   Re: [U-Boot-Users] [PATCH 1/3] SDHC Support 
> for AT572d940HF-EB
>  3739  06/12 Jerry Van BarenRe: [U-Boot-Users] [PATCH 1/3] SDHC Support 
> for AT572d940HF-EB
>  3859  06/15 Haavard Skinnemoe  Re: [U-Boot-Users] [PATCH 1/3] SDHC Support 
> for AT572d940HF-EB
>  3897  06/16 [EMAIL PROTECTED]  Re: [U-Boot-Users] [PATCH 1/3] SDHC Support 
> for AT572d940HF-EB
>  3899  06/17 Haavard Skinnemoe  Re: [U-Boot-Users] [PATCH 1/3] SDHC Support 
> for AT572d940HF-EB
>  3740  06/12 "Antonio R. Costa  [U-Boot-Users] [PATCH 1/6] AT572D940HF-EB 
> Support v2 (board folder)
>  3741  06/12 "Antonio R. Costa  [U-Boot-Users] [PATCH 2/2] AT572D940HF-EB 
> Support v2 (SDHC support part 2)
>  3742  06/12 "Antonio R. Costa  [U-Boot-Users] [PATCH 1/2] AT572D940HF-EB 
> Support v2 (SDHC support part 1)
>  3743  06/12 "Antonio R. Costa  [U-Boot-Users] [PATCH 3/6] AT572D940HF-EB 
> Support v2 (include files part 1)
>  3744  06/12 "Antonio R. Costa  [U-Boot-Users] [PATCH 5/6] AT572D940HF-EB 
> Support v2 (ethernet files)
>  3745  06/12 "Antonio R. Costa  [U-Boot-Users] [PATCH 4/6] AT572D940HF-EB 
> Support v2 (include files part 2)
>  3747  06/12 "Antonio R. Costa  [U-Boot-Users] [PATCH 2/6] AT572D940HF-EB 
> Support v2 (cpu folder)
>  3748  06/12 "Antonio R. Costa  [U-Boot-Users] [PATCH 6/6] AT572D940HF-EB 
> Support v2 (configuration files)
>  3746  06/12 "Antonio R. Costa  [U-Boot-Users] [PATCH 1/1] mmc_verbosity 
> variable
>  3764  06/12 Haavard Skinnemoe  Re: [U-Boot-Users] [PATCH 1/2] AT572D940HF-EB 
> Support v2 (SDHC support part 1)
>   -> still under discussion;  who is reponsible?  

I think Jean-Christophe should be responsible for most of this, but I
obviously want to be kept in the loop with the MMC/SD/SDHC stuff and
possibly other stuff that is or ought to be shared with avr32.

Now that the MMC driver has been moved into drivers/mmc, I'd really
like to see a patch with the minimum amount of changes needed to make
the driver work on AT91 and AT57 as well. With that in place, we'll
have a great baseline to add new features like SDHC and MMC+ support,
and the rest of the AT57 board support can be merged independently.

Haavard

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Re: [U-Boot-Users] [PATCH] add 'license' command to u-boot?commandline

[Jerry Van Baren]

Harald Welte wrote:
> On Thu, Jul 10, 2008 at 12:51:03PM +0200, Detlev Zundel wrote:
> 
>> Even though I'm an enthusiastic Emacs user, I have different reasons for
>> my vote.  As far as build dependencies go, I'd like to restrict this to
>> the LSB standard[1].  Xdd is not in there, so thats why I vote for the
>> small C program (unless we can adapt the script and use 'od').
> 
> I think sticking to LSB for build dependencies is a very reasonable choice.
> 
> I still don't think the small C program is that much of a problem:
> 
> 1) dependency tracking should ensure it is only built when the license
>feature is enabled by the board-level config.  I think this will be
>a minority case.
> 
> 2) compilation of native programs has already to be possible since there
>are other native tools such as mkimage built during the compilation
> 
> Cheers,

FWIIW, I agree with Detlev & Harald and withdraw my "bleah" objection.

Best regards,
gvb


-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Re: [U-Boot-Users] [PATCH] add 'license' command to u-boot?commandline

[Harald Welte]

On Thu, Jul 10, 2008 at 12:51:03PM +0200, Detlev Zundel wrote:

> Even though I'm an enthusiastic Emacs user, I have different reasons for
> my vote.  As far as build dependencies go, I'd like to restrict this to
> the LSB standard[1].  Xdd is not in there, so thats why I vote for the
> small C program (unless we can adapt the script and use 'od').

I think sticking to LSB for build dependencies is a very reasonable choice.

I still don't think the small C program is that much of a problem:

1) dependency tracking should ensure it is only built when the license
   feature is enabled by the board-level config.  I think this will be
   a minority case.

2) compilation of native programs has already to be possible since there
   are other native tools such as mkimage built during the compilation

Cheers,
-- 
- Harald Welte <[EMAIL PROTECTED]>  http://openmoko.org/

Software for the world's first truly open Free Software mobile phone

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

[U-Boot-Users] [PATCH v2] Remove [EMAIL PROTECTED] from MAINTAINERS

[Haavard Skinnemoen]

Mail to [EMAIL PROTECTED] bounces because the user doesn't exist
anymore. You can't be a maintainer without a valid e-mail address, so
move all boards that used to be maintained by Kyle Harris to the
"orphaned" list.

Currently, only PowerPC has a list of orphaned boards, so this patch
creates one for ARM as well.

Signed-off-by: Haavard Skinnemoen <[EMAIL PROTECTED]>
---
On Sun, 06 Jul 2008 00:32:01 +0200 Wolfgang Denk <[EMAIL PROTECTED]> wrote:
> ... don't jusst delete the orphaned boards, but add them to the
> "Unknown / orphaned" list.

I created a new Unknown/orphaned list for ARM since the existing one
was located in the PowerPC section and only had PowerPC boards on it.
Is that ok?

 MAINTAINERS |   14 --
 1 files changed, 8 insertions(+), 6 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index a3d70b1..6065e42 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -492,12 +492,6 @@ Kshitij Gupta <[EMAIL PROTECTED]>
omap1510inn ARM925T
omap1610inn ARM926EJS
 
-Kyle Harris <[EMAIL PROTECTED]>
-
-   lubbock xscale
-   cradle  xscale
-   ixdp425 xscale
-
 Gary Jennejohn <[EMAIL PROTECTED]>
 
smdk2400ARM920T
@@ -591,6 +585,14 @@ Michael Schwingen <[EMAIL PROTECTED]>
actux3  xscale
actux4  xscale
 
+-
+
+Unknown / orphaned boards:
+
+   cradle  xscale
+   ixdp425 xscale
+   lubbock xscale
+
 #
 # x86 Systems: #
 #  #
-- 
1.5.4.3


-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Re: [U-Boot-Users] [PATCH] add 'license' command to u-boot?commandline

[Stefan Roese]

On Thursday 10 July 2008, Detlev Zundel wrote:
> > IMHO, vim and xxd are essential programs so I'm OK with using
> > xxd. OTOH, I understand some people actually prefer emacs and may have
> > a problem with requiring vim to be installed.  ;-/
>
> Even though I'm an enthusiastic Emacs user, I have different reasons for
> my vote.  As far as build dependencies go, I'd like to restrict this to
> the LSB standard[1].  Xdd is not in there, so thats why I vote for the
> small C program (unless we can adapt the script and use 'od').

I would prefer this C program solution too.

Best regards,
Stefan

-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users