[webkit-changes] [103857] trunk/Source/WebKit/chromium

2011-12-30 Thread commit-queue
Title: [103857] trunk/Source/WebKit/chromium








Revision 103857
Author commit-qu...@webkit.org
Date 2011-12-30 22:02:49 -0800 (Fri, 30 Dec 2011)


Log Message
Allow disabling accelerated compositing in WebMediaPlayerClient (so audio-only  isn't accelerated).
https://bugs.webkit.org/show_bug.cgi?id=75261

Patch by Ami Fischman  on 2011-12-30
Reviewed by Darin Fisher.

* public/WebMediaPlayerClient.h:
* src/WebMediaPlayerClientImpl.cpp:
(WebKit::WebMediaPlayerClientImpl::disableAcceleratedCompositing):
(WebKit::WebMediaPlayerClientImpl::AudioSourceProviderImpl::setClient):
* src/WebMediaPlayerClientImpl.h:

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebMediaPlayerClient.h
trunk/Source/WebKit/chromium/src/WebMediaPlayerClientImpl.cpp
trunk/Source/WebKit/chromium/src/WebMediaPlayerClientImpl.h




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (103856 => 103857)

--- trunk/Source/WebKit/chromium/ChangeLog	2011-12-31 02:56:55 UTC (rev 103856)
+++ trunk/Source/WebKit/chromium/ChangeLog	2011-12-31 06:02:49 UTC (rev 103857)
@@ -1,3 +1,16 @@
+2011-12-30  Ami Fischman  
+
+Allow disabling accelerated compositing in WebMediaPlayerClient (so audio-only  isn't accelerated).
+https://bugs.webkit.org/show_bug.cgi?id=75261
+
+Reviewed by Darin Fisher.
+
+* public/WebMediaPlayerClient.h:
+* src/WebMediaPlayerClientImpl.cpp:
+(WebKit::WebMediaPlayerClientImpl::disableAcceleratedCompositing):
+(WebKit::WebMediaPlayerClientImpl::AudioSourceProviderImpl::setClient):
+* src/WebMediaPlayerClientImpl.h:
+
 2011-12-30  Sheriff Bot  
 
 Unreviewed.  Rolled DEPS.


Modified: trunk/Source/WebKit/chromium/public/WebMediaPlayerClient.h (103856 => 103857)

--- trunk/Source/WebKit/chromium/public/WebMediaPlayerClient.h	2011-12-31 02:56:55 UTC (rev 103856)
+++ trunk/Source/WebKit/chromium/public/WebMediaPlayerClient.h	2011-12-31 06:02:49 UTC (rev 103857)
@@ -56,6 +56,7 @@
 virtual WebMediaPlayer::Preload preload() const = 0;
 virtual void sourceOpened() = 0;
 virtual WebKit::WebURL sourceURL() const = 0;
+virtual void disableAcceleratedCompositing() = 0;
 protected:
 ~WebMediaPlayerClient() { }
 };


Modified: trunk/Source/WebKit/chromium/src/WebMediaPlayerClientImpl.cpp (103856 => 103857)

--- trunk/Source/WebKit/chromium/src/WebMediaPlayerClientImpl.cpp	2011-12-31 02:56:55 UTC (rev 103856)
+++ trunk/Source/WebKit/chromium/src/WebMediaPlayerClientImpl.cpp	2011-12-31 06:02:49 UTC (rev 103857)
@@ -225,6 +225,11 @@
 #endif
 }
 
+void WebMediaPlayerClientImpl::disableAcceleratedCompositing()
+{
+m_supportsAcceleratedCompositing = false;
+}
+
 // MediaPlayerPrivateInterface -
 
 void WebMediaPlayerClientImpl::load(const String& url)
@@ -696,7 +701,7 @@
 m_client = adoptPtr(new WebMediaPlayerClientImpl::AudioClientImpl(client));
 else
 m_client.clear();
-
+
 if (m_webAudioSourceProvider)
 m_webAudioSourceProvider->setClient(m_client.get());
 }


Modified: trunk/Source/WebKit/chromium/src/WebMediaPlayerClientImpl.h (103856 => 103857)

--- trunk/Source/WebKit/chromium/src/WebMediaPlayerClientImpl.h	2011-12-31 02:56:55 UTC (rev 103856)
+++ trunk/Source/WebKit/chromium/src/WebMediaPlayerClientImpl.h	2011-12-31 06:02:49 UTC (rev 103857)
@@ -86,6 +86,7 @@
 virtual WebMediaPlayer::Preload preload() const;
 virtual void sourceOpened();
 virtual WebKit::WebURL sourceURL() const;
+virtual void disableAcceleratedCompositing();
 
 // MediaPlayerPrivateInterface methods:
 virtual void load(const WTF::String& url);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes


[webkit-changes] [103856] trunk

2011-12-30 Thread kling
Title: [103856] trunk








Revision 103856
Author kl...@webkit.org
Date 2011-12-30 18:56:55 -0800 (Fri, 30 Dec 2011)


Log Message
Cache and reuse the HTMLTableElement.rows collection.


Reviewed by Anders Carlsson.

Source/WebCore: 

Let HTMLTableElement::rows() cache the returned collection and tie it to the
lifetime of the form.

Test: fast/dom/table-rows-collection-idempotence.html
  fast/dom/gc-9.html

* html/HTMLTableElement.h:
* html/HTMLTableElement.cpp:
(WebCore::HTMLTableElement::rows):

Cache the HTMLTableRowsCollection returned by rows() on the HTMLTableElement.
Remove the per-table CollectionCache and let the collection manage that.

* html/HTMLTableRowsCollection.h:
* html/HTMLTableRowsCollection.cpp:
(WebCore::HTMLTableRowsCollection::HTMLTableRowsCollection):
(WebCore::HTMLTableRowsCollection::create):

Tell the base class constructor to not retain the back-pointer to the table.

LayoutTests: 

- Update gc-9.html to document the new lifetime characteristics of HTMLTableElement.rows.
- Add a test to verify that HTMLTableElement.rows returns the same object when called repeatedly.

* fast/dom/gc-9-expected.txt:
* fast/dom/gc-9.html:
* fast/dom/table-rows-collection-idempotence-expected.txt: Added.
* fast/dom/table-rows-collection-idempotence.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/dom/gc-9-expected.txt
trunk/LayoutTests/fast/dom/gc-9.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLTableElement.cpp
trunk/Source/WebCore/html/HTMLTableElement.h
trunk/Source/WebCore/html/HTMLTableRowsCollection.cpp
trunk/Source/WebCore/html/HTMLTableRowsCollection.h


Added Paths

trunk/LayoutTests/fast/dom/table-rows-collection-idempotence-expected.txt
trunk/LayoutTests/fast/dom/table-rows-collection-idempotence.html




Diff

Modified: trunk/LayoutTests/ChangeLog (103855 => 103856)

--- trunk/LayoutTests/ChangeLog	2011-12-31 02:43:33 UTC (rev 103855)
+++ trunk/LayoutTests/ChangeLog	2011-12-31 02:56:55 UTC (rev 103856)
@@ -1,5 +1,20 @@
 2011-12-30  Andreas Kling  
 
+Cache and reuse the HTMLTableElement.rows collection.
+
+
+Reviewed by Anders Carlsson.
+
+- Update gc-9.html to document the new lifetime characteristics of HTMLTableElement.rows.
+- Add a test to verify that HTMLTableElement.rows returns the same object when called repeatedly.
+
+* fast/dom/gc-9-expected.txt:
+* fast/dom/gc-9.html:
+* fast/dom/table-rows-collection-idempotence-expected.txt: Added.
+* fast/dom/table-rows-collection-idempotence.html: Added.
+
+2011-12-30  Andreas Kling  
+
 Cache and reuse the HTMLSelectElement.options collection.
 
 


Modified: trunk/LayoutTests/fast/dom/gc-9-expected.txt (103855 => 103856)

--- trunk/LayoutTests/fast/dom/gc-9-expected.txt	2011-12-31 02:43:33 UTC (rev 103855)
+++ trunk/LayoutTests/fast/dom/gc-9-expected.txt	2011-12-31 02:56:55 UTC (rev 103856)
@@ -24,7 +24,7 @@
 PASS: document.anchors.myCustomProperty should be 1 and is.
 PASS: document.scripts.myCustomProperty should be 1 and is.
 PASS: document.getElementsByTagName('form')[0].elements.myCustomProperty should be 1 and is.
-PASS: document.getElementsByTagName('table')[0].rows.myCustomProperty should be undefined and is.
+PASS: document.getElementsByTagName('table')[0].rows.myCustomProperty should be 1 and is.
 PASS: document.getElementsByTagName('table')[0].rows[0].cells.myCustomProperty should be undefined and is.
 PASS: document.getElementsByTagName('table')[0].tBodies.myCustomProperty should be undefined and is.
 PASS: document.getElementsByTagName('table')[0].tBodies[0].rows.myCustomProperty should be undefined and is.
@@ -60,7 +60,7 @@
 PASS: document.anchors.myCustomProperty should be 1 and is.
 PASS: document.scripts.myCustomProperty should be 1 and is.
 PASS: document.getElementsByTagName('form')[0].elements.myCustomProperty should be 1 and is.
-PASS: document.getElementsByTagName('table')[0].rows.myCustomProperty should be undefined and is.
+PASS: document.getElementsByTagName('table')[0].rows.myCustomProperty should be 1 and is.
 PASS: document.getElementsByTagName('table')[0].rows[0].cells.myCustomProperty should be undefined and is.
 PASS: document.getElementsByTagName('table')[0].tBodies.myCustomProperty should be undefined and is.
 PASS: document.getElementsByTagName('table')[0].tBodies[0].rows.myCustomProperty should be undefined and is.


Modified: trunk/LayoutTests/fast/dom/gc-9.html (103855 => 103856)

--- trunk/LayoutTests/fast/dom/gc-9.html	2011-12-31 02:43:33 UTC (rev 103855)
+++ trunk/LayoutTests/fast/dom/gc-9.html	2011-12-31 02:56:55 UTC (rev 103856)
@@ -135,7 +135,7 @@
 [ "document.scripts", "allow custom" ],
 
 [ "document.getElementsByTagName('form')[0].elements", "allow custom" ],
-[ "document.getElementsByTagName('table')[0].rows" ],
+[ "document.getElementsByTagName('table')[0].rows", "allow custom" ],
 [ "document.getElementsByTagName(

[webkit-changes] [103855] trunk

2011-12-30 Thread kling
Title: [103855] trunk








Revision 103855
Author kl...@webkit.org
Date 2011-12-30 18:43:33 -0800 (Fri, 30 Dec 2011)


Log Message
Cache and reuse the HTMLSelectElement.options collection.


Reviewed by Anders Carlsson.

Source/WebCore: 

Let HTMLSelectElement::options() cache the returned collection and tie it to the
lifetime of the form. This shrinks HTMLSelectElement by sizeof(CollectionCache)
minus one pointer.

Test: fast/dom/select-options-collection-idempotence.html
  fast/gc-9.html

* html/HTMLSelectElement.h:
* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::options):

Cache the HTMLOptionsCollection returned by options() on the HTMLSelectElement.
Remove the per-select CollectionCache and let the collection manage that.

* html/HTMLOptionsCollection.h:
* html/HTMLOptionsCollection.cpp:
(WebCore::HTMLOptionsCollection::create):
(WebCore::HTMLOptionsCollection::HTMLOptionsCollection):

Tell the base class constructor to not retain the back-pointer to the element.

* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::setRecalcListItems):
* html/HTMLOptionsCollection.cpp:
(WebCore::HTMLOptionsCollection::invalidateCache):

Added so HTMLSelectElement can invalidate the collection without triggering
unnecessary instantiation of a CollectionCache.

LayoutTests: 

- Update gc-9.html to document the new lifetime characteristics of HTMLSelectElement.options.
- Add a test to verify that HTMLSelectElement.options returns the same object when called repeatedly.

* fast/dom/gc-9-expected.txt:
* fast/dom/gc-9.html:
* fast/dom/select-options-collection-idempotence-expected.txt: Added.
* fast/dom/select-options-collection-idempotence.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/dom/gc-9-expected.txt
trunk/LayoutTests/fast/dom/gc-9.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLOptionsCollection.cpp
trunk/Source/WebCore/html/HTMLOptionsCollection.h
trunk/Source/WebCore/html/HTMLSelectElement.cpp
trunk/Source/WebCore/html/HTMLSelectElement.h


Added Paths

trunk/LayoutTests/fast/dom/select-options-collection-idempotence-expected.txt
trunk/LayoutTests/fast/dom/select-options-collection-idempotence.html




Diff

Modified: trunk/LayoutTests/ChangeLog (103854 => 103855)

--- trunk/LayoutTests/ChangeLog	2011-12-31 01:10:47 UTC (rev 103854)
+++ trunk/LayoutTests/ChangeLog	2011-12-31 02:43:33 UTC (rev 103855)
@@ -1,3 +1,18 @@
+2011-12-30  Andreas Kling  
+
+Cache and reuse the HTMLSelectElement.options collection.
+
+
+Reviewed by Anders Carlsson.
+
+- Update gc-9.html to document the new lifetime characteristics of HTMLSelectElement.options.
+- Add a test to verify that HTMLSelectElement.options returns the same object when called repeatedly.
+
+* fast/dom/gc-9-expected.txt:
+* fast/dom/gc-9.html:
+* fast/dom/select-options-collection-idempotence-expected.txt: Added.
+* fast/dom/select-options-collection-idempotence.html: Added.
+
 2011-12-30  Robert Hogan  
 
 [Qt] fast/css/absolute-inline-alignment.html fails


Modified: trunk/LayoutTests/fast/dom/gc-9-expected.txt (103854 => 103855)

--- trunk/LayoutTests/fast/dom/gc-9-expected.txt	2011-12-31 01:10:47 UTC (rev 103854)
+++ trunk/LayoutTests/fast/dom/gc-9-expected.txt	2011-12-31 02:43:33 UTC (rev 103855)
@@ -13,7 +13,7 @@
 PASS: document.getElementsByTagName('canvas')[0].getContext('2d').myCustomProperty should be 1 and is.
 PASS: document.getElementsByTagName('canvas')[0].getContext('2d').createLinearGradient(0, 0, 0, 0).myCustomProperty should be undefined and is.
 PASS: document.getElementsByTagName('canvas')[0].getContext('2d').createPattern(new Image(), 'no-repeat').myCustomProperty should be undefined and is.
-PASS: document.getElementsByTagName('select')[0].options.myCustomProperty should be undefined and is.
+PASS: document.getElementsByTagName('select')[0].options.myCustomProperty should be 1 and is.
 PASS: document.body.childNodes.myCustomProperty should be undefined and is.
 PASS: document.all.myCustomProperty should be 1 and is.
 PASS: document.images.myCustomProperty should be 1 and is.
@@ -49,7 +49,7 @@
 PASS: document.getElementsByTagName('canvas')[0].getContext('2d').myCustomProperty should be 1 and is.
 PASS: document.getElementsByTagName('canvas')[0].getContext('2d').createLinearGradient(0, 0, 0, 0).myCustomProperty should be undefined and is.
 PASS: document.getElementsByTagName('canvas')[0].getContext('2d').createPattern(new Image(), 'no-repeat').myCustomProperty should be undefined and is.
-PASS: document.getElementsByTagName('select')[0].options.myCustomProperty should be undefined and is.
+PASS: document.getElementsByTagName('select')[0].options.myCustomProperty should be 1 and is.
 PASS: document.body.childNodes.myCustomProperty should be undefined and is.
 PASS: document.all.myCustomProperty should be 1 and is.
 PASS: document.images.myCustomProperty should be 1 and is.


[webkit-changes] [103854] trunk/Source/WebCore

2011-12-30 Thread haraken
Title: [103854] trunk/Source/WebCore








Revision 103854
Author hara...@chromium.org
Date 2011-12-30 17:10:47 -0800 (Fri, 30 Dec 2011)


Log Message
Enable the [Supplemental] IDL on CMake
https://bugs.webkit.org/show_bug.cgi?id=75345

Reviewed by Daniel Bates.

This patch enables the [Supplemental] IDL on CMake by changing the build
flow of CMake as follows.

- Previous build flow:
foreach $idl (all IDL files) {
generate-bindings.pl depends on $idl;
generate-bindings.pl reads $idl;
generate-bindings.pl generates .h and .cpp files for $idl;
}

- New build flow (See the discussions in bug 72138 for more details):
resolve-supplemental.pl depends on all IDL files;
resolve-supplemental.pl reads all IDL files;
resolve-supplemental.pl resolves the dependency of [Supplemental=];
resolve-supplemental.pl outputs supplemental_dependency.tmp;
foreach $idl (all IDL files) {
generate-bindings.pl depends on $idl and supplemental_dependency.tmp;
generate-bindings.pl reads $idl;
generate-bindings.pl reads supplemental_dependency.tmp;
generate-bindings.pl generates .h and .cpp files for $idl,
including all attributes in the IDL files that are implementing $idl;
}

Tests: Confirm that build succeeds.
   http/tests/websocket/tests/*

* CMakeLists.txt:
* UseJSC.cmake: Modified to reflect the new build flow as described above.
* UseV8.cmake: Ditto.

Modified Paths

trunk/Source/WebCore/CMakeLists.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/UseJSC.cmake
trunk/Source/WebCore/UseV8.cmake




Diff

Modified: trunk/Source/WebCore/CMakeLists.txt (103853 => 103854)

--- trunk/Source/WebCore/CMakeLists.txt	2011-12-31 00:20:00 UTC (rev 103853)
+++ trunk/Source/WebCore/CMakeLists.txt	2011-12-31 01:10:47 UTC (rev 103854)
@@ -369,6 +369,7 @@
 webaudio/AudioProcessingEvent.idl
 webaudio/AudioSourceNode.idl
 webaudio/ConvolverNode.idl
+webaudio/DOMWindowWebAudio.idl
 webaudio/DelayNode.idl
 webaudio/HighPass2FilterNode.idl
 webaudio/_javascript_AudioNode.idl
@@ -376,6 +377,7 @@
 webaudio/RealtimeAnalyserNode.idl
 
 websockets/CloseEvent.idl
+websockets/DOMWindowWebSocket.idl
 
 xml/DOMParser.idl
 xml/XMLHttpRequest.idl
@@ -2218,12 +2220,17 @@
 ENDIF ()
 
 # Modules that the bindings generator scripts may use
+SET(SCRIPTS_RESOLVE_SUPPLEMENTAL
+${WEBCORE_DIR}/bindings/scripts/IDLParser.pm
+)
 SET(SCRIPTS_BINDINGS
 ${WEBCORE_DIR}/bindings/scripts/IDLParser.pm
 ${WEBCORE_DIR}/bindings/scripts/IDLStructure.pm
 ${WEBCORE_DIR}/bindings/scripts/InFilesParser.pm
 ${WEBCORE_DIR}/bindings/scripts/preprocessor.pm
 )
+SET(IDL_FILES_TMP ${DERIVED_SOURCES_WEBCORE_DIR}/idl_files.tmp)
+SET(SUPPLEMENTAL_DEPENDENCY_FILE ${DERIVED_SOURCES_WEBCORE_DIR}/supplemental_dependency.tmp)
 
 INCLUDE(${WEBCORE_DIR}/UseJSC.cmake)
 


Modified: trunk/Source/WebCore/ChangeLog (103853 => 103854)

--- trunk/Source/WebCore/ChangeLog	2011-12-31 00:20:00 UTC (rev 103853)
+++ trunk/Source/WebCore/ChangeLog	2011-12-31 01:10:47 UTC (rev 103854)
@@ -1,3 +1,40 @@
+2011-12-30  Kentaro Hara  
+
+Enable the [Supplemental] IDL on CMake
+https://bugs.webkit.org/show_bug.cgi?id=75345
+
+Reviewed by Daniel Bates.
+
+This patch enables the [Supplemental] IDL on CMake by changing the build
+flow of CMake as follows.
+
+- Previous build flow:
+foreach $idl (all IDL files) {
+generate-bindings.pl depends on $idl;
+generate-bindings.pl reads $idl;
+generate-bindings.pl generates .h and .cpp files for $idl;
+}
+
+- New build flow (See the discussions in bug 72138 for more details):
+resolve-supplemental.pl depends on all IDL files;
+resolve-supplemental.pl reads all IDL files;
+resolve-supplemental.pl resolves the dependency of [Supplemental=];
+resolve-supplemental.pl outputs supplemental_dependency.tmp;
+foreach $idl (all IDL files) {
+generate-bindings.pl depends on $idl and supplemental_dependency.tmp;
+generate-bindings.pl reads $idl;
+generate-bindings.pl reads supplemental_dependency.tmp;
+generate-bindings.pl generates .h and .cpp files for $idl,
+including all attributes in the IDL files that are implementing $idl;
+}
+
+Tests: Confirm that build succeeds.
+   http/tests/websocket/tests/*
+
+* CMakeLists.txt:
+* UseJSC.cmake: Modified to reflect the new build flow as described above.
+* UseV8.cmake: Ditto.
+
 2011-12-30  Robert Hogan  
 
 REGRESSION (r94492): Text is shifted to the right in some buttons in the Mac App Store


Modified: trunk/Source/WebCore/UseJSC.cmake (103853 => 103854)

--- trunk/Source/WebCore/UseJSC.cmake	2011-12-31 00:20:00 UTC (rev 103853)
+++

[webkit-changes] [103853] trunk/LayoutTests

2011-12-30 Thread robert
Title: [103853] trunk/LayoutTests








Revision 103853
Author rob...@webkit.org
Date 2011-12-30 16:20:00 -0800 (Fri, 30 Dec 2011)


Log Message
[Qt] fast/css/absolute-inline-alignment.html fails
https://bugs.webkit.org/show_bug.cgi?id=75400

Unreviewed, skipping 2 new tests on Qt after r103851.

* platform/qt/Skipped:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/qt/Skipped




Diff

Modified: trunk/LayoutTests/ChangeLog (103852 => 103853)

--- trunk/LayoutTests/ChangeLog	2011-12-30 21:27:14 UTC (rev 103852)
+++ trunk/LayoutTests/ChangeLog	2011-12-31 00:20:00 UTC (rev 103853)
@@ -1,3 +1,12 @@
+2011-12-30  Robert Hogan  
+
+[Qt] fast/css/absolute-inline-alignment.html fails
+https://bugs.webkit.org/show_bug.cgi?id=75400
+
+Unreviewed, skipping 2 new tests on Qt after r103851.
+
+* platform/qt/Skipped:
+
 2011-12-30  Eric Carlson  
 
 [chromium] media/track/track-cue-rendering.html fails


Modified: trunk/LayoutTests/platform/qt/Skipped (103852 => 103853)

--- trunk/LayoutTests/platform/qt/Skipped	2011-12-30 21:27:14 UTC (rev 103852)
+++ trunk/LayoutTests/platform/qt/Skipped	2011-12-31 00:20:00 UTC (rev 103853)
@@ -2534,3 +2534,8 @@
 # [Qt] fails fast/inline/nested-text-descendants.html
 # https://bugs.webkit.org/show_bug.cgi?id=75321
 fast/inline/nested-text-descendants.html
+
+# [Qt] fast/css/absolute-inline-alignment.html fails
+# https://bugs.webkit.org/show_bug.cgi?id=75400
+fast/css/absolute-inline-alignment.html
+fast/css/absolute-inline-alignment-2.html






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes


[webkit-changes] [103852] trunk/LayoutTests

2011-12-30 Thread eric . carlson
Title: [103852] trunk/LayoutTests








Revision 103852
Author eric.carl...@apple.com
Date 2011-12-30 13:27:14 -0800 (Fri, 30 Dec 2011)


Log Message
[chromium] media/track/track-cue-rendering.html fails
https://bugs.webkit.org/show_bug.cgi?id=75098

Reviewed by Dan Bernstein.

* media/media-controls.js:
(textTrackDisplayElement): Don't assume there is only one shadow DOM element used to
display captions.
* media/track/track-cue-nothing-to-render-expected.txt: Updated.
* media/track/track-cue-nothing-to-render.html: Fix the test so it checks the track
container and cue text pseudo element properties separately.
* media/track/track-cue-rendering-expected.txt: Updated for textTrackDisplayElement change.
* media/track/track-cue-rendering.html: Ditto.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/media/media-controls.js
trunk/LayoutTests/media/track/track-cue-nothing-to-render-expected.txt
trunk/LayoutTests/media/track/track-cue-nothing-to-render.html
trunk/LayoutTests/media/track/track-cue-rendering-expected.txt
trunk/LayoutTests/media/track/track-cue-rendering.html




Diff

Modified: trunk/LayoutTests/ChangeLog (103851 => 103852)

--- trunk/LayoutTests/ChangeLog	2011-12-30 20:58:29 UTC (rev 103851)
+++ trunk/LayoutTests/ChangeLog	2011-12-30 21:27:14 UTC (rev 103852)
@@ -1,3 +1,19 @@
+2011-12-30  Eric Carlson  
+
+[chromium] media/track/track-cue-rendering.html fails
+https://bugs.webkit.org/show_bug.cgi?id=75098
+
+Reviewed by Dan Bernstein.
+
+* media/media-controls.js:
+(textTrackDisplayElement): Don't assume there is only one shadow DOM element used to 
+display captions.
+* media/track/track-cue-nothing-to-render-expected.txt: Updated.
+* media/track/track-cue-nothing-to-render.html: Fix the test so it checks the track 
+container and cue text pseudo element properties separately.
+* media/track/track-cue-rendering-expected.txt: Updated for textTrackDisplayElement change.
+* media/track/track-cue-rendering.html: Ditto.
+
 2011-12-30  Robert Hogan  
 
 REGRESSION (r94492): Text is shifted to the right in some buttons in the Mac App Store


Modified: trunk/LayoutTests/media/media-controls.js (103851 => 103852)

--- trunk/LayoutTests/media/media-controls.js	2011-12-30 20:58:29 UTC (rev 103851)
+++ trunk/LayoutTests/media/media-controls.js	2011-12-30 21:27:14 UTC (rev 103852)
@@ -33,9 +33,9 @@
 return new Array(x, y);
 }
 
-function textTrackDisplayElement(parentElement)
+function textTrackDisplayElement(parentElement, id)
 {
-var controlID = "-webkit-media-text-track-display";
+var controlID = "-webkit-media-text-track-" + id;
 var displayElement = mediaControlsElement(internals.shadowRoot(parentElement).firstChild, controlID);
 if (!displayElement)
 throw "Failed to find media control element ID '" + controlID + "'";


Modified: trunk/LayoutTests/media/track/track-cue-nothing-to-render-expected.txt (103851 => 103852)

--- trunk/LayoutTests/media/track/track-cue-nothing-to-render-expected.txt	2011-12-30 20:58:29 UTC (rev 103851)
+++ trunk/LayoutTests/media/track/track-cue-nothing-to-render-expected.txt	2011-12-30 21:27:14 UTC (rev 103852)
@@ -3,46 +3,46 @@
 EVENT(canplaythrough)
 EVENT(seeked)
 EXPECTED (video.currentTime.toFixed(1) == '0.5') OK
-EXPECTED (textTrackDisplayElement(video).innerText == '') OK
+EXPECTED (textTrackDisplayElement(video, 'display').innerText == '') OK
 
 RUN(video.currentTime = 1.5)
 EVENT(seeked)
 EXPECTED (video.currentTime.toFixed(1) == '1.5') OK
 EXPECTED (testTrack.track.activeCues[0].getCueAsSource() == 'Lorem ipsum dolor sit amet,') OK
-EXPECTED (textTrackDisplayElement(video).innerText == 'Lorem ipsum dolor sit amet,') OK
+EXPECTED (textTrackDisplayElement(video, 'display').innerText == 'Lorem ipsum dolor sit amet,') OK
 
 RUN(video.currentTime = 2.5)
 EVENT(seeked)
 EXPECTED (video.currentTime.toFixed(1) == '2.5') OK
-EXPECTED (textTrackDisplayElement(video).innerText == '') OK
+EXPECTED (textTrackDisplayElement(video, 'display').innerText == '') OK
 
 RUN(video.currentTime = 3.3)
 EVENT(seeked)
 EXPECTED (video.currentTime.toFixed(1) == '3.3') OK
 EXPECTED (testTrack.track.activeCues[0].getCueAsSource() == 'consectetuer adipiscing elit,') OK
-EXPECTED (textTrackDisplayElement(video).innerText == 'consectetuer adipiscing elit,') OK
+EXPECTED (textTrackDisplayElement(video, 'display').innerText == 'consectetuer adipiscing elit,') OK
 
 RUN(video.currentTime = 0.6)
 EVENT(seeked)
 EXPECTED (video.currentTime.toFixed(1) == '0.6') OK
-EXPECTED (textTrackDisplayElement(video).innerText == '') OK
+EXPECTED (textTrackDisplayElement(video, 'display').innerText == '') OK
 
 RUN(video.currentTime = 5.9)
 EVENT(seeked)
 EXPECTED (video.currentTime.toFixed(1) == '5.9') OK
 EXPECTED (testTrack.track.activeCues[0].getCueAsSource() == 'sed diam nonummy nibh euismod tincidunt') OK
-EXPECTED (textTrackDisplayElement(video).innerTex

[webkit-changes] [103851] trunk

2011-12-30 Thread robert
Title: [103851] trunk








Revision 103851
Author rob...@webkit.org
Date 2011-12-30 12:58:29 -0800 (Fri, 30 Dec 2011)


Log Message
REGRESSION (r94492): Text is shifted to the right in some buttons in the Mac App Store
https://bugs.webkit.org/show_bug.cgi?id=74723

Reviewed by Dan Bernstein.

Source/WebCore:

Tests: fast/css/absolute-inline-alignment-2.html
   fast/css/absolute-inline-alignment.html

Inline positioned elements in the leading spaces of an inline run need to align to
adjacent text, so add them to the run as they're encountered.

* rendering/RenderBlockLineLayout.cpp:
(WebCore::LineInfo::LineInfo): Keep a count of positioned objects encountered when
 skipping leading whitespace.
(WebCore::LineInfo::runsFromLeadingWhitespace):
(WebCore::LineInfo::resetRunsFromLeadingWhitespace):
(WebCore::LineInfo::incrementRunsFromLeadingWhitespace):
(WebCore::RenderBlock::constructLine): Leading positioned objects should not be considered
 when deciding the number of runs in a line. Otherwise they would contribute towards line
 height themselves and prevent a free-standing BR following the positioned object from providing a full
 20px of height.
(WebCore::RenderBlock::layoutRunsAndFloatsInRange): Since a run containing line-breaks will enter
 skipLeadingWhitespace for each new line we reset the count every time so that the count of positioned
 objects we encounter only affects the line they appear on. This case is covered by
 fast/inline/styledEmptyInlinesWithBRs.html
(WebCore::RenderBlock::LineBreaker::skipLeadingWhitespace): Add a run for each inline positioned object
 encountered in leading white space. Keep a count of them so that they can be excluded from
 the total number of runs in constructLine.

LayoutTests:

* fast/css/absolute-inline-alignment-2-expected.html: Added.
* fast/css/absolute-inline-alignment-2.html: Added.
* fast/css/absolute-inline-alignment-expected.html: Added.
* fast/css/absolute-inline-alignment.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBlockLineLayout.cpp


Added Paths

trunk/LayoutTests/fast/css/absolute-inline-alignment-2-expected.html
trunk/LayoutTests/fast/css/absolute-inline-alignment-2.html
trunk/LayoutTests/fast/css/absolute-inline-alignment-expected.html
trunk/LayoutTests/fast/css/absolute-inline-alignment.html




Diff

Modified: trunk/LayoutTests/ChangeLog (103850 => 103851)

--- trunk/LayoutTests/ChangeLog	2011-12-30 20:53:28 UTC (rev 103850)
+++ trunk/LayoutTests/ChangeLog	2011-12-30 20:58:29 UTC (rev 103851)
@@ -1,3 +1,15 @@
+2011-12-30  Robert Hogan  
+
+REGRESSION (r94492): Text is shifted to the right in some buttons in the Mac App Store
+https://bugs.webkit.org/show_bug.cgi?id=74723
+
+Reviewed by Dan Bernstein.
+
+* fast/css/absolute-inline-alignment-2-expected.html: Added.
+* fast/css/absolute-inline-alignment-2.html: Added.
+* fast/css/absolute-inline-alignment-expected.html: Added.
+* fast/css/absolute-inline-alignment.html: Added.
+
 2011-12-30  Dale Curtis  
 
 media/video-scales-in-media-document.html is Chromium specific


Added: trunk/LayoutTests/fast/css/absolute-inline-alignment-2-expected.html (0 => 103851)

--- trunk/LayoutTests/fast/css/absolute-inline-alignment-2-expected.html	(rev 0)
+++ trunk/LayoutTests/fast/css/absolute-inline-alignment-2-expected.html	2011-12-30 20:58:29 UTC (rev 103851)
@@ -0,0 +1,25 @@
+
+
+body {
+height: 200%;
+}
+div {
+width: 400px;
+height: 25px;
+background-color: silver;
+text-align: center;
+margin: 8px 0;
+}
+#absolute {
+position: absolute;
+width: 25px;
+height: 25px;
+background-color: rgba(0, 0, 255, 0.5);
+}
+
+​Lorem ipsum dolor sit amet
+​Lorem ipsum dolor sit amet
+​Lorem ipsum dolor sit amet
+​Lorem ipsum dolor sit amet
+​Lorem ipsum dolor sit amet
+​Lorem ipsum dolor sit amet
Property changes on: trunk/LayoutTests/fast/css/absolute-inline-alignment-2-expected.html
___


Added: svn:eol-style

Added: trunk/LayoutTests/fast/css/absolute-inline-alignment-2.html (0 => 103851)

--- trunk/LayoutTests/fast/css/absolute-inline-alignment-2.html	(rev 0)
+++ trunk/LayoutTests/fast/css/absolute-inline-alignment-2.html	2011-12-30 20:58:29 UTC (rev 103851)
@@ -0,0 +1,25 @@
+
+
+body {
+height: 200%;
+}
+div {
+width: 400px;
+height: 25px;
+background-color: silver;
+text-align: center;
+margin: 8px 0;
+}
+#absolute {
+position: absolute;
+width: 25px;
+height: 25px;
+background-color: rgba(0, 0, 255, 0.5);
+}
+
+ Lorem ipsum dolor sit amet
+ Lorem ipsum dolor sit amet
+ Lorem ipsum dolor sit amet
+ Lorem ipsum dolor sit amet
+ Lorem ipsum dolor sit amet
+

[webkit-changes] [103850] trunk/LayoutTests

2011-12-30 Thread commit-queue
Title: [103850] trunk/LayoutTests








Revision 103850
Author commit-qu...@webkit.org
Date 2011-12-30 12:53:28 -0800 (Fri, 30 Dec 2011)


Log Message
media/video-scales-in-media-document.html is Chromium specific
https://bugs.webkit.org/show_bug.cgi?id=75079

Moves the test into platform/chromium/media and removes the Skipped
entry for gtk.

Patch by Dale Curtis  on 2011-12-30
Reviewed by Eric Carlson.

* platform/chromium/media/video-scales-in-media-document-expected.txt: Renamed from LayoutTests/media/video-scales-in-media-document-expected.txt.
* platform/chromium/media/video-scales-in-media-document.html: Renamed from LayoutTests/media/video-scales-in-media-document.html.
* platform/gtk/Skipped:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/Skipped


Added Paths

trunk/LayoutTests/platform/chromium/media/video-scales-in-media-document-expected.txt
trunk/LayoutTests/platform/chromium/media/video-scales-in-media-document.html


Removed Paths

trunk/LayoutTests/media/video-scales-in-media-document-expected.txt
trunk/LayoutTests/media/video-scales-in-media-document.html




Diff

Modified: trunk/LayoutTests/ChangeLog (103849 => 103850)

--- trunk/LayoutTests/ChangeLog	2011-12-30 20:40:08 UTC (rev 103849)
+++ trunk/LayoutTests/ChangeLog	2011-12-30 20:53:28 UTC (rev 103850)
@@ -1,3 +1,17 @@
+2011-12-30  Dale Curtis  
+
+media/video-scales-in-media-document.html is Chromium specific
+https://bugs.webkit.org/show_bug.cgi?id=75079
+
+Moves the test into platform/chromium/media and removes the Skipped
+entry for gtk.
+
+Reviewed by Eric Carlson.
+
+* platform/chromium/media/video-scales-in-media-document-expected.txt: Renamed from LayoutTests/media/video-scales-in-media-document-expected.txt.
+* platform/chromium/media/video-scales-in-media-document.html: Renamed from LayoutTests/media/video-scales-in-media-document.html.
+* platform/gtk/Skipped:
+
 2011-12-30  Andreas Kling  
 
 Cache and reuse the HTMLFormElement.elements collection.


Deleted: trunk/LayoutTests/media/video-scales-in-media-document-expected.txt (103849 => 103850)

--- trunk/LayoutTests/media/video-scales-in-media-document-expected.txt	2011-12-30 20:40:08 UTC (rev 103849)
+++ trunk/LayoutTests/media/video-scales-in-media-document-expected.txt	2011-12-30 20:53:28 UTC (rev 103850)
@@ -1,7 +0,0 @@
-Test that video media documents scale to fit undersized containers.
-
-
-EXPECTED (200 == '200') OK
-EXPECTED (163 == '163') OK
-END OF TEST
-


Deleted: trunk/LayoutTests/media/video-scales-in-media-document.html (103849 => 103850)

--- trunk/LayoutTests/media/video-scales-in-media-document.html	2011-12-30 20:40:08 UTC (rev 103849)
+++ trunk/LayoutTests/media/video-scales-in-media-document.html	2011-12-30 20:53:28 UTC (rev 103850)
@@ -1,32 +0,0 @@
-
-
-
-function canPlayThrough(event) {
-var video = event.target;
-testExpected(video.offsetWidth, 200);
-testExpected(video.offsetHeight, 163);
-endTest();
-}
-
-function iframeLoad() {
-var iframe = document.querySelector("iframe");
-var video = iframe.contentDocument.querySelector("video");
-video.addEventListener("canplaythrough", canPlayThrough);
-video.load()
-}
-
-function load() {
-var iframe = document.querySelector("iframe");
-iframe._onload_ = iframeLoad;
-iframe.src = "" "content/counting");
-}
-
-
-
-
-Test that video media documents scale to fit undersized containers.
-
-   
-


Copied: trunk/LayoutTests/platform/chromium/media/video-scales-in-media-document-expected.txt (from rev 103849, trunk/LayoutTests/media/video-scales-in-media-document-expected.txt) (0 => 103850)

--- trunk/LayoutTests/platform/chromium/media/video-scales-in-media-document-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/chromium/media/video-scales-in-media-document-expected.txt	2011-12-30 20:53:28 UTC (rev 103850)
@@ -0,0 +1,7 @@
+Test that video media documents scale to fit undersized containers.
+
+
+EXPECTED (200 == '200') OK
+EXPECTED (163 == '163') OK
+END OF TEST
+


Copied: trunk/LayoutTests/platform/chromium/media/video-scales-in-media-document.html (from rev 103849, trunk/LayoutTests/media/video-scales-in-media-document.html) (0 => 103850)

--- trunk/LayoutTests/platform/chromium/media/video-scales-in-media-document.html	(rev 0)
+++ trunk/LayoutTests/platform/chromium/media/video-scales-in-media-document.html	2011-12-30 20:53:28 UTC (rev 103850)
@@ -0,0 +1,32 @@
+
+
+
+function canPlayThrough(event) {
+var video = event.target;
+testExpected(video.offsetWidth, 200);
+testExpected(video.offsetHeight, 1

[webkit-changes] [103849] trunk/Source/WebCore

2011-12-30 Thread commit-queue
Title: [103849] trunk/Source/WebCore








Revision 103849
Author commit-qu...@webkit.org
Date 2011-12-30 12:40:08 -0800 (Fri, 30 Dec 2011)


Log Message
Remove unnecessary [Custom] attribute in CanvasRenderingContext2D.idl
https://bugs.webkit.org/show_bug.cgi?id=75376

Patch by Raymond Liu  on 2011-12-30
Reviewed by Adam Barth.

No new tests required.

* bindings/js/JSCanvasRenderingContext2DCustom.cpp:
* html/canvas/CanvasRenderingContext2D.idl:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/JSCanvasRenderingContext2DCustom.cpp
trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.idl




Diff

Modified: trunk/Source/WebCore/ChangeLog (103848 => 103849)

--- trunk/Source/WebCore/ChangeLog	2011-12-30 20:15:16 UTC (rev 103848)
+++ trunk/Source/WebCore/ChangeLog	2011-12-30 20:40:08 UTC (rev 103849)
@@ -1,3 +1,15 @@
+2011-12-30  Raymond Liu  
+
+Remove unnecessary [Custom] attribute in CanvasRenderingContext2D.idl
+https://bugs.webkit.org/show_bug.cgi?id=75376
+
+Reviewed by Adam Barth.
+
+No new tests required.
+
+* bindings/js/JSCanvasRenderingContext2DCustom.cpp:
+* html/canvas/CanvasRenderingContext2D.idl:
+
 2011-12-30  Andreas Kling  
 
 Cache and reuse the HTMLFormElement.elements collection.


Modified: trunk/Source/WebCore/bindings/js/JSCanvasRenderingContext2DCustom.cpp (103848 => 103849)

--- trunk/Source/WebCore/bindings/js/JSCanvasRenderingContext2DCustom.cpp	2011-12-30 20:15:16 UTC (rev 103848)
+++ trunk/Source/WebCore/bindings/js/JSCanvasRenderingContext2DCustom.cpp	2011-12-30 20:40:08 UTC (rev 103849)
@@ -91,55 +91,6 @@
 context->setFillStyle(toHTMLCanvasStyle(exec, value));
 }
 
-JSValue JSCanvasRenderingContext2D::createPattern(ExecState* exec)
-{ 
-CanvasRenderingContext2D* context = static_cast(impl());
-
-JSValue value = exec->argument(0);
-if (!value.isObject()) {
-setDOMException(exec, TYPE_MISMATCH_ERR);
-return jsUndefined();
-}
-JSObject* o = asObject(value);
-
-if (o->inherits(&JSHTMLImageElement::s_info)) {
-ExceptionCode ec;
-JSValue pattern = toJS(exec, globalObject(), 
-context->createPattern(static_cast(static_cast(o)->impl()),
-   valueToStringWithNullCheck(exec, exec->argument(1)), ec).get());
-setDOMException(exec, ec);
-return pattern;
-}
-if (o->inherits(&JSHTMLCanvasElement::s_info)) {
-ExceptionCode ec;
-JSValue pattern = toJS(exec, globalObject(), 
-context->createPattern(static_cast(static_cast(o)->impl()),
-valueToStringWithNullCheck(exec, exec->argument(1)), ec).get());
-setDOMException(exec, ec);
-return pattern;
-}
-setDOMException(exec, TYPE_MISMATCH_ERR);
-return jsUndefined();
-}
-
-JSValue JSCanvasRenderingContext2D::createImageData(ExecState* exec)
-{
-// createImageData has two variants
-// createImageData(ImageData)
-// createImageData(width, height)
-CanvasRenderingContext2D* context = static_cast(impl());
-RefPtr imageData = 0;
-
-ExceptionCode ec = 0;
-if (exec->argumentCount() == 1)
-imageData = context->createImageData(toImageData(exec->argument(0)), ec);
-else if (exec->argumentCount() == 2)
-imageData = context->createImageData(exec->argument(0).toFloat(exec), exec->argument(1).toFloat(exec), ec);
-
-setDOMException(exec, ec);
-return toJS(exec, globalObject(), WTF::getPtr(imageData));
-}
-
 JSValue JSCanvasRenderingContext2D::webkitLineDash(ExecState* exec) const
 {
 CanvasRenderingContext2D* context = static_cast(impl());


Modified: trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.idl (103848 => 103849)

--- trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.idl	2011-12-30 20:15:16 UTC (rev 103848)
+++ trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.idl	2011-12-30 20:40:08 UTC (rev 103849)
@@ -207,7 +207,6 @@
 void putImageData(in ImageData imagedata, in float dx, in float dy, in float dirtyX, in float dirtyY, in float dirtyWidth, in float dirtyHeight)
 raises(DOMException);
 
-#if defined(V8_BINDING) && V8_BINDING
 CanvasPattern createPattern(in HTMLCanvasElement canvas, in [ConvertNullToNullString] DOMString repetitionType)
 raises (DOMException);
 CanvasPattern createPattern(in HTMLImageElement image, in [ConvertNullToNullString] DOMString repetitionType)
@@ -216,11 +215,6 @@
 raises (DOMException);
 ImageData createImageData(in float sw, in float sh)
 raises (DOMException);
-#else
-// FIXME: Remove 'else' once JSC supports overloads too.
-[Custom] void createPattern(/* 2 */);
-[Custom] ImageData createImageData(/* 3 */);
-#endif // defined(V8_BINDING)
 
 attribute [Custom] custom strokeStyle;
 attribute [Custom] custom fillStyle;






___

[webkit-changes] [103848] trunk

2011-12-30 Thread kling
Title: [103848] trunk








Revision 103848
Author kl...@webkit.org
Date 2011-12-30 12:15:16 -0800 (Fri, 30 Dec 2011)


Log Message
Cache and reuse the HTMLFormElement.elements collection.


Reviewed by Anders Carlsson.

Source/WebCore: 

Let HTMLFormElement::elements() cache the returned collection and tie it to the
lifetime of the form. This reduces memory consumption by ~70 kB (on 64-bit) when
viewing your average popular post on reddit.com.

Test: fast/dom/form-elements-collection-idempotence.html
  fast/dom/gc-9.html

* html/HTMLFormElement.h:
* html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::elements):

Cache the HTMLFormCollection returned by elements() on the HTMLFormElement.
Remove the per-form CollectionCache and let the collection manage that.

* html/HTMLCollection.h:
* html/HTMLCollection.cpp:
(WebCore::HTMLCollection::HTMLCollection):
(WebCore::HTMLCollection::create):

Have the HTMLCollection constructor take a bool argument that decides whether
we retain the base node pointer or not. This mechanism is a temporary measure
until all collection types are owned by their respective base nodes.

* html/HTMLFormCollection.h:
* html/HTMLFormCollection.cpp:
(WebCore::HTMLFormCollection::HTMLFormCollection):
(WebCore::HTMLFormCollection::create):

Tell the base class constructor to not retain the back-pointer to the form.

LayoutTests: 

- Update gc-9.html to document the new lifetime characteristics of HTMLFormElement.elements.
- Add a test to verify that HTMLFormElement.elements returns the same object when called repeatedly.

* fast/dom/form-elements-collection-idempotence-expected.txt: Added.
* fast/dom/form-elements-collection-idempotence.html: Added.
* fast/dom/gc-9-expected.txt:
* fast/dom/gc-9.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/dom/gc-9-expected.txt
trunk/LayoutTests/fast/dom/gc-9.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLCollection.cpp
trunk/Source/WebCore/html/HTMLCollection.h
trunk/Source/WebCore/html/HTMLFormCollection.cpp
trunk/Source/WebCore/html/HTMLFormCollection.h
trunk/Source/WebCore/html/HTMLFormElement.cpp
trunk/Source/WebCore/html/HTMLFormElement.h


Added Paths

trunk/LayoutTests/fast/dom/form-elements-collection-idempotence-expected.txt
trunk/LayoutTests/fast/dom/form-elements-collection-idempotence.html




Diff

Modified: trunk/LayoutTests/ChangeLog (103847 => 103848)

--- trunk/LayoutTests/ChangeLog	2011-12-30 19:08:03 UTC (rev 103847)
+++ trunk/LayoutTests/ChangeLog	2011-12-30 20:15:16 UTC (rev 103848)
@@ -1,5 +1,20 @@
 2011-12-30  Andreas Kling  
 
+Cache and reuse the HTMLFormElement.elements collection.
+
+
+Reviewed by Anders Carlsson.
+
+- Update gc-9.html to document the new lifetime characteristics of HTMLFormElement.elements.
+- Add a test to verify that HTMLFormElement.elements returns the same object when called repeatedly.
+
+* fast/dom/form-elements-collection-idempotence-expected.txt: Added.
+* fast/dom/form-elements-collection-idempotence.html: Added.
+* fast/dom/gc-9-expected.txt:
+* fast/dom/gc-9.html:
+
+2011-12-30  Andreas Kling  
+
 WebKitCSSKeyframeRule.style.parentRule should point to the keyframe rule.
 
 


Added: trunk/LayoutTests/fast/dom/form-elements-collection-idempotence-expected.txt (0 => 103848)

--- trunk/LayoutTests/fast/dom/form-elements-collection-idempotence-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/dom/form-elements-collection-idempotence-expected.txt	2011-12-30 20:15:16 UTC (rev 103848)
@@ -0,0 +1,11 @@
+This test verifies that HTMLFormElement.elements returns the same collection when called repeatedly.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS formElement.elements is formElement.elements
+PASS formElement.elements === formElement.elements is true
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: trunk/LayoutTests/fast/dom/form-elements-collection-idempotence.html (0 => 103848)

--- trunk/LayoutTests/fast/dom/form-elements-collection-idempotence.html	(rev 0)
+++ trunk/LayoutTests/fast/dom/form-elements-collection-idempotence.html	2011-12-30 20:15:16 UTC (rev 103848)
@@ -0,0 +1,20 @@
+
+
+
+
+
+
+