[webkit-changes] [104269] trunk
Title: [104269] trunk
Revision 104269
Author m...@apple.com
Date 2012-01-05 22:41:04 -0800 (Thu, 05 Jan 2012)
Log Message
Update copyright strings
Reviewed by Mark Rowe.
Source/_javascript_Core:
* Info.plist:
Source/_javascript_Glue:
* Info.plist:
Source/WebCore:
* Info.plist:
Source/WebKit/mac:
* Info.plist:
Source/WebKit2:
* Info.plist:
* PluginProcess/Info.plist:
* WebProcess/Info.plist:
WebKitLibraries:
* win/tools/scripts/COPYRIGHT-END-YEAR:
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/Info.plist
trunk/Source/_javascript_Glue/ChangeLog
trunk/Source/_javascript_Glue/Info.plist
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Info.plist
trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/Info.plist
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Info.plist
trunk/Source/WebKit2/PluginProcess/Info.plist
trunk/Source/WebKit2/WebProcess/Info.plist
trunk/WebKitLibraries/ChangeLog
trunk/WebKitLibraries/win/tools/scripts/COPYRIGHT-END-YEAR
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (104268 => 104269)
--- trunk/Source/_javascript_Core/ChangeLog 2012-01-06 05:36:37 UTC (rev 104268)
+++ trunk/Source/_javascript_Core/ChangeLog 2012-01-06 06:41:04 UTC (rev 104269)
@@ -1,3 +1,11 @@
+2012-01-05 Dan Bernstein
+
+ Update copyright strings
+
+Reviewed by Mark Rowe.
+
+* Info.plist:
+
2012-01-05 Gavin Barraclough
Date constructor handles infinite values incorrectly.
Modified: trunk/Source/_javascript_Core/Info.plist (104268 => 104269)
--- trunk/Source/_javascript_Core/Info.plist 2012-01-06 05:36:37 UTC (rev 104268)
+++ trunk/Source/_javascript_Core/Info.plist 2012-01-06 06:41:04 UTC (rev 104269)
@@ -7,7 +7,7 @@
CFBundleExecutable
${PRODUCT_NAME}
CFBundleGetInfoString
- ${BUNDLE_VERSION}, Copyright 2003-2011 Apple Inc.; Copyright 1999-2001 Harri Porten ; Copyright 2001 Peter Kelly ; Copyright 1997-2005 University of Cambridge; Copyright 1991, 2000, 2001 by Lucent Technologies.
+ ${BUNDLE_VERSION}, Copyright 2003-2012 Apple Inc.; Copyright 1999-2001 Harri Porten ; Copyright 2001 Peter Kelly ; Copyright 1997-2005 University of Cambridge; Copyright 1991, 2000, 2001 by Lucent Technologies.
CFBundleIdentifier
com.apple.${PRODUCT_NAME}
CFBundleInfoDictionaryVersion
Modified: trunk/Source/_javascript_Glue/ChangeLog (104268 => 104269)
--- trunk/Source/_javascript_Glue/ChangeLog 2012-01-06 05:36:37 UTC (rev 104268)
+++ trunk/Source/_javascript_Glue/ChangeLog 2012-01-06 06:41:04 UTC (rev 104269)
@@ -1,3 +1,11 @@
+2012-01-05 Dan Bernstein
+
+ Update copyright strings
+
+Reviewed by Mark Rowe.
+
+* Info.plist:
+
2012-01-05 Benjamin Poulain
Improve charactersAreAllASCII() to compare multiple characters at a time
Modified: trunk/Source/_javascript_Glue/Info.plist (104268 => 104269)
--- trunk/Source/_javascript_Glue/Info.plist 2012-01-06 05:36:37 UTC (rev 104268)
+++ trunk/Source/_javascript_Glue/Info.plist 2012-01-06 06:41:04 UTC (rev 104269)
@@ -7,7 +7,7 @@
CFBundleExecutable
${PRODUCT_NAME}
CFBundleGetInfoString
- ${BUNDLE_VERSION}, Copyright 2003-2011 Apple Inc.
+ ${BUNDLE_VERSION}, Copyright 2003-2012 Apple Inc.
CFBundleIdentifier
com.apple.${PRODUCT_NAME}
CFBundleInfoDictionaryVersion
Modified: trunk/Source/WebCore/ChangeLog (104268 => 104269)
--- trunk/Source/WebCore/ChangeLog 2012-01-06 05:36:37 UTC (rev 104268)
+++ trunk/Source/WebCore/ChangeLog 2012-01-06 06:41:04 UTC (rev 104269)
@@ -1,3 +1,11 @@
+2012-01-05 Dan Bernstein
+
+ Update copyright strings
+
+Reviewed by Mark Rowe.
+
+* Info.plist:
+
2012-01-05 Alexis Menard
Move HTMLFormControlElementWithState class in its own header file.
Modified: trunk/Source/WebCore/Info.plist (104268 => 104269)
--- trunk/Source/WebCore/Info.plist 2012-01-06 05:36:37 UTC (rev 104268)
+++ trunk/Source/WebCore/Info.plist 2012-01-06 06:41:04 UTC (rev 104269)
@@ -7,7 +7,7 @@
CFBundleExecutable
${PRODUCT_NAME}
CFBundleGetInfoString
- ${BUNDLE_VERSION}, Copyright 2003-2011 Apple Inc.; Copyright 1997 Martin Jones ; Copyright 1998, 1999 Torben Weis ; Copyright 1998, 1999, 2002 Waldo Bastian ; Copyright 1998-2000 Lars Knoll ; Copyright 1999, 2001 Antti Koivisto ; Copyright 1999-2001 Harri Porten ; Copyright 2000 Simon Hausmann ; Copyright 2000, 2001 Dirk Mueller ; Copyright 2000, 2001 Peter Kelly ; Copyright 2000 Daniel Molkentin ; Copyright 2000 Stefan Schimanski ; Copyright 1998-2000 Netscape Communications Corporation; Copyright 1998, 1999, 2000 Thai Open Source Software Center Ltd and Clark Cooper; Copyright 2001, 2002 Expat maintainers.+ ${BUNDLE_VERSION}, Copyright 2003-2012 Apple Inc.; C
[webkit-changes] [104268] trunk/Source/WebCore
Title: [104268] trunk/Source/WebCore Revision 104268 Author alexis.men...@openbossa.org Date 2012-01-05 21:36:37 -0800 (Thu, 05 Jan 2012) Log Message Move HTMLFormControlElementWithState class in its own header file. https://bugs.webkit.org/show_bug.cgi?id=75482 Reviewed by Kent Tamura. Move HTMLFormControlElementWithState class which was mixed in HTMLFormControlElement files into its own header file and its own implementation file. No new tests : the existing ones should cover the refactoring. * CMakeLists.txt: * GNUmakefile.list.am: * Target.pri: * WebCore.gypi: * WebCore.vcproj/WebCore.vcproj: * WebCore.xcodeproj/project.pbxproj: * html/HTMLElementsAllInOne.cpp: * html/HTMLFormControlElement.cpp: * html/HTMLFormControlElement.h: * html/HTMLKeygenElement.h: * html/HTMLSelectElement.h: * html/HTMLTextFormControlElement.h: Modified Paths trunk/Source/WebCore/CMakeLists.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/GNUmakefile.list.am trunk/Source/WebCore/Target.pri trunk/Source/WebCore/WebCore.gypi trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj trunk/Source/WebCore/html/HTMLElementsAllInOne.cpp trunk/Source/WebCore/html/HTMLFormControlElement.cpp trunk/Source/WebCore/html/HTMLFormControlElement.h trunk/Source/WebCore/html/HTMLKeygenElement.h trunk/Source/WebCore/html/HTMLSelectElement.h trunk/Source/WebCore/html/HTMLTextFormControlElement.h Added Paths trunk/Source/WebCore/html/HTMLFormControlElementWithState.cpp trunk/Source/WebCore/html/HTMLFormControlElementWithState.h Diff Modified: trunk/Source/WebCore/CMakeLists.txt (104267 => 104268) --- trunk/Source/WebCore/CMakeLists.txt 2012-01-06 05:29:28 UTC (rev 104267) +++ trunk/Source/WebCore/CMakeLists.txt 2012-01-06 05:36:37 UTC (rev 104268) @@ -740,6 +740,7 @@ html/HTMLFontElement.cpp html/HTMLFormCollection.cpp html/HTMLFormControlElement.cpp +html/HTMLFormControlElementWithState.cpp html/HTMLFormElement.cpp html/HTMLFrameElement.cpp html/HTMLFrameElementBase.cpp Modified: trunk/Source/WebCore/ChangeLog (104267 => 104268) --- trunk/Source/WebCore/ChangeLog 2012-01-06 05:29:28 UTC (rev 104267) +++ trunk/Source/WebCore/ChangeLog 2012-01-06 05:36:37 UTC (rev 104268) @@ -1,3 +1,28 @@ +2012-01-05 Alexis Menard + +Move HTMLFormControlElementWithState class in its own header file. +https://bugs.webkit.org/show_bug.cgi?id=75482 + +Reviewed by Kent Tamura. + +Move HTMLFormControlElementWithState class which was mixed in HTMLFormControlElement +files into its own header file and its own implementation file. + +No new tests : the existing ones should cover the refactoring. + +* CMakeLists.txt: +* GNUmakefile.list.am: +* Target.pri: +* WebCore.gypi: +* WebCore.vcproj/WebCore.vcproj: +* WebCore.xcodeproj/project.pbxproj: +* html/HTMLElementsAllInOne.cpp: +* html/HTMLFormControlElement.cpp: +* html/HTMLFormControlElement.h: +* html/HTMLKeygenElement.h: +* html/HTMLSelectElement.h: +* html/HTMLTextFormControlElement.h: + 2012-01-05 Wei James Optimize with memcpy instead of copying frame by frame in Realtimeanalyser::doFFTAnalysis Modified: trunk/Source/WebCore/GNUmakefile.list.am (104267 => 104268) --- trunk/Source/WebCore/GNUmakefile.list.am 2012-01-06 05:29:28 UTC (rev 104267) +++ trunk/Source/WebCore/GNUmakefile.list.am 2012-01-06 05:36:37 UTC (rev 104268) @@ -2020,6 +2020,8 @@ Source/WebCore/html/HTMLFormCollection.h \ Source/WebCore/html/HTMLFormControlElement.cpp \ Source/WebCore/html/HTMLFormControlElement.h \ + Source/WebCore/html/HTMLFormControlElementWithState.cpp \ + Source/WebCore/html/HTMLFormControlElementWithState.h \ Source/WebCore/html/HTMLFormElement.cpp \ Source/WebCore/html/HTMLFormElement.h \ Source/WebCore/html/HTMLFrameElementBase.cpp \ Modified: trunk/Source/WebCore/Target.pri (104267 => 104268) --- trunk/Source/WebCore/Target.pri 2012-01-06 05:29:28 UTC (rev 104267) +++ trunk/Source/WebCore/Target.pri 2012-01-06 05:36:37 UTC (rev 104268) @@ -725,6 +725,7 @@ html/HTMLFontElement.cpp \ html/HTMLFormCollection.cpp \ html/HTMLFormControlElement.cpp \ +html/HTMLFormControlElementWithState.cpp \ html/HTMLFormElement.cpp \ html/HTMLFrameElement.cpp \ html/HTMLFrameElementBase.cpp \ @@ -1795,6 +1796,7 @@ html/HTMLFontElement.h \ html/HTMLFormCollection.h \ html/HTMLFormControlElement.h \ +html/HTMLFormControlElementWithState.h \ html/HTMLFormElement.h \ html/HTMLFrameElementBase.h \ html/HTMLFrameElement.h \ Modified: trunk/Source/WebCore/WebCore.gypi (104267 => 104268) --- trunk/Source/WebCore/WebCore.gypi 2012-01-06 05:29:28 UTC (rev 104267) +++ trunk/Source/WebCore/WebCore.gypi 2012-01-06 05:36:37 UTC (rev 104268) @@ -1065,6 +1065,7 @@ 'html/HTMLDocument.h',
[webkit-changes] [104267] trunk
Title: [104267] trunk
Revision 104267
Author barraclo...@apple.com
Date 2012-01-05 21:29:28 -0800 (Thu, 05 Jan 2012)
Log Message
Date constructor handles infinite values incorrectly.
https://bugs.webkit.org/show_bug.cgi?id=70998
Reviewed by Filip Pizlo.
Source/_javascript_Core:
* runtime/DateConstructor.cpp:
(JSC::constructDate):
- should be checking !finite rather then isnan.
LayoutTests:
* fast/js/date-constructor-expected.txt:
* fast/js/script-tests/date-constructor.js:
- Added test cases.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/js/date-constructor-expected.txt
trunk/LayoutTests/fast/js/script-tests/date-constructor.js
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/DateConstructor.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (104266 => 104267)
--- trunk/LayoutTests/ChangeLog 2012-01-06 04:48:14 UTC (rev 104266)
+++ trunk/LayoutTests/ChangeLog 2012-01-06 05:29:28 UTC (rev 104267)
@@ -1,5 +1,16 @@
2012-01-05 Gavin Barraclough
+Date constructor handles infinite values incorrectly.
+https://bugs.webkit.org/show_bug.cgi?id=70998
+
+Reviewed by Filip Pizlo.
+
+* fast/js/date-constructor-expected.txt:
+* fast/js/script-tests/date-constructor.js:
+- Added test cases.
+
+2012-01-05 Gavin Barraclough
+
date.toISOString produces incorrect results for dates with ms prior to 1970
https://bugs.webkit.org/show_bug.cgi?id=75684
Modified: trunk/LayoutTests/fast/js/date-constructor-expected.txt (104266 => 104267)
--- trunk/LayoutTests/fast/js/date-constructor-expected.txt 2012-01-06 04:48:14 UTC (rev 104266)
+++ trunk/LayoutTests/fast/js/date-constructor-expected.txt 2012-01-06 05:29:28 UTC (rev 104267)
@@ -24,6 +24,14 @@
PASS new Date(new Date(, 1, 1, 1, 1, 1, 1)).getTime() - timeZoneOffset is -27104799538999
PASS new Date(new Date(, 1, 1, 1, 1, 1, 1, 1)).getTime() - timeZoneOffset is -27104799538999
PASS new Date(new Date(, 1, 1, 1, 1, 1, 1, 1, 1)).getTime() - timeZoneOffset is -27104799538999
+PASS Number(new Date(new Date(Infinity, 1, 1, 1, 1, 1, 1, 1, 1))) is Number.NaN
+PASS Number(new Date(new Date(1, Infinity, 1, 1, 1, 1, 1, 1, 1))) is Number.NaN
+PASS Number(new Date(new Date(1, 1, Infinity, 1, 1, 1, 1, 1, 1))) is Number.NaN
+PASS Number(new Date(new Date(1, 1, 1, Infinity, 1, 1, 1, 1, 1))) is Number.NaN
+PASS Number(new Date(new Date(1, 1, 1, 1, Infinity, 1, 1, 1, 1))) is Number.NaN
+PASS Number(new Date(new Date(1, 1, 1, 1, 1, Infinity, 1, 1, 1))) is Number.NaN
+PASS Number(new Date(new Date(1, 1, 1, 1, 1, 1, Infinity, 1, 1))) is Number.NaN
+PASS Number(new Date(new Date(1, 1, 1, 1, 1, 1, 1, 1, Infinity))) is -2174741938999
PASS testStr is "1234567"
PASS testStr is "1234567"
PASS successfullyParsed is true
Modified: trunk/LayoutTests/fast/js/script-tests/date-constructor.js (104266 => 104267)
--- trunk/LayoutTests/fast/js/script-tests/date-constructor.js 2012-01-06 04:48:14 UTC (rev 104266)
+++ trunk/LayoutTests/fast/js/script-tests/date-constructor.js 2012-01-06 05:29:28 UTC (rev 104267)
@@ -35,6 +35,15 @@
shouldBe('new Date(new Date(, 1, 1, 1, 1, 1, 1, 1)).getTime() - timeZoneOffset', '-27104799538999');
shouldBe('new Date(new Date(, 1, 1, 1, 1, 1, 1, 1, 1)).getTime() - timeZoneOffset', '-27104799538999');
+shouldBe("Number(new Date(new Date(Infinity, 1, 1, 1, 1, 1, 1, 1, 1)))", 'Number.NaN');
+shouldBe("Number(new Date(new Date(1, Infinity, 1, 1, 1, 1, 1, 1, 1)))", 'Number.NaN');
+shouldBe("Number(new Date(new Date(1, 1, Infinity, 1, 1, 1, 1, 1, 1)))", 'Number.NaN');
+shouldBe("Number(new Date(new Date(1, 1, 1, Infinity, 1, 1, 1, 1, 1)))", 'Number.NaN');
+shouldBe("Number(new Date(new Date(1, 1, 1, 1, Infinity, 1, 1, 1, 1)))", 'Number.NaN');
+shouldBe("Number(new Date(new Date(1, 1, 1, 1, 1, Infinity, 1, 1, 1)))", 'Number.NaN');
+shouldBe("Number(new Date(new Date(1, 1, 1, 1, 1, 1, Infinity, 1, 1)))", 'Number.NaN');
+shouldBe("Number(new Date(new Date(1, 1, 1, 1, 1, 1, 1, 1, Infinity)))", '-2174741938999');
+
// In Firefox, the results of the following tests are timezone-dependent, which likely implies that the implementation is not quite correct.
// Our results are even worse, though, as the dates are clipped: (new Date(, 1201).getTime()) == (new Date(, 601).getTime())
// shouldBe('new Date(, , , , , , , ).getTime() - timeZoneOffset', '-24085894227889');
Modified: trunk/Source/_javascript_Core/ChangeLog (104266 => 104267)
--- trunk/Source/_javascript_Core/ChangeLog 2012-01-06 04:48:14 UTC (rev 104266)
+++ trunk/Source/_javascript_Core/ChangeLog 2012-01-06 05:29:28 UTC (rev 104267)
@@ -1,5 +1,16 @@
2012-01-05 Gavin Barraclough
+Date constructor handles infinite values incorrectly.
+https://bugs.webkit.org/show_bug.cgi?id=70998
+
+Reviewed by Filip Pizlo.
+
+* runtime/DateConstructor.cpp:
+(JSC::constructDate):
+
[webkit-changes] [104266] trunk
Title: [104266] trunk
Revision 104266
Author barraclo...@apple.com
Date 2012-01-05 20:48:14 -0800 (Thu, 05 Jan 2012)
Log Message
date.toISOString produces incorrect results for dates with ms prior to 1970
https://bugs.webkit.org/show_bug.cgi?id=75684
Reviewed by Sam Weinig.
Source/_javascript_Core:
* runtime/DatePrototype.cpp:
(JSC::dateProtoFuncToISOString):
LayoutTests:
* fast/js/date-toisostring-expected.txt:
* fast/js/script-tests/date-toisostring.js:
- Added test case
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/js/date-toisostring-expected.txt
trunk/LayoutTests/fast/js/script-tests/date-toisostring.js
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/DatePrototype.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (104265 => 104266)
--- trunk/LayoutTests/ChangeLog 2012-01-06 04:01:23 UTC (rev 104265)
+++ trunk/LayoutTests/ChangeLog 2012-01-06 04:48:14 UTC (rev 104266)
@@ -1,3 +1,14 @@
+2012-01-05 Gavin Barraclough
+
+date.toISOString produces incorrect results for dates with ms prior to 1970
+https://bugs.webkit.org/show_bug.cgi?id=75684
+
+Reviewed by Sam Weinig.
+
+* fast/js/date-toisostring-expected.txt:
+* fast/js/script-tests/date-toisostring.js:
+- Added test case
+
2012-01-05 Ojan Vafai
More chromium expected results after r104208.
Modified: trunk/LayoutTests/fast/js/date-toisostring-expected.txt (104265 => 104266)
--- trunk/LayoutTests/fast/js/date-toisostring-expected.txt 2012-01-06 04:01:23 UTC (rev 104265)
+++ trunk/LayoutTests/fast/js/date-toisostring-expected.txt 2012-01-06 04:48:14 UTC (rev 104266)
@@ -5,6 +5,7 @@
PASS Date.toISOString.call({}) threw exception TypeError: 'undefined' is not an object (evaluating 'Date.toISOString.call').
PASS Date.toISOString.call(0) threw exception TypeError: 'undefined' is not an object (evaluating 'Date.toISOString.call').
+PASS new Date(-400).toISOString() is '1969-12-31T23:59:59.600Z'
PASS new Date(0).toISOString() is '1970-01-01T00:00:00.000Z'
PASS new Date('1 January 1500 UTC').toISOString() is '1500-01-01T00:00:00.000Z'
PASS new Date('1 January 2000 UTC').toISOString() is '2000-01-01T00:00:00.000Z'
Modified: trunk/LayoutTests/fast/js/script-tests/date-toisostring.js (104265 => 104266)
--- trunk/LayoutTests/fast/js/script-tests/date-toisostring.js 2012-01-06 04:01:23 UTC (rev 104265)
+++ trunk/LayoutTests/fast/js/script-tests/date-toisostring.js 2012-01-06 04:48:14 UTC (rev 104266)
@@ -13,6 +13,7 @@
shouldThrow("Date.toISOString.call({})");
shouldThrow("Date.toISOString.call(0)");
+shouldBe("new Date(-400).toISOString()", "'1969-12-31T23:59:59.600Z'");
shouldBe("new Date(0).toISOString()", "'1970-01-01T00:00:00.000Z'");
shouldBe("new Date('1 January 1500 UTC').toISOString()", "'1500-01-01T00:00:00.000Z'");
shouldBe("new Date('1 January 2000 UTC').toISOString()", "'2000-01-01T00:00:00.000Z'");
Modified: trunk/Source/_javascript_Core/ChangeLog (104265 => 104266)
--- trunk/Source/_javascript_Core/ChangeLog 2012-01-06 04:01:23 UTC (rev 104265)
+++ trunk/Source/_javascript_Core/ChangeLog 2012-01-06 04:48:14 UTC (rev 104266)
@@ -1,5 +1,15 @@
2012-01-05 Gavin Barraclough
+date.toISOString produces incorrect results for dates with ms prior to 1970
+https://bugs.webkit.org/show_bug.cgi?id=75684
+
+Reviewed by Sam Weinig.
+
+* runtime/DatePrototype.cpp:
+(JSC::dateProtoFuncToISOString):
+
+2012-01-05 Gavin Barraclough
+
Array.prototype.lastIndexOf ignores undefined fromIndex.
https://bugs.webkit.org/show_bug.cgi?id=75678
Modified: trunk/Source/_javascript_Core/runtime/DatePrototype.cpp (104265 => 104266)
--- trunk/Source/_javascript_Core/runtime/DatePrototype.cpp 2012-01-06 04:01:23 UTC (rev 104265)
+++ trunk/Source/_javascript_Core/runtime/DatePrototype.cpp 2012-01-06 04:48:14 UTC (rev 104266)
@@ -508,10 +508,13 @@
// 6 for formatting and one for null termination = 28. We add one extra character to allow us to force null termination.
char buffer[29];
// If the year is outside the bounds of 0 and inclusive we want to use the extended year format (ES 15.9.1.15.1).
+int ms = static_cast(fmod(thisDateObj->internalNumber(), msPerSecond));
+if (ms < 0)
+ms += msPerSecond;
if (gregorianDateTime->year > 8099 || gregorianDateTime->year < -1900)
-snprintf(buffer, sizeof(buffer) - 1, "%+07d-%02d-%02dT%02d:%02d:%02d.%03dZ", 1900 + gregorianDateTime->year, gregorianDateTime->month + 1, gregorianDateTime->monthDay, gregorianDateTime->hour, gregorianDateTime->minute, gregorianDateTime->second, static_cast(fmod(thisDateObj->internalNumber(), 1000)));
+snprintf(buffer, sizeof(buffer) - 1, "%+07d-%02d-%02dT%02d:%02d:%02d.%03dZ", 1900 + gregorianDateTime->year, gregorianDateTime->month + 1, gregorianDateTime->monthDay, gregorianDateTime->hour, gregorianDateTime->minute, gregorianDateT
[webkit-changes] [104265] trunk/Source/WebCore
Title: [104265] trunk/Source/WebCore
Revision 104265
Author commit-qu...@webkit.org
Date 2012-01-05 20:01:23 -0800 (Thu, 05 Jan 2012)
Log Message
Optimize with memcpy instead of copying frame by frame in Realtimeanalyser::doFFTAnalysis
https://bugs.webkit.org/show_bug.cgi?id=74693
Patch by Wei James on 2012-01-05
Reviewed by Kenneth Russell.
* webaudio/RealtimeAnalyser.cpp:
(WebCore::RealtimeAnalyser::doFFTAnalysis):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/webaudio/RealtimeAnalyser.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (104264 => 104265)
--- trunk/Source/WebCore/ChangeLog 2012-01-06 03:20:50 UTC (rev 104264)
+++ trunk/Source/WebCore/ChangeLog 2012-01-06 04:01:23 UTC (rev 104265)
@@ -1,3 +1,13 @@
+2012-01-05 Wei James
+
+Optimize with memcpy instead of copying frame by frame in Realtimeanalyser::doFFTAnalysis
+https://bugs.webkit.org/show_bug.cgi?id=74693
+
+Reviewed by Kenneth Russell.
+
+* webaudio/RealtimeAnalyser.cpp:
+(WebCore::RealtimeAnalyser::doFFTAnalysis):
+
2012-01-05 Ryosuke Niwa
REGRESSION(r104210): Dromaeo DOM test score is lower
Modified: trunk/Source/WebCore/webaudio/RealtimeAnalyser.cpp (104264 => 104265)
--- trunk/Source/WebCore/webaudio/RealtimeAnalyser.cpp 2012-01-06 03:20:50 UTC (rev 104264)
+++ trunk/Source/WebCore/webaudio/RealtimeAnalyser.cpp 2012-01-06 04:01:23 UTC (rev 104265)
@@ -157,10 +157,13 @@
float* tempP = temporaryBuffer.data();
// Take the previous fftSize values from the input buffer and copy into the temporary buffer.
-// FIXME : optimize with memcpy().
unsigned writeIndex = m_writeIndex;
-for (unsigned i = 0; i < fftSize; ++i)
-tempP[i] = inputBuffer[(i + writeIndex - fftSize + InputBufferSize) % InputBufferSize];
+if (writeIndex < fftSize) {
+memcpy(tempP, inputBuffer + writeIndex - fftSize + InputBufferSize, sizeof(*tempP) * (fftSize - writeIndex));
+memcpy(tempP + fftSize - writeIndex, inputBuffer, sizeof(*tempP) * writeIndex);
+} else
+memcpy(tempP, inputBuffer + writeIndex - fftSize, sizeof(*tempP) * fftSize);
+
// Window the input samples.
applyWindow(tempP, fftSize);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104264] trunk/Tools
Title: [104264] trunk/Tools
Revision 104264
Author joc...@chromium.org
Date 2012-01-05 19:20:50 -0800 (Thu, 05 Jan 2012)
Log Message
Don't hardcode expected file URIs in as they depend on the platform
https://bugs.webkit.org/show_bug.cgi?id=75666
Reviewed by Dirk Pranke.
* Scripts/webkitpy/layout_tests/port/win.py:
(WinPort.show_results_html_file):
* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(MainTest.test_unexpected_failures):
(MainTest.test_results_directory_default):
(MainTest.test_results_directory_relative):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/port/win.py
trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py
Diff
Modified: trunk/Tools/ChangeLog (104263 => 104264)
--- trunk/Tools/ChangeLog 2012-01-06 03:14:05 UTC (rev 104263)
+++ trunk/Tools/ChangeLog 2012-01-06 03:20:50 UTC (rev 104264)
@@ -1,3 +1,17 @@
+2012-01-05 Jochen Eisinger
+
+Don't hardcode expected file URIs in as they depend on the platform
+https://bugs.webkit.org/show_bug.cgi?id=75666
+
+Reviewed by Dirk Pranke.
+
+* Scripts/webkitpy/layout_tests/port/win.py:
+(WinPort.show_results_html_file):
+* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
+(MainTest.test_unexpected_failures):
+(MainTest.test_results_directory_default):
+(MainTest.test_results_directory_relative):
+
2012-01-05 Anders Carlsson
Crash when trying to invalidate the NPRuntimeObjectMap for a plug-in in a subframe
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/win.py (104263 => 104264)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/win.py 2012-01-06 03:14:05 UTC (rev 104263)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/win.py 2012-01-06 03:20:50 UTC (rev 104264)
@@ -31,7 +31,7 @@
import sys
from webkitpy.common.system.executive import ScriptError
-from webkitpy.common.system.path import cygpath
+from webkitpy.common.system.path import abspath_to_uri
from webkitpy.layout_tests.port.apple import ApplePort
@@ -109,7 +109,7 @@
return 'win'
def show_results_html_file(self, results_filename):
-self._run_script('run-safari', [cygpath(results_filename)])
+self._run_script('run-safari', [abspath_to_uri(results_filename)])
# FIXME: webkitperl/httpd.pm installs /usr/lib/apache/libphp4.dll on cycwin automatically
# as part of running old-run-webkit-tests. That's bad design, but we may need some similar hack.
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py (104263 => 104264)
--- trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py 2012-01-06 03:14:05 UTC (rev 104263)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py 2012-01-06 03:20:50 UTC (rev 104264)
@@ -433,7 +433,7 @@
self.assertEqual(res, unexpected_tests_count)
self.assertFalse(out.empty())
self.assertFalse(err.empty())
-self.assertEqual(user.opened_urls, ['file:///tmp/layout-test-results/results.html'])
+self.assertEqual(user.opened_urls, [path.abspath_to_uri('/tmp/layout-test-results/results.html')])
def test_missing_and_unexpected_results(self):
# Test that we update expectations in place. If the expectation
@@ -614,7 +614,7 @@
# This is the default location.
res, out, err, user = logging_run(tests_included=True)
-self.assertEqual(user.opened_urls, ['file:///tmp/layout-test-results/results.html'])
+self.assertEqual(user.opened_urls, [path.abspath_to_uri('/tmp/layout-test-results/results.html')])
def test_results_directory_relative(self):
# We run a configuration that should fail, to generate output, then
@@ -624,7 +624,7 @@
host.filesystem.chdir('/tmp/cwd')
res, out, err, user = logging_run(['--results-directory=foo'],
tests_included=True, host=host)
-self.assertEqual(user.opened_urls, ['file:///tmp/cwd/foo/results.html'])
+self.assertEqual(user.opened_urls, [path.abspath_to_uri('/tmp/cwd/foo/results.html')])
def test_retries_directory(self):
host = MockHost()
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104263] trunk/Source/WebCore
Title: [104263] trunk/Source/WebCore
Revision 104263
Author rn...@webkit.org
Date 2012-01-05 19:14:05 -0800 (Thu, 05 Jan 2012)
Log Message
REGRESSION(r104210): Dromaeo DOM test score is lower
https://bugs.webkit.org/show_bug.cgi?id=75679
Reviewed by Andreas Kling.
The regression was caused by isDomVersionConsistent not being able to obtain the tree version
inside isLengthCacheValid when m_cachedItem is null. Fix the regression by always setting
m_cachedItem to some node when caching the length so that we can obtain the tree version later.
Also address Antti's review comment to fit m_cachedLength, m_isLengthCacheValid, and
m_isItemCacheValid all in 32-bit.
* dom/DynamicNodeList.cpp:
(WebCore::DynamicSubtreeNodeList::SubtreeCaches::setLengthCache):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/DynamicNodeList.cpp
trunk/Source/WebCore/dom/DynamicNodeList.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (104262 => 104263)
--- trunk/Source/WebCore/ChangeLog 2012-01-06 03:10:09 UTC (rev 104262)
+++ trunk/Source/WebCore/ChangeLog 2012-01-06 03:14:05 UTC (rev 104263)
@@ -1,3 +1,20 @@
+2012-01-05 Ryosuke Niwa
+
+REGRESSION(r104210): Dromaeo DOM test score is lower
+https://bugs.webkit.org/show_bug.cgi?id=75679
+
+Reviewed by Andreas Kling.
+
+The regression was caused by isDomVersionConsistent not being able to obtain the tree version
+inside isLengthCacheValid when m_cachedItem is null. Fix the regression by always setting
+m_cachedItem to some node when caching the length so that we can obtain the tree version later.
+
+Also address Antti's review comment to fit m_cachedLength, m_isLengthCacheValid, and
+m_isItemCacheValid all in 32-bit.
+
+* dom/DynamicNodeList.cpp:
+(WebCore::DynamicSubtreeNodeList::SubtreeCaches::setLengthCache):
+
2012-01-05 Hajime Morrita
Unreviewed bad merge fix for r104259 which dropped a line from r104210.
Modified: trunk/Source/WebCore/dom/DynamicNodeList.cpp (104262 => 104263)
--- trunk/Source/WebCore/dom/DynamicNodeList.cpp 2012-01-06 03:10:09 UTC (rev 104262)
+++ trunk/Source/WebCore/dom/DynamicNodeList.cpp 2012-01-06 03:14:05 UTC (rev 104263)
@@ -41,7 +41,8 @@
if (m_isItemCacheValid && !domVersionIsConsistent()) {
m_cachedItem = node;
m_isItemCacheValid = false;
-}
+} else if (!m_isItemCacheValid)
+m_cachedItem = node; // Used in domVersionIsConsistent.
m_cachedLength = length;
m_isLengthCacheValid = true;
m_domTreeVersionAtTimeOfCaching = node->document()->domTreeVersion();
Modified: trunk/Source/WebCore/dom/DynamicNodeList.h (104262 => 104263)
--- trunk/Source/WebCore/dom/DynamicNodeList.h 2012-01-06 03:10:09 UTC (rev 104262)
+++ trunk/Source/WebCore/dom/DynamicNodeList.h 2012-01-06 03:14:05 UTC (rev 104263)
@@ -100,9 +100,9 @@
private:
Node* m_cachedItem;
unsigned m_cachedItemOffset;
-unsigned m_cachedLength;
-bool m_isLengthCacheValid : 1;
-bool m_isItemCacheValid : 1;
+unsigned m_cachedLength : 30;
+unsigned m_isLengthCacheValid : 1;
+unsigned m_isItemCacheValid : 1;
bool domVersionIsConsistent() const
{
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104262] trunk/LayoutTests
Title: [104262] trunk/LayoutTests
Revision 104262
Author o...@chromium.org
Date 2012-01-05 19:10:09 -0800 (Thu, 05 Jan 2012)
Log Message
More chromium expected results after r104208.
* platform/chromium-cg-mac-leopard/fast/table/032-expected.png: Added.
* platform/chromium-mac-leopard/fast/table/032-expected.txt: Removed.
* platform/chromium-win-xp/fast/table/032-expected.png:
* platform/chromium-win-xp/fast/table/032-expected.txt: Removed.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium-win-xp/fast/table/032-expected.png
Added Paths
trunk/LayoutTests/platform/chromium-cg-mac-leopard/fast/table/032-expected.png
Removed Paths
trunk/LayoutTests/platform/chromium-mac-leopard/fast/table/032-expected.txt
trunk/LayoutTests/platform/chromium-win-xp/fast/table/032-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (104261 => 104262)
--- trunk/LayoutTests/ChangeLog 2012-01-06 02:46:13 UTC (rev 104261)
+++ trunk/LayoutTests/ChangeLog 2012-01-06 03:10:09 UTC (rev 104262)
@@ -1,3 +1,12 @@
+2012-01-05 Ojan Vafai
+
+More chromium expected results after r104208.
+
+* platform/chromium-cg-mac-leopard/fast/table/032-expected.png: Added.
+* platform/chromium-mac-leopard/fast/table/032-expected.txt: Removed.
+* platform/chromium-win-xp/fast/table/032-expected.png:
+* platform/chromium-win-xp/fast/table/032-expected.txt: Removed.
+
2012-01-05 Gavin Barraclough
Array.prototype.lastIndexOf ignores undefined fromIndex.
Added: trunk/LayoutTests/platform/chromium-cg-mac-leopard/fast/table/032-expected.png
(Binary files differ)
Property changes on: trunk/LayoutTests/platform/chromium-cg-mac-leopard/fast/table/032-expected.png
___
Added: svn:mime-type
Deleted: trunk/LayoutTests/platform/chromium-mac-leopard/fast/table/032-expected.txt (104261 => 104262)
--- trunk/LayoutTests/platform/chromium-mac-leopard/fast/table/032-expected.txt 2012-01-06 02:46:13 UTC (rev 104261)
+++ trunk/LayoutTests/platform/chromium-mac-leopard/fast/table/032-expected.txt 2012-01-06 03:10:09 UTC (rev 104262)
@@ -1,23 +0,0 @@
-layer at (0,0) size 800x600
- RenderView at (0,0) size 800x600
-layer at (0,0) size 800x600
- RenderBlock {HTML} at (0,0) size 800x600
-RenderBody {BODY} at (8,8) size 784x584
- RenderText {#text} at (0,0) size 771x36
-text run at (0,0) width 497: "Because we're in quirks mode, you should see a 100x100 green square below. "
-text run at (497,0) width 274: "If the square is only a couple of pixels wide"
-text run at (0,18) width 187: "or tall, then the test has failed."
- RenderText {#text} at (0,0) size 0x0
-layer at (8,50) size 100x50
- RenderBlock (positioned) {DIV} at (8,50) size 100x50
-RenderBlock (floating) {DIV} at (0,0) size 6x50 [bgcolor=#008000]
- RenderTable {TABLE} at (0,0) size 6x6
-RenderTableSection {TBODY} at (0,0) size 6x6
- RenderTableRow {TR} at (0,2) size 6x2
-RenderTableCell {TD} at (2,2) size 2x2 [r=0 c=0 rs=1 cs=1]
-layer at (8,100) size 6x50
- RenderBlock (positioned) {DIV} at (0,50) size 6x50 [bgcolor=#008000]
-RenderTable {TABLE} at (0,0) size 6x6
- RenderTableSection {TBODY} at (0,0) size 6x6
-RenderTableRow {TR} at (0,2) size 6x2
- RenderTableCell {TD} at (2,2) size 2x2 [r=0 c=0 rs=1 cs=1]
Modified: trunk/LayoutTests/platform/chromium-win-xp/fast/table/032-expected.png
(Binary files differ)
Deleted: trunk/LayoutTests/platform/chromium-win-xp/fast/table/032-expected.txt (104261 => 104262)
--- trunk/LayoutTests/platform/chromium-win-xp/fast/table/032-expected.txt 2012-01-06 02:46:13 UTC (rev 104261)
+++ trunk/LayoutTests/platform/chromium-win-xp/fast/table/032-expected.txt 2012-01-06 03:10:09 UTC (rev 104262)
@@ -1,23 +0,0 @@
-layer at (0,0) size 800x600
- RenderView at (0,0) size 800x600
-layer at (0,0) size 800x600
- RenderBlock {HTML} at (0,0) size 800x600
-RenderBody {BODY} at (8,8) size 784x584
- RenderText {#text} at (0,0) size 779x39
-text run at (0,0) width 478: "Because we're in quirks mode, you should see a 100x100 green square below. "
-text run at (478,0) width 301: "If the square is only a couple of pixels wide or tall,"
-text run at (0,20) width 136: "then the test has failed."
- RenderText {#text} at (0,0) size 0x0
-layer at (8,50) size 100x50
- RenderBlock (positioned) {DIV} at (8,50) size 100x50
-RenderBlock (floating) {DIV} at (0,0) size 6x50 [bgcolor=#008000]
- RenderTable {TABLE} at (0,0) size 6x6
-RenderTableSection {TBODY} at (0,0) size 6x6
- RenderTableRow {TR} at (0,2) size 6x2
-RenderTableCell {TD} at (2,2) size 2x2 [r=0 c=0 rs=1 cs=1]
-layer at (8,100) size 6x50
- RenderBlock (positioned) {DIV} at (0,50) size 6x50 [bgcolor=#008000]
-RenderTable {TABLE} at (0,0) size 6x6
- RenderTableSection {TBODY} at
[webkit-changes] [104261] trunk/Source/WebCore
Title: [104261] trunk/Source/WebCore
Revision 104261
Author morr...@google.com
Date 2012-01-05 18:46:13 -0800 (Thu, 05 Jan 2012)
Log Message
Unreviewed bad merge fix for r104259 which dropped a line from r104210.
* dom/TreeScopeAdopter.cpp:
(WebCore::TreeScopeAdopter::moveTreeToNewScope):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/TreeScopeAdopter.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (104260 => 104261)
--- trunk/Source/WebCore/ChangeLog 2012-01-06 02:13:29 UTC (rev 104260)
+++ trunk/Source/WebCore/ChangeLog 2012-01-06 02:46:13 UTC (rev 104261)
@@ -1,3 +1,10 @@
+2012-01-05 Hajime Morrita
+
+Unreviewed bad merge fix for r104259 which dropped a line from r104210.
+
+* dom/TreeScopeAdopter.cpp:
+(WebCore::TreeScopeAdopter::moveTreeToNewScope):
+
2012-01-05 Yongjun Zhang
https://bugs.webkit.org/show_bug.cgi?id=75593
Modified: trunk/Source/WebCore/dom/TreeScopeAdopter.cpp (104260 => 104261)
--- trunk/Source/WebCore/dom/TreeScopeAdopter.cpp 2012-01-06 02:13:29 UTC (rev 104260)
+++ trunk/Source/WebCore/dom/TreeScopeAdopter.cpp 2012-01-06 02:46:13 UTC (rev 104261)
@@ -53,6 +53,7 @@
for (Node* node = root; node; node = node->traverseNextNode(root)) {
NodeRareData* rareData = node->setTreeScope(newDocument == m_newScope ? 0 : m_newScope);
if (rareData && rareData->nodeLists()) {
+rareData->nodeLists()->invalidateCaches();
if (m_oldScope)
m_oldScope->removeNodeListCache();
m_newScope->addNodeListCache();
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104260] trunk/Source/WebCore
Title: [104260] trunk/Source/WebCore
Revision 104260
Author commit-qu...@webkit.org
Date 2012-01-05 18:13:29 -0800 (Thu, 05 Jan 2012)
Log Message
https://bugs.webkit.org/show_bug.cgi?id=75593
Patch by Yongjun Zhang on 2012-01-05
Reviewed by Alexey Proskuryakov.
Null-check 'page' variable before use, to follow the common usage pattern of m_frame->page()
throughout the rest of FrameView.cpp.
* page/FrameView.cpp:
(WebCore::FrameView::notifyPageThatContentAreaWillPaint):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/FrameView.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (104259 => 104260)
--- trunk/Source/WebCore/ChangeLog 2012-01-06 01:58:34 UTC (rev 104259)
+++ trunk/Source/WebCore/ChangeLog 2012-01-06 02:13:29 UTC (rev 104260)
@@ -1,3 +1,14 @@
+2012-01-05 Yongjun Zhang
+
+https://bugs.webkit.org/show_bug.cgi?id=75593
+Reviewed by Alexey Proskuryakov.
+
+Null-check 'page' variable before use, to follow the common usage pattern of m_frame->page()
+throughout the rest of FrameView.cpp.
+
+* page/FrameView.cpp:
+(WebCore::FrameView::notifyPageThatContentAreaWillPaint):
+
2012-01-04 Hajime Morrita
[Refactoring] Moving between TreeScopes should be done by its own class.
Modified: trunk/Source/WebCore/page/FrameView.cpp (104259 => 104260)
--- trunk/Source/WebCore/page/FrameView.cpp 2012-01-06 01:58:34 UTC (rev 104259)
+++ trunk/Source/WebCore/page/FrameView.cpp 2012-01-06 02:13:29 UTC (rev 104260)
@@ -2596,6 +2596,9 @@
void FrameView::notifyPageThatContentAreaWillPaint() const
{
Page* page = m_frame->page();
+if (!page)
+return;
+
const HashSet* scrollableAreas = page->scrollableAreaSet();
if (!scrollableAreas)
return;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104259] trunk/Source/WebCore
Title: [104259] trunk/Source/WebCore Revision 104259 Author morr...@google.com Date 2012-01-05 17:58:34 -0800 (Thu, 05 Jan 2012) Log Message [Refactoring] Moving between TreeScopes should be done by its own class. https://bugs.webkit.org/show_bug.cgi?id=75290 Reviewed by Ryosuke Niwa. This change extracted Node::setTreeScopeRecursively(), setDocumentRecursively() and a part of setDocument() into a new class called TreeScopeAdopter. By doing this, the idea of moving a node from scope to scope, that was originally hidden behind the forest of Node APIs, has become clearer. Note that this change is a preparation for Bug 59816. No new tests. No behavioral change. * CMakeLists.txt: * GNUmakefile.list.am: * Target.pri: * WebCore.gypi: * WebCore.vcproj/WebCore.vcproj: * WebCore.xcodeproj/project.pbxproj: * dom/ContainerNode.cpp: Followed the renaming. (WebCore::ContainerNode::takeAllChildrenFrom): (WebCore::ContainerNode::insertBefore): (WebCore::ContainerNode::replaceChild): (WebCore::ContainerNode::removeBetween): (WebCore::ContainerNode::removeChildren): (WebCore::ContainerNode::appendChild): (WebCore::ContainerNode::parserAddChild): * dom/DOMAllInOne.cpp: * dom/Document.cpp: Followed te renaming. (WebCore::Document::setDocType): (WebCore::Document::adoptNode): * dom/Element.cpp: Followed te renaming. (WebCore::Element::removeShadowRoot): * dom/Node.cpp: (WebCore::Node::setDocument): (WebCore::Node::setTreeScope): (WebCore::Node::didMoveToNewDocument): * dom/Node.h: * dom/TreeScope.h: * dom/TreeScope.cpp: (WebCore::TreeScope::adoptIfNeeded): moved from setTreeScopeRecursively() * dom/TreeScopeAdopter.cpp: Added. (WebCore::TreeScopeAdopter::TreeScopeAdopter): (WebCore::TreeScopeAdopter::moveTreeToNewScope): (WebCore::TreeScopeAdopter::moveTreeToNewDocument): (WebCore::TreeScopeAdopter::ensureDidMoveToNewDocumentWasCalled): (WebCore::TreeScopeAdopter::moveNodeToNewDocument): * dom/TreeScopeAdopter.h: Added. (WebCore::TreeScopeAdopter::ensureDidMoveToNewDocumentWasCalled): (WebCore::TreeScopeAdopter::execute): (WebCore::TreeScopeAdopter::needsScopeChange()): (WebCore::TreeScopeAdopter::shadowRootFor): Modified Paths trunk/Source/WebCore/CMakeLists.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/GNUmakefile.list.am trunk/Source/WebCore/Target.pri trunk/Source/WebCore/WebCore.gypi trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj trunk/Source/WebCore/dom/ContainerNode.cpp trunk/Source/WebCore/dom/DOMAllInOne.cpp trunk/Source/WebCore/dom/Document.cpp trunk/Source/WebCore/dom/Element.cpp trunk/Source/WebCore/dom/Node.cpp trunk/Source/WebCore/dom/Node.h trunk/Source/WebCore/dom/TreeScope.cpp trunk/Source/WebCore/dom/TreeScope.h Added Paths trunk/Source/WebCore/dom/TreeScopeAdopter.cpp trunk/Source/WebCore/dom/TreeScopeAdopter.h Property Changed trunk/Source/WebCore/ChangeLog Diff Modified: trunk/Source/WebCore/CMakeLists.txt (104258 => 104259) --- trunk/Source/WebCore/CMakeLists.txt 2012-01-06 01:37:39 UTC (rev 104258) +++ trunk/Source/WebCore/CMakeLists.txt 2012-01-06 01:58:34 UTC (rev 104259) @@ -610,6 +610,7 @@ dom/TransformSourceLibxslt.cpp dom/Traversal.cpp dom/TreeScope.cpp +dom/TreeScopeAdopter.cpp dom/TreeWalker.cpp dom/UIEvent.cpp dom/UIEventWithKeyState.cpp Modified: trunk/Source/WebCore/ChangeLog (104258 => 104259) --- trunk/Source/WebCore/ChangeLog 2012-01-06 01:37:39 UTC (rev 104258) +++ trunk/Source/WebCore/ChangeLog 2012-01-06 01:58:34 UTC (rev 104259) @@ -1,3 +1,60 @@ +2012-01-04 Hajime Morrita + +[Refactoring] Moving between TreeScopes should be done by its own class. +https://bugs.webkit.org/show_bug.cgi?id=75290 + +Reviewed by Ryosuke Niwa. + +This change extracted Node::setTreeScopeRecursively(), +setDocumentRecursively() and a part of setDocument() into a new +class called TreeScopeAdopter. By doing this, the idea of +moving a node from scope to scope, that was originally hidden +behind the forest of Node APIs, has become clearer. + +Note that this change is a preparation for Bug 59816. + +No new tests. No behavioral change. + +* CMakeLists.txt: +* GNUmakefile.list.am: +* Target.pri: +* WebCore.gypi: +* WebCore.vcproj/WebCore.vcproj: +* WebCore.xcodeproj/project.pbxproj: +* dom/ContainerNode.cpp: Followed the renaming. +(WebCore::ContainerNode::takeAllChildrenFrom): +(WebCore::ContainerNode::insertBefore): +(WebCore::ContainerNode::replaceChild): +(WebCore::ContainerNode::removeBetween): +(WebCore::ContainerNode::removeChildren): +(WebCore::ContainerNode::appendChild): +(WebCore::ContainerNode::parserAddChild): +* dom/DOMAllInOne.cpp: +* dom/Document.cpp: Followed te renaming. +(WebCore::Document::setDocType): +(WebCore::Document::adoptNode): +
[webkit-changes] [104258] trunk
Title: [104258] trunk
Revision 104258
Author barraclo...@apple.com
Date 2012-01-05 17:37:39 -0800 (Thu, 05 Jan 2012)
Log Message
Array.prototype.lastIndexOf ignores undefined fromIndex.
https://bugs.webkit.org/show_bug.cgi?id=75678
Reviewed by Sam Weinig.
Source/_javascript_Core:
array.lastIndexOf(x, undefined) is equivalent to array.lastIndexOf(x, 0), not array.lastIndexOf(x)
* runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncLastIndexOf):
- should check argumnet count, rather than checking agument value for undefined.
LayoutTests:
* ietestcenter/_javascript_/15.4.4.15-5-4-expected.txt:
- check in passing result
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/ietestcenter/_javascript_/15.4.4.15-5-4-expected.txt
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/ArrayPrototype.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (104257 => 104258)
--- trunk/LayoutTests/ChangeLog 2012-01-06 01:32:45 UTC (rev 104257)
+++ trunk/LayoutTests/ChangeLog 2012-01-06 01:37:39 UTC (rev 104258)
@@ -1,3 +1,13 @@
+2012-01-05 Gavin Barraclough
+
+Array.prototype.lastIndexOf ignores undefined fromIndex.
+https://bugs.webkit.org/show_bug.cgi?id=75678
+
+Reviewed by Sam Weinig.
+
+* ietestcenter/_javascript_/15.4.4.15-5-4-expected.txt:
+- check in passing result
+
2012-01-05 Jochen Eisinger
Unskip fast/storage/storage-detached-iframe.html on chromium
Modified: trunk/LayoutTests/ietestcenter/_javascript_/15.4.4.15-5-4-expected.txt (104257 => 104258)
--- trunk/LayoutTests/ietestcenter/_javascript_/15.4.4.15-5-4-expected.txt 2012-01-06 01:32:45 UTC (rev 104257)
+++ trunk/LayoutTests/ietestcenter/_javascript_/15.4.4.15-5-4-expected.txt 2012-01-06 01:37:39 UTC (rev 104258)
@@ -4,7 +4,7 @@
PASS ES5Harness.preconditionPassed is true
-FAIL ES5Harness.testPassed should be true (of type boolean). Was undefined (of type undefined).
+PASS ES5Harness.testPassed is true
PASS successfullyParsed is true
TEST COMPLETE
Modified: trunk/Source/_javascript_Core/ChangeLog (104257 => 104258)
--- trunk/Source/_javascript_Core/ChangeLog 2012-01-06 01:32:45 UTC (rev 104257)
+++ trunk/Source/_javascript_Core/ChangeLog 2012-01-06 01:37:39 UTC (rev 104258)
@@ -1,5 +1,18 @@
2012-01-05 Gavin Barraclough
+Array.prototype.lastIndexOf ignores undefined fromIndex.
+https://bugs.webkit.org/show_bug.cgi?id=75678
+
+Reviewed by Sam Weinig.
+
+array.lastIndexOf(x, undefined) is equivalent to array.lastIndexOf(x, 0), not array.lastIndexOf(x)
+
+* runtime/ArrayPrototype.cpp:
+(JSC::arrayProtoFuncLastIndexOf):
+- should check argumnet count, rather than checking agument value for undefined.
+
+2012-01-05 Gavin Barraclough
+
Date parsing is too restrictive.
https://bugs.webkit.org/show_bug.cgi?id=75671
Modified: trunk/Source/_javascript_Core/runtime/ArrayPrototype.cpp (104257 => 104258)
--- trunk/Source/_javascript_Core/runtime/ArrayPrototype.cpp 2012-01-06 01:32:45 UTC (rev 104257)
+++ trunk/Source/_javascript_Core/runtime/ArrayPrototype.cpp 2012-01-06 01:37:39 UTC (rev 104258)
@@ -1170,8 +1170,8 @@
return JSValue::encode(jsNumber(-1));
unsigned index = length - 1;
-JSValue fromValue = exec->argument(1);
-if (!fromValue.isUndefined()) {
+if (exec->argumentCount() >= 2) {
+JSValue fromValue = exec->argument(1);
double fromDouble = fromValue.toInteger(exec);
if (fromDouble < 0) {
fromDouble += length;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104257] trunk
Title: [104257] trunk
Revision 104257
Author joc...@chromium.org
Date 2012-01-05 17:32:45 -0800 (Thu, 05 Jan 2012)
Log Message
Source/WebCore: Disallow access to DOM storage from detached frames.
https://bugs.webkit.org/show_bug.cgi?id=61326
Reviewed by Adam Barth.
* storage/StorageAreaImpl.cpp:
(WebCore::StorageAreaImpl::disabledByPrivateBrowsingInFrame):
Source/WebKit/chromium: Check whether a WebView exists before accessing it in StorageAreaProxy. This is not necessarily the case, e.g. for detached iframes.
https://bugs.webkit.org/show_bug.cgi?id=61326
Reviewed by Adam Barth.
* src/StorageAreaProxy.cpp:
(WebCore::StorageAreaProxy::canAccessStorage):
LayoutTests: Unskip fast/storage/storage-detached-iframe.html on chromium
https://bugs.webkit.org/show_bug.cgi?id=61326
Reviewed by Adam Barth.
* fast/storage/storage-detached-iframe-expected.txt:
* fast/storage/storage-detached-iframe.html:
* platform/chromium/test_expectations.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/storage/storage-detached-iframe-expected.txt
trunk/LayoutTests/fast/storage/storage-detached-iframe.html
trunk/LayoutTests/platform/chromium/test_expectations.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/storage/StorageAreaImpl.cpp
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/StorageAreaProxy.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (104256 => 104257)
--- trunk/LayoutTests/ChangeLog 2012-01-06 01:32:00 UTC (rev 104256)
+++ trunk/LayoutTests/ChangeLog 2012-01-06 01:32:45 UTC (rev 104257)
@@ -1,3 +1,14 @@
+2012-01-05 Jochen Eisinger
+
+Unskip fast/storage/storage-detached-iframe.html on chromium
+https://bugs.webkit.org/show_bug.cgi?id=61326
+
+Reviewed by Adam Barth.
+
+* fast/storage/storage-detached-iframe-expected.txt:
+* fast/storage/storage-detached-iframe.html:
+* platform/chromium/test_expectations.txt:
+
2012-01-05 David Grogan
IndexedDB: fix cursor prefetch crash
Modified: trunk/LayoutTests/fast/storage/storage-detached-iframe-expected.txt (104256 => 104257)
--- trunk/LayoutTests/fast/storage/storage-detached-iframe-expected.txt 2012-01-06 01:32:00 UTC (rev 104256)
+++ trunk/LayoutTests/fast/storage/storage-detached-iframe-expected.txt 2012-01-06 01:32:45 UTC (rev 104257)
@@ -1,3 +1,4 @@
+CONSOLE MESSAGE: line 25: Expected exception caught.
Bug: https://bugs.webkit.org/show_bug.cgi?id=57140
Description: Crash from null pointer dereference below WebCore::StorageAreaImpl::setItem()
Modified: trunk/LayoutTests/fast/storage/storage-detached-iframe.html (104256 => 104257)
--- trunk/LayoutTests/fast/storage/storage-detached-iframe.html 2012-01-06 01:32:00 UTC (rev 104256)
+++ trunk/LayoutTests/fast/storage/storage-detached-iframe.html 2012-01-06 01:32:45 UTC (rev 104257)
@@ -19,7 +19,11 @@
first_attr = t1.attributes.item(undefined, undefined, undefined, undefined);
first_attr_value_replaced = first_attr.firstChild.replaceWholeText(undefined, undefined, undefined, undefined);
first_attr_value_replaced.DOCUMENT_FRAGMENT_NODE = a;
- first_attr.firstChild.DOCUMENT_FRAGMENT_NODE.localStorage.fuzz3_visited="test";
+ try {
+ first_attr.firstChild.DOCUMENT_FRAGMENT_NODE.localStorage.fuzz3_visited="test";
+ } catch (e) {
+ console.log("Expected exception caught.");
+ }
}
function runTestOuterText() {
Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (104256 => 104257)
--- trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-01-06 01:32:00 UTC (rev 104256)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-01-06 01:32:45 UTC (rev 104257)
@@ -3311,8 +3311,6 @@
BUGCR88588 : fast/lists/inlineBoxWrapperNullCheck.html = PASS TEXT
-BUGWK61326 : fast/storage/storage-detached-iframe.html = CRASH TIMEOUT
-
BUGCR88894 SLOW WIN : http/tests/cache/subresource-expiration-1.html = PASS
BUGCR88894 SLOW WIN : http/tests/cache/subresource-expiration-2.html = PASS
Modified: trunk/Source/WebCore/ChangeLog (104256 => 104257)
--- trunk/Source/WebCore/ChangeLog 2012-01-06 01:32:00 UTC (rev 104256)
+++ trunk/Source/WebCore/ChangeLog 2012-01-06 01:32:45 UTC (rev 104257)
@@ -1,3 +1,13 @@
+2012-01-05 Jochen Eisinger
+
+Disallow access to DOM storage from detached frames.
+https://bugs.webkit.org/show_bug.cgi?id=61326
+
+Reviewed by Adam Barth.
+
+* storage/StorageAreaImpl.cpp:
+(WebCore::StorageAreaImpl::disabledByPrivateBrowsingInFrame):
+
2012-01-05 No'am Rosenthal
[Qt][Texmap] Convert shaders in TextureMapperGL to use a macro
Modified: trunk/Source/WebCore/storage/StorageAreaImpl.cpp (104256 => 104257)
--- trunk/Source/WebCore/storage/StorageAreaImpl.cpp 2012-01-06 01:32:00 UTC (rev 104256)
+++ trunk/Source/WebCore/storage/StorageAreaImpl.cpp 2012-01-06 01:32:45 UTC (rev 104
[webkit-changes] [104256] trunk/Source
Title: [104256] trunk/Source Revision 104256 Author lforsch...@apple.com Date 2012-01-05 17:32:00 -0800 (Thu, 05 Jan 2012) Log Message Versioning. Modified Paths trunk/Source/_javascript_Core/Configurations/Version.xcconfig trunk/Source/_javascript_Glue/Configurations/Version.xcconfig trunk/Source/WebCore/Configurations/Version.xcconfig trunk/Source/WebKit/mac/Configurations/Version.xcconfig trunk/Source/WebKit2/Configurations/Version.xcconfig Diff Modified: trunk/Source/_javascript_Core/Configurations/Version.xcconfig (104255 => 104256) --- trunk/Source/_javascript_Core/Configurations/Version.xcconfig 2012-01-06 01:29:15 UTC (rev 104255) +++ trunk/Source/_javascript_Core/Configurations/Version.xcconfig 2012-01-06 01:32:00 UTC (rev 104256) @@ -22,7 +22,7 @@ // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. MAJOR_VERSION = 535; -MINOR_VERSION = 15; +MINOR_VERSION = 16; TINY_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION); Modified: trunk/Source/_javascript_Glue/Configurations/Version.xcconfig (104255 => 104256) --- trunk/Source/_javascript_Glue/Configurations/Version.xcconfig 2012-01-06 01:29:15 UTC (rev 104255) +++ trunk/Source/_javascript_Glue/Configurations/Version.xcconfig 2012-01-06 01:32:00 UTC (rev 104256) @@ -22,7 +22,7 @@ // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. MAJOR_VERSION = 535; -MINOR_VERSION = 15; +MINOR_VERSION = 16; TINY_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION); Modified: trunk/Source/WebCore/Configurations/Version.xcconfig (104255 => 104256) --- trunk/Source/WebCore/Configurations/Version.xcconfig 2012-01-06 01:29:15 UTC (rev 104255) +++ trunk/Source/WebCore/Configurations/Version.xcconfig 2012-01-06 01:32:00 UTC (rev 104256) @@ -22,7 +22,7 @@ // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. MAJOR_VERSION = 535; -MINOR_VERSION = 15; +MINOR_VERSION = 16; TINY_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION); Modified: trunk/Source/WebKit/mac/Configurations/Version.xcconfig (104255 => 104256) --- trunk/Source/WebKit/mac/Configurations/Version.xcconfig 2012-01-06 01:29:15 UTC (rev 104255) +++ trunk/Source/WebKit/mac/Configurations/Version.xcconfig 2012-01-06 01:32:00 UTC (rev 104256) @@ -22,7 +22,7 @@ // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. MAJOR_VERSION = 535; -MINOR_VERSION = 15; +MINOR_VERSION = 16; TINY_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION); Modified: trunk/Source/WebKit2/Configurations/Version.xcconfig (104255 => 104256) --- trunk/Source/WebKit2/Configurations/Version.xcconfig 2012-01-06 01:29:15 UTC (rev 104255) +++ trunk/Source/WebKit2/Configurations/Version.xcconfig 2012-01-06 01:32:00 UTC (rev 104256) @@ -22,7 +22,7 @@ // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. MAJOR_VERSION = 535; -MINOR_VERSION = 15; +MINOR_VERSION = 16; TINY_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION); ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104255] trunk/Source/WebCore
Title: [104255] trunk/Source/WebCore
Revision 104255
Author noam.rosent...@nokia.com
Date 2012-01-05 17:29:15 -0800 (Thu, 05 Jan 2012)
Log Message
[Qt][Texmap] Convert shaders in TextureMapperGL to use a macro
https://bugs.webkit.org/show_bug.cgi?id=75598
Use VERTEX_SHADER() and FRAGMENT_SHADER() macros, instead of quoted string literals when
declaring shaders in TextureMapperGL.
We need two macros to account for the differences between OpenGL and OpenGL ES2.
Reviewed by Martin Robinson.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/opengl/TextureMapperGL.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (104254 => 104255)
--- trunk/Source/WebCore/ChangeLog 2012-01-06 01:19:42 UTC (rev 104254)
+++ trunk/Source/WebCore/ChangeLog 2012-01-06 01:29:15 UTC (rev 104255)
@@ -1,3 +1,15 @@
+2012-01-05 No'am Rosenthal
+
+[Qt][Texmap] Convert shaders in TextureMapperGL to use a macro
+https://bugs.webkit.org/show_bug.cgi?id=75598
+
+Use VERTEX_SHADER() and FRAGMENT_SHADER() macros, instead of quoted string literals when
+declaring shaders in TextureMapperGL.
+
+We need two macros to account for the differences between OpenGL and OpenGL ES2.
+
+Reviewed by Martin Robinson.
+
2012-01-05 Ryosuke Niwa
sizeof(CSSRule) is 20 instead of 12 on Windows
Modified: trunk/Source/WebCore/platform/graphics/opengl/TextureMapperGL.cpp (104254 => 104255)
--- trunk/Source/WebCore/platform/graphics/opengl/TextureMapperGL.cpp 2012-01-06 01:19:42 UTC (rev 104254)
+++ trunk/Source/WebCore/platform/graphics/opengl/TextureMapperGL.cpp 2012-01-06 01:29:15 UTC (rev 104255)
@@ -317,63 +317,78 @@
"precision mediump float; \n"
#endif
+#define VERTEX_SHADER(src...) OES2_PRECISION_DEFINITIONS#src
+#define FRAGMENT_SHADER(src...) OES2_PRECISION_DEFINITIONS\
+OES2_FRAGMENT_SHADER_DEFAULT_PRECISION\
+#src
+
const char* fragmentShaderSourceOpacityAndMask =
-OES2_PRECISION_DEFINITIONS
-OES2_FRAGMENT_SHADER_DEFAULT_PRECISION
-" uniform sampler2D SourceTexture, MaskTexture; \n"
-" uniform lowp float Opacity; \n"
-" varying highp vec2 OutTexCoordSource, OutTexCoordMask; \n"
-" void main(void) \n"
-" { \n"
-" lowp vec4 color = texture2D(SourceTexture, OutTexCoordSource); \n"
-" lowp vec4 maskColor = texture2D(MaskTexture, OutTexCoordMask); \n"
-" lowp float o = Opacity * maskColor.a; \n"
-" gl_FragColor = vec4(color.rgb * o, color.a * o);\n"
-" } \n";
+FRAGMENT_SHADER(
+uniform sampler2D SourceTexture, MaskTexture;
+uniform lowp float Opacity;
+varying highp vec2 OutTexCoordSource, OutTexCoordMask;
+void main(void)
+{
+lowp vec4 color = texture2D(SourceTexture, OutTexCoordSource);
+lowp vec4 maskColor = texture2D(MaskTexture, OutTexCoordMask);
+lowp float fragmentAlpha = Opacity * maskColor.a;
+gl_FragColor = vec4(color.rgb * fragmentAlpha, color.a * fragmentAlpha);
+}
+);
const char* vertexShaderSourceOpacityAndMask =
-OES2_PRECISION_DEFINITIONS
-" uniform mat4 InMatrix, InSourceMatrix, InMaskMatrix;\n"
-" attribute vec4 InVertex;\n"
-" varying highp vec2 OutTexCoordSource, OutTexCoordMask; \n"
-" void main(void) \n"
-" { \n"
-" OutTexCoordSource = vec2(InSourceMatrix * InVertex);\n"
-" OutTexCoordMask = vec2(InMaskMatrix * InVertex);\n"
-" gl_Position = InMatrix * InVertex; \n"
-" } \n";
+VERTEX_SHADER(
+uniform mat4 InMatrix, InSourceMatrix, InMaskMatrix;
+attribute vec4 InVertex;
+varying highp vec2 OutTexCoordSource, OutTexCoordMask;
+void main(void)
+{
+OutTexCoordSource = vec2(InSourceMatrix * InVertex);
+OutTexCoordMask = vec2(InMaskMatrix * InVertex);
+gl_Position = InMatrix * InVertex;
+}
+);
const char* fragmentShaderSourceSimple =
-OES2_PRECI
[webkit-changes] [104254] trunk/Source/WebCore
Title: [104254] trunk/Source/WebCore
Revision 104254
Author rn...@webkit.org
Date 2012-01-05 17:19:42 -0800 (Thu, 05 Jan 2012)
Log Message
sizeof(CSSRule) is 20 instead of 12 on Windows
https://bugs.webkit.org/show_bug.cgi?id=75665
Reviewed by Darin Fisher.
Unlike gcc and clang, MSVC pads each consecutive member variables of the same type
in bitfields. e.g. if you have:
sturct AB {
unsigned m_1 : 31;
bool m_2 : 1;
}
then MSVC pads m_1 and allocates sizeof(unsigned) * 2 for AB whereas gcc and clang
only allocate sizeof(unsigned) * 1 for AB.
Fix the bloat by turning all bitfields in CSSRule either signed or unsigned integers.
* css/CSSRule.cpp:
* css/CSSRule.h:
(WebCore::CSSRule::sourceLine):
(WebCore::CSSRule::setSourceLine):
(WebCore::CSSRule::hasCachedSelectorText):
(WebCore::CSSRule::setHasCachedSelectorText):
* css/CSSStyleRule.cpp:
(WebCore::CSSStyleRule::CSSStyleRule):
(WebCore::CSSStyleRule::cleanup):
(WebCore::CSSStyleRule::selectorText):
(WebCore::CSSStyleRule::setSelectorText):
* css/CSSStyleRule.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/css/CSSRule.cpp
trunk/Source/WebCore/css/CSSRule.h
trunk/Source/WebCore/css/CSSStyleRule.cpp
trunk/Source/WebCore/css/CSSStyleRule.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (104253 => 104254)
--- trunk/Source/WebCore/ChangeLog 2012-01-06 01:17:23 UTC (rev 104253)
+++ trunk/Source/WebCore/ChangeLog 2012-01-06 01:19:42 UTC (rev 104254)
@@ -1,3 +1,36 @@
+2012-01-05 Ryosuke Niwa
+
+sizeof(CSSRule) is 20 instead of 12 on Windows
+https://bugs.webkit.org/show_bug.cgi?id=75665
+
+Reviewed by Darin Fisher.
+
+Unlike gcc and clang, MSVC pads each consecutive member variables of the same type
+in bitfields. e.g. if you have:
+
+sturct AB {
+unsigned m_1 : 31;
+bool m_2 : 1;
+}
+
+then MSVC pads m_1 and allocates sizeof(unsigned) * 2 for AB whereas gcc and clang
+only allocate sizeof(unsigned) * 1 for AB.
+
+Fix the bloat by turning all bitfields in CSSRule either signed or unsigned integers.
+
+* css/CSSRule.cpp:
+* css/CSSRule.h:
+(WebCore::CSSRule::sourceLine):
+(WebCore::CSSRule::setSourceLine):
+(WebCore::CSSRule::hasCachedSelectorText):
+(WebCore::CSSRule::setHasCachedSelectorText):
+* css/CSSStyleRule.cpp:
+(WebCore::CSSStyleRule::CSSStyleRule):
+(WebCore::CSSStyleRule::cleanup):
+(WebCore::CSSStyleRule::selectorText):
+(WebCore::CSSStyleRule::setSelectorText):
+* css/CSSStyleRule.h:
+
2012-01-05 David Grogan
IndexedDB: fix cursor prefetch crash
Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (104253 => 104254)
--- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2012-01-06 01:17:23 UTC (rev 104253)
+++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2012-01-06 01:19:42 UTC (rev 104254)
@@ -23832,7 +23832,7 @@
FD6F252D13F5EF0E0065165F /* MediaElementAudioSourceNode.h in Headers */,
E44613AD0CD6331000FADA75 /* MediaError.h in Headers */,
4E1959220A39DABA00220FE5 /* MediaFeatureNames.h in Headers */,
- 07A6D1EC1491137700051D0C /* MediaFragmentURIParser.h in Headers */,
+07A6D1EC1491137700051D0C /* MediaFragmentURIParser.h in Headers */,
A8EA800E0A19516E00A8EF5F /* MediaList.h in Headers */,
E44613E40CD681A200FADA75 /* MediaPlayer.h in Headers */,
076F0D0E12B8192700C26AA4 /* MediaPlayerPrivateAVFoundation.h in Headers */,
@@ -26943,7 +26943,7 @@
97205AB71239291000B17380 /* MediaDocument.cpp in Sources */,
FD6F252C13F5EF0E0065165F /* MediaElementAudioSourceNode.cpp in Sources */,
4E1959210A39DABA00220FE5 /* MediaFeatureNames.cpp in Sources */,
- 07A6D1EB1491137700051D0C /* MediaFragmentURIParser.cpp in Sources */,
+07A6D1EB1491137700051D0C /* MediaFragmentURIParser.cpp in Sources */,
A8EA80090A19516E00A8EF5F /* MediaList.cpp in Sources */,
E44613E30CD6819F00FADA75 /* MediaPlayer.cpp in Sources */,
072C8B11131C518600A4FCE9 /* MediaPlayerPrivateAVFoundation.cpp in Sources */,
Modified: trunk/Source/WebCore/css/CSSRule.cpp (104253 => 104254)
--- trunk/Source/WebCore/css/CSSRule.cpp 2012-01-06 01:17:23 UTC (rev 104253)
+++ trunk/Source/WebCore/css/CSSRule.cpp 2012-01-06 01:19:42 UTC (rev 104254)
@@ -36,6 +36,13 @@
namespace WebCore {
+struct SameSizeAsCSSRule : public RefCounted {
+unsigned bitfields;
+void* pointerUnion;
+};
+
+COMPILE_ASSERT(sizeof(CSSRule) == sizeof(SameSizeAsCSSRule), CSSRule_should_stay_small);
+
void CSSRule::setCssText(const String& /*cssText*/, ExceptionCode& /*ec*/)
{
notImplemented();
Modified: trunk/Source/WebCore/css/CSSRule.h (104253 => 104254)
--- trunk/Source/WebCore/css/CSSRule.h 2012-01-06 01:17:23 UTC (rev 104253)
+++ trunk/Source/WebCore/css/CSSRule.h 2012-01-06 01:19:42 UTC (rev 104254)
@@
[webkit-changes] [104253] tags/Safari-535.15/
Title: [104253] tags/Safari-535.15/ Revision 104253 Author lforsch...@apple.com Date 2012-01-05 17:17:23 -0800 (Thu, 05 Jan 2012) Log Message New Tag. Added Paths tags/Safari-535.15/ Diff Property changes: tags/Safari-535.15 Added: svn:ignore depcomp compile config.guess GNUmakefile.in config.sub ltmain.sh aconfig.h.in autom4te.cache missing aclocal.m4 install-sh autotoolsconfig.h.in INSTALL README gtk-doc.make out Makefile.chromium WebKitSupportLibrary.zip WebKitBuild Added: svn:mergeinfo ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104252] trunk
Title: [104252] trunk
Revision 104252
Author dgro...@chromium.org
Date 2012-01-05 17:15:29 -0800 (Thu, 05 Jan 2012)
Log Message
Source/WebCore: IndexedDB: fix cursor prefetch crash
http://crbug.com/108071
https://bugs.webkit.org/show_bug.cgi?id=75596
Reviewed by Tony Chang.
Test: storage/indexeddb/prefetch-bugfix-108071.html
Note: DumpRenderTree doesn't exercise the bug, it only occurs in
multi-process chromium. The layout test will soon be run as a
chromium ui test: http://codereview.chromium.org/9108004
* storage/IDBCursorBackendImpl.cpp:
(WebCore::IDBCursorBackendImpl::IDBCursorBackendImpl):
(WebCore::IDBCursorBackendImpl::~IDBCursorBackendImpl): Destroy
cursors before their objectstores.
(WebCore::IDBCursorBackendImpl::prefetchReset): Don't run continue if
the cursor is closed.
(WebCore::IDBCursorBackendImpl::close): Set a closed flag.
* storage/IDBCursorBackendImpl.h:
LayoutTests: IndexedDB: fix cursor prefetch crash
https://bugs.webkit.org/show_bug.cgi?id=75596
Reviewed by Tony Chang.
* storage/indexeddb/prefetch-bugfix-108071-expected.txt: Added.
* storage/indexeddb/prefetch-bugfix-108071.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/storage/IDBCursorBackendImpl.cpp
trunk/Source/WebCore/storage/IDBCursorBackendImpl.h
Added Paths
trunk/LayoutTests/storage/indexeddb/prefetch-bugfix-108071-expected.txt
trunk/LayoutTests/storage/indexeddb/prefetch-bugfix-108071.html
Diff
Modified: trunk/LayoutTests/ChangeLog (104251 => 104252)
--- trunk/LayoutTests/ChangeLog 2012-01-06 01:08:34 UTC (rev 104251)
+++ trunk/LayoutTests/ChangeLog 2012-01-06 01:15:29 UTC (rev 104252)
@@ -1,3 +1,13 @@
+2012-01-05 David Grogan
+
+IndexedDB: fix cursor prefetch crash
+https://bugs.webkit.org/show_bug.cgi?id=75596
+
+Reviewed by Tony Chang.
+
+* storage/indexeddb/prefetch-bugfix-108071-expected.txt: Added.
+* storage/indexeddb/prefetch-bugfix-108071.html: Added.
+
2012-01-05 Gavin Barraclough
Date parsing is too restrictive.
Added: trunk/LayoutTests/storage/indexeddb/prefetch-bugfix-108071-expected.txt (0 => 104252)
--- trunk/LayoutTests/storage/indexeddb/prefetch-bugfix-108071-expected.txt (rev 0)
+++ trunk/LayoutTests/storage/indexeddb/prefetch-bugfix-108071-expected.txt 2012-01-06 01:15:29 UTC (rev 104252)
@@ -0,0 +1,54 @@
+Test for crbug.com/108071
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+indexedDB = window.indexedDB || window.webkitIndexedDB || window.mozIndexedDB;
+PASS indexedDB == null is false
+indexedDB.deleteDatabase(DBNAME)
+indexedDB.open(DBNAME)
+db = event.target.result
+db.setVersion('new version')
+setVersionSuccess():
+trans = event.target.result
+PASS trans !== null is true
+objectStore = db.createObjectStore('store', {keyPath: 'id'})
+
+resetObjectStore():
+objectStore.clear()
+objectStore.add({id: 0, name: "Alpha"})
+objectStore.add({id: 1, name: "Bravo"})
+objectStore.add({id: 2, name: "Charlie"})
+objectStore.add({id: 3, name: "Delta"})
+objectStore.add({id: 4, name: "Echo"})
+
+iterateAndDeleteFirstElement():
+trans = db.transaction(['store'], webkitIDBTransaction.READ_WRITE)
+trans.objectStore('store').openCursor()
+0: Alpha
+trans.objectStore('store').delete(0)
+1: Bravo
+2: Charlie
+3: Delta
+4: Echo
+
+resetObjectStore():
+objectStore.clear()
+objectStore.add({id: 0, name: "Alpha"})
+objectStore.add({id: 1, name: "Bravo"})
+objectStore.add({id: 2, name: "Charlie"})
+objectStore.add({id: 3, name: "Delta"})
+objectStore.add({id: 4, name: "Echo"})
+
+prefetchAndAbort():
+trans.objectStore('store').openCursor()
+0: Alpha
+1: Bravo
+2: Charlie
+3: Delta
+trans.abort()
+PASS Transaction aborted as expected
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/storage/indexeddb/prefetch-bugfix-108071.html (0 => 104252)
--- trunk/LayoutTests/storage/indexeddb/prefetch-bugfix-108071.html (rev 0)
+++ trunk/LayoutTests/storage/indexeddb/prefetch-bugfix-108071.html 2012-01-06 01:15:29 UTC (rev 104252)
@@ -0,0 +1,130 @@
+
+
+
+
+
+
+