[webkit-changes] [104397] trunk/Source/WebKit/win
Title: [104397] trunk/Source/WebKit/win Revision 104397 Author kl...@webkit.org Date 2012-01-07 19:59:43 -0800 (Sat, 07 Jan 2012) Log Message Windows build fix. * DOMHTMLClasses.cpp: (DOMHTMLDocument::forms): (DOMHTMLSelectElement::options): Modified Paths trunk/Source/WebKit/win/ChangeLog trunk/Source/WebKit/win/DOMHTMLClasses.cpp Diff Modified: trunk/Source/WebKit/win/ChangeLog (104396 => 104397) --- trunk/Source/WebKit/win/ChangeLog 2012-01-08 03:47:08 UTC (rev 104396) +++ trunk/Source/WebKit/win/ChangeLog 2012-01-08 03:59:43 UTC (rev 104397) @@ -1,3 +1,11 @@ +2012-01-07 Andreas Kling + +Windows build fix. + +* DOMHTMLClasses.cpp: +(DOMHTMLDocument::forms): +(DOMHTMLSelectElement::options): + 2012-01-06 Jessie Berlin Windows build fix. Modified: trunk/Source/WebKit/win/DOMHTMLClasses.cpp (104396 => 104397) --- trunk/Source/WebKit/win/DOMHTMLClasses.cpp 2012-01-08 03:47:08 UTC (rev 104396) +++ trunk/Source/WebKit/win/DOMHTMLClasses.cpp 2012-01-08 03:59:43 UTC (rev 104397) @@ -305,7 +305,7 @@ return E_FAIL; HTMLDocument* htmlDoc = static_cast(m_document); -*collection = DOMHTMLCollection::createInstance(htmlDoc->forms().get()); +*collection = DOMHTMLCollection::createInstance(htmlDoc->forms()); return S_OK; } @@ -709,7 +709,7 @@ if (!selectElement->options()) return E_FAIL; -*result = DOMHTMLOptionsCollection::createInstance(selectElement->options().get()); +*result = DOMHTMLOptionsCollection::createInstance(selectElement->options()); return S_OK; } ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104396] trunk/Source/WebCore
Title: [104396] trunk/Source/WebCore
Revision 104396
Author kl...@webkit.org
Date 2012-01-07 19:47:08 -0800 (Sat, 07 Jan 2012)
Log Message
Attempt to regenerate bindings on the Windows bot.
* html/HTMLCollection.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLCollection.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (104395 => 104396)
--- trunk/Source/WebCore/ChangeLog 2012-01-08 03:41:45 UTC (rev 104395)
+++ trunk/Source/WebCore/ChangeLog 2012-01-08 03:47:08 UTC (rev 104396)
@@ -1,3 +1,9 @@
+2012-01-07 Andreas Kling
+
+Attempt to regenerate bindings on the Windows bot.
+
+* html/HTMLCollection.h:
+
2012-01-07 Daniel Bates
Memory allocator mismatch; Use operator new[] with OwnArrayPtr instead of fastMalloc()
Modified: trunk/Source/WebCore/html/HTMLCollection.h (104395 => 104396)
--- trunk/Source/WebCore/html/HTMLCollection.h 2012-01-08 03:41:45 UTC (rev 104395)
+++ trunk/Source/WebCore/html/HTMLCollection.h 2012-01-08 03:47:08 UTC (rev 104396)
@@ -45,7 +45,7 @@
void deref() { m_base->deref(); }
unsigned length() const;
-
+
virtual Node* item(unsigned index) const;
virtual Node* nextItem() const;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104395] trunk/Source/WebCore
Title: [104395] trunk/Source/WebCore Revision 104395 Author dba...@webkit.org Date 2012-01-07 19:41:45 -0800 (Sat, 07 Jan 2012) Log Message Memory allocator mismatch; Use operator new[] with OwnArrayPtr instead of fastMalloc() Rubber-stamped by Adam Barth. Currently getProgramInfoLog() in GraphicsContext3DOpenGL.cpp assumes that operator new[] and fastMalloc() are equivalent when it adopts a fastMalloc() allocated buffer. Notice, OwnArrayPtr ultimately calls delete[] on destruction. When GLOBAL_FASTMALLOC_NEW is disabled, it isn't true that operator new[], operator delete[] are equivalent to fastMalloc(), fastFree(), respectively. Hence, there may be a mismatch between the allocation and deallocation routines. Therefore, we should allocate the array to be adopted by OwnArrayPtr using operator new[]. * platform/graphics/opengl/GraphicsContext3DOpenGL.cpp: (WebCore::GraphicsContext3D::getProgramInfoLog): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (104394 => 104395) --- trunk/Source/WebCore/ChangeLog 2012-01-08 00:45:55 UTC (rev 104394) +++ trunk/Source/WebCore/ChangeLog 2012-01-08 03:41:45 UTC (rev 104395) @@ -1,3 +1,20 @@ +2012-01-07 Daniel Bates + +Memory allocator mismatch; Use operator new[] with OwnArrayPtr instead of fastMalloc() + +Rubber-stamped by Adam Barth. + +Currently getProgramInfoLog() in GraphicsContext3DOpenGL.cpp assumes that operator new[] +and fastMalloc() are equivalent when it adopts a fastMalloc() allocated buffer. Notice, +OwnArrayPtr ultimately calls delete[] on destruction. When GLOBAL_FASTMALLOC_NEW is disabled, +it isn't true that operator new[], operator delete[] are equivalent to fastMalloc(), fastFree(), +respectively. Hence, there may be a mismatch between the allocation and deallocation +routines. Therefore, we should allocate the array to be adopted by OwnArrayPtr using +operator new[]. + +* platform/graphics/opengl/GraphicsContext3DOpenGL.cpp: +(WebCore::GraphicsContext3D::getProgramInfoLog): + 2012-01-07 Chris Marrin Fixed ANGLE build for GNU and QT broken in https://trac.webkit.org/changeset/104363 Modified: trunk/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp (104394 => 104395) --- trunk/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp 2012-01-08 00:45:55 UTC (rev 104394) +++ trunk/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp 2012-01-08 03:41:45 UTC (rev 104395) @@ -1248,7 +1248,7 @@ return String(); GLsizei size = 0; -OwnArrayPtr info = adoptArrayPtr(static_cast(fastMalloc(length))); +OwnArrayPtr info = adoptArrayPtr(new GLchar[length]); ::glGetProgramInfoLog(program, length, &size, info.get()); return String(info.get()); ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104394] trunk/LayoutTests
Title: [104394] trunk/LayoutTests Revision 104394 Author dslo...@google.com Date 2012-01-07 16:45:55 -0800 (Sat, 07 Jan 2012) Log Message Unreviewed; chromium tests rebaselined after r104240. * platform/chromium-mac-leopard/editing/selection/select-from-textfield-outwards-expected.png: * platform/chromium-mac-leopard/fast/forms/input-text-double-click-expected.png: * platform/chromium-mac-leopard/fast/forms/input-text-drag-down-expected.png: * platform/chromium-mac-leopard/fast/forms/input-text-option-delete-expected.png: * platform/chromium-mac-leopard/fast/forms/input-text-scroll-left-on-blur-expected.png: * platform/chromium-mac-leopard/fast/forms/tabbing-input-iframe-expected.png: * platform/chromium-mac-leopard/fast/html/details-open2-expected.png: * platform/chromium-mac-leopard/fast/html/details-open4-expected.png: * platform/chromium-mac-snowleopard/editing/selection/select-from-textfield-outwards-expected.png: * platform/chromium-mac-snowleopard/fast/forms/input-text-double-click-expected.png: Added. * platform/chromium-mac-snowleopard/fast/forms/input-text-drag-down-expected.png: Added. * platform/chromium-mac-snowleopard/fast/forms/input-text-option-delete-expected.png: Added. * platform/chromium-mac-snowleopard/fast/forms/input-text-scroll-left-on-blur-expected.png: * platform/chromium-mac-snowleopard/fast/forms/tabbing-input-iframe-expected.png: Added. * platform/chromium-mac-snowleopard/fast/html/details-open2-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-open2-expected.png. * platform/chromium-mac-snowleopard/fast/html/details-open4-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-open4-expected.png. * platform/chromium-mac/fast/forms/input-text-double-click-expected.png: Removed. * platform/chromium-mac/fast/forms/input-text-drag-down-expected.png: Removed. * platform/chromium-mac/fast/forms/input-text-option-delete-expected.png: Removed. * platform/chromium-mac/fast/forms/tabbing-input-iframe-expected.png: Removed. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium-mac-leopard/editing/selection/select-from-textfield-outwards-expected.png trunk/LayoutTests/platform/chromium-mac-leopard/fast/forms/input-text-double-click-expected.png trunk/LayoutTests/platform/chromium-mac-leopard/fast/forms/input-text-drag-down-expected.png trunk/LayoutTests/platform/chromium-mac-leopard/fast/forms/input-text-option-delete-expected.png trunk/LayoutTests/platform/chromium-mac-leopard/fast/forms/input-text-scroll-left-on-blur-expected.png trunk/LayoutTests/platform/chromium-mac-leopard/fast/forms/tabbing-input-iframe-expected.png trunk/LayoutTests/platform/chromium-mac-leopard/fast/html/details-open2-expected.png trunk/LayoutTests/platform/chromium-mac-leopard/fast/html/details-open4-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/editing/selection/select-from-textfield-outwards-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/forms/input-text-scroll-left-on-blur-expected.png Added Paths trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/forms/input-text-double-click-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/forms/input-text-drag-down-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/forms/input-text-option-delete-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/forms/tabbing-input-iframe-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/html/details-open2-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/html/details-open4-expected.png Removed Paths trunk/LayoutTests/platform/chromium-mac/fast/forms/input-text-double-click-expected.png trunk/LayoutTests/platform/chromium-mac/fast/forms/input-text-drag-down-expected.png trunk/LayoutTests/platform/chromium-mac/fast/forms/input-text-option-delete-expected.png trunk/LayoutTests/platform/chromium-mac/fast/forms/tabbing-input-iframe-expected.png trunk/LayoutTests/platform/chromium-mac/fast/html/details-open2-expected.png trunk/LayoutTests/platform/chromium-mac/fast/html/details-open4-expected.png Diff Modified: trunk/LayoutTests/ChangeLog (104393 => 104394) --- trunk/LayoutTests/ChangeLog 2012-01-08 00:09:12 UTC (rev 104393) +++ trunk/LayoutTests/ChangeLog 2012-01-08 00:45:55 UTC (rev 104394) @@ -1,5 +1,30 @@ 2012-01-07 Dmitry Lomov +Unreviewed; chromium tests rebaselined after r104240. + +* platform/chromium-mac-leopard/editing/selection/select-from-textfield-outwards-expected.png: +* platform/chromium-mac-leopard/fast/forms/input-text-double-click-expected.png: +* platform/chromium-mac-leopard/fast/forms/input-text-drag-down-expected.png: +* platform/chromium-mac-leopard/fast/forms/input-text-option-delete-expected.png: +* platform/chromium-mac-leopard/fast/forms/input-text-scroll-left-on-blur-expected.png: +* platform/chromium-mac-leopa
[webkit-changes] [104393] trunk/LayoutTests
Title: [104393] trunk/LayoutTests Revision 104393 Author dslo...@google.com Date 2012-01-07 16:09:12 -0800 (Sat, 07 Jan 2012) Log Message Unreviewed: updating expectations and rebaselining. svg/custom/inline-svg-in-xhtml rebaselined due to http://trac.webkit.org/changeset/104240/. * platform/chromium-cg-mac-leopard/svg/custom/inline-svg-in-xhtml-expected.png: * platform/chromium-cg-mac-snowleopard/svg/custom/inline-svg-in-xhtml-expected.png: Added. * platform/chromium-cg-mac/svg/custom/inline-svg-in-xhtml-expected.png: Removed. * platform/chromium-mac-leopard/svg/custom/inline-svg-in-xhtml-expected.png: * platform/chromium-mac-snowleopard/svg/custom/inline-svg-in-xhtml-expected.png: Added. * platform/chromium-mac/svg/custom/inline-svg-in-xhtml-expected.png: Removed. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt trunk/LayoutTests/platform/chromium-cg-mac-leopard/svg/custom/inline-svg-in-xhtml-expected.png trunk/LayoutTests/platform/chromium-mac-leopard/svg/custom/inline-svg-in-xhtml-expected.png Added Paths trunk/LayoutTests/platform/chromium-cg-mac-snowleopard/svg/custom/inline-svg-in-xhtml-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/svg/custom/inline-svg-in-xhtml-expected.png Removed Paths trunk/LayoutTests/platform/chromium-cg-mac/svg/custom/inline-svg-in-xhtml-expected.png trunk/LayoutTests/platform/chromium-mac/svg/custom/inline-svg-in-xhtml-expected.png Diff Modified: trunk/LayoutTests/ChangeLog (104392 => 104393) --- trunk/LayoutTests/ChangeLog 2012-01-07 23:51:35 UTC (rev 104392) +++ trunk/LayoutTests/ChangeLog 2012-01-08 00:09:12 UTC (rev 104393) @@ -1,5 +1,18 @@ 2012-01-07 Dmitry Lomov +Unreviewed: updating expectations and rebaselining. +svg/custom/inline-svg-in-xhtml rebaselined due to http://trac.webkit.org/changeset/104240/. + +* platform/chromium-cg-mac-leopard/svg/custom/inline-svg-in-xhtml-expected.png: +* platform/chromium-cg-mac-snowleopard/svg/custom/inline-svg-in-xhtml-expected.png: Added. +* platform/chromium-cg-mac/svg/custom/inline-svg-in-xhtml-expected.png: Removed. +* platform/chromium-mac-leopard/svg/custom/inline-svg-in-xhtml-expected.png: +* platform/chromium-mac-snowleopard/svg/custom/inline-svg-in-xhtml-expected.png: Added. +* platform/chromium-mac/svg/custom/inline-svg-in-xhtml-expected.png: Removed. +* platform/chromium/test_expectations.txt: + +2012-01-07 Dmitry Lomov + Unreviewed: updating expectations and rebaslining. svg/custom/pattern-userSpaceOnUse-userToBaseTransform rebaselined due to http://trac.webkit.org/changeset/104356/. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (104392 => 104393) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-01-07 23:51:35 UTC (rev 104392) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-01-08 00:09:12 UTC (rev 104393) @@ -3889,3 +3889,5 @@ BUGWK75786 SKIP : compositing/tiled-layers-hidpi.html = TIMEOUT +BUGWK75787 MAC LINUX : fast/text/international/spaces-combined-in-vertical-text.html = TIMEOUT TEXT + Deleted: trunk/LayoutTests/platform/chromium-cg-mac/svg/custom/inline-svg-in-xhtml-expected.png (Binary files differ) Modified: trunk/LayoutTests/platform/chromium-cg-mac-leopard/svg/custom/inline-svg-in-xhtml-expected.png (Binary files differ) Added: trunk/LayoutTests/platform/chromium-cg-mac-snowleopard/svg/custom/inline-svg-in-xhtml-expected.png (Binary files differ) Property changes on: trunk/LayoutTests/platform/chromium-cg-mac-snowleopard/svg/custom/inline-svg-in-xhtml-expected.png ___ Added: svn:mime-type Deleted: trunk/LayoutTests/platform/chromium-mac/svg/custom/inline-svg-in-xhtml-expected.png (Binary files differ) Modified: trunk/LayoutTests/platform/chromium-mac-leopard/svg/custom/inline-svg-in-xhtml-expected.png (Binary files differ) Added: trunk/LayoutTests/platform/chromium-mac-snowleopard/svg/custom/inline-svg-in-xhtml-expected.png (Binary files differ) Property changes on: trunk/LayoutTests/platform/chromium-mac-snowleopard/svg/custom/inline-svg-in-xhtml-expected.png ___ Added: svn:mime-type ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104392] trunk/LayoutTests
Title: [104392] trunk/LayoutTests Revision 104392 Author dslo...@google.com Date 2012-01-07 15:51:35 -0800 (Sat, 07 Jan 2012) Log Message Unreviewed: updating expectations and rebaslining. svg/custom/pattern-userSpaceOnUse-userToBaseTransform rebaselined due to http://trac.webkit.org/changeset/104356/. * platform/chromium-linux/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.png: Added. * platform/chromium-mac-leopard/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.png: Added. * platform/chromium-win/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.png: Added. * platform/chromium-win/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.txt: Added. * platform/chromium/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.png: Added. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Added Paths trunk/LayoutTests/platform/chromium/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.png trunk/LayoutTests/platform/chromium-linux/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.png trunk/LayoutTests/platform/chromium-mac-leopard/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.png trunk/LayoutTests/platform/chromium-win/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.png trunk/LayoutTests/platform/chromium-win/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (104391 => 104392) --- trunk/LayoutTests/ChangeLog 2012-01-07 22:39:04 UTC (rev 104391) +++ trunk/LayoutTests/ChangeLog 2012-01-07 23:51:35 UTC (rev 104392) @@ -1,3 +1,15 @@ +2012-01-07 Dmitry Lomov + +Unreviewed: updating expectations and rebaslining. +svg/custom/pattern-userSpaceOnUse-userToBaseTransform rebaselined due to http://trac.webkit.org/changeset/104356/. + +* platform/chromium-linux/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.png: Added. +* platform/chromium-mac-leopard/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.png: Added. +* platform/chromium-win/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.png: Added. +* platform/chromium-win/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.txt: Added. +* platform/chromium/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.png: Added. +* platform/chromium/test_expectations.txt: + 2012-01-07 Philippe Normand Unreviewed, GTK rebaseline after r104386 and r104208. Added: trunk/LayoutTests/platform/chromium/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.png (Binary files differ) Property changes on: trunk/LayoutTests/platform/chromium/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.png ___ Added: svn:mime-type Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (104391 => 104392) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-01-07 22:39:04 UTC (rev 104391) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-01-07 23:51:35 UTC (rev 104392) @@ -1333,7 +1333,7 @@ BUGCR23476 MAC : fast/frames/inline-object-inside-frameset.html = IMAGE BUGCR23476 MAC : fast/text/font-initial.html = IMAGE // Expectation changed at r99653 (IMAGE -> IMAGE+TEXT). -BUGCR23476 BUGWK70765 MAC : fast/forms/listbox-clip.html = IMAGE+TEXT +BUGCR23476 BUGWK70765 MAC : fast/forms/listbox-clip.html = IMAGE IMAGE+TEXT // Disagreeing XML parsing error messages BUGCR88911 LEOPARD : fast/parser/xhtml-alternate-entities.xml = IMAGE+TEXT @@ -1986,7 +1986,7 @@ BUGCR42875 SKIP WONTFIX : sputnik = TEXT // Need rebaseline -BUGWK70765 WIN : fast/forms/listbox-clip.html = IMAGE+TEXT +BUGWK70765 WIN : fast/forms/listbox-clip.html = IMAGE IMAGE+TEXT BUGWK38705 : http/tests/security/sandbox-inherit-to-initial-document-2.html = TEXT @@ -3887,5 +3887,5 @@ BUGWK75784 : fast/canvas/webgl/invalid-passed-params.html = TEXT +BUGWK75786 SKIP : compositing/tiled-layers-hidpi.html = TIMEOUT - Added: trunk/LayoutTests/platform/chromium-linux/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.png (Binary files differ) Property changes on: trunk/LayoutTests/platform/chromium-linux/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.png ___ Added: svn:mime-type Added: trunk/LayoutTests/platform/chromium-mac-leopard/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.png (Binary files differ) Property changes on: trunk/LayoutTests/platform/chromium-mac-leopard/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.png ___ Added: svn:mime-type Added: trunk/LayoutTests/platform/ch
[webkit-changes] [104391] trunk/LayoutTests
Title: [104391] trunk/LayoutTests Revision 104391 Author ph...@webkit.org Date 2012-01-07 14:39:04 -0800 (Sat, 07 Jan 2012) Log Message Unreviewed, GTK rebaseline after r104386 and r104208. * platform/gtk/Skipped: Skip failing accessibility/textbox-role-reports-line-number.html * platform/gtk/fast/dom/Window/window-properties-expected.txt: * platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt: * platform/gtk/fast/table/032-expected.txt: * platform/gtk/fast/writing-mode/table-percent-width-quirk-expected.txt: Added. * platform/gtk/tables/mozilla/bugs/bug55694-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/Skipped trunk/LayoutTests/platform/gtk/fast/dom/Window/window-properties-expected.txt trunk/LayoutTests/platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt trunk/LayoutTests/platform/gtk/fast/table/032-expected.txt trunk/LayoutTests/platform/gtk/tables/mozilla/bugs/bug55694-expected.txt Added Paths trunk/LayoutTests/platform/gtk/fast/writing-mode/table-percent-width-quirk-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (104390 => 104391) --- trunk/LayoutTests/ChangeLog 2012-01-07 22:12:46 UTC (rev 104390) +++ trunk/LayoutTests/ChangeLog 2012-01-07 22:39:04 UTC (rev 104391) @@ -1,3 +1,14 @@ +2012-01-07 Philippe Normand + +Unreviewed, GTK rebaseline after r104386 and r104208. + +* platform/gtk/Skipped: Skip failing accessibility/textbox-role-reports-line-number.html +* platform/gtk/fast/dom/Window/window-properties-expected.txt: +* platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt: +* platform/gtk/fast/table/032-expected.txt: +* platform/gtk/fast/writing-mode/table-percent-width-quirk-expected.txt: Added. +* platform/gtk/tables/mozilla/bugs/bug55694-expected.txt: + 2012-01-07 Dmitry Lomov Unreviewed: test expectations and filed WK75784. Modified: trunk/LayoutTests/platform/gtk/Skipped (104390 => 104391) --- trunk/LayoutTests/platform/gtk/Skipped 2012-01-07 22:12:46 UTC (rev 104390) +++ trunk/LayoutTests/platform/gtk/Skipped 2012-01-07 22:39:04 UTC (rev 104391) @@ -1620,3 +1620,6 @@ # fast/dom/htmlcollection-zombies.html fails on GTK and on Qt # https://bugs.webkit.org/show_bug.cgi?id=75431 fast/dom/htmlcollection-zombies.html + +# https://bugs.webkit.org/show_bug.cgi?id=75785 +accessibility/textbox-role-reports-line-number.html Modified: trunk/LayoutTests/platform/gtk/fast/dom/Window/window-properties-expected.txt (104390 => 104391) --- trunk/LayoutTests/platform/gtk/fast/dom/Window/window-properties-expected.txt 2012-01-07 22:12:46 UTC (rev 104390) +++ trunk/LayoutTests/platform/gtk/fast/dom/Window/window-properties-expected.txt 2012-01-07 22:39:04 UTC (rev 104391) @@ -2391,9 +2391,12 @@ window.constructor.prototype.setTimeout [function] window.constructor.prototype.showModalDialog [function] window.constructor.prototype.stop [function] +window.constructor.prototype.webkitCancelAnimationFrame [function] +window.constructor.prototype.webkitCancelRequestAnimationFrame [function] window.constructor.prototype.webkitConvertPointFromNodeToPage [function] window.constructor.prototype.webkitConvertPointFromPageToNode [function] window.constructor.prototype.webkitPostMessage [function] +window.constructor.prototype.webkitRequestAnimationFrame [function] window.crypto [object Crypto] window.crypto.getRandomValues [function] window.decodeURI [function] @@ -2584,6 +2587,8 @@ window.typeStringNullAware [function] window.undefined [undefined] window.unescape [function] +window.webkitCancelAnimationFrame [function] +window.webkitCancelRequestAnimationFrame [function] window.webkitConvertPointFromNodeToPage [function] window.webkitConvertPointFromPageToNode [function] window.webkitPeerConnection [object PeerConnectionConstructor] @@ -2606,6 +2611,7 @@ window.webkitPeerConnection.prototype.removeStream [function] window.webkitPeerConnection.prototype.send [function] window.webkitPostMessage [function] +window.webkitRequestAnimationFrame [function] window.window [printed above as window] window.getSelection() [object DOMSelection] window.getSelection().addRange [function] Modified: trunk/LayoutTests/platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt (104390 => 104391) --- trunk/LayoutTests/platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt 2012-01-07 22:12:46 UTC (rev 104390) +++ trunk/LayoutTests/platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt 2012-01-07 22:39:04 UTC (rev 104391) @@ -554,9 +554,12 @@ PASS Object.getOwnPropertyDescriptor(window, 'toLocaleString') is undefined. PASS Object.getOwnPropertyDescriptor(window, 'toString') is undefined. PASS Object.getOwnPropertyDescriptor(window, 'valueOf') is undefined. +PASS Object.getOwnPropertyDescriptor(window, 'webkitCancelAnimationFrame') is undefined. +PASS Object.getOwnPropertyDes
[webkit-changes] [104390] trunk/LayoutTests
Title: [104390] trunk/LayoutTests Revision 104390 Author dslo...@google.com Date 2012-01-07 14:12:46 -0800 (Sat, 07 Jan 2012) Log Message Unreviewed: test expectations and filed WK75784. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (104389 => 104390) --- trunk/LayoutTests/ChangeLog 2012-01-07 21:50:37 UTC (rev 104389) +++ trunk/LayoutTests/ChangeLog 2012-01-07 22:12:46 UTC (rev 104390) @@ -1,3 +1,9 @@ +2012-01-07 Dmitry Lomov + +Unreviewed: test expectations and filed WK75784. + +* platform/chromium/test_expectations.txt: + 2012-01-07 Zan Dobersek [GTK] Enable requestAnimationFrame in build-webkit Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (104389 => 104390) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-01-07 21:50:37 UTC (rev 104389) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-01-07 22:12:46 UTC (rev 104390) @@ -3885,3 +3885,7 @@ BUGWK75742 MAC : fast/forms/input-disabled-color.html = IMAGE +BUGWK75784 : fast/canvas/webgl/invalid-passed-params.html = TEXT + + + ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104389] trunk/Source/WebKit/chromium
Title: [104389] trunk/Source/WebKit/chromium
Revision 104389
Author dslo...@google.com
Date 2012-01-07 13:50:37 -0800 (Sat, 07 Jan 2012)
Log Message
Unreviewed: disabled CCLayerTreeHostImplTest.blendingOffWhenDrawingOpaqueLayers
and filed https://bugs.webkit.org/show_bug.cgi?id=75783.
* tests/CCLayerTreeHostImplTest.cpp:
(WebKit::TEST_F):
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/tests/CCLayerTreeHostImplTest.cpp
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (104388 => 104389)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-01-07 18:43:49 UTC (rev 104388)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-01-07 21:50:37 UTC (rev 104389)
@@ -1,3 +1,11 @@
+2012-01-07 Dmitry Lomov
+
+Unreviewed: disabled CCLayerTreeHostImplTest.blendingOffWhenDrawingOpaqueLayers
+and filed https://bugs.webkit.org/show_bug.cgi?id=75783.
+
+* tests/CCLayerTreeHostImplTest.cpp:
+(WebKit::TEST_F):
+
2012-01-06 W. James MacLean
[Chromium] Cull occluded tiles in tiled layers
Modified: trunk/Source/WebKit/chromium/tests/CCLayerTreeHostImplTest.cpp (104388 => 104389)
--- trunk/Source/WebKit/chromium/tests/CCLayerTreeHostImplTest.cpp 2012-01-07 18:43:49 UTC (rev 104388)
+++ trunk/Source/WebKit/chromium/tests/CCLayerTreeHostImplTest.cpp 2012-01-07 21:50:37 UTC (rev 104389)
@@ -217,7 +217,8 @@
bool m_drawn;
};
-TEST_F(CCLayerTreeHostImplTest, blendingOffWhenDrawingOpaqueLayers)
+// https://bugs.webkit.org/show_bug.cgi?id=75783
+TEST_F(CCLayerTreeHostImplTest, FAILS_blendingOffWhenDrawingOpaqueLayers)
{
GraphicsContext3D::Attributes attrs;
RefPtr context = GraphicsContext3DPrivate::createGraphicsContextFromWebContext(adoptPtr(new BlendStateTrackerContext()), attrs, 0, GraphicsContext3D::RenderDirectlyToHostWindow, GraphicsContext3DPrivate::ForUseOnThisThread);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104388] trunk/Source/ThirdParty/ANGLE
Title: [104388] trunk/Source/ThirdParty/ANGLE
Revision 104388
Author cmar...@apple.com
Date 2012-01-07 10:43:49 -0800 (Sat, 07 Jan 2012)
Log Message
2012-01-07 Chris Marrin
Fixed a warning in GTK build of ANGLE
Unreviewed.
* src/compiler/DetectRecursion.cpp:
(DetectRecursion::~DetectRecursion):
Modified Paths
trunk/Source/ThirdParty/ANGLE/ChangeLog
trunk/Source/ThirdParty/ANGLE/src/compiler/DetectRecursion.cpp
Diff
Modified: trunk/Source/ThirdParty/ANGLE/ChangeLog (104387 => 104388)
--- trunk/Source/ThirdParty/ANGLE/ChangeLog 2012-01-07 17:46:06 UTC (rev 104387)
+++ trunk/Source/ThirdParty/ANGLE/ChangeLog 2012-01-07 18:43:49 UTC (rev 104388)
@@ -1,3 +1,12 @@
+2012-01-07 Chris Marrin
+
+Fixed a warning in GTK build of ANGLE
+
+Unreviewed.
+
+* src/compiler/DetectRecursion.cpp:
+(DetectRecursion::~DetectRecursion):
+
2012-01-06 Mark Rowe
Regenerate a few files with a more appropriate version of bison.
Modified: trunk/Source/ThirdParty/ANGLE/src/compiler/DetectRecursion.cpp (104387 => 104388)
--- trunk/Source/ThirdParty/ANGLE/src/compiler/DetectRecursion.cpp 2012-01-07 17:46:06 UTC (rev 104387)
+++ trunk/Source/ThirdParty/ANGLE/src/compiler/DetectRecursion.cpp 2012-01-07 18:43:49 UTC (rev 104388)
@@ -60,7 +60,7 @@
DetectRecursion::~DetectRecursion()
{
-for (int i = 0; i < functions.size(); ++i)
+for (size_t i = 0; i < functions.size(); ++i)
delete functions[i];
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104387] trunk/Tools
Title: [104387] trunk/Tools
Revision 104387
Author commit-qu...@webkit.org
Date 2012-01-07 09:46:06 -0800 (Sat, 07 Jan 2012)
Log Message
[WK2][GTK] Each test takes roughly half a second to load
https://bugs.webkit.org/show_bug.cgi?id=70699
Patch by Zan Dobersek on 2012-01-07
Reviewed by Martin Robinson.
Set the XDG_CACHE_HOME environment variable when testing with
WebKitTestRunner. This way the testing is started with a non-existing
application cache. If the cache exists and is not empty, the emptying
and vacuuming that is performed before every test can consume a lot of
time.
This is just a temporary workaround until it becomes possible to set
a desired directory to be used as the application cache location through
WebKitWebContext.
* Scripts/webkitpy/layout_tests/port/gtk.py:
(GtkPort.setup_environ_for_server):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/port/gtk.py
Diff
Modified: trunk/Tools/ChangeLog (104386 => 104387)
--- trunk/Tools/ChangeLog 2012-01-07 17:18:14 UTC (rev 104386)
+++ trunk/Tools/ChangeLog 2012-01-07 17:46:06 UTC (rev 104387)
@@ -1,5 +1,25 @@
2012-01-07 Zan Dobersek
+[WK2][GTK] Each test takes roughly half a second to load
+https://bugs.webkit.org/show_bug.cgi?id=70699
+
+Reviewed by Martin Robinson.
+
+Set the XDG_CACHE_HOME environment variable when testing with
+WebKitTestRunner. This way the testing is started with a non-existing
+application cache. If the cache exists and is not empty, the emptying
+and vacuuming that is performed before every test can consume a lot of
+time.
+
+This is just a temporary workaround until it becomes possible to set
+a desired directory to be used as the application cache location through
+WebKitWebContext.
+
+* Scripts/webkitpy/layout_tests/port/gtk.py:
+(GtkPort.setup_environ_for_server):
+
+2012-01-07 Zan Dobersek
+
[GTK] Enable requestAnimationFrame in build-webkit
https://bugs.webkit.org/show_bug.cgi?id=75773
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/gtk.py (104386 => 104387)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/gtk.py 2012-01-07 17:18:14 UTC (rev 104386)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/gtk.py 2012-01-07 17:46:06 UTC (rev 104387)
@@ -94,6 +94,11 @@
environment['TEST_RUNNER_TEST_PLUGIN_PATH'] = self._build_path('TestNetscapePlugin', '.libs')
environment['WEBKIT_INSPECTOR_PATH'] = self._build_path('Programs', 'resources', 'inspector')
environment['WEBKIT_TOP_LEVEL'] = self._config.webkit_base_dir()
+if self.get_option('webkit_test_runner'):
+# FIXME: This is a workaround to ensure that testing with WebKitTestRunner is started with
+# a non-existing cache. This should be removed when (and if) it will be possible to properly
+# set the cache directory path through a WebKitWebContext.
+environment['XDG_CACHE_HOME'] = self._filesystem.join(self.results_directory(), 'appcache')
return environment
def _generate_all_test_configurations(self):
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104386] trunk
Title: [104386] trunk
Revision 104386
Author commit-qu...@webkit.org
Date 2012-01-07 09:18:14 -0800 (Sat, 07 Jan 2012)
Log Message
[GTK] Enable requestAnimationFrame in build-webkit
https://bugs.webkit.org/show_bug.cgi?id=75773
Patch by Zan Dobersek on 2012-01-07
Reviewed by Martin Robinson.
Tools:
Enable requestAnimationFrame for the Gtk port.
* Scripts/build-webkit:
LayoutTests:
Skip the passing requestAnimationFrame-related tests and put
the remaining failing one under the tests that require modal
dialog implementation.
* platform/gtk/Skipped:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/Skipped
trunk/Tools/ChangeLog
trunk/Tools/Scripts/build-webkit
Diff
Modified: trunk/LayoutTests/ChangeLog (104385 => 104386)
--- trunk/LayoutTests/ChangeLog 2012-01-07 15:22:04 UTC (rev 104385)
+++ trunk/LayoutTests/ChangeLog 2012-01-07 17:18:14 UTC (rev 104386)
@@ -1,3 +1,16 @@
+2012-01-07 Zan Dobersek
+
+[GTK] Enable requestAnimationFrame in build-webkit
+https://bugs.webkit.org/show_bug.cgi?id=75773
+
+Reviewed by Martin Robinson.
+
+Skip the passing requestAnimationFrame-related tests and put
+the remaining failing one under the tests that require modal
+dialog implementation.
+
+* platform/gtk/Skipped:
+
2012-01-07 Andreas Kling
Simplify HTMLCollection ownership model.
Modified: trunk/LayoutTests/platform/gtk/Skipped (104385 => 104386)
--- trunk/LayoutTests/platform/gtk/Skipped 2012-01-07 15:22:04 UTC (rev 104385)
+++ trunk/LayoutTests/platform/gtk/Skipped 2012-01-07 17:18:14 UTC (rev 104386)
@@ -286,9 +286,6 @@
fast/canvas/canvas-toDataURL-webp.html
fast/images/webp-image-decoding.html
-# Request ENABLE(REQUEST_ANIMATION_FRAME) support
-fast/animation
-
# Requires media engine closed caption support
media/media-captions.html
@@ -951,6 +948,7 @@
# Tests that user modal dialogs fail in the DRT for some reason.
# https://bugs.webkit.org/show_bug.cgi?id=53600
+fast/animation/request-animation-frame-during-modal.html
fast/events/show-modal-dialog-onblur-onfocus.html
fast/events/scroll-event-during-modal-dialog.html
fast/harness/show-modal-dialog.html
Modified: trunk/Tools/ChangeLog (104385 => 104386)
--- trunk/Tools/ChangeLog 2012-01-07 15:22:04 UTC (rev 104385)
+++ trunk/Tools/ChangeLog 2012-01-07 17:18:14 UTC (rev 104386)
@@ -1,3 +1,14 @@
+2012-01-07 Zan Dobersek
+
+[GTK] Enable requestAnimationFrame in build-webkit
+https://bugs.webkit.org/show_bug.cgi?id=75773
+
+Reviewed by Martin Robinson.
+
+Enable requestAnimationFrame for the Gtk port.
+
+* Scripts/build-webkit:
+
2012-01-06 Jarred Nicholls
Unreviewed build-webkit fix for Chromium to properly use make if gyp generates Makefiles.
Modified: trunk/Tools/Scripts/build-webkit (104385 => 104386)
--- trunk/Tools/Scripts/build-webkit 2012-01-07 15:22:04 UTC (rev 104385)
+++ trunk/Tools/Scripts/build-webkit 2012-01-07 17:18:14 UTC (rev 104386)
@@ -137,7 +137,7 @@
my @features = (
{ option => "request-animation-frame", desc => "Toggle requestAnimationFrame support",
- define => "ENABLE_REQUEST_ANIMATION_FRAME", default => (isAppleMacWebKit()), value => \$requestAnimationFrameSupport },
+ define => "ENABLE_REQUEST_ANIMATION_FRAME", default => (isAppleMacWebKit() || isGtk()), value => \$requestAnimationFrameSupport },
{ option => "download-attribute", desc => "Toggle download attribute support",
define => "ENABLE_DOWNLOAD_ATTRIBUTE", default => isBlackBerry(), value =>\$downloadAttributeSupport },
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104385] trunk/Source/WebCore
Title: [104385] trunk/Source/WebCore Revision 104385 Author cmar...@apple.com Date 2012-01-07 07:22:04 -0800 (Sat, 07 Jan 2012) Log Message 2012-01-07 Chris Marrin Fixed ANGLE build for GNU and QT broken in https://trac.webkit.org/changeset/104363 Unreviewed. * GNUmakefile.list.am: * Target.pri: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/GNUmakefile.list.am trunk/Source/WebCore/Target.pri Diff Modified: trunk/Source/WebCore/ChangeLog (104384 => 104385) --- trunk/Source/WebCore/ChangeLog 2012-01-07 10:08:46 UTC (rev 104384) +++ trunk/Source/WebCore/ChangeLog 2012-01-07 15:22:04 UTC (rev 104385) @@ -1,3 +1,12 @@ +2012-01-07 Chris Marrin + +Fixed ANGLE build for GNU and QT broken in https://trac.webkit.org/changeset/104363 + +Unreviewed. + +* GNUmakefile.list.am: +* Target.pri: + 2012-01-07 Andreas Kling Unreviewed C++ bindings build fix after r104383. Modified: trunk/Source/WebCore/GNUmakefile.list.am (104384 => 104385) --- trunk/Source/WebCore/GNUmakefile.list.am 2012-01-07 10:08:46 UTC (rev 104384) +++ trunk/Source/WebCore/GNUmakefile.list.am 2012-01-07 15:22:04 UTC (rev 104385) @@ -5455,12 +5455,16 @@ webcore_sources += \ Source/ThirdParty/ANGLE/include/GLSLANG/ShaderLang.h \ Source/ThirdParty/ANGLE/src/compiler/BaseTypes.h \ + Source/ThirdParty/ANGLE/src/compiler/BuiltInFunctionEmulator.cpp \ + Source/ThirdParty/ANGLE/src/compiler/BuiltInFunctionEmulator.h \ Source/ThirdParty/ANGLE/src/compiler/CodeGenGLSL.cpp \ Source/ThirdParty/ANGLE/src/compiler/Common.h \ Source/ThirdParty/ANGLE/src/compiler/Compiler.cpp \ Source/ThirdParty/ANGLE/src/compiler/ConstantUnion.h \ Source/ThirdParty/ANGLE/src/compiler/debug.cpp \ Source/ThirdParty/ANGLE/src/compiler/debug.h \ + Source/ThirdParty/ANGLE/src/compiler/DetectRecursion.cpp \ + Source/ThirdParty/ANGLE/src/compiler/DetectRecursion.h \ Source/ThirdParty/ANGLE/src/compiler/ExtensionBehavior.h \ Source/ThirdParty/ANGLE/src/compiler/ForLoopUnroll.cpp \ Source/ThirdParty/ANGLE/src/compiler/ForLoopUnroll.h \ @@ -5502,6 +5506,7 @@ Source/ThirdParty/ANGLE/src/compiler/preprocessor/cpp.c \ Source/ThirdParty/ANGLE/src/compiler/preprocessor/cpp.h \ Source/ThirdParty/ANGLE/src/compiler/preprocessor/cppstruct.c \ + Source/ThirdParty/ANGLE/src/compiler/preprocessor/length_limits.h \ Source/ThirdParty/ANGLE/src/compiler/preprocessor/memory.c \ Source/ThirdParty/ANGLE/src/compiler/preprocessor/memory.h \ Source/ThirdParty/ANGLE/src/compiler/preprocessor/parser.h \ Modified: trunk/Source/WebCore/Target.pri (104384 => 104385) --- trunk/Source/WebCore/Target.pri 2012-01-07 10:08:46 UTC (rev 104384) +++ trunk/Source/WebCore/Target.pri 2012-01-07 15:22:04 UTC (rev 104385) @@ -3735,9 +3735,11 @@ ANGLE_HEADERS += \ $$ANGLE_DIR/src/compiler/BaseTypes.h \ +$$ANGLE_DIR/src/compiler/BuiltInFunctionEmulator.h \ $$ANGLE_DIR/src/compiler/Common.h \ $$ANGLE_DIR/src/compiler/ConstantUnion.h \ $$ANGLE_DIR/src/compiler/debug.h \ +$$ANGLE_DIR/src/compiler/DetectRecursion.h \ $$ANGLE_DIR/src/compiler/ExtensionBehavior.h \ $$ANGLE_DIR/src/compiler/ForLoopUnroll.h \ $$ANGLE_DIR/src/compiler/glslang.h \ @@ -3755,6 +3757,7 @@ $$ANGLE_DIR/src/compiler/preprocessor/atom.h \ $$ANGLE_DIR/src/compiler/preprocessor/compile.h \ $$ANGLE_DIR/src/compiler/preprocessor/cpp.h \ +$$ANGLE_DIR/src/compiler/preprocessor/length_limits.h \ $$ANGLE_DIR/src/compiler/preprocessor/memory.h \ $$ANGLE_DIR/src/compiler/preprocessor/parser.h \ $$ANGLE_DIR/src/compiler/preprocessor/preprocess.h \ @@ -3786,9 +3789,11 @@ HEADERS += $$ANGLE_HEADERS ANGLE_SOURCES += \ +$$ANGLE_DIR/src/compiler/BuiltInFunctionEmulator.cpp \ $$ANGLE_DIR/src/compiler/CodeGenGLSL.cpp \ $$ANGLE_DIR/src/compiler/Compiler.cpp \ $$ANGLE_DIR/src/compiler/debug.cpp \ +$$ANGLE_DIR/src/compiler/DetectRecursion.cpp \ $$ANGLE_DIR/src/compiler/ForLoopUnroll.cpp \ $$ANGLE_DIR/src/compiler/glslang_lex.cpp \ $$ANGLE_DIR/src/compiler/glslang_tab.cpp \ ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104384] trunk/Source/WebCore
Title: [104384] trunk/Source/WebCore
Revision 104384
Author kl...@webkit.org
Date 2012-01-07 02:08:46 -0800 (Sat, 07 Jan 2012)
Log Message
Unreviewed C++ bindings build fix after r104383.
Use WTF::getPtr() to grab at impl pointer since they could be either RefPtr or raw.
* bindings/scripts/CodeGeneratorCPP.pm:
(GenerateImplementation):
* bindings/scripts/test/CPP/WebDOMTestCallback.cpp:
(WebDOMTestCallback::impl):
* bindings/scripts/test/CPP/WebDOMTestEventConstructor.cpp:
(WebDOMTestEventConstructor::impl):
* bindings/scripts/test/CPP/WebDOMTestInterface.cpp:
(WebDOMTestInterface::impl):
* bindings/scripts/test/CPP/WebDOMTestMediaQueryListListener.cpp:
(WebDOMTestMediaQueryListListener::impl):
* bindings/scripts/test/CPP/WebDOMTestNamedConstructor.cpp:
(WebDOMTestNamedConstructor::impl):
* bindings/scripts/test/CPP/WebDOMTestObj.cpp:
(WebDOMTestObj::impl):
* bindings/scripts/test/CPP/WebDOMTestSerializedScriptValueInterface.cpp:
(WebDOMTestSerializedScriptValueInterface::impl):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/CodeGeneratorCPP.pm
trunk/Source/WebCore/bindings/scripts/test/CPP/WebDOMTestCallback.cpp
trunk/Source/WebCore/bindings/scripts/test/CPP/WebDOMTestEventConstructor.cpp
trunk/Source/WebCore/bindings/scripts/test/CPP/WebDOMTestInterface.cpp
trunk/Source/WebCore/bindings/scripts/test/CPP/WebDOMTestMediaQueryListListener.cpp
trunk/Source/WebCore/bindings/scripts/test/CPP/WebDOMTestNamedConstructor.cpp
trunk/Source/WebCore/bindings/scripts/test/CPP/WebDOMTestObj.cpp
trunk/Source/WebCore/bindings/scripts/test/CPP/WebDOMTestSerializedScriptValueInterface.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (104383 => 104384)
--- trunk/Source/WebCore/ChangeLog 2012-01-07 09:35:21 UTC (rev 104383)
+++ trunk/Source/WebCore/ChangeLog 2012-01-07 10:08:46 UTC (rev 104384)
@@ -1,5 +1,28 @@
2012-01-07 Andreas Kling
+Unreviewed C++ bindings build fix after r104383.
+
+Use WTF::getPtr() to grab at impl pointer since they could be either RefPtr or raw.
+
+* bindings/scripts/CodeGeneratorCPP.pm:
+(GenerateImplementation):
+* bindings/scripts/test/CPP/WebDOMTestCallback.cpp:
+(WebDOMTestCallback::impl):
+* bindings/scripts/test/CPP/WebDOMTestEventConstructor.cpp:
+(WebDOMTestEventConstructor::impl):
+* bindings/scripts/test/CPP/WebDOMTestInterface.cpp:
+(WebDOMTestInterface::impl):
+* bindings/scripts/test/CPP/WebDOMTestMediaQueryListListener.cpp:
+(WebDOMTestMediaQueryListListener::impl):
+* bindings/scripts/test/CPP/WebDOMTestNamedConstructor.cpp:
+(WebDOMTestNamedConstructor::impl):
+* bindings/scripts/test/CPP/WebDOMTestObj.cpp:
+(WebDOMTestObj::impl):
+* bindings/scripts/test/CPP/WebDOMTestSerializedScriptValueInterface.cpp:
+(WebDOMTestSerializedScriptValueInterface::impl):
+
+2012-01-07 Andreas Kling
+
Simplify HTMLCollection ownership model.
Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorCPP.pm (104383 => 104384)
--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorCPP.pm 2012-01-07 09:35:21 UTC (rev 104383)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorCPP.pm 2012-01-07 10:08:46 UTC (rev 104384)
@@ -669,7 +669,7 @@
push(@implContent, "$implClassNameWithNamespace* ${className}::impl() const\n");
push(@implContent, "{\n");
-push(@implContent, "return m_impl ? m_impl->impl.get() : 0;\n");
+push(@implContent, "return m_impl ? WTF::getPtr(m_impl->impl) : 0;\n");
push(@implContent, "}\n\n");
# Destructor
Modified: trunk/Source/WebCore/bindings/scripts/test/CPP/WebDOMTestCallback.cpp (104383 => 104384)
--- trunk/Source/WebCore/bindings/scripts/test/CPP/WebDOMTestCallback.cpp 2012-01-07 09:35:21 UTC (rev 104383)
+++ trunk/Source/WebCore/bindings/scripts/test/CPP/WebDOMTestCallback.cpp 2012-01-07 10:08:46 UTC (rev 104384)
@@ -76,7 +76,7 @@
WebCore::TestCallback* WebDOMTestCallback::impl() const
{
-return m_impl ? m_impl->impl.get() : 0;
+return m_impl ? WTF::getPtr(m_impl->impl) : 0;
}
WebDOMTestCallback::~WebDOMTestCallback()
Modified: trunk/Source/WebCore/bindings/scripts/test/CPP/WebDOMTestEventConstructor.cpp (104383 => 104384)
--- trunk/Source/WebCore/bindings/scripts/test/CPP/WebDOMTestEventConstructor.cpp 2012-01-07 09:35:21 UTC (rev 104383)
+++ trunk/Source/WebCore/bindings/scripts/test/CPP/WebDOMTestEventConstructor.cpp 2012-01-07 10:08:46 UTC (rev 104384)
@@ -65,7 +65,7 @@
WebCore::TestEventConstructor* WebDOMTestEventConstructor::impl() const
{
-return m_impl ? m_impl->impl.get() : 0;
+return m_impl ? WTF::getPtr(m_impl->impl) : 0;
}
WebDOMTestEventConstructor::~WebDOMTestEventConstructor()
Modified: trunk/Source/WebCore/bindings/scripts/test/CPP/WebDOMTestInterface.cpp (104383 => 104384)
--- trunk/Source/WebCore/bindings/scripts/test/CPP/W
[webkit-changes] [104382] trunk/Source/WebCore
Title: [104382] trunk/Source/WebCore
Revision 104382
Author aba...@webkit.org
Date 2012-01-07 01:14:18 -0800 (Sat, 07 Jan 2012)
Log Message
Attempt to fix Qt build.
* page/Geolocation.cpp:
(WebCore::Geolocation::Geolocation):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/Geolocation.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (104381 => 104382)
--- trunk/Source/WebCore/ChangeLog 2012-01-07 09:12:01 UTC (rev 104381)
+++ trunk/Source/WebCore/ChangeLog 2012-01-07 09:14:18 UTC (rev 104382)
@@ -1,3 +1,10 @@
+2012-01-07 Adam Barth
+
+Attempt to fix Qt build.
+
+* page/Geolocation.cpp:
+(WebCore::Geolocation::Geolocation):
+
2012-01-06 Ryosuke Niwa
REGRESSION(r104210): Crash inside DynamicSubtreeNodeList::length
Modified: trunk/Source/WebCore/page/Geolocation.cpp (104381 => 104382)
--- trunk/Source/WebCore/page/Geolocation.cpp 2012-01-07 09:12:01 UTC (rev 104381)
+++ trunk/Source/WebCore/page/Geolocation.cpp 2012-01-07 09:14:18 UTC (rev 104382)
@@ -762,7 +762,7 @@
void Geolocation::disconnectFrame() {}
-Geolocation::Geolocation(Frame*) {}
+Geolocation::Geolocation(Frame*) : DOMWindowProperty(0) {}
Geolocation::~Geolocation() {}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [104381] trunk
Title: [104381] trunk
Revision 104381
Author rn...@webkit.org
Date 2012-01-07 01:12:01 -0800 (Sat, 07 Jan 2012)
Log Message
REGRESSION(r104210): Crash inside DynamicSubtreeNodeList::length
https://bugs.webkit.org/show_bug.cgi?id=75731
Reviewed by Andreas Kling.
Source/WebCore:
The crash was caused by DynamicSubtreeNodeList::SubtreeCaches::domVersionIsConsistent
using m_cachedItem as a way to access the document. Changed SubtreeCaches to use
DynamicSubtreeNodeList's m_node instead.
Test: fast/dom/node-list-length-after-removing-node.html
* dom/DynamicNodeList.cpp:
(WebCore::DynamicSubtreeNodeList::SubtreeCaches::setLengthCache):
(WebCore::DynamicSubtreeNodeList::SubtreeCaches::setItemCache):
(WebCore::DynamicSubtreeNodeList::length):
(WebCore::DynamicSubtreeNodeList::item):
* dom/DynamicNodeList.h:
(WebCore::DynamicSubtreeNodeList::SubtreeCaches::isLengthCacheValid):
(WebCore::DynamicSubtreeNodeList::SubtreeCaches::isItemCacheValid):
(WebCore::DynamicSubtreeNodeList::SubtreeCaches::cachedItem):
(WebCore::DynamicSubtreeNodeList::SubtreeCaches::domVersionIsConsistent):
LayoutTests:
Add a regression test. It reproduces the crash with a very high probability.
* fast/dom/node-list-length-after-removing-node-expected.txt: Added.
* fast/dom/node-list-length-after-removing-node.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/DynamicNodeList.cpp
trunk/Source/WebCore/dom/DynamicNodeList.h
Added Paths
trunk/LayoutTests/fast/dom/node-list-length-after-removing-node-expected.txt
trunk/LayoutTests/fast/dom/node-list-length-after-removing-node.html
Diff
Modified: trunk/LayoutTests/ChangeLog (104380 => 104381)
--- trunk/LayoutTests/ChangeLog 2012-01-07 08:46:38 UTC (rev 104380)
+++ trunk/LayoutTests/ChangeLog 2012-01-07 09:12:01 UTC (rev 104381)
@@ -1,3 +1,15 @@
+2012-01-06 Ryosuke Niwa
+
+REGRESSION(r104210): Crash inside DynamicSubtreeNodeList::length
+https://bugs.webkit.org/show_bug.cgi?id=75731
+
+Reviewed by Andreas Kling.
+
+Add a regression test. It reproduces the crash with a very high probability.
+
+* fast/dom/node-list-length-after-removing-node-expected.txt: Added.
+* fast/dom/node-list-length-after-removing-node.html: Added.
+
2012-01-06 Sheriff Bot
Unreviewed, rolling out r104373 and r104374.
Added: trunk/LayoutTests/fast/dom/node-list-length-after-removing-node-expected.txt (0 => 104381)
--- trunk/LayoutTests/fast/dom/node-list-length-after-removing-node-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/dom/node-list-length-after-removing-node-expected.txt 2012-01-07 09:12:01 UTC (rev 104381)
@@ -0,0 +1,3 @@
+This tests accessing an item in node list and then querying the length of the node list after removing the item. WebKit should not crash.
+
+PASS
Added: trunk/LayoutTests/fast/dom/node-list-length-after-removing-node.html (0 => 104381)
--- trunk/LayoutTests/fast/dom/node-list-length-after-removing-node.html (rev 0)
+++ trunk/LayoutTests/fast/dom/node-list-length-after-removing-node.html 2012-01-07 09:12:01 UTC (rev 104381)
@@ -0,0 +1,31 @@
+
+
+
+This tests accessing an item in node list and then querying the length of the node list after removing the item.
+WebKit should not crash.
+
+
+
+
+var nodeList = document.getElementsByTagName('span');
+document.body.removeChild(nodeList[0]);
+
+if (window.layoutTestController)
+layoutTestController.dumpAsText();
+
+if (window.GCController)
+ GCController.collect();
+else {
+for (var i = 0; i < 1; ++i)
+new Object;
+}
+
+document.body.offsetLeft;
+
+function runTest() {
+document.getElementById('result').innerHTML = nodeList.length == 1 ? 'PASS' : 'FAIL';
+}
+
+
+
+
Modified: trunk/Source/WebCore/ChangeLog (104380 => 104381)
--- trunk/Source/WebCore/ChangeLog 2012-01-07 08:46:38 UTC (rev 104380)
+++ trunk/Source/WebCore/ChangeLog 2012-01-07 09:12:01 UTC (rev 104381)
@@ -1,3 +1,27 @@
+2012-01-06 Ryosuke Niwa
+
+REGRESSION(r104210): Crash inside DynamicSubtreeNodeList::length
+https://bugs.webkit.org/show_bug.cgi?id=75731
+
+Reviewed by Andreas Kling.
+
+The crash was caused by DynamicSubtreeNodeList::SubtreeCaches::domVersionIsConsistent
+using m_cachedItem as a way to access the document. Changed SubtreeCaches to use
+DynamicSubtreeNodeList's m_node instead.
+
+Test: fast/dom/node-list-length-after-removing-node.html
+
+* dom/DynamicNodeList.cpp:
+(WebCore::DynamicSubtreeNodeList::SubtreeCaches::setLengthCache):
+(WebCore::DynamicSubtreeNodeList::SubtreeCaches::setItemCache):
+(WebCore::DynamicSubtreeNodeList::length):
+(WebCore::DynamicSubtreeNodeList::item):
+* dom/DynamicNodeList.h:
+(WebCore::DynamicSubtreeNodeList::SubtreeCaches::isLengthCacheValid):
+(WebCore::DynamicSubtreeNodeList::SubtreeCache
