[webkit-changes] [105701] trunk/LayoutTests
Title: [105701] trunk/LayoutTests Revision 105701 Author o...@webkit.org Date 2012-01-23 23:47:47 -0800 (Mon, 23 Jan 2012) Log Message [Qt][WK2] http/tests/navigation/anchor-frames-gbk.html fails https://bugs.webkit.org/show_bug.cgi?id=76896 * platform/qt-wk2/Skipped: Skip the failing test. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt-wk2/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (105700 => 105701) --- trunk/LayoutTests/ChangeLog 2012-01-24 07:38:32 UTC (rev 105700) +++ trunk/LayoutTests/ChangeLog 2012-01-24 07:47:47 UTC (rev 105701) @@ -1,5 +1,12 @@ 2012-01-23 Csaba Osztrogonác +[Qt][WK2] http/tests/navigation/anchor-frames-gbk.html fails +https://bugs.webkit.org/show_bug.cgi?id=76896 + +* platform/qt-wk2/Skipped: Skip the failing test. + +2012-01-23 Csaba Osztrogonác + [Qt] Unreviewed gardening after r105647. * platform/qt/css3/calc/getComputedStyle-margin-percentage-expected.png: Added. Modified: trunk/LayoutTests/platform/qt-wk2/Skipped (105700 => 105701) --- trunk/LayoutTests/platform/qt-wk2/Skipped 2012-01-24 07:38:32 UTC (rev 105700) +++ trunk/LayoutTests/platform/qt-wk2/Skipped 2012-01-24 07:47:47 UTC (rev 105701) @@ -515,3 +515,7 @@ # [Qt][WK2] http/tests/history/replacestate-post-to-get-2.html fails with timeout # https://bugs.webkit.org/show_bug.cgi?id=76784 http/tests/history/replacestate-post-to-get-2.html + +# [Qt][WK2] http/tests/navigation/anchor-frames-gbk.html fails +# https://bugs.webkit.org/show_bug.cgi?id=76896 +http/tests/navigation/anchor-frames-gbk.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [105700] trunk/Source/WebCore
Title: [105700] trunk/Source/WebCore Revision 105700 Author commit-qu...@webkit.org Date 2012-01-23 23:38:32 -0800 (Mon, 23 Jan 2012) Log Message Avoid spurious rebuilds on vs2010 due to DerivedSources not existing https://bugs.webkit.org/show_bug.cgi?id=76873 Patch by Scott Graham on 2012-01-23 Reviewed by Adam Barth. * WebCore.gyp/WebCore.gyp: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/WebCore.gypi Diff Modified: trunk/Source/WebCore/ChangeLog (105699 => 105700) --- trunk/Source/WebCore/ChangeLog 2012-01-24 07:37:31 UTC (rev 105699) +++ trunk/Source/WebCore/ChangeLog 2012-01-24 07:38:32 UTC (rev 105700) @@ -1,3 +1,12 @@ +2012-01-23 Scott Graham + +Avoid spurious rebuilds on vs2010 due to DerivedSources not existing +https://bugs.webkit.org/show_bug.cgi?id=76873 + +Reviewed by Adam Barth. + +* WebCore.gyp/WebCore.gyp: + 2012-01-23 Geoffrey Garen JSValue::toString() should return a JSString* instead of a UString Modified: trunk/Source/WebCore/WebCore.gypi (105699 => 105700) --- trunk/Source/WebCore/WebCore.gypi 2012-01-24 07:37:31 UTC (rev 105699) +++ trunk/Source/WebCore/WebCore.gypi 2012-01-24 07:38:32 UTC (rev 105700) @@ -3,428 +3,6 @@ 'project_dir': ['.'], # These headers are part of WebCore's private API in the Apple Mac build. 'webcore_privateheader_files': [ -'<(PRODUCT_DIR)/DerivedSources/WebCore/CSSPropertyNames.h', -'<(PRODUCT_DIR)/DerivedSources/WebCore/DOMAbstractView.h', -'<(PRODUCT_DIR)/DerivedSources/WebCore/DOMAttr.h', -'<(PRODUCT_DIR)/DerivedSources/WebCore/DOMBlob.h', -'<(PRODUCT_DIR)/DerivedSources/WebCore/DOMBlobInternal.h', -'<(PRODUCT_DIR)/DerivedSources/WebCore/DOMCDATASection.h', -'<(PRODUCT_DIR)/DerivedSources/WebCore/DOMCSSCharsetRule.h', -'<(PRODUCT_DIR)/DerivedSources/WebCore/DOMCSSFontFaceRule.h', -'<(PRODUCT_DIR)/DerivedSources/WebCore/DOMCSSImportRule.h', -'<(PRODUCT_DIR)/DerivedSources/WebCore/DOMCSSMediaRule.h', -'<(PRODUCT_DIR)/DerivedSources/WebCore/DOMCSSPageRule.h', -'<(PRODUCT_DIR)/DerivedSources/WebCore/DOMCSSPrimitiveValue.h', -'<(PRODUCT_DIR)/DerivedSources/WebCore/DOMCSSRule.h', -'<(PRODUCT_DIR)/DerivedSources/WebCore/DOMCSSRuleList.h', -'<(PRODUCT_DIR)/DerivedSources/WebCore/DOMCSSStyleDeclaration.h', -'<(PRODUCT_DIR)/DerivedSources/WebCore/DOMCSSStyleDeclarationInternal.h', -'<(PRODUCT_DIR)/DerivedSources/WebCore/DOMCSSStyleRule.h', -'<(PRODUCT_DIR)/DerivedSources/WebCore/DOMCSSStyleSheet.h', -'<(PRODUCT_DIR)/DerivedSources/WebCore/DOMCSSUnknownRule.h', -'<(PRODUCT_DIR)/DerivedSources/WebCore/DOMCSSValue.h', -'<(PRODUCT_DIR)/DerivedSources/WebCore/DOMCSSValueList.h', -'<(PRODUCT_DIR)/DerivedSources/WebCore/DOMCharacterData.h', -'<(PRODUCT_DIR)/DerivedSources/WebCore/DOMComment.h', -'<(PRODUCT_DIR)/DerivedSources/WebCore/DOMCounter.h', -'<(PRODUCT_DIR)/DerivedSources/WebCore/DOMDOMImplementation.h', -'<(PRODUCT_DIR)/DerivedSources/WebCore/DOMDocument.h', -'<(PRODUCT_DIR)/DerivedSources/WebCore/DOMDocumentFragment.h', -'<(PRODUCT_DIR)/DerivedSources/WebCore/DOMDocumentFragmentInternal.h', -'<(PRODUCT_DIR)/DerivedSources/WebCore/DOMDocumentFragmentPrivate.h', -'<(PRODUCT_DIR)/DerivedSources/WebCore/DOMDocumentInternal.h', -'<(PRODUCT_DIR)/DerivedSources/WebCore/DOMDocumentPrivate.h', -'<(PRODUCT_DIR)/DerivedSources/WebCore/DOMDocumentType.h', -'<(PRODUCT_DIR)/DerivedSources/WebCore/DOMElement.h', -'<(PRODUCT_DIR)/DerivedSources/WebCore/DOMElementInternal.h', -'<(PRODUCT_DIR)/DerivedSources/WebCore/DOMElementTimeControl.h', -'<(PRODUCT_DIR)/DerivedSources/WebCore/DOMEntity.h', -'<(PRODUCT_DIR)/DerivedSources/WebCore/DOMEntityReference.h', -'<(PRODUCT_DIR)/DerivedSources/WebCore/DOMEvent.h', -'<(PRODUCT_DIR)/DerivedSources/WebCore/DOMEventListener.h', -'<(PRODUCT_DIR)/DerivedSources/WebCore/DOMEventTarget.h', -'<(PRODUCT_DIR)/DerivedSources/WebCore/DOMFile.h', -'<(PRODUCT_DIR)/DerivedSources/WebCore/DOMFileInternal.h', -'<(PRODUCT_DIR)/DerivedSources/WebCore/DOMFileList.h', -'<(PRODUCT_DIR)/DerivedSources/WebCore/DOMFileListInternal.h', -'<(PRODUCT_DIR)/DerivedSources/WebCore/DOMHTMLAnchorElement.h', -'<(PRODUCT_DIR)/DerivedSources/WebCore/DOMHTMLAppletElement.h', -'<(PRODUCT_DIR)/DerivedSources/WebCore/DOMHTMLAreaElement.h', -'<(PRODUCT_DIR)/DerivedSources/WebCore/DOMHTMLBRElement.h', -'<(PRODUCT_DIR)/DerivedSources/WebCore/DOMHTMLBaseElement.h', -'<(PRODU
[webkit-changes] [105699] trunk/LayoutTests
Title: [105699] trunk/LayoutTests
Revision 105699
Author o...@webkit.org
Date 2012-01-23 23:37:31 -0800 (Mon, 23 Jan 2012)
Log Message
[Qt] Unreviewed gardening after r105647.
* platform/qt/css3/calc/getComputedStyle-margin-percentage-expected.png: Added.
* platform/qt/css3/calc/getComputedStyle-margin-percentage-expected.txt: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
Added Paths
trunk/LayoutTests/platform/qt/css3/calc/
trunk/LayoutTests/platform/qt/css3/calc/getComputedStyle-margin-percentage-expected.png
trunk/LayoutTests/platform/qt/css3/calc/getComputedStyle-margin-percentage-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (105698 => 105699)
--- trunk/LayoutTests/ChangeLog 2012-01-24 07:34:10 UTC (rev 105698)
+++ trunk/LayoutTests/ChangeLog 2012-01-24 07:37:31 UTC (rev 105699)
@@ -1,3 +1,10 @@
+2012-01-23 Csaba Osztrogonác
+
+[Qt] Unreviewed gardening after r105647.
+
+* platform/qt/css3/calc/getComputedStyle-margin-percentage-expected.png: Added.
+* platform/qt/css3/calc/getComputedStyle-margin-percentage-expected.txt: Added.
+
2012-01-23 Alexey Proskuryakov
REGRESSION: Downloaded file name fallback encodings are not set correctly
Added: trunk/LayoutTests/platform/qt/css3/calc/getComputedStyle-margin-percentage-expected.png
(Binary files differ)
Property changes on: trunk/LayoutTests/platform/qt/css3/calc/getComputedStyle-margin-percentage-expected.png
___
Added: svn:mime-type
Added: trunk/LayoutTests/platform/qt/css3/calc/getComputedStyle-margin-percentage-expected.txt (0 => 105699)
--- trunk/LayoutTests/platform/qt/css3/calc/getComputedStyle-margin-percentage-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/qt/css3/calc/getComputedStyle-margin-percentage-expected.txt 2012-01-24 07:37:31 UTC (rev 105699)
@@ -0,0 +1,13 @@
+Tests calling getPropertyValue on computed margin styles involving CSS calc
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+FAIL getComputedStyle(document.getElementById('calc'), null).getPropertyValue('margin-left') should be 253px. Was 0px.
+FAIL getComputedStyle(document.getElementById('calc'), null).getPropertyValue('margin-top') should be 76px. Was 0px.
+FAIL getComputedStyle(document.getElementById('calc'), null).getPropertyValue('margin-right') should be 345px. Was 0px.
+FAIL getComputedStyle(document.getElementById('calc'), null).getPropertyValue('margin-bottom') should be 529px. Was 0px.
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [105697] trunk/Source/WebCore
Title: [105697] trunk/Source/WebCore
Revision 105697
Author hara...@chromium.org
Date 2012-01-23 23:09:47 -0800 (Mon, 23 Jan 2012)
Log Message
In CodeGeneratorObjC.pm, overwrite the output .h/.mm
only if the bytes differ
https://bugs.webkit.org/show_bug.cgi?id=76874
Reviewed by Adam Barth.
This is one of steps to stop rebuilding .h/.cpp/.mm files
generated by unchanged IDLs (bug 76836).
This patch makes a change on CodeGeneratorObjC.pm so that
it overwrites the output .h/.mm only if the bytes differ.
No tests. No change in behavior.
I manually confirmed that when I add a new attribute to Element.idl,
the time-stamps of unrelated DOM*.h and DOM*.mm do not change.
* bindings/scripts/CodeGenerator.pm:
(UpdateFileIfChanged): Added. This method writes data to a file
only if the data is different from the data in the current file.
* bindings/scripts/CodeGeneratorObjC.pm:
(WriteData): Used UpdateFileIfChanged().
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/CodeGenerator.pm
trunk/Source/WebCore/bindings/scripts/CodeGeneratorObjC.pm
Diff
Modified: trunk/Source/WebCore/ChangeLog (105696 => 105697)
--- trunk/Source/WebCore/ChangeLog 2012-01-24 06:46:00 UTC (rev 105696)
+++ trunk/Source/WebCore/ChangeLog 2012-01-24 07:09:47 UTC (rev 105697)
@@ -1,3 +1,26 @@
+2012-01-23 Kentaro Hara
+
+In CodeGeneratorObjC.pm, overwrite the output .h/.mm
+only if the bytes differ
+https://bugs.webkit.org/show_bug.cgi?id=76874
+
+Reviewed by Adam Barth.
+
+This is one of steps to stop rebuilding .h/.cpp/.mm files
+generated by unchanged IDLs (bug 76836).
+This patch makes a change on CodeGeneratorObjC.pm so that
+it overwrites the output .h/.mm only if the bytes differ.
+
+No tests. No change in behavior.
+I manually confirmed that when I add a new attribute to Element.idl,
+the time-stamps of unrelated DOM*.h and DOM*.mm do not change.
+
+* bindings/scripts/CodeGenerator.pm:
+(UpdateFileIfChanged): Added. This method writes data to a file
+only if the data is different from the data in the current file.
+* bindings/scripts/CodeGeneratorObjC.pm:
+(WriteData): Used UpdateFileIfChanged().
+
2012-01-23 Alexey Proskuryakov
REGRESSION: Downloaded file name fallback encodings are not set correctly
Modified: trunk/Source/WebCore/bindings/scripts/CodeGenerator.pm (105696 => 105697)
--- trunk/Source/WebCore/bindings/scripts/CodeGenerator.pm 2012-01-24 06:46:00 UTC (rev 105696)
+++ trunk/Source/WebCore/bindings/scripts/CodeGenerator.pm 2012-01-24 07:09:47 UTC (rev 105697)
@@ -163,6 +163,30 @@
return $codeGenerator->FileNamePrefix();
}
+sub UpdateFileIfChanged
+{
+my $object = shift;
+my $fileName = shift;
+my $contents = shift;
+
+my $shouldUpdate = 0;
+
+if (open FH, $fileName) {
+local $/ = undef;
+my $oldContents = ;
+$shouldUpdate = 1 if $oldContents ne $contents;
+close FH;
+} else {
+$shouldUpdate = 1;
+}
+
+if ($shouldUpdate) {
+open FH, "> $fileName" or die "Couldn't open $fileName: $!\n";
+print FH $contents;
+close FH;
+}
+}
+
sub ForAllParents
{
my $object = shift;
Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorObjC.pm (105696 => 105697)
--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorObjC.pm 2012-01-24 06:46:00 UTC (rev 105696)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorObjC.pm 2012-01-24 07:09:47 UTC (rev 105697)
@@ -1776,44 +1776,31 @@
my $internalHeaderFileName = "$outputDir/" . $name . "Internal.h";
my $depsFileName = "$outputDir/" . $name . ".dep";
-# Remove old files.
-unlink($headerFileName);
-unlink($privateHeaderFileName);
-unlink($implFileName);
-unlink($internalHeaderFileName);
-unlink($depsFileName);
-
# Write public header.
-open(HEADER, ">$headerFileName") or die "Couldn't open file $headerFileName";
-
-print HEADER @headerContentHeader;
-print HEADER map { "\@class $_;\n" } sort keys(%headerForwardDeclarations);
-print HEADER map { "\@protocol $_;\n" } sort keys(%headerForwardDeclarationsForProtocols);
+my $contents = join "", @headerContentHeader;
+map { $contents .= "\@class $_;\n" } sort keys(%headerForwardDeclarations);
+map { $contents .= "\@protocol $_;\n" } sort keys(%headerForwardDeclarationsForProtocols);
my $hasForwardDeclarations = keys(%headerForwardDeclarations) + keys(%headerForwardDeclarationsForProtocols);
-print HEADER "\n" if $hasForwardDeclarations;
-print HEADER @headerContent;
+$contents .= "\n" if $hasForwardDeclarations;
+$contents .= join "", @headerContent;
+$codeGenerator->UpdateFileIfChanged($headerFileName, $contents);
-close(HEADER);
-
@headerContentHeader = ();
@headerContent = ();
%headerForwardDeclarations = ();
[webkit-changes] [105696] trunk/Source/WebKit/chromium
Title: [105696] trunk/Source/WebKit/chromium
Revision 105696
Author commit-qu...@webkit.org
Date 2012-01-23 22:46:00 -0800 (Mon, 23 Jan 2012)
Log Message
Unreviewed. Rolled DEPS.
Patch by Sheriff Bot on 2012-01-23
* DEPS:
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/DEPS
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (105695 => 105696)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-01-24 06:43:26 UTC (rev 105695)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-01-24 06:46:00 UTC (rev 105696)
@@ -1,3 +1,9 @@
+2012-01-23 Sheriff Bot
+
+Unreviewed. Rolled DEPS.
+
+* DEPS:
+
2012-01-23 Tom Sepez
[chromium] Clean up old WebSharedWorker::startWorkerContext() method.
Modified: trunk/Source/WebKit/chromium/DEPS (105695 => 105696)
--- trunk/Source/WebKit/chromium/DEPS 2012-01-24 06:43:26 UTC (rev 105695)
+++ trunk/Source/WebKit/chromium/DEPS 2012-01-24 06:46:00 UTC (rev 105696)
@@ -32,7 +32,7 @@
vars = {
'chromium_svn': 'http://src.chromium.org/svn/trunk/src',
- 'chromium_rev': '118493'
+ 'chromium_rev': '118722'
}
deps = {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [105695] trunk
Title: [105695] trunk
Revision 105695
Author a...@apple.com
Date 2012-01-23 22:43:26 -0800 (Mon, 23 Jan 2012)
Log Message
REGRESSION: Downloaded file name fallback encodings are not set correctly
https://bugs.webkit.org/show_bug.cgi?id=76862
Reviewed by Adam Barth.
Source/WebCore:
Tests: http/tests/download/default-encoding.html
http/tests/download/form-submission-result.html
http/tests/download/inherited-encoding.html
http/tests/download/literal-utf-8.html
* loader/DocumentWriter.cpp:
* loader/DocumentWriter.h:
Removed deprecatedFrameEncoding. Due to changes in Document::encoding behavior, it can now
be used in its place.
* loader/FrameLoader.cpp: (WebCore::FrameLoader::addExtraFieldsToRequest): Instead of hunting
down a correct loader (and active one is not always correct any more), just use opening document's
encoding.
LayoutTests:
* http/tests/download/default-encoding-expected.txt: Added.
* http/tests/download/default-encoding.html: Added.
* http/tests/download/inherited-encoding-expected.txt: Added.
* http/tests/download/inherited-encoding.html: Added.
* http/tests/download/literal-utf-8-expected.txt: Added.
* http/tests/download/literal-utf-8.html: Added.
* http/tests/download/resources/literal-koi8-r.php: Added.
* http/tests/download/resources/literal-utf-8.php: Added.
* http/tests/download/inherited-encoding-form-submission-result-expected.txt: Added.
* http/tests/download/inherited-encoding-form-submission-result.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/download/resources/basic-ascii.php
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/DocumentWriter.cpp
trunk/Source/WebCore/loader/DocumentWriter.h
trunk/Source/WebCore/loader/FrameLoader.cpp
trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm
Added Paths
trunk/LayoutTests/http/tests/download/default-encoding-expected.txt
trunk/LayoutTests/http/tests/download/default-encoding.html
trunk/LayoutTests/http/tests/download/inherited-encoding-expected.txt
trunk/LayoutTests/http/tests/download/inherited-encoding-form-submission-result-expected.txt
trunk/LayoutTests/http/tests/download/inherited-encoding-form-submission-result.html
trunk/LayoutTests/http/tests/download/inherited-encoding.html
trunk/LayoutTests/http/tests/download/literal-utf-8-expected.txt
trunk/LayoutTests/http/tests/download/literal-utf-8.html
trunk/LayoutTests/http/tests/download/resources/literal-koi8-r.php
trunk/LayoutTests/http/tests/download/resources/literal-utf-8.php
Property Changed
trunk/LayoutTests/http/tests/download/resources/basic-ascii.php
Diff
Modified: trunk/LayoutTests/ChangeLog (105694 => 105695)
--- trunk/LayoutTests/ChangeLog 2012-01-24 06:26:54 UTC (rev 105694)
+++ trunk/LayoutTests/ChangeLog 2012-01-24 06:43:26 UTC (rev 105695)
@@ -1,3 +1,21 @@
+2012-01-23 Alexey Proskuryakov
+
+REGRESSION: Downloaded file name fallback encodings are not set correctly
+https://bugs.webkit.org/show_bug.cgi?id=76862
+
+Reviewed by Adam Barth.
+
+* http/tests/download/default-encoding-expected.txt: Added.
+* http/tests/download/default-encoding.html: Added.
+* http/tests/download/inherited-encoding-expected.txt: Added.
+* http/tests/download/inherited-encoding.html: Added.
+* http/tests/download/literal-utf-8-expected.txt: Added.
+* http/tests/download/literal-utf-8.html: Added.
+* http/tests/download/resources/literal-koi8-r.php: Added.
+* http/tests/download/resources/literal-utf-8.php: Added.
+* http/tests/download/inherited-encoding-form-submission-result-expected.txt: Added.
+* http/tests/download/inherited-encoding-form-submission-result.html: Added.
+
2012-01-23 Ojan Vafai
Implement flex-pack:distribute
Added: trunk/LayoutTests/http/tests/download/default-encoding-expected.txt (0 => 105695)
--- trunk/LayoutTests/http/tests/download/default-encoding-expected.txt (rev 0)
+++ trunk/LayoutTests/http/tests/download/default-encoding-expected.txt 2012-01-24 06:43:26 UTC (rev 105695)
@@ -0,0 +1,5 @@
+Policy delegate: attempt to load http://127.0.0.1:8000/download/resources/literal-koi8-r.php with navigation type 'link clicked' originating from #text > A > BODY > HTML > #document
+Policy delegate: resource is an attachment, suggested file name 'SUССЕSS.txt'
+Downloaded file name should be "SUССЕSS.txt" (letters "CCE" are Cyrillic).
+
+Click Me
Added: trunk/LayoutTests/http/tests/download/default-encoding.html (0 => 105695)
--- trunk/LayoutTests/http/tests/download/default-encoding.html (rev 0)
+++ trunk/LayoutTests/http/tests/download/default-encoding.html 2012-01-24 06:43:26 UTC (rev 105695)
@@ -0,0 +1,21 @@
+
+
+if (window.layoutTestController) {
+layoutTestController.dumpAsText();
+layoutTestController.overridePreference("WebKitDefaultTextEncodingName", "koi8-r");
+layoutTestController.setCustomPol
[webkit-changes] [105694] trunk
Title: [105694] trunk Revision 105694 Author o...@chromium.org Date 2012-01-23 22:26:54 -0800 (Mon, 23 Jan 2012) Log Message Implement flex-pack:distribute https://bugs.webkit.org/show_bug.cgi?id=76864 Reviewed by Tony Chang. Source/WebCore: See http://dev.w3.org/csswg/css3-flexbox/#flex-pack. * css/CSSParser.cpp: (WebCore::CSSParser::parseValue): * css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): (WebCore::CSSPrimitiveValue::operator EFlexPack): * css/CSSValueKeywords.in: * rendering/RenderFlexibleBox.cpp: (WebCore::initialPackingOffset): (WebCore::packingSpaceBetweenChildren): (WebCore::RenderFlexibleBox::layoutAndPlaceChildren): (WebCore::RenderFlexibleBox::layoutColumnReverse): * rendering/style/RenderStyleConstants.h: * rendering/style/StyleFlexibleBoxData.h: LayoutTests: * css3/flexbox/004-expected.txt: * css3/flexbox/004.html: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/css3/flexbox/004-expected.txt trunk/LayoutTests/css3/flexbox/004.html trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/css/CSSParser.cpp trunk/Source/WebCore/css/CSSPrimitiveValueMappings.h trunk/Source/WebCore/css/CSSValueKeywords.in trunk/Source/WebCore/rendering/RenderFlexibleBox.cpp trunk/Source/WebCore/rendering/style/RenderStyleConstants.h trunk/Source/WebCore/rendering/style/StyleFlexibleBoxData.h Diff Modified: trunk/LayoutTests/ChangeLog (105693 => 105694) --- trunk/LayoutTests/ChangeLog 2012-01-24 05:44:22 UTC (rev 105693) +++ trunk/LayoutTests/ChangeLog 2012-01-24 06:26:54 UTC (rev 105694) @@ -1,3 +1,13 @@ +2012-01-23 Ojan Vafai + +Implement flex-pack:distribute +https://bugs.webkit.org/show_bug.cgi?id=76864 + +Reviewed by Tony Chang. + +* css3/flexbox/004-expected.txt: +* css3/flexbox/004.html: + 2012-01-23 Tom Sepez decodeEscapeSequences() not correct for some encodings (GBK, Big5, ...). Modified: trunk/LayoutTests/css3/flexbox/004-expected.txt (105693 => 105694) --- trunk/LayoutTests/css3/flexbox/004-expected.txt 2012-01-24 05:44:22 UTC (rev 105693) +++ trunk/LayoutTests/css3/flexbox/004-expected.txt 2012-01-24 06:26:54 UTC (rev 105694) @@ -5,3 +5,6 @@ PASS PASS PASS +PASS +PASS +PASS Modified: trunk/LayoutTests/css3/flexbox/004.html (105693 => 105694) --- trunk/LayoutTests/css3/flexbox/004.html 2012-01-24 05:44:22 UTC (rev 105693) +++ trunk/LayoutTests/css3/flexbox/004.html 2012-01-24 06:26:54 UTC (rev 105694) @@ -60,6 +60,20 @@ + + + + + + + + + + + + + + Modified: trunk/Source/WebCore/ChangeLog (105693 => 105694) --- trunk/Source/WebCore/ChangeLog 2012-01-24 05:44:22 UTC (rev 105693) +++ trunk/Source/WebCore/ChangeLog 2012-01-24 06:26:54 UTC (rev 105694) @@ -1,3 +1,26 @@ +2012-01-23 Ojan Vafai + +Implement flex-pack:distribute +https://bugs.webkit.org/show_bug.cgi?id=76864 + +Reviewed by Tony Chang. + +See http://dev.w3.org/csswg/css3-flexbox/#flex-pack. + +* css/CSSParser.cpp: +(WebCore::CSSParser::parseValue): +* css/CSSPrimitiveValueMappings.h: +(WebCore::CSSPrimitiveValue::CSSPrimitiveValue): +(WebCore::CSSPrimitiveValue::operator EFlexPack): +* css/CSSValueKeywords.in: +* rendering/RenderFlexibleBox.cpp: +(WebCore::initialPackingOffset): +(WebCore::packingSpaceBetweenChildren): +(WebCore::RenderFlexibleBox::layoutAndPlaceChildren): +(WebCore::RenderFlexibleBox::layoutColumnReverse): +* rendering/style/RenderStyleConstants.h: +* rendering/style/StyleFlexibleBoxData.h: + 2012-01-23 Luke Macpherson Implement CSS clip property in CSSStyleApplyProperty. Modified: trunk/Source/WebCore/css/CSSParser.cpp (105693 => 105694) --- trunk/Source/WebCore/css/CSSParser.cpp 2012-01-24 05:44:22 UTC (rev 105693) +++ trunk/Source/WebCore/css/CSSParser.cpp 2012-01-24 06:26:54 UTC (rev 105694) @@ -1636,7 +1636,7 @@ } break; case CSSPropertyWebkitFlexPack: -validPrimitive = id == CSSValueStart || id == CSSValueEnd || id == CSSValueCenter || id == CSSValueJustify; +validPrimitive = id == CSSValueStart || id == CSSValueEnd || id == CSSValueCenter || id == CSSValueJustify || id == CSSValueDistribute; break; case CSSPropertyWebkitFlexAlign: validPrimitive = id == CSSValueStart || id == CSSValueEnd || id == CSSValueCenter || id == CSSValueBaseline || id == CSSValueStretch; Modified: trunk/Source/WebCore/css/CSSPrimitiveValueMappings.h (105693 => 105694) --- trunk/Source/WebCore/css/CSSPrimitiveValueMappings.h 2012-01-24 05:44:22 UTC (rev 105693) +++ trunk/Source/WebCore/css/CSSPrimitiveValueMappings.h 2012-01-24 06:26:54 UTC (rev 105694) @@ -1218,6 +1218,9 @@ case PackJustify: m_value.ident = CSSValueJustify; break; +case PackDistribute: +m_value.ident = CSSValueDistribute; +break; } } @@ -1232,6 +1235,
[webkit-changes] [105693] trunk/Source/WebCore
Title: [105693] trunk/Source/WebCore
Revision 105693
Author macpher...@chromium.org
Date 2012-01-23 21:44:22 -0800 (Mon, 23 Jan 2012)
Log Message
Implement CSS clip property in CSSStyleApplyProperty.
https://bugs.webkit.org/show_bug.cgi?id=74913
Reviewed by Andreas Kling.
No new tests / refactoring only.
* css/CSSPrimitiveValue.h:
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::convertToLength):
This new function aims to provide a single call for converting many CSSPrimitiveValue
values to Lengths. It is templated to allow the caller to specify which conversions
are appropriate depending on the context in which the value is used.
* css/CSSStyleApplyProperty.cpp:
(WebCore::ApplyPropertyClip::convertToLength):
(WebCore::ApplyPropertyClip::applyInheritValue):
(WebCore::ApplyPropertyClip::applyInitialValue):
(WebCore::ApplyPropertyClip::applyValue):
(WebCore::ApplyPropertyClip::createHandler):
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSPrimitiveValue.h
trunk/Source/WebCore/css/CSSPrimitiveValueMappings.h
trunk/Source/WebCore/css/CSSStyleApplyProperty.cpp
trunk/Source/WebCore/css/CSSStyleSelector.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (105692 => 105693)
--- trunk/Source/WebCore/ChangeLog 2012-01-24 05:19:25 UTC (rev 105692)
+++ trunk/Source/WebCore/ChangeLog 2012-01-24 05:44:22 UTC (rev 105693)
@@ -1,3 +1,28 @@
+2012-01-23 Luke Macpherson
+
+Implement CSS clip property in CSSStyleApplyProperty.
+https://bugs.webkit.org/show_bug.cgi?id=74913
+
+Reviewed by Andreas Kling.
+
+No new tests / refactoring only.
+
+* css/CSSPrimitiveValue.h:
+* css/CSSPrimitiveValueMappings.h:
+(WebCore::CSSPrimitiveValue::convertToLength):
+This new function aims to provide a single call for converting many CSSPrimitiveValue
+values to Lengths. It is templated to allow the caller to specify which conversions
+are appropriate depending on the context in which the value is used.
+* css/CSSStyleApplyProperty.cpp:
+(WebCore::ApplyPropertyClip::convertToLength):
+(WebCore::ApplyPropertyClip::applyInheritValue):
+(WebCore::ApplyPropertyClip::applyInitialValue):
+(WebCore::ApplyPropertyClip::applyValue):
+(WebCore::ApplyPropertyClip::createHandler):
+(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
+* css/CSSStyleSelector.cpp:
+(WebCore::CSSStyleSelector::applyProperty):
+
2012-01-23 Tom Sepez
decodeEscapeSequences() not correct for some encodings (GBK, Big5, ...).
Modified: trunk/Source/WebCore/css/CSSPrimitiveValue.h (105692 => 105693)
--- trunk/Source/WebCore/css/CSSPrimitiveValue.h 2012-01-24 05:19:25 UTC (rev 105692)
+++ trunk/Source/WebCore/css/CSSPrimitiveValue.h 2012-01-24 05:44:22 UTC (rev 105693)
@@ -203,6 +203,9 @@
*/
template T computeLength(RenderStyle* currStyle, RenderStyle* rootStyle, float multiplier = 1.0f, bool computingFontSize = false);
+// Converts to a Length, mapping various unit types appropriately.
+template Length convertToLength(RenderStyle* currStyle, RenderStyle* rootStyle, double multiplier = 1.0, bool computingFontSize = false);
+
// use with care!!!
void setPrimitiveType(unsigned short type) { m_primitiveUnitType = type; }
Modified: trunk/Source/WebCore/css/CSSPrimitiveValueMappings.h (105692 => 105693)
--- trunk/Source/WebCore/css/CSSPrimitiveValueMappings.h 2012-01-24 05:19:25 UTC (rev 105692)
+++ trunk/Source/WebCore/css/CSSPrimitiveValueMappings.h 2012-01-24 05:44:22 UTC (rev 105693)
@@ -36,6 +36,7 @@
#include "FontDescription.h"
#include "FontSmoothingMode.h"
#include "GraphicsTypes.h"
+#include "Length.h"
#include "Path.h"
#include "RenderStyleConstants.h"
#include "SVGRenderStyleDefs.h"
@@ -3673,6 +3674,21 @@
}
}
+enum LengthConversion { UnsupportedConversion = 0, FixedConversion = 1, AutoConversion = 2, PercentConversion = 4, FractionConversion = 8};
+template Length CSSPrimitiveValue::convertToLength(RenderStyle* style, RenderStyle* rootStyle, double multiplier, bool computingFontSize)
+{
+if ((supported & FixedConversion) && isLength())
+return computeLength(style, rootStyle, multiplier, computingFontSize);
+if ((supported & PercentConversion) && isPercentage())
+return Length(getDoubleValue(), Percent);
+if ((supported & FractionConversion) && isNumber())
+return Length(getDoubleValue() * 100.0, Percent);
+if ((supported & AutoConversion) && getIdent() == CSSValueAuto)
+return Length(Auto);
+ASSERT_NOT_REACHED();
+return Length(Undefined);
+}
+
#if ENABLE(SVG)
template<> inline CSSPrimitiveValue::CSSPrimitiveValue(EColorInterpolation e)
Modified: trunk/Source/WebCore/css/CSSStyleApplyProperty.cpp (105692
[webkit-changes] [105692] branches/chromium/963
Title: [105692] branches/chromium/963
Revision 105692
Author tk...@chromium.org
Date 2012-01-23 21:19:25 -0800 (Mon, 23 Jan 2012)
Log Message
Merge 105386 - REGRESSION(r100111): A 'change' event does not fire when a mouse drag
occurs to switch elements in a listbox
https://bugs.webkit.org/show_bug.cgi?id=76244
Reviewed by Hajime Morita.
Source/WebCore:
Test: fast/forms/select/listbox-drag-in-non-multiple.html
* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::updateSelectedState):
Do not update m_activeSelectionState for non-multiple .
(WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
Use setActiveSelection*Index() and updateListBoxSelection(true) instead
of updateSelectedState() because updateSelectedState() updates
m_lastOnChangeSelection and will prevent the mouseup handler from
dispatching 'change' event.
We should not call listBoxOnChange() in the mousemove handler in order
to align the behavior of IE and Firefox.
LayoutTests:
* fast/forms/resources/common.js:
(mouseMoveToIndexInListbox): Added.
* fast/forms/select/listbox-drag-in-non-multiple-expected.txt: Added.
* fast/forms/select/listbox-drag-in-non-multiple.html: Added.
TBR=tk...@chromium.org
BUG=crbug.com/110068
Review URL: https://chromiumcodereview.appspot.com/9285007
Modified Paths
branches/chromium/963/LayoutTests/fast/forms/resources/common.js
branches/chromium/963/Source/WebCore/html/HTMLSelectElement.cpp
Added Paths
branches/chromium/963/LayoutTests/fast/forms/select/listbox-drag-in-non-multiple-expected.txt
branches/chromium/963/LayoutTests/fast/forms/select/listbox-drag-in-non-multiple.html
Diff
Modified: branches/chromium/963/LayoutTests/fast/forms/resources/common.js (105691 => 105692)
--- branches/chromium/963/LayoutTests/fast/forms/resources/common.js 2012-01-24 05:08:14 UTC (rev 105691)
+++ branches/chromium/963/LayoutTests/fast/forms/resources/common.js 2012-01-24 05:19:25 UTC (rev 105692)
@@ -22,3 +22,12 @@
pos.y = element.offsetTop + element.offsetHeight / 2;
return pos;
}
+
+function mouseMoveToIndexInListbox(index, listboxId) {
+var listbox = document.getElementById(listboxId);
+var itemHeight = Math.floor(listbox.offsetHeight / listbox.size);
+var border = 1;
+var y = border + index * itemHeight;
+if (window.eventSender)
+eventSender.mouseMoveTo(listbox.offsetLeft + border, listbox.offsetTop + y - window.pageYOffset);
+}
Copied: branches/chromium/963/LayoutTests/fast/forms/select/listbox-drag-in-non-multiple-expected.txt (from rev 105386, trunk/LayoutTests/fast/forms/select/listbox-drag-in-non-multiple-expected.txt) (0 => 105692)
--- branches/chromium/963/LayoutTests/fast/forms/select/listbox-drag-in-non-multiple-expected.txt (rev 0)
+++ branches/chromium/963/LayoutTests/fast/forms/select/listbox-drag-in-non-multiple-expected.txt 2012-01-24 05:19:25 UTC (rev 105692)
@@ -0,0 +1,11 @@
+Test if 'change' event is dispatched when selecting an item by mouse dragging in a non-multiple listbox.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+
+PASS: A click event was dispatched.
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Copied: branches/chromium/963/LayoutTests/fast/forms/select/listbox-drag-in-non-multiple.html (from rev 105386, trunk/LayoutTests/fast/forms/select/listbox-drag-in-non-multiple.html) (0 => 105692)
--- branches/chromium/963/LayoutTests/fast/forms/select/listbox-drag-in-non-multiple.html (rev 0)
+++ branches/chromium/963/LayoutTests/fast/forms/select/listbox-drag-in-non-multiple.html 2012-01-24 05:19:25 UTC (rev 105692)
@@ -0,0 +1,36 @@
+
+
+
+
+
+FAIL
+
+
+