[webkit-changes] [201127] trunk/Websites/perf.webkit.org
Title: [201127] trunk/Websites/perf.webkit.org Revision 201127 Author rn...@webkit.org Date 2016-05-18 22:20:03 -0700 (Wed, 18 May 2016) Log Message Perf dashboard "Add pane" should list first by test, then by machine https://bugs.webkit.org/show_bug.cgi?id=157880 Reviewed by Stephanie Lewis. Reversed the order which tests and platforms are selected. Also split .pane-selector-container into #tests and #platform for the ease of DOM node manipulations. * public/v3/components/pane-selector.js: (PaneSelector): (PaneSelector.prototype._renderPlatformList): Renamed from _renderPlatformLists since there is a single list for platforms. This list now disappears while a non-metric item is selected in the collection of test lists. e.g. "Speedometer" instead of its "Score" metric. Remember the last metric we rendered to avoid churning. (PaneSelector.prototype._renderTestLists): Render the top level tests once. The index of lists have been decreased by one since test lists are now inside #tests instead of appearing after the platform list. (PaneSelector.prototype._buildTestList): Don't filter tests since platform is chosen after tests now. (PaneSelector.prototype._replaceList): (PaneSelector.prototype._selectedItem): Don't reset the test path (specifies which subtest or metric is picked) when a platform is selected since it happens after a test metric is chosen now. (PaneSelector.prototype._clickedItem): Add a pane when a platform is clicked, not when a metric is clicked. (PaneSelector.cssTemplate): Modified Paths trunk/Websites/perf.webkit.org/ChangeLog trunk/Websites/perf.webkit.org/public/v3/components/pane-selector.js Diff Modified: trunk/Websites/perf.webkit.org/ChangeLog (201126 => 201127) --- trunk/Websites/perf.webkit.org/ChangeLog 2016-05-19 04:57:41 UTC (rev 201126) +++ trunk/Websites/perf.webkit.org/ChangeLog 2016-05-19 05:20:03 UTC (rev 201127) @@ -1,5 +1,29 @@ 2016-05-18 Ryosuke Niwa +Perf dashboard "Add pane" should list first by test, then by machine +https://bugs.webkit.org/show_bug.cgi?id=157880 + +Reviewed by Stephanie Lewis. + +Reversed the order which tests and platforms are selected. Also split .pane-selector-container into #tests and +#platform for the ease of DOM node manipulations. + +* public/v3/components/pane-selector.js: +(PaneSelector): +(PaneSelector.prototype._renderPlatformList): Renamed from _renderPlatformLists since there is a single list +for platforms. This list now disappears while a non-metric item is selected in the collection of test lists. +e.g. "Speedometer" instead of its "Score" metric. Remember the last metric we rendered to avoid churning. +(PaneSelector.prototype._renderTestLists): Render the top level tests once. The index of lists have been +decreased by one since test lists are now inside #tests instead of appearing after the platform list. +(PaneSelector.prototype._buildTestList): Don't filter tests since platform is chosen after tests now. +(PaneSelector.prototype._replaceList): +(PaneSelector.prototype._selectedItem): Don't reset the test path (specifies which subtest or metric is picked) +when a platform is selected since it happens after a test metric is chosen now. +(PaneSelector.prototype._clickedItem): Add a pane when a platform is clicked, not when a metric is clicked. +(PaneSelector.cssTemplate): + +2016-05-18 Ryosuke Niwa + Analysis task should look for a git commit based on abridged hashes https://bugs.webkit.org/show_bug.cgi?id=157877 Modified: trunk/Websites/perf.webkit.org/public/v3/components/pane-selector.js (201126 => 201127) --- trunk/Websites/perf.webkit.org/public/v3/components/pane-selector.js 2016-05-19 04:57:41 UTC (rev 201126) +++ trunk/Websites/perf.webkit.org/public/v3/components/pane-selector.js 2016-05-19 05:20:03 UTC (rev 201127) @@ -5,18 +5,19 @@ super('pane-selector'); this._currentPlatform = null; this._currentPath = []; -this._platformItems = null; -this._renderedPlatform = null; +this._platformItems = []; +this._renderedMetric = null; this._renderedPath = null; this._updateTimer = null; -this._container = this.content().querySelector('.pane-selector-container'); +this._platformContainer = this.content().querySelector('#platform'); +this._testsContainer = this.content().querySelector('#tests'); this._callback = null; this._previouslySelectedItem = null; } render() { -this._renderPlatformLists(); +this._renderPlatformList(); this._renderTestLists(); } @@ -30,16 +31,29 @@ } } -_renderPlatformLists() +_renderPlatformList() { -if (!this._platformItems) { +var currentMetric = null; +if (this._currentPath.length) { +
[webkit-changes] [201126] trunk/Source/WebInspectorUI
Title: [201126] trunk/Source/WebInspectorUI Revision 201126 Author timo...@apple.com Date 2016-05-18 21:57:41 -0700 (Wed, 18 May 2016) Log Message Web Inspector: Classes toggle wraps in some localizations https://bugs.webkit.org/show_bug.cgi?id=157878 rdar://problem/26108859 Reviewed by Brian Burg. * UserInterface/Views/CSSStyleDetailsSidebarPanel.css: (.sidebar > .panel.details.css-style > .content ~ .options-container > .toggle-class-toggle): Add white-space: nowrap. Modified Paths trunk/Source/WebInspectorUI/ChangeLog trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDetailsSidebarPanel.css Diff Modified: trunk/Source/WebInspectorUI/ChangeLog (201125 => 201126) --- trunk/Source/WebInspectorUI/ChangeLog 2016-05-19 03:21:05 UTC (rev 201125) +++ trunk/Source/WebInspectorUI/ChangeLog 2016-05-19 04:57:41 UTC (rev 201126) @@ -1,3 +1,15 @@ +2016-05-18 Timothy Hatcher + +Web Inspector: Classes toggle wraps in some localizations +https://bugs.webkit.org/show_bug.cgi?id=157878 +rdar://problem/26108859 + +Reviewed by Brian Burg. + +* UserInterface/Views/CSSStyleDetailsSidebarPanel.css: +(.sidebar > .panel.details.css-style > .content ~ .options-container > .toggle-class-toggle): +Add white-space: nowrap. + 2016-05-18 Matt Baker Web Inspector: unable to switch between navigation tree outlines using up/down arrow keys Modified: trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDetailsSidebarPanel.css (201125 => 201126) --- trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDetailsSidebarPanel.css 2016-05-19 03:21:05 UTC (rev 201125) +++ trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDetailsSidebarPanel.css 2016-05-19 04:57:41 UTC (rev 201126) @@ -103,6 +103,7 @@ background: none; border: none; border-radius: 3px; +white-space: nowrap; -webkit-appearance: none; } ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [201125] trunk/Source/WebInspectorUI
Title: [201125] trunk/Source/WebInspectorUI Revision 201125 Author mattba...@apple.com Date 2016-05-18 20:21:05 -0700 (Wed, 18 May 2016) Log Message Web Inspector: unable to switch between navigation tree outlines using up/down arrow keys https://bugs.webkit.org/show_bug.cgi?id=157713 Reviewed by Timothy Hatcher. * UserInterface/Views/NavigationSidebarPanel.js: (WebInspector.NavigationSidebarPanel.prototype.createContentTreeOutline): Listen for TreeOutline focus changes, and associate trees and their DOM elements for quick lookup when handling focus events. (WebInspector.NavigationSidebarPanel.prototype._contentTreeOutlineDidFocus): (WebInspector.NavigationSidebarPanel.prototype._contentTreeOutlineTreeSelectionDidChange): When selecting a tree element causes an element in a different tree outline to be deselected, remember the old selection so that it can be restored the next time the tree outline get the focus. Modified Paths trunk/Source/WebInspectorUI/ChangeLog trunk/Source/WebInspectorUI/UserInterface/Views/NavigationSidebarPanel.js Diff Modified: trunk/Source/WebInspectorUI/ChangeLog (201124 => 201125) --- trunk/Source/WebInspectorUI/ChangeLog 2016-05-19 03:11:41 UTC (rev 201124) +++ trunk/Source/WebInspectorUI/ChangeLog 2016-05-19 03:21:05 UTC (rev 201125) @@ -1,5 +1,24 @@ 2016-05-18 Matt Baker +Web Inspector: unable to switch between navigation tree outlines using up/down arrow keys +https://bugs.webkit.org/show_bug.cgi?id=157713 + + +Reviewed by Timothy Hatcher. + +* UserInterface/Views/NavigationSidebarPanel.js: +(WebInspector.NavigationSidebarPanel.prototype.createContentTreeOutline): +Listen for TreeOutline focus changes, and associate trees and their DOM +elements for quick lookup when handling focus events. + +(WebInspector.NavigationSidebarPanel.prototype._contentTreeOutlineDidFocus): +(WebInspector.NavigationSidebarPanel.prototype._contentTreeOutlineTreeSelectionDidChange): +When selecting a tree element causes an element in a different tree outline +to be deselected, remember the old selection so that it can be restored +the next time the tree outline get the focus. + +2016-05-18 Matt Baker + Web Inspector: Checkbox disappears when unchecking CSS property with value containing a semicolon https://bugs.webkit.org/show_bug.cgi?id=157862 Modified: trunk/Source/WebInspectorUI/UserInterface/Views/NavigationSidebarPanel.js (201124 => 201125) --- trunk/Source/WebInspectorUI/UserInterface/Views/NavigationSidebarPanel.js 2016-05-19 03:11:41 UTC (rev 201124) +++ trunk/Source/WebInspectorUI/UserInterface/Views/NavigationSidebarPanel.js 2016-05-19 03:21:05 UTC (rev 201125) @@ -153,7 +153,11 @@ contentTreeOutline.hidden = !dontHideByDefault; contentTreeOutline.element.classList.add(WebInspector.NavigationSidebarPanel.ContentTreeOutlineElementStyleClassName); contentTreeOutline.addEventListener(WebInspector.TreeOutline.Event.SelectionDidChange, this._contentTreeOutlineTreeSelectionDidChange, this); +contentTreeOutline.element.addEventListener("focus", this._contentTreeOutlineDidFocus, this); +// FIXME Remove ContentTreeOutlineSymbol once is finished. +contentTreeOutline.element[WebInspector.NavigationSidebarPanel.ContentTreeOutlineSymbol] = contentTreeOutline; + this.contentView.element.appendChild(contentTreeOutline.element); if (!suppressFiltering) { @@ -646,22 +650,35 @@ this.soon._updateContentOverflowShadowVisibility(); } +_contentTreeOutlineDidFocus(event) +{ +let treeOutline = event.target[WebInspector.NavigationSidebarPanel.ContentTreeOutlineSymbol]; +if (!treeOutline) +return; + +let previousSelectedTreeElement = treeOutline[WebInspector.NavigationSidebarPanel.PreviousSelectedTreeElementSymbol]; +if (!previousSelectedTreeElement) +return; + +previousSelectedTreeElement.select(); +} + _contentTreeOutlineTreeSelectionDidChange(event) { -let treeElement = event.data.selectedElement; -if (!treeElement) +let {selectedElement, deselectedElement} = event.data; +if (deselectedElement) +deselectedElement.treeOutline[WebInspector.NavigationSidebarPanel.PreviousSelectedTreeElementSymbol] = deselectedElement; + +if (!selectedElement) return; -this._selectedContentTreeOutline = treeElement.treeOutline; +// Prevent two selections in the sidebar, if the selected tree outline is changing. +let treeOutline = selectedElement.treeOutline; +if (this._selectedContentTreeOutline && this._selectedContentTreeOutline !== treeOutline) +this._selectedContentTreeOutline.selectedTreeElement.deselect(); -// Deselect any other tree elements to prevent two selections in th
[webkit-changes] [201124] trunk/Source/WebCore
Title: [201124] trunk/Source/WebCore Revision 201124 Author za...@apple.com Date 2016-05-18 20:11:41 -0700 (Wed, 18 May 2016) Log Message Make LayoutUnit::operator bool() explicit. https://bugs.webkit.org/show_bug.cgi?id=157871 Reviewed by Simon Fraser. This is in preparation for getting LayoutUnit::operator int() removed. No behaviour change. * platform/LayoutUnit.h: (WebCore::LayoutUnit::operator bool): * rendering/RenderView.cpp: (WebCore::RenderView::initializeLayoutState): Negative page height is invalid. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/LayoutUnit.h trunk/Source/WebCore/rendering/RenderView.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (201123 => 201124) --- trunk/Source/WebCore/ChangeLog 2016-05-19 02:39:54 UTC (rev 201123) +++ trunk/Source/WebCore/ChangeLog 2016-05-19 03:11:41 UTC (rev 201124) @@ -1,3 +1,19 @@ +2016-05-18 Zalan Bujtas + +Make LayoutUnit::operator bool() explicit. +https://bugs.webkit.org/show_bug.cgi?id=157871 + +Reviewed by Simon Fraser. + +This is in preparation for getting LayoutUnit::operator int() removed. + +No behaviour change. + +* platform/LayoutUnit.h: +(WebCore::LayoutUnit::operator bool): +* rendering/RenderView.cpp: +(WebCore::RenderView::initializeLayoutState): Negative page height is invalid. + 2016-05-18 Eric Carlson [iOS] Fullscreen video playback broken in WK1 apps Modified: trunk/Source/WebCore/platform/LayoutUnit.h (201123 => 201124) --- trunk/Source/WebCore/platform/LayoutUnit.h 2016-05-19 02:39:54 UTC (rev 201123) +++ trunk/Source/WebCore/platform/LayoutUnit.h 2016-05-19 03:11:41 UTC (rev 201124) @@ -116,7 +116,7 @@ operator int() const { return toInt(); } operator float() const { return toFloat(); } operator double() const { return toDouble(); } -operator bool() const { return m_value; } +explicit operator bool() const { return m_value; } LayoutUnit& operator++() { Modified: trunk/Source/WebCore/rendering/RenderView.cpp (201123 => 201124) --- trunk/Source/WebCore/rendering/RenderView.cpp 2016-05-19 02:39:54 UTC (rev 201123) +++ trunk/Source/WebCore/rendering/RenderView.cpp 2016-05-19 03:11:41 UTC (rev 201124) @@ -277,7 +277,8 @@ state.m_pageLogicalHeight = m_pageLogicalHeight; state.m_pageLogicalHeightChanged = m_pageLogicalHeightChanged; -state.m_isPaginated = state.m_pageLogicalHeight; +ASSERT(state.m_pageLogicalHeight >= 0); +state.m_isPaginated = state.m_pageLogicalHeight > 0; } // The algorithm below assumes this is a full layout. In case there are previously computed values for regions, supplemental steps are taken ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [201123] trunk/Websites/perf.webkit.org
Title: [201123] trunk/Websites/perf.webkit.org Revision 201123 Author rn...@webkit.org Date 2016-05-18 19:39:54 -0700 (Wed, 18 May 2016) Log Message Analysis task should look for a git commit based on abridged hashes https://bugs.webkit.org/show_bug.cgi?id=157877 Reviewed by Chris Dumez. Made /privileged-api/associate-commit look for commits using LIKE instead of an exact match. Associate the commit when there is exactly one match. * public/include/commit-log-fetcher.php: (CommitLogFetcher::fetch_between): * public/include/db.php: (Database::escape_for_like): Extracted from CommitLogFetcher::fetch_between. * public/privileged-api/associate-commit.php: (main): Look for the commits using LIKE. Reject whenever there are multiple commits. We limit the number of matches to two for performance when the user specifies something that almost thousands of commits: e.g. "1". * public/v3/pages/analysis-task-page.js: (AnalysisTaskPage.prototype._associateCommit): Added human friendly error messages for mismatching commits. Modified Paths trunk/Websites/perf.webkit.org/ChangeLog trunk/Websites/perf.webkit.org/public/include/commit-log-fetcher.php trunk/Websites/perf.webkit.org/public/include/db.php trunk/Websites/perf.webkit.org/public/privileged-api/associate-commit.php trunk/Websites/perf.webkit.org/public/v3/pages/analysis-task-page.js Diff Modified: trunk/Websites/perf.webkit.org/ChangeLog (201122 => 201123) --- trunk/Websites/perf.webkit.org/ChangeLog 2016-05-19 01:27:49 UTC (rev 201122) +++ trunk/Websites/perf.webkit.org/ChangeLog 2016-05-19 02:39:54 UTC (rev 201123) @@ -1,5 +1,26 @@ 2016-05-18 Ryosuke Niwa +Analysis task should look for a git commit based on abridged hashes +https://bugs.webkit.org/show_bug.cgi?id=157877 + + +Reviewed by Chris Dumez. + +Made /privileged-api/associate-commit look for commits using LIKE instead of an exact match. +Associate the commit when there is exactly one match. + +* public/include/commit-log-fetcher.php: +(CommitLogFetcher::fetch_between): +* public/include/db.php: +(Database::escape_for_like): Extracted from CommitLogFetcher::fetch_between. +* public/privileged-api/associate-commit.php: +(main): Look for the commits using LIKE. Reject whenever there are multiple commits. We limit the number of +matches to two for performance when the user specifies something that almost thousands of commits: e.g. "1". +* public/v3/pages/analysis-task-page.js: +(AnalysisTaskPage.prototype._associateCommit): Added human friendly error messages for mismatching commits. + +2016-05-18 Ryosuke Niwa + Unreviewed build fix. Use --date-order so that every child commit appears after its parent. Otherwise we'll hit a FailedToFindParentCommit error while submitting a commit that appears before its parent. Modified: trunk/Websites/perf.webkit.org/public/include/commit-log-fetcher.php (201122 => 201123) --- trunk/Websites/perf.webkit.org/public/include/commit-log-fetcher.php 2016-05-19 01:27:49 UTC (rev 201122) +++ trunk/Websites/perf.webkit.org/public/include/commit-log-fetcher.php 2016-05-19 02:39:54 UTC (rev 201123) @@ -65,7 +65,7 @@ } if ($keyword) { -array_push($values, '%' . str_replace(array('\\', '_', '%'), array('', '\\_', '\\%'), $keyword) . '%'); +array_push($values, '%' . Database::escape_for_like($keyword) . '%'); $keyword_index = '$' . count($values); array_push($values, ltrim($keyword, 'r')); $revision_index = '$' . count($values); Modified: trunk/Websites/perf.webkit.org/public/include/db.php (201122 => 201123) --- trunk/Websites/perf.webkit.org/public/include/db.php 2016-05-19 01:27:49 UTC (rev 201122) +++ trunk/Websites/perf.webkit.org/public/include/db.php 2016-05-19 02:39:54 UTC (rev 201123) @@ -84,6 +84,10 @@ return intval($timestamp_in_s * 1000); } +static function escape_for_like($string) { +return str_replace(array('\\', '_', '%'), array('', '\\_', '\\%'), $string); +} + function connect() { $databaseConfig = config('database'); $this->connection = @pg_connect('host=' . $databaseConfig['host'] . ' port=' . $databaseConfig['port'] Modified: trunk/Websites/perf.webkit.org/public/privileged-api/associate-commit.php (201122 => 201123) --- trunk/Websites/perf.webkit.org/public/privileged-api/associate-commit.php 2016-05-19 01:27:49 UTC (rev 201122) +++ trunk/Websites/perf.webkit.org/public/privileged-api/associate-commit.php 2016-05-19 02:39:54 UTC (rev 201123) @@ -29,13 +29,18 @@ require_format('Kind', $kind, '/^(cause|fix)$/'); $commit_info = array('repository' => $repository_id, 'revision' => $revision); -$commit_row = $db->select_first_row('commits', 'commit', $commit_info); -if (!$commit_row) { +$commit_rows = $db->que
[webkit-changes] [201122] trunk/Source/JavaScriptCore
Title: [201122] trunk/Source/_javascript_Core Revision 201122 Author sbar...@apple.com Date 2016-05-18 18:27:49 -0700 (Wed, 18 May 2016) Log Message Function with default parameter values that are arrow functions that capture this isn't working https://bugs.webkit.org/show_bug.cgi?id=157786 Reviewed by Geoffrey Garen. To make the scopes ordered properly, I needed to initialize the arrow function lexical environment before initializing default parameter values. I also made the code easier to reason about by never reusing the function's var lexical environment for the arrow function lexical environment. The reason for this is that that code was wrong, and we just didn't have code to that properly tested it. It was easy for that code to be wrong because sometimes the function's lexical environment isn't the top-most scope (namely, when a function's parameter list is non-simple) and sometimes it is (when the function's parameter list is simple). Also, because a function's default parameter values may capture the 'arguments' variable inside an arrow function, I needed to take care to initialize the 'arguments' variable as part of whichever scope is the top-most scope. It's either the function's var environment if the parameter list is simple, or it's the function's parameter environment if the parameter list is non-simple. * bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::BytecodeGenerator): (JSC::BytecodeGenerator::initializeDefaultParameterValuesAndSetupFunctionScopeStack): (JSC::BytecodeGenerator::initializeArrowFunctionContextScopeIfNeeded): (JSC::BytecodeGenerator::initializeParameters): (JSC::BytecodeGenerator::initializeVarLexicalEnvironment): (JSC::BytecodeGenerator::visibleNameForParameter): * bytecompiler/BytecodeGenerator.h: * tests/stress/arrow-functions-as-default-parameter-values.js: Added. (assert): (test): (test.foo): * tests/stress/op-push-name-scope-crashes-profiler.js: (test): Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/bytecompiler/BytecodeGenerator.cpp trunk/Source/_javascript_Core/bytecompiler/BytecodeGenerator.h trunk/Source/_javascript_Core/tests/stress/op-push-name-scope-crashes-profiler.js Added Paths trunk/Source/_javascript_Core/tests/stress/arrow-functions-as-default-parameter-values.js Diff Modified: trunk/Source/_javascript_Core/ChangeLog (201121 => 201122) --- trunk/Source/_javascript_Core/ChangeLog 2016-05-19 01:01:21 UTC (rev 201121) +++ trunk/Source/_javascript_Core/ChangeLog 2016-05-19 01:27:49 UTC (rev 201122) @@ -1,3 +1,43 @@ +2016-05-18 Saam barati + +Function with default parameter values that are arrow functions that capture this isn't working +https://bugs.webkit.org/show_bug.cgi?id=157786 + + +Reviewed by Geoffrey Garen. + +To make the scopes ordered properly, I needed to initialize the arrow +function lexical environment before initializing default parameter values. +I also made the code easier to reason about by never reusing the function's +var lexical environment for the arrow function lexical environment. The +reason for this is that that code was wrong, and we just didn't have code to +that properly tested it. It was easy for that code to be wrong because +sometimes the function's lexical environment isn't the top-most scope +(namely, when a function's parameter list is non-simple) and sometimes +it is (when the function's parameter list is simple). + +Also, because a function's default parameter values may capture the +'arguments' variable inside an arrow function, I needed to take care +to initialize the 'arguments' variable as part of whichever scope +is the top-most scope. It's either the function's var environment +if the parameter list is simple, or it's the function's parameter +environment if the parameter list is non-simple. + +* bytecompiler/BytecodeGenerator.cpp: +(JSC::BytecodeGenerator::BytecodeGenerator): +(JSC::BytecodeGenerator::initializeDefaultParameterValuesAndSetupFunctionScopeStack): +(JSC::BytecodeGenerator::initializeArrowFunctionContextScopeIfNeeded): +(JSC::BytecodeGenerator::initializeParameters): +(JSC::BytecodeGenerator::initializeVarLexicalEnvironment): +(JSC::BytecodeGenerator::visibleNameForParameter): +* bytecompiler/BytecodeGenerator.h: +* tests/stress/arrow-functions-as-default-parameter-values.js: Added. +(assert): +(test): +(test.foo): +* tests/stress/op-push-name-scope-crashes-profiler.js: +(test): + 2016-05-18 Michael Saboff r199812 broke test262 Modified: trunk/Source/_javascript_Core/bytecompiler/BytecodeGenerator.cpp (201121 => 201122) --- trunk/Source/_javascript_Core/bytecompiler/BytecodeGenerator.cpp 2016-05-19 01:01:21 UTC (rev 201121) +++ trunk/Source/_javasc
[webkit-changes] [201121] trunk/Source/WTF
Title: [201121] trunk/Source/WTF Revision 201121 Author sbar...@apple.com Date 2016-05-18 18:01:21 -0700 (Wed, 18 May 2016) Log Message StringBuilder::appendQuotedJSONString doesn't properly protect against the math it's doing. Make the math fit the assertion. https://bugs.webkit.org/show_bug.cgi?id=157868 Reviewed by Benjamin Poulain. appendQuotedJSONString was rounding up to the next power of two when resizing its buffer. Lets call the allocation size X. If X > 2^31, then roundUpToPowerOfTwo(X) == 0. This patch fixes this by making the assertion reflect what the code is doing. We now allocate to a size of X = std::max(maximumCapacityRequired , roundUpToPowerOfTwo(maximumCapacityRequired)) * wtf/text/StringBuilder.cpp: (WTF::StringBuilder::appendQuotedJSONString): Modified Paths trunk/Source/WTF/ChangeLog trunk/Source/WTF/wtf/text/StringBuilder.cpp Diff Modified: trunk/Source/WTF/ChangeLog (201120 => 201121) --- trunk/Source/WTF/ChangeLog 2016-05-19 00:45:16 UTC (rev 201120) +++ trunk/Source/WTF/ChangeLog 2016-05-19 01:01:21 UTC (rev 201121) @@ -1,3 +1,19 @@ +2016-05-18 Saam barati + +StringBuilder::appendQuotedJSONString doesn't properly protect against the math it's doing. Make the math fit the assertion. +https://bugs.webkit.org/show_bug.cgi?id=157868 + +Reviewed by Benjamin Poulain. + +appendQuotedJSONString was rounding up to the next power of two when resizing +its buffer. Lets call the allocation size X. If X > 2^31, then +roundUpToPowerOfTwo(X) == 0. This patch fixes this by making the +assertion reflect what the code is doing. We now allocate to a size +of X = std::max(maximumCapacityRequired , roundUpToPowerOfTwo(maximumCapacityRequired)) + +* wtf/text/StringBuilder.cpp: +(WTF::StringBuilder::appendQuotedJSONString): + 2016-05-17 Joseph Pecoraro REGRESSION(r192855): Math.random() always produces the same first 7 decimal points the first two invocations Modified: trunk/Source/WTF/wtf/text/StringBuilder.cpp (201120 => 201121) --- trunk/Source/WTF/wtf/text/StringBuilder.cpp 2016-05-19 00:45:16 UTC (rev 201120) +++ trunk/Source/WTF/wtf/text/StringBuilder.cpp 2016-05-19 01:01:21 UTC (rev 201121) @@ -414,11 +414,14 @@ // The 6 is for characters that need to be \u encoded. size_t maximumCapacityRequired = length() + 2 + string.length() * 6; RELEASE_ASSERT(maximumCapacityRequired < std::numeric_limits::max()); +unsigned allocationSize = maximumCapacityRequired; +// This max() is here to allow us to allocate sizes between the range [2^31, 2^32 - 2] because roundUpToPowerOfTwo(1<<31 + some int smaller than 1<<31) == 0. +allocationSize = std::max(allocationSize, roundUpToPowerOfTwo(allocationSize)); if (is8Bit() && !string.is8Bit()) -allocateBufferUpConvert(m_bufferCharacters8, roundUpToPowerOfTwo(maximumCapacityRequired)); +allocateBufferUpConvert(m_bufferCharacters8, allocationSize); else -reserveCapacity(roundUpToPowerOfTwo(maximumCapacityRequired)); +reserveCapacity(allocationSize); if (is8Bit()) { ASSERT(string.is8Bit()); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [201120] trunk/Websites/perf.webkit.org
Title: [201120] trunk/Websites/perf.webkit.org Revision 201120 Author rn...@webkit.org Date 2016-05-18 17:45:16 -0700 (Wed, 18 May 2016) Log Message Unreviewed build fix. Use --date-order so that every child commit appears after its parent. Otherwise we'll hit a FailedToFindParentCommit error while submitting a commit that appears before its parent. * tools/sync-commits.py: (GitRepository._fetch_all_hashes): Modified Paths trunk/Websites/perf.webkit.org/ChangeLog trunk/Websites/perf.webkit.org/tools/sync-commits.py Diff Modified: trunk/Websites/perf.webkit.org/ChangeLog (201119 => 201120) --- trunk/Websites/perf.webkit.org/ChangeLog 2016-05-19 00:20:26 UTC (rev 201119) +++ trunk/Websites/perf.webkit.org/ChangeLog 2016-05-19 00:45:16 UTC (rev 201120) @@ -1,5 +1,13 @@ 2016-05-18 Ryosuke Niwa +Unreviewed build fix. Use --date-order so that every child commit appears after its parent. +Otherwise we'll hit a FailedToFindParentCommit error while submitting a commit that appears before its parent. + +* tools/sync-commits.py: +(GitRepository._fetch_all_hashes): + +2016-05-18 Ryosuke Niwa + Removed the erroneously committed debug code. * tools/sync-commits.py: Modified: trunk/Websites/perf.webkit.org/tools/sync-commits.py (201119 => 201120) --- trunk/Websites/perf.webkit.org/tools/sync-commits.py 2016-05-19 00:20:26 UTC (rev 201119) +++ trunk/Websites/perf.webkit.org/tools/sync-commits.py 2016-05-19 00:45:16 UTC (rev 201120) @@ -214,7 +214,7 @@ def _fetch_all_hashes(self): self._run_git_command(['pull', self._git_url]) -lines = self._run_git_command(['log', '--all', '--reverse', '--pretty=%H %ct %ce %P']).split('\n') +lines = self._run_git_command(['log', '--all', '--date-order', '--reverse', '--pretty=%H %ct %ce %P']).split('\n') self._tokenized_hashes = [line.split() for line in lines] def _run_git_command(self, args): ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [201119] trunk/Source/WebCore
Title: [201119] trunk/Source/WebCore Revision 201119 Author eric.carl...@apple.com Date 2016-05-18 17:20:26 -0700 (Wed, 18 May 2016) Log Message [iOS] Fullscreen video playback broken in WK1 apps https://bugs.webkit.org/show_bug.cgi?id=157847 Reviewed by Jer Noble. * platform/cocoa/WebVideoFullscreenModelVideoElement.h: (WebCore::WebVideoFullscreenModelVideoElement::playbackSessionModel): New, model accessor. * platform/cocoa/WebVideoFullscreenModelVideoElement.mm: (WebVideoFullscreenModelVideoElement::setWebVideoFullscreenInterface): Set model's playback interface. (WebVideoFullscreenModelVideoElement::setVideoElement): Set model's video element. * platform/ios/WebVideoFullscreenControllerAVKit.mm: (WebVideoFullscreenControllerContext::didCleanupFullscreen): Clear m_sessionModel. (WebVideoFullscreenControllerContext::setVideoDimensions): This is called from both the UI and Web threads, so dispatch to the UI thread when necessary. (WebVideoFullscreenControllerContext::play): Call the model's playback session on the Web thread. (WebVideoFullscreenControllerContext::pause): Ditto. (WebVideoFullscreenControllerContext::togglePlayState): Ditto. (WebVideoFullscreenControllerContext::beginScrubbing): Ditto. (WebVideoFullscreenControllerContext::endScrubbing): Ditto. (WebVideoFullscreenControllerContext::seekToTime): Ditto. (WebVideoFullscreenControllerContext::fastSeek): Ditto. (WebVideoFullscreenControllerContext::beginScanningForward): Ditto. (WebVideoFullscreenControllerContext::beginScanningBackward): Ditto. (WebVideoFullscreenControllerContext::endScanning): Ditto. (WebVideoFullscreenControllerContext::selectAudioMediaOption): Ditto. (WebVideoFullscreenControllerContext::selectLegibleMediaOption): Ditto. (WebVideoFullscreenControllerContext::setUpFullscreen): Create and configure a session model. (WebVideoFullscreenSessionModel::play): Pass call back to the controller. (WebVideoFullscreenSessionModel::pause): Ditto. (WebVideoFullscreenSessionModel::togglePlayState): Ditto. (WebVideoFullscreenSessionModel::beginScrubbing): Ditto. (WebVideoFullscreenSessionModel::endScrubbing): Ditto. (WebVideoFullscreenSessionModel::seekToTime): Ditto. (WebVideoFullscreenSessionModel::fastSeek): Ditto. (WebVideoFullscreenSessionModel::beginScanningForward): Ditto. (WebVideoFullscreenSessionModel::beginScanningBackward): Ditto. (WebVideoFullscreenSessionModel::endScanning): Ditto. (WebVideoFullscreenSessionModel::selectAudioMediaOption): Ditto. (WebVideoFullscreenSessionModel::selectLegibleMediaOption): Ditto. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/cocoa/WebVideoFullscreenModelVideoElement.h trunk/Source/WebCore/platform/cocoa/WebVideoFullscreenModelVideoElement.mm trunk/Source/WebCore/platform/ios/WebVideoFullscreenControllerAVKit.mm Diff Modified: trunk/Source/WebCore/ChangeLog (201118 => 201119) --- trunk/Source/WebCore/ChangeLog 2016-05-19 00:04:48 UTC (rev 201118) +++ trunk/Source/WebCore/ChangeLog 2016-05-19 00:20:26 UTC (rev 201119) @@ -1,3 +1,47 @@ +2016-05-18 Eric Carlson + +[iOS] Fullscreen video playback broken in WK1 apps +https://bugs.webkit.org/show_bug.cgi?id=157847 + + +Reviewed by Jer Noble. + +* platform/cocoa/WebVideoFullscreenModelVideoElement.h: +(WebCore::WebVideoFullscreenModelVideoElement::playbackSessionModel): New, model accessor. +* platform/cocoa/WebVideoFullscreenModelVideoElement.mm: +(WebVideoFullscreenModelVideoElement::setWebVideoFullscreenInterface): Set model's playback interface. +(WebVideoFullscreenModelVideoElement::setVideoElement): Set model's video element. + +* platform/ios/WebVideoFullscreenControllerAVKit.mm: +(WebVideoFullscreenControllerContext::didCleanupFullscreen): Clear m_sessionModel. +(WebVideoFullscreenControllerContext::setVideoDimensions): This is called from both the UI and + Web threads, so dispatch to the UI thread when necessary. +(WebVideoFullscreenControllerContext::play): Call the model's playback session on the Web thread. +(WebVideoFullscreenControllerContext::pause): Ditto. +(WebVideoFullscreenControllerContext::togglePlayState): Ditto. +(WebVideoFullscreenControllerContext::beginScrubbing): Ditto. +(WebVideoFullscreenControllerContext::endScrubbing): Ditto. +(WebVideoFullscreenControllerContext::seekToTime): Ditto. +(WebVideoFullscreenControllerContext::fastSeek): Ditto. +(WebVideoFullscreenControllerContext::beginScanningForward): Ditto. +(WebVideoFullscreenControllerContext::beginScanningBackward): Ditto. +(WebVideoFullscreenControllerContext::endScanning): Ditto. +(WebVideoFullscreenControllerContext::selectAudioMediaOption): Ditto. +(WebVideoFullscreenControllerContext::selectLegibleMediaOption): Ditto. +(WebVideoFullscreenControllerContext::setUpFullscreen): Create and configure a session
[webkit-changes] [201118] trunk/Source/WebKit2
Title: [201118] trunk/Source/WebKit2 Revision 201118 Author ander...@apple.com Date 2016-05-18 17:04:48 -0700 (Wed, 18 May 2016) Log Message Add WKPreferencesRef getter/setter pair to set RTL mode https://bugs.webkit.org/show_bug.cgi?id=157873 rdar://problem/26329970 Reviewed by Tim Horton. * UIProcess/API/C/WKPreferences.cpp: (WKPreferencesSetUserInterfaceDirectionPolicy): (WKPreferencesGetUserInterfaceDirectionPolicy): * UIProcess/API/C/WKPreferencesRef.h: Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/API/C/WKPreferences.cpp trunk/Source/WebKit2/UIProcess/API/C/WKPreferencesRef.h Diff Modified: trunk/Source/WebKit2/ChangeLog (201117 => 201118) --- trunk/Source/WebKit2/ChangeLog 2016-05-18 23:55:25 UTC (rev 201117) +++ trunk/Source/WebKit2/ChangeLog 2016-05-19 00:04:48 UTC (rev 201118) @@ -1,3 +1,16 @@ +2016-05-18 Anders Carlsson + +Add WKPreferencesRef getter/setter pair to set RTL mode +https://bugs.webkit.org/show_bug.cgi?id=157873 +rdar://problem/26329970 + +Reviewed by Tim Horton. + +* UIProcess/API/C/WKPreferences.cpp: +(WKPreferencesSetUserInterfaceDirectionPolicy): +(WKPreferencesGetUserInterfaceDirectionPolicy): +* UIProcess/API/C/WKPreferencesRef.h: + 2016-05-18 Alex Christensen Clean up CSS code Modified: trunk/Source/WebKit2/UIProcess/API/C/WKPreferences.cpp (201117 => 201118) --- trunk/Source/WebKit2/UIProcess/API/C/WKPreferences.cpp 2016-05-18 23:55:25 UTC (rev 201117) +++ trunk/Source/WebKit2/UIProcess/API/C/WKPreferences.cpp 2016-05-19 00:04:48 UTC (rev 201118) @@ -1466,6 +1466,16 @@ return toImpl(preferencesRef)->allowsAirPlayForMediaPlayback(); } +void WKPreferencesSetUserInterfaceDirectionPolicy(WKPreferencesRef preferencesRef, _WKUserInterfaceDirectionPolicy userInterfaceDirectionPolicy) +{ +toImpl(preferencesRef)->setUserInterfaceDirectionPolicy(userInterfaceDirectionPolicy); +} + +_WKUserInterfaceDirectionPolicy WKPreferencesGetUserInterfaceDirectionPolicy(WKPreferencesRef preferencesRef) +{ +return static_cast<_WKUserInterfaceDirectionPolicy>(toImpl(preferencesRef)->userInterfaceDirectionPolicy()); +} + void WKPreferencesSetResourceUsageOverlayVisible(WKPreferencesRef preferencesRef, bool enabled) { toImpl(preferencesRef)->setResourceUsageOverlayVisible(enabled); Modified: trunk/Source/WebKit2/UIProcess/API/C/WKPreferencesRef.h (201117 => 201118) --- trunk/Source/WebKit2/UIProcess/API/C/WKPreferencesRef.h 2016-05-18 23:55:25 UTC (rev 201117) +++ trunk/Source/WebKit2/UIProcess/API/C/WKPreferencesRef.h 2016-05-19 00:04:48 UTC (rev 201118) @@ -49,6 +49,12 @@ }; typedef unsigned WKDebugOverlayRegions; +enum _WKUserInterfaceDirectionPolicy { +kWKUserInterfaceDirectionPolicyContent, +kWKUserInterfaceDirectionPolicySystem, +}; +typedef enum _WKUserInterfaceDirectionPolicy _WKUserInterfaceDirectionPolicy; + WK_EXPORT WKTypeID WKPreferencesGetTypeID(); WK_EXPORT WKPreferencesRef WKPreferencesCreate(); @@ -266,6 +272,10 @@ WK_EXPORT void WKPreferencesSetAllowsAirPlayForMediaPlayback(WKPreferencesRef preferencesRef, bool enabled); WK_EXPORT bool WKPreferencesGetAllowsAirPlayForMediaPlayback(WKPreferencesRef preferencesRef); +// Defaults to kWKUserInterfaceDirectionPolicyContent. +WK_EXPORT void WKPreferencesSetUserInterfaceDirectionPolicy(WKPreferencesRef preferencesRef, _WKUserInterfaceDirectionPolicy userInterfaceDirectionPolicy); +WK_EXPORT _WKUserInterfaceDirectionPolicy WKPreferencesGetUserInterfaceDirectionPolicy(WKPreferencesRef preferencesRef); + #ifdef __cplusplus } #endif ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [201117] trunk/Tools
Title: [201117] trunk/Tools Revision 201117 Author aakash_j...@apple.com Date 2016-05-18 16:55:25 -0700 (Wed, 18 May 2016) Log Message Remove underline from Status Bubbles on dashboard https://bugs.webkit.org/show_bug.cgi?id=157870 rdar://problem/26332321 Reviewed by Alexey Proskuryakov. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css: Reverted style change made in http://trac.webkit.org/r200880 Modified Paths trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css trunk/Tools/ChangeLog Diff Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css (201116 => 201117) --- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css 2016-05-18 23:49:50 UTC (rev 201116) +++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css 2016-05-18 23:55:25 UTC (rev 201117) @@ -38,7 +38,7 @@ text-decoration: none; } -a:hover:link { +a:hover { text-decoration: underline; } Modified: trunk/Tools/ChangeLog (201116 => 201117) --- trunk/Tools/ChangeLog 2016-05-18 23:49:50 UTC (rev 201116) +++ trunk/Tools/ChangeLog 2016-05-18 23:55:25 UTC (rev 201117) @@ -1,3 +1,14 @@ +2016-05-18 Aakash Jain + +Remove underline from Status Bubbles on dashboard +https://bugs.webkit.org/show_bug.cgi?id=157870 +rdar://problem/26332321 + +Reviewed by Alexey Proskuryakov. + +* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css: Reverted style +change made in http://trac.webkit.org/r200880 + 2016-05-18 Michael Saboff r199812 broke test262 ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [201116] trunk/Websites/perf.webkit.org
Title: [201116] trunk/Websites/perf.webkit.org Revision 201116 Author rn...@webkit.org Date 2016-05-18 16:49:50 -0700 (Wed, 18 May 2016) Log Message Removed the erroneously committed debug code. * tools/sync-commits.py: (GitRepository.fetch_commit): Modified Paths trunk/Websites/perf.webkit.org/ChangeLog trunk/Websites/perf.webkit.org/tools/sync-commits.py Diff Modified: trunk/Websites/perf.webkit.org/ChangeLog (201115 => 201116) --- trunk/Websites/perf.webkit.org/ChangeLog 2016-05-18 23:42:39 UTC (rev 201115) +++ trunk/Websites/perf.webkit.org/ChangeLog 2016-05-18 23:49:50 UTC (rev 201116) @@ -1,5 +1,12 @@ 2016-05-18 Ryosuke Niwa +Removed the erroneously committed debug code. + +* tools/sync-commits.py: +(GitRepository.fetch_commit): + +2016-05-18 Ryosuke Niwa + Perf dashboard should have a script to sync git commits https://bugs.webkit.org/show_bug.cgi?id=157867 Modified: trunk/Websites/perf.webkit.org/tools/sync-commits.py (201115 => 201116) --- trunk/Websites/perf.webkit.org/tools/sync-commits.py 2016-05-18 23:42:39 UTC (rev 201115) +++ trunk/Websites/perf.webkit.org/tools/sync-commits.py 2016-05-18 23:49:50 UTC (rev 201116) @@ -190,7 +190,6 @@ return None current_hash = tokens[0] -print 'current:', tokens commit_time = int(tokens[1]) author_email = tokens[2] parent_hash = tokens[3] if len(tokens) >= 4 else None ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [201115] trunk/Websites/perf.webkit.org
Title: [201115] trunk/Websites/perf.webkit.org Revision 201115 Author rn...@webkit.org Date 2016-05-18 16:42:39 -0700 (Wed, 18 May 2016) Log Message Perf dashboard should have a script to sync git commits https://bugs.webkit.org/show_bug.cgi?id=157867 Reviewed by Chris Dumez. Added the support to pull from a Git repo to pull-svn.py and renamed it to sync-commits.py. Added two classes SVNRepository and GitRepository which inherits from an abstract class, Repository. The code that fetches commit and format revision number / git hash is specialized in each. * Install.md: * tools/pull-svn.py: Removed. * tools/sync-commits.py: Renamed from Websites/perf.webkit.org/tools/pull-svn.py. (main): Renamed --svn-config-json to --repository-config-json. Also made it robust against exceptions inside fetch_commits_and_submit of each Repository class. (load_repository): A factory function for SVNRepository and GitRepository. (Repository): Added. (Repository.__init__): Added. (Repository.fetch_commits_and_submit): Extracted from standalone fetch_commits_and_submit. (Repository.fetch_commit): Added. Implemented by a subclass. (Repository.format_revision): Ditto. (Repository.determine_last_reported_revision): Extracted from alonealone determine_first_revision_to_fetch. The fallback to use "oldest" has been moved to SVNRepository's fetch_commit since it doesn't work in Git. (Repository.fetch_revision_from_dasbhoard): Extracted from fetch_revision_from_dasbhoard. (SVNRepository): Added. (SVNRepository.__init__): Added. (SVNRepository.fetch_commit): Extracted from standalone fetch_commit_and_resolve_author and fetch_commit. (SVNRepository._resolve_author_name): Renamed from resolve_author_name_from_account. (SVNRepository.format_revision): Added. (GitRepository): Added. (GitRepository.__init__): (GitRepository.fetch_commit): Added. Fetches the list of all git hashes if needed, and finds the next hash. (GitRepository._find_next_hash): Added. Finds the first commit that appears after the specified hash. (GitRepository._fetch_all_hashes): Added. Gets the list of all git hashs chronologically (old to new). (GitRepository._run_git_command): Added. (GitRepository.format_revision): Added. Use the first 8 characters of the hash. Modified Paths trunk/Websites/perf.webkit.org/ChangeLog trunk/Websites/perf.webkit.org/Install.md Added Paths trunk/Websites/perf.webkit.org/tools/sync-commits.py Removed Paths trunk/Websites/perf.webkit.org/tools/pull-svn.py Diff Modified: trunk/Websites/perf.webkit.org/ChangeLog (201114 => 201115) --- trunk/Websites/perf.webkit.org/ChangeLog 2016-05-18 23:25:47 UTC (rev 201114) +++ trunk/Websites/perf.webkit.org/ChangeLog 2016-05-18 23:42:39 UTC (rev 201115) @@ -1,3 +1,43 @@ +2016-05-18 Ryosuke Niwa + +Perf dashboard should have a script to sync git commits +https://bugs.webkit.org/show_bug.cgi?id=157867 + +Reviewed by Chris Dumez. + +Added the support to pull from a Git repo to pull-svn.py and renamed it to sync-commits.py. + +Added two classes SVNRepository and GitRepository which inherits from an abstract class, Repository. +The code that fetches commit and format revision number / git hash is specialized in each. + +* Install.md: +* tools/pull-svn.py: Removed. +* tools/sync-commits.py: Renamed from Websites/perf.webkit.org/tools/pull-svn.py. +(main): Renamed --svn-config-json to --repository-config-json. Also made it robust against exceptions +inside fetch_commits_and_submit of each Repository class. +(load_repository): A factory function for SVNRepository and GitRepository. +(Repository): Added. +(Repository.__init__): Added. +(Repository.fetch_commits_and_submit): Extracted from standalone fetch_commits_and_submit. +(Repository.fetch_commit): Added. Implemented by a subclass. +(Repository.format_revision): Ditto. +(Repository.determine_last_reported_revision): Extracted from alonealone +determine_first_revision_to_fetch. The fallback to use "oldest" has been moved to SVNRepository's +fetch_commit since it doesn't work in Git. +(Repository.fetch_revision_from_dasbhoard): Extracted from fetch_revision_from_dasbhoard. +(SVNRepository): Added. +(SVNRepository.__init__): Added. +(SVNRepository.fetch_commit): Extracted from standalone fetch_commit_and_resolve_author and fetch_commit. +(SVNRepository._resolve_author_name): Renamed from resolve_author_name_from_account. +(SVNRepository.format_revision): Added. +(GitRepository): Added. +(GitRepository.__init__): +(GitRepository.fetch_commit): Added. Fetches the list of all git hashes if needed, and finds the next hash. +(GitRepository._find_next_hash): Added. Finds the first commit that appears after the specified hash. +(GitRepository._fetch_all_hashes): Added. Gets the list of all git ha
[webkit-changes] [201114] trunk/Source
Title: [201114] trunk/Source Revision 201114 Author za...@apple.com Date 2016-05-18 16:25:47 -0700 (Wed, 18 May 2016) Log Message Remove LayoutUnit::operator unsigned(). https://bugs.webkit.org/show_bug.cgi?id=157856 Reviewed by Simon Fraser. Converting LayoutUnit values to unsigned is lossy. We should avoid such implicit conversions. No behaviour change. * html/ImageInputType.cpp: (WebCore::ImageInputType::height): (WebCore::ImageInputType::width): * page/EventHandler.cpp: (WebCore::EventHandler::hitTestResultAtPoint): * platform/LayoutUnit.h: (WebCore::LayoutUnit::operator unsigned): Deleted. * rendering/RenderBlockFlow.cpp: (WebCore::RenderBlockFlow::computeColumnCountAndWidth): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/html/ImageInputType.cpp trunk/Source/WebCore/page/EventHandler.cpp trunk/Source/WebCore/platform/LayoutUnit.h trunk/Source/WebCore/rendering/RenderBlockFlow.cpp trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (201113 => 201114) --- trunk/Source/WebCore/ChangeLog 2016-05-18 23:09:09 UTC (rev 201113) +++ trunk/Source/WebCore/ChangeLog 2016-05-18 23:25:47 UTC (rev 201114) @@ -1,3 +1,25 @@ +2016-05-18 Zalan Bujtas + +Remove LayoutUnit::operator unsigned(). +https://bugs.webkit.org/show_bug.cgi?id=157856 + +Reviewed by Simon Fraser. + +Converting LayoutUnit values to unsigned is lossy. We should avoid +such implicit conversions. + +No behaviour change. + +* html/ImageInputType.cpp: +(WebCore::ImageInputType::height): +(WebCore::ImageInputType::width): +* page/EventHandler.cpp: +(WebCore::EventHandler::hitTestResultAtPoint): +* platform/LayoutUnit.h: +(WebCore::LayoutUnit::operator unsigned): Deleted. +* rendering/RenderBlockFlow.cpp: +(WebCore::RenderBlockFlow::computeColumnCountAndWidth): + 2016-05-18 Alex Christensen Clean up CSS code Modified: trunk/Source/WebCore/html/ImageInputType.cpp (201113 => 201114) --- trunk/Source/WebCore/html/ImageInputType.cpp 2016-05-18 23:09:09 UTC (rev 201113) +++ trunk/Source/WebCore/html/ImageInputType.cpp 2016-05-18 23:25:47 UTC (rev 201114) @@ -182,7 +182,7 @@ // If the image is available, use its height. HTMLImageLoader* imageLoader = element->imageLoader(); if (imageLoader && imageLoader->image()) -return imageLoader->image()->imageSizeForRenderer(element->renderer(), 1).height(); +return imageLoader->image()->imageSizeForRenderer(element->renderer(), 1).height().toUnsigned(); } element->document().updateLayout(); @@ -203,7 +203,7 @@ // If the image is available, use its width. HTMLImageLoader* imageLoader = element->imageLoader(); if (imageLoader && imageLoader->image()) -return imageLoader->image()->imageSizeForRenderer(element->renderer(), 1).width(); +return imageLoader->image()->imageSizeForRenderer(element->renderer(), 1).width().toUnsigned(); } element->document().updateLayout(); Modified: trunk/Source/WebCore/page/EventHandler.cpp (201113 => 201114) --- trunk/Source/WebCore/page/EventHandler.cpp 2016-05-18 23:09:09 UTC (rev 201113) +++ trunk/Source/WebCore/page/EventHandler.cpp 2016-05-18 23:25:47 UTC (rev 201114) @@ -1131,7 +1131,9 @@ } } -HitTestResult result(point, padding.height(), padding.width(), padding.height(), padding.width()); +unsigned nonNegativePaddingWidth = std::max(0, padding.width()).toUnsigned(); +unsigned nonNegativePaddingHeight = std::max(0, padding.height()).toUnsigned(); +HitTestResult result(point, nonNegativePaddingHeight, nonNegativePaddingWidth, nonNegativePaddingHeight, nonNegativePaddingWidth); RenderView* renderView = m_frame.contentRenderer(); if (!renderView) Modified: trunk/Source/WebCore/platform/LayoutUnit.h (201113 => 201114) --- trunk/Source/WebCore/platform/LayoutUnit.h 2016-05-18 23:09:09 UTC (rev 201113) +++ trunk/Source/WebCore/platform/LayoutUnit.h 2016-05-18 23:25:47 UTC (rev 201114) @@ -114,7 +114,6 @@ unsigned toUnsigned() const { REPORT_OVERFLOW(m_value >= 0); return toInt(); } operator int() const { return toInt(); } -operator unsigned() const { return toUnsigned(); } operator float() const { return toFloat(); } operator double() const { return toDouble(); } operator bool() const { return m_value; } Modified: trunk/Source/WebCore/rendering/RenderBlockFlow.cpp (201113 => 201114) --- trunk/Source/WebCore/rendering/RenderBlockFlow.cpp 2016-05-18 23:09:09 UTC (rev 201113) +++ trunk/Source/WebCore/rendering/RenderBlockFlow.cpp 2016-05-18 23:25:47 UTC (rev 201114) @@ -412,16 +412,16 @@ LayoutUnit availWidth = desiredColumnWidth; LayoutUnit colGap = columnGap(); LayoutUnit colWidth = std::max(LayoutUnit::fromPixel(1), LayoutUnit(style().columnWidth()
[webkit-changes] [201113] trunk/Source
Title: [201113] trunk/Source Revision 201113 Author achristen...@apple.com Date 2016-05-18 16:09:09 -0700 (Wed, 18 May 2016) Log Message Clean up CSS code https://bugs.webkit.org/show_bug.cgi?id=157808 Reviewed by Chris Dumez. Source/WebCore: No new tests. Just cleaning up and modernizing code. * css/BasicShapeFunctions.cpp: (WebCore::convertToCenterCoordinate): (WebCore::cssValueToBasicShapeRadius): (WebCore::basicShapeForValue): * css/BasicShapeFunctions.h: * css/CSSAnimationTriggerScrollValue.h: (WebCore::CSSAnimationTriggerScrollValue::create): (WebCore::CSSAnimationTriggerScrollValue::startValue): (WebCore::CSSAnimationTriggerScrollValue::CSSAnimationTriggerScrollValue): * css/CSSAspectRatioValue.h: * css/CSSBasicShapes.h: * css/CSSBorderImage.cpp: (WebCore::createBorderImageValue): * css/CSSBorderImage.h: * css/CSSBorderImageSliceValue.h: (WebCore::CSSBorderImageSliceValue::create): * css/CSSCalculationValue.h: * css/CSSCanvasValue.h: (WebCore::CSSCanvasValue::CSSCanvasValue): * css/CSSComputedStyleDeclaration.cpp: (WebCore::valueForNinePieceImageSlice): (WebCore::valueForNinePieceImageQuad): (WebCore::valueForNinePieceImage): (WebCore::zoomAdjustedPixelValue): * css/CSSComputedStyleDeclaration.h: * css/CSSFontFaceLoadEvent.cpp: (WebCore::CSSFontFaceLoadEvent::CSSFontFaceLoadEvent): * css/CSSFontFaceLoadEvent.h: * css/CSSFontValue.h: * css/CSSFunctionValue.h: * css/CSSGradientValue.h: (WebCore::CSSGradientValue::setFirstX): (WebCore::CSSGradientValue::setFirstY): (WebCore::CSSGradientValue::setSecondX): (WebCore::CSSGradientValue::setSecondY): (WebCore::CSSGradientValue::addStop): (WebCore::CSSLinearGradientValue::create): (WebCore::CSSLinearGradientValue::setAngle): (WebCore::CSSRadialGradientValue::setFirstRadius): (WebCore::CSSRadialGradientValue::setSecondRadius): (WebCore::CSSRadialGradientValue::setShape): (WebCore::CSSRadialGradientValue::setSizingBehavior): (WebCore::CSSRadialGradientValue::setEndHorizontalSize): (WebCore::CSSRadialGradientValue::setEndVerticalSize): * css/CSSGroupingRule.cpp: (WebCore::CSSGroupingRule::item): (WebCore::CSSGroupingRule::cssRules): * css/CSSKeyframesRule.cpp: (WebCore::CSSKeyframesRule::cssRules): * css/CSSParser.cpp: (WebCore::CSSParser::addProperty): (WebCore::CSSParser::rollbackLastProperties): (WebCore::CSSParser::parseDashboardRegions): (WebCore::CSSParser::parseClipShape): (WebCore::CSSParser::parseBasicShapeCircle): (WebCore::BorderImageParseContext::commitWebKitBorderImage): (WebCore::BorderImageParseContext::commitBorderImage): (WebCore::BorderImageSliceParseContext::commitBorderImageSlice): (WebCore::BorderImageQuadParseContext::commitBorderImageQuad): (WebCore::CSSParser::parseDeprecatedRadialGradient): (WebCore::CSSParser::parseRadialGradient): * css/CSSParser.h: (WebCore::cssyylex): * css/CSSPrimitiveValue.h: * css/CSSProperty.cpp: * css/CSSProperty.h: (WebCore::CSSProperty::CSSProperty): * css/CSSRule.h: * css/CSSRuleList.h: * css/CSSSegmentedFontFace.h: * css/Counter.h: (WebCore::Counter::create): (WebCore::Counter::identifier): (WebCore::Counter::listStyleIdent): (WebCore::Counter::setIdentifier): (WebCore::Counter::setListStyle): (WebCore::Counter::setSeparator): (WebCore::Counter::equals): (WebCore::Counter::cloneForCSSOM): (WebCore::Counter::Counter): * css/Pair.h: * css/Rect.h: (WebCore::RectBase::bottom): (WebCore::RectBase::left): (WebCore::RectBase::setTop): (WebCore::RectBase::setRight): (WebCore::RectBase::setBottom): (WebCore::RectBase::setLeft): (WebCore::RectBase::equals): * css/SVGCSSComputedStyleDeclaration.cpp: (WebCore::strokeDashArrayToCSSValueList): (WebCore::ComputedStyleExtractor::adjustSVGPaintForCurrentColor): * css/StyleBuilderConverter.h: (WebCore::StyleBuilderConverter::convertClipPath): (WebCore::StyleBuilderConverter::convertShapeValue): * css/StyleProperties.cpp: (WebCore::StyleProperties::borderPropertyValue): (WebCore::StyleProperties::getPropertyCSSValue): (WebCore::StyleProperties::getPropertyCSSValueInternal): (WebCore::MutableStyleProperties::setCustomProperty): (WebCore::MutableStyleProperties::setProperty): * css/StyleProperties.h: (WebCore::StyleProperties::isEmpty): (isType): * css/StylePropertyShorthand.cpp: * css/StylePropertyShorthand.h: (WebCore::StylePropertyShorthand::StylePropertyShorthand): (WebCore::StylePropertyShorthand::id): * css/StyleResolver.cpp: (WebCore::StyleResolver::appendAuthorStyleSheets): (WebCore::StyleResolver::addKeyframeStyle): (WebCore::StyleResolver::~StyleResolver): (WebCore::StyleResolver::resolvedVariableValue): (WebCore::StyleResolver::styleImage): (WebCore::StyleResolver::cachedOrPendingFromValue): (WebCore::StyleResolver::generatedOrPendingFromValue): (WebCore::StyleResolver::createFilterOperations): (WebCore::StyleResolver::loadPendingImage): * css/StyleResolver.h: (WebCore::StyleResolver::hasViewportDependentMediaQueries): (WebCore::StyleResolver::state): (WebCore::checkRegionSelector): * css/StyleSheetList.h: * css/WebKitCSSFilterValue.cpp: * css/WebKitCSS
[webkit-changes] [201112] tags/Safari-601.1.46.143/
Title: [201112] tags/Safari-601.1.46.143/ Revision 201112 Author bshaf...@apple.com Date 2016-05-18 16:08:16 -0700 (Wed, 18 May 2016) Log Message New tag. Added Paths tags/Safari-601.1.46.143/ Diff Property changes: tags/Safari-601.1.46.143 Added: svn:ignore depcomp compile config.guess GNUmakefile.in config.sub ltmain.sh aconfig.h.in autom4te.cache missing aclocal.m4 install-sh autotoolsconfig.h.in INSTALL README gtk-doc.make out Makefile.chromium WebKitSupportLibrary.zip WebKitBuild Added: svn:mergeinfo ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [201111] trunk/Source/WebInspectorUI
Title: [20] trunk/Source/WebInspectorUI Revision 20 Author mattba...@apple.com Date 2016-05-18 16:01:53 -0700 (Wed, 18 May 2016) Log Message Web Inspector: Checkbox disappears when unchecking CSS property with value containing a semicolon https://bugs.webkit.org/show_bug.cgi?id=157862 Reviewed by Timothy Hatcher. * UserInterface/Views/CSSStyleDeclarationTextEditor.js: (WebInspector.CSSStyleDeclarationTextEditor.prototype._createCommentedCheckboxMarker): Modify regex to match CSS properties with url() and quoted values, which can contain semicolons. Modified Paths trunk/Source/WebInspectorUI/ChangeLog trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationTextEditor.js Diff Modified: trunk/Source/WebInspectorUI/ChangeLog (201110 => 20) --- trunk/Source/WebInspectorUI/ChangeLog 2016-05-18 22:52:09 UTC (rev 201110) +++ trunk/Source/WebInspectorUI/ChangeLog 2016-05-18 23:01:53 UTC (rev 20) @@ -1,3 +1,16 @@ +2016-05-18 Matt Baker + +Web Inspector: Checkbox disappears when unchecking CSS property with value containing a semicolon +https://bugs.webkit.org/show_bug.cgi?id=157862 + + +Reviewed by Timothy Hatcher. + +* UserInterface/Views/CSSStyleDeclarationTextEditor.js: +(WebInspector.CSSStyleDeclarationTextEditor.prototype._createCommentedCheckboxMarker): +Modify regex to match CSS properties with url() and quoted values, +which can contain semicolons. + 2016-05-18 Nikita Vasilyev Web Inspector: ugly gaps in Call Trees data grid when expanding more than one level Modified: trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationTextEditor.js (201110 => 20) --- trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationTextEditor.js 2016-05-18 22:52:09 UTC (rev 201110) +++ trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationTextEditor.js 2016-05-18 23:01:53 UTC (rev 20) @@ -835,7 +835,7 @@ return; // Matches a comment like: /* -webkit-foo: bar; */ -var commentedPropertyRegex = /\/\*\s*[-\w]+\s*:\s*[^;]+;?\s*\*\//g; +let commentedPropertyRegex = /\/\*\s*[-\w]+\s*\:\s*(?:(?:\".*\"|url\(.+\)|[^;])\s*)+;?\s*\*\//g; var match = commentedPropertyRegex.exec(lineHandle.text); if (!match) ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [201110] trunk/Source/WebKit2
Title: [201110] trunk/Source/WebKit2 Revision 201110 Author jer.no...@apple.com Date 2016-05-18 15:52:09 -0700 (Wed, 18 May 2016) Log Message Disable default user gesture requirement for audio playback on Mac https://bugs.webkit.org/show_bug.cgi?id=157820 Reviewed by Sam Weinig. Disable the WebPreferences and matching WKWebViewConfiguration.mediaTypesRequiringUserActionForPlayback settings on Mac (and other non-iOS ports). * Shared/WebPreferencesDefinitions.h: * UIProcess/API/Cocoa/WKWebViewConfiguration.mm: (-[WKWebViewConfiguration init]): Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/Shared/WebPreferencesDefinitions.h trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfiguration.mm Diff Modified: trunk/Source/WebKit2/ChangeLog (201109 => 201110) --- trunk/Source/WebKit2/ChangeLog 2016-05-18 22:49:32 UTC (rev 201109) +++ trunk/Source/WebKit2/ChangeLog 2016-05-18 22:52:09 UTC (rev 201110) @@ -1,3 +1,17 @@ +2016-05-18 Jer Noble + +Disable default user gesture requirement for audio playback on Mac +https://bugs.webkit.org/show_bug.cgi?id=157820 + +Reviewed by Sam Weinig. + +Disable the WebPreferences and matching WKWebViewConfiguration.mediaTypesRequiringUserActionForPlayback +settings on Mac (and other non-iOS ports). + +* Shared/WebPreferencesDefinitions.h: +* UIProcess/API/Cocoa/WKWebViewConfiguration.mm: +(-[WKWebViewConfiguration init]): + 2016-05-18 Alex Christensen Build fix when not using CredentialStorage with NetworkSession. Modified: trunk/Source/WebKit2/Shared/WebPreferencesDefinitions.h (201109 => 201110) --- trunk/Source/WebKit2/Shared/WebPreferencesDefinitions.h 2016-05-18 22:49:32 UTC (rev 201109) +++ trunk/Source/WebKit2/Shared/WebPreferencesDefinitions.h 2016-05-18 22:52:09 UTC (rev 201110) @@ -56,12 +56,10 @@ #define DEFAULT_HIDDEN_PAGE_DOM_TIMER_THROTTLING_ENABLED true #define DEFAULT_HIDDEN_PAGE_CSS_ANIMATION_SUSPENSION_ENABLED true #define DEFAULT_PDFPLUGIN_ENABLED true -#define DEFAULT_REQUIRES_USER_GESTURE_FOR_AUDIO_PLAYBACK true #else #define DEFAULT_HIDDEN_PAGE_DOM_TIMER_THROTTLING_ENABLED false #define DEFAULT_HIDDEN_PAGE_CSS_ANIMATION_SUSPENSION_ENABLED false #define DEFAULT_PDFPLUGIN_ENABLED false -#define DEFAULT_REQUIRES_USER_GESTURE_FOR_AUDIO_PLAYBACK false #endif #if PLATFORM(IOS) @@ -78,6 +76,7 @@ #define DEFAULT_MEDIA_DATA_LOADS_AUTOMATICALLY false #define DEFAULT_MEDIA_CONTROLS_SCALE_WITH_PAGE_ZOOM false #define DEFAULT_TEMPORARY_TILE_COHORT_RETENTION_ENABLED false +#define DEFAULT_REQUIRES_USER_GESTURE_FOR_AUDIO_PLAYBACK true #else #define DEFAULT_BACKSPACE_KEY_NAVIGATION_ENABLED true #define DEFAULT_FRAME_FLATTENING_ENABLED false @@ -92,6 +91,7 @@ #define DEFAULT_MEDIA_DATA_LOADS_AUTOMATICALLY true #define DEFAULT_MEDIA_CONTROLS_SCALE_WITH_PAGE_ZOOM true #define DEFAULT_TEMPORARY_TILE_COHORT_RETENTION_ENABLED true +#define DEFAULT_REQUIRES_USER_GESTURE_FOR_AUDIO_PLAYBACK false #endif #if PLATFORM(IOS_SIMULATOR) Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfiguration.mm (201109 => 201110) --- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfiguration.mm 2016-05-18 22:49:32 UTC (rev 201109) +++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfiguration.mm 2016-05-18 22:52:09 UTC (rev 201110) @@ -136,14 +136,15 @@ _allowsInlineMediaPlayback = WebCore::deviceClass() == MGDeviceClassiPad; _inlineMediaPlaybackRequiresPlaysInlineAttribute = !_allowsInlineMediaPlayback; _mediaDataLoadsAutomatically = NO; +if (linkedOnOrAfter(WebKit::LibraryVersion::FirstWithMediaTypesRequiringUserActionForPlayback)) +_mediaTypesRequiringUserActionForPlayback = WKAudiovisualMediaTypeAudio; +else +_mediaTypesRequiringUserActionForPlayback = WKAudiovisualMediaTypeAll; #else +_mediaTypesRequiringUserActionForPlayback = WKAudiovisualMediaTypeNone; _mediaDataLoadsAutomatically = YES; _userInterfaceDirectionPolicy = WKUserInterfaceDirectionPolicyContent; #endif -if (linkedOnOrAfter(WebKit::LibraryVersion::FirstWithMediaTypesRequiringUserActionForPlayback)) -_mediaTypesRequiringUserActionForPlayback = WKAudiovisualMediaTypeAudio; -else -_mediaTypesRequiringUserActionForPlayback = WKAudiovisualMediaTypeAll; _mainContentUserGestureOverrideEnabled = NO; _invisibleAutoplayNotPermitted = NO; ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [201109] trunk
Title: [201109] trunk Revision 201109 Author jer.no...@apple.com Date 2016-05-18 15:49:32 -0700 (Wed, 18 May 2016) Log Message webkitEnterFullscreen() does not require a user gesture when RequireUserGestureForAudioRateChange is set. https://bugs.webkit.org/show_bug.cgi?id=157803 Reviewed by Eric Carlson. Source/WebCore: Test: media/video-play-audio-require-user-gesture.html Refactor the setting of restrictions in the HTMLMediaElement constructor, and in so doing, only relax the RequireUserGestureForFullscreen restriction if both videoPlaybackRequiresUserGesture() and audioPlaybackRequiresUserGesture() settings are not set. * html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement): LayoutTests: * media/video-play-audio-require-user-gesture-expected.txt: Added. * media/video-play-audio-require-user-gesture.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/html/HTMLMediaElement.cpp Added Paths trunk/LayoutTests/media/video-play-audio-require-user-gesture-expected.txt trunk/LayoutTests/media/video-play-audio-require-user-gesture.html Diff Modified: trunk/LayoutTests/ChangeLog (201108 => 201109) --- trunk/LayoutTests/ChangeLog 2016-05-18 22:45:37 UTC (rev 201108) +++ trunk/LayoutTests/ChangeLog 2016-05-18 22:49:32 UTC (rev 201109) @@ -1,3 +1,13 @@ +2016-05-18 Jer Noble + +webkitEnterFullscreen() does not require a user gesture when RequireUserGestureForAudioRateChange is set. +https://bugs.webkit.org/show_bug.cgi?id=157803 + +Reviewed by Eric Carlson. + +* media/video-play-audio-require-user-gesture-expected.txt: Added. +* media/video-play-audio-require-user-gesture.html: Added. + 2016-05-18 Ryosuke Niwa REGRESSION (r186569): media/restore-from-page-cache.html is very flaky Added: trunk/LayoutTests/media/video-play-audio-require-user-gesture-expected.txt (0 => 201109) --- trunk/LayoutTests/media/video-play-audio-require-user-gesture-expected.txt (rev 0) +++ trunk/LayoutTests/media/video-play-audio-require-user-gesture-expected.txt 2016-05-18 22:49:32 UTC (rev 201109) @@ -0,0 +1,18 @@ +Test that video play(), pause() and webkitEnterFullScreen() should not work unless a user clicked on the play button. + + +EVENT(canplaythrough) + +* No user gesture initiated +RUN(video.play()) +TEST(video.webkitEnterFullScreen()) THROWS(DOMException.INVALID_STATE_ERR) OK +EXPECTED (video.paused == 'true') OK + +* User gesture initiated +EVENT(playing) +RUN(video.pause()) +EVENT(pause) +EXPECTED (video.paused == 'true') OK +RUN(video.webkitEnterFullScreen()) +END OF TEST + Added: trunk/LayoutTests/media/video-play-audio-require-user-gesture.html (0 => 201109) --- trunk/LayoutTests/media/video-play-audio-require-user-gesture.html (rev 0) +++ trunk/LayoutTests/media/video-play-audio-require-user-gesture.html 2016-05-18 22:49:32 UTC (rev 201109) @@ -0,0 +1,83 @@ + + +Test that video play, pause and enterfullscreen does not work unless a user gesture is involved in playing a video + +var userGestureInitiated = 0; +if (window.internals) +window.internals.settings.setAudioPlaybackRequiresUserGesture(true); + +function click() +{ +if (window.eventSender) { +var playCoords; +try { +playCoords = mediaControlsButtonCoordinates(video, "play-button"); +} catch (exception) { +failTest(exception.description); +return; +} +var x = playCoords[0]; +var y = playCoords[1]; + +userGestureInitiated = 1; +eventSender.mouseMoveTo(x, y); +eventSender.mouseDown(); +eventSender.mouseUp(); +} +} + +function playing() +{ +if (userGestureInitiated == 0) { +failTest("Should not play without user gesture."); +} else { +run("video.pause()"); +} +} + +function pause() +{ +testExpected("video.paused", true); +// Now video.webkitEnterFullScreen() should no longer throw any exception. +// However, the video element may not always enter fullscreen. For example, +// chromium uses fullscreen API which still requires user gesture +try { +run("video.webkitEnterFullScreen()"); +} catch(ex) { +failTest("video.webkitEnterFullScreen() still requires user gesture."); +} +endTest(); +} + +function canplaythrough() +
[webkit-changes] [201108] trunk/Source/WebKit2
Title: [201108] trunk/Source/WebKit2 Revision 201108 Author achristen...@apple.com Date 2016-05-18 15:45:37 -0700 (Wed, 18 May 2016) Log Message Build fix when not using CredentialStorage with NetworkSession. * NetworkProcess/cocoa/NetworkSessionCocoa.mm: (WebKit::NetworkSession::clearCredentials): Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/NetworkProcess/cocoa/NetworkSessionCocoa.mm Diff Modified: trunk/Source/WebKit2/ChangeLog (201107 => 201108) --- trunk/Source/WebKit2/ChangeLog 2016-05-18 22:40:26 UTC (rev 201107) +++ trunk/Source/WebKit2/ChangeLog 2016-05-18 22:45:37 UTC (rev 201108) @@ -1,3 +1,10 @@ +2016-05-18 Alex Christensen + +Build fix when not using CredentialStorage with NetworkSession. + +* NetworkProcess/cocoa/NetworkSessionCocoa.mm: +(WebKit::NetworkSession::clearCredentials): + 2016-05-18 Brady Eidson Fix null-deref crash sporadically seen after http://trac.webkit.org/changeset/201098 Modified: trunk/Source/WebKit2/NetworkProcess/cocoa/NetworkSessionCocoa.mm (201107 => 201108) --- trunk/Source/WebKit2/NetworkProcess/cocoa/NetworkSessionCocoa.mm 2016-05-18 22:40:26 UTC (rev 201107) +++ trunk/Source/WebKit2/NetworkProcess/cocoa/NetworkSessionCocoa.mm 2016-05-18 22:45:37 UTC (rev 201108) @@ -392,7 +392,7 @@ ASSERT(m_dataTaskMapWithCredentials.isEmpty()); ASSERT(m_dataTaskMapWithoutCredentials.isEmpty()); ASSERT(m_downloadMap.isEmpty()); -m_sessionWithCredentialStorage = [NSURLSession sessionWithConfiguration:m_sessionWithCredentialStorage.get().configuration delegate:static_cast(m_sessionDelegate.get()) delegateQueue:[NSOperationQueue mainQueue]]; +m_sessionWithCredentialStorage = [NSURLSession sessionWithConfiguration:m_sessionWithCredentialStorage.get().configuration delegate:static_cast(m_sessionWithCredentialStorageDelegate.get()) delegateQueue:[NSOperationQueue mainQueue]]; } #endif ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [201107] trunk/Source/WebKit2
Title: [201107] trunk/Source/WebKit2 Revision 201107 Author beid...@apple.com Date 2016-05-18 15:40:26 -0700 (Wed, 18 May 2016) Log Message Fix null-deref crash sporadically seen after http://trac.webkit.org/changeset/201098 No review. * DatabaseProcess/DatabaseProcess.cpp: (WebKit::DatabaseProcess::deleteWebsiteData): Don't access m_idbServer directly, as calling the idbServer() accessor is how you actually get your IDBServer created for you. Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/DatabaseProcess/DatabaseProcess.cpp Diff Modified: trunk/Source/WebKit2/ChangeLog (201106 => 201107) --- trunk/Source/WebKit2/ChangeLog 2016-05-18 22:40:24 UTC (rev 201106) +++ trunk/Source/WebKit2/ChangeLog 2016-05-18 22:40:26 UTC (rev 201107) @@ -1,3 +1,13 @@ +2016-05-18 Brady Eidson + +Fix null-deref crash sporadically seen after http://trac.webkit.org/changeset/201098 + +No review. + +* DatabaseProcess/DatabaseProcess.cpp: +(WebKit::DatabaseProcess::deleteWebsiteData): Don't access m_idbServer directly, as calling + the idbServer() accessor is how you actually get your IDBServer created for you. + 2016-05-18 Brian Burg Web Inspector: InspectorFrontendAPI.setTimelineProfilingEnabled should not implicitly show Timelines tab Modified: trunk/Source/WebKit2/DatabaseProcess/DatabaseProcess.cpp (201106 => 201107) --- trunk/Source/WebKit2/DatabaseProcess/DatabaseProcess.cpp 2016-05-18 22:40:24 UTC (rev 201106) +++ trunk/Source/WebKit2/DatabaseProcess/DatabaseProcess.cpp 2016-05-18 22:40:26 UTC (rev 201107) @@ -260,7 +260,7 @@ #if ENABLE(INDEXED_DATABASE) if (websiteDataTypes.contains(WebsiteDataType::IndexedDBDatabases)) -m_idbServer->closeAndDeleteDatabasesModifiedSince(modifiedSince, [callbackAggregator] { }); +idbServer().closeAndDeleteDatabasesModifiedSince(modifiedSince, [callbackAggregator] { }); #endif } ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [201106] trunk/Source/WebCore
Title: [201106] trunk/Source/WebCore Revision 201106 Author jer.no...@apple.com Date 2016-05-18 15:40:24 -0700 (Wed, 18 May 2016) Log Message Playback session sends audio and text track lists when media does not have audio or text tracks. https://bugs.webkit.org/show_bug.cgi?id=157865 Reviewed by Beth Dakin. Only send across the CaptionUserPreferences-generated list of audio and text tracks if those text tracks exist in the first place. This matches the behavior of the built-in controls. * platform/cocoa/WebPlaybackSessionModelMediaElement.mm: (WebPlaybackSessionModelMediaElement::updateLegibleOptions): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/cocoa/WebPlaybackSessionModelMediaElement.mm Diff Modified: trunk/Source/WebCore/ChangeLog (201105 => 201106) --- trunk/Source/WebCore/ChangeLog 2016-05-18 22:36:01 UTC (rev 201105) +++ trunk/Source/WebCore/ChangeLog 2016-05-18 22:40:24 UTC (rev 201106) @@ -1,3 +1,17 @@ +2016-05-18 Jer Noble + +Playback session sends audio and text track lists when media does not have audio or text tracks. +https://bugs.webkit.org/show_bug.cgi?id=157865 + + +Reviewed by Beth Dakin. + +Only send across the CaptionUserPreferences-generated list of audio and text tracks if those +text tracks exist in the first place. This matches the behavior of the built-in controls. + +* platform/cocoa/WebPlaybackSessionModelMediaElement.mm: +(WebPlaybackSessionModelMediaElement::updateLegibleOptions): + 2016-05-18 Chris Dumez Clean up / Modernize TextAutoSizingValue::adjustNodeSizes() Modified: trunk/Source/WebCore/platform/cocoa/WebPlaybackSessionModelMediaElement.mm (201105 => 201106) --- trunk/Source/WebCore/platform/cocoa/WebPlaybackSessionModelMediaElement.mm 2016-05-18 22:36:01 UTC (rev 201105) +++ trunk/Source/WebCore/platform/cocoa/WebPlaybackSessionModelMediaElement.mm 2016-05-18 22:40:24 UTC (rev 201106) @@ -33,6 +33,7 @@ #import "MediaControlsHost.h" #import "WebVideoFullscreenInterface.h" #import +#import #import #import #import @@ -263,9 +264,18 @@ return; auto& captionPreferences = m_mediaElement->document().page()->group().captionPreferences(); -m_legibleTracksForMenu = captionPreferences.sortedTrackListForMenu(&m_mediaElement->textTracks()); -m_audioTracksForMenu = captionPreferences.sortedTrackListForMenu(&m_mediaElement->audioTracks()); +auto& textTracks = m_mediaElement->textTracks(); +if (textTracks.length()) +m_legibleTracksForMenu = captionPreferences.sortedTrackListForMenu(&textTracks); +else +m_legibleTracksForMenu.clear(); +auto& audioTracks = m_mediaElement->audioTracks(); +if (audioTracks.length() > 1) +m_audioTracksForMenu = captionPreferences.sortedTrackListForMenu(&audioTracks); +else +m_audioTracksForMenu.clear(); + m_playbackSessionInterface->setAudioMediaSelectionOptions(audioMediaSelectionOptions(), audioMediaSelectedIndex()); m_playbackSessionInterface->setLegibleMediaSelectionOptions(legibleMediaSelectionOptions(), legibleMediaSelectedIndex()); } ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [201105] trunk
Title: [201105] trunk Revision 201105 Author msab...@apple.com Date 2016-05-18 15:36:01 -0700 (Wed, 18 May 2016) Log Message r199812 broke test262 https://bugs.webkit.org/show_bug.cgi?id=157595 Reviewed by Filip Pizlo. Source/_javascript_Core: Added a reasonable limit to the size of the match result array to catch possible infinite loops when matching. Added a new tests that creates an infinite loop in RegExp.prototype.[Symbol.match] by creating a subclass of RegExp where the base RegExp's global flag is false and the subclass overrides .global with a getter that always returns true. * builtins/RegExpPrototype.js: (match): * tests/stress/regress-157595.js: Added. (MyRegExp): (MyRegExp.prototype.get global): (test): (catch): Tools: Added a new run type, runOneLargeHeap, for tests that use a large amount of memory. This run type will not run with the --memory-limited option. Without that option, we'll only the default test variant. * Scripts/run-jsc-stress-tests: Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/builtins/RegExpPrototype.js trunk/Tools/ChangeLog trunk/Tools/Scripts/run-jsc-stress-tests Added Paths trunk/Source/_javascript_Core/tests/stress/regress-157595.js Diff Modified: trunk/Source/_javascript_Core/ChangeLog (201104 => 201105) --- trunk/Source/_javascript_Core/ChangeLog 2016-05-18 22:27:47 UTC (rev 201104) +++ trunk/Source/_javascript_Core/ChangeLog 2016-05-18 22:36:01 UTC (rev 201105) @@ -1,3 +1,24 @@ +2016-05-18 Michael Saboff + +r199812 broke test262 +https://bugs.webkit.org/show_bug.cgi?id=157595 + +Reviewed by Filip Pizlo. + +Added a reasonable limit to the size of the match result array to catch possible +infinite loops when matching. +Added a new tests that creates an infinite loop in RegExp.prototype.[Symbol.match] +by creating a subclass of RegExp where the base RegExp's global flag is false and +the subclass overrides .global with a getter that always returns true. + +* builtins/RegExpPrototype.js: +(match): +* tests/stress/regress-157595.js: Added. +(MyRegExp): +(MyRegExp.prototype.get global): +(test): +(catch): + 2016-05-18 Yusuke Suzuki [ES6] Namespace object re-export should be handled as local export Modified: trunk/Source/_javascript_Core/builtins/RegExpPrototype.js (201104 => 201105) --- trunk/Source/_javascript_Core/builtins/RegExpPrototype.js 2016-05-18 22:27:47 UTC (rev 201104) +++ trunk/Source/_javascript_Core/builtins/RegExpPrototype.js 2016-05-18 22:36:01 UTC (rev 201105) @@ -97,8 +97,9 @@ let unicode = regexp.unicode; regexp.lastIndex = 0; let resultList = []; -let stringLength = str.length; +const maximumReasonableMatchSize = 1; + while (true) { let result = @regExpExec(regexp, str); @@ -108,6 +109,9 @@ return resultList; } +if (resultList.length > maximumReasonableMatchSize) +throw new @Error("Out of memory"); + if (!@isObject(result)) throw new @TypeError("RegExp.prototype.@@match call to RegExp.exec didn't return null or an object"); Added: trunk/Source/_javascript_Core/tests/stress/regress-157595.js (0 => 201105) --- trunk/Source/_javascript_Core/tests/stress/regress-157595.js (rev 0) +++ trunk/Source/_javascript_Core/tests/stress/regress-157595.js 2016-05-18 22:36:01 UTC (rev 201105) @@ -0,0 +1,27 @@ +// Test that an overridden global on a RegExp object doesn't cause an infinite loop +// in String.match(). Instead it should eventually throw an Out of Memory exception. +//@ runOneLargeHeap + +class MyRegExp extends RegExp { +constructor(pattern) { +super(pattern, ""); +} + +get global() { +return true; +} +}; + +function test() +{ +let r = new MyRegExp("."); + +return "abc".match(r); +} + +try { +test(); +} catch(e) { +if (e.message != "Out of memory") +throw "Wrong error: " + e; +} Modified: trunk/Tools/ChangeLog (201104 => 201105) --- trunk/Tools/ChangeLog 2016-05-18 22:27:47 UTC (rev 201104) +++ trunk/Tools/ChangeLog 2016-05-18 22:36:01 UTC (rev 201105) @@ -1,3 +1,16 @@ +2016-05-18 Michael Saboff + +r199812 broke test262 +https://bugs.webkit.org/show_bug.cgi?id=157595 + +Reviewed by Filip Pizlo. + +Added a new run type, runOneLargeHeap, for tests that use a large amount of memory. +This run type will not run with the --memory-limited option. Without that option, +we'll only the default test variant. + +* Scripts/run-jsc-stress-tests: + 2016-05-18 Simon Fraser REGRESSION (r200534) Command-+ no longer zooms pages Modified: trunk/Tools/Scripts/run-jsc-stress-tests (201104 => 201105) --- trunk/Tools/Scripts/run-jsc-stress-tests 2016-05-18 22:27:47 UTC (rev 201104) +++ trunk/T
[webkit-changes] [201104] trunk/Source/WebCore
Title: [201104] trunk/Source/WebCore Revision 201104 Author cdu...@apple.com Date 2016-05-18 15:27:47 -0700 (Wed, 18 May 2016) Log Message Clean up / Modernize TextAutoSizingValue::adjustNodeSizes() https://bugs.webkit.org/show_bug.cgi?id=157861 Reviewed by Alex Christensen. Clean up / Modernize TextAutoSizingValue::adjustNodeSizes(), and use tighter typing for autosizing nodes. * dom/Document.cpp: (WebCore::Document::addAutoSizingNode): * dom/Document.h: * rendering/RenderBlockFlow.cpp: (WebCore::RenderBlockFlow::adjustComputedFontSizes): * rendering/TextAutoSizing.cpp: (WebCore::TextAutoSizingValue::addNode): (WebCore::TextAutoSizingValue::adjustNodeSizes): (WebCore::TextAutoSizingValue::reset): * rendering/TextAutoSizing.h: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/dom/Document.cpp trunk/Source/WebCore/dom/Document.h trunk/Source/WebCore/rendering/RenderBlockFlow.cpp trunk/Source/WebCore/rendering/TextAutoSizing.cpp trunk/Source/WebCore/rendering/TextAutoSizing.h Diff Modified: trunk/Source/WebCore/ChangeLog (201103 => 201104) --- trunk/Source/WebCore/ChangeLog 2016-05-18 22:25:01 UTC (rev 201103) +++ trunk/Source/WebCore/ChangeLog 2016-05-18 22:27:47 UTC (rev 201104) @@ -1,3 +1,24 @@ +2016-05-18 Chris Dumez + +Clean up / Modernize TextAutoSizingValue::adjustNodeSizes() +https://bugs.webkit.org/show_bug.cgi?id=157861 + +Reviewed by Alex Christensen. + +Clean up / Modernize TextAutoSizingValue::adjustNodeSizes(), and +use tighter typing for autosizing nodes. + +* dom/Document.cpp: +(WebCore::Document::addAutoSizingNode): +* dom/Document.h: +* rendering/RenderBlockFlow.cpp: +(WebCore::RenderBlockFlow::adjustComputedFontSizes): +* rendering/TextAutoSizing.cpp: +(WebCore::TextAutoSizingValue::addNode): +(WebCore::TextAutoSizingValue::adjustNodeSizes): +(WebCore::TextAutoSizingValue::reset): +* rendering/TextAutoSizing.h: + 2016-05-18 Simon Fraser Remove logging inadvertently committed in r201090. Modified: trunk/Source/WebCore/dom/Document.cpp (201103 => 201104) --- trunk/Source/WebCore/dom/Document.cpp 2016-05-18 22:25:01 UTC (rev 201103) +++ trunk/Source/WebCore/dom/Document.cpp 2016-05-18 22:27:47 UTC (rev 201104) @@ -5279,11 +5279,11 @@ #if ENABLE(IOS_TEXT_AUTOSIZING) -void Document::addAutoSizingNode(Node* node, float candidateSize) +void Document::addAutoSizingNode(Text& node, float candidateSize) { -LOG(TextAutosizing, " addAutoSizingNode %p candidateSize=%f", node, candidateSize); +LOG(TextAutosizing, " addAutoSizingNode %p candidateSize=%f", &node, candidateSize); -TextAutoSizingKey key(&node->renderer()->style()); +TextAutoSizingKey key(&node.renderer()->style()); auto addResult = m_textAutoSizedNodes.ensure(WTFMove(key), [] { return TextAutoSizingValue::create(); }); Modified: trunk/Source/WebCore/dom/Document.h (201103 => 201104) --- trunk/Source/WebCore/dom/Document.h 2016-05-18 22:25:01 UTC (rev 201103) +++ trunk/Source/WebCore/dom/Document.h 2016-05-18 22:27:47 UTC (rev 201104) @@ -1692,7 +1692,7 @@ #if ENABLE(IOS_TEXT_AUTOSIZING) public: -void addAutoSizingNode(Node*, float size); +void addAutoSizingNode(Text&, float size); void validateAutoSizingNodes(); void resetAutoSizingNodes(); Modified: trunk/Source/WebCore/rendering/RenderBlockFlow.cpp (201103 => 201104) --- trunk/Source/WebCore/rendering/RenderBlockFlow.cpp 2016-05-18 22:25:01 UTC (rev 201103) +++ trunk/Source/WebCore/rendering/RenderBlockFlow.cpp 2016-05-18 22:27:47 UTC (rev 201104) @@ -3810,7 +3810,7 @@ float lineTextMultiplier = lineCount == ONE_LINE ? oneLineTextMultiplier(specifiedSize) : textMultiplier(specifiedSize); candidateNewSize = roundf(std::min(minFontSize, specifiedSize * lineTextMultiplier)); if (candidateNewSize > specifiedSize && candidateNewSize != fontDescription.computedSize() && text.textNode() && oldStyle.textSizeAdjust().isAuto()) -document().addAutoSizingNode(text.textNode(), candidateNewSize); +document().addAutoSizingNode(*text.textNode(), candidateNewSize); } } } Modified: trunk/Source/WebCore/rendering/TextAutoSizing.cpp (201103 => 201104) --- trunk/Source/WebCore/rendering/TextAutoSizing.cpp 2016-05-18 22:25:01 UTC (rev 201103) +++ trunk/Source/WebCore/rendering/TextAutoSizing.cpp 2016-05-18 22:27:47 UTC (rev 201104) @@ -62,29 +62,27 @@ return m_autoSizedNodes.size(); } -void TextAutoSizingValue::addNode(Node* node, float size) +void TextAutoSizingValue::addNode(Text& node, float size) { -ASSERT(node); -downcast(*node->renderer()).setCandidateComputedTextSize(size); -m_autoSizedNodes.add(node); +node.renderer()->setCandidateComputedTextSize(size); +m_autoSizedNodes.add(&node); } #define MAX_SCALE_
[webkit-changes] [201103] trunk/Source/WebCore
Title: [201103] trunk/Source/WebCore Revision 201103 Author simon.fra...@apple.com Date 2016-05-18 15:25:01 -0700 (Wed, 18 May 2016) Log Message Remove logging inadvertently committed in r201090. * css/CSSParser.cpp: (WebCore::CSSParserContext::CSSParserContext): Deleted. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/css/CSSParser.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (201102 => 201103) --- trunk/Source/WebCore/ChangeLog 2016-05-18 22:16:22 UTC (rev 201102) +++ trunk/Source/WebCore/ChangeLog 2016-05-18 22:25:01 UTC (rev 201103) @@ -1,3 +1,10 @@ +2016-05-18 Simon Fraser + +Remove logging inadvertently committed in r201090. + +* css/CSSParser.cpp: +(WebCore::CSSParserContext::CSSParserContext): Deleted. + 2016-05-18 Brady Eidson Modern IDB: Add support for server side closing of open database connections. Modified: trunk/Source/WebCore/css/CSSParser.cpp (201102 => 201103) --- trunk/Source/WebCore/css/CSSParser.cpp 2016-05-18 22:16:22 UTC (rev 201102) +++ trunk/Source/WebCore/css/CSSParser.cpp 2016-05-18 22:25:01 UTC (rev 201103) @@ -272,7 +272,6 @@ useLegacyBackgroundSizeShorthandBehavior = settings->useLegacyBackgroundSizeShorthandBehavior(); #if ENABLE(IOS_TEXT_AUTOSIZING) textAutosizingEnabled = settings->textAutosizingEnabled(); -WTFLogAlways("CSSParserContext %p CSSParserContext textAutosizingEnabled=%d", this, textAutosizingEnabled); #endif } ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [201102] trunk/Source/WebInspectorUI
Title: [201102] trunk/Source/WebInspectorUI Revision 201102 Author nvasil...@apple.com Date 2016-05-18 15:16:22 -0700 (Wed, 18 May 2016) Log Message Web Inspector: ugly gaps in Call Trees data grid when expanding more than one level https://bugs.webkit.org/show_bug.cgi?id=157829 Reviewed by Timothy Hatcher. Make a more specific CSS selector to avoid style conflicts. * UserInterface/Views/DataGrid.css: (.data-grid:not(.variable-height-rows) > .data-container > table.data > tbody > tr > td > div): Deleted. (.data-grid:not(.variable-height-rows) > .data-container > table.data > tbody > tr > td > .cell-content): * UserInterface/Views/DataGrid.js: (WebInspector.DataGridNode.prototype.createCell): Modified Paths trunk/Source/WebInspectorUI/ChangeLog trunk/Source/WebInspectorUI/UserInterface/Views/DataGrid.css trunk/Source/WebInspectorUI/UserInterface/Views/DataGrid.js Diff Modified: trunk/Source/WebInspectorUI/ChangeLog (201101 => 201102) --- trunk/Source/WebInspectorUI/ChangeLog 2016-05-18 21:50:35 UTC (rev 201101) +++ trunk/Source/WebInspectorUI/ChangeLog 2016-05-18 22:16:22 UTC (rev 201102) @@ -1,3 +1,19 @@ +2016-05-18 Nikita Vasilyev + +Web Inspector: ugly gaps in Call Trees data grid when expanding more than one level +https://bugs.webkit.org/show_bug.cgi?id=157829 + + +Reviewed by Timothy Hatcher. + +Make a more specific CSS selector to avoid style conflicts. + +* UserInterface/Views/DataGrid.css: +(.data-grid:not(.variable-height-rows) > .data-container > table.data > tbody > tr > td > div): Deleted. +(.data-grid:not(.variable-height-rows) > .data-container > table.data > tbody > tr > td > .cell-content): +* UserInterface/Views/DataGrid.js: +(WebInspector.DataGridNode.prototype.createCell): + 2016-05-18 Brian Burg Web Inspector: InspectorFrontendAPI.setTimelineProfilingEnabled should not implicitly show Timelines tab Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DataGrid.css (201101 => 201102) --- trunk/Source/WebInspectorUI/UserInterface/Views/DataGrid.css 2016-05-18 21:50:35 UTC (rev 201101) +++ trunk/Source/WebInspectorUI/UserInterface/Views/DataGrid.css 2016-05-18 22:16:22 UTC (rev 201102) @@ -125,7 +125,7 @@ background-size: 100% 40px; } -.data-grid:not(.variable-height-rows) > .data-container > table.data > tbody > tr > td > div { +.data-grid:not(.variable-height-rows) > .data-container > table.data > tbody > tr > td > .cell-content { height: 16px; } Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DataGrid.js (201101 => 201102) --- trunk/Source/WebInspectorUI/UserInterface/Views/DataGrid.js 2016-05-18 21:50:35 UTC (rev 201101) +++ trunk/Source/WebInspectorUI/UserInterface/Views/DataGrid.js 2016-05-18 22:16:22 UTC (rev 201102) @@ -2179,7 +2179,7 @@ if (column["group"]) cellElement.classList.add("column-group-" + column["group"]); -var div = cellElement.createChild("div"); +var div = cellElement.createChild("div", "cell-content"); var content = this.createCellContent(columnIdentifier, cellElement); div.append(content); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [201101] trunk/Source
Title: [201101] trunk/Source Revision 201101 Author bb...@apple.com Date 2016-05-18 14:50:35 -0700 (Wed, 18 May 2016) Log Message Web Inspector: InspectorFrontendAPI.setTimelineProfilingEnabled should not implicitly show Timelines tab https://bugs.webkit.org/show_bug.cgi?id=157846 Reviewed by Timothy Hatcher. Source/WebInspectorUI: Currently, if the Web Inspector opens for an in-progress or finished automation session, it will always show the Timelines tab, disregarding any previous user view state. This is annoying and is a bad user experience when trying to debug the same test repeatedly. * UserInterface/Protocol/InspectorFrontendAPI.js: (InspectorFrontendAPI.setTimelineProfilingEnabled): Don't implicitly show Timelines tab. (InspectorFrontendAPI.showTimelines): Added. This is called explicitly when desired. Source/WebKit2: Add a separate ShowTimelines message to WebInspector and WebInspectorUI. Have the start/stop profiling methods in public APIs explicitly call showTimelines() rather than relying on InspectorFrontendAPI to do it. * UIProcess/API/C/WKInspector.cpp: (WKInspectorTogglePageProfiling): * UIProcess/WebInspectorProxy.cpp: (WebKit::WebInspectorProxy::showTimelines): * UIProcess/WebInspectorProxy.h: * WebProcess/InjectedBundle/API/c/WKBundleInspector.cpp: (WKBundleInspectorSetPageProfilingEnabled): * WebProcess/WebPage/WebInspector.cpp: (WebKit::WebInspector::showTimelines): * WebProcess/WebPage/WebInspector.h: * WebProcess/WebPage/WebInspector.messages.in: * WebProcess/WebPage/WebInspectorUI.cpp: (WebKit::WebInspectorUI::showTimelines): * WebProcess/WebPage/WebInspectorUI.h: * WebProcess/WebPage/WebInspectorUI.messages.in: Modified Paths trunk/Source/WebInspectorUI/ChangeLog trunk/Source/WebInspectorUI/UserInterface/Protocol/InspectorFrontendAPI.js trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/API/C/WKInspector.cpp trunk/Source/WebKit2/UIProcess/WebInspectorProxy.cpp trunk/Source/WebKit2/UIProcess/WebInspectorProxy.h trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundleInspector.cpp trunk/Source/WebKit2/WebProcess/WebPage/WebInspector.cpp trunk/Source/WebKit2/WebProcess/WebPage/WebInspector.h trunk/Source/WebKit2/WebProcess/WebPage/WebInspector.messages.in trunk/Source/WebKit2/WebProcess/WebPage/WebInspectorUI.cpp trunk/Source/WebKit2/WebProcess/WebPage/WebInspectorUI.h trunk/Source/WebKit2/WebProcess/WebPage/WebInspectorUI.messages.in Diff Modified: trunk/Source/WebInspectorUI/ChangeLog (201100 => 201101) --- trunk/Source/WebInspectorUI/ChangeLog 2016-05-18 21:36:29 UTC (rev 201100) +++ trunk/Source/WebInspectorUI/ChangeLog 2016-05-18 21:50:35 UTC (rev 201101) @@ -1,5 +1,20 @@ 2016-05-18 Brian Burg +Web Inspector: InspectorFrontendAPI.setTimelineProfilingEnabled should not implicitly show Timelines tab +https://bugs.webkit.org/show_bug.cgi?id=157846 + +Reviewed by Timothy Hatcher. + +Currently, if the Web Inspector opens for an in-progress or finished automation session, +it will always show the Timelines tab, disregarding any previous user view state. This +is annoying and is a bad user experience when trying to debug the same test repeatedly. + +* UserInterface/Protocol/InspectorFrontendAPI.js: +(InspectorFrontendAPI.setTimelineProfilingEnabled): Don't implicitly show Timelines tab. +(InspectorFrontendAPI.showTimelines): Added. This is called explicitly when desired. + +2016-05-18 Brian Burg + Web Inspector: DebuggerSidebarPanel doesn't need to help manage temporarily disabling breakpoints while capturing https://bugs.webkit.org/show_bug.cgi?id=157854 Modified: trunk/Source/WebInspectorUI/UserInterface/Protocol/InspectorFrontendAPI.js (201100 => 201101) --- trunk/Source/WebInspectorUI/UserInterface/Protocol/InspectorFrontendAPI.js 2016-05-18 21:36:29 UTC (rev 201100) +++ trunk/Source/WebInspectorUI/UserInterface/Protocol/InspectorFrontendAPI.js 2016-05-18 21:50:35 UTC (rev 201101) @@ -1,5 +1,5 @@ /* - * Copyright (C) 2013 Apple Inc. All rights reserved. + * Copyright (C) 2013, 2016 Apple Inc. All rights reserved. * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions @@ -47,12 +47,10 @@ if (WebInspector.timelineManager.isCapturing() === enabled) return; -if (enabled) { -WebInspector.showTimelineTab(); +if (enabled) WebInspector.timelineManager.startCapturing(); -} else { +else WebInspector.timelineManager.stopCapturing(); -} }, setElementSelectionEnabled: function(enabled) @@ -99,6 +97,11 @@ WebInspector.showResourcesTab(); }, +showTimelines: function() +{ +WebInspector.showTimelineTab(); +}, + showMainResourceForFrame: function(frameIdentifier) { WebInspector.showSourceCodeForFrame(f
[webkit-changes] [201100] trunk/LayoutTests
Title: [201100] trunk/LayoutTests Revision 201100 Author rn...@webkit.org Date 2016-05-18 14:36:29 -0700 (Wed, 18 May 2016) Log Message REGRESSION (r186569): media/restore-from-page-cache.html is very flaky https://bugs.webkit.org/show_bug.cgi?id=147254 Unreviewed. Removing the flaky test expectation since the test is almost always passing now. * platform/mac/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (201099 => 201100) --- trunk/LayoutTests/ChangeLog 2016-05-18 21:04:27 UTC (rev 201099) +++ trunk/LayoutTests/ChangeLog 2016-05-18 21:36:29 UTC (rev 201100) @@ -1,3 +1,12 @@ +2016-05-18 Ryosuke Niwa + +REGRESSION (r186569): media/restore-from-page-cache.html is very flaky +https://bugs.webkit.org/show_bug.cgi?id=147254 + +Unreviewed. Removing the flaky test expectation since the test is almost always passing now. + +* platform/mac/TestExpectations: + 2016-05-18 Brady Eidson Modern IDB: Add support for server side closing of open database connections. Modified: trunk/LayoutTests/platform/mac/TestExpectations (201099 => 201100) --- trunk/LayoutTests/platform/mac/TestExpectations 2016-05-18 21:04:27 UTC (rev 201099) +++ trunk/LayoutTests/platform/mac/TestExpectations 2016-05-18 21:36:29 UTC (rev 201100) @@ -737,8 +737,6 @@ webkit.org/b/124321 animations/resume-after-page-cache.html [ Pass Failure ] -webkit.org/b/147254 media/restore-from-page-cache.html [ Pass Failure ] - # These fast/forms/select tests open a pop-up menu (visible on screen even when using run-webkit-tests), and get stuck in its nested event loop. webkit.org/b/87748 fast/forms/select/optgroup-clicking.html [ Skip ] webkit.org/b/73304 fast/forms/select/menulist-popup-crash.html [ Skip ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [201099] trunk/Source/WebInspectorUI
Title: [201099] trunk/Source/WebInspectorUI Revision 201099 Author bb...@apple.com Date 2016-05-18 14:04:27 -0700 (Wed, 18 May 2016) Log Message Web Inspector: DebuggerSidebarPanel doesn't need to help manage temporarily disabling breakpoints while capturing https://bugs.webkit.org/show_bug.cgi?id=157854 Reviewed by Timothy Hatcher. Duplicate the event listeners in DebuggerManager and move non-view-related state updates out of DebuggerSidebarPanel's listeners into DebuggerManager's listeners. This allows a test to exercise the temporary-disablement code paths during capturing. * UserInterface/Controllers/DebuggerManager.js: (WebInspector.DebuggerManager.prototype.get breakpointsDisabledTemporarily): Use this to make the code a bit more readable. (WebInspector.DebuggerManager.prototype._startDisablingBreakpointsTemporarily): (WebInspector.DebuggerManager.prototype._stopDisablingBreakpointsTemporarily): (WebInspector.DebuggerManager.prototype.startDisablingBreakpointsTemporarily): Deleted. (WebInspector.DebuggerManager.prototype.stopDisablingBreakpointsTemporarily): Deleted. Make this private since it's not used by other classes anymore. (WebInspector.DebuggerManager.prototype._timelineCapturingWillStart): Added. (WebInspector.DebuggerManager.prototype._timelineCapturingStopped): Added. * UserInterface/Views/DebuggerSidebarPanel.js: (WebInspector.DebuggerSidebarPanel.prototype._timelineRecordingWillStart): Deleted. (WebInspector.DebuggerSidebarPanel.prototype._timelineRecordingStopped): Deleted. (WebInspector.DebuggerSidebarPanel.prototype._timelineCapturingWillStart): Added. (WebInspector.DebuggerSidebarPanel.prototype._timelineCapturingStopped): Added. Make the listener names consistent with TimelineManager: timelineCapturing{WillStart,Stopped}. Modified Paths trunk/Source/WebInspectorUI/ChangeLog trunk/Source/WebInspectorUI/UserInterface/Controllers/DebuggerManager.js trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js Diff Modified: trunk/Source/WebInspectorUI/ChangeLog (201098 => 201099) --- trunk/Source/WebInspectorUI/ChangeLog 2016-05-18 20:42:20 UTC (rev 201098) +++ trunk/Source/WebInspectorUI/ChangeLog 2016-05-18 21:04:27 UTC (rev 201099) @@ -1,3 +1,34 @@ +2016-05-18 Brian Burg + +Web Inspector: DebuggerSidebarPanel doesn't need to help manage temporarily disabling breakpoints while capturing +https://bugs.webkit.org/show_bug.cgi?id=157854 + +Reviewed by Timothy Hatcher. + +Duplicate the event listeners in DebuggerManager and move non-view-related +state updates out of DebuggerSidebarPanel's listeners into DebuggerManager's listeners. +This allows a test to exercise the temporary-disablement code paths during capturing. + +* UserInterface/Controllers/DebuggerManager.js: +(WebInspector.DebuggerManager.prototype.get breakpointsDisabledTemporarily): +Use this to make the code a bit more readable. + +(WebInspector.DebuggerManager.prototype._startDisablingBreakpointsTemporarily): +(WebInspector.DebuggerManager.prototype._stopDisablingBreakpointsTemporarily): +(WebInspector.DebuggerManager.prototype.startDisablingBreakpointsTemporarily): Deleted. +(WebInspector.DebuggerManager.prototype.stopDisablingBreakpointsTemporarily): Deleted. +Make this private since it's not used by other classes anymore. + +(WebInspector.DebuggerManager.prototype._timelineCapturingWillStart): Added. +(WebInspector.DebuggerManager.prototype._timelineCapturingStopped): Added. + +* UserInterface/Views/DebuggerSidebarPanel.js: +(WebInspector.DebuggerSidebarPanel.prototype._timelineRecordingWillStart): Deleted. +(WebInspector.DebuggerSidebarPanel.prototype._timelineRecordingStopped): Deleted. +(WebInspector.DebuggerSidebarPanel.prototype._timelineCapturingWillStart): Added. +(WebInspector.DebuggerSidebarPanel.prototype._timelineCapturingStopped): Added. +Make the listener names consistent with TimelineManager: timelineCapturing{WillStart,Stopped}. + 2016-05-18 Joseph Pecoraro Web Inspector: Improve console.takeHeapSnapshot documentation in console Modified: trunk/Source/WebInspectorUI/UserInterface/Controllers/DebuggerManager.js (201098 => 201099) --- trunk/Source/WebInspectorUI/UserInterface/Controllers/DebuggerManager.js 2016-05-18 20:42:20 UTC (rev 201098) +++ trunk/Source/WebInspectorUI/UserInterface/Controllers/DebuggerManager.js 2016-05-18 21:04:27 UTC (rev 201099) @@ -1,5 +1,5 @@ /* - * Copyright (C) 2013, 2014 Apple Inc. All rights reserved. + * Copyright (C) 2013, 2014, 2016 Apple Inc. All rights reserved. * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions @@ -40,6 +40,9 @@ WebInspector.Breakpoint.addEventListener(WebInspector.Breakpoint.Event.AutoContinueDidChange, this._breakpointEdit
[webkit-changes] [201098] trunk
Title: [201098] trunk Revision 201098 Author beid...@apple.com Date 2016-05-18 13:42:20 -0700 (Wed, 18 May 2016) Log Message Modern IDB: Add support for server side closing of open database connections. https://bugs.webkit.org/show_bug.cgi?id=157843 Reviewed by Alex Christensen. Source/WebCore: Test: storage/indexeddb/modern/handle-user-delete.html In order to support deleting IndexedDB databases, the IDB server needs the ability to "immediately" close a currently open IDB connection. To do so cleanly, the server has to: - Error out all requests it knows about - Abort all transactions it knows about - Tell the connection that it is being closed - Wait for the connection to acknowledge that it was closed on the server And then the client has to: - Error out all requests it hasn't sent to the server - Abort all transactions that haven't already been aborted by the server - Send acknowledgement to the server that it has been closed. Finally, because the status of a given request might be "in flight" somewhere between the server and the client, some design assumptions change. This requires reworking some ASSERTS, null checks, etc. * Modules/indexeddb/IDBDatabase.cpp: (WebCore::IDBDatabase::didCloseFromServer): Do the heavy lifting for the immediate close on the client side. * Modules/indexeddb/IDBDatabase.h: * Modules/indexeddb/IDBDatabaseIdentifier.h: (WebCore::IDBDatabaseIdentifier::isRelatedToOrigin): * Modules/indexeddb/IDBTransaction.cpp: (WebCore::IDBTransaction::connectionClosedFromServer): Error out all outstanding operations and fire the abort error on itself. * Modules/indexeddb/IDBTransaction.h: * Modules/indexeddb/client/IDBConnectionProxy.cpp: (WebCore::IDBClient::IDBConnectionProxy::completeOperation): (WebCore::IDBClient::IDBConnectionProxy::didCloseFromServer): (WebCore::IDBClient::IDBConnectionProxy::confirmDidCloseFromServer): (WebCore::IDBClient::IDBConnectionProxy::forgetActiveOperations): * Modules/indexeddb/client/IDBConnectionProxy.h: * Modules/indexeddb/client/IDBConnectionToServer.cpp: (WebCore::IDBClient::IDBConnectionToServer::didCloseFromServer): (WebCore::IDBClient::IDBConnectionToServer::confirmDidCloseFromServer): * Modules/indexeddb/client/IDBConnectionToServer.h: * Modules/indexeddb/client/IDBConnectionToServerDelegate.h: * Modules/indexeddb/server/IDBConnectionToClient.cpp: (WebCore::IDBServer::IDBConnectionToClient::didCloseFromServer): * Modules/indexeddb/server/IDBConnectionToClient.h: * Modules/indexeddb/server/IDBConnectionToClientDelegate.h: * Modules/indexeddb/server/IDBServer.cpp: (WebCore::IDBServer::IDBServer::confirmDidCloseFromServer): (WebCore::IDBServer::generateDeleteCallbackID): (WebCore::IDBServer::IDBServer::closeAndDeleteDatabasesModifiedSince): (WebCore::IDBServer::IDBServer::closeAndDeleteDatabasesForOrigins): (WebCore::IDBServer::IDBServer::performCloseAndDeleteDatabasesModifiedSince): (WebCore::IDBServer::IDBServer::performCloseAndDeleteDatabasesForOrigins): (WebCore::IDBServer::IDBServer::didPerformCloseAndDeleteDatabases): * Modules/indexeddb/server/IDBServer.h: * Modules/indexeddb/server/UniqueIDBDatabase.cpp: (WebCore::IDBServer::UniqueIDBDatabase::~UniqueIDBDatabase): (WebCore::IDBServer::UniqueIDBDatabase::openDatabaseConnection): (WebCore::IDBServer::UniqueIDBDatabase::didDeleteBackingStore): (WebCore::IDBServer::UniqueIDBDatabase::handleDatabaseOperations): (WebCore::IDBServer::UniqueIDBDatabase::handleCurrentOperation): (WebCore::IDBServer::UniqueIDBDatabase::handleDelete): (WebCore::IDBServer::UniqueIDBDatabase::createObjectStore): (WebCore::IDBServer::UniqueIDBDatabase::deleteObjectStore): (WebCore::IDBServer::UniqueIDBDatabase::clearObjectStore): (WebCore::IDBServer::UniqueIDBDatabase::createIndex): (WebCore::IDBServer::UniqueIDBDatabase::deleteIndex): (WebCore::IDBServer::UniqueIDBDatabase::putOrAdd): (WebCore::IDBServer::UniqueIDBDatabase::getRecord): (WebCore::IDBServer::UniqueIDBDatabase::getCount): (WebCore::IDBServer::UniqueIDBDatabase::deleteRecord): (WebCore::IDBServer::UniqueIDBDatabase::openCursor): (WebCore::IDBServer::UniqueIDBDatabase::iterateCursor): (WebCore::IDBServer::UniqueIDBDatabase::commitTransaction): (WebCore::IDBServer::UniqueIDBDatabase::abortTransaction): (WebCore::IDBServer::UniqueIDBDatabase::connectionClosedFromClient): (WebCore::IDBServer::UniqueIDBDatabase::connectionClosedFromServer): (WebCore::IDBServer::UniqueIDBDatabase::confirmDidCloseFromServer): (WebCore::IDBServer::UniqueIDBDatabase::enqueueTransaction): (WebCore::IDBServer::UniqueIDBDatabase::isCurrentlyInUse): (WebCore::IDBServer::UniqueIDBDatabase::invokeOperationAndTransactionTimer): (WebCore::IDBServer::UniqueIDBDatabase::operationAndTransactionTimerFired): (WebCore::IDBServer::UniqueIDBDatabase::activateTransactionInBackingStore): (WebCore::IDBServer::UniqueIDBDatabase::transactionCompleted): (WebCore::IDBServer::UniqueIDBDatabase::postDatabaseTask): (WebCore::IDBServer::UniqueIDBDatabase::postDatabaseTaskReply): (WebCo
[webkit-changes] [201097] trunk/Websites/bugs.webkit.org
Title: [201097] trunk/Websites/bugs.webkit.org Revision 201097 Author ddkil...@apple.com Date 2016-05-18 13:21:31 -0700 (Wed, 18 May 2016) Log Message CVE-2016-2803: [SECURITY] XSS vulnerability in dependency graphs via bug summary Merge Bugzilla upstream master dd61903154fd363fb4e763d60aa155a507c2c3fc. * showdependencygraph.cgi: (CreateImagemap): Fix XSS vulnerability. Modified Paths trunk/Websites/bugs.webkit.org/ChangeLog trunk/Websites/bugs.webkit.org/showdependencygraph.cgi Diff Modified: trunk/Websites/bugs.webkit.org/ChangeLog (201096 => 201097) --- trunk/Websites/bugs.webkit.org/ChangeLog 2016-05-18 20:01:19 UTC (rev 201096) +++ trunk/Websites/bugs.webkit.org/ChangeLog 2016-05-18 20:21:31 UTC (rev 201097) @@ -1,3 +1,13 @@ +2016-05-18 David Kilzer + +CVE-2016-2803: [SECURITY] XSS vulnerability in dependency graphs via bug summary + + +Merge Bugzilla upstream master dd61903154fd363fb4e763d60aa155a507c2c3fc. + +* showdependencygraph.cgi: +(CreateImagemap): Fix XSS vulnerability. + 2016-05-05 David Kilzer bugs.webkit.org: "See Also" field should support Chromium bugs Modified: trunk/Websites/bugs.webkit.org/showdependencygraph.cgi (201096 => 201097) --- trunk/Websites/bugs.webkit.org/showdependencygraph.cgi 2016-05-18 20:01:19 UTC (rev 201096) +++ trunk/Websites/bugs.webkit.org/showdependencygraph.cgi 2016-05-18 20:21:31 UTC (rev 201097) @@ -67,13 +67,19 @@ $default = qq{ } -if ($line =~ /^rectangle \((.*),(.*)\) \((.*),(.*)\) (http[^ ]*) (\d+)(\\n.*)?$/) { +if ($line =~ /^rectangle \((\d+),(\d+)\) \((\d+),(\d+)\) (http[^ ]*) (\d+)(?:\\n.*)?$/) { my ($leftx, $rightx, $topy, $bottomy, $url, $bugid) = ($1, $3, $2, $4, $5, $6); # Pick up bugid from the mapdata label field. Getting the title from # bugtitle hash instead of mapdata allows us to get the summary even # when showsummary is off, and also gives us status and resolution. +# This text is safe; it has already been escaped. my $bugtitle = html_quote(clean_text($bugtitles{$bugid})); + +# The URL is supposed to be safe, because it's built manually. +# But in case someone manages to inject code, it's safer to escape it. +$url = "" + $map .= qq{ qq{title="$bugtitle" href="" } . qq{coords="$leftx,$topy,$rightx,$bottomy">\n}; ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [201096] trunk/Source/WebInspectorUI
Title: [201096] trunk/Source/WebInspectorUI Revision 201096 Author commit-qu...@webkit.org Date 2016-05-18 13:01:19 -0700 (Wed, 18 May 2016) Log Message Web Inspector: Improve console.takeHeapSnapshot documentation in console https://bugs.webkit.org/show_bug.cgi?id=157853 Patch by Joseph Pecoraro on 2016-05-18 Reviewed by Timothy Hatcher. * UserInterface/Models/NativeFunctionParameters.js: Mention optional label argument. Modified Paths trunk/Source/WebInspectorUI/ChangeLog trunk/Source/WebInspectorUI/UserInterface/Models/NativeFunctionParameters.js Diff Modified: trunk/Source/WebInspectorUI/ChangeLog (201095 => 201096) --- trunk/Source/WebInspectorUI/ChangeLog 2016-05-18 19:35:54 UTC (rev 201095) +++ trunk/Source/WebInspectorUI/ChangeLog 2016-05-18 20:01:19 UTC (rev 201096) @@ -1,3 +1,13 @@ +2016-05-18 Joseph Pecoraro + +Web Inspector: Improve console.takeHeapSnapshot documentation in console +https://bugs.webkit.org/show_bug.cgi?id=157853 + +Reviewed by Timothy Hatcher. + +* UserInterface/Models/NativeFunctionParameters.js: +Mention optional label argument. + 2016-05-18 Brian Burg Web Inspector: race between frontend and backend both starting timeline recordings causes console assert Modified: trunk/Source/WebInspectorUI/UserInterface/Models/NativeFunctionParameters.js (201095 => 201096) --- trunk/Source/WebInspectorUI/UserInterface/Models/NativeFunctionParameters.js 2016-05-18 19:35:54 UTC (rev 201095) +++ trunk/Source/WebInspectorUI/UserInterface/Models/NativeFunctionParameters.js 2016-05-18 20:01:19 UTC (rev 201096) @@ -175,6 +175,7 @@ profile: "name", profileEnd: "name", table: "data, [columns]", +takeHeapSnapshot: "[label]", time: "name = \"default\"", timeEnd: "name = \"default\"", timeStamp: "[label]", ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [201095] trunk/Source
Title: [201095] trunk/Source Revision 201095 Author bshaf...@apple.com Date 2016-05-18 12:35:54 -0700 (Wed, 18 May 2016) Log Message Versioning. Modified Paths trunk/Source/_javascript_Core/Configurations/Version.xcconfig trunk/Source/WebCore/Configurations/Version.xcconfig trunk/Source/WebInspectorUI/Configurations/Version.xcconfig trunk/Source/WebKit/mac/Configurations/Version.xcconfig trunk/Source/WebKit2/Configurations/Version.xcconfig Diff Modified: trunk/Source/_javascript_Core/Configurations/Version.xcconfig (201094 => 201095) --- trunk/Source/_javascript_Core/Configurations/Version.xcconfig 2016-05-18 19:34:19 UTC (rev 201094) +++ trunk/Source/_javascript_Core/Configurations/Version.xcconfig 2016-05-18 19:35:54 UTC (rev 201095) @@ -23,7 +23,7 @@ MAJOR_VERSION = 602; MINOR_VERSION = 1; -TINY_VERSION = 33; +TINY_VERSION = 34; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: trunk/Source/WebCore/Configurations/Version.xcconfig (201094 => 201095) --- trunk/Source/WebCore/Configurations/Version.xcconfig 2016-05-18 19:34:19 UTC (rev 201094) +++ trunk/Source/WebCore/Configurations/Version.xcconfig 2016-05-18 19:35:54 UTC (rev 201095) @@ -23,7 +23,7 @@ MAJOR_VERSION = 602; MINOR_VERSION = 1; -TINY_VERSION = 33; +TINY_VERSION = 34; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: trunk/Source/WebInspectorUI/Configurations/Version.xcconfig (201094 => 201095) --- trunk/Source/WebInspectorUI/Configurations/Version.xcconfig 2016-05-18 19:34:19 UTC (rev 201094) +++ trunk/Source/WebInspectorUI/Configurations/Version.xcconfig 2016-05-18 19:35:54 UTC (rev 201095) @@ -1,6 +1,6 @@ MAJOR_VERSION = 602; MINOR_VERSION = 1; -TINY_VERSION = 33; +TINY_VERSION = 34; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: trunk/Source/WebKit/mac/Configurations/Version.xcconfig (201094 => 201095) --- trunk/Source/WebKit/mac/Configurations/Version.xcconfig 2016-05-18 19:34:19 UTC (rev 201094) +++ trunk/Source/WebKit/mac/Configurations/Version.xcconfig 2016-05-18 19:35:54 UTC (rev 201095) @@ -23,7 +23,7 @@ MAJOR_VERSION = 602; MINOR_VERSION = 1; -TINY_VERSION = 33; +TINY_VERSION = 34; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: trunk/Source/WebKit2/Configurations/Version.xcconfig (201094 => 201095) --- trunk/Source/WebKit2/Configurations/Version.xcconfig 2016-05-18 19:34:19 UTC (rev 201094) +++ trunk/Source/WebKit2/Configurations/Version.xcconfig 2016-05-18 19:35:54 UTC (rev 201095) @@ -23,7 +23,7 @@ MAJOR_VERSION = 602; MINOR_VERSION = 1; -TINY_VERSION = 33; +TINY_VERSION = 34; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [201094] tags/Safari-602.1.33/
Title: [201094] tags/Safari-602.1.33/ Revision 201094 Author bshaf...@apple.com Date 2016-05-18 12:34:19 -0700 (Wed, 18 May 2016) Log Message New tag. Added Paths tags/Safari-602.1.33/ Diff Property changes: tags/Safari-602.1.33 Added: svn:ignore depcomp compile config.guess GNUmakefile.in config.sub ltmain.sh aconfig.h.in autom4te.cache missing aclocal.m4 install-sh autotoolsconfig.h.in INSTALL README gtk-doc.make out Makefile.chromium WebKitSupportLibrary.zip WebKitBuild Added: svn:mergeinfo ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [201093] trunk/PerformanceTests
Title: [201093] trunk/PerformanceTests Revision 201093 Author timo...@apple.com Date 2016-05-18 12:32:55 -0700 (Wed, 18 May 2016) Log Message Make Animometer work in all browsers https://bugs.webkit.org/show_bug.cgi?id=157855 rdar://problem/26338521 Reviewed by Jon Lee. * Animometer/resources/runner/logo.svg: Use a symbol instead of putting the id on the root svg. This works in all browsers. Modified Paths trunk/PerformanceTests/Animometer/resources/runner/logo.svg trunk/PerformanceTests/ChangeLog Diff Modified: trunk/PerformanceTests/Animometer/resources/runner/logo.svg (201092 => 201093) --- trunk/PerformanceTests/Animometer/resources/runner/logo.svg 2016-05-18 19:29:14 UTC (rev 201092) +++ trunk/PerformanceTests/Animometer/resources/runner/logo.svg 2016-05-18 19:32:55 UTC (rev 201093) @@ -1,24 +1,26 @@ - - - - + + + + + - - + + - + - - - - + + + + - - - - - - + + + + + + + Modified: trunk/PerformanceTests/ChangeLog (201092 => 201093) --- trunk/PerformanceTests/ChangeLog 2016-05-18 19:29:14 UTC (rev 201092) +++ trunk/PerformanceTests/ChangeLog 2016-05-18 19:32:55 UTC (rev 201093) @@ -1,3 +1,14 @@ +2016-05-18 Timothy Hatcher + +Make Animometer work in all browsers +https://bugs.webkit.org/show_bug.cgi?id=157855 +rdar://problem/26338521 + +Reviewed by Jon Lee. + +* Animometer/resources/runner/logo.svg: Use a symbol instead +of putting the id on the root svg. This works in all browsers. + 2016-05-07 Timothy Hatcher Update Animometer design ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [201092] trunk/Source/WebInspectorUI
Title: [201092] trunk/Source/WebInspectorUI Revision 201092 Author bb...@apple.com Date 2016-05-18 12:29:14 -0700 (Wed, 18 May 2016) Log Message Web Inspector: race between frontend and backend both starting timeline recordings causes console assert https://bugs.webkit.org/show_bug.cgi?id=157850 Reviewed by Joseph Pecoraro. If TimelineManager has created a fresh recording and the Timeline.autoCaptureStarted event comes before Timeline.recordingStarted, then the manager will try to start the same recording twice. In this scenario, the manager should just wait until the Timeline.recordingStarted event comes, since it causes TimelineMangare to set up the isCapturing flag and other state. * UserInterface/Controllers/TimelineManager.js: (WebInspector.TimelineManager): (WebInspector.TimelineManager.prototype.startCapturing): (WebInspector.TimelineManager.prototype.capturingStarted): (WebInspector.TimelineManager.prototype.autoCaptureStarted): Add a new flag, this._waitingForCapturingStartedEvent. If true, don't start the recording in response to this event. Modified Paths trunk/Source/WebInspectorUI/ChangeLog trunk/Source/WebInspectorUI/UserInterface/Controllers/TimelineManager.js Diff Modified: trunk/Source/WebInspectorUI/ChangeLog (201091 => 201092) --- trunk/Source/WebInspectorUI/ChangeLog 2016-05-18 19:10:14 UTC (rev 201091) +++ trunk/Source/WebInspectorUI/ChangeLog 2016-05-18 19:29:14 UTC (rev 201092) @@ -1,3 +1,25 @@ +2016-05-18 Brian Burg + +Web Inspector: race between frontend and backend both starting timeline recordings causes console assert +https://bugs.webkit.org/show_bug.cgi?id=157850 + + +Reviewed by Joseph Pecoraro. + +If TimelineManager has created a fresh recording and the Timeline.autoCaptureStarted +event comes before Timeline.recordingStarted, then the manager will try to start the +same recording twice. In this scenario, the manager should just wait until the +Timeline.recordingStarted event comes, since it causes TimelineMangare to set up +the isCapturing flag and other state. + +* UserInterface/Controllers/TimelineManager.js: +(WebInspector.TimelineManager): +(WebInspector.TimelineManager.prototype.startCapturing): +(WebInspector.TimelineManager.prototype.capturingStarted): +(WebInspector.TimelineManager.prototype.autoCaptureStarted): +Add a new flag, this._waitingForCapturingStartedEvent. If true, don't start the +recording in response to this event. + 2016-05-18 Matt Baker Web Inspector: REGRESSION(r197488): Incorrect start time in Rendering Frames timeline grid Modified: trunk/Source/WebInspectorUI/UserInterface/Controllers/TimelineManager.js (201091 => 201092) --- trunk/Source/WebInspectorUI/UserInterface/Controllers/TimelineManager.js 2016-05-18 19:10:14 UTC (rev 201091) +++ trunk/Source/WebInspectorUI/UserInterface/Controllers/TimelineManager.js 2016-05-18 19:29:14 UTC (rev 201092) @@ -1,5 +1,5 @@ /* - * Copyright (C) 2013 Apple Inc. All rights reserved. + * Copyright (C) 2013, 2016 Apple Inc. All rights reserved. * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions @@ -42,6 +42,7 @@ this._persistentNetworkTimeline = new WebInspector.NetworkTimeline; this._isCapturing = false; +this._waitingForCapturingStartedEvent = false; this._isCapturingPageReload = false; this._autoCaptureOnPageLoad = false; this._mainResourceForAutoCapturing = null; @@ -170,6 +171,8 @@ if (!this._activeRecording || shouldCreateRecording) this._loadNewRecording(); +this._waitingForCapturingStartedEvent = true; + this.dispatchEventToListeners(WebInspector.TimelineManager.Event.CapturingWillStart); this._activeRecording.start(); @@ -221,6 +224,7 @@ if (this._isCapturing) return; +this._waitingForCapturingStartedEvent = false; this._isCapturing = true; this._lastDeadTimeTickle = 0; @@ -265,7 +269,11 @@ if (this._isCapturing) this.stopCapturing(); -this.startCapturing(true); +// We may already have an fresh TimelineRecording created if autoCaptureStarted is received +// between sending the Timeline.start command and receiving Timeline.capturingStarted event. +// In that case, there is no need to call startCapturing again. Reuse the fresh recording. +if (!this._waitingForCapturingStartedEvent) +this.startCapturing(true); this._shouldSetAutoCapturingMainResource = true; } ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [201091] trunk/LayoutTests
Title: [201091] trunk/LayoutTests Revision 201091 Author mmaxfi...@apple.com Date 2016-05-18 12:10:14 -0700 (Wed, 18 May 2016) Log Message [OS X] Update platform/mac/fast/text/sticky-typesetting-features.html https://bugs.webkit.org/show_bug.cgi?id=157851 Reviewed by Simon Fraser. Kerning and ligatures are enabled by default now. * platform/mac/fast/text/sticky-typesetting-features-expected.png: * platform/mac/fast/text/sticky-typesetting-features-expected.txt: * platform/mac/fast/text/sticky-typesetting-features.html: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac/fast/text/sticky-typesetting-features-expected.png trunk/LayoutTests/platform/mac/fast/text/sticky-typesetting-features-expected.txt trunk/LayoutTests/platform/mac/fast/text/sticky-typesetting-features.html Diff Modified: trunk/LayoutTests/ChangeLog (201090 => 201091) --- trunk/LayoutTests/ChangeLog 2016-05-18 19:06:27 UTC (rev 201090) +++ trunk/LayoutTests/ChangeLog 2016-05-18 19:10:14 UTC (rev 201091) @@ -1,3 +1,16 @@ +2016-05-18 Myles C. Maxfield + +[OS X] Update platform/mac/fast/text/sticky-typesetting-features.html +https://bugs.webkit.org/show_bug.cgi?id=157851 + +Reviewed by Simon Fraser. + +Kerning and ligatures are enabled by default now. + +* platform/mac/fast/text/sticky-typesetting-features-expected.png: +* platform/mac/fast/text/sticky-typesetting-features-expected.txt: +* platform/mac/fast/text/sticky-typesetting-features.html: + 2016-05-18 Simon Fraser REGRESSION (r200534) Command-+ no longer zooms pages Modified: trunk/LayoutTests/platform/mac/fast/text/sticky-typesetting-features-expected.png (Binary files differ) Modified: trunk/LayoutTests/platform/mac/fast/text/sticky-typesetting-features-expected.txt (201090 => 201091) --- trunk/LayoutTests/platform/mac/fast/text/sticky-typesetting-features-expected.txt 2016-05-18 19:06:27 UTC (rev 201090) +++ trunk/LayoutTests/platform/mac/fast/text/sticky-typesetting-features-expected.txt 2016-05-18 19:10:14 UTC (rev 201091) @@ -1,17 +1,20 @@ layer at (0,0) size 800x600 RenderView at (0,0) size 800x600 -layer at (0,0) size 800x600 - RenderBlock {HTML} at (0,0) size 800x600 -RenderBody {BODY} at (8,8) size 784x584 +layer at (0,0) size 800x390 + RenderBlock {HTML} at (0,0) size 800x390 +RenderBody {BODY} at (8,16) size 784x366 RenderBlock {P} at (0,0) size 784x18 -RenderText {#text} at (0,0) size 351x18 - text run at (0,0) width 351: "This should be rendered without kerning and ligatures:" - RenderBlock {DIV} at (0,34) size 784x166 -RenderText {#text} at (0,0) size 754x166 - text run at (0,0) width 754: "Office\x{301} Today" - RenderBlock {P} at (0,216) size 784x18 -RenderText {#text} at (0,0) size 331x18 - text run at (0,0) width 331: "This should be rendered with kerning and ligatures:" - RenderBlock {DIV} at (0,250) size 784x166 -RenderText {#text} at (0,0) size 754x166 - text run at (0,0) width 754: "Office Today" +RenderText {#text} at (0,0) size 464x18 + text run at (0,0) width 464: "All of the following lines should be rendered with kerning and ligatures:" + RenderBlock {DIV} at (0,34) size 784x83 +RenderText {#text} at (0,0) size 377x83 + text run at (0,0) width 377: "Office\x{301} Today" + RenderBlock {DIV} at (0,117) size 784x83 +RenderText {#text} at (0,0) size 377x83 + text run at (0,0) width 377: "Office Today" + RenderBlock {DIV} at (0,200) size 784x83 +RenderText {#text} at (0,0) size 377x83 + text run at (0,0) width 377: "Office\x{301} Today" + RenderBlock {DIV} at (0,283) size 784x83 +RenderText {#text} at (0,0) size 377x83 + text run at (0,0) width 377: "Office Today" Modified: trunk/LayoutTests/platform/mac/fast/text/sticky-typesetting-features.html (201090 => 201091) --- trunk/LayoutTests/platform/mac/fast/text/sticky-typesetting-features.html 2016-05-18 19:06:27 UTC (rev 201090) +++ trunk/LayoutTests/platform/mac/fast/text/sticky-typesetting-features.html 2016-05-18 19:10:14 UTC (rev 201091) @@ -1,12 +1,20 @@ - -This should be rendered without kerning and ligatures: - - -Officé Today - - -This should be rendered with kerning and ligatures: - - -Office Today - + + + + +.test { +font-size: 72px; +} +.legibility { +text-rendering: optimizeLegibility; +} + + + +All of the following lines should be rendered with kerning and ligatures: +Officé Today +Office Today +Officé Today +Office Today + + ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [201090] trunk
Title: [201090] trunk Revision 201090 Author simon.fra...@apple.com Date 2016-05-18 12:06:27 -0700 (Wed, 18 May 2016) Log Message REGRESSION (r200534) Command-+ no longer zooms pages https://bugs.webkit.org/show_bug.cgi?id=157826 rdar://problem/26334636 Reviewed by Dean Jackson. Source/WebCore: When text autosizing was enabled on Mac, we started to parse and respect -webkit-text-size-adjust. Fix by cutting this off in CSSParser if the feature is disabled. Also fix InternalSettings to reset page and text zoom, since WebKit1 aliases the zoom levels causing DRT to fail to reset them between tests. Test: fast/text-autosizing/mac/text-size-adjust-text-zoom.html * css/CSSParser.cpp: (WebCore::CSSParserContext::CSSParserContext): (WebCore::isValidKeywordPropertyAndValue): (WebCore::CSSParser::parseValue): (WebCore::CSSParser::isTextAutosizingEnabled): * css/CSSParser.h: * css/CSSParserMode.h: * testing/InternalSettings.cpp: (WebCore::InternalSettings::resetToConsistentState): Tools: * DumpRenderTree/mac/DumpRenderTree.mm: (resetWebPreferencesToConsistentValues): Remove ENABLE() #ifdefs that do nothing (see http://webkit.org/b/157828). LayoutTests: Need to call internals.settings.setTextAutosizingEnabled(true) earlier in some tests. * fast/text-autosizing/ios/line-height-text-autosizing.html: * fast/text-autosizing/ios/percent-adjust-length-line-height.html: * fast/text-autosizing/ios/percent-adjust-number-line-height.html: * fast/text-autosizing/ios/percent-adjust-percent-line-height.html: * fast/text-autosizing/mac/text-size-adjust-text-zoom-expected.html: Added. * fast/text-autosizing/mac/text-size-adjust-text-zoom.html: Added. * platform/mac-wk2/TestExpectations: * platform/mac/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/fast/text-autosizing/ios/line-height-text-autosizing.html trunk/LayoutTests/fast/text-autosizing/ios/percent-adjust-length-line-height.html trunk/LayoutTests/fast/text-autosizing/ios/percent-adjust-number-line-height.html trunk/LayoutTests/fast/text-autosizing/ios/percent-adjust-percent-line-height.html trunk/LayoutTests/platform/mac/TestExpectations trunk/LayoutTests/platform/mac-wk2/TestExpectations trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/css/CSSParser.cpp trunk/Source/WebCore/css/CSSParser.h trunk/Source/WebCore/css/CSSParserMode.h trunk/Source/WebCore/testing/InternalSettings.cpp trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm Added Paths trunk/LayoutTests/fast/text-autosizing/mac/ trunk/LayoutTests/fast/text-autosizing/mac/text-size-adjust-text-zoom-expected.html trunk/LayoutTests/fast/text-autosizing/mac/text-size-adjust-text-zoom.html Diff Modified: trunk/LayoutTests/ChangeLog (201089 => 201090) --- trunk/LayoutTests/ChangeLog 2016-05-18 19:03:38 UTC (rev 201089) +++ trunk/LayoutTests/ChangeLog 2016-05-18 19:06:27 UTC (rev 201090) @@ -1,3 +1,22 @@ +2016-05-18 Simon Fraser + +REGRESSION (r200534) Command-+ no longer zooms pages +https://bugs.webkit.org/show_bug.cgi?id=157826 +rdar://problem/26334636 + +Reviewed by Dean Jackson. + +Need to call internals.settings.setTextAutosizingEnabled(true) earlier in some tests. + +* fast/text-autosizing/ios/line-height-text-autosizing.html: +* fast/text-autosizing/ios/percent-adjust-length-line-height.html: +* fast/text-autosizing/ios/percent-adjust-number-line-height.html: +* fast/text-autosizing/ios/percent-adjust-percent-line-height.html: +* fast/text-autosizing/mac/text-size-adjust-text-zoom-expected.html: Added. +* fast/text-autosizing/mac/text-size-adjust-text-zoom.html: Added. +* platform/mac-wk2/TestExpectations: +* platform/mac/TestExpectations: + 2016-05-18 Joanmarie Diggs [GTK] accessibility/meter-element.html is failing Modified: trunk/LayoutTests/fast/text-autosizing/ios/line-height-text-autosizing.html (201089 => 201090) --- trunk/LayoutTests/fast/text-autosizing/ios/line-height-text-autosizing.html 2016-05-18 19:03:38 UTC (rev 201089) +++ trunk/LayoutTests/fast/text-autosizing/ios/line-height-text-autosizing.html 2016-05-18 19:06:27 UTC (rev 201090) @@ -1,6 +1,12 @@ + +if (window.internals) { +internals.settings.setTextAutosizingEnabled(true); +internals.settings.setTextAutosizingWindowSizeOverride(320, 480); +} +-