[webkit-changes] [WebKit/WebKit] 5b3687: REGRESSION (261190@main): Lots of tests crashing i...

[Simon Fraser]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5b368793a8c0a3d99c6991fcd3ef96e3dbd2cf2a
  
https://github.com/WebKit/WebKit/commit/5b368793a8c0a3d99c6991fcd3ef96e3dbd2cf2a
  Author: Simon Fraser 
  Date:   2023-03-03 (Fri, 03 Mar 2023)

  Changed paths:
M Source/WebKit/UIProcess/WebPageProxy.cpp

  Log Message:
  ---
  REGRESSION (261190@main): Lots of tests crashing in 
WebPageProxy::createNewPage()
https://bugs.webkit.org/show_bug.cgi?id=253383
rdar://106227636

Unreviewed crash fix.

* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::createNewPage):

Canonical link: https://commits.webkit.org/261215@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 7c30fb: Fix the internal build with older SDKs after 26118...

[Wenson Hsieh]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7c30fb184c3fd65f2d9f64b9e76aa2de607e94ec
  
https://github.com/WebKit/WebKit/commit/7c30fb184c3fd65f2d9f64b9e76aa2de607e94ec
  Author: Wenson Hsieh 
  Date:   2023-03-03 (Fri, 03 Mar 2023)

  Changed paths:
M Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm

  Log Message:
  ---
  Fix the internal build with older SDKs after 261181@main
https://bugs.webkit.org/show_bug.cgi?id=253288
rdar://100583135

Reviewed by Mark Lam.

Soft link several newly-introduced APIs in libnetcore, so that we can both 
build using older SDKs
that don't have the symbol, and also run against older builds that don't 
support these functions.

* Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(WebKit::SessionWrapper::initialize):
(WebKit::NetworkSessionCocoa::clearProxyConfigData):
(WebKit::NetworkSessionCocoa::setProxyConfigData):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm:
(TestWebKitAPI::TEST):

Canonical link: https://commits.webkit.org/261214@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 2f8b9c: Unreviewed, fix gtk build after 261211@main

[Matthieu Dubet]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2f8b9c7f28e84862a8713c44f8201386f13a84fa
  
https://github.com/WebKit/WebKit/commit/2f8b9c7f28e84862a8713c44f8201386f13a84fa
  Author: Matthieu Dubet 
  Date:   2023-03-03 (Fri, 03 Mar 2023)

  Changed paths:
M Source/WebCore/Sources.txt
M Source/WebCore/platform/graphics/TextTransform.cpp
M Source/WebCore/rendering/RenderText.cpp

  Log Message:
  ---
  Unreviewed, fix gtk build after 261211@main
https://bugs.webkit.org/show_bug.cgi?id=253379
rdar://106226408

* Source/WebCore/Sources.txt:
* Source/WebCore/platform/graphics/TextTransform.cpp:
* Source/WebCore/rendering/RenderText.cpp:
(WebCore::transformToFullWidth): Deleted.

Canonical link: https://commits.webkit.org/261213@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 51bcd2: Fix non-Cocoa build after 261211@main

[Alex Christensen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 51bcd2ffa5fd41a680c68624314bef5c913c0549
  
https://github.com/WebKit/WebKit/commit/51bcd2ffa5fd41a680c68624314bef5c913c0549
  Author: Alex Christensen 
  Date:   2023-03-03 (Fri, 03 Mar 2023)

  Changed paths:
M Source/WebCore/rendering/RenderText.cpp

  Log Message:
  ---
  Fix non-Cocoa build after 261211@main
https://bugs.webkit.org/show_bug.cgi?id=253380

Unreviewed.

* Source/WebCore/rendering/RenderText.cpp:
(WebCore::transformToFullWidth):

Canonical link: https://commits.webkit.org/261212@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 2b128e: Implement CSS text-transform: full-width

[Matthieu Dubet]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2b128e4b33892acb61b70cf325cfdbbc14717dab
  
https://github.com/WebKit/WebKit/commit/2b128e4b33892acb61b70cf325cfdbbc14717dab
  Author: Matthieu Dubet 
  Date:   2023-03-03 (Fri, 03 Mar 2023)

  Changed paths:
M LayoutTests/TestExpectations
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-text/parsing/text-transform-computed-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-text/parsing/text-transform-valid-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/text-transform-expected.txt
M LayoutTests/inspector/css/getSupportedCSSProperties-expected.txt
M LayoutTests/platform/gtk/TestExpectations
M LayoutTests/platform/wpe/TestExpectations
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
M Source/WebCore/css/CSSPrimitiveValueMappings.h
M Source/WebCore/css/CSSProperties.json
M Source/WebCore/css/CSSValueKeywords.in
A Source/WebCore/platform/graphics/TextTransform.cpp
A Source/WebCore/platform/graphics/TextTransform.h
A Source/WebCore/platform/graphics/cocoa/TextTransformCocoa.cpp
M Source/WebCore/rendering/RenderText.cpp
M Source/WebCore/rendering/style/RenderStyleConstants.cpp
M Source/WebCore/rendering/style/RenderStyleConstants.h

  Log Message:
  ---
  Implement CSS text-transform: full-width
https://bugs.webkit.org/show_bug.cgi?id=143153
rdar://81520147

Reviewed by Myles C. Maxfield.

Only on Cocoa platform. Some characters mapping are missing from the underlying 
API, such as '(' and ')'.

https://w3c.github.io/csswg-drafts/css-text/#full-width

* LayoutTests/TestExpectations:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-text/parsing/text-transform-computed-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-text/parsing/text-transform-valid-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/text-transform-expected.txt:
* LayoutTests/inspector/css/getSupportedCSSProperties-expected.txt:
* LayoutTests/platform/gtk/TestExpectations:
* LayoutTests/platform/wpe/TestExpectations:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/css/CSSPrimitiveValueMappings.h:
* Source/WebCore/css/CSSProperties.json:
* Source/WebCore/css/CSSValueKeywords.in:
* Source/WebCore/platform/graphics/TextTransform.cpp: Added.
(WebCore::transformToFullWidth):
* Source/WebCore/platform/graphics/TextTransform.h: Added.
* Source/WebCore/platform/graphics/cocoa/TextTransformCocoa.cpp: Added.
(WebCore::transformToFullWidth):
* Source/WebCore/rendering/RenderText.cpp:
(WebCore::applyTextTransform):
* Source/WebCore/rendering/style/RenderStyleConstants.cpp:
(WebCore::operator<<):
* Source/WebCore/rendering/style/RenderStyleConstants.h:

Canonical link: https://commits.webkit.org/261211@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] aa13aa: AX: Remove boundingBoxRect and computedLabel from ...

[Tyler Wilcock]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: aa13aa32a9839363ae62683ab88fca4841bb9d35
  
https://github.com/WebKit/WebKit/commit/aa13aa32a9839363ae62683ab88fca4841bb9d35
  Author: Tyler Wilcock 
  Date:   2023-03-03 (Fri, 03 Mar 2023)

  Changed paths:
M Source/WebCore/accessibility/AccessibilityObject.h
M Source/WebCore/accessibility/AccessibilityObjectInterface.h
M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp
M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h

  Log Message:
  ---
  AX: Remove boundingBoxRect and computedLabel from the AXCoreObject interface
https://bugs.webkit.org/show_bug.cgi?id=253289
rdar://problem/106175101

Reviewed by Andres Gonzalez.

These functions are only necessary for `AccessibilityObject`s, not 
`AXIsolatedObject`s.

This patch also makes calls to `performFunctionOnMainThread` type their lamdba 
with `AccessibilityObject*` instead
of `AXCoreObject*`. `performFunctionOnMainThread` calls 
`AXIsolatedObject::associatedAXObject()`, which returns an 
`AccessibilityObject*`,
so let's use the stronger typing to make the code more clear and to help 
devirtualization optimizations.

* Source/WebCore/accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::boundingBoxRect const):
* Source/WebCore/accessibility/AccessibilityObjectInterface.h:
(WebCore::AXCoreObject::pixelSnappedBoundingBoxRect const): Deleted.
* Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp:
(WebCore::AXIsolatedObject::setSelectedChildren):
(WebCore::AXIsolatedObject::setARIAGrabbed):
(WebCore::AXIsolatedObject::setIsExpanded):
(WebCore::AXIsolatedObject::scrollToMakeVisible const):
(WebCore::AXIsolatedObject::scrollToMakeVisibleWithSubFocus const):
(WebCore::AXIsolatedObject::scrollToGlobalPoint const):
(WebCore::AXIsolatedObject::setSelected):
(WebCore::AXIsolatedObject::setSelectedRows):
(WebCore::AXIsolatedObject::setFocused):
(WebCore::AXIsolatedObject::setSelectedText):
(WebCore::AXIsolatedObject::setSelectedTextRange):
(WebCore::AXIsolatedObject::getOrRetrievePropertyValue):
(WebCore::AXIsolatedObject::makeRangeVisible):
(WebCore::AXIsolatedObject::increment):
(WebCore::AXIsolatedObject::decrement):
(WebCore::AXIsolatedObject::computedLabel): Deleted.
(WebCore::AXIsolatedObject::boundingBoxRect const): Deleted.
* Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h:
* Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h:

Canonical link: https://commits.webkit.org/261210@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] aa1b9d: Blue boxes appear at ends of selection for live te...

[Richard Robinson]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: aa1b9db26fd093f7d590af2d65ea4352289eac4f
  
https://github.com/WebKit/WebKit/commit/aa1b9db26fd093f7d590af2d65ea4352289eac4f
  Author: Richard Robinson 
  Date:   2023-03-03 (Fri, 03 Mar 2023)

  Changed paths:
M Source/WebCore/rendering/RenderObject.cpp

  Log Message:
  ---
  Blue boxes appear at ends of selection for live text for images with vertical 
writing mode
https://bugs.webkit.org/show_bug.cgi?id=253335
rdar://106106328

Reviewed by Wenson Hsieh.

`SelectionRenderingBehavior::UseIndividualQuads` doesn't currently work well 
for images
with a vertical writing mode, so this PR works around it by only using that 
behavior for
horizontal writing modes.

* Source/WebCore/rendering/RenderObject.cpp:
(WebCore::adjustLineHeightOfSelectionGeometries):
(WebCore::RenderObject::collectSelectionGeometriesInternal):
(WebCore::RenderObject::collectSelectionGeometries):

Canonical link: https://commits.webkit.org/261209@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 5a3e8e: Unreviewed, another build fix after 261181@main

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5a3e8eb942e76186e55da765c79a8fe542c24e5e
  
https://github.com/WebKit/WebKit/commit/5a3e8eb942e76186e55da765c79a8fe542c24e5e
  Author: Chris Dumez 
  Date:   2023-03-03 (Fri, 03 Mar 2023)

  Changed paths:
M Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.h

  Log Message:
  ---
  Unreviewed, another build fix after 261181@main
https://bugs.webkit.org/show_bug.cgi?id=253374
rdar://106224551

* Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.h:

Canonical link: https://commits.webkit.org/261208@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 8d8fbc: Unreviewed build fix after 261181@main

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8d8fbca8ec871be3e76587845b9a0fc7aac5163a
  
https://github.com/WebKit/WebKit/commit/8d8fbca8ec871be3e76587845b9a0fc7aac5163a
  Author: Chris Dumez 
  Date:   2023-03-03 (Fri, 03 Mar 2023)

  Changed paths:
M Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.h
M Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.mm

  Log Message:
  ---
  Unreviewed build fix after 261181@main
https://bugs.webkit.org/show_bug.cgi?id=253372
rdar://106224114

* Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.h:

Canonical link: https://commits.webkit.org/261207@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 36c736: Attachment's save button click event is now always...

[Gerald Squelart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 36c736481d50204339ae930b9922c6a03bb06aae
  
https://github.com/WebKit/WebKit/commit/36c736481d50204339ae930b9922c6a03bb06aae
  Author: Gerald Squelart 
  Date:   2023-03-03 (Fri, 03 Mar 2023)

  Changed paths:
M Source/WebCore/html/HTMLAttachmentElement.cpp
M Source/WebCore/html/HTMLAttachmentElement.h

  Log Message:
  ---
  Attachment's save button click event is now always named "save"
https://bugs.webkit.org/show_bug.cgi?id=253269
rdar://106108684

Reviewed by Tim Nguyen.

The HTML attribute "save" doesn't need a value anymore. If it's present with 
any value, the save button is shown, and clicking on it will dispatch a 
MouseEvent with type name "save".

* Source/WebCore/html/HTMLAttachmentElement.cpp:
(WebCore::saveAtom):
(WebCore::saveAttr):
(WebCore::HTMLAttachmentElement::ensureModernShadowTree):
(WebCore::HTMLAttachmentElement::updateSaveButton):
(WebCore::HTMLAttachmentElement::parseAttribute):
* Source/WebCore/html/HTMLAttachmentElement.h:

Canonical link: https://commits.webkit.org/261206@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 43b73e: [contain-intrinsic-size] failures related to repla...

[cathiechen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 43b73e296e5003e669fcb0ba76304837e90cbaa9
  
https://github.com/WebKit/WebKit/commit/43b73e296e5003e669fcb0ba76304837e90cbaa9
  Author: Cathie Chen 
  Date:   2023-03-03 (Fri, 03 Mar 2023)

  Changed paths:
M LayoutTests/TestExpectations
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/contain-intrinsic-size/contain-intrinsic-size-028-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/contain-intrinsic-size/contain-intrinsic-size-logical-003-expected.txt
M Source/WebCore/rendering/RenderBox.cpp
M Source/WebCore/rendering/RenderReplaced.cpp
M Source/WebCore/rendering/RenderReplaced.h
M Source/WebCore/rendering/RenderVideo.cpp
M Source/WebCore/rendering/RenderVideo.h

  Log Message:
  ---
  [contain-intrinsic-size] failures related to replaced elements
https://bugs.webkit.org/show_bug.cgi?id=253013

Reviewed by Alan Baradlay.

This patch makes intrinsicSize() considering both contain: size and inline-size,
so that there is no need to handle contain: inline-size specially.
In computeReplacedLogicalWidth/Height, hasIntrinsicWidth/Height is determined 
by width/height > 0,
for contain: size/inline-size, hasIntrinsicWidth/Height should be true 
regardless of the value.
For RenderVideo, in calculateIntrinsicSize(), the intrinsic size should 
consider contain: inline-size,
so this patch adjustSizeForInlineSizeContainment before return.

* LayoutTests/TestExpectations:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/contain-intrinsic-size/contain-intrinsic-size-028-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/contain-intrinsic-size/contain-intrinsic-size-logical-003-expected.txt:
* Source/WebCore/rendering/RenderBox.cpp:
(WebCore::RenderBox::intrinsicLogicalWidth const):
* Source/WebCore/rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::computeAspectRatioInformationForRenderBox const):
(WebCore::RenderReplaced::computeIntrinsicRatioInformation const):
(WebCore::RenderReplaced::computeReplacedLogicalWidth const):
(WebCore::RenderReplaced::computeReplacedLogicalHeight const):
* Source/WebCore/rendering/RenderReplaced.h:
* Source/WebCore/rendering/RenderVideo.cpp:
(WebCore::RenderVideo::calculateIntrinsicSizeInternal):
(WebCore::RenderVideo::calculateIntrinsicSize):
(WebCore::RenderVideo::hasPosterFrameSize const):
* Source/WebCore/rendering/RenderVideo.h:

Canonical link: https://commits.webkit.org/261205@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 0ad5b1: Unreviewed, build fix after 261190@main

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0ad5b1dc33af312d07190406bc9ad974024e96ed
  
https://github.com/WebKit/WebKit/commit/0ad5b1dc33af312d07190406bc9ad974024e96ed
  Author: Chris Dumez 
  Date:   2023-03-03 (Fri, 03 Mar 2023)

  Changed paths:
M Source/WebKit/UIProcess/API/Cocoa/WKPreferences.mm

  Log Message:
  ---
  Unreviewed, build fix after 261190@main
https://bugs.webkit.org/show_bug.cgi?id=253371
rdar://106223448

* Source/WebKit/UIProcess/API/Cocoa/WKPreferences.mm:
* Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.h:

Canonical link: https://commits.webkit.org/261204@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 379912: Cherry-pick c3f992aad4ba. rdar://problem/106207015

[Chris Dumez]

  Branch: refs/heads/safari-7616.1.5-branch
  Home:   https://github.com/WebKit/WebKit
  Commit: 379912cd2edcba2bca3d247c8992c32fc734d244
  
https://github.com/WebKit/WebKit/commit/379912cd2edcba2bca3d247c8992c32fc734d244
  Author: Chris Dumez 
  Date:   2023-03-03 (Fri, 03 Mar 2023)

  Changed paths:
M Source/WebKit/UIProcess/WebPageProxy.cpp
M Source/WebKit/UIProcess/WebProcessProxy.cpp
M Source/WebKit/UIProcess/WebProcessProxy.h

  Log Message:
  ---
  Cherry-pick c3f992aad4ba. rdar://problem/106207015

Unreviewed, fix build after 261190@main
https://bugs.webkit.org/show_bug.cgi?id=253370
rdar://106222696

* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::createNewPage):
* Source/WebKit/UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::recordUserGestureAuthorizationToken):
(WebKit::WebProcessProxy::consumeIfNotVerifiablyFromUIProcess):
* Source/WebKit/UIProcess/WebProcessProxy.h:

Canonical link: https://commits.webkit.org/261202@main

Canonical link: https://commits.webkit.org/261058.5@safari-7616.1.5-branch


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 544810: Cherry-pick ae690092de53. rdar://problem/106207015

[J Pascoe]

  Branch: refs/heads/safari-7616.1.5-branch
  Home:   https://github.com/WebKit/WebKit
  Commit: 544810005c51b596a7823c29b139e005e745ebb4
  
https://github.com/WebKit/WebKit/commit/544810005c51b596a7823c29b139e005e745ebb4
  Author: J Pascoe 
  Date:   2023-03-03 (Fri, 03 Mar 2023)

  Changed paths:
M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
M Source/WebCore/dom/UserGestureIndicator.cpp
M Source/WebCore/dom/UserGestureIndicator.h
M Source/WebCore/page/EventHandler.cpp
M Source/WebCore/platform/PlatformEvent.h
M Source/WebCore/platform/PlatformMouseEvent.h
M Source/WebKit/Shared/NavigationActionData.h
M Source/WebKit/Shared/NavigationActionData.serialization.in
M Source/WebKit/Shared/WebEvent.cpp
M Source/WebKit/Shared/WebEvent.h
M Source/WebKit/Shared/WebEvent.serialization.in
M Source/WebKit/Shared/WebEventConversion.cpp
M Source/WebKit/Shared/mac/WebEventFactory.mm
M Source/WebKit/UIProcess/API/APIUserInitiatedAction.h
M Source/WebKit/UIProcess/API/Cocoa/WKPreferences.mm
M Source/WebKit/UIProcess/API/Cocoa/WKPreferencesPrivate.h
M Source/WebKit/UIProcess/WebPageProxy.cpp
M Source/WebKit/UIProcess/WebProcessProxy.cpp
M Source/WebKit/UIProcess/WebProcessProxy.h
M Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp
M Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp

  Log Message:
  ---
  Cherry-pick ae690092de53. rdar://problem/106207015

Cherry-pick 261190@main (ae690092de53). rdar://problem/106207015

Verify user gesture for popups originated from UI process
https://bugs.webkit.org/show_bug.cgi?id=253338
rdar://problem/106207015

Reviewed by Chris Dumez

For certain actions like opening a new window, we don't want the web 
process to be
able to fake a user gesture to the client. This patch accomplishes that 
by creating
an identifier whenever we parse the input event, storing it, and then 
invalidating it
whenever we get it back from a WebProcess wanting to perform an action 
where we don't
want to trust simulated gestures.

* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WebCore/dom/UserGestureIndicator.cpp:
(WebCore::UserGestureToken::UserGestureToken):
(WebCore::UserGestureIndicator::UserGestureIndicator):
(WebCore::UserGestureIndicator::authorizationToken):
* Source/WebCore/dom/UserGestureIndicator.h:
(WebCore::UserGestureToken::create):
(WebCore::UserGestureToken::authorizationToken):
* Source/WebCore/page/EventHandler.cpp:
(WebCore::EventHandler::handleMouseReleaseEvent):
* Source/WebCore/platform/PlatformEvent.h:
(WebCore::PlatformEvent::authorizationToken const):
* Source/WebCore/platform/PlatformMouseEvent.h:
* Source/WebKit/Shared/NavigationActionData.h:
* Source/WebKit/Shared/NavigationActionData.serialization.in:
* Source/WebKit/Shared/WebEvent.cpp:
(WebKit::WebEvent::WebEvent):
* Source/WebKit/Shared/WebEvent.h:
(WebKit::WebEvent::authorizationToken const):
* Source/WebKit/Shared/WebEvent.serialization.in:
* Source/WebKit/Shared/WebEventConversion.cpp:
(WebKit::WebKit2PlatformMouseEvent::WebKit2PlatformMouseEvent):
* Source/WebKit/Shared/mac/WebEventFactory.mm:
(WebKit::WebEventFactory::createWebMouseEvent):
(WebKit::WebEventFactory::createWebWheelEvent):
(WebKit::WebEventFactory::createWebKeyboardEvent):
* Source/WebKit/UIProcess/API/APIUserInitiatedAction.h:
* Source/WebKit/UIProcess/API/Cocoa/WKPreferences.mm:
(-[WKPreferences _setVerifyWindowOpenUserGestureFromUIProcess:]):
(-[WKPreferences _verifyWindowOpenUserGestureFromUIProcess]):
* Source/WebKit/UIProcess/API/Cocoa/WKPreferencesPrivate.h:
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::processNextQueuedMouseEvent):
(WebKit::WebPageProxy::handleKeyboardEvent):
(WebKit::WebPageProxy::createNewPage):
(WebKit::WebPageProxy::didReceiveEvent):
* Source/WebKit/UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::userInitiatedActivity):
(WebKit::WebProcessProxy::consumeIfNotVerifiablyFromUIProcess):
(WebKit::WebProcessProxy::didDestroyUserGestureToken):
* Source/WebKit/UIProcess/WebProcessProxy.h:
* Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::createWindow):
* Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::didSameDocumentNavigationForFrameViaJSHistoryAPI):
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):

Canonical link: https

[webkit-changes] [WebKit/WebKit] b7fdc7: [web-animations] accelerate more properties with t...

[Antoine Quint]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b7fdc77150f0922a3b964264c5795a93285dfc56
  
https://github.com/WebKit/WebKit/commit/b7fdc77150f0922a3b964264c5795a93285dfc56
  Author: Antoine Quint 
  Date:   2023-03-03 (Fri, 03 Mar 2023)

  Changed paths:
M Source/WebCore/animation/CSSPropertyAnimation.cpp

  Log Message:
  ---
  [web-animations] accelerate more properties with threaded animation resolution
https://bugs.webkit.org/show_bug.cgi?id=253315

Reviewed by Dean Jackson.

With threaded animation resolution we will be able to accelerate more properties
than we have in the past, for instance CSS Motion Path properties. So we now opt
those into acceleration based on the threaded animation resolution setting.

* Source/WebCore/animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):

Canonical link: https://commits.webkit.org/261203@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] c3f992: Unreviewed, fix build after 261190@main

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c3f992aad4ba211eb10b3554967a5a53ec31e179
  
https://github.com/WebKit/WebKit/commit/c3f992aad4ba211eb10b3554967a5a53ec31e179
  Author: Chris Dumez 
  Date:   2023-03-03 (Fri, 03 Mar 2023)

  Changed paths:
M Source/WebKit/UIProcess/WebPageProxy.cpp
M Source/WebKit/UIProcess/WebProcessProxy.cpp
M Source/WebKit/UIProcess/WebProcessProxy.h

  Log Message:
  ---
  Unreviewed, fix build after 261190@main
https://bugs.webkit.org/show_bug.cgi?id=253370
rdar://106222696

* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::createNewPage):
* Source/WebKit/UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::recordUserGestureAuthorizationToken):
(WebKit::WebProcessProxy::consumeIfNotVerifiablyFromUIProcess):
* Source/WebKit/UIProcess/WebProcessProxy.h:

Canonical link: https://commits.webkit.org/261202@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] ac186a: Block logd in WebContent

[Per Arne Vollan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ac186a8cd8aeb6525562dd59a3d5ba86a6734aae
  
https://github.com/WebKit/WebKit/commit/ac186a8cd8aeb6525562dd59a3d5ba86a6734aae
  Author: Per Arne Vollan 
  Date:   2023-03-03 (Fri, 03 Mar 2023)

  Changed paths:
M Source/WTF/wtf/spi/cocoa/OSLogSPI.h
M Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp
M Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.h
M Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.messages.in
M 
Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in
M Source/WebKit/Scripts/process-entitlements.sh
M 
Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceMain.mm
M Source/WebKit/UIProcess/Launcher/cocoa/ProcessLauncherCocoa.mm
M Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm
M Source/WebKit/WebProcess/com.apple.WebProcess.sb.in

  Log Message:
  ---
  Block logd in WebContent
https://bugs.webkit.org/show_bug.cgi?id=253342
rdar://105416416

Reviewed by John Wilander.

Block logging service in the WebContent process sandbox unless the build is 
internal. This requires
some tweaks at startup of the WebContent process to avoid opening up a Mach 
connection to the service
before determining if logging should be enabled. Logs will be forwarded to the 
Networking process for
logging there if logging is disabled in the WebContent process. This feature is 
off by default, and
will only be enabled by default after further discussion and review from a 
larger group of stake-
holders. Initial performance measurements indicate that this feature is neutral 
and possibly even a
progression on page load benchmarks.

* Source/WTF/wtf/PlatformEnableCocoa.h:
* Source/WTF/wtf/spi/cocoa/OSLogSPI.h:
* Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::logOnBehalfOfWebContent):
* Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.h:
* Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.messages.in:
* Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in:
* Source/WebKit/Scripts/process-entitlements.sh:
* Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceMain.mm:
(WebKit::initializeCFPrefs):
(WebKit::blockLogdInSandbox):
(WebKit::initializeLogd):
(WebKit::XPCServiceEventHandler):
(WebKit::XPCServiceMain):
* Source/WebKit/UIProcess/Launcher/cocoa/ProcessLauncherCocoa.mm:
(WebKit::ProcessLauncher::launchProcess):
* Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::platformInitializeWebProcess):
(WebKit::registerLogHook):
(WebKit::WebProcess::platformInitializeProcess):
(WebKit::initializeLogd): Deleted.
* Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:

Canonical link: https://commits.webkit.org/261201@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 761070: [Cocoa] Enable StorageManager.estimate by default

[Sihui]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7610702507a37da5b4294fdce45612447f7f8acc
  
https://github.com/WebKit/WebKit/commit/7610702507a37da5b4294fdce45612447f7f8acc
  Author: Sihui Liu 
  Date:   2023-03-03 (Fri, 03 Mar 2023)

  Changed paths:
M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml

  Log Message:
  ---
  [Cocoa] Enable StorageManager.estimate by default
https://bugs.webkit.org/show_bug.cgi?id=253279
rdar://106169267

Reviewed by Tim Nguyen.

* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:

Canonical link: https://commits.webkit.org/261200@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 1dbfbb: [GTK] Update Korean translations - Mar 3, 2023

[ChangSeok Oh]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1dbfbb4c31d9762ff10617b2e198912355cf277a
  
https://github.com/WebKit/WebKit/commit/1dbfbb4c31d9762ff10617b2e198912355cf277a
  Author: ChangSeok Oh 
  Date:   2023-03-03 (Fri, 03 Mar 2023)

  Changed paths:
M Source/WebCore/platform/gtk/po/ko.po

  Log Message:
  ---
  [GTK] Update Korean translations - Mar 3, 2023
https://bugs.webkit.org/show_bug.cgi?id=253368

Reviewed by Michael Catanzaro.

This change updates Korean translations for WebKitGTK+.

* Source/WebCore/platform/gtk/po/ko.po:

Canonical link: https://commits.webkit.org/261199@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 451357: Inline Document::page()

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 451357755ccc470408df3da61a2ace2f787268d6
  
https://github.com/WebKit/WebKit/commit/451357755ccc470408df3da61a2ace2f787268d6
  Author: Chris Dumez 
  Date:   2023-03-03 (Fri, 03 Mar 2023)

  Changed paths:
M Source/WebCore/Modules/encryptedmedia/MediaKeySystemRequest.cpp
M Source/WebCore/dom/Document.cpp
M Source/WebCore/dom/Document.h
M Source/WebCore/dom/FullscreenManager.h
M Source/WebCore/page/Page.h

  Log Message:
  ---
  Inline Document::page()
https://bugs.webkit.org/show_bug.cgi?id=253293

Reviewed by Darin Adler.

Inline Document::page() as it is small and shows on profiles.

* Source/WebCore/Modules/encryptedmedia/MediaKeySystemRequest.cpp:
* Source/WebCore/dom/Document.cpp:
(WebCore::Document::page const): Deleted.
* Source/WebCore/dom/Document.h:
* Source/WebCore/dom/FullscreenManager.h:
* Source/WebCore/page/Page.h:
(WebCore::Document::page const):

Canonical link: https://commits.webkit.org/261198@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 1a169d: Add experimental feature for post-processing Canva...

[Matthew Finkel]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1a169d095a6691b2461810e3b639fffed1cf87f6
  
https://github.com/WebKit/WebKit/commit/1a169d095a6691b2461810e3b639fffed1cf87f6
  Author: Matthew Finkel 
  Date:   2023-03-03 (Fri, 03 Mar 2023)

  Changed paths:
M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
M Source/WebCore/html/CanvasBase.cpp
M Source/WebCore/html/CanvasBase.h
M Source/WebCore/html/HTMLCanvasElement.cpp
M Source/WebCore/html/canvas/CanvasRenderingContext.h
M Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp
M Source/WebCore/html/canvas/CanvasRenderingContext2DBase.h
M Source/WebCore/html/canvas/CanvasStyle.h

  Log Message:
  ---
  Add experimental feature for post-processing Canvas image data
https://bugs.webkit.org/show_bug.cgi?id=243555
rdar://98525861

Reviewed by Wenson Hsieh.

In this new experimental feature we post-process the Canvas2D and WebGL buffers
by adding small amounts of noise in the rendered image data. The approach this
patch takes is similar to a proposed patch by Eli Lucherini. In that patch, for
every pixel of the rendered canvas, with some probability one primary color
channel of a pixel might have a small amount of noise added. In this patch,
instead we add small amounts of noise depending on the whole pixel's value.

* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WebCore/html/CanvasBase.cpp:
(WebCore::CanvasBase::makeRenderingResultsAvailable):
(WebCore::CanvasBase::postProcessPixelBuffer const):
* Source/WebCore/html/CanvasBase.h:
* Source/WebCore/html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::getImageData):
* Source/WebCore/html/canvas/CanvasRenderingContext.h:
(WebCore::CanvasRenderingContext::postProcessPixelBuffer const):
* Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp:
(WebCore::CanvasRenderingContext2DBase::setFillStyle):
(WebCore::computeImageDataRect):
(WebCore::CanvasRenderingContext2DBase::postProcessPixelBuffer const):
(WebCore::CanvasRenderingContext2DBase::didDraw):
(WebCore::CanvasRenderingContext2DBase::getImageData const):
(WebCore::CanvasRenderingContext2DBase::putImageData):
* Source/WebCore/html/canvas/CanvasRenderingContext2DBase.h:
(WebCore::CanvasRenderingContext2DBase::suppliedColors const):
* Source/WebCore/html/canvas/CanvasStyle.h:
(WebCore::CanvasStyle::srgbaColor const):

Canonical link: https://commits.webkit.org/261197@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] d1b505: TestFeatures.h:40:37: error: use of undeclared ide...

[Michael Catanzaro]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d1b505231d0dcdfa954d937dd372caafaaacf009
  
https://github.com/WebKit/WebKit/commit/d1b505231d0dcdfa954d937dd372caafaaacf009
  Author: Michael Catanzaro 
  Date:   2023-03-03 (Fri, 03 Mar 2023)

  Changed paths:
M Tools/TestRunnerShared/TestFeatures.h

  Log Message:
  ---
  TestFeatures.h:40:37: error: use of undeclared identifier 'uint32_t'
https://bugs.webkit.org/show_bug.cgi?id=253350

Unreviewed build fix.

* Tools/TestRunnerShared/TestFeatures.h:

Canonical link: https://commits.webkit.org/261196@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 4fad65: Unreviewed, reduce count of test

[Yusuke Suzuki]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4fad651a3bcd61ca60f3615eb1f979e11ff3cc8c
  
https://github.com/WebKit/WebKit/commit/4fad651a3bcd61ca60f3615eb1f979e11ff3cc8c
  Author: Yusuke Suzuki 
  Date:   2023-03-03 (Fri, 03 Mar 2023)

  Changed paths:
M JSTests/wasm/stress/referenced-function.js

  Log Message:
  ---
  Unreviewed, reduce count of test
https://bugs.webkit.org/show_bug.cgi?id=253361
rdar://106218642

This is too slow on Debug bots. Reduce count.

* JSTests/wasm/stress/referenced-function.js:

Canonical link: https://commits.webkit.org/261195@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 2630f2: Add WKWebsiteDataTypeHashSalt to allow fetching/re...

[Sihui]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2630f203a0c9c9bb0ff5e884d47254a6a8101e76
  
https://github.com/WebKit/WebKit/commit/2630f203a0c9c9bb0ff5e884d47254a6a8101e76
  Author: Sihui Liu 
  Date:   2023-03-03 (Fri, 03 Mar 2023)

  Changed paths:
M Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataRecord.h
M Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataRecord.mm
M Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataRecordInternal.h
M Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.mm

  Log Message:
  ---
  Add WKWebsiteDataTypeHashSalt to allow fetching/removing DeviceIDHashSalt data
https://bugs.webkit.org/show_bug.cgi?id=253174
rdar://106096684

Reviewed by Chris Dumez.

Otherwise the data type cannot be viewed by WebKit client.

* Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataRecord.h:
* Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataRecord.mm:
(dataTypesToString):
* Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataRecordInternal.h:
(WebKit::toWebsiteDataType):
(WebKit::toWKWebsiteDataTypes):
* Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.mm:
(+[WKWebsiteDataStore allWebsiteDataTypes]):

Canonical link: https://commits.webkit.org/261194@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 6a08cd: [popover] Enable popover attribute

[Tim Nguyen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6a08cd63e8162f286d3b71ccd85807db31937d5b
  
https://github.com/WebKit/WebKit/commit/6a08cd63e8162f286d3b71ccd85807db31937d5b
  Author: Tim Nguyen 
  Date:   2023-03-03 (Fri, 03 Mar 2023)

  Changed paths:
M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml

  Log Message:
  ---
  [popover] Enable popover attribute
https://bugs.webkit.org/show_bug.cgi?id=253363
rdar://106219137

Reviewed by Brent Fulgham.

* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:

Canonical link: https://commits.webkit.org/261193@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 2d1b4d: Unreviewed, fix build on shipping macOS / iOS afte...

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2d1b4df4bbfcac7f23e99ab233e7146514795009
  
https://github.com/WebKit/WebKit/commit/2d1b4df4bbfcac7f23e99ab233e7146514795009
  Author: Chris Dumez 
  Date:   2023-03-03 (Fri, 03 Mar 2023)

  Changed paths:
M Source/WTF/wtf/PlatformHave.h

  Log Message:
  ---
  Unreviewed, fix build on shipping macOS / iOS after 261181@main
https://bugs.webkit.org/show_bug.cgi?id=253362
rdar://106219063

* Source/WTF/wtf/PlatformHave.h:

Canonical link: https://commits.webkit.org/261192@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] fa0d2c: Inline small wasm functions

[Justin Michaud]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fa0d2ca34a9cdfc451719663ed074136e63ac3a0
  
https://github.com/WebKit/WebKit/commit/fa0d2ca34a9cdfc451719663ed074136e63ac3a0
  Author: Justin Michaud 
  Date:   2023-03-03 (Fri, 03 Mar 2023)

  Changed paths:
M JSTests/wasm/function-tests/stack-trace.js
A 
JSTests/wasm/stress/simple-inline-exception-inlinee-catch-with-delegate-block.js
A 
JSTests/wasm/stress/simple-inline-exception-inlinee-catch-with-delegate-block.wasm
A 
JSTests/wasm/stress/simple-inline-exception-inlinee-catch-with-delegate-block.wat
A 
JSTests/wasm/stress/simple-inline-exception-inlinee-catch-with-delegate-catch.js
A 
JSTests/wasm/stress/simple-inline-exception-inlinee-catch-with-delegate-catch.wasm
A 
JSTests/wasm/stress/simple-inline-exception-inlinee-catch-with-delegate-catch.wat
A JSTests/wasm/stress/simple-inline-exception-inlinee-catch-with-delegate.js
A 
JSTests/wasm/stress/simple-inline-exception-inlinee-catch-with-delegate.wasm
A 
JSTests/wasm/stress/simple-inline-exception-inlinee-catch-with-delegate.wat
A JSTests/wasm/stress/simple-inline-exception-inlinee-catch-with-tag-arg.js
A 
JSTests/wasm/stress/simple-inline-exception-inlinee-catch-with-tag-arg.wasm
A JSTests/wasm/stress/simple-inline-exception-inlinee-catch-with-tag-arg.wat
A JSTests/wasm/stress/simple-inline-exception-inlinee-catch.js
A JSTests/wasm/stress/simple-inline-exception-inlinee-catch.wasm
A JSTests/wasm/stress/simple-inline-exception-inlinee-catch.wat
A JSTests/wasm/stress/simple-inline-exception.js
A JSTests/wasm/stress/simple-inline-exception.wasm
A JSTests/wasm/stress/simple-inline-exception.wat
A JSTests/wasm/stress/simple-inline-one-arg.js
A JSTests/wasm/stress/simple-inline-one-arg.wasm
A JSTests/wasm/stress/simple-inline-one-arg.wat
A JSTests/wasm/stress/simple-inline.js
A JSTests/wasm/stress/simple-inline.wasm
A JSTests/wasm/stress/simple-inline.wat
M JSTests/wasm/stress/tail-call.js
M Source/JavaScriptCore/runtime/OptionsList.h
M Source/JavaScriptCore/wasm/WasmB3IRGenerator.cpp
M Source/JavaScriptCore/wasm/WasmModuleInformation.h
M Tools/Scripts/run-jsc-stress-tests

  Log Message:
  ---
  Inline small wasm functions
https://bugs.webkit.org/show_bug.cgi?id=252717

Reviewed by Yusuke Suzuki.

Support inlining small wasm functions. When we decide to inline,
we parse the inlinee and add its b3 nodes directly to our graph.

Our inlinee's exception handlers are added directly, but they take care to add 
extra
buffer state for their catch handlers. This state is ignored in the caller.

Arguments and return values are handled transparently, and we skip the
prologue, epilogue or stack check as the caller should handle these things.

Finally, we add a new testing mode that aggressively inlines to test this new 
pass.

* JSTests/wasm/stress/simple-inline-exception.js: Added.
(catch):
* JSTests/wasm/stress/simple-inline-exception.wasm: Added.
* JSTests/wasm/stress/simple-inline-exception.wat: Added.
* JSTests/wasm/stress/simple-inline.js: Added.
* JSTests/wasm/stress/simple-inline.wasm: Added.
* JSTests/wasm/stress/simple-inline.wat: Added.
* Source/JavaScriptCore/b3/B3Generate.cpp:
(JSC::B3::generateToAir):
* Source/JavaScriptCore/b3/B3StackmapValue.cpp:
(JSC::B3::StackmapValue::dumpMeta const):
* Source/JavaScriptCore/b3/B3Value.cpp:
(JSC::B3::Value::generateCompilerConstructionSite):
(JSC::B3::Value::deepDump const):
* Source/JavaScriptCore/jit/AssemblyHelpers.cpp:
(JSC::AssemblyHelpers::restoreCalleeSavesFromEntryFrameCalleeSavesBuffer):
(JSC::AssemblyHelpers::restoreCalleeSavesFromVMEntryFrameCalleeSavesBufferImpl):
(JSC::AssemblyHelpers::emitSave):
(JSC::AssemblyHelpers::emitRestore):
(JSC::AssemblyHelpers::emitSaveCalleeSavesFor):
(JSC::AssemblyHelpers::emitRestoreCalleeSavesFor):
* Source/JavaScriptCore/jit/AssemblyHelpersSpoolers.h:
(JSC::AssemblyHelpers::Spooler::execute):
* Source/JavaScriptCore/runtime/OptionsList.h:
* Source/JavaScriptCore/runtime/VM.cpp:
(JSC::VM::throwException):
* Source/JavaScriptCore/wasm/WasmB3IRGenerator.cpp:
(JSC::Wasm::B3IRGenerator::addStackMap):
(JSC::Wasm::B3IRGenerator::takeStackmaps):
(JSC::Wasm::B3IRGenerator::takeExceptionHandlers):
(JSC::Wasm::B3IRGenerator::B3IRGenerator):
(JSC::Wasm::B3IRGenerator::addLoop):
(JSC::Wasm::B3IRGenerator::preparePatchpointForExceptions):
(JSC::Wasm::B3IRGenerator::emitCatchImpl):
(JSC::Wasm::B3IRGenerator::addDelegateToUnreachable):
(JSC::Wasm::B3IRGenerator::addReturn):
(JSC::Wasm::B3IRGenerator::emitInlineDirectCall):
(JSC::Wasm::B3IRGenerator::addCall):
* Source/JavaScriptCore/wasm/WasmCallee.cpp:
(JSC::Wasm::Callee::Callee):
(JSC::Wasm::Callee::runWithDowncast):
* Source/JavaScriptCore/wasm/WasmCompilationMode.cpp:
(JSC::Wasm::makeString):
* Source/JavaScriptCore/wasm/WasmCompilationMode.h:
(JSC::Wasm::isOSREntry):
(JSC::Wasm::isAnyBBQ):
(JSC::Wasm::isAnyOMG):
* Source/J

[webkit-changes] [WebKit/WebKit] ae6900: Verify user gesture for popups originated from UI ...

[J Pascoe]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ae690092de533ece84f31ade478c148b82d8496c
  
https://github.com/WebKit/WebKit/commit/ae690092de533ece84f31ade478c148b82d8496c
  Author: J Pascoe 
  Date:   2023-03-03 (Fri, 03 Mar 2023)

  Changed paths:
M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
M Source/WebCore/dom/UserGestureIndicator.cpp
M Source/WebCore/dom/UserGestureIndicator.h
M Source/WebCore/page/EventHandler.cpp
M Source/WebCore/platform/PlatformEvent.h
M Source/WebCore/platform/PlatformMouseEvent.h
M Source/WebKit/Shared/NavigationActionData.h
M Source/WebKit/Shared/NavigationActionData.serialization.in
M Source/WebKit/Shared/WebEvent.cpp
M Source/WebKit/Shared/WebEvent.h
M Source/WebKit/Shared/WebEvent.serialization.in
M Source/WebKit/Shared/WebEventConversion.cpp
M Source/WebKit/Shared/mac/WebEventFactory.mm
M Source/WebKit/UIProcess/API/APIUserInitiatedAction.h
M Source/WebKit/UIProcess/API/Cocoa/WKPreferences.mm
M Source/WebKit/UIProcess/API/Cocoa/WKPreferencesPrivate.h
M Source/WebKit/UIProcess/WebPageProxy.cpp
M Source/WebKit/UIProcess/WebProcessProxy.cpp
M Source/WebKit/UIProcess/WebProcessProxy.h
M Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp
M Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp

  Log Message:
  ---
  Verify user gesture for popups originated from UI process
https://bugs.webkit.org/show_bug.cgi?id=253338
rdar://problem/106207015

Reviewed by Chris Dumez

For certain actions like opening a new window, we don't want the web process to 
be
able to fake a user gesture to the client. This patch accomplishes that by 
creating
an identifier whenever we parse the input event, storing it, and then 
invalidating it
whenever we get it back from a WebProcess wanting to perform an action where we 
don't
want to trust simulated gestures.

* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WebCore/dom/UserGestureIndicator.cpp:
(WebCore::UserGestureToken::UserGestureToken):
(WebCore::UserGestureIndicator::UserGestureIndicator):
(WebCore::UserGestureIndicator::authorizationToken):
* Source/WebCore/dom/UserGestureIndicator.h:
(WebCore::UserGestureToken::create):
(WebCore::UserGestureToken::authorizationToken):
* Source/WebCore/page/EventHandler.cpp:
(WebCore::EventHandler::handleMouseReleaseEvent):
* Source/WebCore/platform/PlatformEvent.h:
(WebCore::PlatformEvent::authorizationToken const):
* Source/WebCore/platform/PlatformMouseEvent.h:
* Source/WebKit/Shared/NavigationActionData.h:
* Source/WebKit/Shared/NavigationActionData.serialization.in:
* Source/WebKit/Shared/WebEvent.cpp:
(WebKit::WebEvent::WebEvent):
* Source/WebKit/Shared/WebEvent.h:
(WebKit::WebEvent::authorizationToken const):
* Source/WebKit/Shared/WebEvent.serialization.in:
* Source/WebKit/Shared/WebEventConversion.cpp:
(WebKit::WebKit2PlatformMouseEvent::WebKit2PlatformMouseEvent):
* Source/WebKit/Shared/mac/WebEventFactory.mm:
(WebKit::WebEventFactory::createWebMouseEvent):
(WebKit::WebEventFactory::createWebWheelEvent):
(WebKit::WebEventFactory::createWebKeyboardEvent):
* Source/WebKit/UIProcess/API/APIUserInitiatedAction.h:
* Source/WebKit/UIProcess/API/Cocoa/WKPreferences.mm:
(-[WKPreferences _setVerifyWindowOpenUserGestureFromUIProcess:]):
(-[WKPreferences _verifyWindowOpenUserGestureFromUIProcess]):
* Source/WebKit/UIProcess/API/Cocoa/WKPreferencesPrivate.h:
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::processNextQueuedMouseEvent):
(WebKit::WebPageProxy::handleKeyboardEvent):
(WebKit::WebPageProxy::createNewPage):
(WebKit::WebPageProxy::didReceiveEvent):
* Source/WebKit/UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::userInitiatedActivity):
(WebKit::WebProcessProxy::consumeIfNotVerifiablyFromUIProcess):
(WebKit::WebProcessProxy::didDestroyUserGestureToken):
* Source/WebKit/UIProcess/WebProcessProxy.h:
* Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::createWindow):
* Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::didSameDocumentNavigationForFrameViaJSHistoryAPI):
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):

Canonical link: https://commits.webkit.org/261190@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] b094b7: Unreviewed, fix too slow tests

[Yusuke Suzuki]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b094b7d23b77e566d9a468374ac50ea4a4c857b8
  
https://github.com/WebKit/WebKit/commit/b094b7d23b77e566d9a468374ac50ea4a4c857b8
  Author: Yusuke Suzuki 
  Date:   2023-03-03 (Fri, 03 Mar 2023)

  Changed paths:
M JSTests/wasm/references/externref_globals.js
M JSTests/wasm/references/externref_table.js

  Log Message:
  ---
  Unreviewed, fix too slow tests
https://bugs.webkit.org/show_bug.cgi?id=253359
rdar://106218491

This is invoking GC too frequently and simply test does not finish in a 
reasonable amount of time, so useless.
Fix GC invocation count.

* JSTests/wasm/references/externref_globals.js:
(doGCTest):
* JSTests/wasm/references/externref_table.js:
(doGCTest):

Canonical link: https://commits.webkit.org/261189@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 270c82: Implement RegExp `v` flag with set notation + prop...

[Michael Saboff]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 270c824459cec4d19dab347a8db1526e0be50737
  
https://github.com/WebKit/WebKit/commit/270c824459cec4d19dab347a8db1526e0be50737
  Author: Michael Saboff 
  Date:   2023-03-03 (Fri, 03 Mar 2023)

  Changed paths:
M JSTests/es6/Proxy_internal_get_calls_RegExp.prototype.flags.js
A JSTests/stress/regexp-vflag-property-of-strings.js
M JSTests/stress/static-getter-in-names.js
M JSTests/test262/config.yaml
M LayoutTests/js/Object-getOwnPropertyNames-expected.txt
M LayoutTests/js/script-tests/Object-getOwnPropertyNames.js
M Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj
M Source/JavaScriptCore/builtins/BuiltinNames.h
M Source/JavaScriptCore/builtins/RegExpPrototype.js
M Source/JavaScriptCore/builtins/StringPrototype.js
M Source/JavaScriptCore/bytecode/LinkTimeConstant.h
M Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h
M Source/JavaScriptCore/dfg/DFGFixupPhase.cpp
M Source/JavaScriptCore/dfg/DFGOperations.cpp
M Source/JavaScriptCore/dfg/DFGStrengthReductionPhase.cpp
M Source/JavaScriptCore/runtime/CachedTypes.cpp
M Source/JavaScriptCore/runtime/CommonIdentifiers.h
M Source/JavaScriptCore/runtime/JSGlobalObject.cpp
M Source/JavaScriptCore/runtime/JSGlobalObject.h
M Source/JavaScriptCore/runtime/JSGlobalObjectInlines.h
M Source/JavaScriptCore/runtime/RegExp.h
M Source/JavaScriptCore/runtime/RegExpCache.h
M Source/JavaScriptCore/runtime/RegExpObject.cpp
M Source/JavaScriptCore/runtime/RegExpPrototype.cpp
A Source/JavaScriptCore/ucd/emoji-sequences.txt
A Source/JavaScriptCore/ucd/emoji-zwj-sequences.txt
M Source/JavaScriptCore/yarr/Yarr.h
M Source/JavaScriptCore/yarr/YarrErrorCode.cpp
M Source/JavaScriptCore/yarr/YarrErrorCode.h
M Source/JavaScriptCore/yarr/YarrFlags.cpp
M Source/JavaScriptCore/yarr/YarrFlags.h
M Source/JavaScriptCore/yarr/YarrInterpreter.cpp
M Source/JavaScriptCore/yarr/YarrInterpreter.h
M Source/JavaScriptCore/yarr/YarrJIT.cpp
M Source/JavaScriptCore/yarr/YarrParser.h
M Source/JavaScriptCore/yarr/YarrPattern.cpp
M Source/JavaScriptCore/yarr/YarrPattern.h
M Source/JavaScriptCore/yarr/YarrSyntaxChecker.cpp
M Source/JavaScriptCore/yarr/YarrUnicodeProperties.cpp
M Source/JavaScriptCore/yarr/YarrUnicodeProperties.h
M Source/JavaScriptCore/yarr/generateYarrUnicodePropertyTables.py
M Source/WebCore/contentextensions/URLFilterParser.cpp

  Log Message:
  ---
  Implement RegExp `v` flag with set notation + properties of strings
https://bugs.webkit.org/show_bug.cgi?id=241593
rdar://100337109

Reviewed by Yusuke Suzuki.

This change implements the TC39 stage 3 proposal RegExp v flag with set 
notation + properties of strings,
https://github.com/tc39/proposal-regexp-v-flag.  It adds a new "unicodeSets" 
compile mode for the Yarr engine.
Like the prior Unicode Yarr features, this change is driven by Unicode Database 
Files (UCD).
This change includes two such new files, 
JavaScriptCore/ucd/{emoji-sequences.txt & emoji-zwj-sequences.txt}.

The newly added properties include lists of strings.  These strings are 
processed via the character class syntax
through.  When it comes to matching however, there is some desuguraing that 
turns such a property of strings into
a list of alternations.  For example, say a property has strings str1...strN 
plus a traditional character class,
single-character-class, we create the pattern equivalent of:
 (?:str1|str2|...|strN|[single-character-class])
Per the spec, longer strings appear earlier in the alternation, and before the 
traditional character class.
This allows for searching for longer properties in a property list where 
substrings of other strings are included
in that list.

There are new set of combining operators allowed in the class set character 
classes.  Two character class elements
that appear adjacent to each other implicitly have the Union combining 
operations.  There is also an Intersection
operation with the && operator and a Subtraction operation with the || operator.

There is new ClassSet parsing that follows new "cleaner" rules that traditional 
character classes.
The prior ccharacter class constructor and delegates are mostly unchanged, 
except for the compile mode
now being switched on an enum instead of a bool.

Added check that both 'u' and 'v' flags don't appear in the same RegExp.

Added unicodeSets getter watchpoint to the 
m_regExpPrimordialPropertiesWatchpointSet.

* JSTests/es6/Proxy_internal_get_calls_RegExp.prototype.flags.js:
* JSTests/stress/regexp-vflag-property-of-strings.js: Added.
(arrayToString):
(objectToString):
(dumpValue):
(compareArray):
(compareGroups):
(testRegExp):
(testRegExpSyntaxError):
* JSTests/stress/static-getter-in-names.js:
* JSTests/test262/config.yaml:
* LayoutTests/js/Object-getOwnPropertyNames-expected.txt:
* LayoutTests/js/script-tes

[webkit-changes] [WebKit/WebKit] b08585: Fetch/delete data store identifiers on a backgroun...

[Sihui]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b0858555e5db9ca79f8c414d3dc45ef875dcf6ee
  
https://github.com/WebKit/WebKit/commit/b0858555e5db9ca79f8c414d3dc45ef875dcf6ee
  Author: Sihui Liu 
  Date:   2023-03-03 (Fri, 03 Mar 2023)

  Changed paths:
M Source/WebKit/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm
M Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp
M Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h

  Log Message:
  ---
  Fetch/delete data store identifiers on a background thread
https://bugs.webkit.org/show_bug.cgi?id=253113
rdar://106051983

Reviewed by Chris Dumez.

These involves disk operations that should be performed on background thread.

* Source/WebKit/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:
(WebKit::WebsiteDataStore::fetchAllDataStoreIdentifiers):
(WebKit::WebsiteDataStore::removeDataStoreWithIdentifier):
* Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::websiteDataStoreIOQueue):
* Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h:

Canonical link: https://commits.webkit.org/261187@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] fc172b: [Cocoa] API to set process throttling limits

[Miguel Salinas]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fc172b284b323e8f3669ecd67964fa4f5a1c917e
  
https://github.com/WebKit/WebKit/commit/fc172b284b323e8f3669ecd67964fa4f5a1c917e
  Author: Miguel Salinas 
  Date:   2023-03-03 (Fri, 03 Mar 2023)

  Changed paths:
M Source/WebKit/UIProcess/API/Cocoa/WKPreferences.h
M Source/WebKit/UIProcess/API/Cocoa/WKPreferences.mm

  Log Message:
  ---
  [Cocoa] API to set process throttling limits
https://bugs.webkit.org/show_bug.cgi?id=253352
rdar://103084383

Reviewed by Chris Dumez.

API to set background process throttle limits

* Source/WebKit/UIProcess/API/Cocoa/WKPreferences.h:
* Source/WebKit/UIProcess/API/Cocoa/WKPreferences.mm:
(-[WKPreferences setInactiveSchedulingPolicy:]):
(-[WKPreferences inactiveSchedulingPolicy]):

Canonical link: https://commits.webkit.org/261186@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 7eba5a: Enable CSS Contain Intrinsic Size by default

[Sammy Gill]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7eba5ae0b700926ae12c1d513350038d5ac41f5f
  
https://github.com/WebKit/WebKit/commit/7eba5ae0b700926ae12c1d513350038d5ac41f5f
  Author: Sammy Gill 
  Date:   2023-03-03 (Fri, 03 Mar 2023)

  Changed paths:
M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml

  Log Message:
  ---
  Enable CSS Contain Intrinsic Size by default
https://bugs.webkit.org/show_bug.cgi?id=253183
rdar://problem/106099894

Reviewed by Alan Baradlay.

* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:

Canonical link: https://commits.webkit.org/261185@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] a78548: [iOS] Add support for adjusting candidate autocorr...

[Aditya Keerthi]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a78548787147146851cda35e1a46bfcb5a0412fa
  
https://github.com/WebKit/WebKit/commit/a78548787147146851cda35e1a46bfcb5a0412fa
  Author: Aditya Keerthi 
  Date:   2023-03-03 (Fri, 03 Mar 2023)

  Changed paths:
M Source/WebCore/dom/DocumentMarkerController.h
M Source/WebCore/editing/Editor.cpp
M Source/WebKit/UIProcess/WebPageProxy.h
M Source/WebKit/UIProcess/ios/WKContentViewInteraction.h
M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
M Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm
M Source/WebKit/WebProcess/WebPage/WebPage.h
M Source/WebKit/WebProcess/WebPage/WebPage.messages.in
M Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm

  Log Message:
  ---
  [iOS] Add support for adjusting candidate autocorrections
https://bugs.webkit.org/show_bug.cgi?id=253329
rdar://106154530

Reviewed by Wenson Hsieh.

Adopt a new `UIWKInteractionViewProtocol` method to know when a candidate
autocorrection will be inserted.

* Source/WebCore/dom/DocumentMarkerController.h:
(WebCore::addMarker):
* Source/WebCore/editing/Editor.cpp:
(WebCore::shouldRemoveAutocorrectionIndicator):
(WebCore::didApplyAutocorrection):
(WebCore::respondToAppliedEditing):
(WebCore::adjustMarkerTypesToRemoveForWordsAffectedByEditing):
(WebCore::Editor::appliedEditing):
(WebCore::Editor::insertTextWithoutSendingTextEvent):
(WebCore::Editor::updateMarkersForWordsAffectedByEditing):
* Source/WebKit/UIProcess/WebPageProxy.h:
* Source/WebKit/UIProcess/ios/WKContentViewInteraction.h:
* Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView 
applyAutocorrection:toString:isCandidate:withCompletionHandler:]):
(-[WKContentView applyAutocorrection:toString:withCompletionHandler:]):
* Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::applyAutocorrection):
* Source/WebKit/WebProcess/WebPage/WebPage.h:
* Source/WebKit/WebProcess/WebPage/WebPage.messages.in:
* Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::adjustCandidateAutocorrectionInFrame):
(WebKit::WebPage::applyAutocorrection):
(WebKit::WebPage::syncApplyAutocorrection):
(WebKit::WebPage::applyAutocorrectionInternal):

Canonical link: https://commits.webkit.org/261184@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] bbd423: Fix warning introduced in 261124@main

[Don Olmstead]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bbd423cf2e6fd8e27383da52b8a6918c6cc1f0a6
  
https://github.com/WebKit/WebKit/commit/bbd423cf2e6fd8e27383da52b8a6918c6cc1f0a6
  Author: Don Olmstead 
  Date:   2023-03-03 (Fri, 03 Mar 2023)

  Changed paths:
M 
Source/WebKit/Shared/CoordinatedGraphics/threadedcompositor/ThreadedDisplayRefreshMonitor.cpp

  Log Message:
  ---
  Fix warning introduced in 261124@main
https://bugs.webkit.org/show_bug.cgi?id=253339

Unreviewed build fix.

The change removed references to `defaultRefreshRate` causing a warning
which breaks developer builds on PlayStation.

The file is unified on GTK and WPE so my suspicion is that these
warnings only appear on non-unified files.

* 
Source/WebKit/Shared/CoordinatedGraphics/threadedcompositor/ThreadedDisplayRefreshMonitor.cpp:

Canonical link: https://commits.webkit.org/261183@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] f553ff: Enable @counter-style by default at preferences

[Vitor Roriz]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f553ff9e7c032dbcc54b33699caf205a80148f9b
  
https://github.com/WebKit/WebKit/commit/f553ff9e7c032dbcc54b33699caf205a80148f9b
  Author: Vitor Roriz 
  Date:   2023-03-03 (Fri, 03 Mar 2023)

  Changed paths:
M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml

  Log Message:
  ---
  Enable @counter-style by default at preferences
https://bugs.webkit.org/show_bug.cgi?id=253326
rdar://106201695

Reviewed by Brent Fulgham.

Enabling cssCounterStylesAtRulesEnabled by default.

* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:

Canonical link: https://commits.webkit.org/261182@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 54478b: Add proxy API to WKWebsiteDataStore.

[Brady Eidson]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 54478bf81a3e2217d723fef889df7b8d7b88bec9
  
https://github.com/WebKit/WebKit/commit/54478bf81a3e2217d723fef889df7b8d7b88bec9
  Author: Brady Eidson 
  Date:   2023-03-03 (Fri, 03 Mar 2023)

  Changed paths:
M Source/WTF/wtf/PlatformHave.h
M Source/WebKit/NetworkProcess/NetworkProcess.h
M Source/WebKit/NetworkProcess/NetworkProcess.messages.in
M Source/WebKit/NetworkProcess/NetworkSession.h
M Source/WebKit/NetworkProcess/cocoa/NetworkProcessCocoa.mm
M Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.h
M Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm
M Source/WebKit/NetworkProcess/webrtc/NetworkRTCProvider.mm
M Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.h
M Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.mm
M Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp
M Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h
M Tools/TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm

  Log Message:
  ---
  Add proxy API to WKWebsiteDataStore.
https://bugs.webkit.org/show_bug.cgi?id=253288
rdar://100583135

Reviewed by Chris Dumez.

* Source/WTF/wtf/PlatformHave.h:
* Source/WebKit/NetworkProcess/NetworkProcess.h:
* Source/WebKit/NetworkProcess/NetworkProcess.messages.in:
* Source/WebKit/NetworkProcess/NetworkSession.h:
* Source/WebKit/NetworkProcess/cocoa/NetworkProcessCocoa.mm:
(WebKit::NetworkProcess::clearProxyConfigData):
(WebKit::NetworkProcess::setProxyConfigData):
* Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.h:
* Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(WebKit::SessionWrapper::initialize):
(WebKit::NetworkSessionCocoa::forEachSessionWrapper):
(WebKit::NetworkSessionCocoa::clearProxyConfigData):
(WebKit::NetworkSessionCocoa::setProxyConfigData):
* Source/WebKit/NetworkProcess/webrtc/NetworkRTCProvider.mm:
(WebKit::NetworkRTCProvider::proxyInfoFromSession):
* Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.h:
* Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.mm:
(-[WKWebsiteDataStore setProxyConfig:]):
* Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::clearProxyConfigData):
(WebKit::WebsiteDataStore::setProxyConfigData):
* Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h:
* Tools/TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm:
(TestWebKitAPI::TEST):

Canonical link: https://commits.webkit.org/261181@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] fe99ba: [Cocoa] Use new screen/window picker API when avai...

[Eric Carlson]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fe99ba16036bd19b8cc1cff96d394c5dd5b1d275
  
https://github.com/WebKit/WebKit/commit/fe99ba16036bd19b8cc1cff96d394c5dd5b1d275
  Author: Eric Carlson 
  Date:   2023-03-03 (Fri, 03 Mar 2023)

  Changed paths:
M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
M Source/WTF/wtf/PlatformHave.h
M Source/WebCore/Headers.cmake
M Source/WebCore/PAL/pal/mac/ScreenCaptureKitSoftLink.h
M Source/WebCore/PAL/pal/mac/ScreenCaptureKitSoftLink.mm
M Source/WebCore/PAL/pal/spi/mac/ScreenCaptureKitSPI.h
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
M Source/WebCore/platform/audio/PlatformMediaSessionManager.cpp
M Source/WebCore/platform/audio/PlatformMediaSessionManager.h
A Source/WebCore/platform/mediastream/DisplayCapturePromptType.h
M Source/WebCore/platform/mediastream/mac/ScreenCaptureKitCaptureSource.h
M Source/WebCore/platform/mediastream/mac/ScreenCaptureKitCaptureSource.mm
M 
Source/WebCore/platform/mediastream/mac/ScreenCaptureKitSharingSessionManager.h
M 
Source/WebCore/platform/mediastream/mac/ScreenCaptureKitSharingSessionManager.mm
M Source/WebKit/GPUProcess/GPUProcess.cpp
M Source/WebKit/GPUProcess/GPUProcess.h
M Source/WebKit/GPUProcess/GPUProcess.messages.in
M Source/WebKit/GPUProcess/GPUProcessPreferences.cpp
M Source/WebKit/GPUProcess/GPUProcessPreferences.h
M Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in
M Source/WebKit/Shared/Cocoa/WebPreferencesDefaultValuesCocoa.mm
M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in
M Source/WebKit/Shared/WebPreferencesDefaultValues.h
M Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivateForTesting.h
M Source/WebKit/UIProcess/API/Cocoa/WKWebViewTesting.mm
M Source/WebKit/UIProcess/Cocoa/UIDelegate.mm
M Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm
M Source/WebKit/UIProcess/GPU/GPUProcessProxy.cpp
M Source/WebKit/UIProcess/GPU/GPUProcessProxy.h
M Source/WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.cpp
M Source/WebKit/UIProcess/UserMediaPermissionRequestProxy.cpp
M Source/WebKit/UIProcess/UserMediaPermissionRequestProxy.h
M Source/WebKit/UIProcess/WebPageProxy.cpp
M Source/WebKit/UIProcess/WebPageProxy.h
M Source/WebKit/UIProcess/mac/DisplayCaptureSessionManager.h
M Source/WebKit/UIProcess/mac/DisplayCaptureSessionManager.mm
M Source/WebKit/UIProcess/mac/UserMediaPermissionRequestProxyMac.h
M Source/WebKit/UIProcess/mac/UserMediaPermissionRequestProxyMac.mm
M Source/WebKit/WebProcess/WebPage/WebPage.cpp
M Tools/TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm

  Log Message:
  ---
  [Cocoa] Use new screen/window picker API when available
https://bugs.webkit.org/show_bug.cgi?id=251893
rdar://101206117

Reviewed by Jer Noble.

* Source/WebCore/Headers.cmake: Add DisplayCapturePromptType.h.

* Source/WebCore/WebCore.xcodeproj/project.pbxproj: Ditto.

* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: 
SC_CONTENT_SHARING_SESSION -> SCREEN_CAPTURE_KIT.
Add new runtime preference.

* Source/WTF/wtf/PlatformHave.h: Remove HAVE_SC_CONTENT_SHARING_SESSION.

* Source/WebCore/PAL/pal/mac/ScreenCaptureKitSoftLink.h:SCStreamFrameInfoStatus
is always available when ScreenCaptureKit is available.
* Source/WebCore/PAL/pal/mac/ScreenCaptureKitSoftLink.mm:
* Source/WebCore/PAL/pal/spi/mac/ScreenCaptureKitSPI.h:

* Source/WebKit/Shared/Cocoa/WebPreferencesDefaultValuesCocoa.mm:
(WebKit::defaultUseSCContentSharingPicker): Initialize to feature flag value.
* Source/WebKit/Shared/WebPreferencesDefaultValues.h:

* Source/WebCore/platform/audio/PlatformMediaSessionManager.cpp:
(WebCore::PlatformMediaSessionManager::setUseSCContentSharingPicker): New 
preference access.
(WebCore::PlatformMediaSessionManager::useSCContentSharingPicker):
* Source/WebCore/platform/audio/PlatformMediaSessionManager.h:

* Source/WebCore/platform/mediastream/mac/ScreenCaptureKitCaptureSource.h:
* Source/WebCore/platform/mediastream/mac/ScreenCaptureKitCaptureSource.mm:
Rewrite to not be a direct `SCContentSharingSession` delegate and to not create 
`SCContentStream`
directly, but to do both through the ScreenCaptureKitSharingSessionManager.h.

(-[WebCoreScreenCaptureKitHelper stream:didStopWithError:]):
(-[WebCoreScreenCaptureKitHelper stream:didOutputSampleBuffer:ofType:]):
(WebCore::ScreenCaptureKitCaptureSource::~ScreenCaptureKitCaptureSource):
(WebCore::ScreenCaptureKitCaptureSource::stop):
(WebCore::ScreenCaptureKitCaptureSource::sessionFailedWithError):
(WebCore::ScreenCaptureKitCaptureSource::sessionFilterDidChange):
(WebCore::ScreenCaptureKitCaptureSource::sessionStreamDidEnd):
(WebCore::ScreenCaptureKitCaptureSource::startContentStream):
(WebCore::ScreenCaptureKitCaptureSource::updateStreamConfiguration):
(WebCore::ScreenCaptureKitCaptureSource::commitConfiguration):
(WebCore::ScreenCaptureKitCaptu

[webkit-changes] [WebKit/WebKit] 81acad: Unreviewed, just suppress exception warning

[Yusuke Suzuki]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 81acad86697a086e2ed473968443c65544120c4c
  
https://github.com/WebKit/WebKit/commit/81acad86697a086e2ed473968443c65544120c4c
  Author: Yusuke Suzuki 
  Date:   2023-03-03 (Fri, 03 Mar 2023)

  Changed paths:
M Source/JavaScriptCore/interpreter/Interpreter.cpp

  Log Message:
  ---
  Unreviewed, just suppress exception warning
https://bugs.webkit.org/show_bug.cgi?id=253357
rdar://106217064

* Source/JavaScriptCore/interpreter/Interpreter.cpp:
(JSC::Interpreter::executeBoundCall):

Canonical link: https://commits.webkit.org/261179@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 3fb73c: Cherry-pick 41855a914387. rdar://problem/103458234

[Dean Jackson]

  Branch: refs/heads/safari-7616.1.5-branch
  Home:   https://github.com/WebKit/WebKit
  Commit: 3fb73c04b21e4a3768df1616f42a720c59f8a6ef
  
https://github.com/WebKit/WebKit/commit/3fb73c04b21e4a3768df1616f42a720c59f8a6ef
  Author: Dean Jackson 
  Date:   2023-03-03 (Fri, 03 Mar 2023)

  Changed paths:
M 
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm
M 
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm
M Source/WebCore/platform/graphics/cocoa/MediaPlayerPrivateWebM.mm

  Log Message:
  ---
  Cherry-pick 41855a914387. rdar://problem/103458234

Opt out of playback preventing app backgrounding for silent videos
https://bugs.webkit.org/show_bug.cgi?id=253163
rdar://103458234

Reviewed by Jer Noble and Eric Carlson.

AVFoundation has exposed new API on AVPlayer and AVSampleBufferDisplayLayer
to avoid silent media playback from keeping the app moving to the 
background.

Test for the property, then set it to NO.

* 
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer):
* 
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::ensureLayer):
* Source/WebCore/platform/graphics/cocoa/MediaPlayerPrivateWebM.mm:
(WebCore::MediaPlayerPrivateWebM::ensureLayer):

Canonical link: https://commits.webkit.org/261128@main

Canonical link: https://commits.webkit.org/261058.4@safari-7616.1.5-branch


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 4f1841: Replace "CustomHeader=True" with "CustomHeader" in...

[Alex Christensen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4f18414b2c5956d3198c987dafdae5f75b149212
  
https://github.com/WebKit/WebKit/commit/4f18414b2c5956d3198c987dafdae5f75b149212
  Author: Alex Christensen 
  Date:   2023-03-03 (Fri, 03 Mar 2023)

  Changed paths:
M Source/WebKit/Scripts/generate-serializers.py
M Source/WebKit/Shared/API/APIError.serialization.in
M Source/WebKit/Shared/API/APIFrameHandle.serialization.in
M Source/WebKit/Shared/API/APIGeometry.serialization.in
M Source/WebKit/Shared/API/APIPageHandle.serialization.in
M Source/WebKit/Shared/API/APIURL.serialization.in
M Source/WebKit/Shared/API/APIURLRequest.serialization.in
M Source/WebKit/Shared/API/APIURLResponse.serialization.in
M 
Source/WebKit/Shared/ApplePay/ApplePayPaymentSetupFeatures.serialization.in
M Source/WebKit/Shared/ApplePay/PaymentSetupConfiguration.serialization.in
M Source/WebKit/Shared/Cocoa/WebCoreArgumentCodersCocoa.serialization.in
M Source/WebKit/Shared/FocusedElementInformation.serialization.in
M Source/WebKit/Shared/Pasteboard.serialization.in
M Source/WebKit/Shared/ShareableBitmap.serialization.in
M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in
M Source/WebKit/Shared/WebGPU/WebGPUColor.serialization.in
M 
Source/WebKit/Shared/WebGPU/WebGPUComputePassTimestampWrites.serialization.in
M Source/WebKit/Shared/WebGPU/WebGPUOrigin3D.serialization.in
M 
Source/WebKit/Shared/WebGPU/WebGPURenderPassTimestampWrites.serialization.in

  Log Message:
  ---
  Replace "CustomHeader=True" with "CustomHeader" in serialization.in files and 
add attribute documentation
https://bugs.webkit.org/show_bug.cgi?id=253351
rdar://106215304

Reviewed by Simon Fraser.

* Source/WebKit/Scripts/generate-serializers.py:
* Source/WebKit/Shared/API/APIError.serialization.in:
* Source/WebKit/Shared/API/APIFrameHandle.serialization.in:
* Source/WebKit/Shared/API/APIGeometry.serialization.in:
* Source/WebKit/Shared/API/APIPageHandle.serialization.in:
* Source/WebKit/Shared/API/APIURL.serialization.in:
* Source/WebKit/Shared/API/APIURLRequest.serialization.in:
* Source/WebKit/Shared/API/APIURLResponse.serialization.in:
* Source/WebKit/Shared/ApplePay/ApplePayPaymentSetupFeatures.serialization.in:
* Source/WebKit/Shared/ApplePay/PaymentSetupConfiguration.serialization.in:
* Source/WebKit/Shared/Cocoa/WebCoreArgumentCodersCocoa.serialization.in:
* Source/WebKit/Shared/FocusedElementInformation.serialization.in:
* Source/WebKit/Shared/Pasteboard.serialization.in:
* Source/WebKit/Shared/ShareableBitmap.serialization.in:
* Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in:
* Source/WebKit/Shared/WebGPU/WebGPUColor.serialization.in:
* Source/WebKit/Shared/WebGPU/WebGPUComputePassTimestampWrites.serialization.in:
* Source/WebKit/Shared/WebGPU/WebGPUOrigin3D.serialization.in:
* Source/WebKit/Shared/WebGPU/WebGPURenderPassTimestampWrites.serialization.in:

Canonical link: https://commits.webkit.org/261178@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 923d7f: Fix test failures after 261172@main

[Per Arne Vollan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 923d7f965244f4332ce2dce20cba9bbddd6e9e6f
  
https://github.com/WebKit/WebKit/commit/923d7f965244f4332ce2dce20cba9bbddd6e9e6f
  Author: Per Arne Vollan 
  Date:   2023-03-03 (Fri, 03 Mar 2023)

  Changed paths:
M Source/WebKit/WebProcess/com.apple.WebProcess.sb.in

  Log Message:
  ---
  Fix test failures after 261172@main
https://bugs.webkit.org/show_bug.cgi?id=253349
rdar://106214766

Unreviewed fix for test failures.

* Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:

Canonical link: https://commits.webkit.org/261177@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 17ba29: Remove CookieAcceptPolicy related code from WebPro...

[Sihui]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 17ba29f443eeb8e3c8aa1bc80937820c176ef9c2
  
https://github.com/WebKit/WebKit/commit/17ba29f443eeb8e3c8aa1bc80937820c176ef9c2
  Author: Sihui Liu 
  Date:   2023-03-03 (Fri, 03 Mar 2023)

  Changed paths:
M Source/WebKit/UIProcess/API/Cocoa/WKProcessPool.mm
M Source/WebKit/UIProcess/API/Cocoa/WKProcessPoolPrivate.h
M Source/WebKit/UIProcess/WebProcessPool.h

  Log Message:
  ---
  Remove CookieAcceptPolicy related code from WebProcessPool
https://bugs.webkit.org/show_bug.cgi?id=25
rdar://106203382

Reviewed by Alex Christensen.

CookieAcceptPolicy management has been moved to API::HTTPCookieStore.

* Source/WebKit/UIProcess/API/Cocoa/WKProcessPool.mm:
(-[WKProcessPool _setCookieAcceptPolicy:]): Deleted.
(-[WKProcessPool _syncNetworkProcessCookies]): Deleted.
* Source/WebKit/UIProcess/API/Cocoa/WKProcessPoolPrivate.h:
* Source/WebKit/UIProcess/WebProcessPool.h:

Canonical link: https://commits.webkit.org/261176@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 87a1ee: Remove needsInputModeNoneImplicitly

[Rose]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 87a1ee7dd4f2231b246ea65f1ef7ac0b8ac0d06a
  
https://github.com/WebKit/WebKit/commit/87a1ee7dd4f2231b246ea65f1ef7ac0b8ac0d06a
  Author: Rose <83477269+ataridre...@users.noreply.github.com>
  Date:   2023-03-03 (Fri, 03 Mar 2023)

  Changed paths:
M Source/WebCore/html/HTMLElement.cpp
M Source/WebCore/page/Quirks.cpp
M Source/WebCore/page/Quirks.h

  Log Message:
  ---
  Remove needsInputModeNoneImplicitly
https://bugs.webkit.org/show_bug.cgi?id=252819

Reviewed by Ryosuke Niwa.

After checking desmos.com and viewing its source, I can confirm the site
now adopts inputmode="none", so we can remove this quirk.

*Source\WebCore\html\HTMLElement.cpp: Remove
needsInputModeNoneImplicitly check

*Source\WebCore\page\Quirks.cpp: Remove needsInputModeNoneImplicitly
*Source\WebCore\page\Quirks.h: Remove needsInputModeNoneImplicitly

Canonical link: https://commits.webkit.org/261175@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 8aabb4: Unify LocalAuthenticator MakeCredential paths

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8aabb47edefc8778db5ddcb35019e3189524d135
  
https://github.com/WebKit/WebKit/commit/8aabb47edefc8778db5ddcb35019e3189524d135
  Author: Garrett Davidson 
  Date:   2023-03-03 (Fri, 03 Mar 2023)

  Changed paths:
M Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.h
M Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm

  Log Message:
  ---
  Unify LocalAuthenticator MakeCredential paths
rdar://106147850

Reviewed by J Pascoe.

Do some minor clean up to unify the MakeCredential paths in LocalAuthenticator.

* Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.h:
* Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm:
(WebKit::LocalAuthenticator::continueMakeCredentialAfterUserVerification):
(WebKit::LocalAuthenticator::continueMakeCredentialAfterAttested):
(WebKit::LocalAuthenticator::finishMakeCredential):

Canonical link: https://commits.webkit.org/261174@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 983d8e: REGRESSION: [Ventura] http/tests/workers/service/s...

[Ryan Haddad]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 983d8edaa4174f04d9fbbcffaec58b924234ce52
  
https://github.com/WebKit/WebKit/commit/983d8edaa4174f04d9fbbcffaec58b924234ce52
  Author: Ryan Haddad 
  Date:   2023-03-03 (Fri, 03 Mar 2023)

  Changed paths:
M LayoutTests/platform/mac-wk2/TestExpectations

  Log Message:
  ---
  REGRESSION: [Ventura] 
http/tests/workers/service/shownotification-allowed.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=253343
rdar://106210992

Unreviewed test gardening.

* LayoutTests/platform/mac-wk2/TestExpectations: Mark test as flaky.

Canonical link: https://commits.webkit.org/261173@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 5f8370: Add sandbox telemetry for task special port operat...

[Per Arne Vollan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5f8370d754133cdb824d39464235d3eac3b47ad7
  
https://github.com/WebKit/WebKit/commit/5f8370d754133cdb824d39464235d3eac3b47ad7
  Author: Per Arne Vollan 
  Date:   2023-03-03 (Fri, 03 Mar 2023)

  Changed paths:
M 
Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in
M Source/WebKit/WebProcess/com.apple.WebProcess.sb.in

  Log Message:
  ---
  Add sandbox telemetry for task special port operations.
https://bugs.webkit.org/show_bug.cgi?id=253319
rdar://106196547

Reviewed by Brent Fulgham.

Add sandbox telemetry for task special port operations.

* Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in:
* Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:

Canonical link: https://commits.webkit.org/261172@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 84c958: [macOS] Use link check for runningboard throttling

[Miguel Salinas]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 84c958474338a8adeea63096637ef24b5a7f354d
  
https://github.com/WebKit/WebKit/commit/84c958474338a8adeea63096637ef24b5a7f354d
  Author: Miguel Salinas 
  Date:   2023-03-03 (Fri, 03 Mar 2023)

  Changed paths:
M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
M Source/WTF/wtf/cocoa/RuntimeApplicationChecksCocoa.h
M Source/WebKit/Shared/WebPreferencesDefaultValues.cpp
M Source/WebKit/Shared/WebPreferencesDefaultValues.h

  Log Message:
  ---
  [macOS] Use link check for runningboard throttling
https://bugs.webkit.org/show_bug.cgi?id=253290
rdar://106175040

Reviewed by Alex Christensen.

We should use a link check for runningboard based throttling and
suspension on macOS

* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WTF/wtf/cocoa/RuntimeApplicationChecksCocoa.h:
* Source/WebKit/Shared/WebPreferencesDefaultValues.cpp:
(WebKit::defaultRunningBoardThrottlingEnabled):
(WebKit::defaultShouldTakeSuspendedAssertions):
* Source/WebKit/Shared/WebPreferencesDefaultValues.h:

Canonical link: https://commits.webkit.org/261171@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 96f9d0: Marked text does not honor foreground color when s...

[Richard Robinson]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 96f9d0c2e5a5ddbd7421e225fa514c7c2073a61a
  
https://github.com/WebKit/WebKit/commit/96f9d0c2e5a5ddbd7421e225fa514c7c2073a61a
  Author: Richard Robinson 
  Date:   2023-03-03 (Fri, 03 Mar 2023)

  Changed paths:
M Source/WebCore/rendering/TextBoxPainter.cpp
M Source/WebCore/rendering/TextBoxPainter.h

  Log Message:
  ---
  Marked text does not honor foreground color when spellchecking is on
https://bugs.webkit.org/show_bug.cgi?id=253283
rdar://106127073

Reviewed by Aditya Keerthi and Antti Koivisto.

When spellchecking is on, `m_document.markers().hasMarkers()` is `true`, which
meant that `contentMayNeedStyledMarkedText` is `true`, resulting in 
`paintCompositionForeground`
never getting called and so the composition was never being applied.

This PR fixes this by calling `paintCompositionForeground` in all call sites 
where
`paintComposition` was called previously, and then if there is no composition, 
it
just calls `paintForeground` normally like before.

* Source/WebCore/rendering/TextBoxPainter.cpp:
(WebCore::TextBoxPainter::paintCompositionForeground):
(WebCore::TextBoxPainter::paintForegroundAndDecorations):
* Source/WebCore/rendering/TextBoxPainter.h:

Canonical link: https://commits.webkit.org/261170@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 5e4a6f: Factor Shape computation into a standalone function

[Antti Koivisto]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5e4a6f09f5f94236200aee53d376984ed905e897
  
https://github.com/WebKit/WebKit/commit/5e4a6f09f5f94236200aee53d376984ed905e897
  Author: Antti Koivisto 
  Date:   2023-03-03 (Fri, 03 Mar 2023)

  Changed paths:
M Source/WebCore/rendering/RenderBlockFlow.cpp
M Source/WebCore/rendering/shapes/ShapeOutsideInfo.cpp
M Source/WebCore/rendering/shapes/ShapeOutsideInfo.h

  Log Message:
  ---
  Factor Shape computation into a standalone function
https://bugs.webkit.org/show_bug.cgi?id=253313
rdar://106194842

Reviewed by Alan Baradlay.

This will help in supporting shape-outside in LFC.

* Source/WebCore/rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::positionNewFloats):
* Source/WebCore/rendering/shapes/ShapeOutsideInfo.cpp:
(WebCore::referenceBox):
(WebCore::computeLogicalBoxSize):
(WebCore::ShapeOutsideInfo::invalidateForSizeChangeIfNeeded):
(WebCore::makeShapeForShapeOutside):
(WebCore::checkShapeImageOrigin):
(WebCore::ShapeOutsideInfo::computedShape const):
(WebCore::ShapeOutsideInfo::setReferenceBoxLogicalSize): Deleted.
(WebCore::ShapeOutsideInfo::createShapeForImage const): Deleted.
* Source/WebCore/rendering/shapes/ShapeOutsideInfo.h:

Canonical link: https://commits.webkit.org/261169@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 41910e: [ews] Send only important steps info to ews-app

[Aakash J]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 41910e61bbb5a7db89c0689a6e2819853b66fb88
  
https://github.com/WebKit/WebKit/commit/41910e61bbb5a7db89c0689a6e2819853b66fb88
  Author: Aakash Jain 
  Date:   2023-03-03 (Fri, 03 Mar 2023)

  Changed paths:
M Tools/CISupport/ews-app/ews/common/github.py
M Tools/CISupport/ews-app/ews/views/statusbubble.py
M Tools/CISupport/ews-build/events.py

  Log Message:
  ---
  [ews] Send only important steps info to ews-app
https://bugs.webkit.org/show_bug.cgi?id=253341

Reviewed by Ryan Haddad.

EWS (buildbot) should send only important steps info to ews-app. Currently it's
sending information of every step start/stop to ews django app. Then django app
filters out which steps info to use. Instead EWS should just filter out the step
and send only required info to ews-app.

Also, step information is only used to display status-bubble hover-over summary.
Step information in hover-over messages are less useful in GitHub as compared 
to bugzilla,
since there are limitations in Github on how we can display hover-over messages.
We should only display useful information in hover-over messages.

Therefore we should send step information for only the important steps (which we
really want to show in hover-over messages). This would save thousands of 
network
requests every hour from buildbot-server, and would help with load on buildbot 
server.

* Tools/CISupport/ews-app/ews/common/github.py:
(GitHubEWS._should_display_step): Deleted.
* Tools/CISupport/ews-app/ews/views/statusbubble.py:
(StatusBubble):
(StatusBubble._steps_messages_from_multiple_builds):
(StatusBubble._should_display_step): Deleted.
* Tools/CISupport/ews-build/events.py:
(Events): Added list of steps which should be reported to ews django app.
(Events.stepStarted):
(Events.stepFinished):

Canonical link: https://commits.webkit.org/261168@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 440943: REGRESSION(257654@main): [ews-build.webkit.org][GT...

[Carlos Alberto Lopez Perez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 440943ba5b7ea75da370ea5a3d0325262a055127
  
https://github.com/WebKit/WebKit/commit/440943ba5b7ea75da370ea5a3d0325262a055127
  Author: Carlos Alberto Lopez Perez 
  Date:   2023-03-03 (Fri, 03 Mar 2023)

  Changed paths:
M Tools/CISupport/ews-build/steps.py
M Tools/CISupport/ews-build/steps_unittest.py

  Log Message:
  ---
  REGRESSION(257654@main): [ews-build.webkit.org][GTK][WPE] 
RunWebKitTestsRedTree sub-classes are overwriting the 'first_run' properties on 
the retry steps.
https://bugs.webkit.org/show_bug.cgi?id=253048

Reviewed by Jonathan Bedard.

257654@main changed the way the class RunWebKitTests() works: instead of 
specializing the function
buildstep.BuildStep.commandComplete() the function 
buildstep.BuildStep.runCommand() is specialized.

Buildbot first calls runCommand() and then calls commandComplete()

The problem is with the subclasses of RunWebKitTests() which were specializing 
a commandComplete()
function: now instead of executing the generic buildstep.BuildStep.runCommand() 
they execute the
specialized RunWebKitTests.runCommand() which was the previous 
RunWebKitTests.commandComplete()
so this has the undesired effect that the properties defined at 
RunWebKitTests().runCommand()
('first_run_flakies', 'first_run_failures' and 
'first_results_exceed_failure_limit') get
redefined (overwritten) multiple times with the values generated when running 
the command
of each one of the sub-classes.

This is wrong and can cause unexpected issues later when analyzing the results 
in
AnalyzeLayoutTestsResultsRedTree() because the values of the properties 
'first_run_flakies'
and 'first_run_failures' are not the ones from the first run but the ones from 
the last
retry step executed.

Fix it by specializing runCommand() instead of commandComplete() on the 
subclasses like
RunWebKitTests() class does now. Add also a few unit tests.

* Tools/CISupport/ews-build/steps.py:
(RunWebKitTestsRepeatFailuresRedTree):
(RunWebKitTestsRepeatFailuresRedTree.runCommand):
(RunWebKitTestsRepeatFailuresWithoutChangeRedTree):
(RunWebKitTestsRepeatFailuresWithoutChangeRedTree.runCommand):
(RunWebKitTestsRepeatFailuresRedTree.commandComplete): Deleted.
(RunWebKitTestsRepeatFailuresWithoutChangeRedTree.commandComplete): Deleted.
* Tools/CISupport/ews-build/steps_unittest.py:
(MockLayoutTestFailures):
(MockLayoutTestFailures.__init__):
(TestRunWebKitTestsRedTree.configureStep):
(TestRunWebKitTestsRedTree.test_success):
(TestRunWebKitTestsRedTree.test_set_properties_when_executed_scope_this_class):
(TestRunWebKitTestsRepeatFailuresRedTree.configureStep):
(TestRunWebKitTestsRepeatFailuresRedTree.test_success):
(TestRunWebKitTestsRepeatFailuresRedTree.test_set_properties_when_executed_scope_this_class):
(TestRunWebKitTestsRepeatFailuresWithoutChangeRedTree.configureStep):
(TestRunWebKitTestsRepeatFailuresWithoutChangeRedTree.test_success):
(TestRunWebKitTestsRepeatFailuresWithoutChangeRedTree.test_step_with_change_did_timeout):
(TestRunWebKitTestsRepeatFailuresWithoutChangeRedTree.test_set_properties_when_executed_scope_this_class):

Canonical link: https://commits.webkit.org/261167@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 5032e0: Remove export on enum class

[Don Olmstead]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5032e019e64503ec06aeeba4fe887638aa1a2e17
  
https://github.com/WebKit/WebKit/commit/5032e019e64503ec06aeeba4fe887638aa1a2e17
  Author: Don Olmstead 
  Date:   2023-03-03 (Fri, 03 Mar 2023)

  Changed paths:
M Source/WebCore/css/parser/CSSParserEnum.h

  Log Message:
  ---
  Remove export on enum class
https://bugs.webkit.org/show_bug.cgi?id=253332

Unreviewed build fix.

The use of `WEBCORE_EXPORT` on an `enum class` is causing a
`-Wignored-attributes`, "'dllexport' attribute only applies to
functions, variables, classes, and Objective-C interface", which breaks
the developer build.

* Source/WebCore/css/parser/CSSParserEnum.h:

Canonical link: https://commits.webkit.org/261166@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 3d80db: WebCookieJar should clear cache when cookie accept...

[Sihui]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3d80db87c08209096850288337c480abd7bd4131
  
https://github.com/WebKit/WebKit/commit/3d80db87c08209096850288337c480abd7bd4131
  Author: Sihui Liu 
  Date:   2023-03-03 (Fri, 03 Mar 2023)

  Changed paths:
M Source/WebKit/WebKit.xcodeproj/project.pbxproj
M Source/WebKit/WebProcess/Network/NetworkProcessConnection.cpp

  Log Message:
  ---
  WebCookieJar should clear cache when cookie accept policy changes
https://bugs.webkit.org/show_bug.cgi?id=253322
rdar://106198028

Reviewed by Chris Dumez.

When network process changes cookie accept policy, it will notify web process 
about policy change so they have the same
policy. However, in current implementation, web process does not actually 
updates its policy. If WebCookieCache is
already built with old policy, it keeps using the old policy. This means web 
process could have a different view of
cookies from network process. For example, if policy is changed from Accept to 
Never, network process will start
rejecting cookies, while web process will keep accepting them into cache. To 
avoid this issue, this patch ensures cache
is rebuilt when cookie accept policy changes.

* Source/WebKit/WebKit.xcodeproj/project.pbxproj:
* Source/WebKit/WebProcess/Network/NetworkProcessConnection.cpp:
(WebKit::NetworkProcessConnection::cookieAcceptPolicyChanged):

Canonical link: https://commits.webkit.org/261165@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 37fd89: [iOS] Add enablement flag for CARenderServer block...

[Per Arne Vollan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 37fd892327546435028bf1648b5a65646f9fbd6b
  
https://github.com/WebKit/WebKit/commit/37fd892327546435028bf1648b5a65646f9fbd6b
  Author: Per Arne Vollan 
  Date:   2023-03-03 (Fri, 03 Mar 2023)

  Changed paths:
M 
Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in

  Log Message:
  ---
  [iOS] Add enablement flag for CARenderServer blocking in WebContent
https://bugs.webkit.org/show_bug.cgi?id=253266
rdar://problem/106170984

Reviewed by Chris Dumez.

Add enablement flag for CARenderServer blocking in WebContent on iOS.

* Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in:

Canonical link: https://commits.webkit.org/261164@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] ea7a4d: [ews-build.webkit.org] Remove manual verifiers

[Jonathan Bedard]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ea7a4d4c3f7677eb447a502e1ed42a299f1e8989
  
https://github.com/WebKit/WebKit/commit/ea7a4d4c3f7677eb447a502e1ed42a299f1e8989
  Author: Jonathan Bedard 
  Date:   2023-03-03 (Fri, 03 Mar 2023)

  Changed paths:
M Tools/CISupport/ews-build/steps.py
M Tools/CISupport/ews-build/steps_unittest.py

  Log Message:
  ---
  [ews-build.webkit.org] Remove manual verifiers
https://bugs.webkit.org/show_bug.cgi?id=253336
rdar://106206467

Reviewed by Ryan Haddad.

* Tools/CISupport/ews-build/steps.py:
(ValidateCommitterAndReviewer): Remove manual verifiers.
* Tools/CISupport/ews-build/steps_unittest.py:

Canonical link: https://commits.webkit.org/261163@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] d0dcfc: Web Inspector: Add precise editing controls for va...

[Razvan Caliman - Apple]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d0dcfc4c0662f638e82d05512843ffa66c05
  
https://github.com/WebKit/WebKit/commit/d0dcfc4c0662f638e82d05512843ffa66c05
  Author: Razvan Caliman 
  Date:   2023-03-03 (Fri, 03 Mar 2023)

  Changed paths:
M LayoutTests/inspector/model/font-styles-conversion.html
M Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js
M Source/WebInspectorUI/UserInterface/Models/FontStyles.js
M Source/WebInspectorUI/UserInterface/Views/DetailsSection.css
M Source/WebInspectorUI/UserInterface/Views/FontDetailsPanel.js
M 
Source/WebInspectorUI/UserInterface/Views/FontVariationDetailsSectionRow.css
M 
Source/WebInspectorUI/UserInterface/Views/FontVariationDetailsSectionRow.js
M Source/WebInspectorUI/UserInterface/Views/Variables.css

  Log Message:
  ---
  Web Inspector: Add precise editing controls for variation axes in Fonts 
sidebar panel
https://bugs.webkit.org/show_bug.cgi?id=253199

Reviewed by Patrick Angle.

Adds input fields to the Fonts siderbar panel to allow editing variation axis 
values.

HTML number input fields accept and display any character, so we restrict 
keyboard
input to just the ones that make up number values supported as axis values.

The warning for an invalid input is delayed while a user is typing to allow 
them to finish.

An input can accept and display and invalid value. It will be marked with a 
warning.
However, the value written to the stylesheet will be either:
- the default axis value when the input value is invalid;
- the clamped min/max value when the input value is out of bounds;

When focus is moved away from an invalid input,
it will update to reflect the actual value used.

Holding the ArrowUp/ArrowDown keys increments/decrements the value within
the bounds of the min/max range with the corresponding step for that axis.

Holding the Shift key will increase the step by an order of magnitude.
Holding the Alt/Option key will decrease the step by an order of magnitude.

* Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js:
* Source/WebInspectorUI/UserInterface/Models/FontStyles.js:
Ensure values written to CSS properties are strings.

(WI.FontStyles.axisValueToFontPropertyValue):
* Source/WebInspectorUI/UserInterface/Views/FontDetailsPanel.js:
(WI.FontDetailsPanel.prototype.update):
* Source/WebInspectorUI/UserInterface/Views/FontVariationDetailsSectionRow.css:
(.details-section > .content > .group > .row.font-variation > 
input[type="number"]):
(.details-section > .content > .group > .row.font-variation:has(.warning) > 
input[type="number"]):
(.details-section > .content > .group > .row.font-variation > 
input[type="number"]::-webkit-inner-spin-button):
(.details-section > .content > .group > .row.font-variation > .value): Deleted.
(.details-section > .content > .group > .row.font-variation:has(.warning) > 
.value): Deleted.
* Source/WebInspectorUI/UserInterface/Views/FontVariationDetailsSectionRow.js:
(WI.FontVariationDetailsSectionRow):
(WI.FontVariationDetailsSectionRow.prototype.set value):
(WI.FontVariationDetailsSectionRow.prototype._getAxisResolution):
(WI.FontVariationDetailsSectionRow.prototype._showValidity):
(WI.FontVariationDetailsSectionRow.prototype._handleValueBlurEvent):
(WI.FontVariationDetailsSectionRow.prototype._handleValueInputEvent):
(WI.FontVariationDetailsSectionRow.prototype._handleValueKeydownEvent):

Canonical link: https://commits.webkit.org/261162@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit]

[Russell Epstein]

  Branch: refs/tags/WebKit-7616.1.4.1
  Home:   https://github.com/WebKit/WebKit
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 293a3b: Versioning.

[Russell Epstein]

  Branch: refs/heads/safari-7616.1.3.2-branch
  Home:   https://github.com/WebKit/WebKit
  Commit: 293a3b0f0f63ba129c58423c54b2c74936524b9d
  
https://github.com/WebKit/WebKit/commit/293a3b0f0f63ba129c58423c54b2c74936524b9d
  Author: Russell Epstein 
  Date:   2023-03-03 (Fri, 03 Mar 2023)

  Changed paths:
M Configurations/Version.xcconfig

  Log Message:
  ---
  Versioning.

WebKit-7616.1.3.2.1

Canonical link: https://commits.webkit.org/260516.6@safari-7616.1.3.2-branch


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] fe519f: [Cocoa] Simplify ScalableImageDecoder fallback logic

[Myles C. Maxfield]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fe519f43f2e5efc579b388b72492b41088d43b97
  
https://github.com/WebKit/WebKit/commit/fe519f43f2e5efc579b388b72492b41088d43b97
  Author: Myles C. Maxfield 
  Date:   2023-03-03 (Fri, 03 Mar 2023)

  Changed paths:
M Source/WebCore/platform/graphics/ImageDecoder.cpp

  Log Message:
  ---
  [Cocoa] Simplify ScalableImageDecoder fallback logic
https://bugs.webkit.org/show_bug.cgi?id=253299
rdar://106184839

Reviewed by Simon Fraser.

ScalableImageDecoder isn't itself specific to any specific format; we can 
simplify
this code and just try using it unconditionally, since its only set up to 
support
AVIF internally.

* Source/WebCore/platform/graphics/ImageDecoder.cpp:
(WebCore::ImageDecoder::create):

Canonical link: https://commits.webkit.org/261161@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 7b7d1a: Cherry-pick 85232d38f6f4. rdar://problem/106112303

[Jer Noble]

  Branch: refs/heads/safari-7616.1.5-branch
  Home:   https://github.com/WebKit/WebKit
  Commit: 7b7d1ab1e3ce98773c083945b8329d0d17bc5688
  
https://github.com/WebKit/WebKit/commit/7b7d1ab1e3ce98773c083945b8329d0d17bc5688
  Author: Jer Noble 
  Date:   2023-03-03 (Fri, 03 Mar 2023)

  Changed paths:
M Source/WebKit/UIProcess/Cocoa/VideoFullscreenManagerProxy.mm

  Log Message:
  ---
  Cherry-pick 85232d38f6f4. rdar://problem/106112303

REGRESSION(260575@main): [iPad] Crash when navigating to next YouTube video 
in fullscreen mode
https://bugs.webkit.org/show_bug.cgi?id=253246
rdar://106112303

Reviewed by Tim Horton.

Remove the MESSAGE_CHECK protecting against videoLayerID being zero in 
setupFullscreenWithID(). Prior to the
no-double-hosting change, it was impossible to enter this function without 
a remote layer host having been
created in the WebContent process. After the no-double-hosting change, the 
remote layer host is created in
the GPU process, and may not have been created by the time 
setupFullscreenWithID() is called. Once the layer
_is_ created, the videoLayerID is sent to the UI process separately, and 
the created hosting layer is updated.

* Source/WebKit/UIProcess/Cocoa/VideoFullscreenManagerProxy.mm:
(WebKit::VideoFullscreenManagerProxy::setupFullscreenWithID):

Canonical link: https://commits.webkit.org/261104@main

Canonical link: https://commits.webkit.org/261058.1@safari-7616.1.5-branch


  Commit: 6434292f614546037714ff16f168ba9ad30d61ee
  
https://github.com/WebKit/WebKit/commit/6434292f614546037714ff16f168ba9ad30d61ee
  Author: Jer Noble 
  Date:   2023-03-03 (Fri, 03 Mar 2023)

  Changed paths:
M Source/WebCore/platform/cocoa/VideoFullscreenChangeObserver.h
M Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm
M Source/WebCore/platform/ios/WebVideoFullscreenControllerAVKit.mm
M Source/WebKit/UIProcess/Cocoa/VideoFullscreenManagerProxy.h
M Source/WebKit/UIProcess/Cocoa/VideoFullscreenManagerProxy.mm

  Log Message:
  ---
  Cherry-pick e64627c9a4d4. rdar://problem/105990736

REGRESSION(260774@main): [iPad] Video turns black after entering element 
fullscreen
https://bugs.webkit.org/show_bug.cgi?id=253225
rdar://105990736

Reviewed by Tim Horton.

Prior to "no-double-layer-hosting", the fullscreen machinery would create 
an AVPlayerLayerView and AVPlayerLayerViewController
simply to handle the case where the user might exit _element_ fullscreen 
when playing a video, and that video may need to
immediately enter picture-in-picture mode. As part of that process, the new 
AVPlayerLayerView would "steal" the video
content from an existing layer. This wasn't a problem in the double layer 
hosting world; there wasn't anything to steal then,
as the video layer being stolen was empty.

However, in the "no-double-layer-hosting" world, stealing the video layer 
results in no video being visible in the WKWebView,
as that video layer is the one inserted into the UI-side compositing tree. 
This code could benefit from a complete re-write,
now that there's a pre-existing AVPlayerLayerView in the web compositing 
hierarchy. For now, simply work around the problem
by not stealing the video layer prematurely, and by notifying the 
VideoFullscreenManagerProxy when PiP has ended and the
video layer can be returned to its rightful owner.

* Source/WebCore/platform/cocoa/VideoFullscreenChangeObserver.h:
* Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm:
(VideoFullscreenInterfaceAVKit::doSetup):
(VideoFullscreenInterfaceAVKit::returnToStandby):
* Source/WebCore/platform/ios/WebVideoFullscreenControllerAVKit.mm:
* Source/WebKit/UIProcess/Cocoa/VideoFullscreenManagerProxy.h:
* Source/WebKit/UIProcess/Cocoa/VideoFullscreenManagerProxy.mm:
(WebKit::VideoFullscreenModelContext::returnToStandby):
(WebKit::VideoFullscreenManagerProxy::returnToStandby):

Canonical link: https://commits.webkit.org/261143@main

Canonical link: https://commits.webkit.org/261058.2@safari-7616.1.5-branch


Compare: https://github.com/WebKit/WebKit/compare/1d89fdbdb2ba...6434292f6145
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit]

[Russell Epstein]

  Branch: refs/heads/safari-7616.1.3.2-branch
  Home:   https://github.com/WebKit/WebKit
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit]

[MyahCobbs]

  Branch: refs/heads/safari-7616.1.5-branch
  Home:   https://github.com/WebKit/WebKit
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] e3d89d: [web-animations] add a dedicated timeline object f...

[Antoine Quint]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e3d89dcbb53baaa501b9adbcf1ce470b2e176412
  
https://github.com/WebKit/WebKit/commit/e3d89dcbb53baaa501b9adbcf1ce470b2e176412
  Author: Antoine Quint 
  Date:   2023-03-03 (Fri, 03 Mar 2023)

  Changed paths:
M Source/WebCore/Headers.cmake
M Source/WebCore/Sources.txt
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
A Source/WebCore/animation/AcceleratedTimeline.cpp
A Source/WebCore/animation/AcceleratedTimeline.h
M Source/WebCore/animation/DocumentTimeline.cpp
M Source/WebCore/animation/KeyframeEffect.cpp
M Source/WebCore/animation/KeyframeEffect.h
M Source/WebCore/dom/Document.cpp
M Source/WebCore/dom/Document.h

  Log Message:
  ---
  [web-animations] add a dedicated timeline object for accelerated effects
https://bugs.webkit.org/show_bug.cgi?id=253312

Reviewed by Dean Jackson.

Add a new AcceleratedTimeline class on which elements targeted by effects 
animating
accelerated properties are registered. Then as the document's timeline is 
updated,
we go through these registered elements and update the accelerated effect stack 
for
them through their RenderLayerBacking.

* Source/WebCore/Headers.cmake:
* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/animation/AcceleratedTimeline.cpp: Added.
(WebCore::AcceleratedTimeline::AcceleratedTimeline):
(WebCore::AcceleratedTimeline::updateEffectStacks):
(WebCore::AcceleratedTimeline::updateEffectStackForTarget):
* Source/WebCore/animation/AcceleratedTimeline.h: Added.
(WebCore::AcceleratedTimeline::timeOrigin const):
* Source/WebCore/animation/DocumentTimeline.cpp:
(WebCore::DocumentTimeline::applyPendingAcceleratedAnimations):
* Source/WebCore/animation/KeyframeEffect.cpp:
(WebCore::KeyframeEffect::updateAssociatedThreadedEffectStack):
* Source/WebCore/animation/KeyframeEffect.h:
* Source/WebCore/dom/Document.cpp:
(WebCore::Document::acceleratedTimeline):
* Source/WebCore/dom/Document.h:
(WebCore::Document::existingAcceleratedTimeline const):

Canonical link: https://commits.webkit.org/261160@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 2ab27d: AX: Enable XCTests to run in isolated tree mode.

[AndresGonzalezApple]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2ab27dd5700e3aee5fd3be11fbbedf24c6cedcdb
  
https://github.com/WebKit/WebKit/commit/2ab27dd5700e3aee5fd3be11fbbedf24c6cedcdb
  Author: Andres Gonzalez 
  Date:   2023-03-03 (Fri, 03 Mar 2023)

  Changed paths:
M Source/WebCore/accessibility/mac/AXObjectCacheMac.mm

  Log Message:
  ---
  AX: Enable XCTests to run in isolated tree mode.
https://bugs.webkit.org/show_bug.cgi?id=253287


Reviewed by Chris Fleizach.

* Source/WebCore/accessibility/mac/AXObjectCacheMac.mm:
(WebCore::AXObjectCache::clientSupportsIsolatedTree):
Include the case kAXClientTypeXCTest.

Canonical link: https://commits.webkit.org/261159@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 3f9d3c: [web-animations] GraphicsLayerCA::isRunningTransfo...

[Antoine Quint]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3f9d3ca5903baa289c1ff58556ab49f4a404a672
  
https://github.com/WebKit/WebKit/commit/3f9d3ca5903baa289c1ff58556ab49f4a404a672
  Author: Antoine Quint 
  Date:   2023-03-03 (Fri, 03 Mar 2023)

  Changed paths:
M Source/WebCore/platform/animation/AcceleratedEffect.cpp
M Source/WebCore/platform/animation/AcceleratedEffect.h
M Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp

  Log Message:
  ---
  [web-animations] GraphicsLayerCA::isRunningTransformAnimation() needs to 
account for threaded animation resolution
https://bugs.webkit.org/show_bug.cgi?id=253318

Reviewed by Dean Jackson.

Use the accelerated effect stack to determine whether an accelerated effect for 
a graphics layer currently
target a transform-related property.

* Source/WebCore/platform/animation/AcceleratedEffect.cpp:
(WebCore::AcceleratedEffect::animatesTransformRelatedProperty const):
* Source/WebCore/platform/animation/AcceleratedEffect.h:
* Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::isRunningTransformAnimation const):

Canonical link: https://commits.webkit.org/261158@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 2bbba9: [web-animations] internals.acceleratedAnimationsFo...

[Antoine Quint]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2bbba9995b58e61342a156b5af657eeabd99a585
  
https://github.com/WebKit/WebKit/commit/2bbba9995b58e61342a156b5af657eeabd99a585
  Author: Antoine Quint 
  Date:   2023-03-03 (Fri, 03 Mar 2023)

  Changed paths:
M Source/WebCore/animation/DocumentTimeline.cpp
M Source/WebCore/platform/graphics/GraphicsLayer.h
M Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp
M Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h

  Log Message:
  ---
  [web-animations] internals.acceleratedAnimationsForElement() should account 
for threaded animation resolution
https://bugs.webkit.org/show_bug.cgi?id=253317

Reviewed by Dean Jackson.

Use the AcceleratedEffectStack to access animations for a GraphicsLayer to 
report up to internals.acceleratedAnimationsForElement().

* Source/WebCore/animation/DocumentTimeline.cpp:
(WebCore::DocumentTimeline::acceleratedAnimationsForElement const):
* Source/WebCore/platform/graphics/GraphicsLayer.h:
(WebCore::GraphicsLayer::acceleratedAnimationsForTesting const):
* Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:
* Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h:

Canonical link: https://commits.webkit.org/261157@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 8e0278: REGRESSION (260675@main): [ macOS, iOS ] 2 x fast/...

[Ryan Haddad]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8e0278908e4aee6e905b80fcf19d231f32d1a685
  
https://github.com/WebKit/WebKit/commit/8e0278908e4aee6e905b80fcf19d231f32d1a685
  Author: Ryan Haddad 
  Date:   2023-03-03 (Fri, 03 Mar 2023)

  Changed paths:
M LayoutTests/platform/ios-wk2/TestExpectations
M LayoutTests/platform/mac-wk2/TestExpectations

  Log Message:
  ---
  REGRESSION (260675@main): [ macOS, iOS ] 2 x fast/text/glyph-display-list 
tests are a constant failure.
https://bugs.webkit.org/show_bug.cgi?id=252866
rdar://105854585

Unreviewed test gardening.

* LayoutTests/platform/ios-wk2/TestExpectations: Mark tests as flaky.
* LayoutTests/platform/mac-wk2/TestExpectations: Ditto.

Canonical link: https://commits.webkit.org/261156@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 044436: Re-import html/semantics/popovers WPT

[Tim Nguyen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 04443688436be33ec89237497b200153bc0f1b4b
  
https://github.com/WebKit/WebKit/commit/04443688436be33ec89237497b200153bc0f1b4b
  Author: Tim Nguyen 
  Date:   2023-03-03 (Fri, 03 Mar 2023)

  Changed paths:
M 
LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-anchor-idl-property.html
M 
LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-anchor-nested-display.html
M 
LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-attribute-basic-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-attribute-basic.html
M 
LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-backdrop-appearance.html
M 
LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-focus-2-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-focus-2.html
M 
LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-focus.html
M 
LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-invoking-attribute-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-invoking-attribute.html
M 
LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-light-dismiss-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-light-dismiss.html
M 
LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-shadow-dom.html
M 
LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-stacking-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-stacking.html
M 
LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-target-element-disabled.html
M 
LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-top-layer-combinations.html
M 
LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/resources/popover-utils.js
M 
LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/w3c-import.log
M 
LayoutTests/platform/gtk/imported/w3c/web-platform-tests/html/semantics/popovers/popover-focus-2-expected.txt
M 
LayoutTests/platform/gtk/imported/w3c/web-platform-tests/html/semantics/popovers/popover-light-dismiss-expected.txt
M 
LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/popovers/popover-attribute-basic-expected.txt
M 
LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/popovers/popover-focus-2-expected.txt
M 
LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/popovers/popover-light-dismiss-expected.txt

  Log Message:
  ---
  Re-import html/semantics/popovers WPT
https://bugs.webkit.org/show_bug.cgi?id=253271
rdar://106167662

Reviewed by Aditya Keerthi.

Upstream commit: 
https://github.com/web-platform-tests/wpt/commit/0e15e4513cc00bf0874af8c66078aace4db604e4

* 
LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-anchor-idl-property.html:
* 
LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-anchor-nested-display.html:
* 
LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-attribute-basic-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-attribute-basic.html:
* 
LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-backdrop-appearance.html:
* 
LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-focus-2-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-focus-2.html:
* 
LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-focus.html:
* 
LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-invoking-attribute-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-invoking-attribute.html:
* 
LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-light-dismiss-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-light-dismiss.html:
* 
LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-shadow-dom.html:
* 
LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-stacking-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-stacking.html:
* 
LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-target-element-disabled.html:
* 
LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-top-layer-combinations.html:
* 
LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/resources/popover-uti

[webkit-changes] [WebKit/WebKit] eb7c42: Parse list-style-type custom-ident if counter-styl...

[Vitor Roriz]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: eb7c428cb8ebaaf0a6f48a1be8128abec5f5f741
  
https://github.com/WebKit/WebKit/commit/eb7c428cb8ebaaf0a6f48a1be8128abec5f5f741
  Author: Vitor Roriz 
  Date:   2023-03-03 (Fri, 03 Mar 2023)

  Changed paths:
M Source/WebCore/css/CSSProperties.json
M Source/WebCore/css/parser/CSSParserContext.cpp
M Source/WebCore/css/parser/CSSParserContext.h
M Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp
M Source/WebCore/css/parser/CSSPropertyParserHelpers.h
M Source/WebCore/style/StyleBuilderCustom.h

  Log Message:
  ---
  Parse list-style-type custom-ident if counter-style is enabled
https://bugs.webkit.org/show_bug.cgi?id=253291
rdar://problem/106175917

Reviewed by Tim Nguyen.

list-style-type should accept custom-ident
values only if counter-styles-at-rule is enabled.

* Source/WebCore/css/CSSProperties.json:
* Source/WebCore/css/parser/CSSParserContext.cpp:
(WebCore::operator==):
* Source/WebCore/css/parser/CSSParserContext.h:
* Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp:
(WebCore::CSSPropertyParserHelpers::consumeListStyleType):
* Source/WebCore/css/parser/CSSPropertyParserHelpers.h:
* Source/WebCore/style/StyleBuilderCustom.h:
(WebCore::Style::BuilderCustom::applyValueListStyleType):

Canonical link: https://commits.webkit.org/261154@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] e3f0b0: Enable single-pass BBQ baseline JIT by default

[EWS]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e3f0b033dcf4ed2f7b03c7c359acf4ab11a4c08c
  
https://github.com/WebKit/WebKit/commit/e3f0b033dcf4ed2f7b03c7c359acf4ab11a4c08c
  Author: David Degazio 
  Date:   2023-03-03 (Fri, 03 Mar 2023)

  Changed paths:
M Source/JavaScriptCore/runtime/Options.cpp
M Source/JavaScriptCore/runtime/OptionsList.h
M Tools/Scripts/run-jsc-stress-tests

  Log Message:
  ---
  Enable single-pass BBQ baseline JIT by default
https://bugs.webkit.org/show_bug.cgi?id=252209
rdar://100332177

Reviewed by Mark Lam and Yusuke Suzuki.

The new BBQ baseline JIT is largely complete, passes all of our stress tests,
and doesn't introduce a performance regression. This patch moves to enable it
as our default implementation for the BBQ tier, supplanting the Air backend.

One notable hole in the new JIT's support is in some of the recent WASM 
extensions:
typed function references, tail calls, and GC. Since these are still incomplete
currently, and disabled by default, single-pass BBQ doesn't yet support them.
When these features are manually enabled, single-pass BBQ JIT will be disabled
currently, and defer back to Air. Air and B3 can also be selected by passing
`--useSinglePassBBQJIT=0` in the command line options.

* Source/JavaScriptCore/runtime/Options.cpp:
(JSC::Options::notifyOptionsChanged):
* Source/JavaScriptCore/runtime/OptionsList.h:
* Tools/Scripts/run-jsc-stress-tests:

Canonical link: https://commits.webkit.org/261153@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 087a80: Code outside of ScrollingTree should not access sc...

[Simon Fraser]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 087a80ea89a521c156f820554f1298dfcb94c2aa
  
https://github.com/WebKit/WebKit/commit/087a80ea89a521c156f820554f1298dfcb94c2aa
  Author: Simon Fraser 
  Date:   2023-03-03 (Fri, 03 Mar 2023)

  Changed paths:
M Source/WebCore/page/scrolling/ScrollingTree.cpp
M Source/WebCore/page/scrolling/ScrollingTree.h
M Source/WebCore/page/scrolling/ThreadedScrollingTree.cpp
M Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm
M 
Source/WebKit/UIProcess/RemoteLayerTree/RemoteScrollingCoordinatorProxy.cpp
M Source/WebKit/UIProcess/RemoteLayerTree/RemoteScrollingCoordinatorProxy.h
M Source/WebKit/UIProcess/RemoteLayerTree/RemoteScrollingTree.cpp
M 
Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteScrollingCoordinatorProxyIOS.mm
M 
Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteLayerTreeDrawingAreaProxyMac.mm
M 
Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteScrollingCoordinatorProxyMac.h
M 
Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteScrollingCoordinatorProxyMac.mm

  Log Message:
  ---
  Code outside of ScrollingTree should not access scrolling tree nodes directly
https://bugs.webkit.org/show_bug.cgi?id=253276
rdar://106168232

Reviewed by Tim Horton.

Access to the scrolling tree should be protected by locking, since on macOS with
both web-side and UI-side compositing, scrolling happens off the main thread.

So remove RemoteScrollingCoordinatorProxy::rootNode() and move the functionality
down into ScrollingTree, where we can lock.

ScrollingTree already had a field for `mainFrameScrollPosition`, protected by
a lock, so fix all ScrollingTree subclasses to correctly set that, and use it
from RemoteScrollingCoordinatorProxyMac::currentMainFrameScrollPosition().
This has "current" in the name to indicate that it's the live scroll position 
which
is changed by the scrolling thread.

* Source/WebCore/page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::scrollingTreeNodeDidScroll):
(WebCore::ScrollingTree::mainFrameScrollPosition const):
(WebCore::ScrollingTree::mainFrameHorizontalOverscrollBehavior const):
(WebCore::ScrollingTree::mainFrameVerticalOverscrollBehavior const):
* Source/WebCore/page/scrolling/ScrollingTree.h:
* Source/WebCore/page/scrolling/ThreadedScrollingTree.cpp:
(WebCore::ThreadedScrollingTree::scrollingTreeNodeDidScroll):
* Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm:
(-[WKWebView _updateScrollViewForTransaction:]):
* Source/WebKit/UIProcess/RemoteLayerTree/RemoteScrollingCoordinatorProxy.cpp:
(WebKit::RemoteScrollingCoordinatorProxy::rootScrollingNodeID const):
(WebKit::RemoteScrollingCoordinatorProxy::hasScrollableMainFrame const):
(WebKit::RemoteScrollingCoordinatorProxy::mainFrameHorizontalOverscrollBehavior 
const):
(WebKit::RemoteScrollingCoordinatorProxy::mainFrameVerticalOverscrollBehavior 
const):
(WebKit::RemoteScrollingCoordinatorProxy::hasScrollableOrZoomedMainFrame const):
(WebKit::RemoteScrollingCoordinatorProxy::rootNode const): Deleted.
* Source/WebKit/UIProcess/RemoteLayerTree/RemoteScrollingCoordinatorProxy.h:
* Source/WebKit/UIProcess/RemoteLayerTree/RemoteScrollingTree.cpp:
(WebKit::RemoteScrollingTree::scrollingTreeNodeDidScroll):
* 
Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteScrollingCoordinatorProxyIOS.mm:
(WebKit::RemoteScrollingCoordinatorProxyIOS::setRootNodeIsInUserScroll):
* 
Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteLayerTreeDrawingAreaProxyMac.mm:
(WebKit::RemoteLayerTreeDrawingAreaProxyMac::adjustTransientZoom):
* 
Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteScrollingCoordinatorProxyMac.h:
* 
Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteScrollingCoordinatorProxyMac.mm:
(WebKit::RemoteScrollingCoordinatorProxyMac::currentMainFrameScrollPosition 
const):

Canonical link: https://commits.webkit.org/261152@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 817276: [macOS] Show correction panel for grammar errors

[Aditya Keerthi]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 81727684efeb8846fc178d34aa3479307b2ab8ee
  
https://github.com/WebKit/WebKit/commit/81727684efeb8846fc178d34aa3479307b2ab8ee
  Author: Aditya Keerthi 
  Date:   2023-03-03 (Fri, 03 Mar 2023)

  Changed paths:
M Source/WebCore/editing/AlternativeTextController.cpp
M Source/WebCore/page/AlternativeTextClient.h
M Source/WebKit/UIProcess/mac/CorrectionPanel.mm
M Source/WebKit/WebProcess/WebCoreSupport/WebEditorClient.cpp
M Source/WebKitLegacy/mac/WebCoreSupport/CorrectionPanel.mm

  Log Message:
  ---
  [macOS] Show correction panel for grammar errors
https://bugs.webkit.org/show_bug.cgi?id=253294
rdar://105738781

Reviewed by Wenson Hsieh.

Native text views on macOS display a correction panel when grammar checking is
enabled and the cursor is at the end of a grammar error, or when at the end of
a misspelled word.

Currently, WebKit only implements this behavior for misspelled words. This
patch adds support for showing a correction panel for grammar errors, matching
AppKit behavior.

* Source/WebCore/editing/AlternativeTextController.cpp:
(WebCore::AlternativeTextController::timerFired):

Obtain suggestions for an ungrammatical phrase.

(WebCore::AlternativeTextController::handleAlternativeTextUIResult):

Insert accepted suggestions the same way as spelling suggestions.

(WebCore::AlternativeTextController::shouldStartTimerFor const):

Add grammar markers to the allowlist of markers that can display alternative 
text.

Improve the readability of the method by using a switch statement.

(WebCore::AlternativeTextController::respondToMarkerAtEndOfWord):

Start the timer to get grammar suggestions for the current word.

* Source/WebCore/page/AlternativeTextClient.h:
* Source/WebKit/UIProcess/mac/CorrectionPanel.mm:
(correctionIndicatorType):

The correction panel for grammar suggestions should appear the same as the
panel for spelling suggestions.

* Source/WebKit/WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::shouldEraseMarkersAfterChangeSelection const):

Prevent grammar markers from being removed on selection changes, matching
native behavior.

* Source/WebKitLegacy/mac/WebCoreSupport/CorrectionPanel.mm:
(correctionIndicatorType):

The correction panel for grammar suggestions should appear the same as the
panel for spelling suggestions.

Canonical link: https://commits.webkit.org/261151@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 70e57c: Cherry-pick 41855a914387. rdar://problem/103458234

[Dean Jackson]

  Branch: refs/heads/safari-7616.1.4-branch
  Home:   https://github.com/WebKit/WebKit
  Commit: 70e57c28227fb6852e23f860c6d6df72a485c952
  
https://github.com/WebKit/WebKit/commit/70e57c28227fb6852e23f860c6d6df72a485c952
  Author: Dean Jackson 
  Date:   2023-03-03 (Fri, 03 Mar 2023)

  Changed paths:
M 
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm
M 
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm
M Source/WebCore/platform/graphics/cocoa/MediaPlayerPrivateWebM.mm

  Log Message:
  ---
  Cherry-pick 41855a914387. rdar://problem/103458234

Opt out of playback preventing app backgrounding for silent videos
https://bugs.webkit.org/show_bug.cgi?id=253163
rdar://103458234

Reviewed by Jer Noble and Eric Carlson.

AVFoundation has exposed new API on AVPlayer and AVSampleBufferDisplayLayer
to avoid silent media playback from keeping the app moving to the 
background.

Test for the property, then set it to NO.

* 
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer):
* 
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::ensureLayer):
* Source/WebCore/platform/graphics/cocoa/MediaPlayerPrivateWebM.mm:
(WebCore::MediaPlayerPrivateWebM::ensureLayer):

Canonical link: https://commits.webkit.org/261128@main

Canonical link: https://commits.webkit.org/260848.7@safari-7616.1.4-branch


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 28f733: [PlayStation] Build fix for non-experimental featu...

[Stephan Szabo]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 28f733a50d4fb00641cd2386501a99d9cf9e5ce6
  
https://github.com/WebKit/WebKit/commit/28f733a50d4fb00641cd2386501a99d9cf9e5ce6
  Author: Stephan Szabo 
  Date:   2023-03-03 (Fri, 03 Mar 2023)

  Changed paths:
M Source/WebKit/NetworkProcess/EarlyHintsResourceLoader.h

  Log Message:
  ---
  [PlayStation] Build fix for non-experimental features build after 261079@main
https://bugs.webkit.org/show_bug.cgi?id=253282

Unreviewed build fix

Add WebCore:: namespace to ResourceRequest parameter as this seems
to be necessary for us when we're not building experimental features.
Return value for the function already used the namespace.

* Source/WebKit/NetworkProcess/EarlyHintsResourceLoader.h:

Canonical link: https://commits.webkit.org/261150@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] f98080: Versioning.

[Russell Epstein]

  Branch: refs/heads/safari-7616.1.4-branch
  Home:   https://github.com/WebKit/WebKit
  Commit: f9808047a47c1bb0d5ee5c5ef71330203ab93ecf
  
https://github.com/WebKit/WebKit/commit/f9808047a47c1bb0d5ee5c5ef71330203ab93ecf
  Author: Russell Epstein 
  Date:   2023-03-03 (Fri, 03 Mar 2023)

  Changed paths:
M Configurations/Version.xcconfig

  Log Message:
  ---
  Versioning.

WebKit-7616.1.4.1

Canonical link: https://commits.webkit.org/260848.6@safari-7616.1.4-branch


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 9180e6: REGRESSION(260512@main): HDR images should be draw...

[Said Abou-Hallawa]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9180e60fc30a62f676cedb224f881ff24ef8f682
  
https://github.com/WebKit/WebKit/commit/9180e60fc30a62f676cedb224f881ff24ef8f682
  Author: Said Abou-Hallawa 
  Date:   2023-03-03 (Fri, 03 Mar 2023)

  Changed paths:
M Source/WebCore/platform/graphics/GraphicsContext.h
M Source/WebCore/platform/graphics/ImageBuffer.cpp
M Source/WebCore/platform/graphics/cg/NativeImageCG.cpp

  Log Message:
  ---
  REGRESSION(260512@main): HDR images should be drawn directly if the 
destination context has HDR color space
https://bugs.webkit.org/show_bug.cgi?id=253275
rdar://106055782

Reviewed by Simon Fraser.

CoreGraphics should draw the HDR images directly to the destination context if
it has HDR color space.

ImageBuffer::draw() should call GraphicsContext::drawNativeImageInternal() to
prevent the possible recursion from NativeImage::draw() to ImageBuffer::draw().

* Source/WebCore/platform/graphics/GraphicsContext.h:
* Source/WebCore/platform/graphics/ImageBuffer.cpp:
(WebCore::ImageBuffer::draw):
(WebCore::ImageBuffer::drawConsuming):
* Source/WebCore/platform/graphics/cg/NativeImageCG.cpp:
(WebCore::NativeImage::draw):

Canonical link: https://commits.webkit.org/261149@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 81bc2a: RenderElement::updateOutlineAutoAncestor should de...

[Chirag Shah]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 81bc2a0b0fb755976082c1ae57a0667cb9c4e2be
  
https://github.com/WebKit/WebKit/commit/81bc2a0b0fb755976082c1ae57a0667cb9c4e2be
  Author: Chirag M Shah 
  Date:   2023-03-03 (Fri, 03 Mar 2023)

  Changed paths:
A 
LayoutTests/fast/rendering/outline-auto-for-moved-out-element-crash-expected.txt
A LayoutTests/fast/rendering/outline-auto-for-moved-out-element-crash.html
M Source/WebCore/rendering/RenderElement.cpp

  Log Message:
  ---
  RenderElement::updateOutlineAutoAncestor should deal with moved out renderers
https://bugs.webkit.org/show_bug.cgi?id=253270
rdar://105873104

Reviewed by Alan Baradlay.

Before this change, when RenderElement::updateOutlineAutoAncestor was
called on RenderMultiColumnSpannerPlaceholder, we never looked at the
children of the moved out element. This means that we would have an
invalid outline auto set in the hierarchy of the moved out element,
which can cause stack overflow. This change fixes it by making it so
that we recurse through children of the moved out element to set the
right state when dealing with RenderMultiColumnSpannerPlaceholder.

* 
LayoutTests/fast/rendering/outline-auto-for-moved-out-element-crash-expected.txt:
 Added.
* LayoutTests/fast/rendering/outline-auto-for-moved-out-element-crash.html: 
Added.
* Source/WebCore/rendering/RenderElement.cpp:
(WebCore::RenderElement::updateOutlineAutoAncestor):

Canonical link: https://commits.webkit.org/261148@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 5c2607: Add assertions in CacheStorageCache to help debug ...

[Sihui]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5c2607837be66195328f71725114deca9306f2dc
  
https://github.com/WebKit/WebKit/commit/5c2607837be66195328f71725114deca9306f2dc
  Author: Sihui Liu 
  Date:   2023-03-03 (Fri, 03 Mar 2023)

  Changed paths:
M Source/WebKit/NetworkProcess/storage/CacheStorageCache.cpp
M Source/WebKit/NetworkProcess/storage/CacheStorageCache.h

  Log Message:
  ---
  Add assertions in CacheStorageCache to help debug threading issues
https://bugs.webkit.org/show_bug.cgi?id=253223
rdar://106124999

Reviewed by Chris Dumez.

rdar://105122133 indicates CacheStorageCache may have threading issues (e.g. 
record url may become AtomString at some
point), so adding some assertion to help debug that.

This patch also make an isolated copy for record url before passing it to 
CacheStorageCache.

* Source/WebKit/NetworkProcess/storage/CacheStorageCache.cpp:
(WebKit::computeKeyURL):
(WebKit::CacheStorageCache::CacheStorageCache):
(WebKit::CacheStorageCache::getSize):
(WebKit::CacheStorageCache::open):
(WebKit::CacheStorageCache::retrieveRecords):
(WebKit::CacheStorageCache::removeRecords):
(WebKit::CacheStorageCache::findExistingRecord):
(WebKit::CacheStorageCache::putRecords):
(WebKit::CacheStorageCache::putRecordsAfterQuotaCheck):
(WebKit::CacheStorageCache::putRecordsInStore):
(WebKit::CacheStorageCache::removeAllRecords):
(WebKit::CacheStorageCache::close):
* Source/WebKit/NetworkProcess/storage/CacheStorageCache.h:
(WebKit::CacheStorageCache::assertIsOnCorrectQueue):

Canonical link: https://commits.webkit.org/261147@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] ee5e4b: Drop dead code from WebCoreOpaqueRoot

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ee5e4b4b0053a29f4611a284dee7a116214aa643
  
https://github.com/WebKit/WebKit/commit/ee5e4b4b0053a29f4611a284dee7a116214aa643
  Author: Chris Dumez 
  Date:   2023-03-03 (Fri, 03 Mar 2023)

  Changed paths:
M Source/WebCore/bindings/js/WebCoreOpaqueRoot.h

  Log Message:
  ---
  Drop dead code from WebCoreOpaqueRoot
https://bugs.webkit.org/show_bug.cgi?id=253256

Reviewed by Darin Adler.

* Source/WebCore/bindings/js/WebCoreOpaqueRoot.h:
(WebCore::WebCoreOpaqueRoot::WebCoreOpaqueRoot):
(WebCore::WebCoreOpaqueRoot::isNode const): Deleted.

Canonical link: https://commits.webkit.org/261146@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 34d9c5: Use tighter typing for value returned by JSDOMWind...

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 34d9c5fdefdbb4671c538e915a09dda0fc9205aa
  
https://github.com/WebKit/WebKit/commit/34d9c5fdefdbb4671c538e915a09dda0fc9205aa
  Author: Chris Dumez 
  Date:   2023-03-03 (Fri, 03 Mar 2023)

  Changed paths:
M Source/WebCore/bindings/js/JSDOMWindowBase.cpp
M Source/WebCore/bindings/js/JSDOMWindowBase.h

  Log Message:
  ---
  Use tighter typing for value returned by 
JSDOMWindowBase::scriptExecutionContext()
https://bugs.webkit.org/show_bug.cgi?id=253296

Reviewed by Sihui Liu.

* Source/WebCore/bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::scriptExecutionContext const):
* Source/WebCore/bindings/js/JSDOMWindowBase.h:

Canonical link: https://commits.webkit.org/261145@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 781b0d: [Cocoa|MSE] Playback of protected audio tracks stalls

[Jer Noble]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 781b0d137b97d8f5abaabfa191b9e97eeaf1d399
  
https://github.com/WebKit/WebKit/commit/781b0d137b97d8f5abaabfa191b9e97eeaf1d399
  Author: Jer Noble 
  Date:   2023-03-03 (Fri, 03 Mar 2023)

  Changed paths:
A 
LayoutTests/http/tests/media/fairplay/fps-mse-unmuxed-audio-only-expected.txt
A LayoutTests/http/tests/media/fairplay/fps-mse-unmuxed-audio-only.html
M 
Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm

  Log Message:
  ---
  [Cocoa|MSE] Playback of protected audio tracks stalls
https://bugs.webkit.org/show_bug.cgi?id=253281
rdar://104882715

Reviewed by Eric Carlson.

In 256805@main, a check was added to ensure we did not try to enqueue protected 
samples
if a decompression session existed. However, that did not account for a 
SampleBuffer with
only a protected audio track. Modify the check to test for the existence of a 
displayLayer
only if the track in question is the enabled video track.

* 
LayoutTests/http/tests/media/fairplay/fps-mse-unmuxed-audio-only-expected.txt: 
Added.
* LayoutTests/http/tests/media/fairplay/fps-mse-unmuxed-audio-only.html: Added.
* 
Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:
(WebCore::SourceBufferPrivateAVFObjC::canEnqueueSample):

Canonical link: https://commits.webkit.org/261144@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] e64627: REGRESSION(260774@main): [iPad] Video turns black ...

[Jer Noble]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e64627c9a4d48063a2c59af1f39fdb0195fc83cf
  
https://github.com/WebKit/WebKit/commit/e64627c9a4d48063a2c59af1f39fdb0195fc83cf
  Author: Jer Noble 
  Date:   2023-03-03 (Fri, 03 Mar 2023)

  Changed paths:
M Source/WebCore/platform/cocoa/VideoFullscreenChangeObserver.h
M Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm
M Source/WebCore/platform/ios/WebVideoFullscreenControllerAVKit.mm
M Source/WebKit/UIProcess/Cocoa/VideoFullscreenManagerProxy.h
M Source/WebKit/UIProcess/Cocoa/VideoFullscreenManagerProxy.mm

  Log Message:
  ---
  REGRESSION(260774@main): [iPad] Video turns black after entering element 
fullscreen
https://bugs.webkit.org/show_bug.cgi?id=253225
rdar://105990736

Reviewed by Tim Horton.

Prior to "no-double-layer-hosting", the fullscreen machinery would create an 
AVPlayerLayerView and AVPlayerLayerViewController
simply to handle the case where the user might exit _element_ fullscreen when 
playing a video, and that video may need to
immediately enter picture-in-picture mode. As part of that process, the new 
AVPlayerLayerView would "steal" the video
content from an existing layer. This wasn't a problem in the double layer 
hosting world; there wasn't anything to steal then,
as the video layer being stolen was empty.

However, in the "no-double-layer-hosting" world, stealing the video layer 
results in no video being visible in the WKWebView,
as that video layer is the one inserted into the UI-side compositing tree. This 
code could benefit from a complete re-write,
now that there's a pre-existing AVPlayerLayerView in the web compositing 
hierarchy. For now, simply work around the problem
by not stealing the video layer prematurely, and by notifying the 
VideoFullscreenManagerProxy when PiP has ended and the
video layer can be returned to its rightful owner.

* Source/WebCore/platform/cocoa/VideoFullscreenChangeObserver.h:
* Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm:
(VideoFullscreenInterfaceAVKit::doSetup):
(VideoFullscreenInterfaceAVKit::returnToStandby):
* Source/WebCore/platform/ios/WebVideoFullscreenControllerAVKit.mm:
* Source/WebKit/UIProcess/Cocoa/VideoFullscreenManagerProxy.h:
* Source/WebKit/UIProcess/Cocoa/VideoFullscreenManagerProxy.mm:
(WebKit::VideoFullscreenModelContext::returnToStandby):
(WebKit::VideoFullscreenManagerProxy::returnToStandby):

Canonical link: https://commits.webkit.org/261143@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 6dd3a7: REGRESSION(255420@main) Embed-loading PDFs from ne...

[Alex Christensen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6dd3a73e5aa2eae8951508f3b66d2014078a65aa
  
https://github.com/WebKit/WebKit/commit/6dd3a73e5aa2eae8951508f3b66d2014078a65aa
  Author: Alex Christensen 
  Date:   2023-03-03 (Fri, 03 Mar 2023)

  Changed paths:
M Source/WebKit/NetworkProcess/NetworkProcess.cpp
M Tools/TestWebKitAPI/Tests/WebKitCocoa/CookiePrivateBrowsing.mm

  Log Message:
  ---
  REGRESSION(255420@main) Embed-loading PDFs from newly opened about:blank 
terminates web process
https://bugs.webkit.org/show_bug.cgi?id=253285
rdar://105201326

Reviewed by J Pascoe.

In 255420@main I introduced checks in the network process to make sure that 
firstPartyForCookies
is an allowed domain for that process.  There are a few places in WebKit where 
we still have
about:blank or a null firstPartyForCookies, which is fine most of the time 
because
ResourceRequest::allowCookies is false so it doesn't matter that there's no 
firstPartyForCookies.
Sometimes, though, we have a piece of code that loads without a 
firstPartyForCookies and allows
cookies.  This is an existing bug and should probably be fixed, but it is not 
catastrophic
because the result is that no cookie access is given.  However, with 
255420@main it became catastrophic
because we terminate the web content process, which I'm told is undesirable 
when a user is trying to do
something like download a PDF.  This change makes it no longer terminate the 
web content process.

* Source/WebKit/NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::allowsFirstPartyForCookies):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/CookiePrivateBrowsing.mm:
(TEST):

Canonical link: https://commits.webkit.org/261142@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] eb5cfc: Regression(256456@main) Express checkout is broken...

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: eb5cfc8617372e96220cc6d3f5c57b11310eeef4
  
https://github.com/WebKit/WebKit/commit/eb5cfc8617372e96220cc6d3f5c57b11310eeef4
  Author: Chris Dumez 
  Date:   2023-03-03 (Fri, 03 Mar 2023)

  Changed paths:
M Source/WebCore/Modules/websockets/ThreadableWebSocketChannel.cpp
M Source/WebCore/loader/cache/CachedResourceLoader.cpp
M Source/WebCore/page/Quirks.cpp
M Source/WebCore/page/Quirks.h

  Log Message:
  ---
  Regression(256456@main) Express checkout is broken on victoriassecret.com
https://bugs.webkit.org/show_bug.cgi?id=253265
rdar://104818312

Reviewed by Brent Fulgham and Youenn Fablet.

Temporarily disable the Fetch Metadata feature on victoriassecret.com since it
breaks express checkout and while we're investigate the root cause.

* Source/WebCore/Modules/websockets/ThreadableWebSocketChannel.cpp:
(WebCore::ThreadableWebSocketChannel::webSocketConnectRequest):
* Source/WebCore/loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::updateRequestAfterRedirection):
(WebCore::CachedResourceLoader::updateHTTPRequestHeaders):
* Source/WebCore/page/Quirks.cpp:
(WebCore::Quirks::shouldDisableFetchMetadata const):
* Source/WebCore/page/Quirks.h:

Canonical link: https://commits.webkit.org/261141@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 1b2f16: AX: Cache the AttributedString for objects of role...

[AndresGonzalezApple]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1b2f162302f93e680fac7585ff79f1f22560cfda
  
https://github.com/WebKit/WebKit/commit/1b2f162302f93e680fac7585ff79f1f22560cfda
  Author: Andres Gonzalez 
  Date:   2023-03-03 (Fri, 03 Mar 2023)

  Changed paths:
M Source/WebCore/accessibility/AccessibilityNodeObject.cpp
M Source/WebCore/accessibility/AccessibilityRenderObject.cpp
M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h
M Source/WebCore/accessibility/isolatedtree/mac/AXIsolatedObjectMac.mm

  Log Message:
  ---
  AX: Cache the AttributedString for objects of role Tab and WebCoreLink in 
AXIsolatedObjects.
https://bugs.webkit.org/show_bug.cgi?id=253247


Reviewed by Tyler Wilcock and Chris Fleizach.

In some web pages AttributedStrings are requested for ranges in objects with 
role Tab and WebCoreLink quite often. In this patch we cache the 
AttributedString for these objects considerably reducing the hit s to the main 
thread. Some code cleanup.

* Source/WebCore/accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::canHaveChildren const):
(WebCore::AccessibilityNodeObject::title const):
(WebCore::AccessibilityNodeObject::stringValue const):
* Source/WebCore/accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::stringValue const):
* Source/WebCore/accessibility/cocoa/AccessibilityObjectCocoa.mm:
(WebCore::AccessibilityObject::attributedStringForTextMarkerRange const):
* Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h:
* Source/WebCore/accessibility/isolatedtree/mac/AXIsolatedObjectMac.mm:
(WebCore::AXIsolatedObject::initializePlatformProperties):
(WebCore::AXIsolatedObject::attributedStringForTextMarkerRange const):
(WebCore::AXIsolatedObject::shouldCacheAttributedText const):

Canonical link: https://commits.webkit.org/261140@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] a28ad5: AX: Remove unnecessary caching of title() and acce...

[AndresGonzalezApple]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a28ad53763a51538acaf0e2e28f8eaa7d239ef52
  
https://github.com/WebKit/WebKit/commit/a28ad53763a51538acaf0e2e28f8eaa7d239ef52
  Author: Andres Gonzalez 
  Date:   2023-03-03 (Fri, 03 Mar 2023)

  Changed paths:
M Source/WebCore/accessibility/AccessibilityImageMapLink.cpp
M Source/WebCore/accessibility/AccessibilityImageMapLink.h
M Source/WebCore/accessibility/AccessibilityNodeObject.cpp
M Source/WebCore/accessibility/AccessibilityNodeObject.h
M Source/WebCore/accessibility/AccessibilityObject.cpp
M Source/WebCore/accessibility/AccessibilityObject.h
M Source/WebCore/accessibility/AccessibilityObjectInterface.h
M Source/WebCore/accessibility/AccessibilityRenderObject.cpp
M Source/WebCore/accessibility/AccessibilitySVGElement.cpp
M Source/WebCore/accessibility/AccessibilitySVGElement.h
M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp
M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h
M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h

  Log Message:
  ---
  AX: Remove unnecessary caching of title() and accessibilityDescription() in 
AXIsolatedObject.
https://bugs.webkit.org/show_bug.cgi?id=253210


Reviewed by Chris Fleizach.

These two properties were being cached in the AXIsolatedObject initialization, 
but they were only used as separate properties in the search algorithm 
Accessibility::isAccessibilityTextSearchMatch(...). Instead, we now cache 
textContent(), which closer matches the text that is conveyed to the AX client 
to represent the object. This avoids possible duplications of cached text, and 
may make text searches more consistent with the conveyed content. In addition, 
textContent() will be used in a follow up patch as the text buffer on which to 
base TextMarkers. Some code cleanup.

* Source/WebCore/accessibility/AccessibilityImageMapLink.cpp:
(WebCore::AccessibilityImageMapLink::accessibilityText const):
(WebCore::AccessibilityImageMapLink::description const):
(WebCore::AccessibilityImageMapLink::nameForMSAA const):
(WebCore::AccessibilityImageMapLink::accessibilityDescription const): Renamed 
description()
* Source/WebCore/accessibility/AccessibilityImageMapLink.h:
* Source/WebCore/accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::description const):
(WebCore::AccessibilityNodeObject::helpText const):
(WebCore::AccessibilityNodeObject::accessibilityDescription const): Renamed 
description.
* Source/WebCore/accessibility/AccessibilityNodeObject.h:
* Source/WebCore/accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::textContent const):
(WebCore::Accessibility::isAccessibilityTextSearchMatch):
* Source/WebCore/accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::title const):
(WebCore::AccessibilityObject::description const):
(WebCore::AccessibilityObject::helpText const):
* Source/WebCore/accessibility/AccessibilityObjectInterface.h:
* Source/WebCore/accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::helpText const):
(WebCore::AccessibilityRenderObject::descriptionForMSAA const):
* Source/WebCore/accessibility/AccessibilitySVGElement.cpp:
(WebCore::AccessibilitySVGElement::accessibilityText const):
(WebCore::AccessibilitySVGElement::description const):
(WebCore::AccessibilitySVGElement::helpText const):
(WebCore::AccessibilitySVGElement::accessibilityDescription const): Renamed 
description.
* Source/WebCore/accessibility/AccessibilitySVGElement.h:
* Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp:
(WebCore::AXIsolatedObject::initializeProperties):
* Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h:
* Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h:

Canonical link: https://commits.webkit.org/261139@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 3e0670: Block Mach service in all cases

[Per Arne Vollan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3e0670a3304ac66ee027402d1ed30c2d63f2eb7e
  
https://github.com/WebKit/WebKit/commit/3e0670a3304ac66ee027402d1ed30c2d63f2eb7e
  Author: Per Arne Vollan 
  Date:   2023-03-03 (Fri, 03 Mar 2023)

  Changed paths:
M Source/WebKit/Shared/WebPageCreationParameters.cpp
M Source/WebKit/Shared/WebPageCreationParameters.h
M Source/WebKit/UIProcess/WebPageProxy.cpp
M Source/WebKit/WebProcess/WebPage/WebPage.cpp

  Log Message:
  ---
  Block Mach service in all cases
https://bugs.webkit.org/show_bug.cgi?id=252997
rdar://problem/106168413

Reviewed by Geoffrey Garen and Sihui Liu.

Currently, the launchd service is blocked with probability in the WebContent 
process. This patch blocks it in all cases
with a new enablement flag. Having blocked for 1-2 weeks with probability, we 
haven't found any failures. So now we believe
it's safe (or at least, as safe as it will ever be within the limits of our 
current development process) to block in all
cases.

* Source/WebKit/Shared/WebPageCreationParameters.cpp:
(WebKit::WebPageCreationParameters::encode const):
(WebKit::WebPageCreationParameters::decode):
* Source/WebKit/Shared/WebPageCreationParameters.h:
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::creationParameters):
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::m_appHighlightsVisible):

Canonical link: https://commits.webkit.org/261138@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 9a8564: Disable use of IOSurface in PDFs

[Per Arne Vollan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9a85649c152a57452c4f647ca9f4be560613207b
  
https://github.com/WebKit/WebKit/commit/9a85649c152a57452c4f647ca9f4be560613207b
  Author: Per Arne Vollan 
  Date:   2023-03-03 (Fri, 03 Mar 2023)

  Changed paths:
M Source/WTF/wtf/PlatformHave.h
M Source/WebKit/Platform/spi/ios/PDFKitSPI.h
M Source/WebKit/UIProcess/ios/WKPDFView.mm

  Log Message:
  ---
  Disable use of IOSurface in PDFs
https://bugs.webkit.org/show_bug.cgi?id=253075
rdar://problem/106028807

Reviewed by Geoffrey Garen.

Adopt API to disable use of IOSurface in PDFs on iOS.

* Source/WTF/wtf/PlatformHave.h:
* Source/WebKit/Platform/spi/ios/PDFKitSPI.h:
* Source/WebKit/UIProcess/ios/WKPDFView.mm:
(-[WKPDFView web_setContentProviderData:suggestedFilename:]):

Canonical link: https://commits.webkit.org/261137@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 4a7cad: Add API to trigger background fetch click event

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4a7cad9d3d392a6dd9784db1f009c7472ee01aca
  
https://github.com/WebKit/WebKit/commit/4a7cad9d3d392a6dd9784db1f009c7472ee01aca
  Author: Youenn Fablet 
  Date:   2023-03-03 (Fri, 03 Mar 2023)

  Changed paths:
A 
LayoutTests/http/wpt/background-fetch/background-fetch-abort.window-expected.txt
A LayoutTests/http/wpt/background-fetch/background-fetch-abort.window.html
A LayoutTests/http/wpt/background-fetch/background-fetch-abort.window.js
A 
LayoutTests/http/wpt/background-fetch/background-fetch-click.window-expected.txt
A LayoutTests/http/wpt/background-fetch/background-fetch-click.window.html
A LayoutTests/http/wpt/background-fetch/background-fetch-click.window.js
M LayoutTests/http/wpt/background-fetch/sw.js
M Source/WebCore/workers/service/background-fetch/BackgroundFetchEngine.cpp
M Source/WebCore/workers/service/background-fetch/BackgroundFetchEngine.h
M Source/WebCore/workers/service/background-fetch/BackgroundFetchStore.h
M Source/WebCore/workers/service/context/SWContextManager.cpp
M Source/WebCore/workers/service/context/SWContextManager.h
M Source/WebCore/workers/service/context/ServiceWorkerThread.cpp
M Source/WebCore/workers/service/context/ServiceWorkerThread.h
M Source/WebCore/workers/service/context/ServiceWorkerThreadProxy.cpp
M Source/WebCore/workers/service/context/ServiceWorkerThreadProxy.h
M Source/WebCore/workers/service/server/SWServer.cpp
M Source/WebCore/workers/service/server/SWServer.h
M Source/WebCore/workers/service/server/SWServerDelegate.h
M Source/WebCore/workers/service/server/SWServerToContextConnection.h
M Source/WebKit/NetworkProcess/NetworkProcess.cpp
M Source/WebKit/NetworkProcess/NetworkProcess.h
M Source/WebKit/NetworkProcess/NetworkProcess.messages.in
M Source/WebKit/NetworkProcess/NetworkSession.cpp
M Source/WebKit/NetworkProcess/NetworkSession.h
M 
Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerToContextConnection.cpp
M 
Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerToContextConnection.h
M Source/WebKit/NetworkProcess/storage/BackgroundFetchStoreImpl.cpp
M Source/WebKit/NetworkProcess/storage/BackgroundFetchStoreImpl.h
M Source/WebKit/NetworkProcess/storage/NetworkStorageManager.cpp
M Source/WebKit/NetworkProcess/storage/NetworkStorageManager.h
M Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.mm
M Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStorePrivate.h
M Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp
M Source/WebKit/UIProcess/Network/NetworkProcessProxy.h
M Source/WebKit/WebProcess/Storage/WebSWContextManagerConnection.cpp
M Source/WebKit/WebProcess/Storage/WebSWContextManagerConnection.h
M Source/WebKit/WebProcess/Storage/WebSWContextManagerConnection.messages.in
M Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl
M Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp
M Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.h
M Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp
M Tools/WebKitTestRunner/InjectedBundle/TestRunner.h
M Tools/WebKitTestRunner/TestController.cpp
M Tools/WebKitTestRunner/TestController.h
M Tools/WebKitTestRunner/TestInvocation.cpp
M Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm

  Log Message:
  ---
  Add API to trigger background fetch click event
https://bugs.webkit.org/show_bug.cgi?id=253072
rdar://problem/106026054

Reviewed by Sihui Liu.

Expose new WebsiteDataStore API to get a list of background fetch identifiers, 
click, abort, pause and resume them.
Each call sends IPC to network process to do the actual work.
The work is done through BackgroundFetchStoreImpl that will identify the 
background fetch registration from the background fetch identifier.
The background fetch identifier is the filename of the persisted background 
fetch.
Once identified, we send the order to the BackgroundFetchEngine.
This patch only implements abort and click in BackgroundFetchEngine.

We add testRunner API to trigger click, abort, resume and suspend actions.

* 
LayoutTests/http/wpt/background-fetch/background-fetch-abort.window-expected.txt:
 Added.
* LayoutTests/http/wpt/background-fetch/background-fetch-abort.window.html: 
Added.
* LayoutTests/http/wpt/background-fetch/background-fetch-abort.window.js: Added.
(promise_test.async t):
* 
LayoutTests/http/wpt/background-fetch/background-fetch-click.window-expected.txt:
 Added.
* LayoutTests/http/wpt/background-fetch/background-fetch-click.window.html: 
Added.
* LayoutTests/http/wpt/background-fetch/background-fetch-click.window.js: Added.
(promise_test.async t):
* LayoutTests/http/wpt/background-fetch/sw.js:
(onmessage):
(onbackgroundfetchclick):
(onbackgroundfetchabort):
* Source/WebCore/workers/service/background-fetch/BackgroundFetchEngine.cpp:
(WebCore::BackgroundFet

[webkit-changes] [WebKit/WebKit] 2e241f: Integrate RenderListMarker with @counter-style

[Vitor Roriz]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2e241f9b533bf886556c2a94a0cb242297a9d000
  
https://github.com/WebKit/WebKit/commit/2e241f9b533bf886556c2a94a0cb242297a9d000
  Author: Vitor Roriz 
  Date:   2023-03-03 (Fri, 03 Mar 2023)

  Changed paths:
M LayoutTests/TestExpectations
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-counter-styles/counter-style-at-rule/support/ref-common.css
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-counter-styles/counter-style-at-rule/support/test-common.css
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-lists/parsing/list-style-type-computed-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-lists/parsing/list-style-type-valid-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/list-style-type-expected.txt
M Source/WebCore/css/CSSCounterStyle.cpp
M Source/WebCore/css/CSSCounterStyle.h
M Source/WebCore/css/CSSCounterStyleRegistry.cpp
M Source/WebCore/css/CSSProperties.json
M Source/WebCore/css/ComputedStyleExtractor.cpp
M Source/WebCore/css/counterStyles.css
M Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp
M Source/WebCore/html/HTMLLIElement.cpp
M Source/WebCore/html/HTMLUListElement.cpp
M Source/WebCore/rendering/RenderListMarker.cpp
M Source/WebCore/rendering/style/RenderStyle.cpp
M Source/WebCore/rendering/style/RenderStyleConstants.h
M Source/WebCore/style/StyleBuilderCustom.h

  Log Message:
  ---
  Integrate RenderListMarker with @counter-style
https://bugs.webkit.org/show_bug.cgi?id=253158
rdar://102988393

Reviewed by Tim Nguyen.

This patch integrates RenderListMarker with
the parsed counter-style at-rules and fixes
some bugs catched during rendering.

Since we are wiring things up here, we can stop
skipping the related tests.

Some tests will still fail because we are missing:
- Support to shadow DOM scope.
- Integration with counters() function.
- Integration with symbols() function.
- Complex predefined symbols.
- Allowing redefinition of predefined symbols.
- Bug on wpt references regarding prefix/suffix fallback.
The missing items are linked to their issues in TestExpectations.

* LayoutTests/TestExpectations:
- Stop skipping the related tests. We are also tagging the tests
that we still fail due to missing feature/wpt bugs and we are
linking the relevant issues.

* 
LayoutTests/imported/w3c/web-platform-tests/css/css-counter-styles/counter-style-at-rule/support/ref-common.css:
(div, p):
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-counter-styles/counter-style-at-rule/support/test-common.css:
(li, p):
- Avoid fuzziness in the relevant tests. This change is also pushed to WPT 
(https://github.com/web-platform-tests/wpt/pull/38773)

* Source/WebCore/css/CSSCounterStyle.cpp:
(WebCore::CSSCounterStyle::counterForSystemCyclic const):
(WebCore::CSSCounterStyle::applyPadSymbols const):
- Fixing bugs in padding and cyclic-system.

* Source/WebCore/css/CSSCounterStyleRegistry.cpp:
(WebCore::CSSCounterStyleRegistry::resolveExtendsReference):
- We were forgetting to pass the map for reference resolution
during the resolution of author rules, which would make the
user agent map to be used instead, by default.

* Source/WebCore/css/CSSProperties.json:
- Enabling custom-ident parsing in list-style-type.

* Source/WebCore/css/counterStyles.css:
(@counter-style cjk-decimal):
(@counter-style disclosure-open):
(@counter-style disclosure-closed):
- Update the symbols for disclosure open/closed.

* Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp:
(WebCore::CSSPropertyParserHelpers::consumeCounterStyleAdditiveSymbols):
- Fixing bug where we would not invalidate additive-symbol with missing symbol.
This would cause a crash during rendering.

* Source/WebCore/rendering/style/RenderStyle.cpp:
(WebCore::rareInheritedDataChangeRequiresLayout):
- listStyleStringValue change now requires layout, since it defines the name of 
the counter-style.
* Source/WebCore/rendering/RenderListMarker.cpp:
(WebCore::RenderListMarker::updateContent):
* Source/WebCore/style/StyleBuilderCustom.h:
(WebCore::Style::BuilderCustom::applyValueListStyleType):
- Rendering Marker according to counter-style.

* LayoutTests/TestExpectations:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-lists/parsing/list-style-type-computed-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-lists/parsing/list-style-type-valid-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/list-style-type-expected.txt:
- We have new tests passing after fixing presentation hint mapping for LI and 
UL elements.

* Source/WebCore/css/ComputedStyleExtractor.cpp:
(WebCore::ComputedStyleExtractor::valueForPropertyInStyle):

* Source/WebCore/html/HTMLLIElement.cpp:
(WebCore::HTMLLIElement::collectPresentationalHintsForAttribu

[webkit-changes] [WebKit/WebKit] c13c03: Get rid of unnecessary layouts on body elements wi...

[Ahmad Saleem]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c13c03bc9729c266b3458fceb995c064764f2b90
  
https://github.com/WebKit/WebKit/commit/c13c03bc9729c266b3458fceb995c064764f2b90
  Author: Ahmad Saleem 
  Date:   2023-03-03 (Fri, 03 Mar 2023)

  Changed paths:
M Source/WebCore/rendering/RenderBlockFlow.cpp

  Log Message:
  ---
  Get rid of unnecessary layouts on body elements with quirky children

https://bugs.webkit.org/show_bug.cgi?id=253203

Reviewed by Alan Baradlay.

Merge - https://src.chromium.org/viewvc/blink?revision=169790&view=revision

RenderBlockFlow::marginBeforeEstimateForChild() was checking the wrong
margin when detecting quirky children. The performance test added by
this patch times out without the change in this patch - obviously a
pathological case.

* Source/WebCore/rendering/RenderBlockFlow.cpp:
(RenderBlockFlow::marginBeforeEstimateForChild): Change 'hasMarginAfterQuirk' 
to 'hasMarginBeforeQuirk'

Canonical link: https://commits.webkit.org/261134@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] ea7c20: Cherry-pick 261072@main (5c473b4124bf). https://bu...

[Žan Doberšek]

  Branch: refs/heads/webkitglib/2.40
  Home:   https://github.com/WebKit/WebKit
  Commit: ea7c20dfa5aa52dff6d8f740f37e7872177dc835
  
https://github.com/WebKit/WebKit/commit/ea7c20dfa5aa52dff6d8f740f37e7872177dc835
  Author: Žan Doberšek 
  Date:   2023-03-03 (Fri, 03 Mar 2023)

  Changed paths:
M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp

  Log Message:
  ---
  Cherry-pick 261072@main (5c473b4124bf). 
https://bugs.webkit.org/show_bug.cgi?id=253244

[GStreamer] Establish locking when mapping gbm_bo objects for 
software-decoded data upload
https://bugs.webkit.org/show_bug.cgi?id=253244

Reviewed by Philippe Normand.

When separate GStreamer pipelines are established for different video 
elements,
mapping the gbm_bo objects in parallel across different threads can lead to
crashes and GPU memory corruption.

The different gbm_bo objects originate from a single gbm_device, which is 
fine.
Spawning gbm_bo objects and retrieving different attributes from them isn't
showing as problematic, but libgbm thread safety guarantees still need 
research.

Mapping gbm_bo objects in parallel is proving as problematic, and the 
length of
the upload of software-decoded data into the mapped memory regions takes 
long
enough for these problems to inhibit stability. To avoid that, a global 
lock is
provided on the gbm_bo-mapping Destination class inside the
MediaPlayerPrivateGStreamer::pushDMABufToCompositor() method. This lock is
activated whenever data for a given plane is moved over from the 
GStreamer-based
software decoder into the gbm_bo object.

* 
Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::pushDMABufToCompositor):

Canonical link: https://commits.webkit.org/261072@main


  Commit: 49971be69094bede8d25c2129b98eaf33dcb85c4
  
https://github.com/WebKit/WebKit/commit/49971be69094bede8d25c2129b98eaf33dcb85c4
  Author: Žan Doberšek 
  Date:   2023-03-03 (Fri, 03 Mar 2023)

  Changed paths:
M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp

  Log Message:
  ---
  Cherry-pick 261077@main (9b1c8b87c0a4). 
https://bugs.webkit.org/show_bug.cgi?id=253245

[GStreamer] Improve GBM swapchain buffer handling
https://bugs.webkit.org/show_bug.cgi?id=253245

Reviewed by Philippe Normand.

In MediaPlayerPrivateGStreamer::pushDMABufToCompositor(), when allocating
buffer objects from the GBMBufferSwapchain to upload the software-decoded
video data, do a null check on the retrieved buffer. This avoids proceeding 
with
a null object that would be returned when for whatever perverse reason the
swapchain is drained of available buffers.

One such reason is when allocating, retrieving and locking buffers from the
swapchain under an inactive proxy. In that case, the buffer doesn't end up
being pushed into the composition, and it's then also never released and 
made
available for reuse, effectively draining the swapchain.

This case is avoidable through earlier detection of an inactive proxy. The 
proxy
lock and is-active check are unified between different codepaths and done 
before
deciding which codepath is taken.

* 
Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::pushDMABufToCompositor):

Canonical link: https://commits.webkit.org/261077@main


Compare: https://github.com/WebKit/WebKit/compare/90e92d2420f1...49971be69094
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 90e92d: Cherry-pick 261124@main (06b9ec1834d2). https://bu...

[Žan Doberšek]

  Branch: refs/heads/webkitglib/2.40
  Home:   https://github.com/WebKit/WebKit
  Commit: 90e92d2420f19938b3f5299080f9ded2da6fde6f
  
https://github.com/WebKit/WebKit/commit/90e92d2420f19938b3f5299080f9ded2da6fde6f
  Author: Žan Doberšek 
  Date:   2023-03-03 (Fri, 03 Mar 2023)

  Changed paths:
M Source/WebCore/page/scrolling/nicosia/ScrollingTreeNicosia.cpp
M Source/WebCore/page/scrolling/nicosia/ScrollingTreeNicosia.h
M 
Source/WebKit/Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp
M 
Source/WebKit/Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.h
M 
Source/WebKit/Shared/CoordinatedGraphics/threadedcompositor/ThreadedDisplayRefreshMonitor.cpp
M 
Source/WebKit/Shared/CoordinatedGraphics/threadedcompositor/ThreadedDisplayRefreshMonitor.h
M Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/LayerTreeHost.cpp

  Log Message:
  ---
  Cherry-pick 261124@main (06b9ec1834d2). 
https://bugs.webkit.org/show_bug.cgi?id=252467

[CoordinatedGraphics] Provide scheduled display-update events for better 
scrolling handling
https://bugs.webkit.org/show_bug.cgi?id=252467

Reviewed by Carlos Garcia Campos.

In ThreadedCompositor, a timer is established on the composition thread 
that is
used to mimic display updates at the desired update frequency. This is 
necessary
in order to provide opportunities for update producers like the scrolling 
thread
to actually enact the desired composition changes, like scrolling, 
independently
of the main thread.

The timer is put on the composition thread, matching the compositing-thread
update timer in priority. Its delay is based on the established frequency 
of the
display updates.

ThreadedCompositor::displayUpdateFired() method is added and is dispatched 
upon
every firing of the timer. It notifies the scrolling thread(s) for the given
display ID through the EventDispatcher instance on the WebProcess singleton,
and the next firing of the timer is then scheduled.

When ThreadedCompositor enters into the composition phase, the display 
update
timer is stopped, and the displayUpdateFired() dispatcher is invoked 
manually
when the frame-complete signal is returned from the embedder's environment. 
This
allows aligning the display update timer with the environment's vsync 
signals
without disturbing the composition itself.

The target update frequency logic is pulled from 
ThreadedDisplayRefreshMonitor
into ThreadedCompositor, with the desired DisplayUpdate object now also 
kept in
that class. In order for ThreadedDisplayRefreshMonitor to use a sensible
DisplayUpdate object for each of its own dispatches, the DisplayUpdate 
object
is passed through the requiresDisplayRefreshCallback() method to the 
monitor,
where it's then stored for next invocation on the main thread, if it occurs.

ScrollingTreeNicosia::applyLayerPositionsInternal() override is provided,
establishing an update scope when running on the scrolling thread. This will
cause the applied positions to actually go through composition whenever the
scrolling is being handled on the scrolling thread, meaning outside of the 
usual
update process.

* Source/WebCore/page/scrolling/nicosia/ScrollingTreeNicosia.cpp:
(WebCore::ScrollingTreeNicosia::applyLayerPositionsInternal):
* Source/WebCore/page/scrolling/nicosia/ScrollingTreeNicosia.h:
* 
Source/WebKit/Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp:
(WebKit::m_displayRefreshMonitor):
(WebKit::ThreadedCompositor::renderLayerTree):
(WebKit::ThreadedCompositor::sceneUpdateFinished):
(WebKit::ThreadedCompositor::frameComplete):
(WebKit::ThreadedCompositor::targetRefreshRateDidChange):
(WebKit::ThreadedCompositor::displayUpdateFired):
* 
Source/WebKit/Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.h:
* 
Source/WebKit/Shared/CoordinatedGraphics/threadedcompositor/ThreadedDisplayRefreshMonitor.cpp:
(WebKit::ThreadedDisplayRefreshMonitor::ThreadedDisplayRefreshMonitor):
(WebKit::ThreadedDisplayRefreshMonitor::requiresDisplayRefreshCallback):
(WebKit::ThreadedDisplayRefreshMonitor::invalidate):
(WebKit::ThreadedDisplayRefreshMonitor::displayRefreshCallback):
(WebKit::ThreadedDisplayRefreshMonitor::setTargetRefreshRate): Deleted.
* 
Source/WebKit/Shared/CoordinatedGraphics/threadedcompositor/ThreadedDisplayRefreshMonitor.h:
* Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/LayerTreeHost.cpp:
(WebKit::LayerTreeHost::displayDidRefresh):

Canonical link: https://commits.webkit.org/261124@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 21e5a2: Remove obsolete useGDI code path and FontRendering...

[Fujii Hironori]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 21e5a249467d6356fa3cdacb6f49e12b542850fc
  
https://github.com/WebKit/WebKit/commit/21e5a249467d6356fa3cdacb6f49e12b542850fc
  Author: Fujii Hironori 
  Date:   2023-03-03 (Fri, 03 Mar 2023)

  Changed paths:
M Source/WebCore/Headers.cmake
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
M Source/WebCore/page/DragController.cpp
M Source/WebCore/page/Settings.yaml
M Source/WebCore/page/SettingsBase.h
M Source/WebCore/platform/DragImage.cpp
M Source/WebCore/platform/DragImage.h
M Source/WebCore/platform/cocoa/DragImageCocoa.mm
M Source/WebCore/platform/graphics/FontCascade.h
M Source/WebCore/platform/graphics/FontCascadeCache.h
M Source/WebCore/platform/graphics/FontDescription.cpp
M Source/WebCore/platform/graphics/FontDescription.h
M Source/WebCore/platform/graphics/FontPlatformData.h
M Source/WebCore/platform/graphics/win/ComplexTextControllerUniscribe.cpp
M Source/WebCore/platform/graphics/win/FontCacheWin.cpp
R Source/WebCore/platform/graphics/win/FontCustomPlatformData.cpp
M Source/WebCore/platform/graphics/win/FontCustomPlatformDataWin.cpp
M Source/WebCore/platform/graphics/win/FontPlatformDataCairoWin.cpp
M Source/WebCore/platform/graphics/win/FontPlatformDataWin.cpp
M Source/WebCore/platform/graphics/win/SimpleFontDataCairoWin.cpp
M Source/WebCore/platform/graphics/win/SimpleFontDataWin.cpp
M Source/WebCore/platform/gtk/DragImageGtk.cpp
M Source/WebCore/platform/ios/DragImageIOS.mm
R Source/WebCore/platform/text/FontRenderingMode.h
M Source/WebCore/platform/win/DragImageWin.cpp
M Source/WebCore/rendering/RenderEmbeddedObject.cpp
M Source/WebCore/style/StyleResolveForDocument.cpp
M Source/WebCore/style/StyleResolver.cpp
M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in
M Source/WebKit/Shared/win/WebCoreArgumentCodersWin.cpp

  Log Message:
  ---
  Remove obsolete useGDI code path and FontRenderingMode enum
https://bugs.webkit.org/show_bug.cgi?id=206273

Reviewed by Alex Christensen.

These code was used only by AppleWin port.

Define cWindowsFontScaleFactor to remove the magic number 32.

* Source/WebCore/Headers.cmake:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/page/DragController.cpp:
(WebCore::DragController::startDrag):
* Source/WebCore/page/Settings.yaml:
* Source/WebCore/page/SettingsBase.h:
* Source/WebCore/platform/DragImage.cpp:
(WebCore::createDragImageForLink):
* Source/WebCore/platform/DragImage.h:
* Source/WebCore/platform/cocoa/DragImageCocoa.mm:
(WebCore::createDragImageForLink):
* Source/WebCore/platform/graphics/FontCascade.h:
(WebCore::FontCascade::renderingMode const): Deleted.
* Source/WebCore/platform/graphics/FontCascadeCache.h:
(WebCore::FontDescriptionKey::makeFlagsKey):
* Source/WebCore/platform/graphics/FontDescription.cpp:
* Source/WebCore/platform/graphics/FontDescription.h:
(WebCore::FontDescription::fontSelectionRequest const):
(WebCore::FontDescription::setWeight):
(WebCore::FontDescription::operator== const):
(WebCore::FontDescription::encode const):
(WebCore::FontDescription::decode):
(WebCore::FontDescription::renderingMode const): Deleted.
(WebCore::FontDescription::setRenderingMode): Deleted.
* Source/WebCore/platform/graphics/FontPlatformData.h:
(WebCore::FontPlatformData::hfont const):
(WebCore::FontPlatformData::useGDI const): Deleted.
(WebCore::FontPlatformData::cgFont const): Deleted.
* Source/WebCore/platform/graphics/win/ComplexTextControllerUniscribe.cpp:
(WebCore::ComplexTextController::collectComplexTextRunsForCharacters):
* Source/WebCore/platform/graphics/win/FontCacheWin.cpp:
(WebCore::FontCache::lastResortFallbackFont):
(WebCore::createGDIFont):
(WebCore::FontCache::createFontPlatformData):
* Source/WebCore/platform/graphics/win/FontCustomPlatformData.cpp: Removed.
* Source/WebCore/platform/graphics/win/FontCustomPlatformDataWin.cpp:
(WebCore::FontCustomPlatformData::fontPlatformData):
* Source/WebCore/platform/graphics/win/FontPlatformDataCairoWin.cpp:
(WebCore::FontPlatformData::platformDataInit):
(WebCore::FontPlatformData::platformIsEqual const):
* Source/WebCore/platform/graphics/win/FontPlatformDataWin.cpp:
(WebCore::FontPlatformData::FontPlatformData):
* Source/WebCore/platform/graphics/win/SimpleFontDataCairoWin.cpp:
(WebCore::Font::platformInit):
* Source/WebCore/platform/graphics/win/SimpleFontDataWin.cpp:
(WebCore::Font::platformCharWidthInit):
(WebCore::Font::platformCreateScaledFont const):
* Source/WebCore/platform/gtk/DragImageGtk.cpp:
(WebCore::createDragImageForLink):
* Source/WebCore/platform/ios/DragImageIOS.mm:
(WebCore::createDragImageForLink):
* Source/WebCore/platform/text/FontRenderingMode.h: Removed.
* Source/WebCore/platform/win/DragImageWin.cpp:
(WebCore::dragLabelFont):
(WebCore::createDragImageForLink):
* Source/WebCore/rendering/RenderEmbeddedObject.cpp:
(WebCore::RenderEmbed

[webkit-changes] [WebKit/WebKit] fd6859: [web-animations] ensure accelerated effects do not...

[Antoine Quint]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fd6859ad60cd1cb51fabdb4169bf0e4de09f502a
  
https://github.com/WebKit/WebKit/commit/fd6859ad60cd1cb51fabdb4169bf0e4de09f502a
  Author: Antoine Quint 
  Date:   2023-03-03 (Fri, 03 Mar 2023)

  Changed paths:
M Source/WebCore/platform/animation/AcceleratedEffect.cpp
M Source/WebCore/platform/animation/AcceleratedEffect.h
M Source/WebCore/platform/animation/AcceleratedEffectValues.cpp
M Source/WebCore/platform/animation/AcceleratedEffectValues.h
M Source/WebCore/platform/graphics/transforms/TransformOperation.h
M 
Source/WebCore/platform/graphics/transforms/TranslateTransformOperation.cpp
M Source/WebCore/platform/graphics/transforms/TranslateTransformOperation.h
M Source/WebCore/rendering/RenderLayerBacking.cpp

  Log Message:
  ---
  [web-animations] ensure accelerated effects do not contain calculated values
https://bugs.webkit.org/show_bug.cgi?id=253243

Reviewed by Dean Jackson.

Since we will lack the ability to encode calculated values when committing 
PlatformCALayerRemote,
we must ensure those values are pre-calculated when the accelerated effect is 
created.

To do this, we pass down the border box of the RenderLayerBacking's associated 
renderer down to
AcceleratedEffectValues to correctly resolve any Length-backed value that is 
calculated. In the
case of transform operations, we add a new 
selfOrCopyWithResolvedCalculatedValues() method that
will only create a new operation if needed.

* Source/WebCore/platform/animation/AcceleratedEffect.cpp:
(WebCore::AcceleratedEffect::create):
(WebCore::AcceleratedEffect::copyWithProperties):
(WebCore::AcceleratedEffect::AcceleratedEffect):
* Source/WebCore/platform/animation/AcceleratedEffect.h:
* Source/WebCore/platform/animation/AcceleratedEffectValues.cpp:
(WebCore::AcceleratedEffectValues::AcceleratedEffectValues):
(WebCore::nonCalculatedLengthPoint):
(WebCore::AcceleratedEffectValues::copyTransformOperations): Deleted.
* Source/WebCore/platform/animation/AcceleratedEffectValues.h:
* Source/WebCore/platform/graphics/transforms/TransformOperation.h:
(WebCore::TransformOperation::selfOrCopyWithResolvedCalculatedValues):
* Source/WebCore/platform/graphics/transforms/TranslateTransformOperation.cpp:
(WebCore::TranslateTransformOperation::selfOrCopyWithResolvedCalculatedValues):
* Source/WebCore/platform/graphics/transforms/TranslateTransformOperation.h:
* Source/WebCore/rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateAcceleratedEffectsAndBaseValues):

Canonical link: https://commits.webkit.org/261132@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 151a75: Image types enabled by additionalSupportedImageTyp...

[Myles C. Maxfield]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 151a757aa72b7bb9165f9c72fea85bbd09a9181d
  
https://github.com/WebKit/WebKit/commit/151a757aa72b7bb9165f9c72fea85bbd09a9181d
  Author: Myles C. Maxfield 
  Date:   2023-03-03 (Fri, 03 Mar 2023)

  Changed paths:
M LayoutTests/TestExpectations
A LayoutTests/http/tests/misc/heic-accept-header-expected.txt
A LayoutTests/http/tests/misc/heic-accept-header.html
A LayoutTests/http/tests/misc/resources/green-400x400.heic
A LayoutTests/http/tests/misc/resources/image-heic-accept.py
M LayoutTests/platform/ios/TestExpectations
M LayoutTests/platform/mac/TestExpectations
M Source/WebCore/loader/cache/CachedResourceRequest.cpp

  Log Message:
  ---
  Image types enabled by additionalSupportedImageTypes do not show up in the 
Accept: header
https://bugs.webkit.org/show_bug.cgi?id=253046
rdar://106006530

Reviewed by Said Abou-Hallawa.

We can simply augment the Accept: header with the mime types of these image 
formats.

* LayoutTests/http/tests/misc/heic-accept-header-expected.txt: Added.
* LayoutTests/http/tests/misc/heic-accept-header.html: Added.
* LayoutTests/http/tests/misc/resources/image-heic-accept.py: Added.
* Source/WebCore/loader/cache/CachedResourceRequest.cpp:
(WebCore::acceptHeaderValueForAdditionalSupportedImageMIMETypes):
(WebCore::acceptHeaderValueForImageResource):

Canonical link: https://commits.webkit.org/261131@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 812ce3: ImageBufferIOSurfaceBackend should get and put dat...

[Kimmo Kinnunen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 812ce301dec978351734e9cd4f2b43a399599747
  
https://github.com/WebKit/WebKit/commit/812ce301dec978351734e9cd4f2b43a399599747
  Author: Kimmo Kinnunen 
  Date:   2023-03-03 (Fri, 03 Mar 2023)

  Changed paths:
M Source/WebCore/platform/graphics/ImageBuffer.cpp
M Source/WebCore/platform/graphics/ImageBuffer.h
M Source/WebCore/platform/graphics/ImageBufferBackend.cpp
M Source/WebCore/platform/graphics/ImageBufferBackend.h
M Source/WebCore/platform/graphics/cg/ImageBufferIOSurfaceBackend.cpp
M Source/WebCore/platform/graphics/cg/ImageBufferIOSurfaceBackend.h
M Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferProxy.cpp
M Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferProxy.h

  Log Message:
  ---
  ImageBufferIOSurfaceBackend should get and put data in WP when in mapped mode
https://bugs.webkit.org/show_bug.cgi?id=252987
rdar://problem/105972277

Reviewed by Matt Woodrow.

Make putImageData(), getImageData() access the data directly from the
Web process when IOSurfaces are available there.

Avoids sending messages to GPU process and memcpying the contents
multiple times.

* Source/WebCore/platform/graphics/ImageBuffer.cpp:
(WebCore::ImageBuffer::flushContext):
(WebCore::ImageBuffer::copyNativeImageForDrawing const):
(WebCore::ImageBuffer::draw):
(WebCore::ImageBuffer::getPixelBuffer const):
(WebCore::ImageBuffer::putPixelBuffer):
Before, the ImageBuffer would flush the drawing context,
e.g. the IPC commands to the GPUP and flush the draws there,
and then it would flush the backend context.
Move the backend maintainance into the backend functions, as it is
internal detail of the backend.
Instead just flush the drawing context, which on non-GPUP case
flushes the real IOSurface context and GPUP case flushes through
the IPC.

* Source/WebCore/platform/graphics/ImageBuffer.h:
* Source/WebCore/platform/graphics/ImageBufferBackend.cpp:
(WebCore::ImageBufferBackend::copyNativeImageForDrawing):
Provide the destination context to copyNativeImageForDrawing instead
of unused BackingStoreCopy argument.

* Source/WebCore/platform/graphics/ImageBufferBackend.h:
* Source/WebCore/platform/graphics/cg/ImageBufferIOSurfaceBackend.cpp:
(WebCore::ImageBufferIOSurfaceBackend::invalidateCachedNativeImage):
(WebCore::ImageBufferIOSurfaceBackend::copyNativeImageForDrawing):
Fix the copyNativeImageForDrawing(). Before, it would return a CGImage
but not mark the m_mayHaveOutstandingBackingStoreReferences. The intention
was that instead, it would call invalidateCachedNativeImage() to cleanup
the bitmap cache from the cached CGImage. However, this would still leave
some backends, like display list and iosurface, to reference the IOSurface
without ImageBufferIOSurfaceBackend knowing about it. In these cases,
putImageData could change the underlying IOSurface before the display list
or iosurface renderer would have completed their use.

Instead, use CGIOSurfaceContextCreateImageReference which has the added
benefit of not needing the fixup case for cleaning up the memory footprint
after bitmap rendering.

(WebCore::ImageBufferIOSurfaceBackend::getPixelBuffer):
Flush the writes through the backends drawing context.

(WebCore::ImageBufferIOSurfaceBackend::putPixelBuffer):
Flush the writes through the drawing context and CGImage reads.

(WebCore::ImageBufferIOSurfaceBackend::surface):
(WebCore::ImageBufferIOSurfaceBackend::ensureNativeImagesHaveCopiedBackingStore):
(WebCore::ImageBufferIOSurfaceBackend::prepareForExternalRead):
(WebCore::ImageBufferIOSurfaceBackend::prepareForExternalWrite):
(WebCore::ImageBufferIOSurfaceBackend::invalidateCachedNativeImageIfNeeded): 
Deleted.
(WebCore::ImageBufferIOSurfaceBackend::finalizeDrawIntoContext): Deleted.
* Source/WebCore/platform/graphics/cg/ImageBufferIOSurfaceBackend.h:

* Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferProxy.cpp:
(WebKit::RemoteImageBufferProxy::copyNativeImageForDrawing const):
(WebKit::RemoteImageBufferProxy::getPixelBuffer const):
(WebKit::RemoteImageBufferProxy::putPixelBuffer):
The remote proxy putPutlBuffer/getPixelBuffer can now directly call the
normal ImageBufferIOSurfaceBackend codepath for the put/get.
The IPC is flushed by the ImageBuffer calling flushDrawingContext()
The pending read references through the local iosurface are maintained
by the ImageBufferIOSurfaceBackend.
* Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferProxy.h:
The m_needsFlush needs to be flipped to true, since now the first
command might be local putPixelBuffer. This needs to complete after
the initial CGContextFillRect that clears the IOSurface.
Before this was not needed, as all the commands were executed on GPUP
side.

Canonical link: https://commits.webkit.org/261130@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] a45614: Unreviewed, reverting r261111@main.

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a45614e2c76d1aaa402345f8a9771fd8197634d1
  
https://github.com/WebKit/WebKit/commit/a45614e2c76d1aaa402345f8a9771fd8197634d1
  Author: Commit Queue 
  Date:   2023-03-03 (Fri, 03 Mar 2023)

  Changed paths:
M Source/JavaScriptCore/Configurations/Base.xcconfig
M Source/JavaScriptCore/Configurations/JavaScriptCore.xcconfig
M Source/JavaScriptCore/Configurations/ToolExecutable.xcconfig
M Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj
M Source/ThirdParty/ANGLE/ANGLE.xcodeproj/project.pbxproj
M Source/ThirdParty/ANGLE/Configurations/ANGLE-dynamic.xcconfig
M Source/ThirdParty/ANGLE/Configurations/Base.xcconfig
M Source/ThirdParty/libwebrtc/Configurations/Base.xcconfig
M Source/ThirdParty/libwebrtc/Configurations/libabsl.xcconfig
M Source/ThirdParty/libwebrtc/Configurations/libwebrtc.xcconfig
M Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj
M Source/WTF/Configurations/Base.xcconfig
M Source/WTF/Configurations/WTF.xcconfig
M Source/WTF/WTF.xcodeproj/project.pbxproj
M Source/WebCore/PAL/Configurations/Base.xcconfig
M Source/WebCore/PAL/Configurations/PAL.xcconfig
M Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj
M Source/WebGPU/Configurations/Base.xcconfig
M Source/WebGPU/Configurations/WGSL.xcconfig
M Source/WebKit/Configurations/Base.xcconfig
M Source/WebKit/Configurations/WebKit.xcconfig
M Source/WebKit/WebKit.xcodeproj/project.pbxproj
M Source/WebKitLegacy/WebKitLegacy.xcodeproj/project.pbxproj
M Source/WebKitLegacy/mac/Configurations/Base.xcconfig
M Source/WebKitLegacy/mac/Configurations/WebKitLegacy.xcconfig
M Tools/DumpRenderTree/mac/Configurations/Base.xcconfig
M Tools/DumpRenderTree/mac/Configurations/DumpRenderTreeLibrary.xcconfig
M Tools/DumpRenderTree/mac/Configurations/LayoutTestHelper.xcconfig
M Tools/TestWebKitAPI/Configurations/Base.xcconfig
M Tools/TestWebKitAPI/Configurations/TestWTFLibrary.xcconfig

  Log Message:
  ---
  Unreviewed, reverting r26@main.
https://bugs.webkit.org/show_bug.cgi?id=253301

Broke internal builds

Reverted changeset:

"Remove legacy build system script phases and build settings"
https://bugs.webkit.org/show_bug.cgi?id=243221
https://commits.webkit.org/26@main

Canonical link: https://commits.webkit.org/261129@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 41855a: Opt out of playback preventing app backgrounding f...

[Dean Jackson]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 41855a9143871d0ff15e9880b841fd51a11164e6
  
https://github.com/WebKit/WebKit/commit/41855a9143871d0ff15e9880b841fd51a11164e6
  Author: Dean Jackson 
  Date:   2023-03-03 (Fri, 03 Mar 2023)

  Changed paths:
M 
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm
M 
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm
M Source/WebCore/platform/graphics/cocoa/MediaPlayerPrivateWebM.mm

  Log Message:
  ---
  Opt out of playback preventing app backgrounding for silent videos
https://bugs.webkit.org/show_bug.cgi?id=253163
rdar://103458234

Reviewed by Jer Noble and Eric Carlson.

AVFoundation has exposed new API on AVPlayer and AVSampleBufferDisplayLayer
to avoid silent media playback from keeping the app moving to the background.

Test for the property, then set it to NO.

* 
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer):
* 
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::ensureLayer):
* Source/WebCore/platform/graphics/cocoa/MediaPlayerPrivateWebM.mm:
(WebCore::MediaPlayerPrivateWebM::ensureLayer):

Canonical link: https://commits.webkit.org/261128@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes