[webkit-changes] [WebKit/WebKit] 6e6665: [WebGPU] addPipelineLayouts should check if value ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6e666500f2f7cf6f8bb977a1f33c8778d366d9a4 https://github.com/WebKit/WebKit/commit/6e666500f2f7cf6f8bb977a1f33c8778d366d9a4 Author: Mike Wyrzykowski Date: 2024-04-01 (Mon, 01 Apr 2024) Changed paths: M Source/WebGPU/WebGPU/RenderPipeline.mm Log Message: --- [WebGPU] addPipelineLayouts should check if value exist in the map before taking its value https://bugs.webkit.org/show_bug.cgi?id=271875 Reviewed by Dan Glastonbury. The WGSL compiler creates the names for the values in this map, so it is not currently possible to encounter this issue, but we can be preventative since it is not obvious that it is not reproducible. * Source/WebGPU/WebGPU/RenderPipeline.mm: (WebGPU::Device::addPipelineLayouts): Canonical link: https://commits.webkit.org/276926@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 59cedf: Linker error when logging ViewportConfiguration to...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 59cedf7135bc81ea30a89477356dfd5951764d2d https://github.com/WebKit/WebKit/commit/59cedf7135bc81ea30a89477356dfd5951764d2d Author: Abrar Rahman Protyasha Date: 2024-04-01 (Mon, 01 Apr 2024) Changed paths: M Source/WebCore/page/ViewportConfiguration.cpp M Source/WebCore/page/ViewportConfiguration.h Log Message: --- Linker error when logging ViewportConfiguration to TextStream in Release configuration https://bugs.webkit.org/show_bug.cgi?id=271962 rdar://125713559 Reviewed by Sihui Liu. WebCore::operator<<(WTF::TextStream&, WebCore::ViewConfiguration const&) is defined behind !LOG_DISABLED, which means in Release configuration, the linker cannot find this definition. This patch fixes the linker error by removing the relevant !LOG_DISABLED checks around both the operator<< overload definition and the description()/dump() declarations, since said methods are referenced by the operator<< overload. * Source/WebCore/page/ViewportConfiguration.cpp: (WebCore::ViewportConfiguration::setIsKnownToLayOutWiderThanViewport): (WebCore::ViewportConfiguration::dump const): * Source/WebCore/page/ViewportConfiguration.h: Canonical link: https://commits.webkit.org/276925@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8fb5a0: [WinCairo] Unreviewed test gardening
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8fb5a06d7d79bc734694a254fb475c8e3c9de80b https://github.com/WebKit/WebKit/commit/8fb5a06d7d79bc734694a254fb475c8e3c9de80b Author: Fujii Hironori Date: 2024-04-01 (Mon, 01 Apr 2024) Changed paths: M LayoutTests/platform/wincairo/TestExpectations Log Message: --- [WinCairo] Unreviewed test gardening * LayoutTests/platform/wincairo/TestExpectations: Canonical link: https://commits.webkit.org/276924@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c854e7: [Gardening]: REGRESSION (276636@main): [ macOS wk2...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c854e7e0be45a202e0d3b9a9c94c2bd50706affe https://github.com/WebKit/WebKit/commit/c854e7e0be45a202e0d3b9a9c94c2bd50706affe Author: Jay Stfleur Date: 2024-04-01 (Mon, 01 Apr 2024) Changed paths: A LayoutTests/platform/mac-monterey-wk2/http/tests/workers/service/openwindow-from-notification-click-expected.txt Log Message: --- [Gardening]: REGRESSION (276636@main): [ macOS wk2 ] http/tests/workers/service/openwindow-from-notification-click.html is a consistent crash https://bugs.webkit.org/show_bug.cgi?id=271732 rdar://125442890 Unreviewed test gardening. Adding test rebaseline after test started failing after fixes for crashes. * LayoutTests/platform/mac-monterey-wk2/http/tests/workers/service/openwindow-from-notification-click-expected.txt: Added. Canonical link: https://commits.webkit.org/276923@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a92549: Send WebPage::PreferencesDidChange to all processe...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a925498ca136fcd8de543d406e3cab73c876a4f2 https://github.com/WebKit/WebKit/commit/a925498ca136fcd8de543d406e3cab73c876a4f2 Author: Alex Christensen Date: 2024-04-01 (Mon, 01 Apr 2024) Changed paths: M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm M Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h M Source/WebKit/UIProcess/WebPageProxy.cpp M Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm Log Message: --- Send WebPage::PreferencesDidChange to all processes with site isolation enabled https://bugs.webkit.org/show_bug.cgi?id=271999 rdar://125740635 Reviewed by Charlie Wolfe. I also added test SPI to evaluate JS in a child frame without a user gesture so I could use the success of window.open without a user gesture to test the success of updating preferences in an iframe's process. * Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm: (-[WKWebView _evaluateJavaScript:withSourceURL:inFrame:inContentWorld:withUserGesture:completionHandler:]): * Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h: * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::preferencesDidChange): * Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm: (TestWebKitAPI::TEST): Canonical link: https://commits.webkit.org/276922@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6a733f: Fix typo Registeration -> Registration
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6a733f6db1754ada1ffc78ccac24deb924c25eae https://github.com/WebKit/WebKit/commit/6a733f6db1754ada1ffc78ccac24deb924c25eae Author: Pascoe Date: 2024-04-01 (Mon, 01 Apr 2024) Changed paths: M Source/JavaScriptCore/runtime/TZoneInit.cpp M Source/JavaScriptCore/runtime/TZoneInit.h M Source/WebKit/Shared/API/Cocoa/WKMain.mm M Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm M Source/WebKit/UIProcess/WebAuthentication/WebAuthenticatorCoordinatorProxy.h Log Message: --- Fix typo Registeration -> Registration https://bugs.webkit.org/show_bug.cgi?id=271991 rdar://122321639 Reviewed by Chris Dumez and Justin Michaud. This patch fixes typos of the form Registeration -> Registration. * Source/JavaScriptCore/runtime/TZoneInit.cpp: (TZoneRegistrationDone): (TZoneRegisterationDone): Deleted. * Source/JavaScriptCore/runtime/TZoneInit.h: * Source/WebKit/Shared/API/Cocoa/WKMain.mm: (WKXPCServiceMain): * Source/WebKit/UIProcess/WebAuthentication/WebAuthenticatorCoordinatorProxy.h: Canonical link: https://commits.webkit.org/276921@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8dcff7: REGRESSION (276404@main): [ iOS ] imported/w3c/web...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8dcff76a84384cedf0ae7da82c089af2990e136c https://github.com/WebKit/WebKit/commit/8dcff76a84384cedf0ae7da82c089af2990e136c Author: Alan Baradlay Date: 2024-04-01 (Mon, 01 Apr 2024) Changed paths: M LayoutTests/platform/ios/TestExpectations M LayoutTests/platform/ios/imported/w3c/web-platform-tests/mathml/relations/html5-tree/dynamic-childlist-002-expected.txt Log Message: --- REGRESSION (276404@main): [ iOS ] imported/w3c/web-platform-tests/mathml/relations/html5-tree/dynamic-childlist-002.html is a constant failure https://bugs.webkit.org/show_bug.cgi?id=271990 Unreviewed test gardening. * LayoutTests/platform/ios/TestExpectations: * LayoutTests/platform/ios/imported/w3c/web-platform-tests/mathml/relations/html5-tree/dynamic-childlist-002-expected.txt: Canonical link: https://commits.webkit.org/276920@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a45baf: [Site Isolation] `dumpChildFramesAsText()` should ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a45baf2324ee277e8d28b29d5ca723b3cf485c44 https://github.com/WebKit/WebKit/commit/a45baf2324ee277e8d28b29d5ca723b3cf485c44 Author: Charlie Wolfe Date: 2024-04-01 (Mon, 01 Apr 2024) Changed paths: M LayoutTests/http/tests/site-isolation/notify-done-expected.txt M Source/WebKit/WebProcess/WebPage/WebFrame.cpp Log Message: --- [Site Isolation] `dumpChildFramesAsText()` should output the names of out-of-process frames https://bugs.webkit.org/show_bug.cgi?id=271992 rdar://125737114 Reviewed by Alex Christensen. This is work towards getting tests that use `dumpChildFramesAsText()` to compare correctly with --site-isolation. More work is needed for the frame index to be correct. * LayoutTests/http/tests/site-isolation/notify-done-expected.txt: * Source/WebKit/WebProcess/WebPage/WebFrame.cpp: (WebKit::WebFrame::frameTextForTesting): Canonical link: https://commits.webkit.org/276919@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 08da24: Element::boundingClientRect should check the state...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 08da24e33a25275b870ce9d3a2604c02c42495e5 https://github.com/WebKit/WebKit/commit/08da24e33a25275b870ce9d3a2604c02c42495e5 Author: Alan Baradlay Date: 2024-04-01 (Mon, 01 Apr 2024) Changed paths: M Source/WebCore/dom/Element.cpp Log Message: --- Element::boundingClientRect should check the state of the tree https://bugs.webkit.org/show_bug.cgi?id=271934 Reviewed by Simon Fraser. Check if we can get away with not running layout. * Source/WebCore/dom/Element.cpp: (WebCore::Element::boundingClientRect): * Tools/Scripts/webkitpy/benchmark_runner/data/plans/speedometer3.plan: Canonical link: https://commits.webkit.org/276918@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1fc331: [Cocoa] Allow camera zoom above 2x
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1fc3314c16bc098cbaa413895f17e3fbe3a6c2d6 https://github.com/WebKit/WebKit/commit/1fc3314c16bc098cbaa413895f17e3fbe3a6c2d6 Author: Eric Carlson Date: 2024-04-01 (Mon, 01 Apr 2024) Changed paths: M Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm Log Message: --- [Cocoa] Allow camera zoom above 2x https://bugs.webkit.org/show_bug.cgi?id=271968 rdar://125180182 Reviewed by Youenn Fablet. Allow up to 10x on all cameras that support that level of zoom. * Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm: (WebCore::AVVideoCaptureSource::computeMaxZoom const): Canonical link: https://commits.webkit.org/276917@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d8d941: [JSC] Start sharing megamorphic ById JIT code
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d8d941f1893050954e64ab80125e28b1a38c6445 https://github.com/WebKit/WebKit/commit/d8d941f1893050954e64ab80125e28b1a38c6445 Author: Yusuke Suzuki Date: 2024-04-01 (Mon, 01 Apr 2024) Changed paths: M Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj M Source/JavaScriptCore/Sources.txt M Source/JavaScriptCore/bytecode/AccessCase.h M Source/JavaScriptCore/bytecode/InlineCacheCompiler.cpp A Source/JavaScriptCore/bytecode/SharedJITStubSet.cpp A Source/JavaScriptCore/bytecode/SharedJITStubSet.h M Source/JavaScriptCore/bytecode/StructureStubInfo.cpp M Source/JavaScriptCore/bytecode/StructureStubInfo.h M Source/JavaScriptCore/heap/Heap.cpp M Source/JavaScriptCore/jit/GCAwareJITStubRoutine.cpp M Source/JavaScriptCore/jit/GCAwareJITStubRoutine.h M Source/JavaScriptCore/jit/PolymorphicCallStubRoutine.h M Source/JavaScriptCore/runtime/CacheableIdentifier.h M Source/JavaScriptCore/runtime/CacheableIdentifierInlines.h M Source/JavaScriptCore/runtime/VM.cpp Log Message: --- [JSC] Start sharing megamorphic ById JIT code https://bugs.webkit.org/show_bug.cgi?id=271942 rdar://125667161 Reviewed by Keith Miller. This patch makes megamorphic ById JIT code shareable between multiple sites. This is paving a way towards full handler IC, but for now, this is limited to megamorphic ById JIT code. SharedJITStubSet can do hashing via AccessCase vector and can store JIT code for them. This is a key part for Handler IC since we would like to use that later. * Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj: * Source/JavaScriptCore/Sources.txt: * Source/JavaScriptCore/bytecode/AccessCase.h: (JSC::AccessCase::updateIdentifier): * Source/JavaScriptCore/bytecode/InlineCacheCompiler.cpp: (JSC::isMegamorphicById): (JSC::InlineCacheCompiler::regenerate): * Source/JavaScriptCore/bytecode/SharedJITStubSet.cpp: Added. (JSC::SharedJITStubSet::getStatelessStub const): (JSC::SharedJITStubSet::setStatelessStub): (JSC::SharedJITStubSet::getSlowPathHandler const): (JSC::SharedJITStubSet::setSlowPathHandler): * Source/JavaScriptCore/bytecode/SharedJITStubSet.h: Added. (JSC::SharedJITStubSet::stubInfoKey): (JSC::SharedJITStubSet::Hash::Key::Key): (JSC::SharedJITStubSet::Hash::Key::isHashTableDeletedValue const): (JSC::SharedJITStubSet::Hash::hash): (JSC::SharedJITStubSet::Hash::equal): (JSC::SharedJITStubSet::Searcher::Translator::hash): (JSC::SharedJITStubSet::Searcher::Translator::equal): (JSC::SharedJITStubSet::PointerTranslator::hash): (JSC::SharedJITStubSet::PointerTranslator::equal): (JSC::SharedJITStubSet::add): (JSC::SharedJITStubSet::remove): (JSC::SharedJITStubSet::find): * Source/JavaScriptCore/bytecode/StructureStubInfo.cpp: (JSC::SharedJITStubSet::getStatelessStub const): Deleted. (JSC::SharedJITStubSet::setStatelessStub): Deleted. (JSC::SharedJITStubSet::getSlowPathHandler const): Deleted. (JSC::SharedJITStubSet::setSlowPathHandler): Deleted. * Source/JavaScriptCore/bytecode/StructureStubInfo.h: (JSC::SharedJITStubSet::Hash::Key::Key): Deleted. (JSC::SharedJITStubSet::Hash::Key::isHashTableDeletedValue const): Deleted. (JSC::SharedJITStubSet::Hash::hash): Deleted. (JSC::SharedJITStubSet::Hash::equal): Deleted. (JSC::SharedJITStubSet::Searcher::Translator::hash): Deleted. (JSC::SharedJITStubSet::Searcher::Translator::equal): Deleted. (JSC::SharedJITStubSet::PointerTranslator::hash): Deleted. (JSC::SharedJITStubSet::PointerTranslator::equal): Deleted. (JSC::SharedJITStubSet::add): Deleted. (JSC::SharedJITStubSet::remove): Deleted. (JSC::SharedJITStubSet::find): Deleted. * Source/JavaScriptCore/heap/Heap.cpp: (JSC::Heap::runEndPhase): * Source/JavaScriptCore/jit/GCAwareJITStubRoutine.cpp: (JSC::PolymorphicAccessJITStubRoutine::observeZeroRefCountImpl): (JSC::PolymorphicAccessJITStubRoutine::computeHash): (JSC::PolymorphicAccessJITStubRoutine::addedToSharedJITStubSet): * Source/JavaScriptCore/jit/GCAwareJITStubRoutine.h: (JSC::PolymorphicAccessJITStubRoutine::hash const): * Source/JavaScriptCore/jit/PolymorphicCallStubRoutine.h: * Source/JavaScriptCore/runtime/CacheableIdentifier.h: * Source/JavaScriptCore/runtime/CacheableIdentifierInlines.h: (JSC::CacheableIdentifier::createFromSharedStub): * Source/JavaScriptCore/runtime/VM.cpp: Canonical link: https://commits.webkit.org/276916@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 122f2b: Try to fix the visionOS build
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 122f2bd05db439925e762f681d12f4128f39e836 https://github.com/WebKit/WebKit/commit/122f2bd05db439925e762f681d12f4128f39e836 Author: Andy Estes Date: 2024-04-01 (Mon, 01 Apr 2024) Changed paths: M Source/WebKit/WebKitSwift/LinearMediaKit/LinearMediaKitExtras.swift Log Message: --- Try to fix the visionOS build https://bugs.webkit.org/show_bug.cgi?id=272007 rdar://125747739 Unreviewed build fix after 276898@main. * Source/WebKit/WebKitSwift/LinearMediaKit/LinearMediaKitExtras.swift: (PlayableViewController.wks_automaticallyDockOnFullScreenPresentation): (PlayableViewController.wks_dismissFullScreenOnExitingDocking): (PlayableViewController.wks_environmentPickerButtonViewController): Canonical link: https://commits.webkit.org/276915@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8ac4fe: [svn-unapply] Remove
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8ac4fe845f71aadd3342c1bb3a063b200614bcbf https://github.com/WebKit/WebKit/commit/8ac4fe845f71aadd3342c1bb3a063b200614bcbf Author: Jonathan Bedard Date: 2024-04-01 (Mon, 01 Apr 2024) Changed paths: R Tools/Scripts/svn-unapply Log Message: --- [svn-unapply] Remove https://bugs.webkit.org/show_bug.cgi?id=271970 rdar://125725240 Reviewed by Ryan Haddad. * Tools/Scripts/svn-unapply: Removed. Canonical link: https://commits.webkit.org/276914@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b1d861: (2) Adopt com.apple.developer.cs.allow-jit entitle...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b1d861f1f579588da2b6d8b13ba5aa138a7afc46 https://github.com/WebKit/WebKit/commit/b1d861f1f579588da2b6d8b13ba5aa138a7afc46 Author: Justin Michaud Date: 2024-04-01 (Mon, 01 Apr 2024) Changed paths: M Source/JavaScriptCore/Scripts/process-entitlements.sh M Source/JavaScriptCore/jit/ExecutableAllocator.cpp M Source/WebKit/Scripts/process-entitlements.sh M Tools/WebKitTestRunner/Configurations/WebKitTestRunner-internal.entitlements M Tools/WebKitTestRunner/Configurations/WebKitTestRunnerApp-iOS.entitlements Log Message: --- (2) Adopt com.apple.developer.cs.allow-jit entitlement for iOS. rdar://122841355 https://bugs.webkit.org/show_bug.cgi?id=270723 Reviewed by Keith Miller. * Source/JavaScriptCore/Scripts/process-entitlements.sh: * Source/JavaScriptCore/jit/ExecutableAllocator.cpp: (JSC::isJITEnabled): (JSC::ExecutableAllocator::disableJIT): * Source/WebKit/Scripts/process-entitlements.sh: * Tools/WebKitTestRunner/Configurations/WebKitTestRunner-internal.entitlements: * Tools/WebKitTestRunner/Configurations/WebKitTestRunnerApp-iOS.entitlements: Canonical link: https://commits.webkit.org/276913@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 866aed: WebCore::ViewportErrorCode should be an enum class
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 866aeddf322dda7c322fee68d93e1df4f03688ab https://github.com/WebKit/WebKit/commit/866aeddf322dda7c322fee68d93e1df4f03688ab Author: Abrar Rahman Protyasha Date: 2024-04-01 (Mon, 01 Apr 2024) Changed paths: M Source/WebCore/dom/ViewportArguments.cpp M Source/WebCore/dom/ViewportArguments.h Log Message: --- WebCore::ViewportErrorCode should be an enum class https://bugs.webkit.org/show_bug.cgi?id=271961 rdar://125713140 Reviewed by Sihui Liu. This patch mechnically transforms ViewportErrorCode to an enum class. * Source/WebCore/dom/ViewportArguments.cpp: (WebCore::numericPrefix): (WebCore::findScaleValue): (WebCore::parseViewportFitValue): (WebCore::viewportErrorMessageTemplate): Use a switch statement instead of mapping the enum cases to array entries. This is also never slower than the status quo, which is a win. (WebCore::viewportErrorMessageLevel): (WebCore::viewportErrorMessage): (WebCore::setViewportFeature): * Source/WebCore/dom/ViewportArguments.h: Canonical link: https://commits.webkit.org/276912@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b3c270: Adding myself as committer.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b3c27068286ec47f570a551ee0e02e93bae9e557 https://github.com/WebKit/WebKit/commit/b3c27068286ec47f570a551ee0e02e93bae9e557 Author: Nitin Mahendru Date: 2024-04-01 (Mon, 01 Apr 2024) Changed paths: M metadata/contributors.json Log Message: --- Adding myself as committer. Reviewed by Jonathan Bedard. Adding my self as a committer. * metadata/contributors.json: Canonical link: https://commits.webkit.org/276911@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8256f2: [Gardening]: NEW TEST(275838@main): [ MacOS ] medi...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8256f2eea4608a34020295bbfde6e361cbd72aa6 https://github.com/WebKit/WebKit/commit/8256f2eea4608a34020295bbfde6e361cbd72aa6 Author: Jay Stfleur Date: 2024-04-01 (Mon, 01 Apr 2024) Changed paths: M LayoutTests/platform/mac/TestExpectations Log Message: --- [Gardening]: NEW TEST(275838@main): [ MacOS ] media/media-source/media-managedmse-noresumeafterpause.html is a flaky failure https://bugs.webkit.org/show_bug.cgi?id=125741544 rdar://125741544 Unreviewed test gardening. Adding test expectation. * LayoutTests/platform/mac/TestExpectations: Canonical link: https://commits.webkit.org/276910@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b682c5: Add Options::maxHeapSizeAsRAMSizeMultiple() to lim...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b682c5819552ef9e414bf652ba4a65c36aea6871 https://github.com/WebKit/WebKit/commit/b682c5819552ef9e414bf652ba4a65c36aea6871 Author: Mark Lam Date: 2024-04-01 (Mon, 01 Apr 2024) Changed paths: M Source/JavaScriptCore/heap/CompleteSubspace.cpp M Source/JavaScriptCore/jsc.cpp M Source/JavaScriptCore/runtime/OptionsList.h Log Message: --- Add Options::maxHeapSizeAsRAMSizeMultiple() to limit max memory usage for testing. https://bugs.webkit.org/show_bug.cgi?id=271986 rdar://125733077 Reviewed by Keith Miller. Currently, we're only applying this max check to CompleteSubspace::tryAllocateSlow. We found that adding it to LocalAllocator::allocateSlowCase can cause crashes due to failed Structure allocations (which are fatal). As a result, the testing disruption from those crashes far outweigh any benefits we currently get from it. So, we'll leave the max check out of LocalAllocator::allocateSlowCase for now. * Source/JavaScriptCore/heap/CompleteSubspace.cpp: (JSC::CompleteSubspace::tryAllocateSlow): * Source/JavaScriptCore/jsc.cpp: (jscmain): * Source/JavaScriptCore/runtime/OptionsList.h: Canonical link: https://commits.webkit.org/276909@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4c3661: VisibleContentRectIncludesScrollbars should be an ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4c3661f361f0797accb21d8fd40634781f98 https://github.com/WebKit/WebKit/commit/4c3661f361f0797accb21d8fd40634781f98 Author: Abrar Rahman Protyasha Date: 2024-04-01 (Mon, 01 Apr 2024) Changed paths: M Source/WebCore/platform/ScrollView.cpp M Source/WebCore/platform/ScrollView.h M Source/WebCore/platform/ScrollableArea.cpp M Source/WebCore/platform/ScrollableArea.h M Source/WebCore/rendering/RenderLayerScrollableArea.cpp Log Message: --- VisibleContentRectIncludesScrollbars should be an enum class https://bugs.webkit.org/show_bug.cgi?id=271919 rdar://125636091 Reviewed by Simon Fraser. This patch performs a mechanical `enum class`-ification of VisibleContentRectIncludesScrollbars. It also renames the enum cases from ExcludeScrollbars/IncludeScrollbars to No/Yes respectively, since that conveys the same information but reads better. * Source/WebCore/platform/ScrollView.cpp: (WebCore::ScrollView::sizeForVisibleContent const): (WebCore::ScrollView::sizeForUnobscuredContent const): (WebCore::ScrollView::visibleContentRectInternal const): * Source/WebCore/platform/ScrollView.h: (WebCore::ScrollView::unobscuredContentRectIncludingScrollbars const): * Source/WebCore/platform/ScrollableArea.cpp: (WebCore::ScrollableArea::visibleContentRect const): (WebCore::ScrollableArea::visibleContentRectIncludingScrollbars const): (WebCore::ScrollableArea::visibleContentRectInternal const): * Source/WebCore/platform/ScrollableArea.h: * Source/WebCore/rendering/RenderLayerScrollableArea.cpp: (WebCore::RenderLayerScrollableArea::visibleContentRectInternal const): Canonical link: https://commits.webkit.org/276908@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7f781d: [safe-merge-queue] Add JSC checks
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7f781d27db43bf49ef20bf2f852caf9194003b0d https://github.com/WebKit/WebKit/commit/7f781d27db43bf49ef20bf2f852caf9194003b0d Author: Brianna Fan Date: 2024-04-01 (Mon, 01 Apr 2024) Changed paths: M Tools/CISupport/ews-build/steps.py Log Message: --- [safe-merge-queue] Add JSC checks https://bugs.webkit.org/show_bug.cgi?id=271996 rdar://125189163 Reviewed by Jonathan Bedard. Adds 'jsc' and 'jsc-arm64' to the list of MacOS tests. * Tools/CISupport/ews-build/steps.py: (CheckStatusOfPR): (CheckStatusOfPR.checkPRStatus): Canonical link: https://commits.webkit.org/276907@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 0b216b: REGRESSION(276827@main) Retain frame request queue...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0b216b7fee1af5547c9b478998c8ea3c412e6489 https://github.com/WebKit/WebKit/commit/0b216b7fee1af5547c9b478998c8ea3c412e6489 Author: Alex Christensen Date: 2024-04-01 (Mon, 01 Apr 2024) Changed paths: A LayoutTests/fast/images/protected-image-queue-expected.txt A LayoutTests/fast/images/protected-image-queue.html M Source/WebCore/platform/graphics/ImageFrameWorkQueue.cpp Log Message: --- REGRESSION(276827@main) Retain frame request queue in ImageFrameWorkQueue::start https://bugs.webkit.org/show_bug.cgi?id=271979 rdar://125721264 Reviewed by Said Abou-Hallawa. Protecting the ImageFrameWorkQueue is not sufficient because the RequestQueue can be deallocated separately. Restore the protection of the queue. * LayoutTests/fast/images/protected-image-queue-expected.txt: Added. * LayoutTests/fast/images/protected-image-queue.html: Added. * Source/WebCore/platform/graphics/ImageFrameWorkQueue.cpp: (WebCore::ImageFrameWorkQueue::start): Canonical link: https://commits.webkit.org/276906@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 2014df: Add filter-jsc-tests script to minimize buildbot l...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2014dfcb806ae9931de566a45e5c04a07abf8a1b https://github.com/WebKit/WebKit/commit/2014dfcb806ae9931de566a45e5c04a07abf8a1b Author: Brianna Fan Date: 2024-04-01 (Mon, 01 Apr 2024) Changed paths: A Tools/Scripts/filter-jsc-tests.py Log Message: --- Add filter-jsc-tests script to minimize buildbot logging https://bugs.webkit.org/show_bug.cgi?id=271973 rdar://125726551 Reviewed by Jonathan Bedard. This script returns logs only after all tests have finished. Full logs are saved in a text file to be uploaded to S3 through Buildbot. * Tools/Scripts/filter-jsc-tests.py: Added. (parser): (filter_jsc_test): (main): Canonical link: https://commits.webkit.org/276905@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1ff045: [JSC] `Function.prototype.toString` should print `...
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 1ff045b365bb63494783062033d5ef8a0c629cb7
https://github.com/WebKit/WebKit/commit/1ff045b365bb63494783062033d5ef8a0c629cb7
Author: Sosuke Suzuki
Date: 2024-04-01 (Mon, 01 Apr 2024)
Changed paths:
A JSTests/stress/function-toString-for-accessor-properties.js
M
LayoutTests/imported/w3c/web-platform-tests/html/dom/idlharness.https_include=(Document_Window)-expected.txt
M LayoutTests/js/basic-strict-mode-expected.txt
M LayoutTests/js/dom/native-bindings-descriptors-expected.txt
M LayoutTests/js/dom/native-bindings-descriptors.html
M LayoutTests/js/script-tests/basic-strict-mode.js
M LayoutTests/js/script-tests/function-toString-vs-name.js
M
LayoutTests/platform/glib/imported/w3c/web-platform-tests/html/dom/idlharness.https_include=(Document_Window)-expected.txt
M
LayoutTests/platform/gtk/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt
M
LayoutTests/platform/ipad/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt
M
LayoutTests/platform/wpe/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt
M Source/JavaScriptCore/runtime/JSCustomGetterFunction.cpp
M Source/JavaScriptCore/runtime/JSCustomSetterFunction.cpp
Log Message:
---
[JSC] `Function.prototype.toString` should print `set` / `get` for accessor
properties
https://bugs.webkit.org/show_bug.cgi?id=271946
Reviewed by Alexey Shvayka.
`Function.prototype.toString` should output strings like `function get foo() {
[native code] }` or `function set foo() { [native code] }` for accessor
properties[1].
However, for some properties such as `RegExp.input`, JSC currently outputs
`function foo() { [native code] }` as if it were a regular function.
This patch changes `Function.prototype.toString` to output `get` or `set` for
those accessor properties.
[1]: https://tc39.es/ecma262/#sec-function.prototype.tostring
* JSTests/stress/function-toString-for-accessor-properties.js: Added.
(assertNativeGetter):
(assertNativeSetter):
(wellKnownIntrinsicObjects.forEach):
*
LayoutTests/imported/w3c/web-platform-tests/html/dom/idlharness.https_include=(Document_Window)-expected.txt:
* LayoutTests/js/basic-strict-mode-expected.txt:
* LayoutTests/js/dom/native-bindings-descriptors-expected.txt:
* LayoutTests/js/dom/native-bindings-descriptors.html:
* LayoutTests/js/script-tests/basic-strict-mode.js:
* LayoutTests/js/script-tests/function-toString-vs-name.js:
*
LayoutTests/platform/glib/imported/w3c/web-platform-tests/html/dom/idlharness.https_include=(Document_Window)-expected.txt:
*
LayoutTests/platform/gtk/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:
*
LayoutTests/platform/ipad/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:
*
LayoutTests/platform/wpe/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:
* Source/JavaScriptCore/runtime/JSCustomGetterFunction.cpp:
(JSC::JSCustomGetterFunction::create):
* Source/JavaScriptCore/runtime/JSCustomSetterFunction.cpp:
(JSC::JSCustomSetterFunction::create):
Canonical link: https://commits.webkit.org/276904@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e8b59e: Clean up inline jit permissions macros (2)
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e8b59ec70b6894b1d59f46fe2db16954ed3ae9c7 https://github.com/WebKit/WebKit/commit/e8b59ec70b6894b1d59f46fe2db16954ed3ae9c7 Author: Justin Michaud Date: 2024-04-01 (Mon, 01 Apr 2024) Changed paths: M Source/JavaScriptCore/Configurations/Base.xcconfig M Source/WTF/wtf/PlatformUse.h M Source/WebCore/Configurations/WebCore.xcconfig Log Message: --- Clean up inline jit permissions macros (2) https://bugs.webkit.org/show_bug.cgi?id=270937 rdar://125616477 Reviewed by Mark Lam. Clean up inline jit permissions macros (2). * Source/WTF/wtf/PlatformUse.h: Canonical link: https://commits.webkit.org/276903@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 34d1f9: REGRESSION (276827@main): When drawing a pattern, ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 34d1f9aabb7b81a29b2a314e2a939c358bb655a1 https://github.com/WebKit/WebKit/commit/34d1f9aabb7b81a29b2a314e2a939c358bb655a1 Author: Said Abou-Hallawa Date: 2024-04-01 (Mon, 01 Apr 2024) Changed paths: M Source/WebCore/platform/graphics/BitmapImageSource.cpp Log Message: --- REGRESSION (276827@main): When drawing a pattern, get the oriented image frame only if the orientation is not TopLeft https://bugs.webkit.org/show_bug.cgi?id=271977 rdar://125731142 Reviewed by Mike Wyrzykowski. If the passed orientation is FromImage, resolve the current orientation before checking its value to the oriented ImageFrame. * Source/WebCore/platform/graphics/BitmapImageSource.cpp: (WebCore::BitmapImageSource::preTransformedNativeImageAtIndex): Canonical link: https://commits.webkit.org/276902@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1e57d2: [Cocoa] Provide hints to CFNetwork for network tra...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1e57d2b564fd1e0829b164467c080fc54448e1d5 https://github.com/WebKit/WebKit/commit/1e57d2b564fd1e0829b164467c080fc54448e1d5 Author: Brent Fulgham Date: 2024-04-01 (Mon, 01 Apr 2024) Changed paths: M Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm Log Message: --- [Cocoa] Provide hints to CFNetwork for network traffic class https://bugs.webkit.org/show_bug.cgi?id=271920 Reviewed by Jer Noble and Eric Carlson. In Bug 254072 we started setting the traffic class for network activity in WebRTC operations. We should take the same action when we know we are making high (or low) priority requests to the network system so it can do a better job of routing packets and organizing connections. * Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm: (WebKit::adjustNetworkServiceTypeIfNecessary): Added helper. (WebKit::NetworkDataTaskCocoa::NetworkDataTaskCocoa): Canonical link: https://commits.webkit.org/276901@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e7c378: [Gardening]: [ iOS ] imported/w3c/web-platform-tes...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e7c378a1ff38773f02a2866aceaf06e66f555e70 https://github.com/WebKit/WebKit/commit/e7c378a1ff38773f02a2866aceaf06e66f555e70 Author: Jay Stfleur Date: 2024-04-01 (Mon, 01 Apr 2024) Changed paths: M LayoutTests/platform/ios/TestExpectations Log Message: --- [Gardening]: [ iOS ] imported/w3c/web-platform-tests/css/css-transforms/transform3d-preserve3d-001.html is a consistent failure https://bugs.webkit.org/show_bug.cgi?id=125737538 rdar://125737538 Unreviewed test gardening. Adding test expectation. * LayoutTests/platform/ios/TestExpectations: Canonical link: https://commits.webkit.org/276900@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 59e3dc: [build.webkit.org] Upload webdriver-test logs to S3
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 59e3dc4d06aabd8dd2dbe98729d4b15cb8c2577c https://github.com/WebKit/WebKit/commit/59e3dc4d06aabd8dd2dbe98729d4b15cb8c2577c Author: Brianna Fan Date: 2024-04-01 (Mon, 01 Apr 2024) Changed paths: M Tools/CISupport/build-webkit-org/steps.py M Tools/CISupport/build-webkit-org/steps_unittest.py Log Message: --- [build.webkit.org] Upload webdriver-test logs to S3 https://bugs.webkit.org/show_bug.cgi?id=270676 rdar://124653833 Reviewed by Aakash Jain. Pipe webdriver test logs and upload the file to S3. Set a higher timeout since there's no continuous logging on Buildbot. * Tools/CISupport/build-webkit-org/steps.py: (RunWebDriverTests.__init__): (RunWebDriverTests.run): * Tools/CISupport/build-webkit-org/steps_unittest.py: Canonical link: https://commits.webkit.org/276899@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ea7c4f: [visionOS] When entering video fullscreen from ele...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ea7c4f2a062104518cc5f1eb6dddcd489392d1d7 https://github.com/WebKit/WebKit/commit/ea7c4f2a062104518cc5f1eb6dddcd489392d1d7 Author: Andy Estes Date: 2024-04-01 (Mon, 01 Apr 2024) Changed paths: M Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj R Source/WebCore/PAL/pal/spi/vision/LinearMediaKitSPI.h M Source/WebCore/platform/ios/VideoPresentationInterfaceIOS.h M Source/WebKit/Platform/ios/PlaybackSessionInterfaceLMK.mm M Source/WebKit/Platform/ios/VideoPresentationInterfaceLMK.h M Source/WebKit/Platform/ios/VideoPresentationInterfaceLMK.mm M Source/WebKit/UIProcess/Cocoa/VideoPresentationManagerProxy.h M Source/WebKit/UIProcess/Cocoa/VideoPresentationManagerProxy.mm M Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm M Source/WebKit/WebKit.xcodeproj/project.pbxproj A Source/WebKit/WebKitSwift/LinearMediaKit/LinearMediaKitExtras.h A Source/WebKit/WebKitSwift/LinearMediaKit/LinearMediaKitExtras.swift A Source/WebKit/WebKitSwift/LinearMediaKit/LinearMediaKitSPI.h M Source/WebKit/WebKitSwift/WebKitSwift.h Log Message: --- [visionOS] When entering video fullscreen from element fullscreen, go directly to docked mode https://bugs.webkit.org/show_bug.cgi?id=271922 rdar://123529719 Reviewed by Jer Noble. Updated WKFullScreenViewController to insert LMPlayableViewController's environmentPickerButtonView into the fullscreen controls stack view, replacing the placeholder button we had before, and to set properties on the LMPlayableViewController saying that it should dock when entering fullscreen and exit video fullscreen when undocking (thus returning to element fullscreen directly). * Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj: * Source/WebCore/platform/ios/VideoPresentationInterfaceIOS.h: (WebCore::VideoPresentationInterfaceIOS::playableViewController): * Source/WebKit/Platform/ios/PlaybackSessionInterfaceLMK.mm: (-[WKLinearMediaPlayerDelegate linearMediaPlayerToggleInlineMode:]): (-[WKLinearMediaPlayerDelegate linearMediaPlayerWillEnterFullscreen:]): (-[WKLinearMediaPlayerDelegate linearMediaPlayerWillExitFullscreen:]): (-[WKLinearMediaPlayerDelegate _exitFullscreen]): * Source/WebKit/Platform/ios/VideoPresentationInterfaceLMK.h: * Source/WebKit/Platform/ios/VideoPresentationInterfaceLMK.mm: (WebKit::VideoPresentationInterfaceLMK::setupPlayerViewController): (WebKit::VideoPresentationInterfaceLMK::playableViewController): (WebKit::VideoPresentationInterfaceLMK::ensurePlayableViewController): * Source/WebKit/UIProcess/Cocoa/VideoPresentationManagerProxy.h: * Source/WebKit/UIProcess/Cocoa/VideoPresentationManagerProxy.mm: (WebKit::VideoPresentationManagerProxy::playableViewController const): * Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm: (-[WKFullScreenViewController videoControlsManagerDidChange]): (-[WKFullScreenViewController _configureEnvironmentPickerButtonViewWithPlayableViewController:]): (-[WKFullScreenViewController loadView]): (-[WKFullScreenViewController _enterVideoFullscreenAction:]): Deleted. * Source/WebKit/WebKit.xcodeproj/project.pbxproj: * Source/WebKit/WebKitSwift/LinearMediaKit/LinearMediaKitExtras.h: Copied from Source/WebCore/PAL/pal/spi/vision/LinearMediaKitSPI.h. * Source/WebKit/WebKitSwift/LinearMediaKit/LinearMediaKitExtras.swift: Added. (PlayableViewController.wks_automaticallyDockOnFullScreenPresentation): (PlayableViewController.wks_dismissFullScreenOnExitingDocking): (PlayableViewController.wks_environmentPickerButtonViewController): * Source/WebKit/WebKitSwift/LinearMediaKit/LinearMediaKitSPI.h: Renamed from Source/WebCore/PAL/pal/spi/vision/LinearMediaKitSPI.h. * Source/WebKit/WebKitSwift/WebKitSwift.h: Canonical link: https://commits.webkit.org/276898@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7c1699: [Gardening]: REGRESSION (276404@main): [ iOS ] imp...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7c1699784a6bf29f75119db3f3f05b00a63b79fa https://github.com/WebKit/WebKit/commit/7c1699784a6bf29f75119db3f3f05b00a63b79fa Author: Jay Stfleur Date: 2024-04-01 (Mon, 01 Apr 2024) Changed paths: M LayoutTests/platform/ios/TestExpectations Log Message: --- [Gardening]: REGRESSION (276404@main): [ iOS ] imported/w3c/web-platform-tests/mathml/relations/html5-tree/dynamic-childlist-002.html is a constant failure https://bugs.webkit.org/show_bug.cgi?id=125735500 rdar://125735500 Unreviewed test gardening. Adding test expectation. * LayoutTests/platform/ios/TestExpectations: Canonical link: https://commits.webkit.org/276897@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1b32d0: [svn-apply-patch] Replace patch application with git
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1b32d05f1db0f73999a36ffd03ebfd63a8674d1b https://github.com/WebKit/WebKit/commit/1b32d05f1db0f73999a36ffd03ebfd63a8674d1b Author: Jonathan Bedard Date: 2024-04-01 (Mon, 01 Apr 2024) Changed paths: M Tools/Scripts/webkitpy/common/checkout/checkout.py M Tools/Scripts/webkitpy/common/checkout/checkout_unittest.py Log Message: --- [svn-apply-patch] Replace patch application with git https://bugs.webkit.org/show_bug.cgi?id=271975 rdar://125728253 Reviewed by Ryan Haddad. * Tools/Scripts/webkitpy/common/checkout/checkout.py: (apply_patch): Always use 'git' to apply patch. * Tools/Scripts/webkitpy/common/checkout/checkout_unittest.py: (CheckoutTest.test_apply_patch): Canonical link: https://commits.webkit.org/276896@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b52f2b: REGRESSION (273461@main): The value attribute is n...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b52f2b8abac2656e9e7e1c3ca3748e4f4650bded https://github.com/WebKit/WebKit/commit/b52f2b8abac2656e9e7e1c3ca3748e4f4650bded Author: Aditya Keerthi Date: 2024-04-01 (Mon, 01 Apr 2024) Changed paths: A LayoutTests/fast/forms/email-input-type-value-and-multiple-attributes-set-expected.html A LayoutTests/fast/forms/email-input-type-value-and-multiple-attributes-set.html M Source/WebCore/html/EmailInputType.cpp Log Message: --- REGRESSION (273461@main): The value attribute is not displayed in an input field with type="email" and multiple attributes https://bugs.webkit.org/show_bug.cgi?id=271043 rdar://125221858 Reviewed by Ryosuke Niwa. 273461@main deferred input element shadow tree construction outside of attribute parsing. However, when combined with an earlier change to sanitize the value of email inputs when the multiple attribute is set (263555@main), the deferral of shadow tree construction results in the value not being displayed at all. The root cause of the issue is the use of `setValueFromRenderer` introduced by 263555@main. The use of that method in `EmailInputType::attributeChanged` has always been inappropriate, as it is specifically meant for user modifications. However, in this case, the problem arises from the fact that `setValueFromRenderer` calls `setFormControlValueMatchesRenderer(true)`. This results in the elision of shadow tree construction in `TextFieldInputType::updateInnerTextValue`, as `HTMLTextFormControlElement::setInnerTextValue` is only called if `formControlValueMatchesRenderer()` returns false. Before 273461@main, this elision was benign, as the shadow tree was constructed at attribute parse time. Fix by using a more appropriate method to update the email input's value when the multiple attribute is changed. A new regression test is added. The coverage for the issue fixed by 263555@main continues to be provided by the WPT: html/semantics/forms/the-input-element/email.html. * LayoutTests/fast/forms/email-input-type-value-and-multiple-attributes-set-expected.html: Added. * LayoutTests/fast/forms/email-input-type-value-and-multiple-attributes-set.html: Added. * Source/WebCore/html/EmailInputType.cpp: (WebCore::EmailInputType::attributeChanged): Canonical link: https://commits.webkit.org/276895@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 442e56: Security key doesn't show up when allowCredentials...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 442e5675cbb3f411a08db3c8bc4b9ed0afdfb95a https://github.com/WebKit/WebKit/commit/442e5675cbb3f411a08db3c8bc4b9ed0afdfb95a Author: Pascoe Date: 2024-04-01 (Mon, 01 Apr 2024) Changed paths: M Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm Log Message: --- Security key doesn't show up when allowCredentials transports contain "Internal" https://bugs.webkit.org/show_bug.cgi?id=271805 rdar://124265507 Reviewed by Brent Fulgham. This condition was written wrong. We should submit a cross-platform request if transports are empty, or if they contain any transport that is not "Internal" or "Hybrid," which are both considered platform requests by system API. * Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm: (WebKit::WebAuthenticatorCoordinatorProxy::requestsForAssertion): Canonical link: https://commits.webkit.org/276894@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4eac11: Remove ENABLE_AVF_CAPTIONS build flag
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4eac1165b63168227db2518a21d3ac1b561c999e https://github.com/WebKit/WebKit/commit/4eac1165b63168227db2518a21d3ac1b561c999e Author: Eric Carlson Date: 2024-04-01 (Mon, 01 Apr 2024) Changed paths: M Source/WTF/wtf/PlatformEnableCocoa.h M Source/WebCore/html/HTMLMediaElement.cpp M Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp M Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h M Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h M Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm M Source/WebCore/platform/graphics/avfoundation/objc/OutOfBandTextTrackPrivateAVF.h M Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.cpp M Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.h M Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxyConfiguration.h M Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxyConfiguration.serialization.in M Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp M Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.h M Source/WebKit/WebProcess/GPU/media/RemoteMediaPlayerManager.cpp Log Message: --- Remove ENABLE_AVF_CAPTIONS build flag https://bugs.webkit.org/show_bug.cgi?id=271964 rdar://125716661 Reviewed by Andy Estes. Remove `#if ENABLE(AVF_CAPTIONS)` in all Cocoa-only files and replace it with `#if PLATFORM(COCOA)` in cross platform files. * Source/WTF/wtf/PlatformEnableCocoa.h: * Source/WebCore/html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::textTrackModeChanged): * Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp: (WebCore::MediaPlayerPrivateAVFoundation::configureInbandTracks): (WebCore::MediaPlayerPrivateAVFoundation::processNewAndRemovedTextTracks): * Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h: (WebCore::MediaPlayerPrivateAVFoundation::synchronizeTextTrackState): * Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h: * Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm: (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL): (WebCore::MediaPlayerPrivateAVFoundationObjC::processMediaSelectionOptions): (WebCore::MediaPlayerPrivateAVFoundationObjC::setCurrentTextTrack): * Source/WebCore/platform/graphics/avfoundation/objc/OutOfBandTextTrackPrivateAVF.h: * Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.cpp: (WebKit::RemoteMediaPlayerProxy::notifyTrackModeChanged): * Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.h: * Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxyConfiguration.h: * Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxyConfiguration.serialization.in: * Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp: (WebKit::MediaPlayerPrivateRemote::notifyTrackModeChanged): * Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.h: * Source/WebKit/WebProcess/GPU/media/RemoteMediaPlayerManager.cpp: (WebKit::RemoteMediaPlayerManager::createRemoteMediaPlayer): Canonical link: https://commits.webkit.org/276893@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1bdb61: Use std::span more in API::Data
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1bdb6178d5efa27906f1f2dba0796fa01aa63483 https://github.com/WebKit/WebKit/commit/1bdb6178d5efa27906f1f2dba0796fa01aa63483 Author: Chris Dumez Date: 2024-04-01 (Mon, 01 Apr 2024) Changed paths: M Source/WebKit/Platform/IPC/Encoder.h M Source/WebKit/Platform/IPC/SharedBufferReference.h M Source/WebKit/Shared/API/APIData.cpp M Source/WebKit/Shared/API/APIData.h M Source/WebKit/Shared/API/Cocoa/WKRemoteObjectCoder.mm M Source/WebKit/Shared/API/c/WKData.cpp M Source/WebKit/Shared/APIWebArchive.mm M Source/WebKit/Shared/APIWebArchiveResource.mm M Source/WebKit/Shared/Cocoa/APIDataCocoa.mm M Source/WebKit/UIProcess/API/APIWebAuthenticationAssertionResponse.cpp M Source/WebKit/UIProcess/API/C/curl/WKProtectionSpaceCurl.cpp M Source/WebKit/UIProcess/API/glib/WebKitWebResource.cpp M Source/WebKit/UIProcess/Downloads/DownloadProxy.cpp M Source/WebKit/UIProcess/LegacySessionStateCodingNone.cpp M Source/WebKit/UIProcess/WebPageProxy.cpp M Source/WebKit/UIProcess/mac/LegacySessionStateCoding.cpp M Source/WebKit/WebProcess/InjectedBundle/InjectedBundle.cpp M Source/WebKit/WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp Log Message: --- Use std::span more in API::Data https://bugs.webkit.org/show_bug.cgi?id=271966 Reviewed by Brent Fulgham. * Source/WebKit/Platform/IPC/SharedBufferReference.h: (IPC::SharedBufferReference::span const): * Source/WebKit/Shared/API/APIData.cpp: (API::Data::create): Deleted. * Source/WebKit/Shared/API/APIData.h: (API::Data::createWithoutCopying): (API::Data::create): * Source/WebKit/Shared/API/Cocoa/WKRemoteObjectCoder.mm: (-[WKRemoteObjectEncoder encodeBytes:length:forKey:]): * Source/WebKit/Shared/API/c/WKData.cpp: (WKDataCreate): * Source/WebKit/Shared/APIWebArchive.mm: (API::releaseWebArchiveData): (API::WebArchive::data): * Source/WebKit/Shared/APIWebArchiveResource.mm: (API::releaseWebArchiveResourceData): (API::WebArchiveResource::data): * Source/WebKit/Shared/Cocoa/APIDataCocoa.mm: (API::Data::createWithoutCopying): * Source/WebKit/UIProcess/API/APIWebAuthenticationAssertionResponse.cpp: (API::WebAuthenticationAssertionResponse::userHandle const): (API::WebAuthenticationAssertionResponse::credentialID const): * Source/WebKit/UIProcess/Downloads/DownloadProxy.cpp: (WebKit::createData): * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::CompletionHandlerhttps://commits.webkit.org/276892@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 10f34f: Remove unprefixed alias for `:-apple-has-attachment`
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 10f34fe951c3328131a08b66ced3e81dc8eda1d4 https://github.com/WebKit/WebKit/commit/10f34fe951c3328131a08b66ced3e81dc8eda1d4 Author: Tim Nguyen Date: 2024-04-01 (Mon, 01 Apr 2024) Changed paths: M Source/WebCore/css/CSSPseudoSelectors.json Log Message: --- Remove unprefixed alias for `:-apple-has-attachment` https://bugs.webkit.org/show_bug.cgi?id=271947 rdar://125675445 Reviewed by Aditya Keerthi. Now that internal usages have adopted `:-apple-has-attachment`, we can remove the `:has-attachment` alias. * Source/WebCore/css/CSSPseudoSelectors.json: Canonical link: https://commits.webkit.org/276891@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ed9218: [UnifiedPDF] Zoom out doesn't go out far enough wi...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ed9218bd94b98544ebaa74c34f2810a73dafd012 https://github.com/WebKit/WebKit/commit/ed9218bd94b98544ebaa74c34f2810a73dafd012 Author: Simon Fraser Date: 2024-04-01 (Mon, 01 Apr 2024) Changed paths: M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm Log Message: --- [UnifiedPDF] Zoom out doesn't go out far enough with keyboard zoom https://bugs.webkit.org/show_bug.cgi?id=271937 rdar://125386166 Reviewed by Tim Horton. Internally, UnifiedPDFPlugin would adjust m_scaleFactor based on window-fitting and other behaviors for the correct layout. However, the value exposed to clients was somewhat arbitrary; m_scaleFactor==1 meant "fit to window", not "actual size". This meant that the behavior of "Actual Size" from the PDF context menu was different to "Actual Size" in the Safari menus, which just called `setPageScaleFactor(1)`, and Command-+ and Command-- wouldn't work as expected. Fix by computing a normalization factor so that the exposed scale factor is `1` for actual size. * Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h: * Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm: (WebKit::UnifiedPDFPlugin::computeNormalizationFactor): (WebKit::UnifiedPDFPlugin::fromNormalizedScaleFactor const): (WebKit::UnifiedPDFPlugin::toNormalizedScaleFactor const): (WebKit::UnifiedPDFPlugin::scaleFactor const): (WebKit::UnifiedPDFPlugin::setScaleFactor): (WebKit::UnifiedPDFPlugin::setPageScaleFactor): (WebKit::UnifiedPDFPlugin::updateLayout): Canonical link: https://commits.webkit.org/276890@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] df2cc0: Drop String::fromUTF8() overloads taking in a raw ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: df2cc0871eec5de263ca9f20816ef2afcc7b359a https://github.com/WebKit/WebKit/commit/df2cc0871eec5de263ca9f20816ef2afcc7b359a Author: Chris Dumez Date: 2024-04-01 (Mon, 01 Apr 2024) Changed paths: M Source/JavaScriptCore/API/glib/JSCContext.cpp M Source/JavaScriptCore/API/glib/JSCValue.cpp M Source/JavaScriptCore/debugger/DebuggerScope.cpp M Source/JavaScriptCore/jsc.cpp M Source/JavaScriptCore/parser/Lexer.cpp M Source/JavaScriptCore/profiler/ProfilerBytecode.cpp M Source/JavaScriptCore/profiler/ProfilerBytecodeSequence.cpp M Source/JavaScriptCore/profiler/ProfilerBytecodes.cpp M Source/JavaScriptCore/profiler/ProfilerCompilation.cpp M Source/JavaScriptCore/profiler/ProfilerCompiledBytecode.cpp M Source/JavaScriptCore/profiler/ProfilerEvent.cpp M Source/JavaScriptCore/runtime/SamplingProfiler.cpp M Source/JavaScriptCore/tools/FunctionAllowlist.cpp M Source/JavaScriptCore/wasm/WasmSectionParser.cpp M Source/JavaScriptCore/wasm/js/JSWebAssemblyInstance.cpp M Source/JavaScriptCore/wasm/js/JSWebAssemblyModule.cpp M Source/JavaScriptCore/wasm/js/WebAssemblyModuleRecord.cpp M Source/WTF/wtf/StringPrintStream.cpp M Source/WTF/wtf/URL.cpp M Source/WTF/wtf/URLParser.cpp M Source/WTF/wtf/URLParser.h M Source/WTF/wtf/cocoa/FileSystemCocoa.mm M Source/WTF/wtf/text/WTFString.cpp M Source/WTF/wtf/text/WTFString.h M Source/WebCore/Modules/applepay/cocoa/PaymentCocoa.mm M Source/WebCore/Modules/async-clipboard/ClipboardItemBindingsDataSource.cpp M Source/WebCore/Modules/encryptedmedia/legacy/LegacyCDMSessionClearKey.cpp M Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.cpp M Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCDataChannelHandler.cpp M Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp M Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCUtils.h M Source/WebCore/Modules/webauthn/cbor/CBORReader.cpp M Source/WebCore/Modules/websockets/WebSocketExtensionParser.cpp M Source/WebCore/Modules/webtransport/WebTransport.cpp M Source/WebCore/PAL/pal/crypto/commoncrypto/CryptoDigestCommonCrypto.cpp M Source/WebCore/bridge/IdentifierRep.cpp M Source/WebCore/contentextensions/ContentExtensionActions.cpp M Source/WebCore/contentextensions/ContentExtensionStringSerialization.cpp M Source/WebCore/css/parser/CSSPropertyParserWorkerSafe.cpp M Source/WebCore/editing/cocoa/WebContentReaderCocoa.mm M Source/WebCore/html/parser/AtomHTMLToken.h M Source/WebCore/html/parser/HTMLTreeBuilder.cpp M Source/WebCore/inspector/agents/InspectorNetworkAgent.cpp M Source/WebCore/page/linux/ResourceUsageThreadLinux.cpp M Source/WebCore/platform/LocalizedStrings.cpp M Source/WebCore/platform/SharedBufferChunkReader.cpp M Source/WebCore/platform/generic/KeyedDecoderGeneric.cpp M Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp M Source/WebCore/platform/gtk/PasteboardGtk.cpp M Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCDTMFSenderBackend.cpp M Source/WebCore/platform/mock/RTCDataChannelHandlerMock.cpp M Source/WebCore/platform/network/HTTPParsers.cpp M Source/WebCore/platform/network/curl/ResourceResponseCurl.cpp M Source/WebCore/platform/network/soup/NetworkStorageSessionSoup.cpp M Source/WebCore/platform/network/soup/ResourceResponseSoup.cpp M Source/WebCore/platform/sql/SQLiteFileSystem.cpp M Source/WebCore/platform/sql/SQLiteStatement.cpp M Source/WebCore/xml/parser/XMLDocumentParser.cpp M Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp M Source/WebDriver/WebDriverService.cpp M Source/WebDriver/socket/HTTPParser.cpp M Source/WebKit/NetworkProcess/PrivateClickMeasurement/cocoa/PrivateClickMeasurementNetworkLoaderCocoa.mm M Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.cpp M Source/WebKit/NetworkProcess/curl/WebSocketTaskCurl.cpp M Source/WebKit/UIProcess/API/glib/WebKitUserContentFilterStore.cpp M Source/WebKit/UIProcess/API/glib/WebKitWebContext.cpp M Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp M Source/WebKit/UIProcess/API/glib/WebKitWebsiteDataManager.cpp M Source/WebKit/UIProcess/API/gtk/DropTargetGtk3.cpp M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm M Source/WebKit/UIProcess/Inspector/glib/RemoteInspectorHTTPServer.cpp M Source/WebKit/WebProcess/GPU/webrtc/LibWebRTCCodecs.cpp M Source/WebKit/WebProcess/Network/webrtc/LibWebRTCNetworkManager.cpp M Source/WebKit/WebProcess/Network/webrtc/RTCDataChannelRemoteManager.cpp M Source/WebKitLegacy/WebCoreSupport/WebSocketChannel.cpp M Tools/DumpRenderTree/mac/DumpRenderTree.mm M Tools/TestWebKitAPI/Tests/WTF/URLParser.cpp M Tools/TestWebKitAPI/Tests/WebKitCocoa/MediaL
[webkit-changes] [WebKit/WebKit] 2f857b: Add more quirks for `consent.google.*` when applyi...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2f857be7d42f00feb7b59870709310154181a774 https://github.com/WebKit/WebKit/commit/2f857be7d42f00feb7b59870709310154181a774 Author: Wenson Hsieh Date: 2024-04-01 (Mon, 01 Apr 2024) Changed paths: M Source/WebKit/NetworkProcess/cocoa/NetworkTaskCocoa.mm Log Message: --- Add more quirks for `consent.google.*` when applying the third party IP address cookie expiry cap https://bugs.webkit.org/show_bug.cgi?id=271952 rdar://122811153 Reviewed by John Wilander. Add a couple more quirks for requests to `consent.google.*` and `consent.youtube.com`, when checking whether we should apply the cookie expiration cap for requests coming from potential third party IP addresses. * Source/WebKit/NetworkProcess/cocoa/NetworkTaskCocoa.mm: (WebKit::NetworkTaskCocoa::applyCookiePolicyForThirdPartyCloaking): Clean up this capture block, so that the individual captured variables are much easier to read. Canonical link: https://commits.webkit.org/276888@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f088b4: [Skia] Use gtk_widget_queue_draw_region() for Page...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f088b437f4e1a06b18f09812f2662e93f090c9f7 https://github.com/WebKit/WebKit/commit/f088b437f4e1a06b18f09812f2662e93f090c9f7 Author: Patrick Griffis Date: 2024-04-01 (Mon, 01 Apr 2024) Changed paths: M Source/WebCore/platform/graphics/cairo/CairoUtilities.cpp M Source/WebCore/platform/graphics/cairo/CairoUtilities.h M Source/WebKit/UIProcess/API/gtk/PageClientImpl.cpp Log Message: --- [Skia] Use gtk_widget_queue_draw_region() for PageClientImpl::setViewNeedsDisplay in GTK3 https://bugs.webkit.org/show_bug.cgi?id=271955 Reviewed by Carlos Garcia Campos. Just moves around the helper function that was only used in this location. * Source/WebCore/platform/graphics/cairo/CairoUtilities.cpp: (WebCore::toCairoRegion): Deleted. * Source/WebKit/UIProcess/API/gtk/PageClientImpl.cpp: (WebKit::toCairoRegion): (WebKit::PageClientImpl::setViewNeedsDisplay): Canonical link: https://commits.webkit.org/276887@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 220898: Use containsHTMLLineBreak more
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 220898597194f341c70105746e8dcab36c18e41c https://github.com/WebKit/WebKit/commit/220898597194f341c70105746e8dcab36c18e41c Author: Yusuke Suzuki Date: 2024-04-01 (Mon, 01 Apr 2024) Changed paths: M Source/WebCore/html/EmailInputType.cpp M Source/WebCore/html/HTMLInputElement.cpp Log Message: --- Use containsHTMLLineBreak more https://bugs.webkit.org/show_bug.cgi?id=271940 rdar://125666918 Reviewed by Mark Lam. Apply containsHTMLLineBreak more places in WebCore. They rarely include these characters. * Source/WebCore/html/EmailInputType.cpp: (WebCore::EmailInputType::sanitizeValue const): * Source/WebCore/html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::placeholder const): Canonical link: https://commits.webkit.org/276886@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] fa55e5: [WebGPU] WebGPU::PipelineLayout::errorValidatingBi...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: fa55e51f70c3252ec72956e19eb1a07cda1e5e9b https://github.com/WebKit/WebKit/commit/fa55e51f70c3252ec72956e19eb1a07cda1e5e9b Author: Mike Wyrzykowski Date: 2024-04-01 (Mon, 01 Apr 2024) Changed paths: M Source/WebGPU/WebGPU/PipelineLayout.mm Log Message: --- [WebGPU] WebGPU::PipelineLayout::errorValidatingBindGroupCompatibility should ensure bind group exists https://bugs.webkit.org/show_bug.cgi?id=271897 Reviewed by Alex Christensen. We should ensure the WeakPtr is not null before using it. * Source/WebGPU/WebGPU/PipelineLayout.mm: (WebGPU::PipelineLayout::errorValidatingBindGroupCompatibility const): Canonical link: https://commits.webkit.org/276885@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 77738e: Versioning.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 77738ec6566eaec166552bbacfc280f9cc38d09d https://github.com/WebKit/WebKit/commit/77738ec6566eaec166552bbacfc280f9cc38d09d Author: Russell Epstein Date: 2024-04-01 (Mon, 01 Apr 2024) Changed paths: M Configurations/Version.xcconfig Log Message: --- Versioning. WebKit-7619.1.9 Canonical link: https://commits.webkit.org/276884@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e7f669: [webkitpy] Delete SVNRepository
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e7f669c3752c7a3210f22b120c44525c0c9714a7 https://github.com/WebKit/WebKit/commit/e7f669c3752c7a3210f22b120c44525c0c9714a7 Author: Jonathan Bedard Date: 2024-04-01 (Mon, 01 Apr 2024) Changed paths: M Tools/Scripts/webkitpy/common/checkout/scm/git.py R Tools/Scripts/webkitpy/common/checkout/scm/svn.py Log Message: --- [webkitpy] Delete SVNRepository https://bugs.webkit.org/show_bug.cgi?id=271965 rdar://125716794 Reviewed by Alexey Proskuryakov. * Tools/Scripts/webkitpy/common/checkout/scm/git.py: (Git): Remove SVNRepository parent class. * Tools/Scripts/webkitpy/common/checkout/scm/svn.py: Removed. Canonical link: https://commits.webkit.org/276883@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f62faa: [JSC] Redefinitions of RELEASE_ASSERT should be re...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f62faaf4e133012e836c428bf8f651535dce05d9 https://github.com/WebKit/WebKit/commit/f62faaf4e133012e836c428bf8f651535dce05d9 Author: David Degazio Date: 2024-04-01 (Mon, 01 Apr 2024) Changed paths: M Source/JavaScriptCore/b3/air/AirAllocateRegistersAndStackByLinearScan.cpp M Source/JavaScriptCore/dfg/DFGSSAConversionPhase.cpp M Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp Log Message: --- [JSC] Redefinitions of RELEASE_ASSERT should be removed https://bugs.webkit.org/show_bug.cgi?id=271728 rdar://problem/125439450 Reviewed by Yusuke Suzuki. Removes several redefinitions of the RELEASE_ASSERT macro in JavaScriptCore, since they don't seem to serve any purpose other than duplicating code needlessly. * Source/JavaScriptCore/b3/air/AirAllocateRegistersAndStackByLinearScan.cpp: * Source/JavaScriptCore/dfg/DFGSSAConversionPhase.cpp: * Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp: Canonical link: https://commits.webkit.org/276882@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 724f71: Make run-jsc-stress-tests handle expected crashes ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 724f7173e04a9d448964e3094b0929d6ae29d551 https://github.com/WebKit/WebKit/commit/724f7173e04a9d448964e3094b0929d6ae29d551 Author: Mark Lam Date: 2024-04-01 (Mon, 01 Apr 2024) Changed paths: M JSTests/stress/ensure-crash.js M JSTests/stress/incorrect-put-could-generate-invalid-ic-but-still-not-causing-bad-behavior-bad-transition-debug.js M JSTests/stress/incorrect-put-could-generate-invalid-ic-but-still-not-causing-bad-behavior-bad-transition.js M JSTests/stress/incorrect-put-could-generate-invalid-ic-but-still-not-causing-bad-behavior.js M JSTests/stress/incorrect-put-could-generate-invalid-ic-involving-dictionary-flatten-debug.js M Source/JavaScriptCore/Scripts/process-entitlements.sh M Source/JavaScriptCore/jsc.cpp M Source/WTF/wtf/Assertions.cpp M Tools/Scripts/run-jsc-stress-tests M Tools/Scripts/webkitruby/jsc-stress-test-writer-default.rb Log Message: --- Make run-jsc-stress-tests handle expected crashes correctly. https://bugs.webkit.org/show_bug.cgi?id=271954 rdar://124471961 Reviewed by Yusuke Suzuki. It does not make sense to have a crashOK! test attribute, which imply that the test will be flaky. A test should be deterministic. We should either expect a crash or no crash. To enable this, we'll make the following changes: 1. Change the jsc shell "crash detector" signal handler to exit with exitCode 137 (to indicate a fatal crash). 2. Fix the JSC stress test harness to actually be able to handle crashes (terminations with exitCode > 130). 3. Rename the "crashOK!" test attribute to "mustCrash!". It now makes it clear that a test is expected to crash, instead of flakily crashing sometimes. 4. Add filter conditions to tests that "mustCrash!" so that they are only run with configurations where they are expected to crash. Skip the rest. 5. Make WTFCrash() crash with WTFBreakpointTrap() on Darwin ARM64 platforms to be consistent with all other crashes. 6. Opportunistic quality of life improvement: make jsc shell timeouts crash below crashDueToJSCShellTimeout() to distinguish it from other crashes. * JSTests/stress/ensure-crash.js: * JSTests/stress/incorrect-put-could-generate-invalid-ic-but-still-not-causing-bad-behavior-bad-transition-debug.js: * JSTests/stress/incorrect-put-could-generate-invalid-ic-but-still-not-causing-bad-behavior-bad-transition.js: * JSTests/stress/incorrect-put-could-generate-invalid-ic-but-still-not-causing-bad-behavior.js: * JSTests/stress/incorrect-put-could-generate-invalid-ic-involving-dictionary-flatten-debug.js: * Source/JavaScriptCore/Scripts/process-entitlements.sh: * Source/JavaScriptCore/jsc.cpp: (crashDueToJSCShellTimeout): (timeoutCheckCallback): (CommandLine::parseArguments): * Source/WTF/wtf/Assertions.cpp: * Tools/Scripts/run-jsc-stress-tests: * Tools/Scripts/webkitruby/jsc-stress-test-writer-default.rb: Canonical link: https://commits.webkit.org/276881@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 25fc2e: English Heritage Members' Area overlapping layout
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 25fc2ed66b603ac0edfbae46034aa6ee2554dc56 https://github.com/WebKit/WebKit/commit/25fc2ed66b603ac0edfbae46034aa6ee2554dc56 Author: Alan Baradlay Date: 2024-04-01 (Mon, 01 Apr 2024) Changed paths: A LayoutTests/fast/css-grid-layout/height-percentage-on-grid-item-child-with-nesting-expected.html A LayoutTests/fast/css-grid-layout/height-percentage-on-grid-item-child-with-nesting.html M Source/WebCore/rendering/RenderGrid.cpp Log Message: --- English Heritage Members' Area overlapping layout https://bugs.webkit.org/show_bug.cgi?id=271843 Reviewed by Antti Koivisto. Overriding height is (sadly) the render tree way of saying "please use this instead of the computed value". (This is used to communicate between nested formatting contexts) * LayoutTests/fast/css-grid-layout/height-percentage-on-grid-item-child-with-nesting-expected.html: Added. * LayoutTests/fast/css-grid-layout/height-percentage-on-grid-item-child-with-nesting.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-inline/text-box-trim/text-box-trim-half-leading-block-box-001.html: * Source/WebCore/rendering/RenderGrid.cpp: (WebCore::RenderGrid::layoutGrid): Canonical link: https://commits.webkit.org/276880@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9a0c58: [IPC] Remove EnumTraits
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9a0c584ccaa2b3b7694bc4b97dfd4afb610a4bb6 https://github.com/WebKit/WebKit/commit/9a0c584ccaa2b3b7694bc4b97dfd4afb610a4bb6 Author: Mikhail R. Gadelha Date: 2024-04-01 (Mon, 01 Apr 2024) Changed paths: M Source/WebKit/Shared/Extensions/WebExtensionDataType.h M Source/WebKit/Shared/Extensions/WebExtensionStorage.serialization.in Log Message: --- [IPC] Remove EnumTraits https://bugs.webkit.org/show_bug.cgi?id=271887 Reviewed by Timothy Hatcher. Delete the EnumTraits in favor of the serialization format, already implemented in 274603@main. This patch also removes the [OptionSet] attribute as it is not needed. * Source/WebKit/Shared/Extensions/WebExtensionDataType.h: * Source/WebKit/Shared/Extensions/WebExtensionStorage.serialization.in: Canonical link: https://commits.webkit.org/276879@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 493539: [WebDriver] Update imported Selenium WebDriver tests
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 493539fc0255598acbb145436f059ab566b826a8 https://github.com/WebKit/WebKit/commit/493539fc0255598acbb145436f059ab566b826a8 Author: Lauro Moura Date: 2024-04-01 (Mon, 01 Apr 2024) Changed paths: M Tools/Scripts/webkitpy/webdriver_tests/webdriver_driver_wpe.py M WebDriverTests/imported/selenium/common/common-web.iml A WebDriverTests/imported/selenium/common/src/web/attributes.html A WebDriverTests/imported/selenium/common/src/web/bidi/emptyPage.html A WebDriverTests/imported/selenium/common/src/web/bidi/emptyText.txt A WebDriverTests/imported/selenium/common/src/web/bidi/logEntryAdded.html A WebDriverTests/imported/selenium/common/src/web/bidi/redirected.html A WebDriverTests/imported/selenium/common/src/web/bidi/redirected_http_equiv.html A WebDriverTests/imported/selenium/common/src/web/bidi/release_action.html A WebDriverTests/imported/selenium/common/src/web/bidi/scriptTestAccessProperty.html A WebDriverTests/imported/selenium/common/src/web/bidi/scriptTestRemoveProperty.html A WebDriverTests/imported/selenium/common/src/web/const_js.html A WebDriverTests/imported/selenium/common/src/web/devToolsRequestInterceptionTest.html A WebDriverTests/imported/selenium/common/src/web/devtools_request_interception_test/one.js A WebDriverTests/imported/selenium/common/src/web/devtools_request_interception_test/two.js A WebDriverTests/imported/selenium/common/src/web/downloads/download.html A WebDriverTests/imported/selenium/common/src/web/downloads/file_1.txt A WebDriverTests/imported/selenium/common/src/web/downloads/file_2.jpg A WebDriverTests/imported/selenium/common/src/web/fedcm/accounts.json A WebDriverTests/imported/selenium/common/src/web/fedcm/client_metadata.json A WebDriverTests/imported/selenium/common/src/web/fedcm/fedcm.html A WebDriverTests/imported/selenium/common/src/web/fedcm/fedcm.json M WebDriverTests/imported/selenium/common/src/web/formPage.html A WebDriverTests/imported/selenium/common/src/web/index.html A WebDriverTests/imported/selenium/common/src/web/logEntryAdded.html A WebDriverTests/imported/selenium/common/src/web/login.html A WebDriverTests/imported/selenium/common/src/web/mouse_interaction.html A WebDriverTests/imported/selenium/common/src/web/pointerActionsPage.html A WebDriverTests/imported/selenium/common/src/web/printPage.html M WebDriverTests/imported/selenium/common/src/web/readOnlyPage.html A WebDriverTests/imported/selenium/common/src/web/redirected.html A WebDriverTests/imported/selenium/common/src/web/redirected_http_equiv.html M WebDriverTests/imported/selenium/common/src/web/relative_locators.html A WebDriverTests/imported/selenium/common/src/web/scrollingPage.html M WebDriverTests/imported/selenium/common/src/web/scrolling_tests/frame_with_nested_scrolling_frame_out_of_view.html A WebDriverTests/imported/selenium/common/src/web/shadowRootPage.html M WebDriverTests/imported/selenium/common/src/web/single_text_input.html A WebDriverTests/imported/selenium/common/src/web/submitted-form.html A WebDriverTests/imported/selenium/common/src/web/userprompt.html A WebDriverTests/imported/selenium/common/src/web/virtual-authenticator.html A WebDriverTests/imported/selenium/common/src/web/web-form.html A WebDriverTests/imported/selenium/common/src/web/webComponents.html M WebDriverTests/imported/selenium/importer.json M WebDriverTests/imported/selenium/py/conftest.py M WebDriverTests/imported/selenium/py/selenium/__init__.py M WebDriverTests/imported/selenium/py/selenium/common/__init__.py M WebDriverTests/imported/selenium/py/selenium/common/exceptions.py A WebDriverTests/imported/selenium/py/selenium/py.typed A WebDriverTests/imported/selenium/py/selenium/types.py M WebDriverTests/imported/selenium/py/selenium/webdriver/__init__.py M WebDriverTests/imported/selenium/py/selenium/webdriver/common/action_chains.py M WebDriverTests/imported/selenium/py/selenium/webdriver/common/actions/action_builder.py M WebDriverTests/imported/selenium/py/selenium/webdriver/common/actions/input_device.py M WebDriverTests/imported/selenium/py/selenium/webdriver/common/actions/interaction.py M WebDriverTests/imported/selenium/py/selenium/webdriver/common/actions/key_actions.py M WebDriverTests/imported/selenium/py/selenium/webdriver/common/actions/key_input.py M WebDriverTests/imported/selenium/py/selenium/webdriver/common/actions/mouse_button.py M WebDriverTests/imported/selenium/py/selenium/webdriver/common/actions/pointer_actions.py M WebDriverTests/imported/selenium/py/selenium/webdriver/common/actions/pointer_input.py A WebDriverTests/imported/selenium/py/selenium/webdriver/common/actions/wheel_actions.py A WebDriverTests/imported/selenium/py/selen
[webkit-changes] [WebKit/WebKit] abfaec: [GStreamer][LibWebRTC] Add quirks in decoder factory
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: abfaece5215ac3a643abe03500a004a132005ad3 https://github.com/WebKit/WebKit/commit/abfaece5215ac3a643abe03500a004a132005ad3 Author: Philippe Normand Date: 2024-04-01 (Mon, 01 Apr 2024) Changed paths: M Source/WebCore/platform/gstreamer/GStreamerQuirkBroadcom.h M Source/WebCore/platform/gstreamer/GStreamerQuirkRealtek.h M Source/WebCore/platform/gstreamer/GStreamerQuirks.cpp M Source/WebCore/platform/gstreamer/GStreamerQuirks.h M Source/WebCore/platform/mediastream/libwebrtc/gstreamer/GStreamerVideoDecoderFactory.cpp Log Message: --- [GStreamer][LibWebRTC] Add quirks in decoder factory https://bugs.webkit.org/show_bug.cgi?id=271751 Reviewed by Xabier Rodriguez-Calvar. Allow the decoder pipeline to skip auto-plugging of hardware-accelerated decoders and also to disable parsing, both for Broadcom and Realtek quirks. * Source/WebCore/platform/gstreamer/GStreamerQuirkBroadcom.h: * Source/WebCore/platform/gstreamer/GStreamerQuirkRealtek.h: * Source/WebCore/platform/gstreamer/GStreamerQuirks.cpp: (WebCore::GStreamerQuirksManager::shouldParseIncomingLibWebRTCBitStream const): * Source/WebCore/platform/gstreamer/GStreamerQuirks.h: (WebCore::GStreamerQuirk::shouldParseIncomingLibWebRTCBitStream const): * Source/WebCore/platform/mediastream/libwebrtc/gstreamer/GStreamerVideoDecoderFactory.cpp: (WebCore::GStreamerWebRTCVideoDecoder::getGstAutoplugSelectResult): (WebCore::H264Decoder::H264Decoder): Canonical link: https://commits.webkit.org/276877@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5e4935: [WPE] Holepunch doesn't work when the video elemen...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5e4935006d800fff897c52435b38db22ef2ced70 https://github.com/WebKit/WebKit/commit/5e4935006d800fff897c52435b38db22ef2ced70 Author: Miguel Gomez Date: 2024-04-01 (Mon, 01 Apr 2024) Changed paths: M Source/WebCore/platform/graphics/texmap/TextureMapper.cpp M Source/WebCore/platform/graphics/texmap/TextureMapperShaderProgram.cpp Log Message: --- [WPE] Holepunch doesn't work when the video element has rounded corners https://bugs.webkit.org/show_bug.cgi?id=271653 Reviewed by Carlos Garcia Campos. Modify the rounded rectangle clipping in the TextureMapper so it can work when blending is disabled. To do this, the fragments that are out of rounded rectangle are discarded by the fragment shader, instead of painting them transparent. When blending is enabled, we can do some antialiasing of the pixels on the rounded corners by reducing their opacity depending on how much they are inside the rect. When blending is disabled we can't do antialiasing of the rounded corners, so the visual result is a bit worse. The good thing is that blending is only disabled when we're rendering a holepunch buffer, so it's not a big problem. * Source/WebCore/platform/graphics/texmap/TextureMapper.cpp: (WebCore::TextureMapper::drawSolidColor): * Source/WebCore/platform/graphics/texmap/TextureMapperShaderProgram.cpp: Canonical link: https://commits.webkit.org/276876@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 82de10: WebKit's intrinsic inline-size calculations don't ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 82de10d6c30c90fb117fa9761eb0706eff0bcdac https://github.com/WebKit/WebKit/commit/82de10d6c30c90fb117fa9761eb0706eff0bcdac Author: Alan Baradlay Date: 2024-04-01 (Mon, 01 Apr 2024) Changed paths: A LayoutTests/fast/text/empty-trailing-content-trimming-expected.html A LayoutTests/fast/text/empty-trailing-content-trimming.html M Source/WebCore/layout/formattingContexts/inline/InlineContentBreaker.cpp Log Message: --- WebKit's intrinsic inline-size calculations don't account for whitespace before empty child with nonzero margins https://bugs.webkit.org/show_bug.cgi?id=183029 Reviewed by Antti Koivisto. While min/max-content widths are correctly computed, layout fails to ignore the empty inline box generated by pseudo "after". It prevents us from being able to trim the trailing whitespace making the inline box wrapped to the subsequent line. * LayoutTests/fast/text/empty-trailing-content-trimming-expected.html: Added. * LayoutTests/fast/text/empty-trailing-content-trimming.html: Added. * Source/WebCore/layout/formattingContexts/inline/InlineContentBreaker.cpp: (WebCore::Layout::isNonContentRunsOnly): Canonical link: https://commits.webkit.org/276875@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4aa868: Unreviewed. [Skia] Fix build with clang after 2765...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4aa8685f0ebc20c9132bc6f361a7122dfd94d7da https://github.com/WebKit/WebKit/commit/4aa8685f0ebc20c9132bc6f361a7122dfd94d7da Author: Carlos Garcia Campos Date: 2024-04-01 (Mon, 01 Apr 2024) Changed paths: M Source/WebCore/platform/graphics/skia/PathSkia.cpp Log Message: --- Unreviewed. [Skia] Fix build with clang after 276505@main * Source/WebCore/platform/graphics/skia/PathSkia.cpp: Canonical link: https://commits.webkit.org/276874@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] bdd874: Unreviewed. [GTK] Fix the build after 276859@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: bdd874cb8ce5fcdf35806ada613b384fcfa8c151 https://github.com/WebKit/WebKit/commit/bdd874cb8ce5fcdf35806ada613b384fcfa8c151 Author: Carlos Garcia Campos Date: 2024-04-01 (Mon, 01 Apr 2024) Changed paths: M Source/WebKit/UIProcess/API/gtk/DropTargetGtk4.cpp Log Message: --- Unreviewed. [GTK] Fix the build after 276859@main * Source/WebKit/UIProcess/API/gtk/DropTargetGtk4.cpp: (WebKit::DropTarget::accept): Canonical link: https://commits.webkit.org/276873@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 000e44: [GStreamer][Quirks] Apply configureElement to ever...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 000e4448b8aa69a4a29a0da1d52f4208d79200f9 https://github.com/WebKit/WebKit/commit/000e4448b8aa69a4a29a0da1d52f4208d79200f9 Author: Philippe Normand Date: 2024-04-01 (Mon, 01 Apr 2024) Changed paths: M Source/WebCore/platform/gstreamer/GStreamerQuirkAmLogic.cpp M Source/WebCore/platform/gstreamer/GStreamerQuirkAmLogic.h M Source/WebCore/platform/gstreamer/GStreamerQuirkBroadcom.cpp M Source/WebCore/platform/gstreamer/GStreamerQuirkBroadcom.h M Source/WebCore/platform/gstreamer/GStreamerQuirkRealtek.cpp M Source/WebCore/platform/gstreamer/GStreamerQuirkRealtek.h M Source/WebCore/platform/gstreamer/GStreamerQuirkWesteros.cpp M Source/WebCore/platform/gstreamer/GStreamerQuirkWesteros.h M Source/WebCore/platform/gstreamer/GStreamerQuirks.cpp M Source/WebCore/platform/gstreamer/GStreamerQuirks.h Log Message: --- [GStreamer][Quirks] Apply configureElement to every requested quirk https://bugs.webkit.org/show_bug.cgi?id=271697 Reviewed by Xabier Rodriguez-Calvar. On some platforms it is desirable to apply that quirk unconditionally, because multiple platform-specific quirks are requested. * Source/WebCore/platform/gstreamer/GStreamerQuirkAmLogic.cpp: (WebCore::GStreamerQuirkAmLogic::configureElement): * Source/WebCore/platform/gstreamer/GStreamerQuirkAmLogic.h: * Source/WebCore/platform/gstreamer/GStreamerQuirkBroadcom.cpp: (WebCore::GStreamerQuirkBroadcom::configureElement): * Source/WebCore/platform/gstreamer/GStreamerQuirkBroadcom.h: * Source/WebCore/platform/gstreamer/GStreamerQuirkRealtek.cpp: (WebCore::GStreamerQuirkRealtek::configureElement): * Source/WebCore/platform/gstreamer/GStreamerQuirkRealtek.h: * Source/WebCore/platform/gstreamer/GStreamerQuirkWesteros.cpp: (WebCore::GStreamerQuirkWesteros::configureElement): * Source/WebCore/platform/gstreamer/GStreamerQuirkWesteros.h: * Source/WebCore/platform/gstreamer/GStreamerQuirks.cpp: (WebCore::GStreamerQuirksManager::configureElement): * Source/WebCore/platform/gstreamer/GStreamerQuirks.h: (WebCore::GStreamerQuirk::configureElement): Canonical link: https://commits.webkit.org/276872@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 73b85d: [Skia] Fix support for DragImage with GTK
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 73b85d6c9c77de1051c0521be9c8686202a14643 https://github.com/WebKit/WebKit/commit/73b85d6c9c77de1051c0521be9c8686202a14643 Author: Patrick Griffis Date: 2024-04-01 (Mon, 01 Apr 2024) Changed paths: M Source/WebCore/platform/gtk/DragImageGtk.cpp M Source/WebKit/UIProcess/API/gtk/DragSourceGtk3.cpp M Source/WebKit/WebProcess/WebCoreSupport/gtk/WebDragClientGtk.cpp Log Message: --- [Skia] Fix support for DragImage with GTK https://bugs.webkit.org/show_bug.cgi?id=271871 Reviewed by Carlos Garcia Campos. * Source/WebCore/platform/gtk/DragImageGtk.cpp: (WebCore::dragImageSize): (WebCore::scaleDragImage): (WebCore::dissolveDragImageToFraction): * Source/WebKit/UIProcess/API/gtk/DragSourceGtk3.cpp: (WebKit::DragSource::begin): * Source/WebKit/WebProcess/WebCoreSupport/gtk/WebDragClientGtk.cpp: (WebKit::convertSkiaImageToShareableBitmap): (WebKit::WebDragClient::startDrag): Canonical link: https://commits.webkit.org/276871@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
