[Bug 17791] ProofreadPage broken for GIF images due to assuming it can always create thumbnails

2012-08-13 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=17791

matanya  changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 CC||matanya.mo...@gmail.com
 Resolution||FIXED

--- Comment #13 from matanya  2012-08-13 12:37:32 UTC 
---
patch merged. seems to be fixed.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 17791] ProofreadPage broken for GIF images due to assuming it can always create thumbnails

2012-04-28 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=17791

--- Comment #12 from Beau  2012-04-28 19:36:36 UTC ---
I have submitted gerrit #6078 for review.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 17791] ProofreadPage broken for GIF images due to assuming it can always create thumbnails

2012-04-12 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=17791

Doug  changed:

   What|Removed |Added

 CC||wikipediad...@googlemail.co
   ||m
 Blocks||35925

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 17791] ProofreadPage broken for GIF images due to assuming it can always create thumbnails

2012-02-17 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=17791

Sumana Harihareswara  changed:

   What|Removed |Added

 CC||suma...@panix.com,
   ||zaran.krl...@gmail.com

--- Comment #11 from Sumana Harihareswara  2012-02-17 
14:53:30 UTC ---
Adding Zaran to cc in case he can review this patch or otherwise update status.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 17791] ProofreadPage broken for GIF images due to assuming it can always create thumbnails

2011-08-30 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=17791

--- Comment #10 from Beau  2011-08-30 14:40:52 UTC ---
(In reply to comment #8)
> this seems to be redundant; per comments above, we should get back a thumburl
> entry whenever we've asked for a size, and we should always be asking for a
> size ("original size" may be unreasonably *huge* for some scans).

The javascript asks for a specific size, which is based on the size of user
screen during page load. If the software is unable to scale the image for
whatever reason there is it tries to show the original image and let the
browser do the scaling. If it is unwanted behaviour, we can get rid of that and
do not show images.

(In reply to comment #9)
> You won't get back a thumburl for audio fragments, or any other file format
> that does not support thumb nailing (like ogg video if you don't have the
> scalers installed for instance).
> 
> Not sure how much you have to take that into account.

Proofread Page is meant for scans. If wikisource community want to write down
dialogs from recordings they should use different extension (they don't need
paging, but subtitles). The code could check if the file is an image, but I
don't know how.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 17791] ProofreadPage broken for GIF images due to assuming it can always create thumbnails

2011-08-29 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=17791

Derk-Jan Hartman  changed:

   What|Removed |Added

 CC||hart...@videolan.org

--- Comment #9 from Derk-Jan Hartman  2011-08-29 19:11:02 
UTC ---
You won't get back a thumburl for audio fragments, or any other file format
that does not support thumb nailing (like ogg video if you don't have the
scalers installed for instance).

Not sure how much you have to take that into account.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 17791] ProofreadPage broken for GIF images due to assuming it can always create thumbnails

2011-08-29 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=17791

--- Comment #8 from Brion Vibber  2011-08-29 18:44:06 UTC 
---
Looks like fairly reasonablish code overall, but all this really needs a
testing plan to confirm that it fixes the described bugs and doesn't cause
regressions.


Are bits like this code necessary?

if( !imageinfo.thumburl ) {

44 

// Unable to fetch a thumbnail, use the image without
scaling and lie about its size

45 

// This works only for non-paged files though

46 

if ( mw.config.get( 'proofreadPageFilePage' ) == null )
{

47 

height = ( quantizedWidth / fullWidth ) *
fullHeight;

48 

callback( imageinfo.url, quantizedWidth, height );

49 

}

50 

}

this seems to be redundant; per comments above, we should get back a thumburl
entry whenever we've asked for a size, and we should always be asking for a
size ("original size" may be unreasonably *huge* for some scans).

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 17791] ProofreadPage broken for GIF images due to assuming it can always create thumbnails

2011-08-28 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=17791

Beau  changed:

   What|Removed |Added

   Keywords||need-review

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 17791] ProofreadPage broken for GIF images due to assuming it can always create thumbnails

2011-08-28 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=17791

Beau  changed:

   What|Removed |Added

   Attachment #8977|0   |1
is obsolete||

--- Comment #7 from Beau  2011-08-28 14:44:25 UTC ---
Created attachment 8982
  --> https://bugzilla.wikimedia.org/attachment.cgi?id=8982
Reduced version of patch

I have removed minor changes I did when browsing the code. I'll stick to
changes related to fixing the bug only.

I have also fixed layout issue. The image is scaled down to desired size.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 17791] ProofreadPage broken for GIF images due to assuming it can always create thumbnails

2011-08-28 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=17791

--- Comment #6 from Beau  2011-08-28 13:45:13 UTC ---
Okay. I'll fix that, and send another version of patch.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 17791] ProofreadPage broken for GIF images due to assuming it can always create thumbnails

2011-08-27 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=17791

Brion Vibber  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |

--- Comment #5 from Brion Vibber  2011-08-28 01:17:10 UTC 
---
There are bugs described in the above comment, and the patch makes a lot of
unrelated style changes that hide the functional code, making it harder to
review and test.

John, can you back this out pending review and fixes? Thanks!

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 17791] ProofreadPage broken for GIF images due to assuming it can always create thumbnails

2011-08-27 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=17791

John Du Hart  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 CC||j...@compwhizii.net
 Resolution||FIXED

--- Comment #4 from John Du Hart  2011-08-27 17:41:30 UTC 
---
r95602

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 17791] ProofreadPage broken for GIF images due to assuming it can always create thumbnails

2011-08-26 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=17791

Beau  changed:

   What|Removed |Added

   Keywords||patch

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 17791] ProofreadPage broken for GIF images due to assuming it can always create thumbnails

2011-08-26 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=17791

--- Comment #3 from Beau  2011-08-26 20:52:29 UTC ---
Created attachment 8977
  --> https://bugzilla.wikimedia.org/attachment.cgi?id=8977
Url of thumbnail is fetched using api.

The Proofread script asks api for thumbnail url. If the image cannot be scaled
it is shown in full size. This can mess up the layout if the image is large,
but at least text on the scan should be visible.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 17791] ProofreadPage broken for GIF images due to assuming it can always create thumbnails

2011-08-26 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=17791

Beau  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||b...@adres.pl
 AssignedTo|wikibugs-l@lists.wikimedia. |b...@adres.pl
   |org |

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 17791] ProofreadPage broken for GIF images due to assuming it can always create thumbnails

2009-07-31 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=17791


Brion Vibber  changed:

   What|Removed |Added

 CC||br...@wikimedia.org
 AssignedTo|wikibugs-   |thoma...@gmx.de
   |l...@lists.wikimedia.org   |




-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 17791] ProofreadPage broken for GIF images due to assuming it can always create thumbnails

2009-03-16 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=17791





--- Comment #2 from Brion Vibber   2009-03-16 18:35:52 UTC 
---
Just ask for a thumb of a particular size:

http://en.wikisource.org/w/api.php?action=query&titles=Image:Summary_for_B-23.gif&prop=imageinfo&iiprop=url|size&iiurlwidth=320

It'll give you back thumbnail information, which will be scaled or not as
appropriate:

http://upload.wikimedia.org/wikisource/en/1/14/Summary_for_B-23.gif";
thumbwidth="320"
thumbheight="414"
url="http://upload.wikimedia.org/wikisource/en/1/14/Summary_for_B-23.gif";
descriptionurl="http://en.wikisource.org/wiki/File:Summary_for_B-23.gif"; />

You need only use the values returned to you and don't worry about trying to
decide whether to scale anything yourself... The internal system already took
care of that. :)


-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 17791] ProofreadPage broken for GIF images due to assuming it can always create thumbnails

2009-03-08 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=17791


ThomasV  changed:

   What|Removed |Added

 CC||thoma...@gmx.de




--- Comment #1 from ThomasV   2009-03-08 09:01:10 UTC ---
the API allows to retrieve the URL of a given image, eg:
http://en.wikisource.org/w/api.php?action=query&titles=Image:Summary_for_B-23.gif&prop=imageinfo&iiprop=url|size

is there an API query that returns whether scaling is enabled/disabled for a
particular image format ?


-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l