[MediaWiki-CodeReview] [MediaWiki r113966]: Revision status changed

[MediaWiki Mail]

"Brion VIBBER" changed the status of MediaWiki.r113966 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113966

Old status:  new
New status: ok

Commit summary for MediaWiki.r113966:

docs++

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r113986]: New comment added, and revision status changed

[MediaWiki Mail]

"Brion VIBBER" changed the status of MediaWiki.r113986 to "fixme" and commented 
it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113986#c32231

Old Status: new
New Status: fixme

Commit summary for MediaWiki.r113986:

Documentation stuffs

Brion VIBBER's comment:

That code wasn't unused! bug 35253

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r113985]: Revision status changed

[MediaWiki Mail]

"Brion VIBBER" changed the status of MediaWiki.r113985 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113985

Old status:  new
New status: ok

Commit summary for MediaWiki.r113985:

Followup r113740

Fix PODpartners casing difference

Remove unused global and useless return at the same time

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r113988]: Revision status changed

[MediaWiki Mail]

"Brion VIBBER" changed the status of MediaWiki.r113988 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113988

Old status:  new
New status: ok

Commit summary for MediaWiki.r113988:

Reports of undefined index notices related to display title

Add a isset precursor

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r113991]: Revision status changed

[MediaWiki Mail]

"Brion VIBBER" changed the status of MediaWiki.r113991 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113991

Old status:  new
New status: ok

Commit summary for MediaWiki.r113991:

So apparently Collection still had a PHP4 constructor

More documentation improvements at the same time

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r113993]: Revision status changed

[MediaWiki Mail]

"Brion VIBBER" changed the status of MediaWiki.r113993 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113993

Old status:  new
New status: ok

Commit summary for MediaWiki.r113993:

Make UsageException extend MWException

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r113997]: Revision status changed

[MediaWiki Mail]

"Aaron Schulz" changed the status of MediaWiki.r113997 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113997

Old status:  new
New status: ok

Commit summary for MediaWiki.r113997:

Remove incorrect "the" in 'filereadonlyerror'.
Make use of reasons more consistent in a few messages.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r113914]: Revision status changed

[MediaWiki Mail]

"Santhosh.thottingal" changed the status of MediaWiki.r113914 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113914

Old status:  new
New status: ok

Commit summary for MediaWiki.r113914:

Fixing this fixme since it was reported as bug in twn

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r113918]: Revision status changed

[MediaWiki Mail]

"Santhosh.thottingal" changed the status of MediaWiki.r113918 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113918

Old status:  new
New status: ok

Commit summary for MediaWiki.r113918:

Fix typo

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Re: [Wikitech-l] Re-introducing "UNCONFIRMED" state to bugzilla

[Krinkle]

On Mar 16, 2012, at 12:52 AM, Mark A. Hershberger wrote:

> Rob Lanphier  writes:
> 
>> Mark and I just discussed this, and he's going to look into having a
>> "CONFIRMED" state.
> 
> https://bugzillaupdate.wordpress.com/2010/07/06/bugzilla-4-0-has-a-new-default-status-workflow/
> 
> describes this implementation:
> 
> UNCONFIRMED -> CONFIRMED -> IN_PROGRESS -> RESOLVED -> VERIFIED
> 
> Since "UNCONFIRMED" is used so many places, I'm worried about changing
> that to "NEW".

So up until last month we had this workflow:
1. NEW
2. ASSIGNED[1]
3. RESOLVED
(sometimes) 4. VERIFIED
(or) REOPENED -> step 1

I understand that last week it changed to:
1. UNCONFIRMED
2. NEW
3. ASSIGNED
4. RESOLVED
(sometimes) 5. VERIFIED
(or) REOPENED -> step 2

I don't think it makes sense to use "NEW" as "CONFIRMED", because, agreeing
with [2], "NEW" is not descriptive. How about using "CONFIRMED" and dropping
"NEW" completely?

-- Krinkle


[1] The difference between a confirmed bug having an assignee and status
ASSIGNED, is that ASSIGNED means someone has it on his agenda to actively
work on. Whereas the assignee in general is just whoever is currently
watching over it. ASSIGNED and IN_PROGRESS are basically there same. Except
that "IN_PRORESS" is slightly later than ASSIGNED but using both doesn't
make sense and we're already using ASSIGNED.
[2] 
https://bugzillaupdate.wordpress.com/2010/07/06/bugzilla-4-0-has-a-new-default-status-workflow/
[3] http://www.bugzilla.org/docs/4.0/en/html/lifecycle.html
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[Wikitech-l] Deadline for Wikimania submissions is Sunday

[aude]

Reminder to get your Wikimania program submissions in soon!

The deadline for submissions is Sunday, March 18 at 11:59 (San Francisco)
Pacific Daylight Time (or 06:59 UTC on 19 March 2012).

We seek submissions for presentations, workshops, panels, and other types
of sessions.

We want the technical track to be the best possible and we need your help!
 We want submission on various aspects of MediaWiki technology, mobile
apps, operations, and more.

How do we make Wikipedia scale?  visual editor?  Wikipedia and wiktionary
mobile apps, wikidata, semantic mediawiki, GLAM tech, toolserver projects
and tools, MediaWiki extensions, OpenStreetMap and other maps/geo,
Wikimedia labs, and everything else that I'm forgetting to mention. :)

Among all these topics, we're also interested in highlight accessibility as
a topic for presentations and during the hackathon.

You can view the call for participation and make submissions here:

http://wikimania2012.wikimedia.org/wiki/Submissions

Don't forget there will also be a hackathon during the preconference:

http://wikimania2012.wikimedia.org/wiki/Hackathon

Cheers,
Katie

-- 
President, Wikimedia District of Columbia
http://wikimediadc.org
@wikimediadc / @wikimania2012
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[MediaWiki-CodeReview] [MediaWiki r113986]: New comment added

[MediaWiki Mail]

"Reedy" posted a comment on MediaWiki.r113986.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113986#c32230

Commit summary for MediaWiki.r113986:

Documentation stuffs

Reedy's comment:

Oh, normalised some return statements, and remove some unused code and added a 
few braces

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r113984]: Revision status changed

[MediaWiki Mail]

"Krinkle" changed the status of MediaWiki.r113984 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113984

Old status:  new
New status: ok

Commit summary for MediaWiki.r113984:

followup to -r113953 - remove misleading global variables

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r113953]: New comment added

[MediaWiki Mail]

"Reedy" posted a comment on MediaWiki.r113953.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113953#c32229

Commit summary for MediaWiki.r113953:

fix for bug 35245 - add rate limiter and spam filter check

Reedy's comment:

I'm just wondering if this is likely to be misleading..

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Re: [Wikitech-l] Re-introducing "UNCONFIRMED" state to bugzilla

[MZMcBride]

Mark A. Hershberger wrote:
> Does this workflow (+ changing all "NEW" to "UNCONFIRMED") look
> acceptable to everyone?

I don't really understand the purpose of the "unconfirmed" state other than
to create additional bugspam and bureaucracy.

A _constant_ issue in Bugzilla is that a bug is filed and then nobody
comments on it or does any follow-up with the bug filer until _years_ later.
This is the problem that I think you're trying to address? I'm still not
quite sure, but I'll assume it is. I don't see how adding more drop-down
menu options and layers of process is going to help mitigate the underlying
issue. The solution is to respond to bugs in a more timely manner with
comments and follow-up and attempts to illicit steps to reproduce.

MZMcBride



___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[MediaWiki-CodeReview] [MediaWiki r113916]: Revision status changed

[MediaWiki Mail]

"Siebrand" changed the status of MediaWiki.r113916 to "fixme"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113916

Old status:  new
New status: fixme

Commit summary for MediaWiki.r113916:

AFTv5: sync commit, readded i18n msgs etc.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r113953]: New comment added

[MediaWiki Mail]

"Bsitu" posted a comment on MediaWiki.r113953.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113953#c32228

Commit summary for MediaWiki.r113953:

fix for bug 35245 - add rate limiter and spam filter check

Bsitu's comment:

Moodbar code would not re-set the value of these two global variables, the 
error message may reference them.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Re: [Wikitech-l] Re-introducing "UNCONFIRMED" state to bugzilla

[Mark A. Hershberger]

Rob Lanphier  writes:

> Mark and I just discussed this, and he's going to look into having a
> "CONFIRMED" state.

https://bugzillaupdate.wordpress.com/2010/07/06/bugzilla-4-0-has-a-new-default-status-workflow/

describes this implementation:

 UNCONFIRMED -> CONFIRMED -> IN_PROGRESS -> RESOLVED -> VERIFIED

Since "UNCONFIRMED" is used so many places, I'm worried about changing
that to "NEW".

Bugzilla 4 should have had this upgrade script run when it was
installed.

Does this workflow (+ changing all "NEW" to "UNCONFIRMED") look
acceptable to everyone?

Mark.

-- 
Mark A. Hershberger
Bugmeister
Wikimedia Foundation
m...@wikimedia.org

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[MediaWiki-CodeReview] [MediaWiki r113953]: New comment added

[MediaWiki Mail]

"Reedy" posted a comment on MediaWiki.r113953.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113953#c32227

Commit summary for MediaWiki.r113953:

fix for bug 35245 - add rate limiter and spam filter check

Reedy's comment:

One criticism:


+/** Rate limit setting for moodbar **/
255 +$wgMoodBarFeedbackRateLimit = 300;
256 +$wgMoodBarResponseRateLimit = 60;
257 +$wgRateLimits += array( 
258 +   'moodbar-feedback' => array( 'user' => array( 1 => 
$wgMoodBarFeedbackRateLimit ) ),
259 +   'moodbar-response' => array( 'user' => array( 1 => 
$wgMoodBarResponseRateLimit ) )
260 +   );


Changing either $wgMoodBarFeedbackRateLimit or $wgMoodBarResponseRateLimit 
after including Moodbar is going to make no difference.

Do we just pass them by reference, or kill them completely, and just use 
something like the below to override it if they want to?


$wgRateLimits['moodbar-feedback'] = array( 'user' => array( 1 => 5000 ) );


___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r113953]: New comment added

[MediaWiki Mail]

"Reedy" posted a comment on MediaWiki.r113953.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113953#c32226

Commit summary for MediaWiki.r113953:

fix for bug 35245 - add rate limiter and spam filter check

Reedy's comment:

Looks fine to me. Just need someone to review the JS, then we can push it live 
and re-enable Moodbar

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r113972]: New comment added

[MediaWiki Mail]

"Catrope" posted a comment on MediaWiki.r113972.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113972#c32225

Commit summary for MediaWiki.r113972:

Fix ClickTracking URLs for the edit links so the title is added to those too

Catrope's comment:

This is essentially an MFT of r113718, which I didn't discover until after 
committing this.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r113938]: Revision status changed

[MediaWiki Mail]

"MaxSem" changed the status of MediaWiki.r113938 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113938

Old status:  new
New status: ok

Commit summary for MediaWiki.r113938:

MFT r113171

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r113940]: Revision status changed

[MediaWiki Mail]

"MaxSem" changed the status of MediaWiki.r113940 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113940

Old status:  new
New status: ok

Commit summary for MediaWiki.r113940:

MFT r112586, r112930, r113352, r113926

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r113074]: Revision status changed

[MediaWiki Mail]

"Aaron Schulz" changed the status of MediaWiki.r113074 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113074

Old status:  new
New status: ok

Commit summary for MediaWiki.r113074:

remove stub file -- unneeded as it's been expanded into other files

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r113973]: Revision status changed

[MediaWiki Mail]

"MaxSem" changed the status of MediaWiki.r113973 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113973

Old status:  new
New status: ok

Commit summary for MediaWiki.r113973:

MFT r113971

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r113971]: Revision status changed

[MediaWiki Mail]

"Preilly" changed the status of MediaWiki.r113971 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113971

Old status:  new
New status: ok

Commit summary for MediaWiki.r113971:

Fix for bug 35249, makes disable mobile version confirmation page properly 
redirect after confirmation

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Re: [Wikitech-l] First steps at making MobileFrontend usable beyond the WMF infrastructure

[Brion Vibber]

On Thu, Mar 15, 2012 at 2:29 PM, Arthur Richards wrote:

> Asher and I just had a chat in #wikimedia-mobile. We agreed to have the
> Squids handle the new cookie in the same way they handle the old
> 'stopMobileRedirect' cookie (rather than add back the old
> 'permanently disable mobile view' functionality). I'm going to also make
> some minor tweaks to how things get handled in MobileFrontend, but it will
> essentially behave the same way described earlier. This will allow us to
> move forward with the simplified mobile/desktop view switching and continue
> making the MobileFrontend code less WMF-centric. Thanks again, Asher!
>

\o/ awesome! :D

-- brion
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[MediaWiki-CodeReview] [MediaWiki r113948]: New comment added

[MediaWiki Mail]

"Reedy" posted a comment on MediaWiki.r113948.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113948#c32224

Commit summary for MediaWiki.r113948:

Not sure why we're doing a LIKE query against what are going to be exact 
template names.

Re-running this way gives sensible amounts of results - 21 on enwiki, just over 
6000 on itwiki, not seemingly iterating over more pages than the wiki has..

Then running RefreshLinks::fixLinksFromArticle( '1234' ) clears it off the list

Reedy's comment:

I used tl_from as an offset in r113964

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r113948]: New comment added

[MediaWiki Mail]

"Catrope" posted a comment on MediaWiki.r113948.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113948#c32223

Commit summary for MediaWiki.r113948:

Not sure why we're doing a LIKE query against what are going to be exact 
template names.

Re-running this way gives sensible amounts of results - 21 on enwiki, just over 
6000 on itwiki, not seemingly iterating over more pages than the wiki has..

Then running RefreshLinks::fixLinksFromArticle( '1234' ) clears it off the list

Catrope's comment:

I mean fix the infinite loop issue so the script will pick up rows like 
"DEFAULTSORT:foobar" too.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Re: [Wikitech-l] API requests on Wikimedia wikis

[MZMcBride]

Tomasz Finc wrote:
> We already have an article on this :
> http://www.mediawiki.org/wiki/API:Etiquette.

Aha! Thanks. :-)  I would have never thought to look for the page at that
title or with that keyword. It's an awfully clever page title, in my
opinion.

Your changes to the navigation sidebar look good. I also just made an edit
that basically throws a few more keywords into the front page for people
quickly searching the page (with ctrl/cmd-F):
.

Thanks again for the link. I figured it had to be somewhere on mediawiki.org
already, but it wasn't coming to me last night.

MZMcBride



___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[MediaWiki-CodeReview] [MediaWiki r113948]: New comment added

[MediaWiki Mail]

"Reedy" posted a comment on MediaWiki.r113948.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113948#c3

Commit summary for MediaWiki.r113948:

Not sure why we're doing a LIKE query against what are going to be exact 
template names.

Re-running this way gives sensible amounts of results - 21 on enwiki, just over 
6000 on itwiki, not seemingly iterating over more pages than the wiki has..

Then running RefreshLinks::fixLinksFromArticle( '1234' ) clears it off the list

Reedy's comment:

Fix in what way? Delete?

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r113934]: Revision status changed

[MediaWiki Mail]

"SPQRobin" changed the status of MediaWiki.r113934 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113934

Old status:  new
New status: ok

Commit summary for MediaWiki.r113934:

Move RELEASE-NOTES after merging r111647 into 1.19 in r113933

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r113933]: Revision status changed

[MediaWiki Mail]

"SPQRobin" changed the status of MediaWiki.r113933 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113933

Old status:  new
New status: ok

Commit summary for MediaWiki.r113933:

MFT r111647

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r113932]: Revision status changed

[MediaWiki Mail]

"SPQRobin" changed the status of MediaWiki.r113932 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113932

Old status:  new
New status: ok

Commit summary for MediaWiki.r113932:

MFT r111647

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r111647]: New comment added

[MediaWiki Mail]

"SPQRobin" posted a comment on MediaWiki.r111647.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111647#c32221

Commit summary for MediaWiki.r111647:

(Bug 31417) Content-holding div needs an ID.
Since the introduction of the class mw-content-ltr/rtl, it has been used to get 
the page text which is very bad because there are two class names and it is not 
always on the same place (if at all). This ID will always hold the bodytext 
(excluding categories, ArticleFeedback, ...).

SPQRobin's comment:

I see you did so already.. that's even better I suppose :)

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r113948]: New comment added

[MediaWiki Mail]

"Catrope" posted a comment on MediaWiki.r113948.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113948#c32220

Commit summary for MediaWiki.r113948:

Not sure why we're doing a LIKE query against what are going to be exact 
template names.

Re-running this way gives sensible amounts of results - 21 on enwiki, just over 
6000 on itwiki, not seemingly iterating over more pages than the wiki has..

Then running RefreshLinks::fixLinksFromArticle( '1234' ) clears it off the list

Catrope's comment:

Aha. So let's fix that, then, as opposed to ignoring broken rows that don't 
exactly match a magic word synonym?

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r113911]: Revision status changed

[MediaWiki Mail]

"Amire80" changed the status of MediaWiki.r113911 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113911

Old status:  new
New status: ok

Commit summary for MediaWiki.r113911:

Cleanup the Mymr font directory- remove svg font(Does not work), remove unused 
fonts
Recreate the WOFF files
Add TharLon font
Ref Bug 34817

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r113948]: New comment added

[MediaWiki Mail]

"Reedy" posted a comment on MediaWiki.r113948.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113948#c32219

Commit summary for MediaWiki.r113948:

Not sure why we're doing a LIKE query against what are going to be exact 
template names.

Re-running this way gives sensible amounts of results - 21 on enwiki, just over 
6000 on itwiki, not seemingly iterating over more pages than the wiki has..

Then running RefreshLinks::fixLinksFromArticle( '1234' ) clears it off the list

Reedy's comment:

Oh, it's getting into an infinite loop..

As it's doing small queries, if it doesn't process any of the 50, it'll start 
pulling the same 50 next time..

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Re: [Wikitech-l] First steps at making MobileFrontend usable beyond the WMF infrastructure

[Arthur Richards]

Asher and I just had a chat in #wikimedia-mobile. We agreed to have the
Squids handle the new cookie in the same way they handle the old
'stopMobileRedirect' cookie (rather than add back the old
'permanently disable mobile view' functionality). I'm going to also make
some minor tweaks to how things get handled in MobileFrontend, but it will
essentially behave the same way described earlier. This will allow us to
move forward with the simplified mobile/desktop view switching and continue
making the MobileFrontend code less WMF-centric. Thanks again, Asher!

On Thu, Mar 15, 2012 at 1:47 PM, Arthur Richards wrote:

> On second thought - Asher, shouldn't setting the 'Vary' header to 'Cookie'
> be sufficient to prevent cache pollution/fragmentation? MobileFrontend
> already does this. If, however, that is it not the case, would it be
> possible to configure the squids to respond to the 'mf_useformat=desktop'
> cookie in the same way they currently respond to 'stopMobileDirect'?
>
> From my developer perspective, I would prefer to not have to add the
> 'permanently disable mobile frontend' functionality back into
> MobileFrontend in the way it had previously existed as it will increase
> code complexity and keep WMF-centric functionality in what would otherwise
> be an agnostic extension.
>
>
> On Thu, Mar 15, 2012 at 12:52 PM, Arthur Richards  > wrote:
>
>> This is blocked on migrating text from squid to varnish which is likely at
>>>  least a few months off.  Until then, MobileFrontend needs to continue
>>> supporting the current production reality.
>>
>>
>> Asher, thanks for the response. I didn't realize the functionality was so
>> crucial. I'll go ahead and add it back in for now - however I'll probably
>> slightly change how things work so the functionality in mobileRedirect.php
>> is included in the extension itself.
>>
>> --
>> Arthur Richards
>> Software Engineer, Mobile
>> [[User:Awjrichards]]
>> IRC: awjr
>> +1-415-839-6885 x6687
>>
>>
>
>
> --
> Arthur Richards
> Software Engineer, Mobile
> [[User:Awjrichards]]
> IRC: awjr
> +1-415-839-6885 x6687
>
>


-- 
Arthur Richards
Software Engineer, Mobile
[[User:Awjrichards]]
IRC: awjr
+1-415-839-6885 x6687
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[MediaWiki-CodeReview] [MediaWiki r113948]: New comment added

[MediaWiki Mail]

"Reedy" posted a comment on MediaWiki.r113948.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113948#c32218

Commit summary for MediaWiki.r113948:

Not sure why we're doing a LIKE query against what are going to be exact 
template names.

Re-running this way gives sensible amounts of results - 21 on enwiki, just over 
6000 on itwiki, not seemingly iterating over more pages than the wiki has..

Then running RefreshLinks::fixLinksFromArticle( '1234' ) clears it off the list

Reedy's comment:

Right...

In the original case, on abwiki (for example)


mysql> select count(*) from templatelinks;
+--+
| count(*) |
+--+
| 6046 |
+--+
1 row in set (0.00 sec

mysql> select count(*) from templatelinks where tl_namespace='10';
+--+
| count(*) |
+--+
| 5945 |
+--+

1 row in set (0.00 sec)

mysql> select count(*) from page;
+--+
| count(*) |
+--+
| 2871 |
+--+



But when the original script was running against the wiki, it had apparently 
processed over 800,000 pages (see [[Special:Code/MediaWiki/104758#c32132]]). 
Which is total rubbish

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r113956]: Revision status changed

[MediaWiki Mail]

"Khorn (WMF)" changed the status of MediaWiki.r113956 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113956

Old status:  new
New status: ok

Commit summary for MediaWiki.r113956:

Disabling GlobalCollect credit card forms temporarily

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r113679]: Revision status changed

[MediaWiki Mail]

"Pgehres (WMF)" changed the status of MediaWiki.r113679 to "deferred"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113679

Old status:  new
New status: deferred

Commit summary for MediaWiki.r113679:

MFT r113677

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r113858]: Revision status changed

[MediaWiki Mail]

"Catrope" changed the status of MediaWiki.r113858 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113858

Old status:  new
New status: ok

Commit summary for MediaWiki.r113858:

bug 35106 - adding | and rev id after rest of tracking items

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r113939]: New comment added

[MediaWiki Mail]

"Siebrand" posted a comment on MediaWiki.r113939.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113939#c32217

Commit summary for MediaWiki.r113939:

* r113886: use  instead of span to wrap element that has p tags.
* Also fixed an older instance of the same problem.

Siebrand's comment:

I think there is something like wrapWikiMsg you can use to make these one 
liners.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Re: [Wikitech-l] First steps at making MobileFrontend usable beyond the WMF infrastructure

[Arthur Richards]

On second thought - Asher, shouldn't setting the 'Vary' header to 'Cookie'
be sufficient to prevent cache pollution/fragmentation? MobileFrontend
already does this. If, however, that is it not the case, would it be
possible to configure the squids to respond to the 'mf_useformat=desktop'
cookie in the same way they currently respond to 'stopMobileDirect'?

>From my developer perspective, I would prefer to not have to add the
'permanently disable mobile frontend' functionality back into
MobileFrontend in the way it had previously existed as it will increase
code complexity and keep WMF-centric functionality in what would otherwise
be an agnostic extension.


On Thu, Mar 15, 2012 at 12:52 PM, Arthur Richards
wrote:

> This is blocked on migrating text from squid to varnish which is likely at
>> least a few months off.  Until then, MobileFrontend needs to continue
>> supporting the current production reality.
>
>
> Asher, thanks for the response. I didn't realize the functionality was so
> crucial. I'll go ahead and add it back in for now - however I'll probably
> slightly change how things work so the functionality in mobileRedirect.php
> is included in the extension itself.
>
> --
> Arthur Richards
> Software Engineer, Mobile
> [[User:Awjrichards]]
> IRC: awjr
> +1-415-839-6885 x6687
>
>


-- 
Arthur Richards
Software Engineer, Mobile
[[User:Awjrichards]]
IRC: awjr
+1-415-839-6885 x6687
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[MediaWiki-CodeReview] [MediaWiki r107350]: New comment added

[MediaWiki Mail]

"Duplicatebug" posted a comment on MediaWiki.r107350.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107350#c32216

Commit summary for MediaWiki.r107350:

[mediawiki.api] write mediawiki.api.watch module
* add mediawiki.api.watch module
* mediawiki.api.parse.js: remove 'data && ' check to match the other modules. 
If data is not good, then the internal error handler will have already handled 
it and never call the ok-callback in the first place.
* mw.Api.errors: adding error codes by ApiWatch.php

Duplicatebug's comment:

Using 1 for boolean parameter in api is bad (unwatch=1) because that 
indicates, that 0 means false, but that is not right. Use an empty string and 
save that byte. (The equal sign is necessary, because sometimes (most in post 
requests) without the equal sign the parameter is not recognised by the api)

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r113922]: New comment added

[MediaWiki Mail]

"Duplicatebug" posted a comment on MediaWiki.r113922.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113922#c32215

Commit summary for MediaWiki.r113922:

Bug 35051 - [Regression] If heading has a trailing space after == then its name 
is not preloaded into edit summary on section edit. Regression from r105380.

Duplicatebug's comment:

HTML comments are also valid after headers, when the (\n|$) is 
removed, the old behaviour is back and should not make more bad things than 
before.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r113948]: New comment added

[MediaWiki Mail]

"Duplicatebug" posted a comment on MediaWiki.r113948.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113948#c32214

Commit summary for MediaWiki.r113948:

Not sure why we're doing a LIKE query against what are going to be exact 
template names.

Re-running this way gives sensible amounts of results - 21 on enwiki, just over 
6000 on itwiki, not seemingly iterating over more pages than the wiki has..

Then running RefreshLinks::fixLinksFromArticle( '1234' ) clears it off the list

Duplicatebug's comment:

Because the templatelinks table can contains rows with INT:Lang, where 
INT: is the synonym.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Re: [Wikitech-l] First steps at making MobileFrontend usable beyond the WMF infrastructure

[Arthur Richards]

>
> This is blocked on migrating text from squid to varnish which is likely at
> least a few months off.  Until then, MobileFrontend needs to continue
> supporting the current production reality.


Asher, thanks for the response. I didn't realize the functionality was so
crucial. I'll go ahead and add it back in for now - however I'll probably
slightly change how things work so the functionality in mobileRedirect.php
is included in the extension itself.

-- 
Arthur Richards
Software Engineer, Mobile
[[User:Awjrichards]]
IRC: awjr
+1-415-839-6885 x6687
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[MediaWiki-CodeReview] [MediaWiki r113946]: Revision status changed

[MediaWiki Mail]

"Raymond" changed the status of MediaWiki.r113946 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113946

Old status:  new
New status: ok

Commit summary for MediaWiki.r113946:

Fix typos.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Re: [Wikitech-l] First steps at making MobileFrontend usable beyond the WMF infrastructure

[Asher Feldman]

On Thu, Mar 15, 2012 at 12:10 PM, Brion Vibber  wrote:

>
> Let's please kill the m. domain.
>
> IMO desktop and mobile users should use the same URLs; there should be sane
> device detection; and an easy override in both directions available at all
> times.
>

This is blocked on migrating text from squid to varnish which is likely at
least a few months off.  Until then, MobileFrontend needs to continue
supporting the current production reality.
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] First steps at making MobileFrontend usable beyond the WMF infrastructure

[Brion Vibber]

On Thu, Mar 15, 2012 at 12:05 PM, Asher Feldman wrote:

> Replacing this with a "desktop view" that leaves users permanently
> accessing the desktop site via m. isn't suitable for our environment.  It
> may make sense for smaller sites without a dedicated mobile namespace but
> even in that case, some care is needed to ensure that any frontend caching
> dosen't get inadvertently polluted or unduly fragmented.
>

Let's please kill the m. domain.

IMO desktop and mobile users should use the same URLs; there should be sane
device detection; and an easy override in both directions available at all
times.

-- brion
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] First steps at making MobileFrontend usable beyond the WMF infrastructure

[Asher Feldman]

On Wed, Mar 14, 2012 at 5:08 PM, Arthur Richards wrote:

> To follow up on this, I actually made some additional changes to how
> "useformat" works to simplify manually switching between mobile and desktop
> views which had been suggested by Brion Vibber. Take a look at:
> https://www.mediawiki.org/wiki/Special:Code/MediaWiki/113865
>
> This removes the "Permanently disable mobile view" text (broken for anyone
> other than the WMF anyway) and makes it so accessing the site with
> "useformat=mobile" in the URL (eg by clicking 'Mobile view' at the bottom
> of any page on a site with MobileFrontend enabled) will set a cookie which
> will ensure that you see the mobile view until either the cookie expires or
> you explicitly switch back to desktop view.
>

It looks like "permanently disable mobile view" is broken completely as of
last weeks mobilefrontend deployment.  So its impossible to see how its
supposed to behave currently, but a key part of it for wikipedia is that it
takes you off the m site and disables squid's mobile redirection via the
"stopMobileRedirect=true" cookie.  It actually disables use of the .m. site
as the text implies, not just disabling the mobilefrontend dom rewrite that
you get when viewing the desktop version of a single article, which keeps
you on the mobile site.

Replacing this with a "desktop view" that leaves users permanently
accessing the desktop site via m. isn't suitable for our environment.  It
may make sense for smaller sites without a dedicated mobile namespace but
even in that case, some care is needed to ensure that any frontend caching
dosen't get inadvertently polluted or unduly fragmented.
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Re-introducing "UNCONFIRMED" state to bugzilla

[Michael Movchin]

Like this idea!
+1

-- mmovchin (Michael Movchin)


Am 15.03.2012 19:29, schrieb Rob Lanphier:

Mark and I just discussed this, and he's going to look into having a
"CONFIRMED" state.  The flow would be:

"NEW"->"CONFIRMED"

...rather than:
"UNCONFIRMED"->"NEW"

That would also mean that all of the currently "NEW" bugs are presumed
to be unconfirmed rather than confirmed, and that we can have a
relatively clean list of bugs that someone explicitly declared to be
confirmed.

Rob

On Fri, Mar 9, 2012 at 5:16 PM, Mark A. Hershberger  wrote:

I set up Bugzilla today so that, by default, bugs would be in the
"UNCONFIRMED" state.

Next week, I plan to begin recruiting volunteers for the "Bug Squad",
who will help me to verify bugs by testing them against the Beta
cluster.  The plan is that the Bug Squad will be able to verify these
bugs and change them to the "NEW" state.

The Bug Squad idea comes from KDE's Bug Squad
(http://techbase.kde.org/Contribute/Bugsquad) and I've begun talking
with them.

If you have an interest in helping out with or participating in the Bug
Squad, please contact me.

--
Mark A. Hershberger
Bugmeister
Wikimedia Foundation
m...@wikimedia.org

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l


___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[MediaWiki-CodeReview] [MediaWiki r113942]: Revision status changed

[MediaWiki Mail]

"Preilly" changed the status of MediaWiki.r113942 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113942

Old status:  new
New status: ok

Commit summary for MediaWiki.r113942:

first version of references reveal

see design:
http://www.mediawiki.org/wiki/Mobile_design/Reference_reveal

this is only made available for the beta

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r113900]: Revision status changed

[MediaWiki Mail]

"Preilly" changed the status of MediaWiki.r113900 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113900

Old status:  new
New status: ok

Commit summary for MediaWiki.r113900:

style search results for full screen search

this completes the first iteration of
http://www.mediawiki.org/wiki/Mobile_design/Full-screen_search

add box shadow to search box when active
use css transitions to fade into full screen search
move results element to under search form

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r113899]: Revision status changed

[MediaWiki Mail]

"Preilly" changed the status of MediaWiki.r113899 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113899

Old status:  new
New status: ok

Commit summary for MediaWiki.r113899:

follow up to r113898

add missing semicolon

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r113898]: Revision status changed

[MediaWiki Mail]

"Preilly" changed the status of MediaWiki.r113898 to "resolved"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113898

Old status:  fixme
New status: resolved

Commit summary for MediaWiki.r113898:

restyle header

following design @
http://www.mediawiki.org/wiki/Mobile_design/Full-screen_search
increase margin of content/header
change icons for close search and clear search

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r113898]: Revision status changed

[MediaWiki Mail]

"Preilly" changed the status of MediaWiki.r113898 to "fixme"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113898

Old status:  new
New status: fixme

Commit summary for MediaWiki.r113898:

restyle header

following design @
http://www.mediawiki.org/wiki/Mobile_design/Full-screen_search
increase margin of content/header
change icons for close search and clear search

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r113898]: New comment added

[MediaWiki Mail]

"Preilly" posted a comment on MediaWiki.r113898.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113898#c32213

Commit summary for MediaWiki.r113898:

restyle header

following design @
http://www.mediawiki.org/wiki/Mobile_design/Full-screen_search
increase margin of content/header
change icons for close search and clear search

Preilly's comment:

Missing a semicolon in 
trunk/extensions/MobileFrontend/stylesheets/beta_common.css in the  #searchbox 
{... section.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r113897]: Revision status changed

[MediaWiki Mail]

"Preilly" changed the status of MediaWiki.r113897 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113897

Old status:  new
New status: ok

Commit summary for MediaWiki.r113897:

adjust utils tests

there are some side effects with the old tests
sometimes causing them to fail
this makes them past consistently

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r113887]: Revision status changed

[MediaWiki Mail]

"Preilly" changed the status of MediaWiki.r113887 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113887

Old status:  new
New status: ok

Commit summary for MediaWiki.r113887:

* Abstracted cookie expiration time handling to its own method
* Added unit tests for cookie expiration time handling method as well as 
getUseFormat()
* Wanted to add further unit tests around cookie handling, but I cannot get 
PHPUnit playing nicely with cookies. At first it was causing header issues 
until prielly suggested disabling output buffereing for the test method, which 
quieted the errors. However, setcookie() seems to have actual effect in the 
tests (see commented out tests in this commit). Open to suggestions :)

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r113885]: Revision status changed

[MediaWiki Mail]

"Preilly" changed the status of MediaWiki.r113885 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113885

Old status:  new
New status: ok

Commit summary for MediaWiki.r113885:

remove trailing whitespace on operamini.css

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r113883]: Revision status changed

[MediaWiki Mail]

"Preilly" changed the status of MediaWiki.r113883 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113883

Old status:  new
New status: ok

Commit summary for MediaWiki.r113883:

add cursor pointer for section headings

make it clear you can click these

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r113882]: Revision status changed

[MediaWiki Mail]

"Preilly" changed the status of MediaWiki.r113882 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113882

Old status:  new
New status: ok

Commit summary for MediaWiki.r113882:

remove autocomplete from search results

it was discussed that although we'd like this in future
at the moment whilst the search is only a title search
this doesn't make much sense so removing

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Re: [Wikitech-l] Re-introducing "UNCONFIRMED" state to bugzilla

[Rob Lanphier]

Mark and I just discussed this, and he's going to look into having a
"CONFIRMED" state.  The flow would be:

"NEW"->"CONFIRMED"

...rather than:
"UNCONFIRMED"->"NEW"

That would also mean that all of the currently "NEW" bugs are presumed
to be unconfirmed rather than confirmed, and that we can have a
relatively clean list of bugs that someone explicitly declared to be
confirmed.

Rob

On Fri, Mar 9, 2012 at 5:16 PM, Mark A. Hershberger  wrote:
>
> I set up Bugzilla today so that, by default, bugs would be in the
> "UNCONFIRMED" state.
>
> Next week, I plan to begin recruiting volunteers for the "Bug Squad",
> who will help me to verify bugs by testing them against the Beta
> cluster.  The plan is that the Bug Squad will be able to verify these
> bugs and change them to the "NEW" state.
>
> The Bug Squad idea comes from KDE's Bug Squad
> (http://techbase.kde.org/Contribute/Bugsquad) and I've begun talking
> with them.
>
> If you have an interest in helping out with or participating in the Bug
> Squad, please contact me.
>
> --
> Mark A. Hershberger
> Bugmeister
> Wikimedia Foundation
> m...@wikimedia.org
>
> ___
> Wikitech-l mailing list
> Wikitech-l@lists.wikimedia.org
> https://lists.wikimedia.org/mailman/listinfo/wikitech-l

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[MediaWiki-CodeReview] [MediaWiki r113881]: Revision status changed

[MediaWiki Mail]

"Preilly" changed the status of MediaWiki.r113881 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113881

Old status:  new
New status: ok

Commit summary for MediaWiki.r113881:

correct viewport resetting

viewport should be set for anything that can support it
not just iphone/ipad (palm pre for example)
also when we do reset it make sure we reset to the initial
value

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r113880]: Revision status changed

[MediaWiki Mail]

"Preilly" changed the status of MediaWiki.r113880 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113880

Old status:  new
New status: ok

Commit summary for MediaWiki.r113880:

redefine toggle behaviour

this rewrites the tests to describe toggle behaviour
in terms of classes rather than visibility

in beta we use height:0 and overflow:hidden instead of
display:none so we can make use of transitions to
animate expanding/collapsing

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r113830]: Revision status changed

[MediaWiki Mail]

"Preilly" changed the status of MediaWiki.r113830 to "resolved"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113830

Old status:  new
New status: resolved

Commit summary for MediaWiki.r113830:

allow search to be triggered on a blur and submit event

hitting enter in a search box should trigger a search
for javascript enabled browsers - not redirect to the
search results page

also some browsers (opera mini) do not support keyup
event so providing blur fallback

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r113781]: Revision status changed

[MediaWiki Mail]

"Preilly" changed the status of MediaWiki.r113781 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113781

Old status:  new
New status: ok

Commit summary for MediaWiki.r113781:

Moved all the basic HTML reformatting routines to a base class

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r113778]: Revision status changed

[MediaWiki Mail]

"Preilly" changed the status of MediaWiki.r113778 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113778

Old status:  new
New status: ok

Commit summary for MediaWiki.r113778:

Bumping CSS version

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r113771]: Revision status changed

[MediaWiki Mail]

"Preilly" changed the status of MediaWiki.r113771 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113771

Old status:  new
New status: ok

Commit summary for MediaWiki.r113771:

Bumping CSS version

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r113695]: Revision status changed

[MediaWiki Mail]

"Preilly" changed the status of MediaWiki.r113695 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113695

Old status:  new
New status: ok

Commit summary for MediaWiki.r113695:

follow up to r113644#c32093

package up configuration into a single global config variable

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r113466]: Revision status changed

[MediaWiki Mail]

"Preilly" changed the status of MediaWiki.r113466 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113466

Old status:  new
New status: ok

Commit summary for MediaWiki.r113466:

remove placeholder code in favour of placeholder attribute

for browsers that don't support this attribute it would make
more sense to provide a generic solution if this is in fact
needed

see http://www.quirksmode.org/html5/inputs_mobile.html#t13

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r113645]: Revision status changed

[MediaWiki Mail]

"Preilly" changed the status of MediaWiki.r113645 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113645

Old status:  new
New status: ok

Commit summary for MediaWiki.r113645:

update toggle.js to use message function introduced

introduced in r113644

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r113644]: Revision status changed

[MediaWiki Mail]

"Preilly" changed the status of MediaWiki.r113644 to "resolved"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113644

Old status:  fixme
New status: resolved

Commit summary for MediaWiki.r113644:

add locale global for handling languages and message function

for the benefit of the phonegap app

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r113642]: Revision status changed

[MediaWiki Mail]

"Preilly" changed the status of MediaWiki.r113642 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113642

Old status:  new
New status: ok

Commit summary for MediaWiki.r113642:

follow up to r113640

this adds toggle.js and drops the beta prefix for
application.js

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r113640]: Revision status changed

[MediaWiki Mail]

"Preilly" changed the status of MediaWiki.r113640 to "resolved"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113640

Old status:  new
New status: resolved

Commit summary for MediaWiki.r113640:

separate toggle code from application, remove beta_application

this separates all toggling related code so that it is more
self contained and better for consumption by the phonegap app
which makes use of it.

during this refactoring I noticed that application.js is
actually the same as beta_application.js so I have removed
the latter to make the project easier to maintain.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r113474]: Revision status changed

[MediaWiki Mail]

"Preilly" changed the status of MediaWiki.r113474 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113474

Old status:  new
New status: ok

Commit summary for MediaWiki.r113474:

Plugged MobileFrontend's excerpts into OpenSearchXml

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r113756]: Revision status changed

[MediaWiki Mail]

"Siebrand" changed the status of MediaWiki.r113756 to "new"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113756

Old status:  fixme
New status: new

Commit summary for MediaWiki.r113756:

Follow-up r113594: Update export.php so that when using gettext post processing 
switch ppgettext, definitionFile is no longer required.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r113460]: Revision status changed

[MediaWiki Mail]

"Preilly" changed the status of MediaWiki.r113460 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113460

Old status:  new
New status: ok

Commit summary for MediaWiki.r113460:

Killed with fire  where possible

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Re: [Wikitech-l] API requests on Wikimedia wikis

[Tomasz Finc]

On Wed, Mar 14, 2012 at 9:30 PM, Tim Starling  wrote:
> On 15/03/12 15:17, MZMcBride wrote:
>> Hi.
>>
>> I occasionally get asked about what a reasonable rate for querying the API
>> of a Wikimedia wiki is for a particular script or tool. I don't really know
>> the answer other than "be reasonable" and "specify an informative
>> User-Agent." That's essentially what I said when asked here:
>> https://meta.wikimedia.org/w/index.php?title=Tech&diff=3569658&oldid=3569474
>>
>> If there's an authoritative answer (on Meta-Wiki or mediawiki.org or even
>> wikitech), that'd obviously be ideal. I'd also settle for a mailing list
>> post. I looked at  to see if
>> it mentioned "limit" or "rate", but nothing came up. It's a fairly common
>> question; it should probably be a bit easier to find.
>>
>> MZMcBride
>
> When people ask me that question, I tell them to limit the
> concurrency, not the request rate. You can't do much damage with a
> single thread, whether queries complete in 10ms or 10s. But you can
> certainly do a lot of damage if you send a query once per second that
> takes 100 seconds to complete, using 100 concurrent clients.
>
> This is especially relevant for people who write toolserver scripts
> and the like. It's easy to write a server-side script which
> accidentally allows 100 concurrent connections to Wikimedia, when 100
> people happen to use it at once, or if someone decides to try a DoS
> attack using the toolserver as a proxy.
>
> -- Tim Starling
>
>
> ___
> Wikitech-l mailing list
> Wikitech-l@lists.wikimedia.org
> https://lists.wikimedia.org/mailman/listinfo/wikitech-l

We already have an article on this :
http://www.mediawiki.org/wiki/API:Etiquette.

Looks like it captures Tim's point about slamming us with concurrency.
For those that regularly get asked about this ... what's missing from
it and how can we make it more discoverable? Currently its linked from
the front of the API page.

I changed the text slightly from 'Etiquette' to 'Etiquette & Usage
Limits' so that its a quicker find. Updates as needed.

--tomasz

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[MediaWiki-CodeReview] [MediaWiki r113439]: Revision status changed

[MediaWiki Mail]

"Preilly" changed the status of MediaWiki.r113439 to "resolved"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113439

Old status:  new
New status: resolved

Commit summary for MediaWiki.r113439:

Makes useformat=mobile sticky with a cookie. Changese 
ExtMobileFrontend::useFormat to protected var accessible with get/set methods. 
Updated tests to reflect changes

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r113672]: Revision status changed

[MediaWiki Mail]

"Preilly" changed the status of MediaWiki.r113672 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113672

Old status:  new
New status: ok

Commit summary for MediaWiki.r113672:

wurfl-2.3.1.zip

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r113901]: Revision status changed

[MediaWiki Mail]

"Preilly" changed the status of MediaWiki.r113901 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113901

Old status:  new
New status: ok

Commit summary for MediaWiki.r113901:

font size tweaks

increase default font size
reduce footer size for normal mobile version

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r113902]: Revision status changed

[MediaWiki Mail]

"Preilly" changed the status of MediaWiki.r113902 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113902

Old status:  new
New status: ok

Commit summary for MediaWiki.r113902:

Refactoring

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r113903]: Revision status changed

[MediaWiki Mail]

"Preilly" changed the status of MediaWiki.r113903 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113903

Old status:  new
New status: ok

Commit summary for MediaWiki.r113903:

fix iphone styling

these rules are now redundant

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r113904]: Revision status changed

[MediaWiki Mail]

"Preilly" changed the status of MediaWiki.r113904 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113904

Old status:  new
New status: ok

Commit summary for MediaWiki.r113904:

Lower the limit due to worst-case performance concerns. OpenSearchXml will 
generate its fast but inaccurate extracts for the remaining pages, while 
geosearch will not need more.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r113937]: Revision status changed

[MediaWiki Mail]

"Preilly" changed the status of MediaWiki.r113937 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113937

Old status:  new
New status: ok

Commit summary for MediaWiki.r113937:

Avoid a DOM parse when it's not needed

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Re: [Wikitech-l] integrating who's been awsome to MediaWiki

[John Du Hart]

You do realize you've been making posts on a public mailing list right?
On Mar 15, 2012 1:06 PM, "Eranga Mapa"  wrote:

> Hi Sumanah
> Still I did not hear from James
> Can you look into this matter.
> When can I get a space to host my extension in Git??
> ___
> Wikitech-l mailing list
> Wikitech-l@lists.wikimedia.org
> https://lists.wikimedia.org/mailman/listinfo/wikitech-l
>
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[MediaWiki-CodeReview] [MediaWiki r113886]: Revision status changed

[MediaWiki Mail]

"Aaron Schulz" changed the status of MediaWiki.r113886 to "new"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113886

Old status:  fixme
New status: new

Commit summary for MediaWiki.r113886:

Add error css to errors like the other file operation pages and actions

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r113487]: New comment added

[MediaWiki Mail]

"Saper" posted a comment on MediaWiki.r113487.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113487#c32212

Commit summary for MediaWiki.r113487:

Handle PostgreSQL transaction errors and improve schema detection

* Introduce $wgDebugDBTransactions facility to help
  figure out what's going on with transactions.
  Currently PostgreSQL only.

  PostgresTransactionState can be easily be made more general
  to trace all sorts of state machinery.

* Improve r113408: we don't need to full reconnect on error,
  rollback is enough.

  Rolling back breaks search_path, as PostgreSQL
  can manage sessions settings under transaction therefore
  we need to improve schema sniffing introduced in r82674

* Introduce few schema handling functions. This could
  probably be generalized for other databases like DB2 and Oracle.

* Fix bug 15816 - Add a switch for SETting the search_path

  We try to avoid touching search_path at all unless
  really necessary. Even in this case we append MediaWiki
  core schema to the front of the list.

* No longer add $wgDBmwschema to PostgreSQL role search_path
  in the installer. This is no longer necessary as
  setting schema on connect should ReallyWorkNow(tm).

* Get rid as much as possible of $wgDBmwschema and
  bring us one step closer to fix bug 16794 (wgSharedDB
  support).

  All references to core MediaWiki schema in PostgreSQL
  specific code should now use Database::getCoreSchema()
  unless we know what we are doing.

Followup-To: r113408 r82674

Saper's comment:

Issues fixed by followup edits. 

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r113487]: New comment added

[MediaWiki Mail]

"Saper" posted a comment on MediaWiki.r113487.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113487#c32211

Commit summary for MediaWiki.r113487:

Handle PostgreSQL transaction errors and improve schema detection

* Introduce $wgDebugDBTransactions facility to help
  figure out what's going on with transactions.
  Currently PostgreSQL only.

  PostgresTransactionState can be easily be made more general
  to trace all sorts of state machinery.

* Improve r113408: we don't need to full reconnect on error,
  rollback is enough.

  Rolling back breaks search_path, as PostgreSQL
  can manage sessions settings under transaction therefore
  we need to improve schema sniffing introduced in r82674

* Introduce few schema handling functions. This could
  probably be generalized for other databases like DB2 and Oracle.

* Fix bug 15816 - Add a switch for SETting the search_path

  We try to avoid touching search_path at all unless
  really necessary. Even in this case we append MediaWiki
  core schema to the front of the list.

* No longer add $wgDBmwschema to PostgreSQL role search_path
  in the installer. This is no longer necessary as
  setting schema on connect should ReallyWorkNow(tm).

* Get rid as much as possible of $wgDBmwschema and
  bring us one step closer to fix bug 16794 (wgSharedDB
  support).

  All references to core MediaWiki schema in PostgreSQL
  specific code should now use Database::getCoreSchema()
  unless we know what we are doing.

Followup-To: r113408 r82674

Saper's comment:

Issues fixed by followup edits. 

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r113408]: New comment added

[MediaWiki Mail]

"Saper" posted a comment on MediaWiki.r113408.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113408#c32210

Commit summary for MediaWiki.r113408:

PostgreSQL: Improve SQL error handling

After a query error, PostgreSQL transaction is aborted
until it's terminated or the query is closed.

All further queries result in:

  ERROR: current transaction is aborted, commands ignored
  until end of transaction block

Those subsequent errors are ignored by double fault handling in
DatabaseBase::reportQueryError but they cause all localization
of error messages to fail (unable to issue queries to message
tables) and errors lke


This resulted in a broken MediaWiki screen with

  
  

instead of localized error message.

We need to fully reset database connection because after
pg_connection_reset() various session parameters need to
be set again (like "search_path"), otherwise tables will not be
found.

   ERROR: relation "msg_resource" does not exist
   ERROR:  relation "l10n_cache" does not exist

Saper's comment:

All issues so far resolved, now moving on to fix rest of PostgresUpdater 
problems.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r113926]: Revision status changed

[MediaWiki Mail]

"Reedy" changed the status of MediaWiki.r113926 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113926

Old status:  new
New status: ok

Commit summary for MediaWiki.r113926:

Bug 35242 - invalid CSS in ext.wikihiero.css. Haven't used the patch from that 
bug as it's wrong.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r113892]: Revision status changed

[MediaWiki Mail]

"Reedy" changed the status of MediaWiki.r113892 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113892

Old status:  new
New status: ok

Commit summary for MediaWiki.r113892:

Fixed 'Illegal string offset 'LIMIT' in 
C:\wamp\www\MediaWiki\includes\db\Database.php on line 1462'

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[Wikitech-l] integrating who's been awsome to MediaWiki

[Eranga Mapa]

Hi Sumanah
Still I did not hear from James
Can you look into this matter.
When can I get a space to host my extension in Git??
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[MediaWiki-CodeReview] [MediaWiki r111647]: New comment added

[MediaWiki Mail]

"Reedy" posted a comment on MediaWiki.r111647.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111647#c32209

Commit summary for MediaWiki.r111647:

(Bug 31417) Content-holding div needs an ID.
Since the introduction of the class mw-content-ltr/rtl, it has been used to get 
the page text which is very bad because there are two class names and it is not 
always on the same place (if at all). This ID will always hold the bodytext 
(excluding categories, ArticleFeedback, ...).

Reedy's comment:

Should this go into 1.19 aswell?

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r113737]: New comment added

[MediaWiki Mail]

"Reedy" posted a comment on MediaWiki.r113737.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113737#c32208

Commit summary for MediaWiki.r113737:

User:PleaseStand patch fixes bug 34972

Reedy's comment:

Bah, that didn't display how I wanted to...

Just copy in the title line from Bugzilla, makes reviewing a bit easier as then 
you don't need to click through to the bug in all cases :)

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r113737]: New comment added

[MediaWiki Mail]

"Reedy" posted a comment on MediaWiki.r113737.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113737#c32207

Commit summary for MediaWiki.r113737:

User:PleaseStand patch fixes bug 34972

Reedy's comment:

Also, it's useful if you copy in the bug title aswell to the commit message.

Just copying the title line, e.g. Bug 34972 - [Regression] An error 
occurred while changing your watchlist settings for 
[[Special:WhatLinksHere/Example]]

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview