Re: configure.ac: Do not pass "-fPIC" to mingw for "make crosstest"

[Detlef Riekenberg]

On Mi, 2006-09-13 at 15:23 +0200, Detlef Riekenberg wrote:
> When we do a "make crosstest" with mingw32msvc-gcc,
> the compiler give a warning about "-fPIC" 
> 
> 
> Changelog:
> - configure.ac: Do not pass "-fPIC" to mingw for "make crosstest"
> 
> 
> Changes for configure are not included.
> I crosscompiled the tests, dlls and programs and it still works.
> 

Please ignoge this patch.

There are more gcc-only flags, that we use without checking


-- 
 
By by ... Detlef

Re: cabinet: Add breaks to switch statements

[Andrew Talbot]

Dimi Paun wrote:

> 
> On Wed, September 13, 2006 1:18 pm, Dan Kegel wrote:
>> Offhand that looks like a more serious change than you thought.
>> You'd better either really understand the code, or
>> add a conformance test that shows this fixes a bug, IMHO.
> 
> Agreed. But that is confusing code, it should have a /* fallthrough */
> comment instead of the break statement if that was the intent.
> 

And I shall humbly learn to properly check how code works before "fixing"
it, in future. :) Thanks, Dan and Dimi, for your helpful comments.

-- Andy.

Re: cabinet: Add breaks to switch statements

[Dimi Paun]

On Wed, September 13, 2006 1:18 pm, Dan Kegel wrote:
> Offhand that looks like a more serious change than you thought.
> You'd better either really understand the code, or
> add a conformance test that shows this fixes a bug, IMHO.

Agreed. But that is confusing code, it should have a /* fallthrough */
comment instead of the break statement if that was the intent.

-- 
Dimi Paun <[EMAIL PROTECTED]>
Lattica, Inc.

Re: cabinet: Add breaks to switch statements

[Dan Kegel]

On 9/13/06, Andrew Talbot <[EMAIL PROTECTED]> wrote:

On Wednesday 13 September 2006 04:22, you wrote:
> Does adding the breaks fix conformance tests?

No, I haven't fixed anything with this patch: it was a neutral one, in that
respect. I just put it in because I perceived that those switch statements
were not relying on any fallthrough, so I thought it good practice to isolate
the cases.


Let's see: your change was

--- a/dlls/cabinet/fci.c2006-09-12 11:55:48.0 +0100
+++ b/dlls/cabinet/fci.c2006-09-12 23:29:02.0 +0100
@@ -454,11 +454,12 @@
  switch (cb % 4) {
case 3:
  ul |= (((ULONG)(*pb++)) << 16);
+  break;
case 2:
  ul |= (((ULONG)(*pb++)) <<  8);
+  break;
case 1:
  ul |= *pb++;
-default:
  break;
  }

Offhand that looks like a more serious change than you thought.
You'd better either really understand the code, or
add a conformance test that shows this fixes a bug, IMHO.
- Dan

Re: [PATCH] PATCH: kernel 2.6 in README.de

[Jan Zerebecki]

On Wed, Sep 13, 2006 at 09:57:13PM +0930, n0dalus wrote:
> Many people have their mail clients configured to filter emails
> into folders based on 'To:' fields, so it would be great if you
> could sort that out (your last few ones, such as this one,
> ended up in my inbox instead of my wine folder).

You could filter on "List-Post: " .
(Yes there should be a proper To field, but this way it would be
more reliable for you regardless how people send their mail.)


Jan

Re: Low-level coding

[hendric]

Hi,Slunt
Hmm as my thought you'd better read something about windows kernel 
technology. If you got difficult in assembly , which I thought the very 
low-level coding you refered to , to have a look at books about assembly maybe 
the best choice. But I still think windows kernel technology should be most 
important.
Cheers!
--   
hendric
2006-09-13

-
发件人：Aaron Slunt
发送日期：2006-09-11 08:01:07
[EMAIL PROTECTED]
抄送：
主题：Low-level coding

Hi,

I was interested in starting to play with wine and maybe even build a few
functions for it...but then I realized that it's low-level coding, something
I'm not familiar with (higher level is more of my expertise). Correct me if
I'm wrong, I could be looking at the wrong files :S. Does anyone  have any
good places to go to to learn about low-level coding, and afterwards coding
for wine specifically?

Thanks.

-- 
Tired of being hammered by spyware, or want to browse the internet in a
whole new way? Download Firefox and enjoy a much better internet experience.
http://getfirefox.com/

Re: cabinet: Add breaks to switch statements

[H. Verbeet]

On 13/09/06, Andrew Talbot <[EMAIL PROTECTED]> wrote:

Changelog:
cabinet: Add breaks to switch statements.

diff -urN a/dlls/cabinet/fci.c b/dlls/cabinet/fci.c
--- a/dlls/cabinet/fci.c2006-09-12 11:55:48.0 +0100
+++ b/dlls/cabinet/fci.c2006-09-12 23:29:02.0 +0100
@@ -454,11 +454,12 @@
   switch (cb % 4) {
 case 3:
   ul |= (((ULONG)(*pb++)) << 16);
+  break;
 case 2:
   ul |= (((ULONG)(*pb++)) <<  8);
+  break;
 case 1:
   ul |= *pb++;
-default:
   break;
   }
   csum ^= ul;
diff -urN a/dlls/cabinet/fdi.c b/dlls/cabinet/fdi.c
--- a/dlls/cabinet/fdi.c2006-05-23 13:47:35.0 +0100
+++ b/dlls/cabinet/fdi.c2006-09-12 23:29:13.0 +0100
@@ -302,9 +302,15 @@
   }

   switch (bytes & 3) {
-  case 3: ul |= *data++ << 16;
-  case 2: ul |= *data++ <<  8;
-  case 1: ul |= *data;
+  case 3:
+  ul |= *data++ << 16;
+  break;
+  case 2:
+  ul |= *data++ <<  8;
+  break;
+  case 1:
+  ul |= *data;
+  break;
   }
   csum ^= ul;


I think that's supposed to fall through.

Re: [PATCH] PATCH: kernel 2.6 in README.de

[Marcus Meissner]

On Wed, Sep 13, 2006 at 09:57:13PM +0930, n0dalus wrote:
> On Wed Sep 13 10:57:33 2006 +0200, Marcus Meissner
> <[EMAIL PROTECTED]> wrote:
> >Mention kernel 2.6.
> >
> >---
> >
> > documentation/README.de |2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> >10857c3dbb8429ea599288ac93f4cecd8ffeff59
> 
> Hi,
> 
> A few of the emails you've sent to the wine-patches mailing list
> lately have not had 'To:' headers. Many people have their mail clients
> configured to filter emails into folders based on 'To:' fields, so it
> would be great if you could sort that out (your last few ones, such as
> this one, ended up in my inbox instead of my wine folder). It probably
> means that whatever program you are using to send these emails is
> broken slightly.
> 
> I hope you are able to work it out,

Its git-format-patch, I just bounce the mails ... 

LIkely I need to invest time to understand git patch submission better.

Ciao, Marcus

Re: RTL language support in usp.dll

[Jeff Latimer]

Vijay Kiran Kamuju wrote:


Hi,

Your patch for RTL support in usp10.dll.
http://www.winehq.org/pipermail/wine-patches/2006-September/030571.html

Only includes support for Arabic.
If you could include for other RTL languages esp Hebrew (other RTL
languages are Farsi and Urdu).
I think that would be an easy task for you as you know the usp 
internals. ;)


bye,
VJ



Recognising them as I have Arabic won't be much of a problem.  The real 
fun starts when looking at how to implement the support script for 
correct formatting and layout.


Jeff

Re: [PATCH] PATCH: kernel 2.6 in README.de

[n0dalus]

On Wed Sep 13 10:57:33 2006 +0200, Marcus Meissner
<[EMAIL PROTECTED]> wrote:

Mention kernel 2.6.

---

 documentation/README.de |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

10857c3dbb8429ea599288ac93f4cecd8ffeff59
diff --git a/documentation/README.de b/documentation/README.de
index c4a1324..680e077 100644
--- a/documentation/README.de
+++ b/documentation/README.de
@@ -45,7 +45,7 @@ Linux-Info:
   Obwohl Linux 2.2.x immer noch funktionieren sollte und Linux 2.0.x
   vielleicht auch noch funktioniert (ältere 2.0.x-Versionen verzeichneten
   Abstürze im Zusammenhang mit Threads), sollte man am besten einen
-  aktuellen Kernel wie 2.4.x verwenden.
+  aktuellen Kernel wie 2.4.x oder 2.6.x verwenden.

 FreeBSD-Info:
   Stellen Sie sicher, dass Sie die Optionen USER_LDT, SYSVSHM, SYSVSEM und
--
1.2.4





Hi,

A few of the emails you've sent to the wine-patches mailing list
lately have not had 'To:' headers. Many people have their mail clients
configured to filter emails into folders based on 'To:' fields, so it
would be great if you could sort that out (your last few ones, such as
this one, ended up in my inbox instead of my wine folder). It probably
means that whatever program you are using to send these emails is
broken slightly.

I hope you are able to work it out,
n0dalus.

Re: Find out which handle corresponds to which window

[David Gümbel]

Hi Dmitry,


..thanks for looking into this!

On Wednesday 13 September 2006 12:10, Dmitry Timoshkov wrote:
> "David Gümbel" <[EMAIL PROTECTED]> wrote:
> > Sure ;-) http://bugs.winehq.org/show_bug.cgi?id=6191
>
> What's your screen resolution and WM? Are you using Wine from
> today's Git or any other version?

I'm using 0.9.20 under KDE (=> kwin) 3.5.4.

David


pgpCZVUVux9al.pgp
Description: PGP signature

Re: resend: tools[1/2]: wineprefixcreate: create a freedesktop-enabled menu directory

[Alexandre Julliard]

Mikołaj Zalewski <[EMAIL PROTECTED]> writes:

> When creating the wineprefix, create a directory for the menu and a
> configuration file that enables this menu in the freedesktop.org menu
> structure. As suggested on wine-devel the menu directory is a
> subdirectory of ~/.wine, so if the user deletes it, all menu items
> created there will be automatically removed.
>
> Is there something wrong with this patch?

That sort of desktop-specific code does not belong in
wineprefixcreate. I'm not really convinced that this approach to menus
is correct, but even if it is, it should be handled by wineshelllink
and friends.

-- 
Alexandre Julliard
[EMAIL PROTECTED]

Re: Find out which handle corresponds to which window

[Dmitry Timoshkov]

"David Gümbel" <[EMAIL PROTECTED]> wrote:


Sure ;-) http://bugs.winehq.org/show_bug.cgi?id=6191


What's your screen resolution and WM? Are you using Wine from
today's Git or any other version?

--
Dmitry. 

Re: riched20: move some selection code from message handler to ME_SetSelection

[Alexandre Julliard]

"Matt Finnicum" <[EMAIL PROTECTED]> writes:

> The special cases handled by EM_EXSETSEL should also be handled by
> EM_SETSEL, so this patch moves that code into the common
> ME_SetSelection function. Before this patch, sending EM_SETSEL with
> any value less than -1 would crash richedit.
>
> Changelog: move some selection code from message handlers to ME_SetSelection

This fails make test:

../../../tools/runtest -q -P wine -M riched20.dll -T ../../.. -p 
riched20_test.exe.so editor.c && touch editor.ok
editor.c:1335: Test failed: EM_EXSETSEL: expected: 18 actual: 17
make: *** [editor.ok] Error 1

-- 
Alexandre Julliard
[EMAIL PROTECTED]

Re: Find out which handle corresponds to which window

[David Gümbel]

Hi Dmitry,

On Wednesday 13 September 2006 10:38, Dmitry Timoshkov wrote:
> "David Gümbel" <[EMAIL PROTECTED]> wrote:
> > In order to verify or falsify my guess, it would be extremely helpful
> > to find out which handle corresponds to the window showing the symtoms.
> > I've tried my luck with Process Explorer, but that tool doesn't show me
> > the information I need.
>
> Could you upload a +win log somewhere on the net, and provide a
> description what is going on?

Sure ;-) http://bugs.winehq.org/show_bug.cgi?id=6191

David


pgp8gE4oykpUI.pgp
Description: PGP signature

Re: Find out which handle corresponds to which window

[Dmitry Timoshkov]

"David Gümbel" <[EMAIL PROTECTED]> wrote:


In order to verify or falsify my guess, it would be extremely helpful to
find out which handle corresponds to the window showing the symtoms. I've
tried my luck with Process Explorer, but that tool doesn't show me the
information I need.


Could you upload a +win log somewhere on the net, and provide a description
what is going on?

--
Dmitry. 

Find out which handle corresponds to which window

[David Gümbel]

Hi,



- I'm almost sure that question has been asked here before, but I can't seem 
to find the corresponding post: I am trying to debug an application (Net 
Support Manager) that has trouble displaying a window in fullscreen mode. 
NSM enables you (among other things) to remotely look onto somebody else's 
Desktop, a bit like VNC or NX. 

It's quite annoying not to be able to look onto that remote desktop in 
fullscreen mode. Anyway, my guess is that it tries to put itself on top of 
everything in a wierd way that does not work properly under wine.

In order to verify or falsify my guess, it would be extremely helpful to 
find out which handle corresponds to the window showing the symtoms. I've 
tried my luck with Process Explorer, but that tool doesn't show me the 
information I need.

Any help is greatly appreciated.


Cheers,



David


pgpJNKUR0iQLI.pgp
Description: PGP signature