Re: Vijay Kiran Kamuju : comctl32: MonthCalendar - Fixhighlightingof current date.
"Vijay Kiran Kamuju" <[EMAIL PROTECTED]> wrote: What do we need to setup, if we want a test framework for messages in comctl32 similar to user32? Some kind of a message queue is needed and a mechanism to check what has been gathered with an expected sequence. I'd suggest to not invent a wheel and copy existing parts from dlls/user32/tests/msg.c. -- Dmitry.
Re: Vijay Kiran Kamuju : comctl32: MonthCalendar - Fix highlightingof current date.
Hi, It might be because of the MULTISELECT style not being set. Can you please test with the MULTISELECT set? In the older version of the control spy test its set by default, and in the new version its not set. Can you please test that and also test by applying the other patch as well? Currently I am tidying it up and putting some comments. As the order of messages sent is a bit messed up. Dimitry: What do we need to setup, if we want a test framework for messages in comctl32 similar to user32? Lei and Dan, This can also be a good exercise. But I will try to do it myself first. Cheers, VJ On 12/27/06, Dmitry Timoshkov <[EMAIL PROTECTED]> wrote: "Lei Zhang" <[EMAIL PROTECTED]> wrote: >I see the problem Duane reports as well. As long as you stay with in > the current month, the current day will remain highlighted even if you > click another date. It will disappear if you (a) highlight the current > date, then another date, or (b) if you go to another month. > > On 12/26/06, Vijay Kiran Kamuju <[EMAIL PROTECTED]> wrote: >> Hi, >> >> It did it for me. when I did the tests. >> I will check again. >> Currently I am out of net access for atleast 2 weeks. >> Shifting to a new room(hostel). >> So I will test it soon, please bear with me, and also please test with >> my other patch(month calander one). May be I should leave that for >> Dan's students. >> But I will fix it as this is my bug, anyways. Since 2 independent persons do see that the patch has caused a regression, and it's not going to be fixed in a reasonable amount of time, I'd suggest to revert that patch as an obviously wrong then. -- Dmitry.
Re: WGL: fix wglGetProcAddress bug
Vitaly just pointed out that the previous version added some extra spaces. This
one fixes that.
Roderick
> Hi,
>
> This patch fixes a nasty wglGetProcAddress bug. In case the name of an
> unknown GL extension (one which is not in wine yet) was passed to
> wglGetProcAddress it was assumed that it was a WGL extension.
>
> WGL extensions are in the end looked up in winex11.drv. The
> wglGetProcAddress function in winex11.drv can return WGL extensions but it
> can also
> return native GL functions. This ability is used in order to fill the opengl32
> thunks (win32 GL -> native GL).
>
> The problem was that unknown extensions were also passed to the
> winex11.drv code. This resulted that code to look up a native GL functions
> (the
> winex11.drv code returns wgl extensions if the function name starts with 'wgl'
> and else it calls glXGetProcAddress).
>
> In the end this patch makes sure that only functions which start with a
> 'w' are passed to the winex11.drv code in the other cases a warning is
> printed that the function wasn't found.
>
> Regards,
> Roderick Colenbrander
--
Der GMX SmartSurfer hilft bis zu 70% Ihrer Onlinekosten zu sparen!
Ideal für Modem und ISDN: http://www.gmx.net/de/go/smartsurfer
Index: dlls/opengl32/wgl.c
===
RCS file: /home/wine/wine/dlls/opengl32/wgl.c,v
retrieving revision 1.114
diff -u -r1.114 wgl.c
--- dlls/opengl32/wgl.c 12 Dec 2006 20:30:35 - 1.114
+++ dlls/opengl32/wgl.c 28 Dec 2006 00:04:38 -
@@ -223,6 +223,9 @@
TRACE("(%s)\n", lpszProc);
+ if(lpszProc == NULL);
+return NULL;
+
/* First, look if it's not already defined in the 'standard' OpenGL functions */
if ((local_func = GetProcAddress(opengl32_handle, lpszProc)) != NULL) {
TRACE(" found function in 'standard' OpenGL functions (%p)\n", local_func);
@@ -234,10 +237,14 @@
ext_ret = (const OpenGL_extension *) bsearch(&ext, extension_registry,
extension_registry_size, sizeof(OpenGL_extension), compar);
- /* If nothing was found, we are looking for a WGL extension */
+ /* If nothing was found, we are looking for a WGL extension or an unknown GL extension. */
if (ext_ret == NULL) {
-WARN("Extension '%s' not defined in opengl32.dll's function table!\n", lpszProc);
-return wine_wgl.p_wglGetProcAddress(lpszProc);
+/* If the function name starts with a w it is a WGL extension */
+if(lpszProc[0] == 'w')
+ return wine_wgl.p_wglGetProcAddress(lpszProc);
+
+/* We are dealing with an unknown GL extension. */
+WARN("Extension '%s' not defined in opengl32.dll's function table!\n", lpszProc);
} else { /* We are looking for an OpenGL extension */
/* Check if the GL extension required by the function is available */
Re: kernel32 console bug?
On 21.12.2006 21:28, Eric Pouech wrote: > perhaps ShellExecute is supposed to create a console when calling > CreateProcess for CUI subprocesses (this should be tested) Or CreateProcess() itself creates the console window. -f.r.
Re: Bug 50
Hi Pedro, Suppose the user asks for (on average) 5.5 pixels per space. At the moment wine is using 5 pixels per space, and then tacking on all the remaining .5 pixels at the end of the line. The correct answer would be to use 5 pixels in half the spaces, and 6 in the other half. This is essentially doing pulse width modulation (PWM) on the space sizes, and you can probably find algorithms for doing this on the Internet. However, I think wine is storing the wrong information in the hDC. From what I remember, wine is storing the average number of pixels per space, and the number of pixels left over. This isn't enough, because you need to know how many spaces the "left over" pixels are to be distributed over. -- Keith --- "Pedro Araújo Chaves Jr." <[EMAIL PROTECTED]> wrote: > I've been trying to get the lpDx array to be properly calculated, but > unfortunately to no avail. I did find, though, that GetTextExtentExPointW is > never called with a maxExt value other than zero, and thus nfit is not > calculated. > > Regarding that, would any of you know where I should look for the proper > method of calculating the maximum width (maxExt) of a formatted string? I'm > somewhat puzzled... neither lprect nor dc->BoundsRect seem to hold the > proper values for getting that value [1], or (more likely, I guess) I'm just > looking at it the wrong way. > > Btw, I'd add that I've been testing this in Lotus Notes R5, just in case it > helps, and no, I haven't found a link to download a trial. [2] [3] > > Cheers, > Pedro. > > [1] I'm investigating the SetTextJustification, ExtTextOutW, > GetTextExtentPointW, GetTextExtentPoint32W, GetTextExtentExPointW, and > WineEngGetTextExtentExPoint functions from gdi32 (the latter in freetype.c, > the rest in font.c). I am yet to look into their *I counterparts, where > applicable. > > [2] http://appdb.winehq.org/viewbugs.php?bug_id=50 > > [3] http://bugs.winehq.org/show_bug.cgi?id=7016 > > > __ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com
Re: Bug 50
Followup: you can download Lotus trial versions here: http://www.ibm.com/developerworks/lotus/downloads/ Hope this helps. Regards, Pedro.
Re: adding a data point to ALSA vs Wine sound discussion
Hi, On Tue, Dec 26, 2006 at 03:41:56AM +0100, Molle Bestefich wrote: > Adding a data point to the ALSA and Wine sound discussion. That data point unfortunately doesn't contain the ALSA version number, thus it's almost useless ;) Andreas Mohr
Re: Bug 50
I've been trying to get the lpDx array to be properly calculated, but unfortunately to no avail. I did find, though, that GetTextExtentExPointW is never called with a maxExt value other than zero, and thus nfit is not calculated. Regarding that, would any of you know where I should look for the proper method of calculating the maximum width (maxExt) of a formatted string? I'm somewhat puzzled... neither lprect nor dc->BoundsRect seem to hold the proper values for getting that value [1], or (more likely, I guess) I'm just looking at it the wrong way. Btw, I'd add that I've been testing this in Lotus Notes R5, just in case it helps, and no, I haven't found a link to download a trial. [2] [3] Cheers, Pedro. [1] I'm investigating the SetTextJustification, ExtTextOutW, GetTextExtentPointW, GetTextExtentPoint32W, GetTextExtentExPointW, and WineEngGetTextExtentExPoint functions from gdi32 (the latter in freetype.c, the rest in font.c). I am yet to look into their *I counterparts, where applicable. [2] http://appdb.winehq.org/viewbugs.php?bug_id=50 [3] http://bugs.winehq.org/show_bug.cgi?id=7016
Re: make test failure
"Kai Blin" <[EMAIL PROTECTED]> wrote: Well, both emulate virtual desktop and managed windows are both ticked. It's impossible to have managed windows in a virtual Wine desktop. I switched off the desktop emulation and reran the tests, giving me the following errors: msg.c:8624: Test failed: 15: ShowWindow(SW_HIDE): in msg 0x0046 expecting wParam 0x93 got 0x83 msg.c:8624: Test failed: 15: ShowWindow(SW_HIDE): in msg 0x0047 expecting wParam 0x1893 got 0x1883 This is on xorg [EMAIL PROTECTED], KDE 3.5.1 That one also fails for me, but passes for Alexandre. Wonder if that's another race. Anyway having this only test failing sounds much more reasonable. -- Dmitry.
Re: make test failure
On Wednesday 27 December 2006 05:00, Dmitry Timoshkov wrote: > "Kai Blin" <[EMAIL PROTECTED]> wrote: > > over christmas, I decided to give make test another try. > > > > I'm running this on an openSUSE 10.1 box, ati radeon mobility x300 with > > open source drivers. (Probably unimportant for the errors I'm getting) > > > > My procedure to get the tests setup were: > > > > export WINEPREFIX=~/.wine-test > > rm -rf $WINEPREFIX > > wineprefixcreate > > winecfg (set to emulate virtual desktop, nothing else touched) > > If virtual desktop means not managed windows then that's what broke > the test. Well, both emulate virtual desktop and managed windows are both ticked. I switched off the desktop emulation and reran the tests, giving me the following errors: msg.c:8624: Test failed: 15: ShowWindow(SW_HIDE): in msg 0x0046 expecting wParam 0x93 got 0x83 msg.c:8624: Test failed: 15: ShowWindow(SW_HIDE): in msg 0x0047 expecting wParam 0x1893 got 0x1883 This is on xorg [EMAIL PROTECTED], KDE 3.5.1 Cheers, Kai -- Kai Blin, WorldForge developerhttp://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin/ -- Will code for cotton. pgpRpbzHWg451.pgp Description: PGP signature
Re: ole32: Marshal the ORPCTHAT structure prefixed to the server data.
Dmitry Timoshkov wrote: "Robert Shearman" <[EMAIL PROTECTED]> wrote: +*hook_count = 0; +*extension_count = 0; + +EnterCriticalSection(&csChannelHook); + +LIST_FOR_EACH_ENTRY(entry, &channel_hooks, struct channel_hook_entry, entry) +(*hook_count)++; + +if (hook_count) +*data = HeapAlloc(GetProcessHeap(), 0, *hook_count * sizeof(struct channel_hook_buffer_data)); +else +*data = NULL; Perhaps 'if (hook_count)' should be 'if (*hook_count)' ? Is that a typo? Yes, well spotted. -- Rob Shearman
Re: ole32: Marshal the ORPCTHAT structure prefixed to the server data.
"Robert Shearman" <[EMAIL PROTECTED]> wrote: +*hook_count = 0; +*extension_count = 0; + +EnterCriticalSection(&csChannelHook); + +LIST_FOR_EACH_ENTRY(entry, &channel_hooks, struct channel_hook_entry, entry) +(*hook_count)++; + +if (hook_count) +*data = HeapAlloc(GetProcessHeap(), 0, *hook_count * sizeof(struct channel_hook_buffer_data)); +else +*data = NULL; Perhaps 'if (hook_count)' should be 'if (*hook_count)' ? Is that a typo? -- Dmitry.
Re: oleaut32: Fix failing VarMod tests in WinXP, fix VarMod(VT_DECIMAL) in Wine
Alex Villacís Lasso <[EMAIL PROTECTED]> writes: > BTW, in case nobody knows, the BOOL->BSTR conversion is localized in > WinXP (so that in Spanish locales, conversion to strings gives > "Verdadero", not "True" as tested). Apparently it is *not* localized > in Win98SE. I don't have any other Windows versions available, but > this means at least two test failures on non-English versions of > WinXP. Does this mean that a comparison to a specific string is > pointless and should be removed? It should not be removed, but it can be disabled when the current locale is not English. -- Alexandre Julliard [EMAIL PROTECTED]
Re: Vijay Kiran Kamuju : comctl32: MonthCalendar - Fix highlightingof current date.
"Lei Zhang" <[EMAIL PROTECTED]> wrote: I see the problem Duane reports as well. As long as you stay with in the current month, the current day will remain highlighted even if you click another date. It will disappear if you (a) highlight the current date, then another date, or (b) if you go to another month. On 12/26/06, Vijay Kiran Kamuju <[EMAIL PROTECTED]> wrote: Hi, It did it for me. when I did the tests. I will check again. Currently I am out of net access for atleast 2 weeks. Shifting to a new room(hostel). So I will test it soon, please bear with me, and also please test with my other patch(month calander one). May be I should leave that for Dan's students. But I will fix it as this is my bug, anyways. Since 2 independent persons do see that the patch has caused a regression, and it's not going to be fixed in a reasonable amount of time, I'd suggest to revert that patch as an obviously wrong then. -- Dmitry.
Re: Vijay Kiran Kamuju : comctl32: MonthCalendar - Fix highlighting of current date.
I see the problem Duane reports as well. As long as you stay with in the current month, the current day will remain highlighted even if you click another date. It will disappear if you (a) highlight the current date, then another date, or (b) if you go to another month. On 12/26/06, Vijay Kiran Kamuju <[EMAIL PROTECTED]> wrote: Hi, It did it for me. when I did the tests. I will check again. Currently I am out of net access for atleast 2 weeks. Shifting to a new room(hostel). So I will test it soon, please bear with me, and also please test with my other patch(month calander one). May be I should leave that for Dan's students. But I will fix it as this is my bug, anyways. bye, VJ On 12/26/06, Duane Clark <[EMAIL PROTECTED]> wrote: > Alexandre Julliard wrote: > > Module: wine > > Branch: master > > Commit: c5b8df481f2bb0362b57188a8c7df423030ba8b0 > > URL: http://source.winehq.org/git/wine.git/?a=commit;h=c5b8df481f2bb0362b57188a8c7df423030ba8b0 > > > > Author: Vijay Kiran Kamuju <[EMAIL PROTECTED]> > > Date: Sun Dec 24 13:31:56 2006 +0530 > > > > comctl32: MonthCalendar - Fix highlighting of current date. > > That does highlight the current date on startup. But I notice that when > I click another date, the current date doesn't get unhighlighted. > > >
