Re: New SCSI Driver for Mac OS X
On 4/27/10 8:54 PM, C.W. Betts wrote: > Excuse me, but why is this needed again? What IOCTL is missing in Mac OS X's > native implementation? Do I have to explain everything?! All right. Here goes. Way back in October of last year, I started a discussion on this list about SCSI on Mac OS X: http://www.winehq.org/pipermail/wine-devel/2009-October/079257.html Then AJ objected to the first approach, saying that we really can't require the disk to be unmounted. This leaves option 2. This driver is part of an attempt to implement option 2. In summary: - There's no IOCTL for sending SCSI commands. - There's an API for sending them, but it's unrealistic for Wine. Therefore, we want to use an IOCTL, instead. - To implement an IOCTL, we need a driver. - This driver implements an IOCTL for sending SCSI commands. And don't suggest the SCSITask user client. I already did (as you can see in the linked post). Chip
Re: New SCSI Driver for Mac OS X
Excuse me, but why is this needed again? What IOCTL is missing in Mac OS X's native implementation? On Apr 27, 2010, at 2:10 PM, Charles Davis wrote: > Hi, > > A while ago on this list, I was talking about implementing SCSI support > on Mac OS X in Wine, and we all agreed the best way to do that would be > to have a custom driver that provides an IOCTL interface. > > I've attached the driver (which is now finished) here. I've tested it on > my system, and it works with this small test program that's also > attached. But I want to make sure it's totally stable before I start > working on the Wine side. So if you've got a Mac, and you're feeling > brave, feel free to install my driver and run my test program. > > Extract the archive, then cd to the directory inside: > > tar jxf ExtMediaBSDClient.tar.bz2 > cd ExtMediaBSDClient > > Install the extension to /Library/Extensions: > > cp -r ExtMediaBSDClient.kext /Library/Extensions > > If you're feeling really brave, you can install it to > /System/Library/Extensions (and then it will be loaded on boot): > > cp -r ExtMediaBSDClient.kext /System/Library/Extensions > > The driver bundle has to be owned by root and belong to the wheel group, > so make sure it does before trying to load it: > > sudo chown -R root:wheel /path/to/ExtMediaBSDClient.kext > > You can load the driver with the kextload command: > > kextload /path/to/ExtMediaBSDClient.kext > > You can verify that the driver loaded by running: > > kextstat | grep "ExtMediaBSDClient" > > Once it's loaded, all SCSI disks that are inserted afterward will accept > the IOCTL. All disks that were inserted before won't however. To make > sure a disk is using my driver, run the ioreg tool (it's part of Xcode) > and look for "ExtMediaBSDClient": > > ioreg | grep "ExtMediaBSDClient" > > To test it, run the program 'ExtMediaTest' that I included. Pass it the > filename of a device file for the disk (it should be one of the raw > device files, e.g. /dev/rdisk1 instead of /dev/disk1) on which you want > to test this: > > ./ExtMediaTest /path/to/device/file > > If it works, the program will print some of the INQUIRY data for that > disk to the Terminal. If it doesn't work, it will print an error to the > Terminal (and the driver will have logged something in the kernel log; > see the Console app), or worse, the kernel will panic. (If it says > "Inappropriate ioctl for device", that probably means it's not using my > driver. Try ejecting the disk and reinserting it. And if it says the > device is busy, try the program on one of the slices, e.g. /dev/rdisk1s1 > instead of /dev/rdisk1.) > > If anything goes wrong (error messages, kernel panics, etc.), I want to > know about it. If you get an error, paste the whole error message. If > it's from ExtMediaTest, show me the lines in the kernel log that came > from the driver (they have "ExtMediaBSDClient" or some such in them). If > the kernel panics, attach the panic log. Also, tell me which version of > Mac OS X you're using (so I know which KernelDebugKit to use). > > As soon as I verify that the driver works well, I'm going to start > submitting patches to implement support for it in Wine. > > Chip >
RE: user32: Fix some tests on 2K8R2 and win7
> From: André Hentschel > > Yepp, the bot doesnt compare results with an unpatched state... Actually, it does. It compares the results of patch jobs against the most recent winetest.exe job for the same VM, which in this case would be https://testbot.winehq.org/JobDetails.pl?Key=1749. That job didn't list any failures for the user32:win.c test, which is why the failures produced by the patch are listed as new failures. Of course, it is still possible that this is a false positive, we've seen more differences between individual test runs and winetest.exe runs. BTW, the bot now reports test results back to Alexandre's patch tracker at http://source.winehq.org/patches Ge.
Re: user32: Fix some tests on 2K8R2 and win7
Am 27.04.2010 20:55, schrieb (Marvin): > Hi, > > While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? > Full results can be found at > http://testbot.winehq.org/JobDetails.pl?Key=1768 > > Your paranoid android. > > > === W98SE (32 bit win) === > win.c:2929: Test failed: hwnd 04C4 message 0112 > win.c:2931: Test failed: message 0112 available > win.c:2938: Test failed: hwnd 04C4 message 0100 > win.c:2940: Test failed: message 0100 available > win.c:2952: Test failed: message 000f available > win.c:2964: Test failed: message 000f available > win.c:2973: Test failed: message 000f available > win.c:2982: Test failed: message 000f available Yepp, the bot doesnt compare results with an unpatched state... -- Best Regards, André Hentschel
Re: user32: Fix some tests on 2K8R2 and win7
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=1768 Your paranoid android. === W98SE (32 bit win) === win.c:2929: Test failed: hwnd 04C4 message 0112 win.c:2931: Test failed: message 0112 available win.c:2938: Test failed: hwnd 04C4 message 0100 win.c:2940: Test failed: message 0100 available win.c:2952: Test failed: message 000f available win.c:2964: Test failed: message 000f available win.c:2973: Test failed: message 000f available win.c:2982: Test failed: message 000f available
Re: Slackware download description line updated to latest package binary format
This patch does not apply against the current git tree. Please always submit patches using "git format-patch". Also, it helps if you prefix the subject with [website] so I can tell which patches are meant for the website without scanning the body. -Newman Ing. Simone. Giustetti wrote: Hi all, The download page description for Slackware was updated because someone pointed to me it was not clear if the new txz package format was supported or not. The attached patch contains the updated line for the template in 3 languages. Bye Simone
Re: [3/5] msi/tests: Use a unique product code when testing MsiConfigureFeature parameter validation.
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=1761
Your paranoid android.
=== W7PROX64 (32 bit msi) ===
msi.c:1596: Test failed: Expected C:\imapath, got <à(
msi.c:1615: Test failed: Expected C:\imapath, got <à(
msi.c:1624: Test failed: Expected C:\imapath, got <à(
msi.c:1657: Test failed: Expected C:\imapath, got <à(
msi.c:1676: Test failed: Expected C:\imapath, got <à(
msi.c:1685: Test failed: Expected C:\imapath, got <à(
msi.c:1733: Test failed: Expected C:\imapath, got <à(
msi.c:1752: Test failed: Expected C:\imapath, got <à(
msi.c:1761: Test failed: Expected C:\imapath, got <à(
msi.c:1808: Test failed: Expected C:\imapath, got <à(
msi.c:1817: Test failed: Expected C:\imapath, got <à(
msi.c:1859: Test failed: Expected C:\imapath, got <à(
msi.c:1868: Test failed: Expected C:\imapath, got <à(
msi.c:1965: Test failed: Expected {8BA3F294-2904-42D3-B780-7C569244693E}, got
prod
msi.c:1983: Test failed: Expected {8BA3F294-2904-42D3-B780-7C569244693E}, got
prod
msi.c:1998: Test failed: Expected {8BA3F294-2904-42D3-B780-7C569244693E}, got
prod
msi.c:2013: Test failed: Expected {8BA3F294-2904-42D3-B780-7C569244693E}, got
prod
msi.c:2031: Test failed: Expected {62D87153-CBAE-4699-86D4-C37EEE2A9901}, got
prod
msi.c:2060: Test failed: Expected {8BA3F294-2904-42D3-B780-7C569244693E}, got
prod
msi.c:2078: Test failed: Expected {8BA3F294-2904-42D3-B780-7C569244693E}, got
prod
msi.c:2093: Test failed: Expected {8BA3F294-2904-42D3-B780-7C569244693E}, got
prod
msi.c:2108: Test failed: Expected {8BA3F294-2904-42D3-B780-7C569244693E}, got
prod
msi.c:2126: Test failed: Expected {62D87153-CBAE-4699-86D4-C37EEE2A9901}, got
prod
msi.c:2207: Test failed: Expected {B8311ECD-C0EF-4937-81A1-73E7A63065CD}, got
msi.c:2213: Test failed: Expected {B8311ECD-C0EF-4937-81A1-73E7A63065CD}, got
msi.c:2237: Test failed: Expected {B8311ECD-C0EF-4937-81A1-73E7A63065CD} or
{4DF189B9-4720-46F4-B870-D7B6B32A204E}, got
msi.c:2244: Test failed: Expected {B8311ECD-C0EF-4937-81A1-73E7A63065CD} or
{4DF189B9-4720-46F4-B870-D7B6B32A204E}, got
msi.c:2278: Test failed: Expected {B8311ECD-C0EF-4937-81A1-73E7A63065CD}, got
msi.c:2307: Test failed: Expected {B8311ECD-C0EF-4937-81A1-73E7A63065CD} or
{4DF189B9-4720-46F4-B870-D7B6B32A204E}, got
msi.c:2314: Test failed: Expected {B8311ECD-C0EF-4937-81A1-73E7A63065CD} or
{4DF189B9-4720-46F4-B870-D7B6B32A204E}, got
msi.c:7303: Test failed: Expected "{805BDA38-C6AE-424D-8178-45836DB8D4D3}", got
"C:\winetest\\winetest.msi"
msi.c:7372: Test failed: Expected "{805BDA38-C6AE-424D-8178-45836DB8D4D3}", got
"C:\winetest\\winetest.msi"
msi.c:7439: Test failed: Expected "{805BDA38-C6AE-424D-8178-45836DB8D4D3}", got
"C:\winetest\\winetest.msi"
msi.c:7663: Test failed: Expected "{74818EE1-8A72-4B5E-BD11-2628E1090FDC}", got
"apple"
msi.c:7665: Test failed: Expected "{7ED2C8EE-9E50-42A4-BEDF-E42E1AA119E2}", got
"banana"
msi.c:7724: Test failed: Expected "{7ED2C8EE-9E50-42A4-BEDF-E42E1AA119E2}", got
"banana"
msi.c:7742: Test failed: Expected "{74818EE1-8A72-4B5E-BD11-2628E1090FDC}", got
"apple"
msi.c:7760: Test failed: Expected "{74818EE1-8A72-4B5E-BD11-2628E1090FDC}", got
"apple"
msi.c:7762: Test failed: Expected "{7ED2C8EE-9E50-42A4-BEDF-E42E1AA119E2}", got
"banana"
msi.c:7778: Test failed: Expected "{74818EE1-8A72-4B5E-BD11-2628E1090FDC}", got
"apple"
msi.c:7780: Test failed: Expected "{7ED2C8EE-9E50-42A4-BEDF-E42E1AA119E2}", got
"banana"
msi.c:7797: Test failed: Expected "{74818EE1-8A72-4B5E-BD11-2628E1090FDC}", got
"apple"
msi.c:7799: Test failed: Expected "{7ED2C8EE-9E50-42A4-BEDF-E42E1AA119E2}", got
"banana"
msi.c:7818: Test failed: Expected "{74818EE1-8A72-4B5E-BD11-2628E1090FDC}", got
"apple"
msi.c:7820: Test failed: Expected "{7ED2C8EE-9E50-42A4-BEDF-E42E1AA119E2}", got
"banana"
msi.c:7837: Test failed: Expected "{74818EE1-8A72-4B5E-BD11-2628E1090FDC}", got
"apple"
msi.c:7839: Test failed: Expected "{7ED2C8EE-9E50-42A4-BEDF-E42E1AA119E2}", got
"banana"
msi.c:7955: Test failed: Expected "{74818EE1-8A72-4B5E-BD11-2628E1090FDC}", got
"apple"
msi.c:7957: Test failed: Expected "{7ED2C8EE-9E50-42A4-BEDF-E42E1AA119E2}", got
"banana"
msi.c:8002: Test failed: Expected "{74818EE1-8A72-4B5E-BD11-2628E1090FDC}", got
"apple"
msi.c:8004: Test failed: Expected "{7ED2C8EE-9E50-42A4-BEDF-E42E1AA119E2}", got
"banana"
msi.c:8028: Test failed: Expected "{74818EE1-8A72-4B5E-BD11-2628E1090FDC}", got
"apple"
msi.c:8030: Test failed: Expected "{7ED2C8EE-9E50-42A4-BEDF-E42E1AA119E2}", got
"banana"
msi.c:7663: Test failed: Expected "{44750609-7030-4563-A080-485647446DEE}", got
"apple"
msi.c:7665: Test failed: Expected "{BAC6C3BA-B9D7-4696-BDDE-9A4176BC56A2}", got
"banana"
msi.c:7724: Test failed: Expected "{BAC6C3BA-B9D7-4696-BDDE-9A4176BC56A2}", got
"banana"
msi.c:7742: Te
Re: [1/5] msi/tests: Return INVALID_FILE_SIZE from get_pf_file_size if the file can't be opened.
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=1760 Your paranoid android. === W7PROX64 (32 bit install) === install.c:5279: Test failed: Expected "C:\Program Files (x86)\msitest\maximus", got "Software\Microsoft\Windows\CurrentVersion\Installer\UserData\S-1-5-18\Products\84A88FD7F6998CE40A22FB59F6B9C2BB\InstallProperties" install.c:5298: Test failed: Expected "01\msitest\augustus", got "Software\Microsoft\Windows\CurrentVersion\Installer\UserData\S-1-5-18\Products\84A88FD7F6998CE40A22FB59F6B9C2BB\InstallProperties" install.c:5323: Test failed: Expected "C:\Program Files (x86)\msitest\maximus", got "Software\Microsoft\Windows\CurrentVersion\Installer\UserData\S-1-5-18\Products\84A88FD7F6998CE40A22FB59F6B9C2BB\InstallProperties" install.c:5342: Test failed: Expected "01\msitest\augustus", got "Software\Microsoft\Windows\CurrentVersion\Installer\UserData\S-1-5-18\Products\84A88FD7F6998CE40A22FB59F6B9C2BB\InstallProperties" === W7PROX64 (64 bit install) === install.c:8132: Test failed: RegQueryValueExA failed 2 (0) install.c:8855: Test failed: file not created install.c:8856: Test failed: file not created install.c:8858: Test failed: file not created install.c:8864: Test failed: file removed install.c:8869: Test failed: directory removed install.c:8916: Test failed: key not removed install.c:8926: Test failed: key not removed install.c:8937: Test failed: key not removed install.c:9011: Test failed: got 6 expected 0 install.c:9017: Test failed: got 6 expected 0 install.c:9020: Test failed: got 6 expected 0 install.c:9022: Test failed: file removed install.c:9167: Test failed: key not created === W7PROX64 (64 bit patch) === patch.c:698: Test failed: expected 1000, got 4294967295 patch.c:711: Test failed: expected 1002, got 4294967295
RE: gdi32: "StretchDIBits" with value of zero for "xSrc" and "ySrc"
> From: Wolfram Sang > > > === W98SE (32 bit dib) === > > dib.c:159: Test failed: Bitmap data not matching. > [...] > > === WNT4WSSP6 (32 bit dib) === > > dib.c:159: Test failed: Bitmap data not matching. > Probably 16-bit display depth again? Yes. smime.p7s Description: S/MIME cryptographic signature
Re: [7/9] msi: Implement the UnregisterMIMEInfo standard action.
On Tue, 2010-04-27 at 08:55 +0200, Vincent Pelletier wrote: > Backtrace: > =>0 0x7ecf3750 ACTION_UnregisterMIMEInfo+0x260(package=0x131f00) > [/home/vincent/git/wine/dlls/msi/classes.c:1516] in msi (0x0033f998) > 1 0x7ecda25e ACTION_HandleStandardAction+0x1dd(package=, > action="UnregisterMIMEInfo", rc=0x33f9cc, force=0x0001) > [/home/vincent/git/wine/dlls/msi/action.c:7089] in msi (0x0033f9e8) > > Note: of-by-one line count, as I added a WARN to log mime->Extension value, > which confirms the problem (3rd line): > > warn:msi:ACTION_UnregisterMIMEInfo Unregistering MIME type L"application/pdf" > warn:msi:ACTION_UnregisterMIMEInfo Failed to delete MIME key 2 > warn:msi:ACTION_UnregisterMIMEInfo mime->Extension = (nil) > > I believe the mime->InstallMe condition is too relaxed, as it does check mime- > >Extension, but with || (reindented code, for wordwrap): > > + mime->InstallMe = (mime->InstallMe || > > +(mime->Class && mime->Class->Installed) || > > +(mime->Extension && mime->Extension->Installed)); Well, the Extension_ column of the MIME table is not nullable, so mime->Extension should not be null here. Can you send me the msi file?
Re: [PATCH] Remove variable dbgtext which is not really used frommake_number.
James McKenzie wrote: > Could you help us who are trying to match up what has changed by putting > the module name in braces like this: > > [riched20] > > somewhere in the title? Better to follow a commonly used patch naming convention instead: http://wiki.winehq.org/SubmittingPatches -- Dmitry.
