Re: Moving pages to/from wiki
Thu, Aug 30, 2012 12:23, Michael Stefaniuc wrote: > On 08/30/2012 06:05 PM, Jeremy Newman wrote: >> On 08/29/2012 09:32 PM, Kyle Auble wrote: >>> just checked http://cvs.winehq.org and sure enough, there is still a >>> very outdated CVS repository there, but I can't find a template or a PHP >>> applet for it, just the same links you found (most in WWN issues). I've >>> CCed Jeremy Newman because I'm guessing the site admin would have to >>> remove it. >> >> I am not opposed to removing it. We had left it up as a historical >> archive, or for people that were not ready to switch to GIT yet. If >> there is consensus then I can certainly take it down. > According to Alexandre it is used by http://source.winehq.org/ for the > "Wine Cross Reference". Ahhh, that certainly changes things. Does the server have to run a CVS instance to generate the web interface? If so, and if it's possible to somehow store the CVS data somewhere else, it might not hurt to consolidate it someday. That's really distant, low-priority stuff though. I'll remove the line from the WineHQ Todo list and make a note on the wiki SourceCode page so no one gets confused. - Kyle
Re: Moving pages to/from wiki
Thu, Aug 30, 2012 11:55, André Hentschel wrote: > Am 30.08.2012 04:32, schrieb Kyle Auble: >> As for redirecting to http://www.winehq.org/cvs, since that was designed >> as a notice page for people trying to browse the source code, I was >> picturing just redirecting the links to http://source.winehq.org/git and >> deleting http://www.winehq.org/cvs as only WWN issues and news would >> still have dangling links. I don't want to remove it if there's another >> reason for keeping it though. > please don't remove it. there's still much linking to it on the web, or > hiding links, like in sourcecodes somewhere OK, sounds good. I'll leave the CVS notice pages but update the links. - Kyle
Re: [PATCH 2/5] hhctrl.ocx: Implement HH_SET_WIN_TYPE (try 7).
"Erich E. Hoover" writes:
> @@ -1784,11 +1785,25 @@ void ReleaseHelpViewer(HHInfo *info)
> OleUninitialize();
> }
>
> -HHInfo *CreateHelpViewer(LPCWSTR filename, HWND caller)
> +static BOOL info_in_list(HHInfo *info)
> +{
> +HHInfo *i;
> +
> +LIST_FOR_EACH_ENTRY(i, &window_list, HHInfo, entry)
> +{
> +if(i == info)
> +return TRUE;
> +}
> +return FALSE;
> +}
You should never need that sort of thing.
--
Alexandre Julliard
julli...@winehq.org
Re: kernel32: Add UTF-7 support. (try 4)
Alex Henrie writes:
> +do
> +{
> +if (src[source_index] == 0 && srclen == -1)
> +{
> +if (dry_run) dest_index++; else if (write_to_w_string(dst,
> dstlen, &dest_index, 0)) return -1;
> +/* when srclen=-1, terminate at the first null character found */
> +break;
> +}
> +else if (src[source_index] == '+')
> +{
> +WCHAR byte_pair = 0;
> +short offset = 0;
> +
> +source_index++; /* skip the + sign */
> +
> +if (src[source_index] == '-')
> +{
> +/* just a plus sign escaped as +- */
> +if (dry_run) dest_index++; else if (write_to_w_string(dst,
> dstlen, &dest_index, '+')) return -1;
> +source_index++;
> +continue;
> +}
You are not checking properly for the source string length. Also please
add tests for such cases.
--
Alexandre Julliard
julli...@winehq.org
Re: Moving pages to/from wiki
On 08/30/2012 06:05 PM, Jeremy Newman wrote: > On 08/29/2012 09:32 PM, Kyle Auble wrote: >> just checked http://cvs.winehq.org and sure enough, there is still a >> very outdated CVS repository there, but I can't find a template or a PHP >> applet for it, just the same links you found (most in WWN issues). I've >> CCed Jeremy Newman because I'm guessing the site admin would have to >> remove it. > > I am not opposed to removing it. We had left it up as a historical > archive, or for people that were not ready to switch to GIT yet. If > there is consensus then I can certainly take it down. According to Alexandre it is used by http://source.winehq.org/ for the "Wine Cross Reference". bye michael
Re: Moving pages to/from wiki
Am 30.08.2012 04:32, schrieb Kyle Auble: > As for redirecting to http://www.winehq.org/cvs, since that was designed > as a notice page for people trying to browse the source code, I was > picturing just redirecting the links to http://source.winehq.org/git and > deleting http://www.winehq.org/cvs as only WWN issues and news would > still have dangling links. I don't want to remove it if there's another > reason for keeping it though. please don't remove it. there's still much linking to it on the web, or hiding links, like in sourcecodes somewhere -- Best Regards, André Hentschel
Re: Moving pages to/from wiki
On 08/29/2012 09:32 PM, Kyle Auble wrote: just checked http://cvs.winehq.org and sure enough, there is still a very outdated CVS repository there, but I can't find a template or a PHP applet for it, just the same links you found (most in WWN issues). I've CCed Jeremy Newman because I'm guessing the site admin would have to remove it. I am not opposed to removing it. We had left it up as a historical archive, or for people that were not ready to switch to GIT yet. If there is consensus then I can certainly take it down.
